[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18762] Some tests are noisy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18763] swagger/definitions.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18761] AutomaticItemModificationByAge.t tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18761 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18685] Patron edit/cancel floating toolbar out of place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18752] Automatic item modifications by age should allow 'blank' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Marc Véron changed: What|Removed |Added Attachment #64288|0 |1 is obsolete|| --- Comment #9 from Marc Véron --- Created attachment 64302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64302&action=edit Bug 18786 - Add ability to create custom payment types Some libraries would like to be able to specify more specific payment types such as cash, check, credit card, or even canned food ( for food drives ). This feature will allow a library to specify payment types as authorised values of the type PAYMENT_TYPE. Test Plan: 1) Apply patches 2) Update database 3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card' 4) Go to the fines section of a patron who has several fines 5) Tab 'Fines' 6) Click on 'Pay' for an individual fine 7) Verify that in the form a 'Pay an individual fine' dropdown appears with payment types 8) Select a payment type, confirm payment 9) Verify that payment type appears in "Description of charges" in tab 'Account' Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Marc Véron changed: What|Removed |Added Attachment #64202|0 |1 is obsolete|| --- Comment #7 from Marc Véron --- Created attachment 64300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64300&action=edit Bug 18786 - Update database Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Marc Véron changed: What|Removed |Added Attachment #64203|0 |1 is obsolete|| --- Comment #8 from Marc Véron --- Created attachment 64301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64301&action=edit Bug 18786 - Update schema Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18807] www/batch.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 --- Comment #2 from Jonathan Druart --- Created attachment 64299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64299&action=edit Bug 18807: Fix tests www/batch.t Several things are wrong here: 1. It assumes that import_record_id is the biblionumber => Wrong, it is only true when the DB is empty and that the 2 AI equal 1 2. The encoding in the template is 'UTF-8', not 'utf8', it leaded to "stage-marc-import.pl: marc21record.mrc: Unexpected charset UTF-8, expecting utf8" 3. We did not test that the biblio was correctly imported Test plan: Make sure the tests now pass. For the www tests you need to set the following env vars: KOHA_USER, KOHA_PASS, KOHA_INTRANET_URL and KOHA_OPAC_URL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18807] www/batch.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18807] www/batch.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 Jonathan Druart changed: What|Removed |Added Depends on||18806 --- Comment #1 from Jonathan Druart --- Needs fix from bug 18806. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 [Bug 18806] Cannot revert a batch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18806] Cannot revert a batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 Jonathan Druart changed: What|Removed |Added Blocks||18807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 [Bug 18807] www/batch.t is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it matches new layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Jonathan Druart changed: What|Removed |Added Blocks||18807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 [Bug 18807] www/batch.t is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18807] www/batch.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 Jonathan Druart changed: What|Removed |Added Depends on||16423 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 [Bug 16423] Fix t/db_dependent/www/batch.t so it matches new layout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18807] New: www/batch.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 Bug ID: 18807 Summary: www/batch.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
Lee Jamison changed:
What|Removed |Added
CC||ldjami...@marywood.edu
--- Comment #16 from Lee Jamison ---
The patch and its dependencies applied cleanly and there were no problems when
running updatedatabase.pl. I added/paid fines on accounts but when I click on
the "Details" button of boraccount.pl tailing plack throws the following error
message:
Can't locate object method "search" via package "Koha::Account::Offsets"
(perhaps you forgot to load "Koha::Account::Offsets"?) at
/home/vagrant/kohaclone/members/accountline-details.pl line 52.
Line 52 of accountline-details.pl consists of the following code:
my @account_offsets = Koha::Account::Offsets->search( { $column =>
$accountlines_id } );
The only methods contained in Offsets.pm that are showing for me are:
sub _type {
return 'AccountOffset';
}
sub object_class {
return 'Koha::Account::Offset';
}
Let me know if there appears to be a problem with my test and I will try it
again.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- Tests are missing -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18806] Cannot revert a batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 Jonathan Druart changed: What|Removed |Added Version|17.05 |master See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18329 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18806 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #14 from Jonathan Druart --- Indeed, you are right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18806] Cannot revert a batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18806] Cannot revert a batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 --- Comment #1 from Jonathan Druart --- Created attachment 64298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64298&action=edit Bug 18806: Fix batch revert Since bug 18242: When a biblio is deleted, a new transaction is created. tools/manage-marc-import.pl use the AutoCommit flag, which does not allow nested transaction. AutoCommit must not be used. Test plan: Import a batch, then revert it. The biblios must have been correctly deleted, they were not before this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handled correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What|Removed |Added Blocks||18806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 [Bug 18806] Cannot revert a batch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18806] New: Cannot revert a batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 Bug ID: 18806 Summary: Cannot revert a batch Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 18242 Since bug 18242: When a biblio is deleted, a new transaction is created. tools/manage-marc-import.pl use the AutoCommit flag, which does not allow nested transaction. AutoCommit must not be used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 [Bug 18242] Move of checkouts to old_issues is not handled correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18803] Web installer does not load optional data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18803 Indranil Das Gupta changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Indranil Das Gupta --- *** This bug has been marked as a duplicate of bug 18741 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18741] Web installer does not load default data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741 Indranil Das Gupta changed: What|Removed |Added CC||indr...@l2c2.co.in --- Comment #8 from Indranil Das Gupta --- *** Bug 18803 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall changed: What|Removed |Added Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #1 from Kyle M Hall --- Created attachment 64297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64297&action=edit Bug 18805 - Add ability to use up account credits Right now, in Koha, credits always have a static amount outstanding. So if a patron owes $10 in fines, and has a $10 credit, they technically owe nothing, but yet they still owe $10. This seems rather confusing. Instead, we should add the ability for credits to be used to pay down closed out fines and other fees. Test Plan: 1) Apply this patch and dependencies 2) Create a manual credit of some amount 3) Create a manual invoice 4) Note the manual invoice was automatically paid down using the balance from the manual credit! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall changed: What|Removed |Added Depends on||2696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine Payments Should Show What Was Paid For -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Blocks||18805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Add ability to use up account credits -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 M. Tompsett changed: What|Removed |Added CC||ldjami...@marywood.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #13 from M. Tompsett --- (In reply to Jonathan Druart from comment #11) > (In reply to Marcel de Rooy from comment #10) > > (In reply to Jonathan Druart from comment #8) > > > I do not think the behaviour is correct, C4::SMS::send_sms should just do > > > nothing if the config is missing. > > > > Could be discussed on another report and perhaps solved. At first glance, > > the config seems to be something additional not required. > > This just deals with eliminating a uninit warn. > > Nope, please fix it here. "Any parameters with a leading underscore are considered private driver-specific options and will be passed through without alteration. Any other parameters without a leading underscore will be silently stripped out and not passed through to the driver." (SMS::Send - http://search.cpan.org/~adamk/SMS-Send-1.06/lib/SMS/Send.pm) The configuration file is used to set extraneous parameters based on the driver. It has nothing to do whether sending a message should be attempted or not. In the case of SMS::Send::Test, it won't matter because it is a test driver. In the case of driver where it matters, they may not take extra parameters, so the configuration file is pointless and should be sent. In the case where it matters, and the extra parameters are needed, the sending will fail and the warn $@; return; will be triggered. This patch is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] New: Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Bug ID: 18805 Summary: Add ability to use up account credits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Blocks: 14825 Right now, in Koha, credits always have a static amount outstanding. So if a patron owes $10 in fines, and has a $10 credit, they technically owe nothing, but yet they still owe $10. This seems rather confusing. Instead, we should add the ability for credits to be used to pay down closed out fines and other fees. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Kyle M Hall changed: What|Removed |Added Depends on||18805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Add ability to use up account credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799 --- Comment #9 from Jonathan Druart --- Regarding last comments another signoff is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18685] Patron edit/cancel floating toolbar out of place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18763] swagger/definitions.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18762] Some tests are noisy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart --- Added the signed-off-by lines. Mark I removed your patch, I am not sure if the warning should be displayed. I do not have time to dig into the problem right now and would like to see the other patches pushed. Will see that later. Skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18762] Some tests are noisy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #16 from Jonathan Druart --- Created attachment 64295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64295&action=edit Bug 18762: Remove a warning from History.t Test plan: prove t/db_dependent/Search/History.t should not display any warnings Signed-off-by: Lee Jamison Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18762] Some tests are noisy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #17 from Jonathan Druart --- Created attachment 64296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64296&action=edit Bug 18762: Remove some warnings from Search.t Note that some are caused by CGI, see bug 18632 Test plan: Confirm there are less warnings with this patch applied Signed-off-by: Lee Jamison Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18762] Some tests are noisy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart changed: What|Removed |Added Attachment #64114|0 |1 is obsolete|| Attachment #64115|0 |1 is obsolete|| Attachment #64116|0 |1 is obsolete|| Attachment #64170|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 64294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64294&action=edit Bug 18762: Remove warnings from xt/author/valid-templates.t Test plan: Read the changes and make sure they make sense Signed-off-by: Lee Jamison Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18761] AutomaticItemModificationByAge.t tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18761 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #64287|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 64293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64293&action=edit Bug 2696 - Fine Payments Should Show What Was Paid For Test Plan: 1) Apply this patch and its' dependencies 2) Create and pay some various fees and fines 3) View the payments for fees, and fees paid by payments by using the new 'Details' button available on boraccount.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #5 from Jonathan Druart --- Additional information: To test this patch: % wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.1.jar % sudo apt-get install xvfb firefox-esr % SELENIUM_PATH=/home/vagrant/selenium-server-standalone-2.53.1.jar % Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & % DISPLAY=:1 java -jar $SELENIUM_PATH Remove the rentalcharge: % UPDATE itemtypes SET rentalcharge = 0; Then you can execute the test file. If you get: Wide character in print at /usr/local/share/perl/5.20.2/Test2/Formatter/TAP.pm line 105. # 'Koha › Patrons › Add patron test_patron_surname (Adult)' # doesn't match '(?^u:Patron details for test_patron_surname)' Ignore and retry (FIXME LATER...) No need to say that this code needs more love. The plan here is to make the tests pass, it will already be a big step. Tested on 17.05.x, 16.11.x and 16.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16286] Use validation plugin when adding or editing patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16286 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16286, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16400, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11088, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13501 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #4 from Jonathan Druart --- Created attachment 64292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64292&action=edit Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #3 from Jonathan Druart --- Created attachment 64291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64291&action=edit Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: to: then finally to: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #2 from Jonathan Druart --- Created attachment 64290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64290&action=edit Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: with -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #1 from Jonathan Druart --- Created attachment 64289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64289&action=edit Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart changed: What|Removed |Added Version|17.05 |master Depends on||13691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 [Bug 13691] Add some selenium scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What|Removed |Added Blocks||18804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 [Bug 18804] Selenium tests are failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18804] New: Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Bug ID: 18804 Summary: Selenium tests are failing Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org These tests are not run regularly and they are now completely broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18728] use html filter in suggestions datatable sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18728 Jonathan Druart changed: What|Removed |Added Resolution|WORKSFORME |INVALID --- Comment #13 from Jonathan Druart --- Next time please confirm the bug before fixing it ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Kyle M Hall changed: What|Removed |Added Attachment #64204|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 64288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64288&action=edit Bug 18786 - Add ability to create custom payment types Some libraries would like to be able to specify more specific payment types such as cash, check, credit card, or even canned food ( for food drives ). This feature will allow a library to specify payment types as authorised values of the type PAYMENT_TYPE. Test Plan: 1) Apply patches 2) Update database 3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card' 4) Go to the fines section of a patron who has several fines 5) Tab 'Fines' 6) Click on 'Pay' for an individual fine 7) Verify that in the form a 'Pay an individual fine' dropdown appears with payment types 8) Select a payment type, confirm payment 9) Verify that payment type appears in "Description of charges" in tab 'Account' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #5 from Kyle M Hall --- Ack! Thanks for the test plan! I'll get the patch set fixed up asap! (In reply to Marc Véron from comment #4) > Test plan was missing. > > I tested with following steps: > Following test is OK: > > - Apply patches > - Update database > - Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit > card' > - Go to the fines section of a patron who has several fines > - Tab 'Fines' > - Click on 'Pay' for an individual fine > - Verified that in form 'Pay an individual fine' a dropdown appears with > paxment types > - Selected a payment type, confirm payment > - Verify that payment type appears in "Description of charges" in tab > 'Account' > > > Following is missing: > - Go to 'Fines' tab > - Use 'Pay amount' or 'Pay selected' for payment > Fail: There is no dropdown list with payment types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18803] New: Web installer does not load optional data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18803 Bug ID: 18803 Summary: Web installer does not load optional data Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: indr...@l2c2.co.in QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com On a Debian 8 64 bit / MariaDB installation, the optional data sets are not loading. Looks similar to 18741. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11210] Allow partial writeoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > (In reply to Marcel de Rooy from comment #9) > > ERROR: > > Bareword "dt_from_string" not allowed while "strict subs" in use at > > C4/Search/History.pm line 47. > > > > Look here: > > userid, sessionid, query_desc, query_cgi, type, total} . ( > > > > Look better :) Different brackets > > Nope Look even better :) Forget this. Remains of 17600 ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #9) > ERROR: > Bareword "dt_from_string" not allowed while "strict subs" in use at > C4/Search/History.pm line 47. > > Look here: > userid, sessionid, query_desc, query_cgi, type, total} . ( > > Look better :) Different brackets Nope Look even better :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #14 from Marc Véron --- I can fix and reproduce the issue with following steps: - Apply patch - restart plack / memcached with every step as appropriate - Verify that (on my installation) the CSV export is in one line - Edit empty_line.inc (using vim) - Set vim to display line breaks (:set list) - Add a new line after the existing one - Delete the first line - Save - Do a new CSV export -> Success - Revert all edits (using u in vim) - Save - Do a new CSV export -> Fail, export is again on one line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17380] Cannot edit authorities with authtypecode = default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18801 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 --- Comment #9 from Marcel de Rooy --- ERROR: Bareword "dt_from_string" not allowed while "strict subs" in use at C4/Search/History.pm line 47. Look here: userid, sessionid, query_desc, query_cgi, type, total} . ( Look better :) Different brackets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18801] Merging authorities has an invalid 'Default' type in the merge framework selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18801 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17380 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #9583|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #3069|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #800 is|0 |1 obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #13 from Kyle M Hall --- Created attachment 64287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64287&action=edit Bug 2696 - Fine Payments Should Show What Was Paid For Test Plan: 1) Apply this patch and its' dependencies 2) Create and pay some various fees and fines 3) View the payments for fees, and fees paid by payments by using the new 'Details' button available on boraccount.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #47 from Marcel de Rooy --- Applying: Bug 17600: Explicitly export the subroutines used fatal: sha1 information is lacking or useless (C4/Auth_with_cas.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. If it applies Friday morning, I will start with it ;) Just using git 2.1.4 on Jessie.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18728] use html filter in suggestions datatable sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18728 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |WORKSFORME Status|In Discussion |RESOLVED --- Comment #12 from Fridolin SOMERS --- Oki, thanks all for testing. I mark as resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > (In reply to Marcel de Rooy from comment #10) > > (In reply to Jonathan Druart from comment #8) > > > I do not think the behaviour is correct, C4::SMS::send_sms should just do > > > nothing if the config is missing. > > > > Could be discussed on another report and perhaps solved. At first glance, > > the config seems to be something additional not required. > > This just deals with eliminating a uninit warn. > > Nope, please fix it here. I respectfully disagree. This can be pushed imo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18728] use html filter in suggestions datatable sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18728 --- Comment #11 from Owen Leonard --- I still can't reproduce, even after remove some email addresses from patron records, adding different email addresses to identically-named patrons, etc. I think this is resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #11 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #10) > (In reply to Jonathan Druart from comment #8) > > I do not think the behaviour is correct, C4::SMS::send_sms should just do > > nothing if the config is missing. > > Could be discussed on another report and perhaps solved. At first glance, > the config seems to be something additional not required. > This just deals with eliminating a uninit warn. Nope, please fix it here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 --- Comment #2 from Jonathan Druart --- Created attachment 64286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64286&action=edit Bug 18802: Fix Circulation.t if finesMode ne 'production' If finesMode is not set to production, only 1 fine will be created (the renewal one will not). This is what assumes the tests. If set to 'production', the tests will fail because the fines will not be deleted (because of the DBIx::Class) warning. prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491 t/db_dependent/Circulation.t .. 56/95 # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' # at t/db_dependent/Circulation.t line 670. # got: 'auto_too_much_oweing' # expected: 'auto_renew' # Looks like you failed 1 test of 6. Test plan: prove t/db_dependent/Circulation.t should return green whatever the value of finesMode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What|Removed |Added Version|17.05 |master Depends on||14390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 [Bug 14390] Fine not updated from 'FU' to 'F' on renewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jonathan Druart changed: What|Removed |Added Blocks||18802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 --- Comment #1 from Jonathan Druart --- Caused by bug 14390. prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491 t/db_dependent/Circulation.t .. 56/95 # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' # at t/db_dependent/Circulation.t line 670. # got: 'auto_too_much_oweing' # expected: 'auto_renew' # Looks like you failed 1 test of 6. # Failed test 'auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew' # at t/db_dependent/Circulation.t line 679. t/db_dependent/Circulation.t .. 94/95 # Looks like you failed 1 test of 95. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > I do not think the behaviour is correct, C4::SMS::send_sms should just do > nothing if the config is missing. Could be discussed on another report and perhaps solved. At first glance, the config seems to be something additional not required. This just deals with eliminating a uninit warn. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 Marcel de Rooy changed: What|Removed |Added Attachment #64167|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 64285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64285&action=edit Bug 18732: Noisy t/SMS.t triggered by koha_conf.xml without sms_send_config Upgraded systems may be lacking sms_send_config which makes t/SMS.t noisy. This silently bypasses the problem. Remove sms_send_config from your koha-conf.xml file prove t/SMS.t -- it will be noisy, but pass. apply patch prove t/SMS.t -- noise gone. run koha qa test tools. Signed-off-by: Lee Jamison Works correctly as indicated by the testing plan. No "uninitialized" noise after patch is applied. Signed-off-by: Marcel de Rooy Slightly amended: turned the iif around. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 Marcel de Rooy changed: What|Removed |Added QA Contact|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18802 --- Comment #35 from Jonathan Druart --- (In reply to Jonathan Druart from comment #34) > > Test fails: > > t/db_dependent/Circulation.t .. 44/95 > > # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' > > # at t/db_dependent/Circulation.t line 671. > > # got: 'auto_too_much_oweing' > > # expected: 'auto_renew' > > # Looks like you failed 1 test of 6. > > I manage to recreate that with prove t/db_dependent/Circulation* > but then the test failed on master too. Sounds like a master bug, depending > on data. It depends on the value of finesMode. I have opened bug 18802. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17680 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] New: Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Bug ID: 18802 Summary: Circulation.t fails if finesMode != "Do not calculate" Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
