[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #13 from Marcel de Rooy --- (In reply to Michael Cabus from comment #12) > When I run perl misc/maintenance/auth_show_hidden_data.pl -c I get this > error: > > DBIx::Class::ResultSet::find(): find() expects either a column/value > hashref, or a list of values corresponding to the columns of the specified > unique constraint 'primary' at /home/vagrant/kohaclone/Koha/Objects.pm line > 85 > > Checked Authorities schema and all seemed well. Hi Michael, Thanks for testing. I guess that you are using kohadevbox to test, but I wonder if you have a configuration issue. Line 85 of Koha/Objects in master is not the DBIx find call, but only the first line of the sub with me. Please check if your paths are in order. The perl library path should also point to current master not to the older instance installed on your devbox. Do you use dev_install in your koha-conf? Marcel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799 --- Comment #21 from Baptiste --- Hum ok.. So the settings: item-level_itype => biblio record XSLTDetailsDisplay, XSLTListsDisplay , XSLTResultsDisplay => "default" DisplayIconsXSLT => show noItemTypeImages => show I can find icons on this page http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=384&searchid=scs_1499067251739 but with all others settings it works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marcel de Rooy changed: What|Removed |Added Resolution|--- |DUPLICATE CC||m.de.r...@rijksmuseum.nl Status|Signed Off |RESOLVED --- Comment #3 from Marcel de Rooy --- Good catch, Aleisha. I am moving the solution to 18881 as Marc expanded it. *** This bug has been marked as a duplicate of bug 18881 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #14 from Marcel de Rooy --- *** Bug 18859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Bug 18881 depends on bug 18859, which changed state. Bug 18859 Summary: Warns when accessing Circulation -> Holds Queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marcel de Rooy changed: What|Removed |Added Blocks|18881 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 [Bug 18881] Remove dead code in circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Depends on|18859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 [Bug 18859] Warns when accessing Circulation -> Holds Queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #15 from Marcel de Rooy --- Created attachment 64769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64769&action=edit Bug 18881: Remove dead code from view_holdsqueue.pl Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. The description was not even used. Template calls GetDescription. To test: Verify that viewing the holds queue still works as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #16 from Marcel de Rooy --- Created attachment 64770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64770&action=edit Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Attachment #64761|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #17 from Marcel de Rooy --- Taking the liberty to move this directly into PQA now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Marc Véron changed: What|Removed |Added Attachment #64767|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 64771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64771&action=edit Bug 1 - Currency defined in new onboardingstep6.tt after installation Test plan: 1. Restart memcached and drop and recreate your database 2. Go through the Koha web installer making sure to install all data except the currencies 3. Run through the onboarding tool noticing that after creating the circulation rule the complete page appears and you can click to log into Koha with the superlibrarian user you have created in the onboarding tool 4. Apply patch 5. Repeat step 1, and 2 6. Run through the onboarding tool and notice that after creating the circulation rule, a screen appears for you to define a currency 7. Write in the currency name and symbol (notice: you cannot edit the exchange rate of 1) and submit the form 8. Notice the complete screen appears and you can log in with the superlibrarian account created in the onboarding tool 9. Go to Administration->Currencies and exchange rates and notice that the currency you created in the onboarding tool is displayed as active 10. Repeat step 1 11. Go through the Koha web installer making sure to install all data including currencies 12. Run through the onboarding tool and notice that after creating the circulation rule then the complete screen appears and click to log into Koha with your superlibrarian account 13. Run qa tool and all tests should be successful 14. Sign off Sponsored-by: Catalyst IT Folloewe test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Marc Véron changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16610 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18755 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #47 from Marc Véron --- Hi Alex It works great. Two small issues: - The modal box now shows sliders (inactive), they are not necessary. I think it's in #onboardingModal (overflow) or something with the dimensions. - The rate can not be changed, that is ok now, but users can enter oter values and try to save. They will need an explanation why the exchange rate can not be changed. Or maybe better hide the exchange rate? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Ruth Smalley changed: What|Removed |Added CC||rsmalley@livewirewarrington ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Marc Véron --- Sorry, after applying the patch (on top of 18002, refresh memcahed and plack), I get an Internal error. Plack error log says: Variable "$layout" is not available at /home/marc/koha/labels/label-home.pl line 55. Can't call method "get_attr" on an undefined value at /home/marc/koha/labels/label-home.pl line 55. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12355] Print quick slip should not print items renewed in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12355 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12355 CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12355] Print quick slip should not print items renewed in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12355 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18527 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #25 from Marc Véron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18889] New: Item number in biblio description in fine page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Bug ID: 18889 Summary: Item number in biblio description in fine page Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: vimal0...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 64772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64772&action=edit Fines Dear Friends, Very useful to see the item number (barcode) along with bibliographic details in fines page. If barcode appears along with book details easy identify the specific book. For example, in law libraries books with the same title by many authors (e.g. Constitution of India). Please see the screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18889] Item number in biblio description in fine page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 vimal kumar changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #21 from Nick Clemens --- Created attachment 64773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64773&action=edit Bug 18434 - Followup fix tests for sorting and factes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785
Julian Maurice changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment #3 from Julian Maurice ---
(In reply to M. Tompsett from comment #2)
> There are a bunch of other bugzilla issues related to ->find and a scalar
> context.
> Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or
> I think others get lazy ->find( scalar $self->biblionumber )... or was it
> return scalar Koha::Biblios->find($self->biblionumber);
> Hmmm... anyways, this isn't right, as far as I can tell.
I assume you are talking about bug 18179, but the patch I wrote doesn't make
any call to 'find' in a list context. Plus, there is a check in
Koha::Objects::find that prevents it to be used in a list context, so I think
we're good. Callers of Koha::Subsbcription::biblio will be the ones to have to
make sure it's called in scalar context.
> Plus if it is singular, then why Biblios? This is the part I don't
> understand in this and other code.
The 'find' subroutine is defined in Koha::Objects, not Koha::Object.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 --- Comment #4 from Marcel de Rooy --- Colin: What about Patron Status now? If you provide no AD field, Patron Status responds with a CQN (without Invalid password). Should it return a CQ? Same for empty AD; receive CQN. Should the new option change behavior here? Note: Patron Info without AD does not return a CQ. (Should it?) And an empty AD with allow_e_p returns a CQY. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18890] New: REST API: Fix fetching operation spec in route chain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 Bug ID: 18890 Summary: REST API: Fix fetching operation spec in route chain Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@jns.fi QA Contact: testo...@bugs.koha-community.org Mojolicious::Plugin::OpenAPI version 1.17 added a feature for fetching API spec in route chain. For us, this type of functionality is used in authentication with our own workaround introduced in Bug 18137. Our own workaround no longer works if M::P::OpenAPI version >=1.17. When upgrading Mojolicious::Plugin::OpenAPI dependency, this patch will fix the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 --- Comment #1 from Lari Taskula --- Created attachment 64774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64774&action=edit Bug 18890: REST API: Fix fetching operation spec in route chain Mojolicious::Plugin::OpenAPI version 1.17 added a feature for fetching API spec in route chain. For us, this type of functionality is used in authentication with our own workaround introduced in Bug 18137. Our own workaround no longer works if M::P::OpenAPI version >=1.17. When upgrading Mojolicious::Plugin::OpenAPI dependency, this patch will fix the issue. To test: 1. prove t/db_dependent/api/v1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #53 from Nick Clemens --- Created attachment 64776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64776&action=edit Bug 12768 - Replacement cost and processing fee management Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Nick Clemens changed: What|Removed |Added Attachment #4|0 |1 is obsolete|| Attachment #40001|0 |1 is obsolete|| Attachment #40002|0 |1 is obsolete|| Attachment #42157|0 |1 is obsolete|| Attachment #43181|0 |1 is obsolete|| Attachment #43546|0 |1 is obsolete|| --- Comment #52 from Nick Clemens --- Created attachment 64775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64775&action=edit Bug 12768 - Updated schema files Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #54 from Nick Clemens --- Rebased, addressed QA concerns, squashed for readability, added more tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 --- Comment #3 from Lari Taskula --- Created attachment 64778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64778&action=edit Bug 18890: Fix holds.t The update also causes some tests authorization tests to fail with HTTP 400 response instead of the expected 401/403. It seems that the parameters were not properly validated before and the tests were mistakenly passing. To test: 1. prove t/db_dependent/api/v1/holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 --- Comment #2 from Lari Taskula --- Created attachment 64777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64777&action=edit Bug 18890: Fix cities.t The update also causes some tests authorization tests to fail with HTTP 400 response instead of the expected 401/403. It seems that the parameters were not properly validated before and the tests were mistakenly passing. To test: 1. prove t/db_dependent/api/v1/cities.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 --- Comment #6 from Lari Taskula --- (In reply to Mike from comment #5) > Hi Lari, > any progress on it? Jiri propably will ready to join us again and do some > code on REST. So, we need to know actual state of Your work. > > Thank You. Hi! Sorry for late answer, I was on holidays. Yes, I have some code ready, attaching it by tomorrow so you can review it. Nice to hear Jiri is joining you again! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 Lari Taskula changed: What|Removed |Added Depends on||18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What|Removed |Added Blocks||18890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 [Bug 18890] REST API: Fix fetching operation spec in route chain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 Lari Taskula changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Attachment #64478|0 |1 is obsolete|| --- Comment #36 from Nick Clemens --- Created attachment 64779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64779&action=edit [SIGNED-OFF] Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 3 - Test searching for author, title, and subject 4 - Verify that results are returned in expected order 5 - Experiment with fuzziness 6 - Click any result and verify specific titles are correct 7 - Click through title to record and verify it is the correct record Signed-off-by: Sebastian Hierl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #12 from Nick Clemens --- (In reply to Marcel de Rooy from comment #10) > If I select say Author and set them all to Facetable No in the Search fields > list on the Biblios tab, I would not expect Author to be still in the Facet > order list? I agree, this is not ideal, but I think that comes when we stop hardcoding the displayable facets all together - I would say beyond the scope of this bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11317] Add a way to access files from the intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #79 from Blou --- Should have been in Need Signoff for a month, now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Nick Clemens changed: What|Removed |Added Attachment #64505|0 |1 is obsolete|| Attachment #64506|0 |1 is obsolete|| Attachment #64507|0 |1 is obsolete|| Attachment #64508|0 |1 is obsolete|| Attachment #64509|0 |1 is obsolete|| --- Comment #41 from Nick Clemens --- Created attachment 64780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64780&action=edit Bug 18228: Table revision of virtualshelves In order to make the permissions easier, we will replace the columns allow_add, allow_delete_own and allow_delete_other by two new columns allow_change_from_owner and allow_change_from_others. The distinction between adding or deleting an entry is no longer made. If you have change permission, you can do both. Also deleting an entry does no longer depend on who added the entry. Formerly, the owner could always add entries. It is now possible to make a list readonly. We will not use the combination of owner=no and other=yes. This will leave us three possibilities: [1] owner=no, other=no: The list is read-only. No one can change contents of the list. Naturally, the owner can edit permissions. [2] owner=yes, other=no: Only the owner can change contents. [3] owner=yes, other=yes: Anyone seeing the list can change contents. This especially applies to shared lists and public lists. The two database columns will be presented in the interface as one permission field offering the three abovementioned options. Test plan: [1] Run the db rev. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #42 from Nick Clemens --- Created attachment 64781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64781&action=edit Bug 18228: DBIx schema changes for Virtualshelve.pm No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #44 from Nick Clemens --- Created attachment 64783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64783&action=edit Bug 18228: Adjust Virtualshelves.t Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Eric Gosselin Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #43 from Nick Clemens --- Created attachment 64782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64782&action=edit Bug 18228: Implement the new columns in code The two new columns as mentioned in the commit message of the table revision must be used in the codebase now. Highlighting some changes in Koha::VirtualShel[f|ves]: [1] Additional methods is_public and is_private. [2] Method add_biblio did not check permissions. Does now. No impact on the interface, but one call in the unit test was affected. [3] Method remove_biblios is signficantly simplified. Removed a FIXME. [4] Method can_biblios_be_removed now redirects to can_biblios_be_added. A followup report may deal with unifying those routines. [5] Condition in get_some_shelves changed. [6] The reference to allow_add in get_shelves_containing_record can simply be removed. opac-shelves.pl and shelves.pl now pass the default setting of Owner only to the template. Templates shelves.tt and opac-shelves.tt now include the new permission field with three choices as mentioned in the table revision patch. opac-addbybiblionumber.pl and addbybiblionumber now need a check on allow_change_from_owner; search conditions slightly adjusted to the new permission scheme. Test plan: When we refer to visibility in the test plan, please check the Add to-combo on opac search results and staff results. And check opac-addbybiblionumber by clicking Save to Lists from opac results. The step 'Check delete' means: open the list in opac and check if you see the Delete button below the entries (only check, do not delete). [ 1] Create private list I01 (perm=Owner) [ 2] Check visibility: Seen. [ 3] Add a book. (Change by owner should be allowed.) [ 4] Check delete: Yes. [ 5] Edit list I01, set perm=Nobody [ 6] Check visibility: Not seen. [ 7] Check delete: No. [ 8] Share list I01 with another patron. [ 9] Check visibility for the other patron: Not seen. [10] Check delete for the other patron: No. [11] Change permission of list I01 to Anyone (by owner). [12] Check visibility for the other patron: Seen. [13] Let other patron add a book (change is allowed). [14] Let owner delete the same book again (change allowed). [15] Create public list U01 (perm=Owner) [16] Check visibility: Seen. [17] Add a book. (Change by owner should be allowed.) [18] Login as other user. Check visibility: Not seen. Check delete: No. [19] Change permission of U01 to Nobody (by owner) [20] As owner: Check visibility: Not seen. Check delete: No. [21] As other user: Check visibility: Not seen. Check delete: No. [22] Create public list U02 (perm=Anyone) [23] Add a book by owner. [24] Delete the same book by other user. Add another book. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #46 from Nick Clemens --- Created attachment 64785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64785&action=edit QA Followup - use gender neutral language in new tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #45 from Nick Clemens --- Created attachment 64784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64784&action=edit Bug 18228: Add missing comma in kohastructure.sql Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18861] branch_transfer_limits needs keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- What is the status of this bug? Signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18891] New: Download Reports Directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 Bug ID: 18891 Summary: Download Reports Directly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: csl...@camdencountylibrary.org QA Contact: testo...@bugs.koha-community.org There should be an option to download a report directly, rather than having to run the report and then choose to download it (effectively running it twice). This would be especially helpful when dealing with reports that take a while to load, though it would also be convenient for reports that are run regularly for distribution and therefore really don't need to be previewed on the screen before downloading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA CC||tomasco...@gmail.com --- Comment #28 from Tomás Cohen Arazi --- Hi everyone here. I tested this with some credentials Nick gave me. I have a couple observations about this one. Important = - I first tested opac-oneclick-search.pl using the q= query param. That way I found stuff in Oneclick. The searched on the main opac search for a term I knew should give results (q=1776), and I got (the first time) "Error searching OneClickDigital collection: Not Found". I then reloaded the results page, and got "Found 1 results in OneClickDigital collection". This one seemed ok - When clicking in the '1 results' link, I got a red message "Error searching OneClickDigital collection: Not Found", on reloading, I got the search results for 1776. => FAIL: It seems there's a problem on the first query, or a throttling stuff getting in the middle. Moderate => FAIL: The search results on opac-oneclick-search.pl have a different styling than Koha's search results. They look nicer, but I think the same XSLT's shold be used. I understood that this is a transition until this search results are displayed inline along with the regular (local) search results. I wouldn't say the second item is a blocker, but it might be a reason for others to vote against its inclusion. Minor = - Another (minor) thing I would consider changing is the wording for the sysprefs description. I think they should clearly match what Oneclick provides the user to configure Koha (LibraryID vs. library #) - Warnings are logged: Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/WebService/ILS/OneClickDigital/PartnerPatron.pm line 58. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/ExternalContent/OneClickDigital.pm line 73. QA scripts == The QA scripts complain about oneclick-checkout.inc => FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/oneclick-checkout.inc FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tomás Cohen Arazi changed: What|Removed |Added Attachment #63477|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 64786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64786&action=edit Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tomás Cohen Arazi changed: What|Removed |Added Attachment #64386|0 |1 is obsolete|| --- Comment #25 from Tomás Cohen Arazi --- Created attachment 64789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64789&action=edit Bug 18434 - Followup - same changes for sort and facet fields To test: 1 - Index some stuff with multiple fields defined for sorting i.e. Authorites - make heading sortable - default is 110a and 111a for heading - a record with 111a empty will make the sort field empty 2 - view the record: curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true 3 - Note the blank field 4 - Apply patch 5 - Reindex 6 - Fields should be correctly populated Unit tests to follow (once I have the originals working for all) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tomás Cohen Arazi changed: What|Removed |Added Attachment #63479|0 |1 is obsolete|| --- Comment #24 from Tomás Cohen Arazi --- Created attachment 64788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64788&action=edit Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tomás Cohen Arazi changed: What|Removed |Added Attachment #64773|0 |1 is obsolete|| --- Comment #26 from Tomás Cohen Arazi --- Created attachment 64790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64790&action=edit Bug 18434 - Followup fix tests for sorting and factes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tomás Cohen Arazi changed: What|Removed |Added Attachment #63478|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 64787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64787&action=edit Bug 18434: Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #27 from Tomás Cohen Arazi --- The last two patches for this one overlap with my patches for bug 18610, this ones are ok and i'm closing the other as duplicate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 18434 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #28 from Tomás Cohen Arazi --- *** Bug 18610 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17875] Linking to series authority records fails when a space precedes the semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875 Liz Rea changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17875 CC||l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #18 from M. Tompsett --- Comment on attachment 62934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62934 [SIGNED OFF] Bug 10267: Show error message if user tries to enter too many characters for cardnumber Review of attachment 62934: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10267&attachment=62934) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +621,4 @@ >[% END %] >[% IF minlength_cardnumber == maxlength_cardnumber %] > size="20" value="[% cardnumber | html %]" minlength="[% minlength_cardnumber > %]" maxlength="[% maxlength_cardnumber %]" /> > +[% IF mandatorycardnumber and not autoMemberNum %] class="required">Required[% END %] class="required">Card number must not be more than [% maxlength_cardnumber %] > characters. It is impossible to enter more than maxlength_cardnumber characters because the maxlength attribute of the input line makes it impossible. I believe bug 13178, providing flexibility of the max size based on the schema which should be regenerated as needed to match the table's field size, makes this bug obsolete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What|Removed |Added Status|NEW |In Discussion --- Comment #1 from Liz Rea --- Hi Kyle, Using the MODS url-encode works when you transfer it over to slimUtils, is that what you had in mind or something else? Seems like it sorts the problem nicely. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 Katrin Fischer changed: What|Removed |Added Severity|major |minor --- Comment #10 from Katrin Fischer --- The screenshots/images on manual.koha-community.org have been fixed, so this is no longer major. Maybe we should switch all links on master for the 17.11 release - as it can't be done automatically (changed headings/achors) and it's a lot of help files to fix. This here will only link from the start page to the new manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 --- Comment #4 from Katrin Fischer --- +1 - nice idea! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18876] Broken links in Koha documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18876 Katrin Fischer changed: What|Removed |Added CC||ch...@bigballofwax.co.nz, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18876] Broken links in Koha documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18876 --- Comment #1 from Katrin Fischer --- Hi Pablo, thx for reporting and for the list. We are aware that a lot of links need to be fixed with the change to Sphinx as the headings/anchors have changed. Please take a look at https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual for some of the ongoing work on the manual :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Katrin Fischer changed: What|Removed |Added Severity|critical|blocker CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Updating severity as this is a blocker issue for libraries using one of those external methods with no passwords in the db for their users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
