[Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Alex Buckleychanged: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Alex Buckleychanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Aleisha Amohiachanged: What|Removed |Added Attachment #64834|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 64836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64836=edit [SIGNED-OFF] Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohiachanged: What|Removed |Added Attachment #64683|0 |1 is obsolete|| --- Comment #28 from Aleisha Amohia --- Created attachment 64835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64835=edit Bug 17698: [FOLLOW-UP] Koha Objects, access borrower through patron sub See Comment 27 This is ready to be tested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #22 from Jonathan Druart--- You are modifying a js file that is used from different templates. You will introduced side-effects with these changes (when receiving an item if AcqCreateItem = "on receiving"). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |In Discussion CC||nicolas.legr...@bulac.fr, ||severine.que...@bulac.fr, ||sonia.bo...@univ-lyon3.fr --- Comment #8 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #7) > So the table is more compact and easy to follow. Well not really, it is less compact than before. I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See comments 5 & 6). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18807] www/batch.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 --- Comment #17 from Jonathan Druart--- (In reply to Katrin Fischer from comment #16) > Tests fail for me with and without this patch: master or 16.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druartchanged: What|Removed |Added Blocks||18870 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18870 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 [Bug 18870] Patron Clubs breaks when creating a club -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druartchanged: What|Removed |Added Attachment #64694|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 64834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64834=edit Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druartchanged: What|Removed |Added Depends on||18179, 12461 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18179 | CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 [Bug 18179] Koha::Objects->find should not be called in list context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druartchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druartchanged: What|Removed |Added Blocks||18870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 [Bug 18870] Patron Clubs breaks when creating a club -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |Signed Off --- Comment #43 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #41) Thanks for catching that, fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #42 from Jonathan Druart--- Created attachment 64833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64833=edit Bug 17680: Fix conflict with bug 18651 $issue is now a Koha::Checkout, not a hashref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9599] printable work slip on receive in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17101] Confirm a question before check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #16 from Lisette--- That seems like the correct order to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #8 from Jonathan Druart--- non-dependent tests must be tested with and without Test::DBIx::Class and with and without the DBMS running -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #7 from Jonathan Druart--- Mirko, could you confirm these patches fix the problem? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #5 from Jonathan Druart--- Created attachment 64831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64831=edit Bug 18851: Test::DBIx::Class is not needed in 00-load.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #6 from Jonathan Druart--- Created attachment 64832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64832=edit Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #4 from Jonathan Druart--- Created attachment 64830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64830=edit Bug 18851: Database handler must not be created at runtime -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druartchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18899] Tests should skip instead of failing when dependency modules are not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Lee Jamisonchanged: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamisonchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18899 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18899] Tests should skip instead of failing when dependency modules are not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Lee Jamisonchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18897 Assignee|ch...@bigballofwax.co.nz|ldjami...@marywood.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18899] New: Tests should skip instead of failing when dependency modules are not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Bug ID: 18899 Summary: Tests should skip instead of failing when dependency modules are not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: ldjami...@marywood.edu QA Contact: testo...@bugs.koha-community.org t/db_dependent/00-strict.t (tests 342, 521, 533) and t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t (test 1) fail instead of skipping when a Perl module required for them to run properly is not installed. test 342 requires Catmandu::Importer::MARC tests 521 and 533 require WebService::ILS::OverDrive::Patron test 1 requires Catmandu::Store::ElasticSearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druartchanged: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Ok, I am on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||m.de.r...@rijksmuseum.nl, ||olli-antti.kivila...@jns.fi ||, tomasco...@gmail.com --- Comment #2 from Jonathan Druart --- My bad, I completely forgot that this module was not packaged. So we have a problem here, the way we mocked our DB was not reliable and we fixed it using Test::DBIx::Class. Olli, Tomas, Marcel, any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druartchanged: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druartchanged: What|Removed |Added Attachment #64286|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 64829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64829=edit Bug 18802: Fix Circulation.t if finesMode ne 'production' If finesMode is not set to production, only 1 fine will be created (the renewal one will not). This is what assumes the tests. If set to 'production', the tests will fail because the fines will not be deleted (because of the DBIx::Class) warning. prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491 t/db_dependent/Circulation.t .. 56/95 # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' # at t/db_dependent/Circulation.t line 670. # got: 'auto_too_much_oweing' # expected: 'auto_renew' # Looks like you failed 1 test of 6. Test plan: prove t/db_dependent/Circulation.t should return green whatever the value of finesMode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 --- Comment #12 from Jonathan Druart--- (In reply to Tomás Cohen Arazi from comment #10) > Overall, it looks great. I would love to see (at some point) the > Koha::Biblio objects passed to the template instead of explicitly extracting > each attribute, but that's a whole other problem. What I did on bug 18789 for Koha::Patron, I'd love to do it for Koha::Biblio too. > I've found a test to fail with this patch applied, and pass without it: Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #56 from Philippe Audet-Fortin--- Created attachment 64828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64828=edit Bug 12446 - Added a missing comma in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 --- Comment #11 from Jonathan Druart--- Created attachment 64827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64827=edit Bug 18262: Fix test in MultiplePerRecord The biblioitem entry must be added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Attachment #63889|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 64826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64826=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17101] Confirm a question before check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #41 from Tomás Cohen Arazi --- wihtout the patches: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. ok All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.02 usr 0.01 sys + 2.09 cusr 0.35 csys = 2.47 CPU) Result: PASS with the patches: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. 1/4 # Failed test 'No account lines should exist on old issue_id' # at t/db_dependent/Circulation/Returns.t line 311. # got: '1' # expected: '0' # Failed test 'Two account lines should exist on new issue_id' # at t/db_dependent/Circulation/Returns.t line 314. # got: '1' # expected: '2' # Looks like you failed 2 tests of 4. t/db_dependent/Circulation/Returns.t .. 4/4 # Failed test 'Handle ids duplication' # at t/db_dependent/Circulation/Returns.t line 318. # Looks like you failed 1 test of 4. t/db_dependent/Circulation/Returns.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report --- t/db_dependent/Circulation/Returns.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.14 cusr 0.33 csys = 2.50 CPU) Result: FAIL kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |Signed Off --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > Koha/REST/V1/Hold.pm > Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of > GetBiblio was not tested too before. > No blocker. > > catalogue/imageviewer.pl > biblionumber is a CGI parameter here > find should be tested That was already true before this patch, we must handle nonexistent biblionumber correctly on all catalogue scripts. > Same for catalogue/issuehistory.pl > opac/opac-imageviewer.pl I did not find a change in the behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druartchanged: What|Removed |Added Depends on||18277 --- Comment #7 from Jonathan Druart --- Patch rebased on top of bug 18277. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druartchanged: What|Removed |Added Blocks||18260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 [Bug 18260] Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 --- Comment #8 from Jonathan Druart--- Created attachment 64825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64825=edit Bug 18260: Handle nonexistent biblionumber in imageviewer.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #52 from Philippe Audet-Fortin--- Because of the sha1 error, I took the content of the original commit "Bug 12532 - QA Follow-up", put it in an other commit and mark the old one has obsolete. Now the patch apply correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortinchanged: What|Removed |Added Attachment #64824|Bug 12532 - Bug 12532 - QA |Bug 12532 - QA Follow-up description|Follow-up | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortinchanged: What|Removed |Added Attachment #59447|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #51 from Philippe Audet-Fortin--- Created attachment 64824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64824=edit Bug 12532 - Bug 12532 - QA Follow-up Fixed tests, they now work without any fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druartchanged: What|Removed |Added Attachment #63760|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 64823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64823=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com --- Comment #17 from Tomás Cohen Arazi --- (In reply to alfre69 from comment #16) > (In reply to Barton Chittenden from comment #13) > > (In reply to alfre69 from comment #9) > > > If you increase $max_record_size too much it breaks the Z39.50 server. > > > > > > A yaz-client search report this: > > > > > > Target has closed the association. > > > Reason: protocolError, message: Incoming package too large > > > > Does this error occur on *all* searches, or simply searches whose results > > are greater than 1 MB? > > It occurs on all searches, so the Z39.50 server is not usable when > increasing $max_record_size. IndexData told me a while back that yaz-client has several limitations the protocol doesn't have, and we should be using zoomsh instead for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #13 from Jonathan Druart--- Patches have been rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #11 from Jonathan Druart--- Created attachment 64821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64821=edit Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druartchanged: What|Removed |Added Attachment #63301|0 |1 is obsolete|| Attachment #63302|0 |1 is obsolete|| Attachment #63303|0 |1 is obsolete|| Attachment #63304|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 64819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64819=edit Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #12 from Jonathan Druart--- Created attachment 64822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64822=edit Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #10 from Jonathan Druart--- Created attachment 64820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64820=edit Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18898] New: Some permissions for Reports can be bypassed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18898 Bug ID: 18898 Summary: Some permissions for Reports can be bypassed Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: bovinitydivin...@comcast.net QA Contact: testo...@bugs.koha-community.org In 16.11.05.000 If a user has permissions to run - but not create or edit reports - they can still create or edit reports by editing the the URL while running a report and changing the Phase parameter to "Edit SQL" or "Create report from SQL". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |In Discussion --- Comment #13 from Jonathan Druart --- Yes indeed you are right, this is not ideal and might be confusing. We should add more JS code to handle that correctly, but I am not willing to write it. However I am still thinking that this feature is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 --- Comment #1 from Lee Jamison--- Created attachment 64818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64818=edit Bug 18897 - Koha_Elasticsearch_Indexer.t doesn't skip when ES module not installed If Catmandu::Importer::MARC is not installed, Koha_Elasticsearch_Indexer.t fails instead of skipping. Test Plan: 1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t" as koha-shell. 2. Note failure on test 1/5 indicating module not installed. 3. Apply patch. 4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t" 5. Note test now skips. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamisonchanged: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18862] Allow relations in Koha::Object's AUTOLOAD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18862 --- Comment #5 from Jonathan Druart--- What you pasted in comment 2 is the current way to go. I am not in favour of adding more magic for now. We clearly see/show what we are using and the methods are covered by tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #60 from Jonathan Druart--- (In reply to Marcel de Rooy from comment #49) > Add checks for find please. > > Can't call method "biblio" on an undefined value at circ/circulation.pl line > 334. > > Before this patch set you get a warning on an unknown barcode, now an > Internal server error.. Thanks for catching that Marcel. Must be fixed with the last patch. The other calls look safe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamisonchanged: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|ldjami...@marywood.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #59 from Jonathan Druart--- Created attachment 64817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64817=edit Bug 18276: barcode may be nonexistent when checking out/in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18897] New: Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Bug ID: 18897 Summary: Koha_Elasticsearch_Indexer.t doesn't skip when ES module not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: ldjami...@marywood.edu QA Contact: testo...@bugs.koha-community.org Running "prove t/db_dependent/Koha_Elasticsearch_Indexer.t" fails instead of skipping if Catmandu::Importer::MARC is not installed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #58 from Jonathan Druart--- Fixed conflicts with bug 17843 and bug 17738. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #57 from Jonathan Druart--- Created attachment 64816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64816=edit Bug 18276: [QA Follow-up] Two newlines to make qa tools happy FAIL pod Apparent command =cut not preceded by blank line in file misc/cronjobs/advance_notices.pl FAIL pod Apparent command =cut not preceded by blank line in file C4/SIP/ILS/Item.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #53 from Jonathan Druart--- Created attachment 64812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64812=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #56 from Jonathan Druart--- Created attachment 64815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64815=edit Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI Take into account biblio level holds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druartchanged: What|Removed |Added Attachment #63294|0 |1 is obsolete|| Attachment #63295|0 |1 is obsolete|| Attachment #63296|0 |1 is obsolete|| Attachment #63297|0 |1 is obsolete|| Attachment #63298|0 |1 is obsolete|| Attachment #63299|0 |1 is obsolete|| Attachment #63300|0 |1 is obsolete|| Attachment #64748|0 |1 is obsolete|| --- Comment #50 from Jonathan Druart --- Created attachment 64809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64809=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #51 from Jonathan Druart--- Created attachment 64810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64810=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=51_holds=1 The results should be the same before and after this patch Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #54 from Jonathan Druart--- Created attachment 64813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64813=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #52 from Jonathan Druart--- Created attachment 64811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64811=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #55 from Jonathan Druart--- Created attachment 64814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64814=edit Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- Hello, If this patch is ready to be tested you should change the status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #48 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18782] Remove unused C4::Serials::getsupplierbyserialid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18782 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #10 from Jonathan Druart --- Remote branch has been rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] need an add option in marc modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com Assignee|gmcha...@gmail.com |n...@bywatersolutions.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] need an add option in marc modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemenschanged: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] need an add option in marc modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #2 from Nick Clemens--- Created attachment 64808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64808=edit Bug 13560 - need an add option in marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to Add & Update so that add will always add a field and Update will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9599] printable work slip on receive in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Sandre Cunhachanged: What|Removed |Added CC||cu...@monterey.org --- Comment #1 from Sandre Cunha --- Has anyone looked into the feasibility of doing this? It would really speed up the process, especially for larger libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Oliver Bock from comment #0) > The regression itself is a logical error as "@return = (0)" is considered to > be "false" when checked with "unless". That's wrong as "unless" tests the > number of elements in a list. Thus the "falsy" condition has to established > with "@return = ()" instead. Where did you find this condition? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druartchanged: What|Removed |Added Attachment #64259|0 |1 is obsolete|| Attachment #64284|0 |1 is obsolete|| Attachment #64337|0 |1 is obsolete|| --- Comment #38 from Jonathan Druart --- Created attachment 64805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64805=edit Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #39 from Jonathan Druart--- Created attachment 64806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64806=edit Bug 17680: Fix regression - is_overdue must be called is_overdue must be called even if there is not dropbox date (!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #40 from Jonathan Druart--- Created attachment 64807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64807=edit Bug 17680: Add few tests for AddReturn when overdue To make sure the last patch fixes the issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Kyle M Hallchanged: What|Removed |Added Attachment #64801|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 64804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64804=edit Bug 18894 - Add ability to limit the number of messages sent by misc/cronjobs/process_message_queue.pl at a time Having the ability to limit the number of messages sent by process_message_queue.pl on a single run would be very useful for controlling home many messages are sent at a given time. This can help prevent too many messages being sent out at once and getting flagged as a spammer. Test Plan: 1) Apply this patch 2) Generate some number of messages in the message queue 3) Run process_message_queue.pl with the new --limit option, set limit to a number smaller than the number of pending messages 4) After the script has run, check the database and note that only a number of pending messages were sent, and that the remaining amount of pending messages is the original amount less the number specified as the limit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #50 from Philippe Audet-Fortin--- Corrected minor error. However, "Bug 12532 - QA Follow-up" give me a Sha1 error so it couldn't be applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #49 from Philippe Audet-Fortin--- Corrected minor error. However, "Bug 12532 - QA Follow-up" give me a Sha1 error so it couldn't be applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18891] Download Reports Directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 Lee Jamisonchanged: What|Removed |Added CC||ldjami...@marywood.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 --- Comment #1 from Kyle M Hall--- Created attachment 64803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64803=edit Bug 18725 - Process_message_queue sends duplicate emails if message_queue is not writable. Last week, we had a database server whose disk filled, causing database writes to fail. This meant that messages in message_queue marked 'pending' were not marked as 'sent' when they were added to the postfix mail queue; messages were sent every 15 minutes (as specified in the cron job) until the disk space issues were cleared. I would suggest adding a token write to the start of process_message_queue.pl as a 'canary in the coal mine'. If the database write fails, process_message_queue should stop, because it's not safe to proceed sending emails that may not be marked 'sent'. I have no good idea on how to test this patch so this is what I've got: Test Plan: 1) Apply this patch 2) prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hallchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/