[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- Applying: Bug 16976 - Unit tests fatal: sha1 information is lacking or useless (t/Search/Zebra/QueryBuilder.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Marcel de Rooy changed: What|Removed |Added Attachment #64909|0 |1 is obsolete|| Attachment #65021|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 65037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65037&action=edit Bug 18880: Fix authentication fallback for external authentications A regression in commit cfc484b17 / bug #18314 breaks the local authentication fallback for all external authentications like LDAP, CAS and Shibboleth. The regression itself is a logical error as "@return = (0)" is considered to be "false" when checked with "unless" (line 1814). That's wrong as "unless" tests the number of elements in a list. Thus the "falsy" condition has to established with "@return = ()" instead. This patch tries to simplify the logic by adding a $passwd_ok and $check_internal_as_fallback flags to be more verbose and hopefully more understandable. The goal here is simply to restore back the same logic as before cfc484b17 Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 --- Comment #31 from Marcel de Rooy --- Created attachment 65038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65038&action=edit Bug 18880: [QA Follow-up] Finishing touch Do not fill @return if retval == -1 for LDAP (see cfc484b17). No need to call store after an DBIx update. Rearranged the if statement. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7374] can't upload icon for auth values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7374] can't upload icon for auth values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Dilan Johnpullé changed: What|Removed |Added Attachment #64916|0 |1 is obsolete|| Attachment #64917|0 |1 is obsolete|| --- Comment #7 from Dilan Johnpullé --- Created attachment 65036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65036&action=edit Bug 7374: Can't upload icon for auth values Fixes a bug which prevents the delivered images being selected. Works as expected in line with test plan above. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18939] New: Record matching rules didnot work by matching with callnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18939 Bug ID: 18939 Summary: Record matching rules didnot work by matching with callnumber Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: importedbugs Assignee: koha-bugs@lists.koha-community.org Reporter: nara...@gmail.com QA Contact: testo...@bugs.koha-community.org I try to migrate data from WISIS to koha. In record matching rules, I was created rule for matching with callnumber (tag 080$a). The result is "no matching found" , even though a match exists. If anyone met this issue before, please help me to fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org Severity|minor |major CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17829 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18938 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18938] New: opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 Bug ID: 18938 Summary: opac/svc/patron_notes and opac/opac-issue-note.pl use GetMember Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org C4::Members::GetMember no longer exists. This means this code is broken. I believe 17829 is why it no longer exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #30 from M. Tompsett --- Bug 17829 means the C4::Member::GetMember logic here doesn't work. Tweaking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17829 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14385 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #124 from Alex Buckley --- Hi Whilst going through this http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md to install Mana I run the following command: plackup -r -R lib -E production bin/app.psgi And I get the following output: Error while loading /home/vagrant/kohaclone/koha-mana/bin/app.psgi: Can't locate Dancer2/Plugin/REST.pm in @INC (you may need to install the Dancer2::Plugin::REST module) (@INC contains: /home/vagrant/kohaclone/koha-mana/bin/../lib ~/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/koha-mana/bin/../lib/Mana.pm line 8. I try to install the Dancer2/Plugin/REST package using the command: sudo apt-get install libdancer2-plugin-rest-perl However the package cannot be found. I have tried many different variations of the name without any success (and I cannot find any help with this online) therefore can someone please inform me of the correct command to install the Dancer2/Plugin/REST package? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Liz Rea changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18918] Exporting bibs in CSV when you have no CSV profiles created causes error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18918 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18934] Warns in Admin -> SMS providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18934 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18917] use font awesome buttons in CSV profiles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18917 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18858] Warn when deleting a borrower debarment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18858 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch 's email as "from" address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18542] Move and style "new field" link in item search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17639] Remove white filling inside of Koha logo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17639 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16545] Make edit link a styled button in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17639] Remove white filling inside of Koha logo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17639 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17639] Remove white filling inside of Koha logo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17639 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17639] Remove white filling inside of Koha logo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17639 Jonathan Druart changed: What|Removed |Added Attachment #64062|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 65035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65035&action=edit Bug 17639 - Remove white filling inside of Koha logo This patch modifies the Koha logo SVG file to remove the fill from two letters. This patch also optimizes the file and converts the text object to paths for better cross-platform portability. To test you could: - Open the file in an editor and confirm that the change is correct - or - - Open the file in a browser and use the code inspector to add a background-color attribute to the top-level tag. The logo should appear transparent, with no white fills. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18934] Warns in Admin -> SMS providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18934 Jonathan Druart changed: What|Removed |Added Severity|enhancement |trivial Status|Signed Off |Passed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18934] Warns in Admin -> SMS providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18934 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18934] Warns in Admin -> SMS providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18934 Jonathan Druart changed: What|Removed |Added Attachment #65015|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 65034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65034&action=edit Bug 18934: Preventing warns in Admin -> SMS providers This patch initialises the $op variable to prevent the warns To test: 1) Go to admin -> sms providers 2) Notice warns in error log 3) Apply patch and refresh page 4) Notice warns are gone Sponsored-by: Catalyst IT Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18858] Warn when deleting a borrower debarment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18858 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA Severity|enhancement |trivial CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18858] Warn when deleting a borrower debarment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18858 Jonathan Druart changed: What|Removed |Added Attachment #64665|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 65033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65033&action=edit Bug 18858: Prevent warn when deleting a borrower debarment To test: 1) Look at intranet log 2) Go to delete a debarment on a borrower 3) Notice warn 4) Apply patch 5) Add a new debarment 6) Delete this debarment 7) Notice warn is gone Sponsored-by: Catalyst IT Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18858] Warn when deleting a borrower debarment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18858 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18858] Warn when deleting a borrower debarment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18858 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18632 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18632] CGI::param called in list context flooding error logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18858 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Julian you must force the context to make sure the following code will not explode: my $s = Koha::Subscriptions->find(42); $template->param( biblio => $s->biblio ); Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Subscription.pm line 48. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Tests pass for me, when will we need this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819 Jonathan Druart changed: What|Removed |Added Depends on||16140 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 [Bug 16140] Only clear L1 cache when needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 Jonathan Druart changed: What|Removed |Added Blocks||17819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819 [Bug 17819] Performance 16.11 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16545] Make edit link a styled button in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 Jonathan Druart changed: What|Removed |Added Attachment #65031|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 65032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65032&action=edit Bug 16545 - Make edit link a styled button in item search results This patch replaces the item search results "edit" link with a dropup button which offers "Edit item" and "Edit record" links. To test, apply the patch and perform an item search. Each results should have an "Edit" menu. Confirm that the menu links work correctly for items on more than one page. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16545] Make edit link a styled button in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 Jonathan Druart changed: What|Removed |Added Attachment #63154|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 65031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65031&action=edit Bug 16545 - Make edit link a styled button in item search results This patch replaces the item search results "edit" link with a dropup button which offers "Edit item" and "Edit record" links. To test, apply the patch and perform an item search. Each results should have an "Edit" menu. Confirm that the menu links work correctly for items on more than one page. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16545] Make edit link a styled button in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18542] Move and style "new field" link in item search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Jonathan Druart changed: What|Removed |Added Attachment #63137|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 65030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65030&action=edit Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. Behaves as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Amended patch: Fix indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18542] Move and style "new field" link in item search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839 Jonathan Druart changed: What|Removed |Added Attachment #64695|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 65029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65029&action=edit Bug 18839: Suggestion.pl spelling mistake On the suggestion management page, 'unknown' is spelled 'unkown' This patch corrects this spelling mistake in suggestion/suggestion.pl koha-tmpl/intranet-tmpl/prog/en/include/strings.inc koha-tmpl/intranet-tmpl/prog/en/include/search_indexes.inc Signed-off-by: Lee Jamison Signed-off-by: sonia BOUIS Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18917] use font awesome buttons in CSV profiles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18917 Jonathan Druart changed: What|Removed |Added Attachment #64963|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 65028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65028&action=edit Bug 18917: Use font-awesome buttons for CSV profiles To test: 1) Go to Tools -> CSV profiles 2) Notice old style of links for Edit and Delete 3) Apply patch and refresh page 4) Notice buttons for Edit and Delete 5) Confirm they work as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18917] use font awesome buttons in CSV profiles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18917 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18918] Exporting bibs in CSV when you have no CSV profiles created causes error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18918 Jonathan Druart changed: What|Removed |Added Attachment #64964|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 65027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65027&action=edit Bug 18918: Disable CSV option if no CSV profiles exist To test: 1) Confirm you have no MARC CSV profiles (tools -> csv profiles) 2) Go to Tools -> Export data 3) Select the CSV file format for biblios 4) Notice the CSV profile dropdown shows up but the dropdown is empty 5) Click the Export button, notice Koha breaks 6) Go back and apply the patch, refresh 7) Notice the CSV option is now disabled in the file format menu 8) If you hover over CSV, an appropriate message should show explaining why it is disabled 9) Create a CSV profile for MARC 10) Go back to Export and you should be able to use CSV now without problem Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18918] Exporting bibs in CSV when you have no CSV profiles created causes error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18918 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Jonathan Druart changed: What|Removed |Added Attachment #64933|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 65026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65026&action=edit Bug 18367 - Fix untranslatable string from Bug 18264 Restore display of message when no barcode found To test: 1 - Go to course reserves 2 - Add an item to a course 3 - Try adding an invalid barcode - should get an alert 4 - Try force adding an item with itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup&course_id=11&itemnumber=1234523546 5 - Should recieve an error Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch 's email as "from" address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch 's email as "from" address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 --- Comment #4 from Jonathan Druart --- Created attachment 65025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65025&action=edit Bug 18775: Use Koha::Patron->library instead of Koha::Libraries->find Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch 's email as "from" address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jonathan Druart changed: What|Removed |Added Attachment #64875|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 65024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65024&action=edit Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. Signed-off-by: Jessica Freeman Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Jonathan Druart changed: What|Removed |Added Attachment #64849|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 65023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65023&action=edit Bug 18667: Show a diff view of SQL reports when converting This patch reformats the SQL conversion before-and-after view so that it shows a diff between the two, just as the Manage MARC Import interface does. This patch also makes a correction to the JavaScript which is triggered by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the event name instead of "hidden." To test, apply the patch and find an SQL report in your reports library which requires updating. - Click the "Update SQL" button. - In the modal window, the "existing" and "updated" SQL should be shown side-by-side with colored highlighting of the differece. - Confirm that the "Update" button still works correctly. - Also confirm that if you open the preview of another report, the "Close" button hides the modal and updates the contents of the modal markup. Use your browser's DOM inspector to confirm that contains only and its contents. Revision moves inline style attributes to CSS block. Signed-off-by: Jesse Maseto Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 Jonathan Druart changed: What|Removed |Added Attachment #64559|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 65022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65022&action=edit Bug 18847 - Add "Save and continue" option to notice editing This patch adds an option to "Save and continue editing" when editing notices. The submit button is now a split button in a floating toolbar. The secondary action of the split button is "Save and continue editing." To test, apply the patch and go to Tools -> Notices. - Open any notice for editing. Verify that the toolbar looks correct and floats as it should when sections of the form are expanded and the page scrolls. - Edit a notice and click the "Save" button. Confirm that you are redirected to the main Notices page and that your changes were saved. - Edit a notice and click the "Save and continue editing" menu item. The page should reload with your updates in place. Signed-off-by: NickUCKohaCon17 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- Marcel, I do not think we should hide "Anyone seeing this list" for private lists. First, you are not allowed to select it before sharing it. That can be a bit annoying if you know you are going to share it after you created it. Then imagine the following workflow: - Create a private list - Share it - Edit the list to let your friend adding items to this list - Remove the share => When you edit the list you do not see the correct value, "Anyone seeing this list" is not displayed whereas it is the value of the field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12145] Lock for Move up buttons with Marc tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #10 from Jonathan Druart
---
I don't think it is the best way to answer the need.
If a library wants to remove the move up buttons it can be achieve easily with
JS:
$('.subfieldmoveup').hide();
Then we could add the checkbox "Lock subfield positions" but the value must be
saved in session like we do for the "sticky due date" (see circ/circulation.pl
stickyduedate).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17864] Increase test coverage on admin pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- I am not sure to understand how useful these regression tests can be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #14 from Jonathan Druart --- Comment on attachment 64077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64077 [SIGNED-OFF] Bug 14039 - Add patron salutation to checkout screen Review of attachment 64077: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14039&attachment=64077) - ::: koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc @@ +5,4 @@ > [%- IF invert_name %] > [%- borrower.surname | html %], [% borrower.firstname | html %] > [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %] > [%- ELSE %] > +[% IF borrower.title %] [%- > borrower.title | html %] [% END %][%- borrower.firstname | html %] [% > IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %] [% > borrower.surname | html %] I do not think it's a good idea to have an id here, there are certainly places where this include file is used several times. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17966 --- Comment #8 from Jonathan Druart --- This is typically the kind of thing that will be easy to do using the TT syntax (see bug 17966). I am not in favour of adding a new pref for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18527 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15404] CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item' s home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Lee Jamison changed: What|Removed |Added Attachment #65011|0 |1 is obsolete|| --- Comment #29 from Lee Jamison --- Created attachment 65021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65021&action=edit Bug 18880: Fix authentication fallback for external authentications A regression in commit cfc484b17 / bug #18314 breaks the local authentication fallback for all external authentications like LDAP, CAS and Shibboleth. The regression itself is a logical error as "@return = (0)" is considered to be "false" when checked with "unless" (line 1814). That's wrong as "unless" tests the number of elements in a list. Thus the "falsy" condition has to established with "@return = ()" instead. This patch tries to simplify the logic by adding a $passwd_ok and $check_internal_as_fallback flags to be more verbose and hopefully more understandable. The goal here is simply to restore back the same logic as before cfc484b17 Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr Status|Needs Signoff |Failed QA --- Comment #3 from Koha Team Lyon 3 --- regarding comment 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18937] Limit the number of entries to print for larger lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937 Marcel de Rooy changed: What|Removed |Added Summary|Limit the number of list|Limit the number of entries |entries to print|to print for larger lists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18937] Limit the number of list entries to print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18937] Limit the number of list entries to print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937 --- Comment #1 from Marcel de Rooy --- Created attachment 65020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65020&action=edit Bug 18937: Limit the number of list entries to print When you have large lists of say 2000 entries, the option Print a list may be very time consuming. Especially when an impatient user hits refresh a couple of times, this might affect your server performance. This patch adds paging to list printing when the number of list entries is over 200 (just a constant). The number of entries to print is now governed by preference OPACnumSearchResults. Test plan: [1] Pick a small list. Verify that print (add print=1 to URL) includes all records. [2] Pick a large list (>200 entries). Verify that print now only includes records of the current page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18937] Limit the number of list entries to print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18937] New: Limit the number of list entries to print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937 Bug ID: 18937 Summary: Limit the number of list entries to print Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When you have large lists of say 2000 entries, the option Print a list may be very time consuming. Especially when an impatient user hits refresh a couple of times, this might affect your server performance. This patch adds paging to list printing when the number of list entries is over 200 (just a constant). The number of entries to print is now governed by preference OPACnumSearchResults. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] New: Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Bug ID: 18936 Summary: Convert issuingrules fields to circulation_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Depends on: 18930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 [Bug 18930] Move lost item refund rules to circulation_rules table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Kyle M Hall changed: What|Removed |Added Blocks||18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18935] MARC::Record->new_from_usmarc does not handle UNIMARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18935 Baptiste changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||stephane.delaune@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18935] MARC::Record->new_from_usmarc does not handle UNIMARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18935 Baptiste changed: What|Removed |Added Severity|major |normal See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18910 Depends on||18533, 18910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 [Bug 18533] MARC::Record->encoding does not handle UNIMARC records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910 [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910 Baptiste changed: What|Removed |Added Blocks||18935 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18935 [Bug 18935] MARC::Record->new_from_usmarc does not handle UNIMARC records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18533] MARC::Record->encoding does not handle UNIMARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 Baptiste changed: What|Removed |Added Blocks||18935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18935 [Bug 18935] MARC::Record->new_from_usmarc does not handle UNIMARC records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18935] New: MARC::Record-> new_from_usmarc does not handle UNIMARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18935 Bug ID: 18935 Summary: MARC::Record->new_from_usmarc does not handle UNIMARC records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkow...@biblibre.com QA Contact: testo...@bugs.koha-community.org The problem related by Bug 18533 is also concerning all calls to MARC::Record->new_from_usmarc (this function uses MARC::Record->encoding). All imported marc notice from z3950 with 18152 active (versions after 16.11) are not considered as UTF-8 anymore by MARC::Record->new_from_usmarc and are also false encoded when imported in Koha. Example of problematic call: cataloguing/addbiblio.pl 85 my $record = MARC::Record->new_from_usmarc($marc); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #139 from Josef Moravec --- (In reply to David Cook from comment #133) > > 2) Could you elaborate on the style issues? I went to > https://wiki.koha-community.org/wiki/QA_Test_Tools, but the configure > dependency step is risky and it looks set up to be used on Debian (and I'm > on openSUSE although I should try out kohadevbox again) so I might hold off > trying the tools for now. > No problem, here is relevant output from qa tools: FAILKoha/Daemon.pm FAIL critic "$fh" is declared but not used at line 78, column 14. Unused variables clutter code and make it harder to read. Bareword file handle opened at line 64, column 18. See pages 202,204 of PBP. FAILKoha/OAI/Harvester.pm FAIL critic Variable declared in conditional statement at line 291, column 9. Declare variables outside of the condition. FAIL pod =head3 without preceding higher level in file Koha/OAI/Harvester.pm FAILKoha/OAI/Harvester/Downloader.pm FAIL pod in file Koha/OAI/Harvester/Downloader.pm =head2 without preceding higher level FAILKoha/OAI/Harvester/Import/RDFXML.pm FAIL critic Variable declared in conditional statement at line 110, column 5. Declare variables outside of the condition. FAIL forbidden patterns forbidden pattern: tab char (line 32) FAILKoha/OAI/Harvester/Import/Record.pm FAIL critic Variable declared in conditional statement at line 325, column 17. Declare variables outside of the condition. Variable declared in conditional statement at line 262, column 13. Declare variables outside of the condition. "return" statement with explicit "undef" at line 145, column 41. See page 199 of PBP. Variable declared in conditional statement at line 252, column 5. Declare variables outside of the condition. FAIL forbidden patterns forbidden pattern: tab char (line 152) forbidden pattern: tab char (line 156) forbidden pattern: tab char (line 142) forbidden pattern: tab char (line 139) forbidden pattern: tab char (line 136) forbidden pattern: tab char (line 384) forbidden pattern: tab char (line 380) forbidden pattern: tab char (line 140) forbidden pattern: tab char (line 141) forbidden pattern: tab char (line 151) forbidden pattern: tab char (line 155) forbidden pattern: tab char (line 149) forbidden pattern: tab char (line 154) forbidden pattern: tab char (line 153) forbidden pattern: tab char (line 138) forbidden pattern: tab char (line 150) forbidden pattern: tab char (line 137) FAIL pod in file Koha/OAI/Harvester/Import/Record.pm =head3 without preceding higher level empty =head3 FAILKoha/OAI/Harvester/Request.pm FAIL forbidden patterns forbidden pattern: tab char (line 69) forbidden pattern: tab char (line 191) forbidden pattern: tab char (line 189) forbidden pattern: tab char (line 181) forbidden pattern: tab char (line 188) forbidden pattern: tab char (line 193) forbidden pattern: tab char (line 104) forbidden pattern: tab char (line 98) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 113) forbidden pattern: tab char (line 183) forbidden pattern: tab char (line 184) forbidden pattern: tab char (line 89) forbidden pattern: tab char (line 185) forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 190) forbidden pattern: tab char (line 83) forbidden pattern: tab char (line 102) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 95) forbidden pattern: tab char (line 194) forbidden pattern: tab char (line 107) forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 108) forbidden pattern: tab char (line 182) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 109) forbidden pattern: tab char (line 66) forbidden pattern: tab char (line 97) forbidden pattern: tab char (line 106)
