[Koha-bugs] [Bug 19178] Remove outdated sms/* scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #4 from Magnus Enger --- *** Bug 10784 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Marcel de Rooy changed: What|Removed |Added Attachment #66486|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 --- Comment #14 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #8) > > Created attachment 66486 [details] [review] [review] > > Bug 19004: build_object takes care of existing data > > > > Signed-off-by: Jonathan Druart > > It works, but it will trigger a "unique violation" warning from build. Which > is valid since build should create data not find it. (I once proposed a flag > to suppress this warning, but it was not welcomed.) It does not work: # Subtest: add_enrolment_fee_if_needed 1..4 Violation of unique constraint in Category at /usr/share/koha/masterclone/t/lib/ TestBuilder.pm line 233. # No tests run! not ok 14 - No tests run for subtest "add_enrolment_fee_if_needed" # Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"' # at t/db_dependent/Koha/Patrons.t line 426. Can't call method "enrolmentfee" on an undefined value at t/db_dependent/Koha/Pa trons.t line 381. # Looks like your test exited with 255 just after 14. Obsoleting this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004
--- Comment #13 from Marcel de Rooy ---
Created attachment 66546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66546&action=edit
Bug 19004: [QA Follow-up] No need to check item-level_itypes again
As Jonathan pointed out, GetItem already called effective_itemtype.
So we can just use $item->{itype} here.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004
--- Comment #12 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #10)
> Actually either the previous version was good (to handle specific cases,
> i.e. wrong data) and yours is wrong, or we could just use $item->{itype}.
We can just use $item->{itype}.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Created attachment 66486 [details] [review] > Bug 19004: build_object takes care of existing data > > Signed-off-by: Jonathan Druart It works, but it will trigger a "unique violation" warning from build. Which is valid since build should create data not find it. (I once proposed a flag to suppress this warning, but it was not welcomed.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Marcel de Rooy changed: What|Removed |Added Attachment #66038|[SIGNED-OFF] [SIGNED-OFF] |Bug 19004: Adjust AddReturn description|Bug 19004: Adjust AddReturn |for retrieving item type |for retrieving item type| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Marcel de Rooy changed: What|Removed |Added Attachment #66037|[SIGNED-OFF] Bug 19004: |Bug 19004: Patrons.t should description|Patrons.t should create its |create its own data for |own data for enrollment |enrollment fees. |fees. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18231 --- Comment #7 from Marc Véron --- (In reply to Marc Véron from comment #6) > While testing I get: > 'Cloning of circulation and fine rules failed!' > Plack error log says: > DBD::mysql::st execute failed: Duplicate entry '5' for key 'PRIMARY' [for > Statement "INSERT INTO issuingrules SELECT * FROM tmpissuingrules WHERE > branchcode=?" with ParamValues: 0="MPL"] at > /home/marc/koha/admin/clone-rules.pl line 86. > > Seems to be a separate bug, but it makes impossible to test here. Could be related to Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19029 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #6 from Marc Véron --- While testing I get: 'Cloning of circulation and fine rules failed!' Plack error log says: DBD::mysql::st execute failed: Duplicate entry '5' for key 'PRIMARY' [for Statement "INSERT INTO issuingrules SELECT * FROM tmpissuingrules WHERE branchcode=?" with ParamValues: 0="MPL"] at /home/marc/koha/admin/clone-rules.pl line 86. Seems to be a separate bug, but it makes impossible to test here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #5 from Alex Buckley --- In the patch I have attach I implemented a security question but have not moved the clone button, please let me know if you think I need to move the clone button as well, because I personally think the security question is a great improvement on the previous behaviour and the moving of the clone button is not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19178] Remove outdated sms/* scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I think t/00-testcritic.t might also need its 'sms' reference removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #140 from Aleisha Amohia --- Sorry for the spam! Signing off on all patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66403|0 |1 is obsolete|| --- Comment #139 from Aleisha Amohia --- Created attachment 66545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66545&action=edit [SIGNED-OFF] Bug 14385: Fix ILSDI_Services test when clubs with branch exist Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66401|0 |1 is obsolete|| --- Comment #138 from Aleisha Amohia --- Created attachment 66544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66544&action=edit [SIGNED-OFF] Bug 14385: Fix breaking issues constraint in ITerator test Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66372|0 |1 is obsolete|| --- Comment #137 from Aleisha Amohia --- Created attachment 66543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66543&action=edit [SIGNED-OFF] Bug 14385: Corrected opac-details searchResult call Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66347|0 |1 is obsolete|| --- Comment #135 from Aleisha Amohia --- Created attachment 66541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66541&action=edit [SIGNED-OFF] Bug 14385: Test C4/Labels/Label.pm changes Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66210|0 |1 is obsolete|| --- Comment #132 from Aleisha Amohia --- Created attachment 66538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66538&action=edit [SIGNED-OFF] Bug 14385: Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66209|0 |1 is obsolete|| --- Comment #131 from Aleisha Amohia --- Created attachment 66537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66537&action=edit [SIGNED-OFF] Bug 14385: Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66302|0 |1 is obsolete|| --- Comment #133 from Aleisha Amohia --- Created attachment 66539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66539&action=edit [SIGNED-OFF] Bug 14385: Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66361|0 |1 is obsolete|| --- Comment #136 from Aleisha Amohia --- Created attachment 66542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66542&action=edit [SIGNED-OFF] Bug 14385: Improve C4::Record::marcrecord2csv test cases Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66303|0 |1 is obsolete|| --- Comment #134 from Aleisha Amohia --- Created attachment 66540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66540&action=edit [SIGNED-OFF] Bug 14385: Added missing 'my' Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66208|0 |1 is obsolete|| --- Comment #130 from Aleisha Amohia --- Created attachment 66536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66536&action=edit [SIGNED-OFF] Bug 14385: Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66206|0 |1 is obsolete|| --- Comment #128 from Aleisha Amohia --- Created attachment 66534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66534&action=edit [SIGNED-OFF] Bug 14385: Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66207|0 |1 is obsolete|| --- Comment #129 from Aleisha Amohia --- Created attachment 66535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66535&action=edit [SIGNED-OFF] Bug 14385: Add missing test to trigger Koha/BiblioUtils/Iterator change Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19178] Remove outdated sms/* scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 --- Comment #2 from David Cook --- Comment on attachment 66496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66496 Bug 19178 - Remove outdated sms/* scripts and related files Review of attachment 66496: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19178&attachment=66496) - ::: t/db_dependent/00-strict.t @@ +19,1 @@ > 'sms', 'suggestion', 'svc', 'tags', 'tools', 'virtualshelves' ); I think this 'sms' reference needs to be removed as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66205|0 |1 is obsolete|| --- Comment #127 from Aleisha Amohia --- Created attachment 66533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66533&action=edit [SIGNED-OFF] Bug 14385: Refactor EmbedItemsInMarcBiblio parameters to hashref Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66202|0 |1 is obsolete|| --- Comment #124 from Aleisha Amohia --- Created attachment 66530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66530&action=edit [SIGNED-OFF] Bug 14385: Properly trigger all changes in C4/Search.pm Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66203|0 |1 is obsolete|| --- Comment #125 from Aleisha Amohia --- Created attachment 66531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66531&action=edit [SIGNED-OFF] Bug 14385: Fix QA Test tool failures C4/Search.pm had some tabs. Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66204|0 |1 is obsolete|| --- Comment #126 from Aleisha Amohia --- Created attachment 66532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66532&action=edit [SIGNED-OFF] Bug 14385: Add some commenting to make sense of logic Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66200|0 |1 is obsolete|| --- Comment #122 from Aleisha Amohia --- Created attachment 66528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66528&action=edit [SIGNED-OFF] Bug 14385: Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66201|0 |1 is obsolete|| --- Comment #123 from Aleisha Amohia --- Created attachment 66529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66529&action=edit [SIGNED-OFF] Bug 14385: Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66199|0 |1
is obsolete||
--- Comment #121 from Aleisha Amohia ---
Created attachment 66527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66527&action=edit
[SIGNED-OFF] Bug 14385: Tweak borrower category code
$borrower->{categorycode} on a Koha::Patron is not the
same as $borrower->categorycode. Fixed error.
Signed-off-by: Mark Tompsett
Signed-off-by: Aleisha Amohia
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66194|0 |1 is obsolete|| --- Comment #116 from Aleisha Amohia --- Created attachment 66522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66522&action=edit [SIGNED-OFF] Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66197|0 |1 is obsolete|| --- Comment #119 from Aleisha Amohia --- Created attachment 66525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66525&action=edit [SIGNED-OFF] Bug 14385: Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66198|0 |1 is obsolete|| --- Comment #120 from Aleisha Amohia --- Created attachment 66526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66526&action=edit [SIGNED-OFF] Bug 14385: Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66196|0 |1 is obsolete|| --- Comment #118 from Aleisha Amohia --- Created attachment 66524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66524&action=edit [SIGNED-OFF] Bug 14385: Always use mocks, not set_preference Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66195|0 |1 is obsolete|| --- Comment #117 from Aleisha Amohia --- Created attachment 66523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66523&action=edit [SIGNED-OFF] Bug 14385: Added missing GetHiddenItems parameter change case Without this prove t had a failure. Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66193|0 |1 is obsolete|| --- Comment #115 from Aleisha Amohia --- Created attachment 66521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66521&action=edit [SIGNED-OFF] Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia changed: What|Removed |Added Attachment #66192|0 |1 is obsolete|| --- Comment #114 from Aleisha Amohia --- Created attachment 66520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66520&action=edit [SIGNED-OFF] Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=5592 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5592] circ rule cloning can be dangerous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5592 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19029 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5592] circ rule cloning can be dangerous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5592 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #2 from Alex Buckley --- Hi The patch I have attached to bug 19029 partially addresses the issues in this bug report. My patch provides a JavaScript security question asking the user to confirm that they want to Clone the circulation and fine rules when the Select a library option is set to 'Standard rules for all libraries'. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #4 from Alex Buckley --- Created attachment 66519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66519&action=edit Bug 19029 - Added JavaScript security question for cloning circ rules This patch introduces a Javascript security question which is displayed to the user when they try to clone a circulation rule to a specific branch when the rule is a 'Standard rule for all libraries" The rationale for this patch is when the cloning takes place it overwrites the existing rules of the destination branch and there is no notification of this to the user. Therefore by implementing this patch the user is asked if they want to clone the rule (if the rule is standard accross all libraries) and are told that it will overwrite the rules in the destination branch. Test plan: 1. Create a circulation rule for all libraries 2. Make sure the 'select a library' option is set to 'Standard rules for all libraries" 3. Click the 'Clone' button and notice that the cloning takes place without any warning that it will overwrite the rules of the destination branch 4. Apply patch 5. Return to the circulation and fine rules page 6. Repeat step 2 7. Click the clone button and notice a alert box appears asking if you are sure you want to clone the standard rule to the destination branch. Note: The name of the destination branch is included in the alert. Also note that the user is informed of the consequences of performing the action, i.e. that it will overwrite the existing rules in the destination branch 8. Click 'Cancel' and notice that no cloning occurs 9. Click the clone button again and this time click 'OK' and notice that the cloning takes place 10. Return to the Circulation and fine rules page and set the 'Select a library' option to the name of an individual branch 11. Click the clone button and notice that the clone action takes place Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Aleisha Amohia changed: What|Removed |Added Attachment #64937|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 66518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518&action=edit Bug 18915: Fix checkout note email message This patch replaces the <> in the email with <> and uses CHECKOUT_NOTE instead of PATRON_NOTE. This patch also adds the notice to installer/data/mysql/en/mandatory/sample_notices.sql, and updates the PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Jiri Kozlovsky changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #48 from Jiri Kozlovsky --- Changing this to Needs Sign-off (I can see no discussion in here) Btw Lari, nice job ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19180] Vendor name is missing from breadcrumbs when closing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19180] Vendor name is missing from breadcrumbs when closing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #1 from Aleisha Amohia --- Created attachment 66517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66517&action=edit Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19180] Vendor name is missing from breadcrumbs when closing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #54 from Aleisha Amohia --- Hi Josef I have one test failing in t/db_dependent/Circulation.t. I've pasted the output here: http://paste.koha-community.org/621 All other tests pass. Some notes from following the rest of your test plan: When deleting a collection, two different confirmation boxes pop up. (i know this is the behaviour before your patches) Deleting a collection with items was no different from deleting a collection without items (no error message to say the collection had items). No difference when returning an item in an untransferred collection and returning an item in a transferred collection I know the first point is the original behaviour before your patches. Unfortunately I can't test whether the second and third points are the expected behaviour because rotating collections appears to be broken for me without your patches! :) If the behaviour I've described is expected, then everything looks good. Setting to Failed QA for the failed test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19121] Prevent XSS in the Staff Client and the OPAC - bis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121
Chris Cormack changed:
What|Removed |Added
CC||ch...@bigballofwax.co.nz
--- Comment #9 from Chris Cormack ---
(In reply to Jonathan Druart from comment #7)
> Hi Robin,
>
> Thanks for your input!
>
> I have to admit that I should have explained what I have in mind a bit more.
> At the moment we are facing lot of XSS vulnerabilities caused by input
> parameters we sent to the template:
> $template->param( foo => scalar $cgi->param('foo') )
> and them [% foo %]
>
> That is our main problem.
>
> Of course the idea was not to insert escaped strings into the DB, but to
> trust data from DB (inserted from staff, not OPAC), and not url parameters.
> Which is wrong (!) and just move the escape problem to somewhere else (we
> will have to list the variable we trust and the ones we do not). I am
> obsoleting my proposal.
>
> Fixing XSS incrementally scared me. First it will be long and hard to be
> exhaustive, then we will not be regression proof.
This won't save us from stored XSS either, I think scripting adding the
|something to all non filtered output and changing the ones we don't want is
probably the safest way to go.
Long and annoying, but in the end easy to test for with QA scripts.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351
--- Comment #23 from Aleisha Amohia ---
(In reply to Marcel de Rooy from comment #22)
> +my @funds =
> Koha::Database->new()->schema->resultset('Aqbudget')->search({
> budget_period_id => $budgetperiod->{budget_period_id} });
>
> Please introduce a Koha Object for that one.
> Copy and paste operation. Should not be hard ;)
Hi Marcel,
Where is this line? It may have been fixed in a follow-up patch as I can't find
it in the most recent version.
Aleisha
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Alex Buckley changed: What|Removed |Added Attachment #65699|0 |1 is obsolete|| --- Comment #6 from Alex Buckley --- Created attachment 66516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66516&action=edit Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields This patch adds a note to the system preferences autonembernum and BorrowerMandatoryFields regarding a conflict if automembernum is on and BorrowerMandatoryFields contains cardnumber. To reproduce issue: See initial comment. To test: - Apply patch - Verify that in system preferences note appears with both prefs automembernum and BorrowerMandatoryFields Followed test plan, works as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Attachment #63221|0 |1 is obsolete|| Attachment #63222|0 |1 is obsolete|| Attachment #63223|0 |1 is obsolete|| --- Comment #16 from Aleisha Amohia --- Created attachment 66515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66515&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #17 from Alex Buckley --- Hi Christopher Your patch works as described and I have signed off on it, I have added your test plan from comment 2 onto the patch as I know it makes it easier for the Release Manager -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley changed: What|Removed |Added Attachment #66432|0 |1 is obsolete|| --- Comment #16 from Alex Buckley --- Created attachment 66514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66514&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail.pl and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Check another item that was not checked in. You should see the permanent location and not a secondary location. Followed test plan, patch worked as described. Passes QA test Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19189 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 Alex Buckley changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18974 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 --- Comment #1 from Alex Buckley --- Created attachment 66513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66513&action=edit Bug 19189 - OPAC reserve and renew selenium test This Selenium test will catalog an item using the Z39.50 target and add items to the biblio. Then it will test the OPAC reserve functionality and if the item is successfully reserved then the test outout 'Hold successfully placed will be displayed. Then the item is checked out to the patron in the intranet. Then the OPAC renew functionality is tested and if the reserve functionality is successful then the test output 'Item has been renewed' will be displayed Test plan (this test plan includes how to install Selenium as well as how to run this test, for the benefit of people who have not got Selenium installed on their machines): 1. wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar 2. vim /etc/apt/sources.list.d/firefox.list 3. Paste into the file: deb http://packages.linuxmint.com debian import 4. sudo apt-get update 5. sudo apt-get install firefox 6. sudo apt-get install xvfb 7. Set the SELENIUM_PATH vartiable: SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar 8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & 9. DISPLAY=:1 java -jar $SELENIUM_PATH Note: This will start up the selenium server. Everytime you want to shutdown this terminal window and want to restart Selenium just run the step 9 command to restart the Selenium server 10. Open a new terminal window and write in: git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch build/master --single-branch --depth 1 11. cd Selenium-Remote-Driver 12. perl Makefile.PL 13. make 14. make test 15. sudo make install 16. Now everything is installed and you can set up for running the selenium tests 17. Drop and recreate the Koha database and restart memcached 18. Go through the web installer installing all sample data and onboarding tool 19. Create a superlibrarian user with the username koha and password koha 20. If your usual port configuration for the intranet and OPAC is 8081 and 8080 respectively then set the staffClientBaseURL and OPACBaseURL system preferences to localhost:8080 and localhost:80 respectively 21. Make sure the OPACRenewalAllowed system preference is set to 'Allow' 22. Create a circulation and fine rule which allows multiple holds and holds per record 23. sudo koha-shell 24. perl t/db_dependent/selenium/opac_reserveitem.t 25. The test should pass. Note: The time_diff comments in the test output showing what the test is doing Note: If you have issues with installing Selenium and Selenium::Remote::Driver please write a comment on the bug report and I will be more than happy to create a screencapture video showing all the steps Note: Warns in front of the $driver->get_title() function have been implemented because during troubleshooting they were found to be an effective solution for stopping the test from failing due to not being able to find an element on the page. If anyone can suggest an alternative to using these warns please do Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19189] New: Reserving and renewing item in OPAC selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 Bug ID: 19189 Summary: Reserving and renewing item in OPAC selenium test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: alexbuck...@catalyst.net.nz Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org This Selenium test will start with a biblio being cataloged using a z39.50 target, then items are added. Then the OPAC reserve functionality is tested by loading the OPAC and placing a hold on the item. Then the item is checked out to the user in the intranet, and the OPAC renew functionality is tested by loading the OPAC and renewing the item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #14 from Katrin Fischer --- I have tested the web installer with MARC21 and UNIMARC, installing all sample files each time. There were no SQL errors. I would suggest to bring the Ukrainian installer more in line with the en installer long term, as this might help with new features like the onboarding tool and with updating in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer changed: What|Removed |Added Attachment #66382|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 66512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66512&action=edit Bug 18537 - Update Ukrainian installer sample files for 17.05 Update and translate sample SQL files of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear old fines as did recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Colin, I think the behaviour is still a bit odd. Your patch works, but only if the fine was created first. I think sequence should not matter? I have made sure to restart Plack after applying the patch: Test plan: 1) Created to fines, 1.00 each 2) Created a credit, 1.00 3) Balance is at 1.00 4) Pay amount of 1.00 1.00 is paid, Credit and other fine remain unchanged (amount <> 0) 1) Created a credit, 1.00 2) Created to fines, 1.00 each 3) Balance is at 1.00 4) Pay amount of 1.00 All amount outstanding are set to 0.00. Good. I appears it only works if the credit was created before the fines were. I used a fresh patron account for each test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18853] Allow to set different email addresses for sending emails from different modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18853 Katrin Fischer changed: What|Removed |Added Summary|Module wise email alerts|Allow to set different ||email addresses for sending ||emails from different ||modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18853] Module wise email alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18853 --- Comment #3 from Katrin Fischer --- Thx for clarifying! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18836] Table 'koha_library.club_enrollments' doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836 --- Comment #14 from Katrin Fischer --- Hi Freddy, same question to you: Are you running MySQL 5.7 by chance? See here: https://wiki.koha-community.org/wiki/Koha_on_Debian#Debian_Packages_on_Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #11 from Katrin Fischer --- Thx a lot, Josef! Works perfectly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added Attachment #66307|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 66511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66511&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #9 from Katrin Fischer --- Testing now - I think we might need a unit test for QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18503] Confusing hold and transfer dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Christopher, you might have run into bug 19116 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Filed bug 19187 - figured out it was OpacRenewalAllowed. Renewals are ok (sound and note), but no sound and note for successful checkouts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19187] Renewals are offered, but don' t work from the web based self check with OpacRenewalAllowed OFF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19187 Katrin Fischer changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer changed: What|Removed |Added Keywords||Academy Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19188] New: Self checkout: missing space if fine amount is blocking renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Bug ID: 19188 Summary: Self checkout: missing space if fine amount is blocking renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When a fine amount is blocking the renewal in the web based self checkout, the message reads like: ... EUR15.00 ... EUR is the active currency in my system, so display might vary a bit. We should add a space there and it might be nice to use the Price TT plugin for formatting the fine nicely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19187] Renewals are offered, but don' t work from the web based self check with OpacRenewalAllowed OFF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19187 Katrin Fischer changed: What|Removed |Added Summary|Renewals don't work from|Renewals are offered, but |the web based self check|don't work from the web ||based self check with ||OpacRenewalAllowed OFF --- Comment #1 from Katrin Fischer --- After some more testing OpacRenewalAllowed makes the difference. But the current behaviour makes no sense: Either we should not offer renewal functionality or it should work. :) I think it might be nice to have this controlled by a separate preference as the SCO is neither staff nor OPAC. If this ever worked, restoring former behaviour might be enough for a bug fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19187] Renewals don't work from the web based self check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19187 Katrin Fischer changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19187] New: Renewals don't work from the web based self check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19187 Bug ID: 19187 Summary: Renewals don't work from the web based self check Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org To test: - Check out an item via web based self check - Click on 'renew' button or enter barcode again - Renewal form should display, giving you 'renew' or 'cancel' as options - Click on 'renew' -> Note that nothing happens. Wonder if this is something in my setup, but anyway there should be a helpful message instead of just a page reload. Couldn't find any error in the logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19179] Email option for SMSSendDriver is not documented as a valid setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19179 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19186] SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19186 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19186] New: SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19186 Bug ID: 19186 Summary: SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #27 from Katrin Fischer --- I tried testing this, but ran into some problems: 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out I don't see the note in 9. Also renewals for me don't work. I tried to check out an item and immediately renew it. Nothing happens when I click on "renew item" - so I can't test this part. It's the same with and without the patch. Can someone confirm this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #15 from Katrin Fischer --- Looks better than before to me - I think at least it should have less surprises! These 2 options don't make so much sense to use together, but I think we can live with that until another iteration with a good idea: Don't export items: Remove items not owned by selected libraries: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827
Katrin Fischer changed:
What|Removed |Added
Attachment #66345|0 |1
is obsolete||
--- Comment #8 from Katrin Fischer ---
Created attachment 66510
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66510&action=edit
Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl
Signed-off-by: Serhij Dubyk {Сергій Дубик}
The "by" after the title was not translatable in the result
lists of the intranet. This patch fixes it by removing
a comment, that caused a problem with the translation
scripts.
To test:
Test:
Before this patch in file en-GB-marc-MARC21.po present next paragraph:
msgid "by "
msgstr " by "
According string "by " in the file MARC21slim2intranetResults.xsl can not be
translated (in other languages).
After applying this patch performed next command:
cd /usr/share/koha/misc/translator
sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update
Now in the file en-GB-marc-MARC21.po present the following (modified)
paragraph:
msgid "by "
msgstr " by "
https://bugs.koha-community.org/show_bug.cgi?id=17827
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Katrin Fischer --- Hi Serhij, thx for investigating! I have signed off on your patch with some little changes: - The subject should always start with "Bug " as this helps our tools to recognize what the patch is for and is used to link all the things together. - The patch commit message should contain a short description of the problem and the test plan (just copied your test plan in) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12095] Hold queue should take closed dates into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12095 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I think this should already be possible, see bug 12803 and system preference HoldsQueueSkipClosed! If this doesn't cover what you need, please add a step by step description of how the problem happens to make it more clear. *** This bug has been marked as a duplicate of bug 12803 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 --- Comment #12 from Katrin Fischer --- Magnus, I think you are right. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Katrin Fischer changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #84 from Katrin Fischer --- *** Bug 12095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
