[Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Katrin Fischer  ---
I think the reason for your problem is the version of MySQL, see here:

Koha does not work well with MySQL 5.7 which is shipped with Ubuntu 16.04. use
MariaDB instead. 
https://wiki.koha-community.org/wiki/Koha_on_Debian

I'd recommend switching to MariaDB and redoing the import.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248

--- Comment #2 from mks...@yahoo.com  ---
sir,

Thanks for your response. 

Versions of DBMS, Koha & Ubuntu are
Mysql-5.7.2
KKoha - 17.05
Ubuntu-16.04

Thanks 

K.Sivasamy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

--- Comment #23 from Aleisha Amohia  ---
Created attachment 66831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66831=edit
Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets

To test:
prove -v t/db_dependent/Koha/Acquisition/Baskets.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #66829|0   |1
is obsolete||

--- Comment #14 from Aleisha Amohia  ---
Created attachment 66830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66830=edit
Bug 12365 - Notes for rules

Lee Jamison  rescued this patch.
It is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.

To test:
Follow test plan in Comment 2

Signed-off-by: Mark Tompsett 

Signed-off-by: macon  lauren KohaCon17 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #64565|0   |1
is obsolete||

--- Comment #13 from Aleisha Amohia  ---
Created attachment 66829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66829=edit
Bug 12365 - Notes for rules

Lee Jamison  rescued this patch.
It is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.

To test:
Follow test plan in Comment 2

Signed-off-by: Mark Tompsett 

Signed-off-by: macon  lauren KohaCon17 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add item in LIST by Record number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add item in LIST by Record number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

--- Comment #14 from Aleisha Amohia  ---
Created attachment 66828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66828=edit
Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio

Ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #10 from Aleisha Amohia  ---
Created attachment 66827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66827=edit
Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places

As suggested in Comment 7.
The timestamp has also been added to printfeercpt.tt, printinvoice.tt,
and opac-account.tt

To test:
1) In Staff side, go to member account, go to Fines, go to Account tab
2) Click the Print button next to a payment
3) Confirm timestamp shows on print slip
4) Create a manual invoice
5) Go back to the Account tab
6) Click the Print button next to the invoice
7) Confirm timestamp shows on print slip
8) Log into OPAC
9) Go to your fines
10) Confirm timestamp shows

Ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #9 from Aleisha Amohia  ---
Created attachment 66826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66826=edit
Bug 16486: [FOLLOW-UP] Putting time in date column

In reply to Comment 6, I have moved the time into a column separate from
the description. Unfortunately the timestamp has the date and the time,
so I figured it was easier to just have them in the same column and
replace the original date column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19251] New: Show book drop information in the Checkout History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19251

Bug ID: 19251
   Summary: Show book drop information in the Checkout History
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, josef.mora...@gmail.com,
kyle.m.h...@gmail.com, r...@rbit.cz
Depends on: 18994

All drop box check-ins will be marked and showed in history together with
branch name.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994
[Bug 18994] Show the branch name where checkin occurred on a title's Checkout
History display
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title' s Checkout History display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994

Mike  changed:

   What|Removed |Added

 Blocks||19251


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19251
[Bug 19251] Show book drop information in the Checkout History
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title' s Checkout History display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994

--- Comment #2 from Mike  ---
Info where was checkin occured is very useful for us too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title' s Checkout History display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

--- Comment #17 from Katrin Fischer  ---
Created attachment 66825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66825=edit
Bug 13766 - Follow-up - use index_exists()

Changes check for existing index to use index_exists.
Also checks deletedbiblioitems for an existing ean index
and drops it if one is found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #19 from Katrin Fischer  ---
is( $hold->found, "T", 'Hold is in transit' );
before you return it again at the pickup library. No matter what I try, I only
get 'undef'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #18 from Katrin Fischer  ---
The problem is that the item is not in transit, but I haven't figured out how
to fix the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Component|Architecture, internals,|REST api
   |and plumbing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #17 from Katrin Fischer  ---
If I am reading the test correctly, you miss returning in the library the item
is 'sourced at' in order to create the transport status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|REST API: add routes to |Add routes to list
   |list libraries  |libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] REST API: add routes to list libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
  Component|Web services|REST api

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi, can you share the version of your DBMS and the Koha version you tried to
install, please?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||19196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
[Bug 19196] Add pagination helpers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19250] New: Add pagination to /acquisitions/vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

Bug ID: 19250
   Summary: Add pagination to /acquisitions/vendors
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

The vendors listing endpoint should provide a way to have pagination. Should be
straightforward with bug 19196.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #16 from Jonathan Druart  
---
I do not recreate the issue with tests, someone else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #15 from Jonathan Druart  
---
Created attachment 66824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66824=edit
Bug 19116: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19077] When loading patrons matching on userid updates to matched patrons are rejected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED

--- Comment #5 from Jonathan Druart  
---
Closing, reopen if it is still needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #32 from Jonathan Druart  
---
+ Add more POD to explain what the script actually does.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #57 from Jonathan Druart  
---
Tests do not pass!

t/db_dependent/Circulation/Chargelostitem.t .. Can't locate C4/Branch.pm in
@INC (you may need to install the C4::Branch module)

C4::Branch has been removed months ago.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #14 from Katrin Fischer  ---
Can someone help out here and write the tests necessary please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Jonathan Druart  changed:

   What|Removed |Added

Summary|koha-rebuild-zebra -f -v|koha-rebuild-zebra is
   |koha|failing with "error
   ||retrieving biblio"
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
Version|17.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18927] koha-rebuild-zebra -f -v koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

--- Comment #4 from Jonathan Druart  
---
Created attachment 66823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66823=edit
Bug 18927: Use fully qualified subroutine names in C4::Items

rebuild_zebra.pl fails in some conditions (perl version?)
I do not recreate but it has been reported that reindex fails with:
  error retrieving biblio 94540 at
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683,  line 751.

To fix it we can use fully qualified subroutine names for:
  GetMarcFromKohaField
  GetMarcBiblio
  GetBiblionumberFromItemnumber
  TransformKohaToMarc
  GetFrameworkCode

Test plan:
Confirm the rebuild_zebra script still works correctly after this patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18927] koha-rebuild-zebra -f -v koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

Lucy Vaux-Harvey  changed:

   What|Removed |Added

 CC||lucy.vaux-harvey@ptfs-europ
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

--- Comment #13 from Tomás Cohen Arazi  ---
Patches reworked so the resulting pagination links preserve the query params
:-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66658|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 66822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66822=edit
Bug 19196: Make plugin available to endpoints

This patch just initializes the plugin on the main controller class so
it is available for all endpoints to use.

As it is not used, in order to test just restart plack and make sure the
endpoints work (run the t/db_dependent/api/v1 tests).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66657|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 66821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66821=edit
Bug 19196: Add Koha::REST::Plugin::Pagination

This patch introduces a Mojolicious plugin to be used on the REST api.
It adds a helper method:

add_pagination_headers
==

When used, it adds a _Link_ header to the reponse with the calculated
values for pagination, and X-Total-Count containing the total results
like this:

my $params  = $c->validation->output;
my $patrons = Koha::Patrons->search;
my $count   = $patrons->count;

$c->add_pagination_headers({
total  => $count,
params => $params )};

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater solutions
Sponsored-by: Camden County

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66656|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 66820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66820=edit
Bug 19196: Unit tests

This patch adds unit tests for the new pagination Mojo plugin.

Sponsored-by: ByWater Solutions
Sponsored-by: Camden County

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19249] date picker broken in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #119 from Tomás Cohen Arazi  ---
Rebased against master, which changed Koha::REST::V1::Hold a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66806|0   |1
is obsolete||

--- Comment #116 from Tomás Cohen Arazi  ---
Created attachment 66817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66817=edit
Bug 18137: (follow-up) Sort definitions.json

Before this file grows, we should sort it alphabetically.

To test:
1. prove t/db_dependent/api/v1

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66808|0   |1
is obsolete||

--- Comment #118 from Tomás Cohen Arazi  ---
Created attachment 66819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66819=edit
Bug 18137: (QA followup) Make sure the session exists and is expired on
expiration tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66804|0   |1
is obsolete||

--- Comment #114 from Tomás Cohen Arazi  ---
Created attachment 66815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66815=edit
Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages

- DBIx::Class::Exception should use ->{msg}

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66805|0   |1
is obsolete||

--- Comment #115 from Tomás Cohen Arazi  ---
Created attachment 66816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66816=edit
Bug 18137: (QA-follow-up) Fix pod fail

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66807|0   |1
is obsolete||

--- Comment #117 from Tomás Cohen Arazi  ---
Created attachment 66818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66818=edit
Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as
dependencies

Edit (tcohen): I've changed the version numbers to match those Mirko has
already
successfully packaged and are known to work for this patchset.

Signed-off-by: Olli-Antti Kivilahti 
Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66803|0   |1
is obsolete||

--- Comment #113 from Tomás Cohen Arazi  ---
Created attachment 66814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66814=edit
Bug 18137: Remove x-mojo-around-action

Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch
removes it from our specification document.

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66802|0   |1
is obsolete||

--- Comment #112 from Tomás Cohen Arazi  ---
Created attachment 66813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66813=edit
Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible

Also
- adding some missing and new response definitions into Swagger spec.
- fixing failing tests due to Bug 17932's change of boolean values

To test:
1. prove t/db_dependent/api/v1/holds.t

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65108|0   |1
is obsolete||

--- Comment #110 from Tomás Cohen Arazi  ---
Created attachment 66811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66811=edit
Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible

Also:
- adding some missing and new response definitions into Swagger spec.
- fixing failing test due to Bug 17932's change of boolean values

To test:
1. prove t/db_dependent/api/v1/patrons.t

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65109|0   |1
is obsolete||

--- Comment #111 from Tomás Cohen Arazi  ---
Created attachment 66812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66812=edit
Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible

Also:
- adding some missing and new response definitions into Swagger spec.

To test:
1. prove t/db_dependent/api/v1/cities.t

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65106|0   |1
is obsolete||

--- Comment #108 from Tomás Cohen Arazi  ---
Created attachment 66809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66809=edit
Bug 18137: Add useful Koha::Exceptions

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65714|0   |1
is obsolete||

--- Comment #107 from Tomás Cohen Arazi  ---
Created attachment 66808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66808=edit
Bug 18137: (QA followup) Make sure the session exists and is expired on
expiration tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65107|0   |1
is obsolete||

--- Comment #109 from Tomás Cohen Arazi  ---
Created attachment 66810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66810=edit
Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI

This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2
is
no longer actively maintained.

This migration involves some minor changes to our Swagger specification
documents
and to controllers. Each operation is migrated in following patches separately.
Please see Mojolicious::Plugin::OpenAPI and its tutorial for more
documentation.

The patch also refactors some API authentication -related code by taking
advantage
of Koha::Exceptions. Authentication is now handled via Mojolicious's
"under->to"
functionality. The actual authentication & authorization checks are moved to
Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is
required, instead of returning an authentication failure as before.

To test:
1. prove t/db_dependent/api/v1/auth.t

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65112|0   |1
is obsolete||

--- Comment #103 from Tomás Cohen Arazi  ---
Created attachment 66804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66804=edit
Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages

- DBIx::Class::Exception should use ->{msg}

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65114|0   |1
is obsolete||

--- Comment #105 from Tomás Cohen Arazi  ---
Created attachment 66806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66806=edit
Bug 18137: (follow-up) Sort definitions.json

Before this file grows, we should sort it alphabetically.

To test:
1. prove t/db_dependent/api/v1

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65404|0   |1
is obsolete||

--- Comment #106 from Tomás Cohen Arazi  ---
Created attachment 66807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66807=edit
Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as
dependencies

Edit (tcohen): I've changed the version numbers to match those Mirko has
already
successfully packaged and are known to work for this patchset.

Signed-off-by: Olli-Antti Kivilahti 
Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65110|0   |1
is obsolete||

--- Comment #101 from Tomás Cohen Arazi  ---
Created attachment 66802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66802=edit
Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible

Also
- adding some missing and new response definitions into Swagger spec.
- fixing failing tests due to Bug 17932's change of boolean values

To test:
1. prove t/db_dependent/api/v1/holds.t

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65113|0   |1
is obsolete||

--- Comment #104 from Tomás Cohen Arazi  ---
Created attachment 66805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66805=edit
Bug 18137: (QA-follow-up) Fix pod fail

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65111|0   |1
is obsolete||

--- Comment #102 from Tomás Cohen Arazi  ---
Created attachment 66803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66803=edit
Bug 18137: Remove x-mojo-around-action

Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch
removes it from our specification document.

Signed-off-by: Olli-Antti Kivilahti 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19245] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19245

Jonathan Druart  changed:

   What|Removed |Added

Summary|numpang lewat   |SPAM
Product|Koha security   |Koha
  Component|Koha|Architecture, internals,
   ||and plumbing
   Severity|critical|minor
 QA Contact||testo...@bugs.koha-communit
   ||y.org
 Resolution|--- |INVALID
  Group|Koha security   |
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Magnus Enger  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Magnus Enger  ---
On further inspection it looks like this is completely fixed by bug 19025.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Magnus Enger  changed:

   What|Removed |Added

  Attachment #45800|0   |1
is obsolete||

--- Comment #15 from Magnus Enger  ---
Comment on attachment 45800
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45800
Bug 12204: Display the expiration date on RESERVESLIP

Bug 19025 makes this patch obsolete. But the problem described in the bug
report remains, as far as I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

--- Comment #14 from Magnus Enger  ---
Looks like bug 19025 pulled the rug out from underneath this patch between my
comment and that from Jonathan. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19249] date picker broken in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

--- Comment #1 from Fridolin SOMERS  ---
Also date of birth has a small JS code showing age when date is changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19249] date picker broken in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||christophe.croullebois@bibl
   ||ibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19249] date picker broken in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||3534


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534
[Bug 3534] Patron quick add form
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19249] date picker broken in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17344

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||19249


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249
[Bug 19249] date picker broken in quick add brief form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17344] Can't set guarantor in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19249] New: date picker broken in quick add brief form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Bug ID: 19249
   Summary: date picker broken in quick add brief form
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a date input like date of birth is mandatory, in quick add brief form the
calendar icon appears but clicking on it does nothing.
This is because quick add brief form creates a clone of inputs in the original
form.
An input with date picker is changed and linked to Javascript code (see
calendar.inc) so it can not be cloned.

Note also that creating a clone of an input in another form does not update the
form value in its DOM. It can generate errors.

In my opinion this feature should be reconsidered to hide unwanted fields
instead of cloning wanted ones. Many bugs may be avoided.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

--- Comment #6 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #5)
> (In reply to Marcel de Rooy from comment #4)
> > (In reply to Tomás Cohen Arazi from comment #3)
> > > Marcel, I agree with the removal, but you seem to be fixing a bug in the
> > > meantime (which I'm not against per-se) but I think if falls short, as we
> > > should be warning or similar about those non-existing authority records.
> > 
> > This is about two checks?
> > [1] opac-authoritiesdetail
> > -my $authtypecode = $authority->authtypecode;
> > +my $authtypecode = $authority ? $authority->authtypecode : q{};
> > This does not fall short. It actually is only theoretical. If GetAuthority
> > fails, the script redirects to 404.
> > 
> > [2] authorities/detail.pl
> > -my $authtypecode = Koha::Authorities->find($authid)->authtypecode;
> > +my $authobj = Koha::Authorities->find($authid);
> > +my $authtypecode = $authobj ? $authobj->authtypecode: q{};
> > Similar here. This check just prevents an ISE on authtypecode while a few
> > lines later the output of GetAuthority is checked and an error is printed
> > via the template. So no, it does not fall short.
> > 
> > Please explain why this fails QA.
> 
> It is not a big deal, I just would like the script to warn (in the logs) in
> addition to the fallback to empty string.
We do not need these warns. As mentioned, the script either redirects to 404 or
prints an error already.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #4)
> (In reply to Tomás Cohen Arazi from comment #3)
> > Marcel, I agree with the removal, but you seem to be fixing a bug in the
> > meantime (which I'm not against per-se) but I think if falls short, as we
> > should be warning or similar about those non-existing authority records.
> 
> This is about two checks?
> [1] opac-authoritiesdetail
> -my $authtypecode = $authority->authtypecode;
> +my $authtypecode = $authority ? $authority->authtypecode : q{};
> This does not fall short. It actually is only theoretical. If GetAuthority
> fails, the script redirects to 404.
> 
> [2] authorities/detail.pl
> -my $authtypecode = Koha::Authorities->find($authid)->authtypecode;
> +my $authobj = Koha::Authorities->find($authid);
> +my $authtypecode = $authobj ? $authobj->authtypecode: q{};
> Similar here. This check just prevents an ISE on authtypecode while a few
> lines later the output of GetAuthority is checked and an error is printed
> via the template. So no, it does not fall short.
> 
> Please explain why this fails QA.

It is not a big deal, I just would like the script to warn (in the logs) in
addition to the fallback to empty string.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #6 from Katrin Fischer  ---
Hi Hugo, please add your sign-off line to patche that you mark as signed off.
Instructions on how to do this can be found on the wiki.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #36 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #35)
> (In reply to Kyle M Hall from comment #30)
> > Marcel, Colin, can you try out this version? It's an update of Colin's 
> > patch.
> 
> Looking back. I see that the patch dates from June 13 and I submitted a
> comment on July 14. No changes after that?

No, wait. You changed obsoleted flags..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #35 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #30)
> Marcel, Colin, can you try out this version? It's an update of Colin's patch.

Looking back. I see that the patch dates from June 13 and I submitted a comment
on July 14. No changes after that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #34 from Marcel de Rooy  ---
(In reply to Colin Campbell from comment #32)
> (In reply to Marcel de Rooy from comment #31)
> > +foreach my $key ( keys %{$href} ) {
> > +if ( $key =~ m/[^A-Z_]/ ) {
> > +delete $href->{$key};
> > +}
> > 
> > Don't understand this. You are deleting the uppercase keys ? SHouldn't you
> > do the reverse ?
> 
> No that deletes lowercase [^A-Z] is a negated character class (includes
> lowercase and non alpha)

Of course, missed that somehow..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #28 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #20)
> Marcel - I fixed a problem in tests and provide an alternate to the
> exceptions, does this seem reasonable?
> 
> -Nick

Yes, looks good to me. 
Did you finish QA on this one with these adjustments?
If so, please dont forget to add a signoff and change status.
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66316|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66314|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66315|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66313|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66751|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #22 from Marcel de Rooy  ---
Created attachment 66796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66796=edit
Bug 17380: Add some checks around Authorities::Types->find

Resolves:
Use of uninitialized value $biblio_fields in scalar chop at
authorities/detail.pl line 212.
Can't call method "authtypetext" on an undefined value at authorities/detail.pl
line 216.
Can't call method "authtypecode" on an undefined value at authorities/detail.pl
line 180.

NOTE: Some of these problems have actually been resolved now by bugs 18801
and 18811, but it is still better imo to have these checks.

Test plan:
[1] Verify unchanged behavior. Search for some authorities on authorities.pl
and click on the details of a record.
[2] Open an authorities detail page and change the authid in the URL to a
not existing number. Instead of an internal server error, you should see
a message like "The authority record you requested does not exist".

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #23 from Marcel de Rooy  ---
Created attachment 66797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66797=edit
Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority

If we got an authtypecode from the database and this value is not NULL
since the table column does not allow it, there is no need to call
GuessAuthTypeCode for empty string (read: Default framework) in the
sub get_from_authid.

Furthermore, we remove three Koha::MetadataRecord::Authority->new calls.
They are useless, since we do not pass a record. It just generates:
  No record passed at authorities/merge.pl line 96.
  Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66.
Instead we throw an ObjectNotFound exception.

Test plan:
[1] Run t/db_dependent/Koha_Authority.t
[2] Interface will be tested in the following patches.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #27 from Marcel de Rooy  ---
Created attachment 66801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66801=edit
Bug 17380: [QA Follow-up] Report error to user instead of throwing exception

Internal server errors are good, user feedback is better.

Signed-off-by: Marcel de Rooy 
Tiny change: removed the obsolete 'use Koha::Exceptions'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #25 from Marcel de Rooy  ---
Created attachment 66799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66799=edit
Bug 17380: Do not allow Default template in merge form

This patch makes the following changes:
[1] Removes Default from the template list. We should not merge with the
Default framework, since it does not have a reporting tag.
[2] Rearranges the error section in the template. It is confusing to have
two error sections in this template. The error CANNOT_MOVE is not used.
The error FRAMEWORK_NOT_SELECTED is replaced by WRONG_FRAMEWORK.
[3] Do not allow to merge a record with itself.
[4] Check if the merge reference record still contains any MARC tags.
[5] Additional polishing: Simplify passing frameworks to template. Remove
an unused Koha::Authority::Types->search. Remove obsolete POD header
for functions from the script.

Test plan:
[1] Select two authorities to merge. Verify that you cannot select Default
anymore as framework for the reference record.
[2] Reproduce error WRONG_COUNT by adding another authid=999 in the URL
after you selected two authority records for merging.
[3] Remove the third authid from the URL and change the first or second
authid into an unexisting record id. You should generate an Internal
Server Error. The log should show the exception message.
[4] Merge two authorities. Deselect all MARC tags. Should trigger the
error EMPTY_MARC in the template.
[5] Select the same authority record twice for merging. Should trigger the
error DESTRUCTIVE_MERGE in the template.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #24 from Marcel de Rooy  ---
Created attachment 66798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66798=edit
Bug 17380: Graceful resolution of missing reporting tag in merge

Altough this patch deals with a mostly hypothetical case and this report
makes it practically impossible anymore to merge with records in the
Default framework (having no reporting tag), we can make the code of
sub merge still a bit more robust here.

If you would merge biblio records from one authtype to another and the new
framework would not have a reporting tag, before this patch the result would
be data loss. Merge would handle this request as a delete. This patch makes
merge handle it differently: instead of clearing the biblio records, it
keeps $a and $9 in order to make a future corrective merge possible.

Note: The additional condition on line 1468 for $tags_using_authtype
makes sure that we do not select all fields when the authtype should
unexpectedly be empty string (Default). This prevents crashing on
a "Control fields do not have subfields" error.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66750|0   |1
is obsolete||

--- Comment #26 from Marcel de Rooy  ---
Created attachment 66800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66800=edit
Bug 17380: (QA followup) Fix parameter in tests

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19248] New: install.pl: DBD::mysql::st execute failed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248

Bug ID: 19248
   Summary: install.pl: DBD::mysql::st execute failed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k.shivasw...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 66795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66795=edit
Koha>Web Insteller> error

The following error occurred while importing the database structure:

[Mon Sep 4 13:12:33 2017] install.pl: DBD::mysql::st execute failed: Invalid
default value for 'date_created' at /usr/share/perl5/DBIx/RunSQL.pm line 273.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1022] DBD::mysql::st fetchrow failed: fetch() without execute()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1022

mks...@yahoo.com  changed:

   What|Removed |Added

 CC||k.shivasw...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #21 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #18)
> Created attachment 66750 [details] [review]
> Bug 17380: (QA followup) Fix parameter in tests

This has to do with the pushed enhancement that changes prototype of
GetMarcBiblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

--- Comment #25 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #24)
> Note: Since Subfield and Tag only contain one sub which is considered as
> private by Pod::Coverage, these modules are listed as unrated (no public
> symbols defined) and trigger a FAIL on pod coverage in qa tools. This fail
> can be ignored.

This is true for all 'empty' singular Koha objects.
Could be resolved by renaming _type to type, or adding another public symbol.
Should be done on another report, if we really feel the need to do so. We can
just ignore them too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

--- Comment #24 from Marcel de Rooy  ---
Created attachment 66794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66794=edit
Bug 18811: [QA Follow-up] Resolved POD warnings

Trivial changes to silence qa tools on POD warnings for Subfields and Tags.

Note: Since Subfield and Tag only contain one sub which is considered as
private by Pod::Coverage, these modules are listed as unrated (no public
symbols defined) and trigger a FAIL on pod coverage in qa tools. This fail
can be ignored.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17039] No cancel/new item option when editing an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17039

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ha...@orex.es

--- Comment #2 from Hugo Agud  ---
I have applied the patch and it works fine!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/