[Koha-bugs] [Bug 19178] Remove outdated sms/* scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Magnus Enger changed: What|Removed |Added Attachment #66832|0 |1 is obsolete|| --- Comment #7 from Magnus Enger --- Created attachment 66833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66833&action=edit Bug 19178 - Remove outdated sms/* scripts and related files Those files appear unmaintained and unusable with current Koha and should be removed. It appears at some point there was work done on a feature to send SMS messages to a phone number using a form in the tools area. This has never been documented, files and git history make it look like work remained unfinished. sms/sms_listen_windows_start.pl - targetted for Windows, which is not supported by Koha 00-strict.t - reference to sms removed sms/sms_listen.pl - refers to a table sms_messages that doesn't exist - uses getmember() that doesn't exist sms/sms.pl - script calls routines that no longer exist in SMS.pm error_codes(), parse_phone(), write_sms() - template sms-home.tt is not accessible form anywhere in the templates sms-home.tt - see sms/sms.pl Signed-off-by: Magnus Enger Makes sense. 00-strict.t runs OK after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19178] Remove outdated sms/* scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18741] Web installer does not load default data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741 --- Comment #9 from Julian Maurice --- (In reply to Katrin Fischer from comment #7) > Dependency is not in 16.11.x - so this is probably not be needed there. > Also: doesn't apply. Since this comment, bug 18632 was pushed in 16.11.x and 16.05.x, so the fix is now needed in these versions too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19227] 00-merge-conflict-markers.t launches too many tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19227 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19227] 00-merge-conflict-markers.t launches too many tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19227 Magnus Enger changed: What|Removed |Added Attachment #66673|0 |1 is obsolete|| --- Comment #2 from Magnus Enger --- Created attachment 66834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66834&action=edit Bug 19227: Reduce the number of tests run by 00-merge-conflict-markers.t The number of tests on jenkins is sometimes confusing: https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/testReport/(root)/t_00_merge_conflict_markers_t/ shows that 00-merge-conflict-markers.t ran 10,751 tests, 124 less than the previous run. However 124 files have not been removed from the codebase! I suggest to count only 1 test for all files. Moreover files from blib and cover_db are counted, they should be excluded. Test plan: prove t/00-merge-conflict-markers.t must return green echo ">>>" >> mainpage.pl and run the test again It should now fail Signed-off-by: Magnus Enger Works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18741] Web installer does not load default data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741 --- Comment #10 from Julian Maurice --- Created attachment 66835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66835&action=edit [16.11.x] Bug 18741: Fix loading of SQL files in web installer Test plan: 1. Start a normal install using the web installer 2. When asked to select data to load, verify that 'message_transport_types' is checked, and check some optional data files 3. Continue the install to the end 4. Verify that message_transport_types is not empty, and that the optional data you checked is there Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Lyle Kozloff changed: What|Removed |Added CC||l...@lyle.work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 --- Comment #4 from mks...@yahoo.com --- Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19196] Add pagination helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
Benjamin Rokseth changed:
What|Removed |Added
CC||benjamin.roks...@kul.oslo.k
||ommune.no
--- Comment #14 from Benjamin Rokseth ---
Great work Tomas.
please fix typo in your example ;)
> $c->add_pagination_headers({
>total => $count,
>params => $params )};
and add some sensible defaults (10/10?) to page and per_page so Pagination.pm
doesnt die if none is given as params.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10707] inventory not removing lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #4 from Séverine Queune --- I just apply the plan test in our local Koha (16.11.11). The "lost" status is correctly reset and the last seen date is fixed on the today date. It seems this bug can be closed. Do I need change it to "RESOLVED" or one of the QA team want to check first ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19252] New: Upgrading message shows identical Version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19252 Bug ID: 19252 Summary: Upgrading message shows identical Version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 66836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66836&action=edit Screenshot upgrading message with identical version in web installer While upgrading, the web installer shows a message similar like "We are upgrading from Koha 17.06.00.004 to 17.06.00.004" Expected: Different version numbers for "from" and for "to". It seems that dbversion and kohaversion are the same in installer/step3.tt (see screenshot). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16497] Add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
--- Comment #19 from Benjamin Rokseth ---
Created attachment 66837
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66837&action=edit
Bug 16497: [REST] Add /api/v1/libraries
CRUD for libraries via REST API.
GET/api/v1/libraries - List all libraries
GET/api/v1/libraries/{branchcode} - Get one Library
POST /api/v1/libraries - Add new Library
DELETE /api/v1/libraries/{branchcode} - Delete Library
Test plan:
- apply patch
- run tests: t/db_dependent/api/v1/libraries.t
- test API with some API tool or simple curl
e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl
Signed-off-by: Josef Moravec
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16497] Add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #20 from Benjamin Rokseth --- Created attachment 66838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66838&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16497] Add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth changed: What|Removed |Added Attachment #63161|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16497] Add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth changed: What|Removed |Added Attachment #63160|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #31 from Mason James --- (In reply to Katrin Fischer from comment #29) > Thx Fridolin for providing the patch! > > This patch has been pushed to 16.11.x and will be in 16.11.11. hi Cait i think 16.11.11 is missing this patch.. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63546 ..currently patron search seems broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19035] Stored XSS in patron lists - lists.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19035 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19114] Stored XSS in parcels.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19114 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19165] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What|Removed |Added Attachment #66464|0 |1 is obsolete|| Attachment #66474|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 66839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66839&action=edit Bug 19173 - Make OPAC online payments pluggable While PayPal is fairly universal, there is a plethora of online payment system that are far more localized, servicing a single country ( e.g. Bug 18968 ) or even a single city! Instead of adding support for each and every one of these payment options directly into Koha, it makes more sense to add the ability to create online payment plugins. Test Plan: 1) Apply this patch 2) Download and install the Kitchen Sink plugin version 2.1.1 or later https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases 3) In the plugin options, enable the opac payments option 4) Create a patron with one or more fines 5) Log into the opac as that patron, note you now have the option to pay online via KitchenSink ImaginaryPay 6) Make an online payment 7) Note the payment was processed correctly Signed-off-by: Magnus Enger Awesome enhancement! I know we want to add at least one Norwegian payment service at some point. I followed the test plan and everything works as advertised. Turning off the "opac payments option" makes the option dissappear cleanly from the OPAC. I have *not* looked at the code or done any considerations about security. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 --- Comment #8 from Kyle M Hall --- Created attachment 66840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66840&action=edit Bug 19173 [Followup] - Add opac payment and marc conversion plugins to the pulldown filter list Signed-off-by: Magnus Enger New categories are added to the pulldown and work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What|Removed |Added Attachment #66839|0 |1 is obsolete|| Attachment #66840|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 66841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66841&action=edit Bug 19173 - Make OPAC online payments pluggable While PayPal is fairly universal, there is a plethora of online payment system that are far more localized, servicing a single country ( e.g. Bug 18968 ) or even a single city! Instead of adding support for each and every one of these payment options directly into Koha, it makes more sense to add the ability to create online payment plugins. Test Plan: 1) Apply this patch 2) Download and install the Kitchen Sink plugin version 2.1.1 or later https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases 3) In the plugin options, enable the opac payments option 4) Create a patron with one or more fines 5) Log into the opac as that patron, note you now have the option to pay online via KitchenSink ImaginaryPay 6) Make an online payment 7) Note the payment was processed correctly Sponsored-by: Washoe County Library System Signed-off-by: Kyle M Hall Signed-off-by: Magnus Enger Awesome enhancement! I know we want to add at least one Norwegian payment service at some point. I followed the test plan and everything works as advertised. Turning off the "opac payments option" makes the option dissappear cleanly from the OPAC. I have *not* looked at the code or done any considerations about security. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 --- Comment #10 from Kyle M Hall --- Created attachment 66842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66842&action=edit Bug 19173 [Followup] - Add opac payment and marc conversion plugins to the pulldown filter list Signed-off-by: Magnus Enger New categories are added to the pulldown and work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What|Removed |Added Comment #7 is|1 |0 private|| Comment #8 is|1 |0 private|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1356] Lose original search term when select "More options"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1356 Evro Ofranto changed: What|Removed |Added CC||evroofrant...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19254] New: Bug ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19254 Bug ID: 19254 Summary: Bug ID Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleon...@myacpl.org Reporter: evroofrant...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 66844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66844&action=edit Akatsuki Was Here Herein record bugs concerning cases where Koha behaves in unexpected ways or fails depending on the web browser being used. Applies to both staff and OPAC bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What|Removed |Added Attachment #56579|0 |1 is obsolete|| --- Comment #10 from Benjamin Rokseth --- Created attachment 66845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66845&action=edit Bug 16694 - Limit SIP2 auth by patron attribute The main use case of this bug is to use patron attributes to grant special privileges, e.g. to open a door to an unmanned library. This patch adds an extra check against patron attributes if login account in SIPconfig.xml has a key validate_patron_attribute set to some patron attribute. If a patron information request is sent (63), and patron has proper rights in the given attribute: (a value of 1/true or some authorised value mapping to 1) The user will be allowed access (in SIP: charge and/or renewal ok). Otherwise denied. Please note that this is specific to the SIP login account, so self checkout machines can be handled differently than e.g. a door card terminal. To test: 0) you need to debug using telnet or the koha provided sip_client 1) add validate_patron_attribute="testattribute" to some login account in SIPconfig.xml 2) add a patron attribute "testattribute" 3) edit some patron and set "testattribute" to "1" 4) do a sip login with the given login account from SIPconfig.xml 5) do a patron information request (63) on the patron 6) observe that no charge or renewal denied is given in the response (64 ) 7) try all or any of the following: - set patron attribute to anything but "1" - delete the patron attribute - map the patron attribute to an authorized list, e.g. (YES_NO) and set it to a value that doesn't map to "1", e.g. "No". 8) do a patron information request (63) again 9) observe that charge and renewal is now denied in the SIP response (64YY) 10) thank yourself if noone else does and grab a coffee Signed-off-by: Magnus Enger Took me a while to remember I was on a gitified setup and needed to do sudo cp C4/SIP/Sip/MsgType.pm /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm before I could test properly. Works as expected. I have a Swedish customer running a similar hack in production, so looking forward to getting this into Koha proper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #11 from Benjamin Rokseth --- rebased against master. Ignoring failing test 'Checkin V2' as it has no bearing on this bug and should be resolved in another bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #12 from Benjamin Rokseth --- Created attachment 66846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66846&action=edit Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What|Removed |Added Attachment #66846|0 |1 is obsolete|| --- Comment #13 from Benjamin Rokseth --- Created attachment 66847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66847&action=edit Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What|Removed |Added Attachment #66847|0 |1 is obsolete|| --- Comment #14 from Benjamin Rokseth --- Created attachment 66848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66848&action=edit Bug 16694 - Limit SIP2 auth by patron attribute The main use case of this bug is to use patron attributes to grant special privileges, e.g. to open a door to an unmanned library. This patch adds an extra check against patron attributes if login account in SIPconfig.xml has a key validate_patron_attribute set to some patron attribute. If a patron information request is sent (63), and patron has proper rights in the given attribute: (a value of 1/true or some authorised value mapping to 1) The user will be allowed access (in SIP: charge and/or renewal ok). Otherwise denied. Please note that this is specific to the SIP login account, so self checkout machines can be handled differently than e.g. a door card terminal. To test: 0) you need to debug using telnet or the koha provided sip_client 1) add validate_patron_attribute="testattribute" to some login account in SIPconfig.xml 2) add a patron attribute "testattribute" 3) edit some patron and set "testattribute" to "1" 4) do a sip login with the given login account from SIPconfig.xml 5) do a patron information request (63) on the patron 6) observe that no charge or renewal denied is given in the response (64 ) 7) try all or any of the following: - set patron attribute to anything but "1" - delete the patron attribute - map the patron attribute to an authorized list, e.g. (YES_NO) and set it to a value that doesn't map to "1", e.g. "No". 8) do a patron information request (63) again 9) observe that charge and renewal is now denied in the SIP response (64YY) 10) thank yourself if noone else does and grab a coffee Signed-off-by: Magnus Enger Took me a while to remember I was on a gitified setup and needed to do sudo cp C4/SIP/Sip/MsgType.pm /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm before I could test properly. Works as expected. I have a Swedish customer running a similar hack in production, so looking forward to getting this into Koha proper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What|Removed |Added Attachment #66845|0 |1 is obsolete|| --- Comment #15 from Benjamin Rokseth --- Created attachment 66849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66849&action=edit Bug 16694 - Add tests to t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #16 from Marcel de Rooy --- (In reply to Benjamin Rokseth from comment #11) > rebased against master. > > Ignoring failing test 'Checkin V2' as it has no bearing on this bug and > should be resolved in another bug The test passes with me btw. Please copy your test results in a comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #17 from Benjamin Rokseth --- needs another signoff on added tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19253] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19253 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Component|Koha|Architecture, internals, ||and plumbing Summary|We Are |SPAM Status|NEW |RESOLVED Product|Koha security |Koha Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun ||ity.org QA Contact||testo...@bugs.koha-communit ||y.org Group|Koha security | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19254] Bug ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19254 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19254] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19254 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Bug ID |SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #18 from Benjamin Rokseth --- (In reply to Marcel de Rooy from comment #16) > (In reply to Benjamin Rokseth from comment #11) > > rebased against master. > > > > Ignoring failing test 'Checkin V2' as it has no bearing on this bug and > > should be resolved in another bug > > The test passes with me btw. Please copy your test results in a comment. Good. May be I have corrupted my DB somehow from testing various tests. Seems there are problems on creating items resensitize(): no item found in object to resensitize at C4/SIP/ILS/Transaction/Checkin.pm line 127. # Failed test 'Check screen msg' # at ./t/db_dependent/SIP/Message.t line 448. # got: '' # expected: '1' new ILS::Item(Kckdb) : No item 'Kckdb'. at C4/SIP/ILS/Item.pm line 80. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #17) > AdjustRemark is a bit awkward, we could show the note only if the shelf is > shared, private and changes are allowed by anyone seeing this list. Hmm. Guess that 20 lines are a bit long to accomplish this, right? But apart from that, this sub just does what you say it should. And note it should not only show but it should also hide since it is dynamical and responds to change events on some other controls. I could compress it a bit, but essentially we need all the checks currently there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19112] Stored XSS in basketheader.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19112 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19110] XSS Stored in branches.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19110 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19100] XSS Flaws in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19100 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19079] XSS Flaws in Membership page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19079 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16069] XSS issue in basket.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16069 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable --- Comment #17 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19105] XSS Stored in holidays.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19105 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19033] XSS Flaws in Currencies and exchange page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19033 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19034] XSS Flaws in- Cities - Z39.50/ SRU servers administration - Patron categories pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19034 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19050] XSS Flaws in Quick spine label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19050 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19051] XSS Flaws in - Batch record deletion page - Batch item deletion page - Batch item modification page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19051 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #11 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19052] XSS Flaws in - vendor search page - Invoice search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19052 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] New: Correct explanation about list types on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Bug ID: 19255 Summary: Correct explanation about list types on shelves.pl in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl >From Jonathan on bug 18980: On the staff interface: """ Private list: Is managed by you and can be seen only by you. Public list: Can be seen by everybody, but managed only by you. """ Should not we update it? If a list is private but shared, the description is wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19054] XSS Flaws in Report - Top Most-circulated items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19054 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19078] XSS Flaws in System preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19078 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18726] OPAC XSS - biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18726 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list types on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What|Removed |Added Depends on||18980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 [Bug 18980] Add an explanation when Anyone permission has no actual effect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy changed: What|Removed |Added Blocks||19255 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > On the staff interface: > """ > Private list: Is managed by you and can be seen only by you. > Public list: Can be seen by everybody, but managed only by you. > """ > > Should not we update it? If a list is private but shared, the description is > wrong. Opened bug 19255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 [Bug 19255] Correct explanation about list types on shelves.pl in staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Lee Jamison changed: What|Removed |Added Attachment #66823|0 |1 is obsolete|| --- Comment #5 from Lee Jamison --- Created attachment 66850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66850&action=edit Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch Signed-off-by: Lee Jamison Script works correctly after patch is applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What|Removed |Added Summary|Correct explanation about |Correct explanation about |list types on shelves.pl in |list categories on |staff |shelves.pl in staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18472] Add system preferences to manage online help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #25 from Marc Véron --- Created attachment 66851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66851&action=edit Bug 18472: Add system preferences to manage online help system This patch introduces two new system preferences in section 'Administration' - 'HelpSystem' to select / disable the help system to use. It is designed to allow future expansions (alternative / complementing help system), thats why it is a 'Multiple choice' with one choice - 'EnableEditingFilebasedHelp' is used to toggle on/off the 'Edit' field that appears at the bottom of the durrent help pages. To test: - In staff client, open help on some pages, including help on main page - They have a button 'Edit help'. On main page help, you see a text about 'Can I edit the online help?' - Apply patch, restart memcached and plack - Update database - In staff client, go to Administration > System preferences > Administration - Locate section 'Help system', do not yet schange settings - Verify that the help pages you visited look the same as before - Change syspref 'EnableEditingFilebasedHelp' to 'No' - Visit the help pages again, verify that 'Edit help' button no longer appears. - Set the system preference 'HelpSystem' to none (deselect 'File based (staff client) - Reload any page and verify that the 'Help' link in the page header does no longer display - In syspref 'HelpSystem', check 'File based (staff client)' - Reload any page, verify that the 'Help' link is displayed (Amended to correct wrong line in sysprefs.sql 201-04-29 mv) Signed-off-by: Josef Moravec (Minor change to make it apply on current master 2017-09-05 mv) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18472] Add system preferences to manage online help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Marc Véron changed: What|Removed |Added Attachment #62950|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19072] REST API: Toggle suspend for /api/v1/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072
Benjamin Rokseth changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||benjamin.roks...@kul.oslo.k
||ommune.no
--- Comment #6 from Benjamin Rokseth ---
The use of C4::Reserves::ToggleSuspend is a bit counter-intuitive here. If you
send a PUT to /api/v1/holds/x with '{"suspend":false}' it would suspend hold if
it was not already suspended.
I would rather respect the body request and suspend according to that, or you
would have unpredictable results.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Marc Véron changed: What|Removed |Added Attachment #62952|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 --- Comment #22 from Marc Véron --- Created attachment 66852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66852&action=edit Bug 18483 - Customised help: Enhance staff client with news based, easily editable help system Koha's staff client has a file based help system with an edit function for customising. However, the edited files have to be saved and restored with each release. Otherwise they are overwritten. As an enhancement or alternative, the existing news system is used to implement a complementing help system. Similar to the news, the text can be created for all branches or for individual branches. Help is context sensitive (based on the existing help system), and it can be created / edited directly from the help page (based on a user permission). Du to the need of this user permissen, a user permission for editing news is implemented as well. Display can be managed with a system preference (Bug 18472: Add system preference to manage online help system). Preferences default to legacy (fiele based) help. To test: - Apply patch on top of Bug 18472, restart memcached and plack - Update database (Alternative: fresh install) - Log in as superlibrarian (later we test the permisisons) - Verify that news behave as before - Verify that legacy help works as before - Locate system preferences 'EnableEditingFilebasedHelp' and 'Help system' - For our tests, set 'EnableEditingFilebasedHelp' to 'No' - In 'HelpSystem', uncheck 'File based' (none selected) - Refresh any page and verify that 'Help' Link in the main menu has vanished - Check both 'File based' and 'News based' - Verify that 'Help appears again in top menu - Click 'Help' for any page, verify that, above the 'classic' filebased help, you see a title 'Help for (library name) and two buttons 'Add help for this page' and 'Add help for all pages' - Close the help page - Go back to system preferences, select 'News based' only for 'HelpSystem' - Open Help again for any page - Verify that the text from file based help no longer displays, you should have a title and buttons only at the moment. - Click 'Add help for this page'. You are taken to the form you already know from editing 'News' - Click 'Cancel'. You should be taken back to the help page as before - Again click 'Add help for this page' and add an easyly identifiable title and some text, like you would do with news. - Leave the new field 'Help key' unchanged. - Submit. You should be taken back to the help you just created should appear - Close help page and open it again to verify that the text persists (for this page) - Go to an other page and verify that the help you added for the first page does not appear. - Add a help entry using the button 'Add help for all pages' - Go back to the first page you entered help for and verify, that it displays it's own help text and the text for all pages - Edit one of the texts, verify that it saves correctly - Add some more entries and verify that they appear as expected - Go to More > Tools (in an other tab) - Verify that the menu entry for News appears/disappears and changes text depending on the settings of system preference 'HelpSystem' - Open 'News' rsp. 'Help', verify that entries appear depending on the settings of syspref 'HelpSystem' - Verify that the filter for 'Display location' works - Verify that in the 'Location' column a hint about the page appears the entry was created for - Edit a staff help entry, verify that submit or close takes you back to the list - Bonus test: Edit a staff help entry, change the key to 'all', verify that the entry now appears for all pages. Change the key to 'help/admin/preferences' and verify that it appears now for the preferences page - Create a staff user with following permisisons only: catalogue (for login), edit_help and edit_news - Test visibility of news / help editing functionality depending on the edit_ permissions - Run QA tools Signed-off-by: Josef Moravec (Amended to resolve minor merge conflict. 2017-09-05 mv) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #1 from Marcel de Rooy --- Created attachment 66853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66853&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18071] Add new script update_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18071] Add new script update_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Lee Jamison changed: What|Removed |Added Attachment #64744|0 |1 is obsolete|| --- Comment #11 from Lee Jamison --- Created attachment 66854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66854&action=edit Bug 18071: Add authorities maintenance script With bug 9988 the manual merge option of merge_authorities was removed. (Note that it did not work any more too.) This patch reintroduces this functionality on the command line. This maintenance script now allows you to force renumbering field 001 for selected authid's, to delete authid's including the removal of references in biblio records, as well as merging several authid's into one reference record. Test plan: [1] Test the -renumber parameter. Field 001 and 005 should be updated. [2] Test the -delete parameter. Check if a linked biblio does no longer contain a reference to the deleted authority. [3] Test the -merge parameter. Create two PERSO_NAME records (say A,B) and attach biblios to them. Pick a CORPO_NAME record as reference record C. Now pass -merge -reference C -authid A,B Verify that A and B are gone, and the records link to C now. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14976] Specify due date, calendar and useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14976 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14815] Different leader values per framework code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields , or based on the koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11594] store both item type and document type in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11594 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7386] Label batches cannot be batch deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11683] Add search by title or callnumber on courses reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11683 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11979] Display correct not for loan status description on course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13259] Set notforloan status when adding items to a course reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19256 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19256] New: Koha::Acquisition::Order should use Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Bug ID: 19256 Summary: Koha::Acquisition::Order should use Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Lee Jamison changed: What|Removed |Added Attachment #66378|0 |1 is obsolete|| --- Comment #9 from Lee Jamison --- Created attachment 66855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66855&action=edit Bug 18999 - Added regression test Added regression test for GetBudgetSpent() and GetBudgetOrdered() into the t/db_dependent/Budgets.t Test plan: 1. Go into your koha-shell 2. set the PERL5LIB variable 3. Run t/db_dependent/Budgets.t All tests should pass Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison All tests pass as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Lee Jamison changed: What|Removed |Added Attachment #54511|0 |1 is obsolete|| --- Comment #5 from Lee Jamison --- Created attachment 66856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66856&action=edit Bug 15173: Restore SubfieldsToAllowForRestrictedEditing Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176 broke it assuming that only selects were impacted by this feature. Test plan: Go back on bug 7673 and confirm that SubfieldsToAllowForRestrictedEditing is working as expected with this patch applied. Signed-off-by: Lee Jamison For clarification, the item fields that are entered in SubfieldsToAllowForRestrictedEditing should EXCLUDE the desired fields you want to disable. Test plan (updated to test the scenario in the bug Description): 1. Create a patron with only the following permissions: - catalogue (Required for staff login) - editcatalogue -> edit_catalogue - editcatalogue -> edit_items - editcatalogue -> edit_items_restricted 2. Navigate to Administration -> Global system preferences -> Cataloging -> Record Structure -> SubfieldsToAllowForRestrictedEditing 3. In the input field for SubfieldsToAllowForRestrictedEditing enter in all the 952 fields EXCEPT the ones desired to be disabled. In this case, we want to disallow editing of 952$2, 952$a, 952$b, 952$e, 952$h, and 952$o so we enter the following into the SubfieldsToAllowForRestrictedEditing (without quotes) "952$0 952$1 952$3 952$4 952$5 952$7 952$8 952$c 952$d 952$f 952$g 952$i 952$j 952$p 952$t 952$u 952$v 952$w 952$x 952$y 952$z" 4. Click Save all Cataloging preferences 5. Login to the staff client as the created restricted editing patron 6. Edit an item 7. Note that all fields except for the ones excluded from the syspref are editable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19207] Don't export fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19207 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18201 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19207 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19207] Don't export fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19207 --- Comment #1 from Katrin Fischer --- Please see also 19207 for a discussion about changes to the form! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19207] Don't export fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19207 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Sorry, bug 18201! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19206] How should we sort 19xx when order is pubdate?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19206 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- It's a hard one, I wonder how other systems might handle that. My initial feeling is that beginning (1900) seems better than end (1999) - but others might disagree. >From the documentatoin: https://www.loc.gov/marc/bibliographic/bd008a.html Determination of dates for 008/07-10 is made concurrently with the choice of code for 008/06. See the section above on 008/06 for examples and input conventions related to coded date information. The use of fill characters in 008/07-10, although possible, is discouraged since the data in Date 1 is used for retrieval and duplicate detection in many systems. When fill is used in 008/07-10, all four positions must contain the fill character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I think there are also some cases for or/OR in the XSLT templates probably. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Katrin Fischer changed: What|Removed |Added Attachment #64957|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 66857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66857&action=edit Bug 18921: Resolve a few warnings in C4/XSLT.pm Resolves warnings like: Use of uninitialized value in hash element at C4/XSLT.pm line 262. Use of uninitialized value in numeric eq (==) at C4/XSLT.pm line 267. Use of uninitialized value $status in concatenation (.) or string at C4/XSLT.pm line 300. Note: Line numbers are not exactly the same anymore. Test plan: [1] Enable XSLT view in OPAC [2] Without this patch, you will probably have some of these warnings when doing some opac searches. [3] Apply this patch. Check the logs again. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
