[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #36 from Katrin Fischer  ---
Sadly for 16.11 things are not going as smoothly. I applied all 5 patches
cherry-picked from Fridolin. The last patch had some conflicts, but I resolved
them and the git diff -w doesn't show a difference now. Tests fail:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl
t/db_dependent/SIP/Message.t 
1..3
Can't locate Koha/Old/Checkouts.pm in @INC (you may need to install the
Koha::Old::Checkouts module) (@INC contains: /home/vagrant/kohaclone
/home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at t/db_dependent/SIP/Message.t line 37.
BEGIN failed--compilation aborted at t/db_dependent/SIP/Message.t line 37.

16.11.x still has Koha/OldIssues.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #37 from Katrin Fischer  ---
I've tried to fix the tests replacing the newer by the old modules, but getting
stuck here:

# Data corrupted: add same issue_id to old_issues
Koha::OldIssues->new({ issue_id => $issue->issue_id })->store;

The method store is not covered by tests at t/db_dependent/SIP/Message.t line
312.
not ok 15 - DBIx error on duplicate issue_id
#   Failed test 'DBIx error on duplicate issue_id'
#   at t/db_dependent/SIP/Message.t line 316.
# didn't find a warning
# expected to find warning: (?^u:Duplicate entry)
# expected to find warning: (?^u:data corrupted)
not ok 16 - OK flag is false when we encounter data corruption in
old_issues
#   Failed test 'OK flag is false when we encounter data corruption in
old_issues'
#   at t/db_dependent/SIP/Message.t line 318.
#  got: '1'
# expected: '0'
not ok 17 - Alert flag is set
#   Failed test 'Alert flag is set'
#   at t/db_dependent/SIP/Message.t line 319.
#  got: 'N'
# expected: 'Y'
not ok 18 - Code AF not found in
'|AOz7vpbEBO2|ABNZd|AQz7vpbEBO2|AJNVjlgNa_|AAgHWDOyBTR|CRmibXFk|CSd0dkNUeiPLgDfs5ZS8tKmTiko63dH74rAf5ikn_Jg2QXE6TEmks381qyPoSUvy5ZORcYPHtyT_BiUpH7vTR2KdHjc_TNDNaFvZtMsvaP_qDOQLqP8ZWfJMGFKWO1dd6VaXt1kCqgU1zqOmoPEcox92XXWlL54V0df04DoOGpaGq2aChxvamLvEPhEgLDsbLhw34EI28uO9DfKFYDtPpVteffxIy7qHyFZHgkPNthjLMNAeDYSZZP9Y|'?
#   Failed test 'Code AF not found in
'|AOz7vpbEBO2|ABNZd|AQz7vpbEBO2|AJNVjlgNa_|AAgHWDOyBTR|CRmibXFk|CSd0dkNUeiPLgDfs5ZS8tKmTiko63dH74rAf5ikn_Jg2QXE6TEmks381qyPoSUvy5ZORcYPHtyT_BiUpH7vTR2KdHjc_TNDNaFvZtMsvaP_qDOQLqP8ZWfJMGFKWO1dd6VaXt1kCqgU1zqOmoPEcox92XXWlL54V0df04DoOGpaGq2aChxvamLvEPhEgLDsbLhw34EI28uO9DfKFYDtPpVteffxIy7qHyFZHgkPNthjLMNAeDYSZZP9Y|'?'
#   at t/db_dependent/SIP/Message.t line 364.
#  got: '0'
# expected: '1'
not ok 19 - OK flag is true when we checkin after removing the duplicate
#   Failed test 'OK flag is true when we checkin after removing the
duplicate'
#   at t/db_dependent/SIP/Message.t line 327.
#  got: '0'
# expected: '1'
not ok 20 - Alert flag is not set
#   Failed test 'Alert flag is not set'
#   at t/db_dependent/SIP/Message.t line 328.
#  got: 'Y'
# expected: 'N'
ok 21 - Issue record is gone now
# Looks like you failed 6 tests of 21.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18331] Translated CSV exports need to be fixed once and for all

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331

Katrin Fischer  changed:

   What|Removed |Added

Summary|CSV exports need to be  |Translated CSV exports need
   |fixed once and for all  |to be fixed once and for
   ||all

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18331] Translated CSV exports need to be fixed once and for all

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331

--- Comment #47 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.12.

Let's hope this zombie bug stays dead now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #23 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #18 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.12.

Please note: Not all Elasticsearch related patches have been pushed to 16.11.x
as there were some problems/conflicts and I received no answer on the bugs. 
This applied cleanly, so I have pushed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #19 from Katrin Fischer  ---
Sorry, reverted - tests were failing.

 perl t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t 

not ok 9 - Exception thrown on invalid value in the marclist param
#   Failed test 'Exception thrown on invalid value in the marclist param'
#   at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line
53.
# expecting: Koha::Exceptions::WrongParameter
# found: Can't locate object method "throw" via package
"Koha::Exceptions::WrongParameter" (perhaps you forgot to load
"Koha::Exceptions::WrongParameter"?) at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line
432.
1..9
# Looks like you failed 1 test of 9.
not ok 1 - build_authorities_query_compat() tests
#   Failed test 'build_authorities_query_compat() tests'
#   at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 55.
# Looks like you failed 1 test of 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19053] Auto renewal flag is not kept if a confirmation is needed

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19053

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19049] Fix regression on stage-marc-import with to_marc plugin

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

--- Comment #30 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.12.

Fridolin, please take a look at the dependent bug 19163 - it fixes a critical
problem with this patch set!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers and max connections to be set in koha-conf.xml

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

--- Comment #21 from Katrin Fischer  ---
Still willing to push this - can we get a sign-off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

--- Comment #32 from Katrin Fischer  ---
Mason, you were right. Thx a lot for catching this!

Missing patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18741] Web installer does not load default data

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741

--- Comment #11 from Katrin Fischer  ---
Hi Julian, thx for the 16.11.x patch!

This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18763] swagger/definitions.t is failing

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Katrin Fischer  ---
Won't apply to 16.11.x as is, closing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221

--- Comment #2 from Magnus Enger  ---
Ah hah! Still, I managed to misread it, so maybe others will too. Could we find
a clearer wording/layout perhaps?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19273] Confirm hold does not work for in-transit holds

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

2017-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #26 from Josef Moravec  ---
(In reply to Kyle M Hall from comment #25)
> (In reply to Jonathan Druart from comment #22)
> > (In reply to Josef Moravec from comment #2)
> > > And it is caused by bug 18438...
> > 
> > If this is caused by template changes, why do we need to fix it at package
> > level?

My fault, it is not caused by bug 18438, this bug just highlited the problem.

> 
> Which is why I'd suggest my fix on bug 19273 which is a one line template
> change.

The patch on bug 19273 just reverts the functionality provided by bug 18438...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/