[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Liz, I think we had a similar approach on another bug, but when I tested
with Japanese text the links were totally broken. Could you test your patch
with some original script in 490?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19414] New: Move the location of the ' Import this batch into the catalog' button

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Bug ID: 19414
   Summary: Move the location of the 'Import this batch into the
catalog' button
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: di...@calyx.net.au
  Reporter: di...@calyx.net.au
QA Contact: testo...@bugs.koha-community.org

Logically reading the Manage staged MARC records page, the 'Import this batch
into the catalog' button is above the dropdown selector for which framework to
use.

This poses a problem if a user clicks the button before selecting which
framework they want to import the batch as because it will be imported using
the default framework otherwise.

The patch attached will move the button below the dropdown selector so as make
everything appear in a more logical order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19412] Add ability to email item suggestions through system preferences

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19412

--- Comment #1 from Alex Buckley  ---
Created attachment 67627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67627=edit
Bug 19412 - Ability to set 2 new sysprefs to email OPAC purchase suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #67623|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 67626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67626=edit
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder

Followed test plan and patch applies and functions as described
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

--- Comment #7 from Aleisha Amohia  ---
(In reply to Lari Taskula from comment #3)
> Comment on attachment 67070 [details] [review]
> Bug 19293: Prevent error when receiving shipment with order with deleted
> biblio
> 
> Review of attachment 67070 [details] [review]:
> -
> 
> Test plan works, just some small thoughts for the patch. Also I noticed test
> plan was dropped from the commit message after the sign-off.
> 
> ::: acqui/parcel.pl
> @@ +225,4 @@
> >  for (my $i = 0 ; $i < $countpendings ; $i++) {
> >  my $order = $pendingorders->[$i];
> >  
> > +unless( !defined $order->{biblionumber} ){ # if this biblio has 
> > been deleted and the orderline hasn't been cancelled
> 
> if ( defined $order->{biblionumber} ) {
> 
> Or perhaps even
> next unless defined $order->{biblionumber};
> to avoid having to fix indendation of 80+ lines below.

There we go, changed the line to 
if ( defined $order->{biblionumber} ) {

and put test plan back in commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #67624|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 67625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67625=edit
[SIGNED-OFF] Bug 19293: Prevent error when receiving shipment with order with
deleted biblio

This patch checks if the biblio exists when receiving a shipment, and
will skip the order if the biblio does not exist.

To test:
1) Find or create a basket
2) Add TWO items to it
3) Find the record for one item in a separate tab, delete the record
4) Notice the order in the basket for that item now says 'deleted
bibliographic
record'
5) close the basket and receive the shipment
6) After entering an invoice number and clicking next, you'll see the
error:
Can't call method "subscriptions" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 245.
7) Apply the patch and go back to the basket to receive the shipment
8) Put in an invoice number and click next
9) This should now work as expected, skipping the deleted biblio, and
the other item should show as ready to receive

Sponsored-by: Catalyst IT

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #67127|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 67624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67624=edit
[SIGNED-OFF] Bug 19293: Prevent error when receiving shipment with order with
deleted biblio

This patch checks if the biblio exists when receiving a shipment, and
will skip the order if the biblio does not exist.

To test:
1) Find or create a basket
2) Add TWO items to it
3) Find the record for one item in a separate tab, delete the record
4) Notice the order in the basket for that item now says 'deleted
bibliographic
record'
5) close the basket and receive the shipment
6) After entering an invoice number and clicking next, you'll see the
error:
Can't call method "subscriptions" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 245.
7) Apply the patch and go back to the basket to receive the shipment
8) Put in an invoice number and click next
9) This should now work as expected, skipping the deleted biblio, and
the other item should show as ready to receive

Sponsored-by: Catalyst IT

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413

--- Comment #1 from Alex Buckley  ---
Created attachment 67623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67623=edit
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder

Test plan:
1. Go into the Cataloguing module in the staff intranet
2. Create a new record in one of your MARC frameworks
3. Click on the small tag editor icon to the right
of the 008 field
4. A new window (containing the 008 builder)
will appear and notice that the OK and cancel buttons
are at the bottom of the page in this window
5. Apply patch
6. Refresh this window (right click and select refresh
button)
7. Notice that the OK and cancel buttons have moved
to the top right of the page

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #2 from Liz Rea  ---
Created attachment 67622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67622=edit
Bug 16804 - unescaped semicolons in XSLT values can cause searches to fail

This patch adds a url-encode to the MARC21slimUtils, and applies it
specifically to a common place where semicolons can appear in searches, the 490
field.

To test:

* have OPACSuppression on
* have a record with a 490 field a la:

490 _a something ;
_v 123

* go to the opac and search for this record
* click the Series link from the detail

Without this patch, there will be no results.

With this patch, you will get relevant results (possibly the same record back)

There are probably lots of places this could be applied, and also possibly many
other solutions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Liz Rea  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19413] New: Move the location of the Ok and cancel buttons to the 008 cataloguing builder

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413

Bug ID: 19413
   Summary: Move the location of the Ok and cancel buttons to the
008 cataloguing builder
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

The inputs that librarians are most likely to interact with on the Cataloguing
008 Builder are types of materials, and dates which are all at the top of the
window.

The patch attached to this bug report will place the OK and cancel inputs at
the top of the page therefore improving the UX of the page because they don't
have to scroll past a whole lot of unnecessary inputs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #90 from Alex Buckley  ---
Hi Mehdi

Whilst applying this patch on a clean, up to date branch I got the following
merge error (below) the issue is C4/Reserves.pm can you please rebase against
master and I will be happy to try testing it again:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts
Applying: Bug 17015 - Tests for DiscreteCalendar
Applying: Bug 17015 - Koha now uses the new DiscreteCalendar module
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
M   C4/HoldsQueue.pm
M   C4/Overdues.pm
M   C4/Reserves.pm
M   Koha/Hold.pm
M   circ/returns.pl
M   misc/cronjobs/overdue_notices.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/overdue_notices.pl
Auto-merging circ/returns.pl
Auto-merging Koha/Hold.pm
Auto-merging C4/Reserves.pm
CONFLICT (content): Merge conflict in C4/Reserves.pm
Auto-merging C4/Overdues.pm
Auto-merging C4/HoldsQueue.pm
Auto-merging C4/Circulation.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 17015 - Koha now uses the new DiscreteCalendar module
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-17015---Koha-now-uses-the-new-DiscreteCalendar-G564_m.patch
You have new mail in /var/mail/vagrant

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19412] New: Add ability to email item suggestions through system preferences

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19412

Bug ID: 19412
   Summary: Add ability to email item suggestions through system
preferences
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

A library has requested this feature so it has a real world use case.

The summary of what the patches attached to this bug report will do is create 2
new sysprefs:

1) To write in a borrower name and it will auto-complete with the borrower
record storing the borrower number which is unlikely to change.

When a patron makes a purchase suggestion this is sent to the email address
associated with the borrower number (as long as the second (below) syspref is
enabled). The reason the borrower number not the email address is going to be
stored is that email addresses are more likely to be changed than the borrower
number so from a usability point of view it is best to store the least likely
to be changed value. 


2) To enable or disable the emailing of suggestions to the borrower specified
in syspref 1 (above)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2646] Add sort option for the series number

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexbuck...@catalyst.net.nz

--- Comment #10 from Alex Buckley  ---
Hi Kyle

Can you please rebase against master because when trying to apply the patches
up to and including the 'port max_holds_rules to new CirculationRules systems'
(after applying the dependency: patch 15524) I got the below merge error. 

The issue is in Koha/Schema/Result/Branch.pm file.

Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 18887 - Update database
Applying: Bug 18887 - Add new schema file
Applying: Bug 18887 - Update existing schema files
Using index info to reconstruct a base tree...
M   Koha/Schema/Result/Branch.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Schema/Result/Branch.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 18887 - Update existing schema files
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-18887---Update-existing-schema-files-74PCpN.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925

--- Comment #8 from Jesse Weaver  ---
Created attachment 67621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67621=edit
Bug 18925: (follow-up) Change name of rule to fix ambiguity

There was previously an ambiguity between the branch/category/itemtype
specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty.
The latter has been renamed to patron_max{,onsite}issueqty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #32 from Alex Buckley  ---
Hi David

Testing this patch again it fails to apply for me, the issue is in
members/paycollect.pl, can you please rebase against master and then I will be
happy to retest:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 5620 - Rebase and add Paypal to staff interface
/home/vagrant/kohaclone/.git/rebase-apply/patch:155: trailing whitespace.
Koha::Account->new( { patron_id => $borrowernumber } )->pay( 
/home/vagrant/kohaclone/.git/rebase-apply/patch:156: trailing whitespace.
{ 
/home/vagrant/kohaclone/.git/rebase-apply/patch:157: trailing whitespace.
amount => $total_paid, 
/home/vagrant/kohaclone/.git/rebase-apply/patch:160: trailing whitespace.
} 
warning: 4 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt
M   members/paycollect.pl
:155: trailing whitespace.
Koha::Account->new( { patron_id => $borrowernumber } )->pay( 
:156: trailing whitespace.
{ 
:157: trailing whitespace.
amount => $total_paid, 
:160: trailing whitespace.
} 
warning: 4 lines applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging members/paycollect.pl
CONFLICT (content): Merge conflict in members/paycollect.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 5620 - Rebase and add Paypal to staff interface
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-5620---Rebase-and-add-Paypal-to-staff-interfac-SeWTyY.patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #9 from Jesse Weaver  ---
Created attachment 67620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67620=edit
Bug 18887: (follow-up) Fix behavior for default branch/category

Also, fix a couple small QA issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

--- Comment #8 from Alex Buckley  ---
Created attachment 67619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67619=edit
Bug 9495 - split NotesBlacklist in to two prefs for staff and OPAC

Fixed: Undefined subroutine ::GetOPACMarcNotes

Followed test plan, patch worked as described, also ran QA test tools
which passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67182|0   |1
is obsolete||
  Attachment #67183|0   |1
is obsolete||

--- Comment #7 from Alex Buckley  ---
Created attachment 67618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67618=edit
Bug 9495 - split NotesBlacklist in to two prefs for staff and OPAC

Create the new preference NotesOPACBlacklist, it works like NotesBlacklist but
these fields will not appear in the OPAC detail and will appear in the staff

Test plan:
1) Add the fields to hide in the OPAC in the new preference NotesOPACBlacklist
2) Check in the Opac detail if these fields don't appear
3) Check in the staff detail if these fields appear

Sponsored-by: Scanbit

Followed test plan, patch worked as described. Also ran QA test tools
which passed modified files

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19409] Around 130 images not migrated from DocBook XML to ReST format (Sphinx)

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19409

--- Comment #3 from Katrin Fischer  ---
Patches have been merged into master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexbuck...@catalyst.net.nz

--- Comment #15 from Alex Buckley  ---
Hi 

Can you please rebase against the master branch, when I apply the patches
attached to this bug report I get the following merge error which is being
thrown by the t/db_dependent/Serials.t file

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17674 - Allow UI to delete serials in batch
Applying: Bug 17674 - Fix problem tabs
Applying: Bug 17674 - Add unit tests
Using index info to reconstruct a base tree...
M   t/db_dependent/Serials.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Serials.t
CONFLICT (content): Merge conflict in t/db_dependent/Serials.t
Failed to merge in the changes.
Patch failed at 0001 Bug 17674 - Add unit tests
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-17674---Add-unit-tests-yO9YMv.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12227] remove demo user functionality

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67407|0   |1
is obsolete||

--- Comment #5 from Alex Buckley  ---
Created attachment 67617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67617=edit
Bug 12227: Remove the demo functionality

This is a legacy mode that did not really work.

Test plan:
Play with frameworks and sysprefs and confirm the changes
(add/del/update) are taken into account.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12227] remove demo user functionality

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Sarah Kirby  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Sarah Kirby  changed:

   What|Removed |Added

  Attachment #67347|0   |1
is obsolete||

--- Comment #5 from Sarah Kirby  ---
Created attachment 67615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67615=edit
Bug 11976 - Show publication date instead of received date

Allows choosing between publication date or receival date for serials
information in the OPAC.

Test plan :
0) If you have no serials :
a) Create a subscription
b) Receive the item, making sure to have a different publication and
receival date
1) Visit the OPAC details page for the item you've created
2) Without the patch the receival date will be displayed
3) Apply patch
4) Run installer/data/mysql/updatedatabase.pl
5) With the patch the publication date will be displayed. This can be changed
back with the 'OPACSerialDisplayPublishedDate' system preference.

Signed-off-by: Sarah Kirby 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

--- Comment #7 from Magnus Enger  ---
(In reply to Josef Moravec from comment #6)
> But the solution should be more complex (and yes, we will need tests for
> this)
> 
> The CancelExpiredReserved has to deal with ExpireReservesMaxPickUpDelay -
> nad use the different SQL for this two cases.

Could you make an alternative patch for that? I will sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19363] QA test tools fails detail.tt template

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19363

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Alex Buckley  ---
(In reply to Owen Leonard in comment 1)

Hi Owen

Yes sorry I was having issues with QA test tools, I have now fixed those issues
and this bug no longer exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #10 from Alex Buckley  ---
Hi David

Thanks for clarifying, yes after including barcodes in the selected layout the
exported PDF now contains barcodes. 

One point though like you say if you write in a non-existing barcode e.g. 1,
then a blank page is exported. If you could create a warning to inform the user
that the inputted barcode does not exist then that would be good. Then I should
be able to sign off on these patches as they pass the QA test tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19409] Around 130 images not migrated from DocBook XML to ReST format (Sphinx)

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19409

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Jonathan Druart  
---
See https://gitlab.com/koha-community-devs-users/kohadocs/issues/2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19411] New: opac-shelves.tt : the opaccredits block should be outside of the main

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

Bug ID: 19411
   Summary: opac-shelves.tt : the opaccredits block should be
outside of the main 
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: david.bourga...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 67614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67614=edit
HTML structure of opac-shelves.tt as displayed by Chrome dev tools.

The opac-shelves.tt template seems to have mismatch tags, resulting in the
opaccredits  to be placed inside the main . This can break CSS
customization.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #9 from David Bourgault  ---
(In reply to Alex Buckley from comment #8)
> Hi David
> 
> Thanks for fixing that :)
> 
> I have tried testing again and I am sorry to say that it  exports a blank
> page. Can you please fix this and I will be happy to test again

This can happen if the selected layout does not include barcodes (Manage layout
> Edit > Layout type), and there is no item with the given barcode. Can you
check those parameters and tell me if the issue persists? Thanks.

I'll see if I can add a warning to the layout selection page when I have the
time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #10 from Alex Buckley  ---
Hi Tomas

Can you please rebase this patch against master because when I applied the
patches attached to this bug report (after applying the dependencies) I got the
following merge error:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19278: Add RESTdefaultPageSize syspref
Applying: Bug 19278: Unit tests
fatal: sha1 information is lacking or useless
(t/Koha/REST/Plugin/Pagination.t).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 19278: Unit tests
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19278-Unit-tests-3gVPjM.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Alex Buckley  ---
Hi David

Thanks for fixing that :)

I have tried testing again and I am sorry to say that it  exports a blank page.
Can you please fix this and I will be happy to test again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18731] CRUD for acquisition orders

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] CRUD for acquisition orders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 67613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67613=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
$vendors = Koha::Acquisition::Booksellers->api_list_search($c);
return $c->render(status => 200, openapi => $vendors);
  } catch {
...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||lari.task...@jns.fi,
   ||martin.renvoize@ptfs-europe
   ||.com
 Depends on||19196, 19278, 19234, 19369,
   ||19370
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
[Bug 19196] Add pagination helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234
[Bug 19234] Add query parameters handling helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278
[Bug 19278] Add a configurable default page size for endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369
[Bug 19369] Add a helper function for translating pagination params into
SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370
[Bug 19370] Add a helper function for translating order_by params into
SQL::Abstract
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] New: Koha::Objects needs a ->search_for_api method

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Bug ID: 19410
   Summary: Koha::Objects needs a ->search_for_api method
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We should extend Koha::Objects so searching can deal with squery parameters,
specially handling pagination, results sorting, matching criteria, etc.

This could be easily implemented using:

- Bug 19196 (Pagination handling helpers)
- Bug 19278 (Make REST api default page size configurable)
- Bug 19234 (Query params handling helpers)
- Bug 19369 (Query pagination to SQL::Abstract)
- Bug 19370 (Query order by to SQL::Abstract)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

David Bourgault  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #9 from David Bourgault  ---
I updated the systempreference name to something more global (SortIgnoreWords)
and updated datatables.inc to use it (opac and intranet).

Test plan is same as before, plus testing any table that uses datatables.inc.

Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #8 from David Bourgault  ---
Created attachment 67612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67612=edit
Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19409] Around 130 images not migrated from DocBook XML to ReST format (Sphinx)

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19409

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

--- Comment #1 from Jonathan Druart  
---
I am working on a patch to fix these issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19388] Error in course details on OPAC if an item is checked-out

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388

Jonathan Druart  changed:

   What|Removed |Added

   Severity|blocker |critical

--- Comment #5 from Jonathan Druart  
---
Lowering severity, it does not impact stable releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365

Jonathan Druart  changed:

   What|Removed |Added

   Severity|blocker |major
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||n...@bywatersolutions.com

--- Comment #1 from Jonathan Druart  
---
This is not blocker, ES is not considered as stable yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794

--- Comment #5 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #4)
> This patch has been pushed to 16.11.x and will be in 16.11.09.

No, it is not in 16.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12227] remove demo user functionality

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

--- Comment #4 from Jonathan Druart  
---
(In reply to Alex Buckley from comment #3)
> What is the demo setting in koha-conf.xml that needs to be enabled? I cannot
> find the string 'demo' in the aforementioned file

This patch removes the demo functionality. It has never been implemented fully,
it is expected not to see it in the config file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

David Bourgault  changed:

   What|Removed |Added

   Assignee|maxime.beaul...@inlibro.com |david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19343] Private lists displayed in search results list

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67559|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19343] Private lists displayed in search results list

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #11 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #10)
> -allow_add=> 1,
> +allow_change_from_owner => 1,
> +allow_change_from_others => 1,
> 
> THis change in master does not apply.
> And I wonder if it makes sense too, since not adding these lines does not
> make a difference. Test still passes. Please adjust.

Yes right, this patch is not needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19381] Replace the built-in help files with links to the online manual

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19381

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
I really like this idea!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #68 from Nick Clemens  ---
Created attachment 67611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67611=edit
Bug 14576: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64656|0   |1
is obsolete||
  Attachment #64657|0   |1
is obsolete||
  Attachment #64658|0   |1
is obsolete||

--- Comment #67 from Nick Clemens  ---
Created attachment 67610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67610=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences.  The update statement should
insert values that replciate these functions.  Note existing
functionality of all items in PROC location being returned to
permanent_location is preserved by default.  Also, any items issued from
CART location will be returned to their permanent location on issue (if
it differs)

Special values for this pref are:
_ALL_ - used on left side only to affect all items
_BLANK_ - used on either side to match on/set to blank (actual blanks
will work, but this is an easier to read option)
_PERM_ - used on right side only to return items to permanent location

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN
8) Test using _ALL_, _BLANK_ and _PERM_ for updates
9) Try entering various incorrect syntax in the pref and note you are warned

Sponsored by:
Arcadia Public Library (http://library.ci.arcadia.ca.us/)
Middletown Township Public Library (http://www.mtpl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67608|0   |1
is obsolete||

--- Comment #3 from Alex Arnaud  ---
Created attachment 67609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67609=edit
Bug 18399 - Add reasons in edit suggestion page

Test plan:

 - Fill the authorised values's category 'SUGGEST' with reason
 - Edit a pending suggestion. Set the status to rejected
   and select a reason
 - Check the reason has been saved (i.e in the suggestions
   table of rejected tab)
 - Check in the corresponding message_queue that the reason
   is here
 - Re-edit the same suggestion
 - Check that the correct reason is selected by defaut
 - Edit an other pending suggetion. Set the status to rejected,
   select other reason and fill the input text
 - Re-edit the previews suggestion and make sure the input
   "other" is displayed by default with the correct value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

--- Comment #2 from Alex Arnaud  ---
Created attachment 67608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67608=edit
Bug 18399 - Add reasons in edit suggestion page

Test plan:

 - Fill the authorised values's category 'SUGGEST' with reason
 - Edit a pending suggestion. Set the status to rejected
   and select a reason
 - Check the reason has been saved (i.e in the suggestions
   table of rejected tab)
 - Check in the corresponding message_queue that the reason
   is here
 - Re-edit the same suggestion
 - Check that the correct reason is selected by defaut
 - Edit an other pending suggetion. Set the status to rejected,
   select other reason and fill the input text
 - Re-edit the previews suggestion and make sure the input
   "other" is displayed by default with the correct value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67525|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19363] QA test tools fails detail.tt template

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19363

--- Comment #1 from Owen Leonard  ---
I tried to reproduce this bug on my kohadevbox by making a trivial change to
detail.tt and running the QA test tool, but I didn't get any failures.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19409] Around 130 images not migrated from DocBook XML to ReST format (Sphinx)

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19409

Zeno Tajoli  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |alex.arn...@biblibre.com
 CC||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67341|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 67607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67607=edit
Bug 19278: Mention RESTdefaultPageSize in POD

This patch adds information about RESTdefaultPageSize usage
when the per_page parameter is absent on the query.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66995|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 67605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67605=edit
Bug 19278: Unit tests

This patch introduces tests for a behaviour change in
Koha::REST::Plugin::Pagination.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> FAIL: Tests should fail without the followup patch applied

Sponsored-by: Camden County
Sponsored-by: Bywater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66996|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 67606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67606=edit
Bug 19278: Make the pagination plugin use RESTdefaultPageSize

This bug introduces a new syspref RESTdefaultPageSize that is used on
the Koha::REST::Plugin::Pagination plugin to default to a valid value
for the page size if the param is not present on the query.

This patch also considers the situation in which no 'page' param is
passed, and no header should be added.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> FAIL: Tests fail because the plugin doesn't behave as the tests
expect.
- Apply this patch
- Run:
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County
Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66994|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 67604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67604=edit
Bug 19278: Add RESTdefaultPageSize syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

David Bourgault  changed:

   What|Removed |Added

  Attachment #67394|0   |1
is obsolete||

--- Comment #31 from David Bourgault  ---
Created attachment 67603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67603=edit
Bug 5620 - Rebase and add Paypal to staff interface

Previous patch failed to apply for me, so I remade it. 

+ Paypal should now be an option in the staff interface when collecting from
patrons.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

David Bourgault  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19173] Make OPAC online payments pluggable

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173

--- Comment #16 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #15)
> Hi Kyle,
> Could you add documentation about how people can develop payment plugins?
> Would it make sense to move the existing paypal method to a plugin?
> Thanks!

I think those are both capital ideas! I'll see what I can do.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #13 from Nick Clemens  ---
(In reply to Colin Campbell from comment #8)
> In an EDI environment credit note messages are a type of invoice message,
> and we'd have to drive the creation of th Adjustment from there. With that
> case in mind (but also with manual cases) It would be useful to have a field
> similar to the invoicenumber in the aqinvoice table to record the suppliers
> document number
> (mandatory in edifact where its a max 35 character field)

Do you want this field simply added to the DB changes for future use? Does it
need to be displayed/editable?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #12 from Nick Clemens  ---
Created attachment 67602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67602=edit
Bug 19166: DO NOT PUSH - Schema updates

Included to ease testing :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66475|0   |1
is obsolete||
  Attachment #66476|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 67599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67599=edit
Bug 19166 - Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #11 from Nick Clemens  ---
Created attachment 67601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67601=edit
Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered

To test:
1. prove -v t/db_dependent/Budgets.t
2. Should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #10 from Nick Clemens  ---
Created attachment 67600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67600=edit
Bug 19166 - Add the ability to add adjustments to an invoice

This patchset adds the ability to add adjustments to an invoice, one can
provide a reason, an adjustment amount, select a budget, and choose
whether to encumber the funds before the invoice is closed or not

To test:

1 - Create a new invoice with or without a shipping cost
2 - Note there are no existing adjustments
3 - Add an adjustment
4 - Submit the form withno changes, nothing happens
5 - Update the adjustment you created, ensure changes are saved but no
extra adjustment created
6 - Add another invoice prodiving only reason or amount (you can have 0
value adjustments)
7 - Verify the adjustment total at bottom is correct
8 - Recieve some orders
9 - Verify totals are correct

Conflicts:
C4/Budgets.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #7 from David Bourgault  ---
Additionally : this function works for any range, regardless of if they
actually exist. (You can print your barcodes before your books arrive)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #6 from David Bourgault  ---
Created attachment 67598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67598=edit
Bug 7468 - Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range'
button, which Chrome didn't mind, but Firefox did understand.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171

Katrin Fischer  changed:

   What|Removed |Added

   Severity|minor   |normal

--- Comment #1 from Katrin Fischer  ---
Upping severity as we have another library reporting this issue and it's
confusing patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #30 from Josef Moravec  ---
(In reply to David Bourgault from comment #29)
> Yes, I excluded it because usually PayPal payments are done through the
> OPAC. Should it be added to the staff interface anyway?

Maybe it does make sense for some administration purposes?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #29 from David Bourgault  ---
Yes, I excluded it because usually PayPal payments are done through the OPAC.
Should it be added to the staff interface anyway?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Nick Clemens  changed:

   What|Removed |Added

  Attachment #62152|0   |1
is obsolete||
  Attachment #66412|0   |1
is obsolete||

--- Comment #18 from Nick Clemens  ---
Created attachment 67596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67596=edit
Bug 18201 - Export data -Fix "Remove non-local items" option and add "Removes
non-local records" option for existing functionality

It turns out the modules had the option expected  built in, we just didn't call
it. This patch set expands the options for passing to the export.

To test:
1 - Go to Tools->Export data
2 - Perform an export and check 'Remove non-local items'
3 - Note that file contains only 'local' records, but includes all items
on those records
4 - Apply patch
5 - Note Tools->Export data has a new option to remove records not owned
by logged in branch
6 - Export as before checking records option, file should be as before
7 - Now check 'Remove items not owned by logged in branch'
8 - File should now only have local items (may have empty records)
9 - Check both boxes and recieve only 'local' records and items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

--- Comment #19 from Nick Clemens  ---
Created attachment 67597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67597=edit
Bug 18201 - Unit tests

To test:
1. prove -v t/db_dependent/Exporter/Record.t
2. Tests should pass/be green/make the day a little brighter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #31 from Marcel de Rooy  ---
(In reply to David Cook from comment #23)
> It would be great to have a single test plan in a comment. I'm not entirely
> sure what I need to test here... 
> 
> I'll do my best to find all the relevant test plans but we'll see.

Sorry that you could not find what you needed. But thx for trying.
Each patch (except the first one) had a test plan in the commit message and
also visible in the individual Bugzilla comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #30 from Marcel de Rooy  ---
(In reply to Josef Moravec from comment #29)
> Signed-off-by: Josef Moravec 

Thanks, Josef !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >