[Koha-bugs] [Bug 19442] add patron attributes into the patron card creator

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19442

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

--- Comment #1 from Alex Arnaud  ---
Created attachment 67923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67923&action=edit
Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl)

The form provided on top of the page if Koha find a duplicate
patron is not closed. This cause some trouble.

Test plan:

 - Edit the syspref IntranetUserJS and type the following code:
   "$(document).ready(function() {
$("#memberentry_library_management").insertBefore("#memberentry_identity");
});"
 - create a patron so that Koha will warn you about a duplicate one,
 - click on "Not a duplicate. Save as new record",
 - you should get error(s) about empty field(s).
   Note that now, the library management part's fields are empty or
   reset to default

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

Alex Arnaud  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

Marc Véron  changed:

   What|Removed |Added

  Attachment #67883|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 67924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67924&action=edit
Bug 18961: Use exact match for select filters on item search

The SQL operator LIKE is always used for filters when searching for
items.

If the filter is a select, we should search for an exact match.
That way we avoid problematic search like "%NFIC%" and "%FIC%" (one
includes the other one).

Test plan:
- Make sure you have collection codes 'Fiction' and 'Non-fiction'
- Do an item search
- Filter column 'Collection', select 'Fiction'
- Result: Column contains items from Fiction only

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19359] Reporting module selenium test

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

--- Comment #2 from Alex Buckley  ---
Created attachment 67925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67925&action=edit
Bug 19359 - Followup patch with xpaths changed to id's

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19359] Reporting module selenium test

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67925|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19359] Reporting module selenium test

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

--- Comment #3 from Alex Buckley  ---
Created attachment 67926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67926&action=edit
Bug 19359 - Followup patch with xpaths changed to id's

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Created attachment 67927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67927&action=edit
More problems with patron entry form

There are more problems with the form, additional attributes display outside,
see screenshot attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19085] Empty files in English web installer

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19085

Marc Véron  changed:

   What|Removed |Added

  Attachment #67869|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 67928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67928&action=edit
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19085] Empty files in English web installer

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19085

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19444] New: Automatic renewal script should not auto-renew if a patron' s record has expired

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Bug ID: 19444
   Summary: Automatic renewal script should not auto-renew if a
patron's record has expired
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: janet.mcgo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently with the automatic_renewals.pl script, materials are still
auto-renewed even if the patron's account has expired.
The automatic renewals script has error conditions which prevent automatic
renewals  in these circumstances:
$error eq 'too_many'
or $error eq 'on_reserve'
or $error eq 'restriction'
or $error eq 'overdue'
or $error eq 'auto_too_late'
or $error eq 'auto_too_much_oweing'
or $error eq 'auto_too_soon

The error conditions should take into account the expiry date of borrower and
not auto renew if the borrower's account has expired.
For example adding a new error code such as 'borrower_expired' - or whatever
convention achieves this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

--- Comment #3 from Alex Arnaud  ---
(In reply to Marc Véron from comment #2)
> Created attachment 67927 [details]
> More problems with patron entry form
> 
> There are more problems with the form, additional attributes display
> outside, see screenshot attached.

Can not reproduce this issue. On which step? Is there custom js?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67721|0   |1
is obsolete||

--- Comment #98 from Alex Buckley  ---
Created attachment 67929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67929&action=edit
Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts

Followed test plan, patch worked as described, also passed QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570

Jens Weber  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #7 from Jens Weber  ---
I wonder if this (sending of password recovery messages as well as CHECKIN/-OUT
notices) could not be achieved by putting them in the message queue (i.e. the
default behaviour) and then have misc/cronjobs/process_message_queue.pl
triggered 'manually' by the relevant script.

For CHECKIN/CHECKOUT this would obviously happen rather often (maybe too
often?), but for password recovery -- rarely more than once an hour -- I can't
see how it would pose any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67722|0   |1
is obsolete||

--- Comment #99 from Alex Buckley  ---
Created attachment 67930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67930&action=edit
Bug 17015 - Tests for DiscreteCalendar

Ran test which passed. The test also passed QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67723|0   |1
is obsolete||

--- Comment #100 from Alex Buckley  ---
Created attachment 67931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67931&action=edit
Bug 17015 - Koha now uses the new DiscreteCalendar module

Followed test plan and this patch worked as described. Also all modified
files in this patch pass QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67724|0   |1
is obsolete||

--- Comment #101 from Alex Buckley  ---
Created attachment 67932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67932&action=edit
Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module

All tests in t directory (including test files modified by this patch)
pass and all modified files in this patch pass QA test
tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67725|0   |1
is obsolete||

--- Comment #102 from Alex Buckley  ---
Created attachment 67933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67933&action=edit
Bug 17015 - Peformance tests for Koha::DiscreteCalendar

Passed QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

--- Comment #4 from Marc Véron  ---
(In reply to Alex Arnaud from comment #3)
> (In reply to Marc Véron from comment #2)
> > Created attachment 67927 [details]
> > More problems with patron entry form
> > 
> > There are more problems with the form, additional attributes display
> > outside, see screenshot attached.
> 
> Can not reproduce this issue. On which step? Is there custom js?

- No custom JS
- Screenshot is from Home > Patrons > New patron

I mentioned it here because this bug is related to HTML in patron entry form
that is not correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67879|0   |1
is obsolete||

--- Comment #103 from Alex Buckley  ---
Created attachment 67934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67934&action=edit
Bug 17015 - Fix QA tools criticism

Adds POD to Koha/DiscreteCalendar.pm
Fixes spelling errors/bad pratices in various files.

QA tools now passes all green with the exception of
Koha::Schema::Result::DiscreteCalendar. I'm not sure what to do here, this file
did not exist before, and is (as far as I understand) generated automatically.
Any ideas?

All files including Koha::Schema::Result::DiscreteCalendar pass QA test
tool for me

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #104 from Alex Buckley  ---
Excellent new feature for Koha!

One point to keep in mind for the test plan, I may be getting a bit pedantic
here but in the future I would change the wording slightly in the following
steps:

Copy dates 1 day to multiple,
Copy dates 1 week to 1 week
Copy dates multiple dates to multiple dates

In these sections it is not particularly clear that you have to create the
holiday period before you copy the dates it looked to me at first glance that
you could copy a holiday that was set to 1 day/1 week/multiple dates in the
to/from inputs to another set of dates at the same time.

So I would emphasise that the holiday period must be created first then you can
copy the dates.

Another potential UX enhancement for the future (in a separate bug report but
don't worry at the moment) to build on your excellent work would be to have the
calendar in the 'from' input show the same month/year by default as the 'to'
date input. e.g. if I set the 'to' date to 1/10/2018 it would be useful to have
the 'from' calendar show January 2018 by default when clicked on rather than
the current month October 2017.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

--- Comment #16 from Alex Arnaud  ---
Created attachment 67935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67935&action=edit
Bug 18399 - Followup - escape reason input

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Stuart Hall Library, Iniva  changed:

   What|Removed |Added

 CC||inivalibr...@gmail.com

--- Comment #8 from Stuart Hall Library, Iniva  ---
Hello, We are new to Koha and came across this issue when setting up our first
journal subscriptions. Posting this comment to express an interest and to
endorse the view that OPAC display of the periodical publication date would be
more useful to our patrons than the receival date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #114 from Kyle M Hall  ---
Created attachment 67937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67937&action=edit
Bug 14826: Add Koha::Account::Offset(s) modules

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #115 from Kyle M Hall  ---
Created attachment 67938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67938&action=edit
Bug 14826: Resurrect account offsets table

The account offsets table should be used to track increments and
decrements of fines via payments and credits, as well as fine accruals.
It should be able to match fees to payments and visa versa, so we can
know which fee was paid by a given payment, and which payments applied
to a given fee.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Note the table accountoffsets has been renamed to account_offsets
4) Ensure fine generation creates offsets
5) Ensure creating a manual invoice creates an offset
6) Ensure a lost item charge creates an offset
7) Ensure Reverse Payment creates an offset
8) Ensure a payment creates an offset
9) Ensure a payment for multiple fees creates an offset for each
10) Ensure writeoffs create offsets

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67453|0   |1
is obsolete||
  Attachment #67454|0   |1
is obsolete||
  Attachment #67455|0   |1
is obsolete||
  Attachment #67456|0   |1
is obsolete||
  Attachment #67457|0   |1
is obsolete||
  Attachment #67458|0   |1
is obsolete||
  Attachment #67459|0   |1
is obsolete||
  Attachment #67460|0   |1
is obsolete||
  Attachment #67461|0   |1
is obsolete||
  Attachment #67462|0   |1
is obsolete||
  Attachment #67463|0   |1
is obsolete||
  Attachment #67464|0   |1
is obsolete||
  Attachment #67465|0   |1
is obsolete||

--- Comment #113 from Kyle M Hall  ---
Created attachment 67936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67936&action=edit
Bug 14826: Update database

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #116 from Kyle M Hall  ---
Created attachment 67939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67939&action=edit
Bug 14826; Unit Tests

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #118 from Kyle M Hall  ---
Created attachment 67941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67941&action=edit
Bug 14826: Remove old offset table schema file

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #119 from Kyle M Hall  ---
Created attachment 67942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67942&action=edit
Bug 14826: Add new offset table schema file

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #120 from Kyle M Hall  ---
Created attachment 67943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67943&action=edit
Bug 14826: Add offset for rental fees

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #121 from Kyle M Hall  ---
Created attachment 67944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67944&action=edit
Bug 14826: Add unit tests for _FixAccountForLostAndReturned and
_FixOverduesOnReturn

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #117 from Kyle M Hall  ---
Created attachment 67940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67940&action=edit
Bug 14826: Remove old offset table schema file

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #122 from Kyle M Hall  ---
Created attachment 67945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67945&action=edit
Bug 14826: (QA followup) Fix minor issues with unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #124 from Kyle M Hall  ---
Created attachment 67947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67947&action=edit
Bug 14826: Add account offset type table

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #123 from Kyle M Hall  ---
Created attachment 67946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67946&action=edit
Bug 14826: (QA followup) Only use plural modules in other modules

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #125 from Kyle M Hall  ---
Created attachment 67948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67948&action=edit
Bug 14826: (QA followup) POD fixes

This patch just fixes POD. There are still some false positives with the
QA scripts.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #126 from Kyle M Hall  ---
Created attachment 67949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67949&action=edit
Bug 14826 [QA Followup] - Correct number of tests run following rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

--- Comment #35 from Marcel de Rooy  ---
Since commenting this line solves the problem:
# $self->plugin( 'Koha::REST::Plugin::Pagination' );
I still hope to see something moving here ;)
Anything with setting path for Mojo plugins or so? Mojo experts around?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19085] Empty files in English web installer

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19085

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #67928|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 67950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67950&action=edit
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.

Signed-off-by: Marc Véron 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19085] Empty files in English web installer

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19085

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19085] Empty files in English web installer

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19085

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

--- Comment #36 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #35)
> Since commenting this line solves the problem:
> # $self->plugin( 'Koha::REST::Plugin::Pagination' );
> I still hope to see something moving here ;)
> Anything with setting path for Mojo plugins or so? Mojo experts around?

For the record, I cannot reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19373] CAS Login for staff interface always go back to home.

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19373

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Marcel de Rooy  ---
not ok 4 - Intranet URL should be returned when using intranet login (Bug
13507)
#   Failed test 'Intranet URL should be returned when using intranet login (Bug
13507)'
#   at t/db_dependent/Auth_with_cas.t line 62.
#  got: 'localhost:8080/cgi-bin/koha/opac-user.pl?bar=baz'
# expected: 'localhost:8080?bar=baz'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

--- Comment #5 from Marcel de Rooy  ---
Created attachment 67953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67953&action=edit
Bug 18625: Update lastseen in patron info request

Many services use SIP patron req info to validate a patron against
the koha database. If recording lastseen sites will
also want to record that the user has accessed these
library facilities although they have not logged into koha

Signed-off-by: Marcel de Rooy 
Verified that Patron Info request (63) updates lastseen when the pref has
been enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

--- Comment #6 from Marcel de Rooy  ---
Created attachment 67954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67954&action=edit
Bug 18625: (QA follow-up) Simply update_lastseen

No need to check the pref.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
  Attachment #63533|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

--- Comment #8 from Marcel de Rooy  ---
addition -> additional

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18625] update borrower last seen from SIP

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

--- Comment #7 from Marcel de Rooy  ---
No idea if the QAer will request an addition test in SIP/Patron.t or Message.t
;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19445] New: Add support for ES rebuild to koha-sandbox cron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19445

Bug ID: 19445
   Summary: Add support for ES rebuild to koha-sandbox cron
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: contribs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19445] Add support for ES rebuild to koha-sandbox cron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19445

--- Comment #1 from Nick Clemens  ---
Added below on the BWS sandboxes, probably need to add a test for if ES
enabled?

202 eval {
203 Run->new( qq|perl
$koha_src_path/misc/search_tools/rebuild_elastic_search.pl -d| );
204 };
205 if ( $@ ) {
206 push @errors, "Cannot rebuild elastic: " . $@;
207 }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Caroline Cyr La Rose  ---
It's ok now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

--- Comment #6 from Jonathan Druart  
---
I will take a look again later but I think the condition is wrong, I guess it
should be 
if( $item and ( !$blocker or $force_allow_issue ) ){

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67658|0   |1
is obsolete||

--- Comment #11 from Caroline Cyr La Rose  ---
Created attachment 67955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67955&action=edit
Bug 19361 - Followup altered wording of the default value

Sponsored-By: Catalyst IT
Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19446] New: Add button to write off individual item credits

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19446

Bug ID: 19446
   Summary: Add button to write off individual item credits
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Work to be done:
Implement a “Writeoff” button for each line on a patron’s account that has a
negative amount outstanding balance.
Writing off a credit will change the amount outstanding to $0.00 and create a
Writeoff line of the previous amount on the patron record.
Implement ability to edit fine notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19447] New: Closed budget amounts should be fixed

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19447

Bug ID: 19447
   Summary: Closed budget amounts should be fixed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Budget amounts in acquisitions are always calculated, meaning we pull the
orders and do the math. Recently we have added a few changes to how things are
calculated, additionally one can edit orders after a budget is closed ( bug
10921 )

We have three unused columns:
budget_amount
budget_encumb
budget_spend

It might be worthwhile to use these (or add new) and store the values of a
budget at closing to provide a constant historical value for audits.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19446] Add button to write off individual item credits

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19446

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19448] New: Add button to write off individual item credits

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19448

Bug ID: 19448
   Summary: Add button to write off individual item credits
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Work to be done:
Implement a “Writeoff” button for each line on a patron’s account that has a
negative amount outstanding balance.
Writing off a credit will change the amount outstanding to $0.00 and create a
Writeoff line of the previous amount on the patron record.
Implement ability to edit fine notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19448] Add button to write off individual item credits

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19448

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19449] New: Add button to write off individual item credits

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19449

Bug ID: 19449
   Summary: Add button to write off individual item credits
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Work to be done:
Implement a “Writeoff” button for each line on a patron’s account that has a
negative amount outstanding balance.
Writing off a credit will change the amount outstanding to $0.00 and create a
Writeoff line of the previous amount on the patron record.
Implement ability to edit fine notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17915] warning in Stage MARC records for import when matching rule with offset

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
I was able to reproduce this problem in master, and the patch does make the
error go away. However, I'm seeing a different error now:

stage-marc-import.pl: DBIx::Class::Storage::DBI::select_single(): Query
returned more than one row.  SQL that returns multiple rows is DEPRECATED for
->find and ->single at /home/vagrant/kohaclone/Koha/Objects.pm line 92

Is this error within the scope of this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #7)
> I think it's an ES version conflict - Elasticsearch.pm is referencing
> settings of type 'string' and using an older syntax for facets (now
> 'aggregations')
> 
> Related to 17255, ES for 16.11 and before only works with version 1.x of ES
> 
> Skip the tests? or adjust tests to run with older ES?

Skip the tests. A soon-to-die release, with no real ES support, we could even
remove those.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #6 from Jonathan Druart  
---
There are still code in C4::Account about accountlines.notify_id (at least).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://'

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

--- Comment #16 from Nick Clemens  ---
(In reply to M. Tompsett from comment #15)
> (In reply to Katrin Fischer from comment #12)
> Are there any letters with something like <>? 

I didn't see anything in my check, doesn't mean a library isn't using it in
their custom notices, but I think it is a minor local adjustment if needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

Owen Leonard  changed:

   What|Removed |Added

  Attachment #66849|0   |1
is obsolete||

--- Comment #19 from Owen Leonard  ---
Created attachment 67956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67956&action=edit
Bug 16694 - Add tests to t/db_dependent/SIP/Message.t

Signed-off-by: Owen Leonard 

Test passes with no errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441

--- Comment #9 from Jonathan Druart  
---
Created attachment 67957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67957&action=edit
Bug 19441: Remove ES-related tests

16.05.x do not provided stable ES support, it will take us too much time
to keep these tests up-to-date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441

--- Comment #10 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #8)
> we could even remove those.

granted!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Owen Leonard  ---
I can't reproduce the problem Marc shows in the screenshot, but I have another
problem: If I click the "Edit existing record" button the existing patron's
record is displayed, but it still has the "Duplicate patron record?" warning at
the top.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19083] 'Show all details' checkbox on basket summary page is broken

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19083] 'Show all details' checkbox on basket summary page is broken

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083

Owen Leonard  changed:

   What|Removed |Added

  Attachment #67874|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 67958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67958&action=edit
Bug 19083: Fix 'show all details' link on closed basket detail

'Show all details' add columns on the basket summary page.
This link is broken if the basket is closed.

Indeed there is a JS error raised by $('#toolbar').fixFloat();
The toolbar is not displayed if the basket is closed.

This is caused by bug 12333, which added the floating toolbar.

Test plan:
Create 2 baskets with orders
Close 1 basket
Click on the 'show all details' links and confirm it works as expected
Also confirm that the toolbar works correctly

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3642] New informations in overdues CSV export

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58206|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 67959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67959&action=edit
Bug 13572 - Add --actives parameter to force_borrower_messaging_defaults script

1) Apply the patch
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--actives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #11 from Marcel de Rooy  ---
Created attachment 67961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67961&action=edit
Bug 13572: (Follow-up) Print since on a separate line

Very trivial change.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #10 from Marcel de Rooy  ---
Created attachment 67960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67960&action=edit
Bug 13572: (Follow-up) Add perl extension to script

There is no reason to keep this perl script without the regular extension.
Please see other scripts in the same folder too.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|String patch|Small patch
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Add onlyactives parameter   |Add actives parameter to
   |to  |force_borrower_messaging_de
   |force_borrower_messaging_de |faults script
   |faults script   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275

Owen Leonard  changed:

   What|Removed |Added

  Attachment #66998|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 67962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67962&action=edit
Bug 19275 - clubs table broken at the opac if public enrollment is not allowed

Test Plan:
1. Create a template club and disable public enrollment
2. Create a club and add it a patron
3. login at the opac with this patron
4. Note the borked clubs table
5. Apply this patch
6. Refresh the page
7. Table is fixed!

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13703] batchRebuildBiblioTables.pl should also update from database to MARC Record.

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13703

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13666] Allow SIP2 checkin/ checkout to get branch from institution_id field AO

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19373] CAS Login for staff interface always go back to home.

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19373

--- Comment #6 from Jonathan Druart  
---
Created attachment 67963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67963&action=edit
Bug 19373: Update tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19373] CAS Login for staff interface always go back to home.

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19373

Jonathan Druart  changed:

   What|Removed |Added

 CC||matthias.meusburger@biblibr
   ||e.com
 Status|Failed QA   |Needs Signoff

--- Comment #7 from Jonathan Druart  
---
Matts, could you take a look at these changes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC Modification Templates

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #3 from Jon Knight  ---
Is there a reason for having "does not match" and "does not exist" considering
there is the choice of "if" or "unless"?  In other words isn't:

"Delete field 999 unless 999$l matches NASH"

equivalent to

"Delete field 999 if 999$l does not match NASH"

?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear old fines as did recordpayment

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580

Jason Palmer  changed:

   What|Removed |Added

 CC||jpal...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

David Bourgault  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #9 from David Bourgault  ---
Created attachment 67964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67964&action=edit
Bug 11976 - Display either or both publication date and receival date

This changes the behavior of the patch. The systempreference now allows
choosing to display either date, or both (in two separate columns).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #10 from David Bourgault  ---
Addedum : the new patch's default behavior is to display both columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19083] 'Show all details' checkbox on basket summary page is broken

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083

--- Comment #5 from PTFS Europe Sandboxes  ---
Created attachment 67965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67965&action=edit
Bug 19083: Fix 'show all details' link on closed basket detail

'Show all details' add columns on the basket summary page.
This link is broken if the basket is closed.

Indeed there is a JS error raised by $('#toolbar').fixFloat();
The toolbar is not displayed if the basket is closed.

This is caused by bug 12333, which added the floating toolbar.

Test plan:
Create 2 baskets with orders
Close 1 basket
Click on the 'show all details' links and confirm it works as expected
Also confirm that the toolbar works correctly

Signed-off-by: Owen Leonard 

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19083] 'Show all details' checkbox on basket summary page is broken

2017-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #67958|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >