[Koha-bugs] [Bug 19341] Default location is always PROC when enter Item first time manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19341 Katrin Fischer changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |In Discussion --- Comment #15 from M. Tompsett --- (In reply to Julian Maurice from comment #12) > 1. With the patch, the export tool also modifies the leader of exported > authorities (position 9 is for authority type, so this is a problem) > 2. The code is poorly formatted and is missing a comment to explain why we > need to do this. The new patch seems to address this, but I haven't tested it yet. > 3. It only fixes exported records from the export tool and only for iso2709 > format. If I export in marcxml or if I use the 'Save' button from the detail > page, the leader is still invalid. I think this is a valid reason to keep it Failed QA, though I'm changing it to in discussion. The summary doesn't say only iso2709 export format. It suggests UNIMARC records in general. > 4. This patch states clearly that the leader may be invalid in Koha but > tries to fix it at export-time instead of fixing it directly in Koha. I > think it is possible to fix the leader at save-time, so that every biblio > created/modified (whether it's by import or manually) will be saved with a > correct leader. And maybe at read-time too, for already existing invalid > records. @QAers, any opinions ? While I am not a QA person, I think this is a really good point. The leader record should be saved correctly in the first place, not need correction on export. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19341] Default location is always PROC when enter Item first time manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19341 --- Comment #2 from Vinod --- Hello Katrin Thanks for your suggestions, i understood how it works now and how to get work as per my requirements. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19331] When filtering by library, the analyticals are not recovered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19331 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #4 from M. Tompsett --- Dominic, I'm curious, are you using XSLT at all? Or are your XSLT system preferences empty? I really think this hasn't been thought through with respect to non-XSLT displays. I'm marking as Failed QA, because of Dominic's issues, though perhaps it should have another status instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mtomp...@hotmail.com --- Comment #4 from M. Tompsett --- I figured a trivial string patch of mine isn't going to Fail QA, unless the wording is horrible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #3 from M. Tompsett --- Created attachment 68574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68574&action=edit Bug 19530: Added commentary for last test when prove -v Before patch, prove -v had no comment for the last test. After patch, it says something in line with second last test. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 M. Tompsett changed: What|Removed |Added Attachment #68541|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 68573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68573&action=edit Bug 19530 - Prevent multiple transfers from existing for one item We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one. Test Plan: 1) prove t/db_dependent/Circulation/transfers.t Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #4 from Aleisha Amohia --- Created attachment 68572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68572&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #68570|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 68571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68571&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #2 from Aleisha Amohia --- Created attachment 68570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68570&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Dilan Johnpullé changed: What|Removed |Added CC||di...@calyx.net.au --- Comment #5 from Dilan Johnpullé --- Patch fails to apply in devbox. The following is from my terminal. vagrant@kohadevbox:kohaclone((dafb678...))$ git bz apply -s 19474 Bug 19474 - Convert staff client CSS to SCSS 68211 - Bug 19474: Convert staff client CSS to SCSS Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19474: Convert staff client CSS to SCSS Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/css/staff-global.css deleted in Bug 19474: Convert staff client CSS to SCSS and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/css/staff-global.css left in tree. Failed to merge in the changes. Patch failed at 0001 Bug 19474: Convert staff client CSS to SCSS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19474-Convert-staff-client-CSS-to-SCSS-bSMH6p.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #14 from Agnes Rivers-Moore --- Thank you everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #1 from Aleisha Amohia --- Created attachment 68569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68569&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] New: Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Bug ID: 19532 Summary: Recalls for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P3 Component: Staff Client Assignee: alei...@catalyst.net.nz Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, l...@catalyst.net.nz Deadline: 2017-12-01 Preface: I know this will be quite an interesting feature for lots of people. Catalyst is doing a working proof of concept for this feature. The requirements we have given to Aleisha are firm, and we will not be scope creeping them. Additional features are welcome once this initial development is either accepted or supplanted by something else. That said, we welcome comment and suggestions on the patches we will attach here, and view this as a starting point instead of a complete solution. Expected scope of the feature to include: - Ability for borrowers to place a recall on a book from the OPAC results and detail, if it is checked out (question, do we offer to issue a recall if only one copy of say 3 is checked out?) - Ability for borrowers to see their requested recalls, and the when the book is expected to be returned back - An interface similar to holds for recalls, that alerts librarians that a book needs to go on the recall shelf (Recall for User, confirm or cancel) - An interface similar to holds waiting to show recalls that are currently on the shelf, and recalls that are requested but overdue, and ones that have expired and need to be reshelved. - A view in the intranet user interface for librarians to see a borrower's recalls (similar to holds) - Notices for borrower who has the recalled book on issue, to notify that the book's due date has changed and for the recaller, to let them know when the recalled item is ready for pick up. - Something in the circ rules that defines whether an item type/borrower category is allowed to place recalls on an item. - Sysprefs for "days from now that item is now due" and "how long do I let this recall languish on the recall shelf before reshelving" Current implementation notes: * DB: recalls table • DB: old_recalls table • notices: to user who has an item checked out that a recall request has been placed on, saying request has been made and due date has been updated (may use or build upon existing code from 17509) • notices: to user who made the recall request when it has been checked in, saying the item is awaiting pickup and must be picked up within X days (may use or build upon existing code from 17509) • OPAC: in checked out tab on user summary page, show your item has a recall placed on it, highlighting the new due date • OPAC: recall button under availability on record detail page and results page • OPAC: recalls tab on user summary page Per item type/borrower category combination: • circ rules: recall due date interval - what is the new due date of the item being recalled? How many days from the date of recall do we set the new due date? • circ rules: recall overdue fine - Do we have a special fine on an item that was recalled but not returned on time? (this may be a phase two feature) • circ rules: recall shelf time (how long can it be awaiting pickup before it needs to be reshelved) • circ rules OR syspref: do recalls automatically expire? (this may be a phase two feature) • circ reports: overdue recalls • circ reports: recalls awaiting pickup / recalls waiting over X days • circ reports: recalls queue • intranet: recalls tab on member detail page, showing recalls that the borrower has requested. • intranet: highlight on checkout and detail page items with a recall due date. • intranet: alert when checking in an item with a recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Liz Rea changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19532 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 int changed: What|Removed |Added CC||i...@arcor.de --- Comment #2 from int --- 'make test' fails differently depending on the database (with 'run the database-dependent test suite' is set to 'no'). If he can't connect to a database (e.g. 'Access denied'), Koha_ExternalContent_OverDrive.t and XSLT.t fail. If he can connect to an empty database or a database without data (but with the tables), Matcher.t and Prices.t fail. This seems to be your case. With a "real" database with data, Matcher.t seems to work. I didn't investigate this further, but if you import kohastructure.sql, e.g. > mysql -u root -p kohatest < installer/data/mysql/kohastructure.sql and everything from installer/data/mysql/mandatory and installer/data/mysql/en, it should work. (If I didn't miss something.) Prices.t seems to rely on some testdata, see the fixture data in t/Prices.t (fixtures_ok). If there is a database-connection available, he seem to want this data from the database (and not the mock anymore). So if you set it up in the database, the test also works: > INSERT INTO aqbooksellers (id, name, listincgst, invoiceincgst) > VALUES (1, '0 0', 0, 0), (2, '0 1', 0, 1), (3, '1 0', 1, 0), (4, '1 1', 1, 1); I would assume that if 'run the database-dependent test suite' is set to 'no', 'make test' ignores even working database credentials in koha-conf.xml. This doesn't seem to be the case right now. I don't know if this is a general problem or if this bug should be split into several for each failing test (Koha_ExternalContent_OverDrive.t, XSLT.t, Matcher.t and Prices.t). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #53 from Katrin Fischer --- Not sure when I can test again :( Maybe it was just a data problem on my side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #52 from Liz Rea --- Hallo, Aleisha and I just walked through this patch and it is all working ok for me. We didn't have to do anything to the export files to get them to import into a new framework, nor did we have any trouble exporting the files. Bibliographic frameworks still worked as well. tl;dr: Sorry, wasn't able to replicate your problem here :( Not sure what exactly the difference could be, Aleisha and I were both using the devbox, with and without Plack enabled, on current master. Any thoughts on what might be different? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] When editing patrons without circulation permission redirect should be toa the patron 's detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] When editing patrons without circulation permission redirect should be toa the patron 's detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Katrin Fischer changed: What|Removed |Added Attachment #68557|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 68568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68568&action=edit Bug 19531: When saving patron record do not redirect to circ if not authorised If the logged in patron does not have the necessary permission we should not redirect to circulation.pl but moremember.pl instead Test plan: With the borrowers permission, you should be able to edit a patron and be redirect to the moremember page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68549|0 |1 is obsolete|| --- Comment #159 from Benjamin Rokseth --- Created attachment 68564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68564&action=edit Bug 7317: (followup) Migrate endpoint to OpenAPI This patch moves the current endpoint implementation from Swagger2 to the OpenAPI plugin. It also takes advantage of the overloaded Koha::Illrequest::TO_JSON method which has now the option to embed what's needed for the REST api. The path spec is adjusted to fit OpenAPI, and some minor fixes are applied: - Missing 'metadata' query param - 'ill' permissions should be required instead of 'borrowers' - Full test coverage To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68551|0 |1 is obsolete|| --- Comment #161 from Benjamin Rokseth --- Created attachment 68566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68566&action=edit Bug 7317: (followup) Fix id and class on body tag The HTML body tag looked like this: Probably an overlooked copypasta. This patch changes it to: This should not have any visual side effects. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68552|0 |1 is obsolete|| --- Comment #162 from Benjamin Rokseth --- Created attachment 68567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68567&action=edit Bug 7317: Rewrite atomicupdate file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68550|0 |1 is obsolete|| --- Comment #160 from Benjamin Rokseth --- Created attachment 68565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68565&action=edit Bug 7317: Adjust packages koha-conf.xml Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Original sign off message: It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. Update: I have applied the new patchset and done some exploratory testing, using the Dummy backend. Everything seems to be fine after the patches were re-arranged and with the followups from Tomas. All tests pass. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68546|0 |1 is obsolete|| --- Comment #156 from Benjamin Rokseth --- Created attachment 68561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68561&action=edit Bug 7317: DO NOT PUSH: Update OPAC CSS Signed-off-by: Magnus Enger It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. I think this is one of those things we need to get into Koha so we can start using it and find any remaining bugs. One non-functional thing that needs to be looked at are the tests. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68547|0 |1 is obsolete|| --- Comment #157 from Benjamin Rokseth --- Created attachment 68562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68562&action=edit Bug 7317: (QA folowup) 404 if module is disabled (intranet) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68544|0 |1 is obsolete|| --- Comment #154 from Benjamin Rokseth --- Created attachment 68559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68559&action=edit Bug 7317: DO NOT PUSH: Updated Schema Files. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68548|0 |1 is obsolete|| --- Comment #158 from Benjamin Rokseth --- Created attachment 68563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68563&action=edit Bug 7317: Overload Koha::Illrequest::TO_JSON This patch implements an overloaded TO_JSON method, that introduces the option to (selectively) embed information required on the REST api. Tests are included for the new method. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68545|0 |1 is obsolete|| --- Comment #155 from Benjamin Rokseth --- Created attachment 68560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68560&action=edit Bug 7317: Interlibrary loans framework for Koha. This Commit is at the heart of adding an interlibrary loans framework for Koha. The framework does not prescribe a particular workflow. Instead it provides a general framework that can be extended & implemented by individual backends whose responsibility it is to implement a specific workflow. The module is largely self-sufficient: it adds new tables to the Koha database and touches only a few files in the Koha source tree. Primarily, we add our files to the Makefile and the koha-conf.xml, define ill paths for the REST API, and introduce links from the main intranet, opac pages & user permissions. Outside of this we simply add new files & functionality. Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What|Removed |Added Attachment #68543|0 |1 is obsolete|| --- Comment #153 from Benjamin Rokseth --- Created attachment 68558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68558&action=edit Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] When editing patrons without circulation permission redirect should be toa the patron 's detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Katrin Fischer changed: What|Removed |Added Severity|blocker |normal Summary|Can no longer edit patrons |When editing patrons |with only borrower |without circulation |permission |permission redirect should ||be toa the patron's detail ||page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] Can no longer edit patrons with only borrower permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 --- Comment #1 from Jonathan Druart --- Created attachment 68557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68557&action=edit Bug 19531: When saving patron record do not redirect to circ if not authorised If the logged in patron does not have the necessary permission we should not redirect to circulation.pl but moremember.pl instead Test plan: With the borrowers permission, you should be able to edit a patron and be redirect to the moremember page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] Can no longer edit patrons with only borrower permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #51 from Katrin Fischer --- Hm, it didn't work for me until I had changed the frameworkcode this morning - I actually had missed the step at first and then went back to look for a reason why it would not work. I had created a new framework, imported into the empty framework, page relaoded, but it remained empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #50 from Aleisha Amohia --- Created attachment 68556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68556&action=edit Bug 13952: [FOLLOW-UP] Fixing JS error Missing a bracket that stopped the export modal from closing after clicking the button. Now fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #49 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #44) > Hi Aleisha, export is all looking good now. Signing off. > > Not a blocker for me: > > 1) When exporting authority types, the window stays open in the background, > when exporting bibliographic frameworks it closes after clicking the > 'export' button. Will fix this. > > 2) Not a blocker as this is the current behaviour, but maybe something for > the future: > > >6) IMPORTANT STEP: > >Before you import, make sure that the authtypecode of the file you > >are going to import matches the Code of your new authority type. > > Wouldn't it be better to display a warning in the case that the selected > framework for import and the code in the file don't match? It seems like > this could cause some unwanted data loss. I fixed this in Comment 31, you don't have to match up the authtypecode anymore, this step is from an old test plan. For those in the future testing, please use the most recent test plan from Comment 45. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] Can no longer edit patrons with only borrower permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Katrin Fischer changed: What|Removed |Added Summary|Can no longer edit patrons |Can no longer edit patrons |with borrower permissions |with only borrower ||permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] New: Can no longer edit patrons with borrower permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Bug ID: 19531 Summary: Can no longer edit patrons with borrower permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This was just reported for 16.11.10, but was able to confirm in master: 1) create a staff account with catalog and borrowers permission 2) create a new user with this patron account 3) try to edit the patron account - you get a log in screen (Error: You do not have permission to access this page.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19461] Add floating toolbar to staff client catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #13 from Katrin Fischer --- Hi Julian, I really like it! The problem I previously had disappeared :) Some notes: 1) Agree with Nick: "Edit" button would be nicer as a link, matching other pages like the details page. 2) If you select no subscriptions and click on edit, there should be a warning. Or it should be inactive until you have selected some. 3) It would be nice to have a checkbox like on the batch item edit in order to allow emptying the note fields. At the moment you'd have to add a space or something to clear them out. 4) Agree with Nick: A cancel link would be consistent with other pages and features. 5) Agree with Nick: Maybe 'Save' instead of 'Start batch edit'? 6) Agree with Nick: It might be nice to be able to select/deselect subs before applying the edits - not a blocker but saves from going back a page on wrong click Don't understand that one: >is 'No change' I cannot know what the original value was for things like >'Create items when receiving Nick, can you explain? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19341] Default location is always PROC when enter Item first time manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19341 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Vinod, I think this is a misunderstanding on how the feature works. Try the following: - Set NewItemsDefaultLocation to 'PROC' - Add a new item, set another location - Verify that the location shown on the detail page is 'PROC' But: - Check the item in! - It will now show the location you had selected. If you are using CART, it will first go to CART and then to your catalogued location, but that's the intended behaviour :) For what you want I'd suggest another configuration: - Remove PROC from the system preference - Edit 952$c in the frameworks and set a default value of PROC This will make PROC preselected for every new item, but it can be changed before saving and will then show the selected location immediately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #22 from Séverine Queune --- (In reply to Jonathan Druart from comment #20) > (In reply to Séverine Queune from comment #0) > > - set the field “items.notforloan” or “items.itemlost” (define in a system > > preference) from “0” to a value from the same ‘authorized values list’ and > > set in another system preference > > I do not know what is better here. Do we need 2 more sysprefs? Only 1 with a > YAML syntax? > Or we can also display the LOST authorised values on the "Holds awaiting > pickup" page. Nicolas agreeds with the yaml syntax syspref ! Can you tell us more about the behaviour you project before starting to develop it (to be sure) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19461] Add floating toolbar to staff client catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- This is awesome :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #6 from Katrin Fischer --- It's a good question. I think as ExpiredPatronBlockOpacActions already covers normal renewals it makes sense to include AutoRenewals there. If we want to have both separate, I'd make the new pref specific, so that it doesn't interfere with the existing pref: ExpiredBlockAutoRenewing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Dilan, please do not edit the commit message. You removed the test plan from the first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #24 from Katrin Fischer --- Checked Nick's follow-up and liked it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischer changed: What|Removed |Added Attachment #68475|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 68555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68555&action=edit Bug 13178: QA Followup - fix kohastructure and update info in fields Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischer changed: What|Removed |Added Attachment #68474|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 68554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68554&action=edit Bug 13178: Correct Max cardnumberlength ($max is the value of the max size of a card number) - $max not hardcoded anymore in C4::Memeber - $max now correctly adapts to the field of cardnumber in database Signed-off-by: Marc Véron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischer changed: What|Removed |Added Attachment #68473|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 68553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68553&action=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - Update dbix scheme 4 - set the value of CardnumberLength to a value between 16 and 32 5 - Check you can enter a propper cardnumber (modify to 32 instead 20) + max value now depends on the database field value to Signed-off-by: Marc Véron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19515] Refactor REST API session mocking to reduce code duplication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19515 --- Comment #6 from Tomás Cohen Arazi --- > - You are missing something that's important for testing: we need to be able > to assign the patron specific permissions, something in the lines of: > my $flags = ( $args->{authorized} ) ? 2**$args->{authorized} : 0; About this, this has been wrong in all submitted tests. I've implemented it correctly in bug 7317. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19515] Refactor REST API session mocking to reduce code duplication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19515 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Tomás Cohen Arazi --- Hi Olli, good innitiative. Just some remarks: - You patch covers several endpoints not currently in master, so it won't apply. - It is way too much to make it dependent on the castToObject stuff, just a personal opinion: you can just my $patron = $builder->build_object({class=>'Koha::Patrons'}); to get a sample patron. This is already in master... - You are missing something that's important for testing: we need to be able to assign the patron specific permissions, something in the lines of: my $flags = ( $args->{authorized} ) ? 2**$args->{authorized} : 0; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #150 from Tomás Cohen Arazi --- Created attachment 68550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68550&action=edit Bug 7317: Adjust packages koha-conf.xml Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Original sign off message: It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. Update: I have applied the new patchset and done some exploratory testing, using the Dummy backend. Everything seems to be fine after the patches were re-arranged and with the followups from Tomas. All tests pass. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #152 from Tomás Cohen Arazi --- Created attachment 68552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68552&action=edit Bug 7317: Rewrite atomicupdate file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #151 from Tomás Cohen Arazi --- Created attachment 68551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68551&action=edit Bug 7317: (followup) Fix id and class on body tag The HTML body tag looked like this: Probably an overlooked copypasta. This patch changes it to: This should not have any visual side effects. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #149 from Tomás Cohen Arazi --- Created attachment 68549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68549&action=edit Bug 7317: (followup) Migrate endpoint to OpenAPI This patch moves the current endpoint implementation from Swagger2 to the OpenAPI plugin. It also takes advantage of the overloaded Koha::Illrequest::TO_JSON method which has now the option to embed what's needed for the REST api. The path spec is adjusted to fit OpenAPI, and some minor fixes are applied: - Missing 'metadata' query param - 'ill' permissions should be required instead of 'borrowers' - Full test coverage To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #148 from Tomás Cohen Arazi --- Created attachment 68548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68548&action=edit Bug 7317: Overload Koha::Illrequest::TO_JSON This patch implements an overloaded TO_JSON method, that introduces the option to (selectively) embed information required on the REST api. Tests are included for the new method. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #147 from Tomás Cohen Arazi --- Created attachment 68547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68547&action=edit Bug 7317: (QA folowup) 404 if module is disabled (intranet) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #146 from Tomás Cohen Arazi --- Created attachment 68546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68546&action=edit Bug 7317: DO NOT PUSH: Update OPAC CSS Signed-off-by: Magnus Enger It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. I think this is one of those things we need to get into Koha so we can start using it and find any remaining bugs. One non-functional thing that needs to be looked at are the tests. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #145 from Tomás Cohen Arazi --- Created attachment 68545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68545&action=edit Bug 7317: Interlibrary loans framework for Koha. This Commit is at the heart of adding an interlibrary loans framework for Koha. The framework does not prescribe a particular workflow. Instead it provides a general framework that can be extended & implemented by individual backends whose responsibility it is to implement a specific workflow. The module is largely self-sufficient: it adds new tables to the Koha database and touches only a few files in the Koha source tree. Primarily, we add our files to the Makefile and the koha-conf.xml, define ill paths for the REST API, and introduce links from the main intranet, opac pages & user permissions. Outside of this we simply add new files & functionality. Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #144 from Tomás Cohen Arazi --- Created attachment 68544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68544&action=edit Bug 7317: DO NOT PUSH: Updated Schema Files. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #143 from Tomás Cohen Arazi --- Created attachment 68543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68543&action=edit Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68542|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68525|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68522|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68523|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68524|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68521|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68520|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68519|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68518|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #68517|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #142 from Tomás Cohen Arazi --- Created attachment 68542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68542&action=edit Bug 7317: Rewrite atomicupdate file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #1 from Kyle M Hall --- Created attachment 68541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68541&action=edit Bug 19530 - Prevent multiple transfers from existing for one item We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one. Test Plan: 1) prove t/db_dependent/Circulation/transfers.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] New: Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Bug ID: 19530 Summary: Prevent multiple transfers from existing for one item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] need an add option in marc modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Jon Knight changed: What|Removed |Added CC||j.p.kni...@lboro.ac.uk --- Comment #6 from Jon Knight --- When I try to do step 11 in the test plan, the rule created comes out as "Delete" rather than "Add new". Similarly, if I try to edit the rule to make it "Add new" it goes back to "Delete" once the "Update action" button is pressed in the "Edit action 3" dialog box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] need an add option in marc modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens changed: What|Removed |Added Attachment #64808|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 68540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68540&action=edit Bug 13560 - need an add option in marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to Add & Update so that add will always add a field and Update will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] need an add option in marc modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Alex, it works but there is no client-side validation Take a look at commit 7cc65af6ffdabbabe7ae3463f51096de375216ad Bug 18298: Use the validate jQuery plugin We want this form to behave like others. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Pushed to master for 17.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 --- Comment #1 from Jonathan Druart --- Created attachment 68539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68539&action=edit Bug 19529: Prevent NoIssuesChargeGuarantees.t to fail randomly Use a categorycode != "X" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19529] New: NoIssuesChargeGuarantees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 Bug ID: 19529 Summary: NoIssuesChargeGuarantees.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 728. # Looks like your test exited with 255 before it could output anything. [15:27:16] t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. When categorycode = X -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #68526|1 |0 is obsolete|| --- Comment #8 from Victor Grousset/tuxayo --- Comment on attachment 68526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68526 Bug 19522: Label creator - some strings are not translatable git-bz invalidated this patch because another one had the same commit summary (which was the name of this bug) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 68538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68538&action=edit Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #68526|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 68537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68537&action=edit Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see "foobar" instead of "Fields to print" 8. then you should see the "Unités" dropdown with french units -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19513] More changes to MarkIssueReturned.t (after bug 19487)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19513 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19028] Add 'shelving location' to holdings table in detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18184] Subscriptions summaries don' t show if seeing all subs attached to a biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18184 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not styled with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/