date:20171030

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #9 from M. Tompsett  ---
Comment on attachment 68633
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68633
Bug 19444: Do not auto renew if patron is expired and
BlockExpiredPatronOpacActions is set

Review of attachment 68633:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19444=68633)
-

::: installer/data/mysql/updatedatabase.pl
@@ +14854,4 @@
>  });
>  
>  SetVersion( $DBversion );
> +print "Upgrade to $DBversion done (Bug 12768 - Add 'Processing Fee' to 
> the account_offset_types table if missing)\n";

This isn't related to this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

--- Comment #3 from M. Tompsett  ---
Created attachment 68851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68851=edit
Bug 19547: Deal with --create-db missing debian.cnf issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

--- Comment #2 from M. Tompsett  ---
Further thought makes me think we should be generating our koha-common.cnf file
if there is no debian.cnf, rather than soft-link. MariaDB generates a dummy
debian.cnf with root user and blank password when I ran 'sudo dpkg-reconfigure
mariadb-server'. This patch may work for koha-create options other than
--create-db, but I have yet to test further after these results thus far.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #12 from Liz Rea  ---
This patch applies just fine for me on a clean master branch.

I recommend the following: 

git fetch origin && git checkout origin/master
git checkout -b bug-18645
git bz apply 18645

(or apply the patch however you usually do)

This is the best and really only way to test patches.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #11 from Alex Buckley  ---
(In reply to Dominic Pichette)

Hi Dominic

Thanks for trying to test. Hmm it is applying successfully for me on a clean,
up to date branch. If you try applying on a new branch rather than resetting do
you get the same error?

Also can someone else try testing just to determine if this is a system
specific issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

--- Comment #1 from M. Tompsett  ---
Created attachment 68850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68850=edit
Bug 19547: MariaDB install has no debian.cnf

This attempts to handle issues arising when running
koha-create on a system that never had MySQL installed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19492] Field 'lowestPriority' doesn't have a default value (MariaDB)

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492

--- Comment #2 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #1)
> What is the version of MariaDB?

10.2.9-MariaDB-10.2.9+maria~xenial

> Did you modify my.cnf?

Don't think so.

> Does `grep -r sql-mode /etc/mysql` return something?

$ sudo grep -r sql-mode /etc/mysql
/etc/mysql/mysql.conf.d/mysqld.cnf:sql-mode="IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19123] Remove/fix reference to latest release

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123

--- Comment #2 from Jonathan Druart  
---
Ok so apparently it reads the docs/history.txt to generate it.

What's the point of this info? Should we remove it or fix it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19123] Remove/fix reference to latest release

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123

--- Comment #1 from Jonathan Druart  
---
17.05.05 and 16.11.13 seems ok:
https://koha-community.org/koha-17-05-05-release/
 "The last Koha release was 17.05.04, which was released on sept. 20, 2017."
https://koha-community.org/koha-16-11-13-release/
 "The last Koha release was 16.11.12, which was released on September 21,
2017."

But not 16.05.18
https://koha-community.org/koha-16-05-18-release/
 "The last Koha release was 3.22.8, which was released on June 24, 2016."

I guess you (RMaint) are updating it manually?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19284] Correct version numbering by adding missing zeros

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19284

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Jonathan Druart  
---
commit 1c179cdd01e323124c83155724376ab5a04357e2
  Bug 19284: Correct version numbering by adding missing zeros

Tested with master:

1c1
< # RELEASE NOTES FOR KOHA 17.06.00
---
> # RELEASE NOTES FOR KOHA 17.6.0
11c11
< Koha 17.06.00 can be downloaded from:
---
> Koha 17.6.0 can be downloaded from:
20c20
< Koha 17.06.00 is a major release, that comes with many new features.
---
> Koha 17.6.0 is a major release, that comes with many new features.
872c872
< The release team for Koha 17.06.00 is
---
> The release team for Koha 17.6.0 is
904c904
< new features in Koha 17.06.00:
---
> new features in Koha 17.6.0:
915c915
< We thank the following individuals who contributed patches to Koha 17.06.00.
---
> We thank the following individuals who contributed patches to Koha 17.6.0.
973c973
< patches to Koha 17.06.00
---
> patches to Koha 17.6.0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19082] Release notes contain reference to INSTALL files that have been removed

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19082

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  
---
commit 48be9df68d5091e1da4348100a3516001c0d400c
  Bug 19082: Remove reference to the INSTALL file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] New: Maria DB doesn't have a debian.cnf

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

Bug ID: 19547
   Summary: Maria DB doesn't have a debian.cnf
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

This means if you install Debian with no root password set (so sudo is
installed by default), and then you start to following the typical installation
instructions (https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages),
when you get to the point where you want to koha-create you get something like
this:
$ sudo koha-create --create-db library
awk: cannot open /etc/mysql/koha-common.cnf (No such file or directory)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price diplay on a basketgroup

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #5 from Jon Knight  ---
Patch commit message updated to match formatting requirements in
https://wiki.koha-community.org/wiki/Commit_messages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price diplay on a basketgroup

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #68276|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price diplay on a basketgroup

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #4 from Jon Knight  ---
Created attachment 68849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68849=edit
Bug 19479: Patch to format totals according to the CurrencyFormat syspref.

On the page acqui/basketgroup.pl the prices of baskets should be shown
according to the selected CurrencyFormat syspref.

Test plan:

1) Create some baskets with items in them.
2) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
3) Go to Administration and change CurrencyFormat syspref to one of the other
   available options and recheck step 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #22 from Victor Grousset/tuxayo  ---
Could there be a difference between using koha-translate and
misc/translator/translate?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #21 from Victor Grousset/tuxayo  ---
@Owen Leonard
I followed the test plan for 68612 from the latest code on the master branch.
And  applied only 68612.
After step 6 (update the language, I used ./translate update fr-FR)
When I run
grep -rin -E "\"fields to print" misc/translator/po
Then I get
misc/translator/po/fr-FR-staff-prog.po:24391:msgid "Fields to print"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #164 from Jonathan Druart  
---
1/ 
+TODO:
+
+- Anything invoking the ->status method; annotated with:
+  + # Old use of ->status !

What do it mean?

2/ I will not make you rewrite everything, but it would have been better to
stay consistent and not mix snake_case and camelCase for method names.

First steps with the GUI:
3/ This is what I see when I enable the module:
https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org
Looks wrong.

4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got:
Loading failed for the

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #163 from Jonathan Druart  
---
Please fix QA script failures.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode hides email and breaks workflow

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #4 from Jonathan Druart  
---
Katrin, I do not understand. Which email are you talking about?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #23 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #21)
> Hi Julian,
> Thanks for taking care of this.
> I am stuck and I do not have more time to spend on this. Do you have
> something to suggest?
> If we do not find a way to handle tz easily, we can provide a way to compare
> dates without handling them.
> Moreover I am not sure we need it in existing tests.

I'm not sure if we need it, but I think it's better to behave like
DateTime::compare.
The last patch should fix the timezone problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #22 from Julian Maurice  ---
Created attachment 68848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68848=edit
Bug 19176: Fix how t::lib::Dates::compare handle timezone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #20 from Owen Leonard  ---
I installed fr-FR in my devbox using 'sudo koha-translate --install fr-FR --dev
kohadev' With the patch applied, even after running 'sudo koha-translate
--update fr-FR --dev kohadev' I still don't see 'Fields to print' as a
standalone string in the po file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #21 from Jonathan Druart  
---
Hi Julian,
Thanks for taking care of this.
I am stuck and I do not have more time to spend on this. Do you have something
to suggest?
If we do not find a way to handle tz easily, we can provide a way to compare
dates without handling them.
Moreover I am not sure we need it in existing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

--- Comment #16 from M. Tompsett  ---
Comment on attachment 68470
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68470
Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level
values for manual credit in pay.tt and replaced the description with string
"Credit"

Review of attachment 68470:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=2454=68470)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
@@ -132,5 @@
> -  [% CASE 'HE' %]Hold waiting too long
> -  [% CASE 'Rent' %]Rental fee
> -  [% CASE 'FOR' %]Forgiven
> -  [% CASE 'LR' %]Lost item fee refund
> -  [% CASE 'PF' %]Processing fee

This is why you put white space changes in a different file. I believe this
line got removed incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

--- Comment #4 from Jonathan Druart  
---
Created attachment 68847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68847=edit
Bug 19539: (follow-up) Fix column index shift in cirulation rules

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68789|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 68846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68846=edit
Bug 19539: Fix column index shift in cirulation rules

This patch fixes an index shift introduced by bug 18857 when it introduced
a new column.

To test:
- On the Circulation and fine rules page
- Empty the value of 'Current on-site checkouts allowed' and save
- Notice 'Unlimited' shows on the saved rule.
- Click edit
=> FAIL: the 'Unlimited' string displays instead of the empty string on the
editing row.
- Apply this patch
- Re-open the circ rules page
- Click edit
=> SUCCESS: An empty string fills the 'Unlimited' fields
- Sign off :-D

Signed-off-by: David Bourgault 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

--- Comment #44 from Tomás Cohen Arazi  ---
(In reply to Dominic Pichette from comment #43)
> Created attachment 68791 [details] [review]
> Bug 18282: operationId must be unique
> 
> operationId has the following documentation:
>  "Unique string used to identify the operation. The id MUST be unique among
> all
>   operations described in the API."
> 
> This patch modifies operationIds to be unique accross our API operations.
> 
> Signed-off-by: Tomas Cohen Arazi 
> 
> Signed-off-by: Jonathan Druart 
> Signed-off-by: Dominic Pichette 

Dominique, I think you submitted a signed patch to the wrong bug report. I
obsoleted it and marked the bug back as Needs Signoff to avoid confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

M. Tompsett  changed:

   What|Removed |Added

  Attachment #62994|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Comment on attachment 62994
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62994
[SIGNED OFF] Bug 2454 - Amended patch: Removed the display of accountype,
Notify ID, Level values for manual credit in pay.tt and replaced the
description with string "Credit"

The second one is the rebase of this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19464] emailLibrarianWhenHoldIsPlaced email enhancement

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19464

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68791|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

--- Comment #4 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #2)
> > +next unless CanItemBeReserved($b,$itemnumber);
> 
> Shouldn't $b be $borrowernumber ?

Yes, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67124|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 68845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68845=edit
Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest

Almost everywhere we call IsAvailableForItemLevelRequest we already have
a Koha::Patron and Koha::Item object. It makes sense to use them to
avoid a refetch

Test plan:
It would be good to test this patch on top of 19300 and 19301 and make
sure everything works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #14 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #13)
> CONFLICT (content): Merge conflict in
> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
> 
> Please do NOT modify the indentation when you do not modify the line or
> create a new block. That will avoid this kind of unnecessary rebases.

"If you want to reindent large amounts of existing code in connection with a
bugfix or enhancement, you must do so in a separate patch from the one with
code changes (unless the reindent is required due to the addition or removal of
an indentation level (for example, an additional if added around a block)."
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED

--- Comment #5 from Jonathan Druart  
---
Blocked by bug 19243. We need to find a clean way to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED

--- Comment #4 from Jonathan Druart  
---
Blocked by bug 19243. We need to find a clean way to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium test

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #6 from Jonathan Druart  
---
Blocked by bug 19243. We need to find a clean way to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19183] Acquisition module setup selenium test

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED

--- Comment #5 from Jonathan Druart  
---
Blocked by bug 19243. We need to find a clean way to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19184] Purchase workflow selenium test

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED

--- Comment #5 from Jonathan Druart  
---
Blocked by bug 19243. We need to find a clean way to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #12 from Jonathan Druart  
---
Blocked by bug 19243. We need to find a clean way to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380
Bug 17380 depends on bug 18811, which changed state.

Bug 18811 Summary: Visibility settings inconsistent between framework and 
authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #32 from Katrin Fischer  ---
This won't get pushed into 16.11.x, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
Bug 17908 depends on bug 17380, which changed state.

Bug 17380 Summary: Resolve several problems related to Default authority 
framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #39 from Katrin Fischer  ---
Looking at Marcel's comments, this won't get pushed to 16.11.x. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Add a Default ACQ framework

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

--- Comment #9 from Jonathan Druart  
---
I think a first step would be to have a ACQ framework that does not introduce
regression and remove the warning message.
This is what does the patch.

The need here was bug 19289.

If ACQ needs to be improved/tweaked, I think it should be done on a separate
bug report (maybe it will depend on the MARC flavour, languages, etc.?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451

Owen Leonard  changed:

   What|Removed |Added

  Attachment #68200|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 68844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68844=edit
Bug 19451: Add no_overwrite option to borrowers-force-messaging-defaults.pl

This option allows you to add preferences only when they are not yet
present. In other words: skip patrons that already set their prefs.

Test plan:
[1] Delete all borrower messaging prefs for a patron.
[2] Run borrowers-force-messaging-defaults.pl -no_overwrite -doit
Verify that the patron now has default msg preferences.
[3] Change his settings and make them non-default.
For instance, increase days in advance.
[4] Run borrowers-force-messaging-defaults.pl -no_overwrite -doit
Verify that the patron still has the non-default settings.
[5] Run borrowers-force-messaging-defaults.pl -doit
Verify that the patron msg prefs have been overwritten.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

--- Comment #4 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #3)
> I never managed to reproduce it. Are you sure your setup is pointing to the
> right PERL5LIB?

Ha. If it wasn't, I really should have had so much more problems..
And what about uncommenting a line in a library that is not used?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

--- Comment #3 from Tomás Cohen Arazi  ---
I never managed to reproduce it. Are you sure your setup is pointing to the
right PERL5LIB?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #6 from Owen Leonard  ---
This patch deletes staff-global.css, assuming that staff-global.css should be
generated from the SCSS file. Since commits have been made to stafff-global.css
in the meantime, it creates a conflict. I will submit follow-ups to catch up
with master, but I think this could be properly tested by resolving the
conflict manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16748] Batch checkout needs set due date

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748

Emma Perks  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

--- Comment #5 from Emma Perks  ---
Would like to request this enhancement also.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #38 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #37)
> Doesn't apply cleanly on 16.11.x, please rebase if you want this to be
> included.

See comment on the dependency 18811.
Recommend to close it now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

--- Comment #31 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #30)
> Applying: Bug 18811: [QA Follow-up] Add tests for
> Koha::Authority::Subfields/Tags
> fatal: mode change for t/db_dependent/Authorities/MergeRequests.t, which is
> not in current HEAD

This might change the game. It is related to 9988.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

--- Comment #30 from Marcel de Rooy  ---
Applying: Bug 18811: [QA Follow-up] Add tests for
Koha::Authority::Subfields/Tags
fatal: mode change for t/db_dependent/Authorities/MergeRequests.t, which is not
in current HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

--- Comment #29 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #28)
> I am not sure about this comment:
> 
> NOTE: The proposed solution restores consistency, but will remove hidden
> fields from the MARC record.
> 
> Nick or Marcel, can you please explain and advise if this should go into
> 16.11.x?

Comment11 addresses this concern. I would recommend to push it in order to keep
in line with 17.05 too.
Note too that fields are not removed rightaway but could be lost when you save
your (authority) record again in such a framework. A warning is printed and a
script is provided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #49 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #46)
> 2/ return wantarray ? @retval : ( @retval ? $retval[0] : undef );
> This is not necessary, do not do that please.
> Caller can do
> my ( $v ) = the_sub();
> Not blocker.

This is about GetMarcFromKohaField.
Bug 19097 will adjust all calls. This seems imo now the best opportunity to
address this point and verify that we should miss a call in scalar context. I
will also need to remove the associated test. Added a comment on that bug.
If it is no blocker, leave it now as-is here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #19 from Victor Grousset/tuxayo  ---
Thanks for testing my first set of patches.

> Maybe the translated string is only present in your .po?

The .po I use is the one from the repository without any modification.

I followed the test plan for 68740 from the latest code on the master branch.
And whether by applying only 68740 or all the patches. In the end, I get the
expected result ("Exporter des étiquettes").

I'm not sure my step 9 was well named (one might think that it's different from
step 1)
It means using `koha-translate --install` or `./translate install` is that what
you did?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19097] Koha to MARC mappings (Part 3): Correct remaining GetMarcFromKohaField and TransformMarcToKoha calls

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097

--- Comment #2 from Marcel de Rooy  ---
Moving this QA comment on bug 19096 about sub GetMarcFromKohaField here also:

return wantarray ? @retval : ( @retval ? $retval[0] : undef ); 
This is not necessary, do not do that please.
Caller can do
my ( $v ) = the_sub();
Not blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode hides email and breaks workflow

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

Katrin Fischer  changed:

   What|Removed |Added

Summary|Patron self registration:   |Patron self registration:
   |hiding lbranchcode also |hiding branchcode hides
   |hides email |email and breaks workflow

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

--- Comment #35 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #32)
> Comment on attachment 68671 [details] [review]
> Bug 17989: Final changes
> 
> Review of attachment 68671 [details] [review]:
> -
> 
> ::: svc/members/search
> @@ +28,5 @@
> >  use Koha::Patrons;
> >  
> >  my $input = new CGI;
> > +my $template_path = $input->param('template_path');
> > +if( !$template_path || $template_path =~ /^\/|\.\./ ) {
> 
> Why do we need to check that here? It is already checked in badtemplatecheck.

No, it is not needed. Removed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68672|0   |1
is obsolete||

--- Comment #34 from Marcel de Rooy  ---
Created attachment 68843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68843=edit
Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t

SuggestionEngine_ExplodedTerms.t uses paths like /../.. or /.. in order
to find a template in opac-tmpl.
Sub badtemplatecheck does not like these paths.
Using Cwd::abs_path to resolve the situation (rel2abs does not).

Test plan:
Run again t/db_dependent/SuggestionEngine_ExplodedTerms.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68671|0   |1
is obsolete||

--- Comment #33 from Marcel de Rooy  ---
Created attachment 68842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68842=edit
Bug 17989: Final changes

[1] The template sco/printslip.tt is in the regular modules directory.
Should not be prefixed with a slash.

Test plan:
[1] Try to find another occurrence just like the one corrected in
sco/printslip.pl where an absolute path is passed to gettemplate or
get_template_and_user. I already tried several regex variations
while git grepping template_name, but you may still find one..

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 
Amended: Removed the changes for svc/members/search. Not needed.
Commit message adjusted accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68838|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall  ---
Created attachment 68839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68839=edit
Bug 16497: [REST] Add /api/v1/libraries

CRUD for libraries via REST API.

GET/api/v1/libraries  - List all libraries
GET/api/v1/libraries/{branchcode} - Get one Library
POST   /api/v1/libraries  - Add new Library
DELETE /api/v1/libraries/{branchcode} - Delete Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

Signed-off-by: Josef Moravec 
Signed-off-by: Benjamin Rokseth 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #28 from Kyle M Hall  ---
Created attachment 68841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68841=edit
Bug 16497: (followup) New column marcorgcode added

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #27 from Kyle M Hall  ---
Created attachment 68840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68840=edit
Bug 16497: Add missing field in definitions due to bug 18066

Signed-off-by: Josef Moravec 
Signed-off-by: Benjamin Rokseth 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68746|0   |1
is obsolete||
  Attachment #68747|0   |1
is obsolete||
  Attachment #68748|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 68838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68838=edit
Bug 16497: [REST] Add /api/v1/libraries

CRUD for libraries via REST API.

GET/api/v1/libraries  - List all libraries
GET/api/v1/libraries/{branchcode} - Get one Library
POST   /api/v1/libraries  - Add new Library
DELETE /api/v1/libraries/{branchcode} - Delete Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

Signed-off-by: Josef Moravec 
Signed-off-by: Benjamin Rokseth 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12227] remove demo user functionality

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67617|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 68837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68837=edit
Bug 12227: Remove the demo functionality

This is a legacy mode that did not really work.

Test plan:
Play with frameworks and sysprefs and confirm the changes
(add/del/update) are taken into account.

Signed-off-by: Alex Buckley 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12227] remove demo user functionality

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

--- Comment #2 from Marcel de Rooy  ---
So just for the record:
I have a very simple workaround (but Tomas wont like it very much): Just
comment the line until this path issue has been resolved completely.
Any other ideas ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

--- Comment #1 from Marcel de Rooy  ---
Stopped/started apache, memcached, plack. To no effect.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||19546


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546
[Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm
breaks opac and staff
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Can't locate|Can't locate
   |Mojolicious/Plugin/Koha/RES |Mojolicious/Plugin/Koha/RES
   |T/Plugin/Pagination.pm  |T/Plugin/Pagination.pm
   ||breaks opac and staff
 Depends on||19196
 CC||stefan.berndts...@ub.gu.se,
   ||tomasco...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
[Bug 19196] Add pagination helpers
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19546] New: Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

Bug ID: 19546
   Summary: Can't locate
Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl

See bug 19196 and my comment 40.
What happened? For just a short time I did not see the error. I merged the last
changes on master, ran updatedatabase, restarted plack, flushed the cache and
there it was again:

Error while loading /etc/koha/plack.psgi: Can't load application from file
"api/v1/app.pl": Can't locate
Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm:  
./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at (eval
1299) line 1.

This effectively breaks opac and staff client completely until I comment the
change for the Pagination plugin again in Koha/REST/V1.pm.
Note that nothing special happened between Friday and now on this virtual
Jessie box..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #48 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #46)
> Reviewed on top of bug 10306
> 
> 1/ I always though we would need to fix the mapping at some point, and make
> it use the correct template. Here we are moving the other way around.
> Does that mean we should move the mapping out of the framework tables?

Implicitly, yes. They could in be another table. The code now looks only at
Default, but keeps the other frameworks in sync.

Note that I only did this after consulting the mailings lists in order to know
if there are relevant objections for doing so. I did receive responses of
approval, but no objections.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #68835|0   |1
is obsolete||

--- Comment #39 from Nicholas van Oudtshoorn  ---
Created attachment 68836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68836=edit
Allow restricting SCO to IP or IP range

Ah no! One more bit of noise - a very minor copy-and-paste mistake... in the
copyright statement in the new unit test Auth.t!
Hopefully this is now it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #68834|0   |1
is obsolete||

--- Comment #38 from Nicholas van Oudtshoorn  ---
Created attachment 68835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68835=edit
Allow restricting SCO to IP or IP range

Sorry for the noise - running on two git instances, and forgot to include the
required updates to Auth.pm that testing revealed. Now fails secure if invalid
IP ranges are set...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #47 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #45)
> 
> Signed-off-by: Kyle M Hall 

Thanks, Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #37 from Nicholas van Oudtshoorn  ---
Added unit tests for in_ipset

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2017-10-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #56066|0   |1
is obsolete||

--- Comment #36 from Nicholas van Oudtshoorn  ---
Created attachment 68834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68834=edit
Bug 14407 - Allow restricting SCO to IP or IP range

Added some unit tests to this. Not added in the db_dependent directory, given
that the new function (in_ipset) doesn't actually touch the database at all.
It's meant to be a function that can be reused in the future for other ip based
limits in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

85 matches

Mail list logo