[Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #9 from Mason James  ---
(In reply to Marcel de Rooy from comment #7)
> About the "use threads;" line:
> 
> Do we really need it ?

hi Marcel, i think it's not needed :)
i must have forgotten to remove the line before sending, i'll fix that now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||18974


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974
[Bug 18974] Cataloging MARC21 record and adding item selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

M. Tompsett  changed:

   What|Removed |Added

 Depends on||19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19184] Purchase workflow selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184

M. Tompsett  changed:

   What|Removed |Added

 Depends on||19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||19185


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185
[Bug 19185] Web installer and onboarding tool selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189

M. Tompsett  changed:

   What|Removed |Added

 Depends on||19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

M. Tompsett  changed:

   What|Removed |Added

 Depends on||19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||19189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189
[Bug 19189] Reserving and renewing item in OPAC selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||19183


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183
[Bug 19183] Acquisition module setup selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||19184


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184
[Bug 19184] Purchase workflow selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19183] Acquisition module setup selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183

M. Tompsett  changed:

   What|Removed |Added

 Depends on||19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||19181


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181
[Bug 19181] Intranet and OPAC authentication selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 Depends on||19243

--- Comment #10 from M. Tompsett  ---
This and the other selenium tests all are blocked by bug 19243.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Blocks||19182


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182
[Bug 19182] Item search in intranet and OPAC selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

M. Tompsett  changed:

   What|Removed |Added

 Depends on||19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64804|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 68887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68887=edit
Bug 18894 - Add ability to limit the number of messages sent by
misc/cronjobs/process_message_queue.pl at a time

Having the ability to limit the number of messages sent by
process_message_queue.pl on a single run would be very useful for controlling
home many messages are sent at a given time. This can help prevent too many
messages being sent out at once and getting flagged as a spammer.

Test Plan:
1) Apply this patch
2) Generate some number of messages in the message queue
3) Run process_message_queue.pl with the new --limit option,
   set limit to a number smaller than the number of pending messages
4) After the script has run, check the database and note that only
   a number of pending messages were sent, and that the remaining amount
   of pending messages is the original amount less the number specified
   as the limit

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

--- Comment #3 from M. Tompsett  ---
Comment on attachment 64804
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64804
Bug 18894 - Add ability to limit the number of messages sent by
misc/cronjobs/process_message_queue.pl at a time

Review of attachment 64804:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18894=64804)
-

::: C4/Letters.pm
@@ +1272,5 @@
> +SELECT mq.message_id, mq.borrowernumber, mq.subject, mq.content, 
> mq.message_transport_type, mq.status, mq.time_queued, mq.from_address, 
> mq.to_address, mq.content_type, b.branchcode, mq.letter_code
> +FROM message_queue mq
> +LEFT JOIN borrowers b ON b.borrowernumber = mq.borrowernumber
> +WHERE status = ?
> +};

I like the clean up, but technically not necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

--- Comment #9 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #8)
> Patches still apply. Mark, could you add a test plan please and say
> something about the requirements in order to test this?

This is about the koha-create --use-db method, if doing a manual install from
source. But I figure you can get the same result with a simple package install
and a couple tweaks.

As you can see in comment #1, I created a DB, but did not grant permissions for
'%'. This means when the web installer attempts to SHOW GRANTS it is going to
fail, because hostname on a regular install is the KohaApp VM, not the KohaDB
VM.

The 'Do an install' is a simple package installation.
'Hack the kohaconf...' is something like:
$ sudo vi /etc/koha/sites/library/koha-conf.xml
and making the appropriate adjustments to match the information used in the
GRANT ALL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal Details opac-memberentry.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

--- Comment #1 from Ed Veal  ---
The ability to translate the notices is a great new feature. However, to have
it work well staff is placed in a position of asking patrons their preferred
language. If that could be added to the patron record on the
opac-memberentry.pl page then the patrons would be empowered to manage that
themselves. 

We have patrons use the online form to register for a card so that would be the
best point of contact for that choice. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal Details opac-memberentry.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

Jessie Zairo  changed:

   What|Removed |Added

 CC||ev...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal Details opac-memberentry.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com
   ||,
   ||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19561] New: Add "preferred language" to OPAC Personal Details opac-memberentry.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

Bug ID: 19561
   Summary: Add "preferred language" to OPAC Personal Details
opac-memberentry.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 17762 adds the ability to translate notices. The new system preference for
translatenotices allows staff members to set a preferred language in the user
account, which controls which template will be used when generating notices.

It would be great to allow patrons to select their preferred language in the
OPAC Personal Details page on opac-memberentry.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #172 from Tomás Cohen Arazi  ---
Created attachment 68886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68886=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68878|0   |1
is obsolete||

--- Comment #171 from Tomás Cohen Arazi  ---
Created attachment 68885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68885=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an
exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warning.

TODO: Should add a noticeable warning on the UI, or a tooltip on the button.
TODO: add a couple tests for the exception

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

3/ I know it doesn't look right, but am not sure how to display. This is the
usual empty
datatable display we have everywhere in Koha.

2/ We could fix it with a proper IDE, I use Komodo and refactoring code is
pretty straigh-forward.
Worth a separate bug report.

1/ That TODO is misleading. It refers to their own migration from a different
design. I checked this
code and cannot find occurences of ->status with that annotation. I think this
relates to backends code.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] New: Special characters & and # in branchcode - unable to delete branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Bug ID: 19560
   Summary: Special characters & and # in branchcode - unable to
delete branch
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: j...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Special Characters in Branchcode cause the user to be unable to delete the
branch.

Replicate:
1. Administration->Libraries and Groups
2. Click on New Library button
3. Create a new branch use the & or # character in the branchcode
4. Branch is created.
5. Click on Delete (under Actions) for that branch
6. Verify you wish to delete the branch.
7. Error message appears 
An error occurred when deleting this library. Check the logs. 

Can this field be validated when data is entered?  We should not allow users to
create branchcodes that use special characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

Nick Clemens  changed:

   What|Removed |Added

 CC||juan.sie...@xercode.es

--- Comment #10 from Nick Clemens  ---
*** Bug 16746 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 19415 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

--- Comment #13 from Nick Clemens  ---
(In reply to Julian Maurice from comment #11)
> Also, this is weird that search_result_compat returns different result
> depending on the search engine. Shouldn't we fix one of
> Koha::SearchEngine::*::Search::search_result_compat ?

Agreed, it is odd, see the comment in the pod:
315 an arrayref of MARC::Records (note that this is different from the
316 L version which will return plain XML, but too bad.)

I think beyond the scope here, let's get this fixed for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Nick Clemens  changed:

   What|Removed |Added

 Depends on||19559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559
[Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens
if data is quoted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

--- Comment #12 from Nick Clemens  ---
Created attachment 68884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68884=edit
Bug 18131: Followup - Use data if biblionumber_tag < 10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18131


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131
[Bug 18131] Matching staged records when using elastic search fails
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19123] Remove/fix reference to latest release

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Jonathan Druart  
---
commit 6fb40783995ef1171ef784f79e6d077b0ae60aec
  Bug 19123: Remove reference to the last release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #377 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #36 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68880|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 68883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68883=edit
Bug 19539: (follow-up) Fix column index shift in cirulation rules

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] Add routes to list libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #29 from Jonathan Druart  
---
Please check POD coverage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #24 from Jonathan Druart  
---
Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559
[Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens
if data is quoted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||julian.maur...@biblibre.com
   ||, tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||18374


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374
[Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #1 from Nick Clemens  ---
Created attachment 68881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68881=edit
Bug 19559 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #2 from Nick Clemens  ---
Created attachment 68882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68882=edit
Bug 19559 - Add '-' to list of characters we don't split search terms on

Test plan assumes
QueryAutoTruncate = automatically
SearchEngine = Elasticsearch

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number:"4"' (or a vlid biblionumber)
7 - should get expected result

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] New: Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Bug ID: 19559
   Summary: Elasticsearch QueryAutoTruncate truncate field names
with hyphens if data is quoted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

With QueryAutoTruncate enabled a search for:
Local-number:"4"
is truncated as:
Local-* number:"4"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

--- Comment #6 from Kyle M Hall  ---
Created attachment 68880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68880=edit
Bug 19539: (follow-up) Fix column index shift in cirulation rules

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68846|0   |1
is obsolete||
  Attachment #68847|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 68879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68879=edit
Bug 19539: Fix column index shift in cirulation rules

This patch fixes an index shift introduced by bug 18857 when it introduced
a new column.

To test:
- On the Circulation and fine rules page
- Empty the value of 'Current on-site checkouts allowed' and save
- Notice 'Unlimited' shows on the saved rule.
- Click edit
=> FAIL: the 'Unlimited' string displays instead of the empty string on the
editing row.
- Apply this patch
- Re-open the circ rules page
- Click edit
=> SUCCESS: An empty string fills the 'Unlimited' fields
- Sign off :-D

Signed-off-by: David Bourgault 

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #4)
> Yes, we are using the MySQL feature, I think for all of our timestamps
> actually. That's why Magnus suggested to put one on the metadata table and
> use that.

I don't oppose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

--- Comment #4 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #2)
> Signed-off-by: Mark Tompsett 

Thanks Mark

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #4 from Katrin Fischer  ---
Yes, we are using the MySQL feature, I think for all of our timestamps
actually. That's why Magnus suggested to put one on the metadata table and use
that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #3 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #2)
> Hm, when we add the timestamp to the new table, wouldn't looking at that not
> be enough? I think that would be easiest. 
> I think I saw on another bug that changes to items weren't reflected either.
>  Is this already fixed or could be fixed in one go with this here?

biblio and biblioitems are both the same table, just splitted. When a
bibliographic record is modified, the timestamp should be changed (no matter in
which of the tables is). The problem might be that we are relying on the DB
feature of updating the timestamp when the row is changed. Which doesn't happen
when no mapping triggers a row change.

Regarding items, the items timestamps should be checked if include_items is
set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hm, when we add the timestamp to the new table, wouldn't looking at that not be
enough? I think that would be easiest. 
I think I saw on another bug that changes to items weren't reflected either.
 Is this already fixed or could be fixed in one go with this here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #23 from Katrin Fischer  ---
Hm there could be. Owen, could you try from koha-shell with 
cd misc/translator
perl translate update fr-FR
?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19488] 5 digit, "Borrower Number" from details page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Why 5 digit?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #20 from Jon Knight  ---
I noticed that this doesn't apply cleanly to the latest master HEAD on my
kohadevbox.  I could help rebase if that would be useful to nudge this bug
along?  Unless of course Jiri is working on an updated version?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19284] Correct version numbering by adding missing zeros

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19284

--- Comment #2 from Katrin Fischer  ---
+1 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19123] Remove/fix reference to latest release

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123

--- Comment #3 from Katrin Fischer  ---
I fixed it manually every time, it never generated right for me.

I don't think it adds valuable information. The easiest fix would be to remove
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

--- Comment #16 from Katrin Fischer  ---
Glad to see this one moving, thx for taking the time to test!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode hides email and breaks workflow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #6 from Katrin Fischer  ---
Sorry for all the typos in my previous comment. The system preference
*unwanted*  takes the database column names from the borrowers table. When you
enter 'branchcode' it will hide more fields, especially the primary email
(email) field, which doesn't make sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #170 from Magnus Enger  ---
Trying to summarize the status of this bug now. 

*** QA script

** POD coverage

Some FAILS are "POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666". It sounds like these can be ignored. 

** Atomicupdate

 FAIL   installer/data/mysql/atomicupdate/ill_tables.sql
   FAIL   git manipulation
The file has been added and deleted in the same patchset

Alex provided ill_tables.sql. Tomas rewrote it as bug_7317_ill.perl. Not sure
there is anything to fix here? 

** tt_valid

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   FAIL   tt_valid
lines 665
   FAIL   valid_template
: not found

TT is used to set some HTML attributes. Not sure if this can be fixed. Tomas? 

*** (In reply to Jonathan Druart from comment #164)

> 1/ 
> +TODO:
> +
> +- Anything invoking the ->status method; annotated with:
> +  + # Old use of ->status !
> 
> What do it mean?

OK, according to Tomas.

> 2/ I will not make you rewrite everything, but it would have been better to
> stay consistent and not mix snake_case and camelCase for method names.

OK

> First steps with the GUI:
> 3/ This is what I see when I enable the module:
> https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org
> Looks wrong.

Not sure if this can be fixed?

> 4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got:
> Loading failed for the 

[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode hides email and breaks workflow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #5 from Katrin Fischer  ---
The primary email field in the form where you enter the patron data.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Magnus Enger  changed:

   What|Removed |Added

  Attachment #68858|0   |1
is obsolete||

--- Comment #168 from Magnus Enger  ---
Created attachment 68877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68877=edit
Bug 7317: QA followup

This fixes some of the issues reported by the QA script, but not all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Magnus Enger  changed:

   What|Removed |Added

  Attachment #68874|0   |1
is obsolete||

--- Comment #169 from Magnus Enger  ---
Created attachment 68878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68878=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an
exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warning.

TODO: Should add a noticeable warning on the UI, or a tooltip on the button.
TODO: add a couple tests for the exception

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

3/ I know it doesn't look right, but am not sure how to display. This is the
usual empty
datatable display we have everywhere in Koha.

2/ We could fix it with a proper IDE, I use Komodo and refactoring code is
pretty straigh-forward.
Worth a separate bug report.

1/ That TODO is misleading. It refers to their own migration from a different
design. I checked this
code and cannot find occurences of ->status with that annotation. I think this
relates to backends code.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/