[Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 --- Comment #12 from Josef Moravec --- Created attachment 70105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70105&action=edit Bug 18458: Merging authority record incorrectly orders subfields While doing a merge, if a subfield(s) precedes the controlled subfields (like $i before $a in 7XX, which comes before $a -- rare but will become more and more usual) after merging will be moved to the end. This is not right. The patch (with AuthorityMergeMode == loose) make merge consider the subfields order: all subfields which originally were found before the first controlled subfield (e.g. $i before $a in 7XX / MARC 21) will remain in the front, the rest of not controlled subfields that should remain in the field will come after the subfields copied from authority rec. As a bonus, $9 will be placed at the end. To test: 0) Have AuthorityMergeMode == loose; 1) Have some field in bibliorecord, controlled by an authority, with extra subfield(s) (i.e. not present in authority rec.) placed at the beginning of the field; 2) Open (not necessarily edit) and save the connected authority; 3) See that the extra subfieds were moved to the end of the field (and $9 is in the front); 4) Apply the patch; 5) Reorder subfields in biblio field; 6) Open (not necessarily edit) and save the connected authority; 7) See that the order has been conserved, additionally $9 the last subfield in the field. Signed-off-by: Marcel de Rooy Amended: Moved field creation to its original place. Changed $9 handling. Simplified the following add_subfields for loop. Edited comments. Restored the append_fields_ordered call (see comment6). With this patch, the Merge.t test now passes. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Josef Moravec changed: What|Removed |Added Attachment #69637|0 |1 is obsolete|| Attachment #69638|0 |1 is obsolete|| --- Comment #11 from Josef Moravec --- Created attachment 70104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70104&action=edit Bug 18458: Add a subtest in Merge.t This test illustrates the problem we have if you run it without the second patch. And it serves to demonstrate that we resolved the situation if you run it after the second patch. Test plan: [1] Without the second patch: The last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | --- Comment #13 from Josef Moravec --- Looks good -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Marcel de Rooy changed: What|Removed |Added Attachment #69846|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 70106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70106&action=edit Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy Following the pattern introduced by bug 19300, we are going to move the OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy Test plan: Make sure the onshelfholds policy is correct when placing a hold Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Marcel de Rooy changed: What|Removed |Added Attachment #69847|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 70107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70107&action=edit Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed At this point the subroutine is not used anymore Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 --- Comment #14 from Marcel de Rooy --- Created attachment 70108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70108&action=edit Bug 19301: (QA follow-up) Add POD, use statements and correct typo Add POD for new sub in Koha/IssuingRules.pm. Adding use Koha::IssuingRules to opac-detail and opac-MARCdetail. Adding use Koha::Items to opac-detail and opac-MARCdetail. Correct typo $items => $item in opac-MARCdetail.pl. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 --- Comment #15 from Marcel de Rooy --- Created attachment 70109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70109&action=edit Bug 19301: (QA follow-up) Add a few simple tests We removed tests from Reserves.t, but would be nice to test the new sub in IssuingRules.t too. Adding a subtest there. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag not existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag not existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813 Marcel de Rooy changed: What|Removed |Added Attachment #69830|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 70110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70110&action=edit Bug 19813 - MarcItemFieldsToOrder cannot handle a tag not existing MarcItemFieldsToOrder defines how Koha looks at tags in order records to generate item data. Let's look at a simplified case: homebranch: 955$a holdingbranch: 956$a So, here we are looking at 955 for the home branch, and 956 for the holding branch. So, it should make sense that Koha requires that these fields exist in equal number in the record. That is, for each 955, there should be a corresponding 956. Let's look at a different case: homebranch: 946$a|975$a holdingbranch: 946$a|975$a In this case, we are using the fallback behavior. VendorA stores the branch data in 946, and VendorB stores it in 975. This seems like it would work, but it won't! That's because Koha is expecting there to be the same number of 946's as there are 975's! In reality, the VendorA records will have a number of 946's, and *zero* 975's. The inverse will be true for VendorB. Koha should be able to skip those tags that simply don't exist in the record. Test Plan: 1) Set MarcItemFieldsToOrder to something like: homebranch: 946$a|975$a holdingbranch: 946$a|975$a budget_code: 946$f|975$f itype: 946$y|975$y notforloan: 946$l|975$l ccode: 946$t|975$c quantity: 946$q|975$q price: 946$p|975$p itemcallnumber: 946$n|975$n loc: 946$c|975$t 2) Create a record using only the 975 tag for item building data 3) Import the record into Koha 4) Create a basket 5) Attempt to add the record to the basket 6) Note the unequal fields error 7) Apply this patch 8) Reload the page 9) No error! Signed-off-by: Kyle M Hall Signed-off-by: Marci Chen Signed-off-by: Marcel de Rooy Amended: Fix typo occurrance and theses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag not existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 --- Comment #7 from Marcel de Rooy --- QA: Resuming here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Marcel de Rooy changed: What|Removed |Added QA Contact|alex.arn...@biblibre.com|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494 Katrin Fischer changed: What|Removed |Added Attachment #69738|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 70111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70111&action=edit Bug 19494: Add reservedate to Holds awaiting pickup Add reservedate to report. Change label "Available since" to "Waiting since". Note: The table (already) crosses the boundaries of its container. Also the vertical spacing for the first column (already) is not the same as the others. (Adding the second date only makes it more visible.) These minor design issues should be solved on another report. Test plan: [1] Go to Circulation, Holds awaiting pickup [2] Note the additional column for reservedate. Signed-off-by: Marcel de Rooy Signed-off-by: Simon Pouchol Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494 Katrin Fischer changed: What|Removed |Added Attachment #70096|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 70112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70112&action=edit Bug 19494: (QA follow-up) Rename column and apply title-string As requested by Katrin, the column should not refer to Reserve but Hold. Sorting should be the same as Waiting since-column. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 --- Comment #9 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #6) > Is the if() else() statement still usefull? Why not just one call to > GetBasketAsCSV? Yes. Adding a follow-up for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200
--- Comment #8 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #4)
> (In reply to Marcel de Rooy from comment #3)
> > This looks like a change in behavior. When the cgi param is default, no
> > profile id was passed.
> > I guess what you wanted to do was just if( $param && $param eq ... ) ?
>
> Hi Marcel,
>
> there is no change in behaviour in my patch. It looks like there's
> originally a bug here, because the original code says "if
> $query->param('csv_profile') eq 'default'", but the word 'default' is never
> passed through that param, based on acqui/basket.tt. this means that when
> the Default option was selected, the $query->param('csv_profile') is not
> actually set to 'default' so an uninitialised value is sent to the
> GetBasketAsCSV method and the 'if' condition is never true. (I hope that
> makes sense. If you put a warn inside the if statement under where
> $query->param('csv_profile') eq default, you'll see that it never enters
> here and never prints the warn.)
>
> my patch checks if the $query->param('csv_profile') has been defined. if it
> has, then it uses one of the library-made csv profiles. if it hasn't been
> defined then it must be using the default profile and no ID is passed, as
> intended, with no warns.
>
> setting back to needs signoff as I believe this is still a valid patch.
You are right that the compare with 'default' makes no sense. It may have been
a leftover from the past.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 --- Comment #11 from Marcel de Rooy --- Created attachment 70114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70114&action=edit Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV If no profile_id is passed, GetBasketAsCSV will fallback to default itself. No need to make the distinction in basket.pl. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19200] Warns when exporting a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Marcel de Rooy changed: What|Removed |Added Attachment #69959|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 70113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70113&action=edit Bug 19200: Preventing warns when exporting a basket To test: 1) Go to Tools -> CSV profiles -> New CSV Profile 2) Create a new CSV profile with any name of SQL fields. Ensure profile type: SQL and usage: basket export in acquisition 3) Go to Acquisitions -> Find or create a vendor -> Use or create a basket 4) Click the dropdown menu next to the 'Export as CSV' button. There should be a 'Default' option and your new CSV profile (at least) 5) Click the 'Default' option. Notice warns 6) Click the 'Export as CSV' button. Notice warns 7) Click your new CSV profile option. Notice warns 8) Apply patch and refresh page 9) Repeat steps 5-7, confirm that warns do not show 10) Confirm export still works as expected Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #22 from Nick Clemens --- Patch in comment 12 has been pushed to stable for 17.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||n...@bywatersolutions.com --- Comment #33 from Nick Clemens --- All but last patch (translation) have been pushed to stable for 17.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19843] reviews.datereviewed is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Pushed to Master|Pushed to Stable --- Comment #5 from Nick Clemens --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Marcel de Rooy changed: What|Removed |Added Attachment #69829|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 70115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70115&action=edit Bug 19812 - Holds count in "Already received" table has confusing and unexpected values In acqui/parcel.pl both the "Pending orders" and "Already received" tables show how many holds there are for the given record. However, the count of holds in the "Pending orders" table confuses librarians because it only lists holds for the particular items in the orderline. Due to that, the holds column may show 0 holds even if there are a dozen record level holds for that bib! This is not what librarians seem to expect, instead it seems that the same total holds in the "Pending orders" table would be preferred. Test Plan: 1) Find an invoice with an item in the "Already received" table 2) Add one or more record level holds to the record 3) Note the holds column does not count those holds 4) Apply this patch 5) Note the holds column now shows total holds and holds for just those ordered items Signed-off-by: Kyle M Hall Signed-off-by: Nancy Keener Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- (In reply to Jon Knight from comment #2) > 3) sudo chmod a+rx /etc/koha/sites/kohadev/koha-conf.xml chmod 640 might be better ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Marcel de Rooy changed: What|Removed |Added Attachment #69571|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 70116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70116&action=edit Bug 19760: Die if koha-conf is not accessible We got a lot of support questions because scripts are executed without the correct environment/user. We could die and provide more useful information Tested on my kohadevbox VM by: 1) sudo chmod a-rx /etc/koha/sites/kohadev/koha-conf.xml 2) run help.pl from the command line to produce the desired die message 3) sudo chmod a+rx /etc/koha/sites/kohadev/koha-conf.xml 4) rerun help.pl successfully Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Marcel de Rooy changed: What|Removed |Added Attachment #70014|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 70117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70117&action=edit Bug 19760: Change wording Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled up on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Marcel de Rooy changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled up on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Marcel de Rooy changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled up on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Looks good to me. Moving to Stable status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- I like the idea of such a performance boost. Could you move the anonymous sub out of GetBudgetHierarchy? Can it be tested separately? Or do you think that the current code in Budgets.t sufficiently covers your changes (including processing a budget tree) ? Changing status to reflect need for some adjustments/feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17672] Items table should have a damaged_on column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 --- Comment #12 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > require C4::Reserves; > Did I really see that ? It is removed in the next patch. The goal was to prove that the same tests were passing with the current code and the new code :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19623] Move template JavaScript to the footer: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 --- Comment #4 from Owen Leonard --- Created attachment 70118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70118&action=edit Bug 19623: (Follow-up) Correct footer include in pop-up windows This patch corrects the footer include in two templates for Z39.50 pop-up windows. popup-bottom.inc shouldn't be used because it doesn't have the JavaScript embed code in it. To test, perform a Z39.50 search from both the MARC bibliographic editor and the MARC authority editor. In both cases the Z39.50 popup window should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19623] Move template JavaScript to the footer: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19872] New: Move template JavaScript to the footer: UNIMARC editor plugins, part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 Bug ID: 19872 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 17858 Most UNIMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. This patch modifies more and more UNIMARC editor plugins. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What|Removed |Added Depends on||19872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Jonathan Druart changed: What|Removed |Added Depends on||19401 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Patch doesn't apply --- Comment #5 from Jonathan Druart --- Please rebase on top of bug 19401. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 [Bug 19401] No confirm message when deleting an invoice from invoice detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19401] No confirm message when deleting an invoice from invoice detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Jonathan Druart changed: What|Removed |Added Blocks||19753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 [Bug 19753] Move template JavaScript to the footer: Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70064|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 70120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70120&action=edit Bug 19826: Unit test files Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70063|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 70119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70119&action=edit Bug 19826: Add K::Acq::Budget(s) and K::Acq::Fund(s) This patch introduces Koha::Object(s)-derived classes for budgets and funds (aqbudgetperiods and aqbudgets respectively). C4::Budgets already uses DBIC calls on those tables so transition should be easy on top of this. To test: - Check the referenced schema files are the right ones. - QA scripts shoudl be happy. - Sign off :-D Note: the POD coverage report throws a false negative result on singular classes which is trivially wrong. Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins , part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins , part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 --- Comment #1 from Owen Leonard --- Created attachment 70121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70121&action=edit Bug 19872: Move template JavaScript to the footer: UNIMARC editor plugins, part 4 This patch updates more and more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_124a.tt - unimarc_field_124b.tt - unimarc_field_124c.tt - unimarc_field_124d.tt - unimarc_field_124e.tt - unimarc_field_124f.tt - unimarc_field_124g.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] New: Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Bug ID: 19873 Summary: Make it possible to search on value 0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org The current code considers a value of 0 in a search query as an empty string, that is, it won't search on it. If a library wants to search for records that specifically have the value "0" in a given field, it will not be possible. This patch aims to correct this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > (In reply to Julian Maurice from comment #18) > > (In reply to Jonathan Druart from comment #15) > > > Hum, so Koha::Acquisition::Vendor::Basket::Order? :) > > > > Please, no :) > > Not everything can be represented in a tree. > > Where do you place basket groups in this hierarchy ? It could be > > Koha::Acq::Vendor::Basketgroup::Basket, but not every basket belongs to a > > basketgroup. > > Also, there is a 1-n relationship between biblio and aqorders, but > > Koha::Biblio::Orders does not make much sense IMHO. > > > > If there was a vote, I'd vote for everything on one level > > Not everything, but I would prefer Koha::Acq::Budget[s] and > Koha::Acq::fund[s] too. > Setting to In Discussion to get more opinions. I don't really care, really. I've moved Fund(s).pm one level up, and marked PQA so Matthias can code the funds endpoint on top of this. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 --- Comment #25 from Katrin Fischer --- I am ok with this approach - I think our relations could get confusing fast. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19874] New: Move template JavaScript to the footer: UNIMARC editor plugins, part 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Bug ID: 19874 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 17858 Most UNIMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. This patch modifies yet more UNIMARC editor plugins. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- If there are no holds, should not we display "0" instead of "0 / 0"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What|Removed |Added Depends on||19874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 [Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins, part 5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 David Bourgault changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #6 from David Bourgault --- I don't think I can move the recursive sub out of GetBudgetHierarchy, since it calls variables local to that function. If it were moved out it would need to either rebuild them everytime, which voids the perf boost, or receive them as parameters, which would make the code less readable, and requires the dev to know the exact SQL query result to pass. In this case I strongly believe an anonymous inner function is the best way to go. As for tests, the current test to budgets.t should be sufficient as this does not (should not!) change behavior. It is supposed to replace the inner workings of the function with no impact on input or output. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 --- Comment #1 from Alex Arnaud --- Created attachment 70122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70122&action=edit Bug 19873 - Ability to search on 0 value Test plan: - create a st-numeric index in zebra conf related to a numeric field i.e: yourindex 1=yourindex 4=109 - fill a field with 0 in a biblio, - reindex your biblios, - search yourindex=0, - should not work, - apply this patch, - test again, - should work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff CC||alex.arn...@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70081|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 70123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70123&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70082|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 70124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70124&action=edit Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Alex Arnaud changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19875] New: When & is in the title of a search result, subscribing via rss can be broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Bug ID: 19875 Summary: When & is in the title of a search result, subscribing via rss can be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: christophe.croulleb...@biblibre.com QA Contact: testo...@bugs.koha-community.org This issue is not in all cases (depend on many factors). It is due to the xml syntax where the use of "&" is forbidden and must be "&" Koha do the job in this line : [% SEARCH_RESULT.title |html %]... With the use of "|html" But not in this line : Place Hold on [% SEARCH_RESULT.title %].. The patch is very light just adds "|html" in the line above. # Test Plan : 1° in opac do a search where you can find "&" in the title 2° in the result page click on the rss button on the right of "Your search returned n results." (Subscribe to this search) 3° if your subscribe is ok you can not perform the test :o( 4° if your subscribe is nok you can apply the patch 5° test the same work flow with the patch the subscribe must be ok. Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 --- Comment #2 from Fridolin SOMERS --- + original_operand => ($operands[$i] ne '') ? $operands[$i] : '', I think it could be more pretty : + original_operand => $operands[$i] // '', -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19873] Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Alex Arnaud changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #19 from Charles Farmer --- Created attachment 70125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70125&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11291] Change the behavior of any index in DOM indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11291 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Fridolin SOMERS --- I will work on Bug 8962 so I set this one as duplicate *** This bug has been marked as a duplicate of bug 8962 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than " any"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #49 from Fridolin SOMERS --- *** Bug 11291 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #20 from Charles Farmer --- (In reply to Katrin Fischer from comment #14) > As this now not only works for Serials, but for datatables in general, I > think maybe it would better fit on the 'staff client' tab? Hope I didn't > misunderstand the change. The preference was recently moved from serials.pref to searching.pref to account, as you said, for the more 'global' impact the change has on datatables. I have no qualms moving it though, if admin/preferences/searching.pref is not where you feel it should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than " any"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Assignee|gmcha...@gmail.com |fridolin.som...@biblibre.co ||m CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than " any"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Attachment #25673|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than " any"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Attachment #25674|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than " any"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Attachment #25675|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than " any"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #50 from Fridolin SOMERS --- I found this exact bug and found an easy way to propose a solution. I set GRS1 patches has invalid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins , part 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins , part 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 --- Comment #1 from Owen Leonard --- Created attachment 70126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70126&action=edit Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 This patch updates yet more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_125a.tt - unimarc_field_125b.tt - unimarc_field_126a.tt - unimarc_field_126b.tt - unimarc_field_127.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19857] Optionally hide SMS provider field in patron modification screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857 Jonathan Druart changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19857] Optionally hide SMS provider field in patron modification screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Summary|Create a new index for OPAC |Restore Any index behavior |simple search, more |and add Anywhere index |specific than "any" | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #51 from Fridolin SOMERS --- > > The "Any" index/register should contains all the data contained in all the > other indexes/registers (e.g. Title, Author, Subject, etc). > > The "Anywhere" index/register should contain the entire record including > fields/subfields that aren't indexed anywhere else. > This is what I want to do so I changed the bug description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19876] New: Koha::Account->pay() does not exit specific fine loop when balance is used up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Bug ID: 19876 Summary: Koha::Account->pay() does not exit specific fine loop when balance is used up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If a patron selects specific fines to pay and enters an amount less than all of those fines the loop will continue through all fines. This can be problematic for lost fines which are not paid or not paid fully as they will be marked 'Paid for...' and returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11317] Add a way to access files from the intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com --- Comment #116 from Josef Moravec --- Sorry, I see it is long process to get this to Koha, but I have one more concern: If there are files with the same name in multiple directories, they have the same hash! Than only one of them is always downloaded, although both (or more) are listed. The path of each file should be presented in the table too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15492] Stand alone self check-in tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA --- Comment #14 from Jonathan Druart --- All works great, few concerns: 1. Code in C4::Auth must be simplify and merged with existing one (you c/p 25 lines) 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we should apply the same behaviour as self-checkout (no?) 3. Description (and name) of the permission self_checkout must be adapted 4. I do not know how SCOMainUserBlock is used, but it may be wrong to display it for SCI (?) 5. "Data corruption detected" => Are we sure we want to display that at the OPAC? 6. If error code is not known, we should display it instead of ignore it (BLOCK error_message) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #52 from Fridolin SOMERS --- Created attachment 70127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70127&action=edit Bug 8962: Restore Any index behavior and add Anywhere index The "Any" index/register should contains all the data contained in all the other indexes/registers (e.g. Title, Author, Subject, etc). The "Anywhere" index/register should contain the entire record including fields/subfields that aren't indexed anywhere else. In GRS1 indexing the Any index was indeed only on fields defined as indexed. This has changed in DOM where all data in MARC is indexed with Any. This generates a lot of results when no index is defined in search. This patch changes the DOM xsl config generation to add Any to each indexed data and add Anywhere to keep a way of searching on all data. Test plan : - Add a data on a field that is not indexed : for example "toto" in 998$z - Add same data as the title of another record - Index the records - Search on toto without index (uses Any) => you get the 2 records - Search on toto with title index => you get the record with "toto" as title - Apply patch - Update DOM xsl config files - Reindex - Search on toto without index (uses Any) => you get the record with "toto" as title - Search on toto with title index => you get the record with "toto" as title - Search on toto with Anywhere index => you get the 2 records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #53 from Fridolin SOMERS --- Once validated, we will patch the DOM XSL config files. Maybe first patch needs some changes, let me know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380
--- Comment #3 from Josef Moravec ---
Comment on attachment 67577
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67577
Bug 19380: Add transfer informations in ILS-DI GetRecords response
Review of attachment 67577:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19380&attachment=67577)
-
::: C4/ILSDI/Services.pm
@@ +239,5 @@
> my $holding_library = Koha::Libraries->find(
> $item->{holdingbranch} );
> $item->{'homebranchname'}= $home_library?
> $home_library->branchname: '';
> $item->{'holdingbranchname'} = $holding_library ?
> $holding_library->branchname : '';
> +
> +my ($transferDate, $transferFrom, $transferTo) =
> GetTransfers($item->{itemnumber});
You should use Koha::Item->get_transfer instead
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70081|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70124|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70123|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70082|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9495] Split NotesBlacklist in to two prefs for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 Katrin Fischer changed: What|Removed |Added Summary|split NotesBlacklist in to |Split NotesBlacklist in to |two prefs for staff and |two prefs for staff and |OPAC|OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70082|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 70128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70128&action=edit Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70128|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard changed: What|Removed |Added Attachment #70081|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 --- Comment #9 from Owen Leonard --- Created attachment 70129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70129&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
