[Koha-bugs] [Bug 19716] Add option to send header line for CSV output with runreport.pl

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Add option to send header   |Add option to send header
   |line for CSV output |line for CSV output with
   ||runreport.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip.

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70181|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 70198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70198&action=edit
Bug 19798: Fix print transfer slip

... and maybe other bugs as well
What happens here is that $itemnumber is no longer set when barcode is
passed.

Test plan:
1. Check in available/not on hold item at a non owning library.
2. Click print slip
3. Item's info must be displayed on the slip

Signed-off-by: Björn Nylén 
Signed-off-by: Björn Nylén 
Signed-off-by: Jon Knight 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip.

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
1) If you leave the preference empty, the default will show. The default
doesn't include cardnumber, I think it might be good to include it on top.

2) When using the preference, the default will still show, so there is no way
to remove fields. Wouldn't it make more sense to use the non-empty pref instead
of the default? For example a lot of libraries don't use the sort fields and
could remove them from the list this way. 

The current behaviour seems especially confusing since the preference is not
empty by default but includes a list of values. Deleting one of them will have
no effect as long as the value is in the list of default.

Failing for 2).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference(' OPACNumbersPreferPhrase') in OPAC

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19892] New: Replace numbersphr variable with Koha.Preference(' OPACNumbersPreferPhrase') in OPAC

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

Bug ID: 19892
   Summary: Replace numbersphr variable with
Koha.Preference('OPACNumbersPreferPhrase') in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

This was just done in intranet with bug 19807 to fix a bug and I think it would
be good to do the same for the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70180|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 70197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70197&action=edit
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase

This patch
- fixes callnum and sn
- Removes unecessary syspref transmission to the template.
  As the template directly reads the syspref

Test plan:
1. Set sysprefs IntranetCatalogSearchPulldown and
   IntranetNumbersPreferPhrase to true
2. Go to staff:/cgi-bin/koha/catalogue/search.pl
3. "search for" → "call number" and write anything that won't match a
   call number in the field
4. Then you should see
   «No results match your search for 'callnum,phr: [...]»
5. Go to the staff homepage
6. Click on "Search the catalog"
7. Do the same search as previouly
8. Then you should see
   «No results match your search for 'callnum,wrdl: [...]»
   This shows that IntranetNumbersPreferPhrase isn't honored
9. Apply this patch
10. Redo the same two searches and see that phr will now be always used.
So IntranetNumbersPreferPhrase is honored

Signed-off-by: Jon Knight 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19891] New: itemtypecat should show categories in refine search ( facets) and item details, not itypes

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19891

Bug ID: 19891
   Summary: itemtypecat should show categories in refine search
(facets) and item details, not itypes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: hu...@brimbank.vic.gov.au
QA Contact: testo...@bugs.koha-community.org

If using itemtypecat, the itemtypes are grouped into categories for Advanced
Search. However, in Refine Search, the item types listed are actual item types
rather than the item type categories. The same seems to be the case in
opac-detail. Either showing the category instead of the itemtype if itemtypecat
is being used, or providing a toggle to allow it, would be more consistent and
allow libraries to use fine-grained itemtypes without having to present them
all to library patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6685] circ rules by groups of items

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #12 from Hugh Rundle  ---
Great idea, and would resolve a problem for us too. We have different itemtypes
for games for adults vs games for children because we fine adults but not
children, but we want to maintain a limit on the number of games you can borrow
on a single card, regardless of item type. Definitely should use itemtypecat.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19890] New: authorised value branches is not visible from dropdown in Admin

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890

Bug ID: 19890
   Summary: authorised value branches is not visible from dropdown
in Admin
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hu...@brimbank.vic.gov.au
QA Contact: testo...@bugs.koha-community.org

branches is an authorised value category in the database, but is not visible in
the 'Show category' dropdown list in Administration - Authorised Values.

This is confusing if a librarian tries to create an authorised value category
called 'branches' because it will fail, since it already exists. It should
appear in the authorised value category dropdown, though perhaps should not be
editable from that screen, since branches should be created under
Administration - Libraries and groups.

Problem in 16.11, presumably in later versions too but I can't test that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #99 from Hugh Rundle  ---
Is anyone still working on this? Being able to provide extended hold dates
(e.g. for items set aside for our housebound patrons) would be very useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9834] Should reverting a waiting hold keep the item number?

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #5 from Hugh Rundle  ---
Definitely needed for all the reasons mentioned: if holds are 'next available'
(which is nearly always the case for us) then turning it into an item-level
hold on allocation isn't ideal. Also, usually if you're reverting the waiting
status it's because the item has gone missing, so the only way to fix this is
actually to cancel the hold and then place a new hold and push the borrower to
the top of the list again, which is ...suboptimal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #56 from Katrin Fischer  ---
As this would be a change of behavior now after a long time of dom indexing...
should we make it possible to switch the one that is used in the GUI when
selecting 'keyword'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #55 from Katrin Fischer  ---
Hi Magnus, I think this is out of scope if this aims to restore the former
behaviour - you'd have to remove the place of publication from indexes.
Maybe a next step could be a configurable Any index?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

Katrin Fischer  changed:

   What|Removed |Added

Summary|"Overdue Notices" email |"Overdue Notices" email
   |sent to |sent to
   |KohaAdminEmailAddress is|KohaAdminEmailAddress
   |useless |should be optional

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress is useless

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
As there is no nice way to print the print notices at the moment we are still
relying on the email - it's not useless to us :) Making it optional makes a lot
of sense tho - if you have automated your printing somehow, you will no longer
need the emails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #55 from Charles Farmer  ---
Some rebasing on the new master was necessary.

Submitted a third patch to follow-up on Marcel's observation.

Had to obsolete the [SIGNED-OFF] patches, but didn't have the stomach to remove
the sign off from the commit messages themselves. Patch back at needs sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70193|0   |1
is obsolete||

--- Comment #54 from Charles Farmer  ---
Created attachment 70196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70196&action=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70192|0   |1
is obsolete||

--- Comment #53 from Charles Farmer  ---
Created attachment 70195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70195&action=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #62938|0   |1
is obsolete||
  Attachment #62939|0   |1
is obsolete||
  Attachment #70191|0   |1
is obsolete||

--- Comment #52 from Charles Farmer  ---
Created attachment 70194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70194&action=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

modified:   C4/Breeding.pm
modified:   Koha/Schema/Result/Z3950server.pm
modified:   admin/z3950servers.pl
new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
modified:   installer/data/mysql/kohastructure.sql
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

New sign-off, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70190|0   |1
is obsolete||

--- Comment #51 from Charles Farmer  ---
Created attachment 70193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70193&action=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #50 from Charles Farmer  ---
Created attachment 70192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70192&action=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #49 from Charles Farmer  ---
Created attachment 70191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70191&action=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

modified:   C4/Breeding.pm
modified:   Koha/Schema/Result/Z3950server.pm
modified:   admin/z3950servers.pl
new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
modified:   installer/data/mysql/kohastructure.sql
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

New sign-off, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #48 from Charles Farmer  ---
Created attachment 70190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70190&action=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #38 from Charles Farmer  ---
Is there any consensus on how to move this bug forward?

One of the implementation touches on SIP, the other does not. Are we sure
they're really duplicates?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] localholdspriority needs exclusions

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Christopher Brannon  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] New: localholdspriority needs exclusions

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Bug ID: 19889
   Summary: localholdspriority needs exclusions
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

localholdspriority is great, unless you have a unique or rare collection that
is popular.  If you have such a collection, and ongoing holds are being placed
on it to be picked up at several locations, only the patrons at that library
will ever get their hands on it unless a patron is smart enough and willing to
pickup the item at that location.

I would propose an exclusion preference, that would exclude listed patron
categories, item types, formats, or specific items.  Any other item criteria or
factors that I missed could be added to this list.

Currently we have patrons at other libraries that will never get the items they
have requested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #12 from David Gustafsson  ---
Just to clarify: with "this patch is a requirement for us" I'm of course not
implying it's a requirement it gets committed, just that if it doesn't we will
maintain this patch against koha-master indefinitely (or at least as long as we
are using Koha) since without it indexing takes too long :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19416] Make it possible to hide "Show checkouts to guarantor" on patron's detail page in staff

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19416

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #17 from Nick Clemens  ---
This is an attempt to repair the calculations here by providing a system
preference. I only add a 'nearest_cent' option, but I tried to leave things
open for further options to be added later.

Please test thouroughly and let me know any feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64061|0   |1
is obsolete||
  Attachment #64065|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 70187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70187&action=edit
Bug 18736 - Add OrerPriceRounding syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #16 from Nick Clemens  ---
Created attachment 70189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70189&action=edit
Bug 18736 - Unit tests for rounding

Unit tests to highlight the issue

To test:
Prove t/db_dependent/Budgets.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #15 from Nick Clemens  ---
Created attachment 70188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70188&action=edit
Bug 18736 - Use rounding syspref to determine correct prices in calculations

To test:
Place an order (no tax just for simplicity)
 listprice/rrp = 16.99
 discount = 42%
 quantity = 8
 estimated calculated at 9.85
 but order total is 78.83, but 8 times 9.85 = 78.80
Apply patches, set OrderPriceRounding syspref to 'Nearest cent'
Not order total is now as expected
View ordered.pl and confirm values are correct
Complete order, view invoice and confirm values
View spent.pl and confirm values
Go through acquisitions module and confirm prices throughout are
correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #9 from Katrin Fischer  ---
*** Bug 16722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16722] Display internal note for late orders

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16722

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 12502 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15461] Add staff equivalent to OpacLocationBranchToDisplayShelving

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461

--- Comment #1 from Katrin Fischer  ---
Could also be solved with colvis column configuration maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18065] Initials are not generated correctly by LDAP when firstname or surname start with umlauts

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18065

Katrin Fischer  changed:

   What|Removed |Added

 CC||dpav...@rot13.org
  Component|Patrons |Authentication

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour concerning sticky due date

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Sophie MEYNIEUX  changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m
   Assignee|baptiste.wojtkowski@biblibr |fridolin.som...@biblibre.co
   |e.com   |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

Katrin Fischer  changed:

   What|Removed |Added

Summary|Facet links broken because  |Facet links broken because
   |double-quotes are not URL   |double-quotes are not URL
   |encoded.|encoded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17786] Date filter on circulation statistics not working correctly

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17786

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13854] XSLT result list doesn't show 'on order' when itemtype is not for loan

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

--- Comment #4 from Katrin Fischer  ---
I think this requires a change, maybe resorting of conditions, in the XSLT file
für the result list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19888] New: "Overdue Notices" email sent to KohaAdminEmailAddress is useless

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

Bug ID: 19888
   Summary: "Overdue Notices" email sent to KohaAdminEmailAddress
is useless
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sophie.meyni...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

If a patron does not have any email address, a print notification is generated
instead of an email, so sending notification to Koha Admin is useless and
should be removed.

At least it should be possible to choose if we want it or not with a script
parameter

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19534] Adding collection code attribute to cover image div

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19534

--- Comment #1 from Michael Cabus  ---
Created attachment 70186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70186&action=edit
Bug [19534] - [Adding collection code attribute to cover image div] Adds
collection code value to cover image class, so specific collection code icons
can be assigned to search results

Test plan

1.) Do a search on OPAC
2.) Inspect element to confirm collection code is not present
3.) Apply patch
4.) Do a search on OPAC to confirm collection code is present as a class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #11 from David Gustafsson  ---
Hi! Yes I read the comment. As I wrote in the first comment I usually frown
upon this kind of optimization myself, but since the speedup is so substantial,
and we (at our library) really need to get indexing done during the night, this
patch is a requirement for our needs. The search_unblessed code is placed in
the Koha::Items for clarity, since it approximates the behaviour of
Koha::Items::search. DBIx also uses DBI internally, so in my opinion this
communicates the purpose of this optimization in more obvious way than if the
SQL would reside in GetItems for example. Also, one might want to use this
method in other places where item objects are fetched (through ->search for
example) and unblessed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #10 from Katrin Fischer  ---
Hi David, did you see my last comment? 

I think using SQL instead of Koha::Object in a module in the Koha namespace is
not valid. - So maybe wait before putting more work into this until we can give
you some more feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Gustafsson  changed:

   What|Removed |Added

  Attachment #70184|0   |1
is obsolete||

--- Comment #9 from David Gustafsson  ---
Created attachment 70185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70185&action=edit
Bug 19884 - Improve performance of GetItem

Provide optimized search_unblessed method for Koha::Items to increase
performance of GetItem. Also extend GetMarcItem() to also accept an item
record as second parameter. This way an extra call to GetItem() can be
avoided by passing an item record directly instead of an item number.

Also add new function GetItems() making it possible to load multiple
items at once, which is more efficient than loading them one by one.

How to test:
1) Run tests in t/db_dependent/Items.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Gustafsson  changed:

   What|Removed |Added

  Attachment #70172|0   |1
is obsolete||

--- Comment #8 from David Gustafsson  ---
Created attachment 70184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70184&action=edit
Bug 19884 - Improve performance of GetItem

Provide optimized search_unblessed method for Koha::Items to increase
performance of GetItem. Also extend GetMarcItem() to also accept an item
record as second parameter. This way an extra call to GetItem() can be
avoided by passing an item record directly instead of an item number.

Also add new function GetItems() making it possible to load multiple
items at once, which is more efficient than loading them one by one.

How to test:
1) Run tests in t/db_dependent/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #7 from David Gustafsson  ---
I added two profiling results obtained by running this script
https://gist.github.com/gnucifer/a86feeac08dac9bc1bb699f52b95f8b2 with and
without the patch to illustrate the difference. As can be seen by the
flamegraph Koha::Objects::find takes up half of the total time, and with the
patch applied this overhead is gone.

This shows the performance difference of just calling GetItem:
https://gist.github.com/gnucifer/113b033d211add58fe7e6ebfc257726a

Without patch the calls to GetItem takes about 100s to execute on my machine.
With patch applied 3.26s, so about 31 times faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #6 from David Gustafsson  ---
Created attachment 70183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70183&action=edit
GetMarcBiblio with patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #5 from David Gustafsson  ---
Created attachment 70182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70182&action=edit
GetMarcBiblio master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #54 from Magnus Enger  ---
(In reply to Fridolin SOMERS from comment #51)
> > 
> > The "Any" index/register should contains all the data contained in all the
> > other indexes/registers (e.g. Title, Author, Subject, etc). 
> > 
> > The "Anywhere" index/register should contain the entire record including
> > fields/subfields that aren't indexed anywhere else. 
> > 
> 
> This is what I want to do so I changed the bug description.

Which index will be used for the default/simple search from the OPAC front
page? 

One of my least favourite "features" of search in Koha is that the
default/simple search includes "Place of publication" (MARC21: 260$a). If you
have a Norwegian catalogue, a lot of the books in it will have Oslo as Place of
publication. This means that if you do a simple search for "oslo", because you
want to find books about Oslo, you will get *a lot* of noise, because you not
only find the books about Oslo, but also all the books published in Oslo. 

Any chance of fixing this as part of this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines

2017-12-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED

--- Comment #13 from Tomás Cohen Arazi  ---
16330 got big changes. This is not supposed to apply nor up to date with the
voted RFC. I'll fix it today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/