[Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 Elias changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 --- Comment #3 from Elias --- (In reply to Katrin Fischer from comment #2) > The translation displays on master and the po files for 17.11 contain the > string. > > Did you make any changes to the default XSLT files? That could cause strings > to appear untranslated. The default XSLT files are unchanged, but after another 'sudo koha-translate --update de-DE' the translation seems fixed. Thank you for the fast response. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12 from Katrin Fischer --- Thx, Arturo, for documenting your tests and the sign-off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer changed: What|Removed |Added Attachment #70308|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 70445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70445&action=edit Bug 19911: Do not escape html characters when saving passwords When the password is not generated automatically, we should not escape the html characters. Otherwise it will be changed without any warnings. Signed-off-by: Arturo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer changed: What|Removed |Added Attachment #70309|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 70446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70446&action=edit Bug 19911: Escape password value during self-registration confirmation The password must be correctly escape, it can contains html character and break the display. Test plan: Apply first patch and confirm that the display is broken Apply second patch (this one) and confirm that the display is fixed Signed-off-by: Arturo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #61 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #60) > Bouzid: I will still continue on this one. But how do you make sure that you > do not save a personal name into say field 610 that should only include > corporate names ? QA: Looking here again little bit. Bouzid: A response would have been helpful to expedite QA now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #16 from Marcel de Rooy --- Thx for your adjustments! Looks good to me. Final comments: This is not a blocker for me, but OpacExportOptions controls the options listed by detail sidebar. Your custom exports are listed no matter what. It might be better to let OpacExportOptions also control if the custom exports should be added to the list somehow. Maybe not one by one, but just on directory level (show them all or not)? But do not make big adjustments here. It could be handled on a new report or we could simply state: remove the xsl files from biblioexport. XSLTParse4Display is not yet tested, but your change should officially be tested ;) Also I recommend to remove the opac parameter. It is not consistent with the approach followed in the sub. Not changing the parameters could help you here. Please send XSLTCustomExport and OPACXSLTCustomExport to the routine; this is consistent and does the same thing. Since your change only deals with the $xslfilename, I could live without a test script (but I am not sure about the RM). CustomXSLTExportList is new and should really have its own test (should not be hard) Mock opachtdocs and create the dir in a tempdir. Check on returned title and method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #16 from Katrin Fischer --- The manual team is still small, maybe write something up and send it to them? ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 --- Comment #2 from Katrin Fischer --- The translation displays on master and the po files for 17.11 contain the string. Did you make any changes to the default XSLT files? That could cause strings to appear untranslated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Chris Cormack changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #13 from Chris Cormack --- Looks good to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16639] Split item data from description in Fines tab into separate columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #3 from Owen Leonard --- I don't think it's necessary to show all the links from the old confirmation page. They're all in the toolbar or the sidebar. I would prefer that we instead put a standard "message" type dialog saying "Your report has been saved." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19961] New: Move template JavaScript to the footer: Patron card creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961 Bug ID: 19961 Summary: Move template JavaScript to the footer: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for patron card creator templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What|Removed |Added Depends on||19961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961 [Bug 19961] Move template JavaScript to the footer: Patron card creator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens changed: What|Removed |Added CC||bar...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 --- Comment #1 from Owen Leonard --- Created attachment 70444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70444&action=edit Bug 19960: Update popup window templates to use Bootstrap grid: Add to list This patch updates add-to-list template to use the Bootstrap grid instead of the YUI grid. To test, open the detail page for a bibliographic record in the staff client and choose "Add to -> List." The resulting pop-up window should look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #2 from Nick Clemens --- Created attachment 70443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70443&action=edit Bug 19957 - Hide saved message once editing report To test: 1 - Apply this patch 2 - Save/Update report 3 - Note when you focus on the 'sql' area the saved message dissappears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19960] New: Update popup window templates to use Bootstrap grid: Add to list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Bug ID: 19960 Summary: Update popup window templates to use Bootstrap grid: Add to list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be one lists template: addbybiblionumber.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What|Removed |Added Depends on||19960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart --- This is what I had in mind. The first 2 patches just move code, the last one may be problematic if I missed something in the logic. In discussion. Please obsolete these patches if you prefer another QAer opinion or switch back to NSO if you agree with testing them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #9 from Jonathan Druart --- Created attachment 70440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70440&action=edit Bug 19160: Move duplicated code to its own private subroutine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #11 from Jonathan Druart --- Created attachment 70442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70442&action=edit Bug 19160: Isolate CAS code into its own module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #10 from Jonathan Druart --- Created attachment 70441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70441&action=edit Bug 19160: Move the code from controller to C4::Auth_with_cas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #1 from Nick Clemens --- Created attachment 70439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70439&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 9 - Note errors stil display as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 --- Comment #1 from Owen Leonard --- Created attachment 70438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70438&action=edit Bug 19959: Update popup window templates to use Bootstrap grid: Label creator This patch updates two label creator templates to use the Bootstrap grid instead of the YUI grid. To test, apply the patch and go to Label creator -> Manage -> Label batches. - Create a new or open an existing label batch. - Click "Add items." - The resulting pop-up window should look correct. - Perform a search - The search results screen should look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Circ rules will not limit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Ed Veal changed: What|Removed |Added CC||ev...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What|Removed |Added Depends on||19959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19959] New: Update popup window templates to use Bootstrap grid: Label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Bug ID: 19959 Summary: Update popup window templates to use Bootstrap grid: Label creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 19709 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two label creator templates: result.tt, search.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard changed: What|Removed |Added Blocks||19959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall changed: What|Removed |Added Attachment #70436|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 70437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70437&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall changed: What|Removed |Added Attachment #70434|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 70436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70436&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19958] New: Allow the system preference AutoMemberNum to include a combination of numbers and letters when creating a new barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19958 Bug ID: 19958 Summary: Allow the system preference AutoMemberNum to include a combination of numbers and letters when creating a new barcode Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently the system preference "automembernum" only allows for the patron's barcode to default the card number field on the patron addition screen to the next available card number (for example, if the largest currently used card number is 2634512941, then this field will default to 2634512942). It would be nice for the library to choose the format of the barcode (for example : system preference autobarcode). Then a library could choose to include letters and numbers to their patron's barcode instead of just numbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 --- Comment #1 from Owen Leonard --- Created attachment 70435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70435&action=edit Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] New: Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Bug ID: 19957 Summary: Allow continued editing after saving a report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19957] Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov --- Comment #1 from Christopher Davis --- Thanks Lisette, We have seen this behavior in Koha at our institution as well. This bug is more annoying and confusing than anything, but it would be good to have it patched. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19956] New: Adjusting fine block on SIP connected self-check - Coffeyville
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956 Bug ID: 19956 Summary: Adjusting fine block on SIP connected self-check - Coffeyville Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: je...@bywatersolutions.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org 1) Add a new parameter "ignore_AllFinesNeedOverride" to SIP2 config on a per-account basis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 --- Comment #1 from Kyle M Hall --- Created attachment 70434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70434&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19955] New: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Bug ID: 19955 Summary: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #9 from Owen Leonard --- Created attachment 70433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70433&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What|Removed |Added Depends on||19954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19954] New: Update popup window templates to use Bootstrap grid: Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Bug ID: 19954 Summary: Update popup window templates to use Bootstrap grid: Patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 19641 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two patron-related templates: moremember-brief.tt and update-child.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||19954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 --- Comment #5 from Owen Leonard --- (In reply to Claire Gravely from comment #3) > - clicking 'add items' without entering any barcodes opens an empty frame My updated patch fixes this. > - When exporting items or a batch, the 'cancel' link in the first frame > doesn't work > - After exporting, the 'done' button doesn't work I can't reproduce these problems. Can you please try again and let me know if it's still happening? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard changed: What|Removed |Added Attachment #69418|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 70432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70432&action=edit Bug 19709 - Move template JavaScript to the footer: Labels This patch modifies the staff client label creator templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing batches - Creating and managing templates - Creating and managing printer profiles - Creating quick spine labels Edit: Fixed footer include error causing blank popup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #23 from Barton Chittenden ---
(In reply to Marcel de Rooy from comment #21)
> (In reply to Jonathan Druart from comment #16)
> > Yes Barton you are right, that's why I added a comment to the POD of the
> > method to tell it only applies for the OPAC.
> > Maybe rename the method to something more verbose (is_cancelable_from_opac)
> > to remove the ambiguity?
>
> Maybe include a parameter for opac/intranet/api ?
> $hold->is_cancelable{( from => 'opac' or opac=>1 }) ?
This strikes the right balance for me.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #22 from Katrin Fischer --- You are absolutely right, Marcel. Tired brain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #21 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #16)
> Yes Barton you are right, that's why I added a comment to the POD of the
> method to tell it only applies for the OPAC.
> Maybe rename the method to something more verbose (is_cancelable_from_opac)
> to remove the ambiguity?
Maybe include a parameter for opac/intranet/api ?
$hold->is_cancelable{( from => 'opac' or opac=>1 }) ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #20 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #17) > is_found is also a bit confusing, because this also includes transit items. > found = F in the reserves table is for waiting. So you might not think about > the transit items as well immediately. It confused me on testing this. found=W is waiting found=F is finished (only in deleted reserves) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #1 from Victor Grousset/tuxayo --- Created attachment 70431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70431&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items → receive? → tick this checkbox 8. save 9. click on "finish receiving" 10. Go to the record → Acquisition details 11. Apply this patch 12. Refresh the page 13. You should see the new column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #47 from Alex Arnaud --- Created attachment 70430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70430&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #46 from Alex Arnaud --- (In reply to Josef Moravec from comment #44) > Comment on attachment 70336 [details] [review] > Bug 17656 - Update irregularities on subscription renewals > > Review of attachment 70336 [details] [review]: > - > > > Better to add new subs just to Koha namespace... but I understand it here - > we do not have all the objects needed for serials management (frequencies > and number patterns are missing) and calling C4 subs from Koha namespace is > not good idea... If you are not willing to add needed objects, we could just > fill a bug for now... Don't understand. You mean create Koha::Subscription->GuessEnddate? > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt > @@ +52,5 @@ > > + > > + > > + > > + > > + > > Why do you include all the data when renewing subscription? It should be not > needed! Yes. testPredictionPattern js function needs all the data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #8 from Owen Leonard --- Created attachment 70429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70429&action=edit Bug 19641 (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Attachment #69415|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 70428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70428&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #70427|Screenshot proposed change |Screenshot of proposed description||change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] New: Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Bug ID: 19953 Summary: Record page: acquisition details: add column for invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grous...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 70427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70427&action=edit Screenshot proposed change See the attachment for how it would look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #9 from Victor Grousset/tuxayo --- "," is now used by default if the syspref is missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #70422|0 |1 is obsolete|| --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 70426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70426&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=X 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #19 from Kyle M Hall --- Created attachment 70425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70425&action=edit Bug 18856 [QA Followup] - Rename method to avoid confusion Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Attachment #70398|0 |1 is obsolete|| Attachment #70399|0 |1 is obsolete|| Attachment #70419|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 70424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70424&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Axelle Aix-Marseille Université changed: What|Removed |Added CC||axelle.clari...@univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 --- Comment #1 from Owen Leonard --- Created attachment 70423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70423&action=edit Bug 19952: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins This patch updates two UNIMARC cataloging plugin templates to use the Bootstrap grid instead of the YUI grid. - unimarc_field_210c_bis.tt - unimarc_field_686a.tt To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that the page in the popup window looks correct. Confirm that changes made in the popup window are saved to the corresponding field in the editor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What|Removed |Added Depends on||19952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard changed: What|Removed |Added Blocks||19952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19952] New: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Bug ID: 19952 Summary: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 19878 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two UNIMARC cataloging plugins: unimarc_field_210c_bis.tt and unimarc_field_686a.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #7 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #6) > [...] you do not default to ';', ',' or '\t' if the pref 'delimiter' > does not exist. > > Maybe ',' is better here as it was the value before your changes. You're right, I though that the pref 'delimiter' always existed. Is giving 'delimiter' a default value in the DB[1] also an option? [1] INSERT in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #6 from Jonathan Druart --- About your patches, it should not be needed but it is the behaviour of other occurrences: you do not default to ';', ',' or '\t' if the pref 'delimiter' does not exist. Maybe ',' is better here as it was the value before your changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #5 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #4) > Thanks Joubu for this explanation: > http://git.koha-community.org/gitweb/?p=koha.git;a=commit; > h=8403799c7212349bee70090249e3425afd62423b > About the part "in order to make it a have-to-read for next changes." > How would the next person find this? As it won't be the last commit. (It could be a have-to-read if I fix all the grammar errors!) At least you, Katrin and me are aware of this commit and the problem. So we can guide people to this commit message when they need it :) Feel free to create a wiki page if you think it is a good idea (and you have time). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #4 from Victor Grousset/tuxayo --- Thanks Joubu for this explanation: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=8403799c7212349bee70090249e3425afd62423b About the part "in order to make it a have-to-read for next changes." How would the next person find this? As it won't be the last commit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #70421|0 |1 is obsolete|| --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 70422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70422&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=X 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 70421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70421&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=X 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- It works in our 16.11.13, will try to check on master too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
