[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Julian Maurice  changed:

   What|Removed |Added

 Depends on||20178


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178
[Bug 20178] Fix output_pref with dateformat=iso
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20178] New: Fix output_pref with dateformat=iso

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178

Bug ID: 20178
   Summary: Fix output_pref with dateformat=iso
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: julian.maur...@biblibre.com
QA Contact: julian.maur...@biblibre.com
Blocks: 17258

This bug is a continuation of bug 20144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177

--- Comment #3 from Julian Maurice  ---
But maybe the joins are useless ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #2 from Julian Maurice  ---
The GROUP BY is needed here. Otherwise you can see the same course multiple
times in /cgi-bin/koha/course_reserves/course-reserves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177

--- Comment #1 from Julian Maurice  ---
Created attachment 71468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71468=edit
Bug 20177: [sql_modes] Remove GROUP BY clause in GetCourses

Fix for:
'koha_kohadev.courses.department' isn't in GROUP BY

t/db_dependent/CourseReserves.t

no need to group by here

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20177

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20177] New: Remove GROUP BY clause in GetCourses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177

Bug ID: 20177
   Summary: Remove GROUP BY clause in GetCourses
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: julian.maur...@biblibre.com
QA Contact: julian.maur...@biblibre.com
Blocks: 17258

This bug is a continuation of bug 20144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Julian Maurice  changed:

   What|Removed |Added

 Depends on||20177


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177
[Bug 20177] Remove GROUP BY clause in GetCourses
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13580] item circ history has 'last seen' labeled wrong

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580

--- Comment #5 from Sophie MEYNIEUX  ---
What data do we really want to see there ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #65 from Julian Maurice  ---
Created attachment 71467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71467=edit
Bug 20144: [sql_modes] Do not store -00-00

This patch needs to be linked with bug 20145.

Fix for:
Incorrect date value: '-00-00' for column 'dateexpiry'

We cannot longer store -00-00, but no need to.
The tests must be kept for now as long as bug 20145 has a solution

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13580] New: item circ history has 'last seen' labeled wrong

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580

Bug ID: 13580
   Summary: item circ history has 'last seen' labeled wrong
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: cgi-bin/koha/circ/bookcount.pl?=106124
=106124=140197
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: katrin.fisc...@bsz-bw.de, sophie.meyni...@biblibre.com
CC: katrin.fisc...@bsz-bw.de
CC: sophie.meyni...@biblibre.com

On this page:
cgi-bin/koha/circ/bookcount.pl?=106124=106124=140197 the
'last seen' column is actually the timestamp - not the date last seen so it's
confusing. The label should be changed or the value should be changed.

--- Comment #1 from Owen Leonard  ---
*** Bug 13581 has been marked as a duplicate of this bug. ***

--- Comment #2 from Katrin Fischer  ---
Hm, it's not quite the timestamp either. It looks like a calculated date on
when the item was 'last seen' in this library. 

It uses the newest date and time from issues, old_issues and branchtransfers.

Maybe 'last seen at library'?

--- Comment #3 from Katrin Fischer  ---
Hm, it's not quite the timestamp either. It looks like a calculated date on
when the item was 'last seen' in this library. 

It uses the newest date and time from issues, old_issues and branchtransfers.

Maybe 'last seen at library'?

--- Comment #4 from Sophie MEYNIEUX  ---
The pb with this timestamp is that it is changed by anonymisation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #2 from Julian Maurice  ---
There are other places where the default values are enforced in 'store'
subroutine (Koha::Patron::Category for example). Why does this patch enforce a
default value in 'new' subroutine ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176

--- Comment #1 from Julian Maurice  ---
Created attachment 71466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71466=edit
Bug 20176: [sql_modes] Set biblio.datecreated to NOW if not defined

Fix at constructor level, this issue appears in lot of places.

Fix for:
Field 'datecreated' doesn't have a default value

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20176

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #5 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #4)
> Why do you think the favicon is not used?

Because the templates only use the ones in the image subdirectories, not the
koha-tmpl directory directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Julian Maurice  changed:

   What|Removed |Added

 Depends on||20176


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176
[Bug 20176] Set biblio.datecreated to NOW if not defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20176] New: Set biblio.datecreated to NOW if not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176

Bug ID: 20176
   Summary: Set biblio.datecreated to NOW if not defined
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: julian.maur...@biblibre.com
QA Contact: julian.maur...@biblibre.com
Blocks: 17258

This bug is a continuation of bug 20144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

--- Comment #4 from Jonathan Druart  
---
It is set in svc/club/enroll

 50 date_enrolled  => \'NOW()',
 51 date_created   => \'NOW()',

Which it weird and wrong. 
I considered it as out of the scope if there is no regression.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

--- Comment #3 from Julian Maurice  ---
Not sure about this one. Shouldn't date_created be set to "now" in
Koha::Club::Enrollment->store ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

--- Comment #2 from Julian Maurice  ---
Created attachment 71465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71465=edit
Bug 20175: [sql_modes] (follow-up) Set a correct default value for
club_enrollments.date_created

>From comment 6:
"""
Can't recreate database, when creating table structure, I got:
there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT
or ON UPDATE clause

I am on mysql 5.5.59, which is still default in jessie, more timestamp
columns are possible from mysql 5.6.5:
https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html
"""

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

--- Comment #1 from Julian Maurice  ---
Created attachment 71464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71464=edit
Bug 20175: [sql_modes] Set a correct default value for
club_enrollments.date_created

-00-00 00:00:00 is not a valid timestamp.

It will fix the installer and upgrade process

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Julian Maurice  changed:

   What|Removed |Added

 Depends on||20175


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175
[Bug 20175] Set a correct default value for club_enrollments.date_created
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20175

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20175] New: Set a correct default value for club_enrollments.date_created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175

Bug ID: 20175
   Summary: Set a correct default value for
club_enrollments.date_created
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: julian.maur...@biblibre.com
QA Contact: julian.maur...@biblibre.com
Blocks: 17258

This bug is a continuation of bug 20144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #64 from Julian Maurice  ---
All attached patches are ready to be pushed.

I will create other bug reports for the other patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #63 from Julian Maurice  ---
Created attachment 71463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71463=edit
Bug 20144: [sql_modes] Fix GROUP BY clause in Virtualshelves search (DT)

Fix for:
'koha_kohadev.vs.shelfname' isn't in GROUP BY

t/db_dependent/Utils/Datatables_Virtualshelves.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #62 from Julian Maurice  ---
Created attachment 71462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71462=edit
Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if
not passed

Fix for:
Incorrect integer value: '' for column 'numberlength'
Incorrect integer value: '' for column 'weeklength'

t/db_dependent/Serials/ReNewSubscription.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71441|0   |1
is obsolete||

--- Comment #61 from Julian Maurice  ---
Created attachment 71461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71461=edit
Bug 20144: [sql_modes] Add default value for
subscription_numberpatterns.description in tests

Fix for:
Field 'description' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #60 from Julian Maurice  ---
Created attachment 71460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71460=edit
Bug 20144: [sql_modes] Fix search history tests

Incorrect datetime value: '1374978877' for column 'time'

Need to investigate this: Why did I put that value in the test?
Does the feature correctly works?

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #59 from Julian Maurice  ---
Created attachment 71459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71459=edit
Bug 20144: [sql_modes] Fix values when creating a sql report in tests

For fix:
Data too long for column 'report_area'
Incorrect integer value: 'null' for column 'cache_expiry'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #58 from Julian Maurice  ---
Created attachment 71458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71458=edit
Bug 20144: [sql_modes] Set default value for opac_news.content in tests

Fix for:
Field 'content' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #57 from Julian Maurice  ---
Created attachment 71457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71457=edit
Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in
GetItemsForInventory

Fix for:
DBD::mysql::st execute failed: Mixing of GROUP columns
(MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP
BY clause [for Statement 'SELECT COUNT(*)

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #56 from Julian Maurice  ---
Created attachment 71456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71456=edit
Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests

Fix for:
Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is
illegal if there is no GROUP BY clause

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #55 from Julian Maurice  ---
Created attachment 71455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71455=edit
Bug 20144: [sql_modes] Set value for creator_batches.timestamp

Fix for:
Incorrect datetime value: 'now()' for column 'timestamp'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71442|0   |1
is obsolete||

--- Comment #54 from Julian Maurice  ---
Created attachment 71454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71454=edit
Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests

Fix for:
Field 'datecreated' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #53 from Julian Maurice  ---
Created attachment 71453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71453=edit
Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp

Not null

Fix for:
Incorrect datetime value: 'null' for column 'timestamp'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #52 from Julian Maurice  ---
Created attachment 71452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71452=edit
Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues

Fix for:
'koha_kohadev.b.title' isn't in GROUP BY

t/db_dependent/Circulation/GetTopIssues.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Claire Gravely  ---
Hiya,

The patch has fixed the error message.

However, in the OPAC advanced search under the Item type tab, there is a
checkbox for my new ITEMTYPECAT but no description (label) is displayed. 

If I select only the new category checkbox to perform a search (no keywords
etc), nothing happens and the advanced search page refreshes. If I check the
new category and also another itype category (eg: music) with no keywords, then
search results are displayed as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@joensuu.fi

--- Comment #14 from paxed  ---
Like Katrin, I'm also worried about having numbers from different countries.

Couldn't this functionality basically be done with a phone number validator
written in javascript and hooked on to the borrower edit/add form inputs? And
for checking the phone numbers in the database, a simple report could be done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #51 from Julian Maurice  ---
Created attachment 71451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71451=edit
Bug 20144: [sql_modes] Remove 'Null' string values from GetHardDueDate.t

Must be undef or correct integer value

Fix for:
Incorrect integer value: 'Null' for column 'enrolmentperiod'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #50 from Julian Maurice  ---
Created attachment 71450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71450=edit
Bug 20144: [sql_modes] Set default value for Itemtype fees in TestBuilder

Fix for:
Out of range value for column 'amount'

t/db_dependent/Circulation/Chargelostitem.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #49 from Julian Maurice  ---
Created attachment 71449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71449=edit
Bug 20144: [sql_modes] Fix GROUP BY clause in GetInvoices

Need to be tested from the interface!

Fix for:
'koha_kohadev.aqinvoices.invoicenumber' isn't in GROUP BY

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #48 from Julian Maurice  ---
Created attachment 71448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71448=edit
Bug 20144: [sql_modes] Fix GROUP BY clause in GetBasketsInfosByBookseller

This need to be tested from the interface!

Fix for:
'koha_kohadev.aqbasket.basketname' isn't in GROUP BY

t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t

We need this group by.
We should not need to list all fields, from mysql 5.7 doc:
https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html
"The query is valid if name is a primary key of t or is a unique NOT NULL
column. In such cases, MySQL recognizes that the selected column is
functionally dependent on a grouping column. "

However, MariaDB did not implemented yet:
https://jira.mariadb.org/browse/MDEV-11588

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #47 from Julian Maurice  ---
Created attachment 71447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71447=edit
Bug 20144: [sql_modes] Add default value for export_basket.description in tests

Fix for:
Field 'description' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #46 from Julian Maurice  ---
Created attachment 71446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71446=edit
Bug 20144: [sql_modes] Shorten values for virtualshelfshares.invitekey in tests

It's a varchar(10)

Fix for:
Data too long for column 'invitekey'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #45 from Julian Maurice  ---
Created attachment 71445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71445=edit
Bug 20144: [sql_modes] Set correct value for old_issues.issue_id in tests

Fix for:
Column 'issue_id' cannot be null

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #44 from Julian Maurice  ---
Created attachment 71444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71444=edit
Bug 20144: [sql_modes] Shorten auth_header.authtypecode values in tests

Fix for:
Data too long for column 'authtypecode'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71419|0   |1
is obsolete||

--- Comment #43 from Julian Maurice  ---
Created attachment 71443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71443=edit
Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests

Fix for:
Field 'marcxml' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71435|0   |1
is obsolete||

--- Comment #42 from Julian Maurice  ---
Created attachment 71442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71442=edit
Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests

Should call Koha::Biblio->new instead

Fix for:
Field 'datecreated' doesn't have a default value

t/db_dependent/UsageStats.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71430|0   |1
is obsolete||

--- Comment #41 from Julian Maurice  ---
Created attachment 71441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71441=edit
Bug 20144: [sql_modes] Add default value for
subscription_numberpatterns.description in tests

Fix for:
Field 'description' doesn't have a default value

t/db_dependent/Serials.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #40 from Julian Maurice  ---
Created attachment 71440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71440=edit
Bug 20144: [sql_modes] Remove HAVING clause in GetBorrowersToExpunge

Special attention needed here!

Fix for:
Non-grouping field 'currentissue' is used in HAVING clause

t/db_dependent/Members.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078

--- Comment #1 from Nick Clemens  ---
Created attachment 71439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71439=edit
Bug 20078:  Add accelerated reading indexes to getIndexes

To test:
1 - Find a bib with 526$c and 526$d populated, or populate them
 e.g. 526$a 5.5 | 526$d 14
2 - Try searching for 'arl:5.5' or 'arp:14'
3 - Your record should be returned in results
4 - Add the indexes as dropdowns by entering the following in intranetuserjs:
$(document).ready(function(){
// Add Accelerated Reading Level to advanced search
if (window.location.href.indexOf("catalogue/search.pl") > -1) {
$(".advsearch").append('Accelerated Reading
Level');
}

// Add Accelerated Reading Point to advanced search
if (window.location.href.indexOf("catalogue/search.pl") > -1) {
$(".advsearch").append('Accelerated Reading
Point');
}
});
5 - Search using these in the dropdown, your record will not be found
6 - Apply patch
7 - Repeat searches directly and by using dropdown, your record should be
returned.
8 - prove t/db_dependent/Search.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #39 from Julian Maurice  ---
Created attachment 71438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71438=edit
Bug 20144: [sql_modes] Set default value for marc_modification_template_actions

Cannot be empty strings.

Fix for:
Data truncated for column 'conditional'
Data truncated for column 'conditional_comparison'
Incorrect integer value: '' for column 'conditional_regex'

t/db_dependent/MarcModificationTemplates.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #38 from Julian Maurice  ---
Created attachment 71437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71437=edit
Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters

This subroutine is wrong and must be rewritten using
Koha::Notice::Templates.
Mainly because the DB structure is bad.
Meanwhile we remove the branchcode from the SELECT to get correct
results, it was not used by callers anyway.

Fix for:
'koha_kohadev.letter.module' isn't in GROUP BY

t/db_dependent/Letters.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71422|0   |1
is obsolete||

--- Comment #37 from Julian Maurice  ---
Created attachment 71436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71436=edit
Bug 20144: [sql_modes] Correct quotes.timestamp values in tests

Fix for:
Incorrect datetime value: '-00-00 00:00:00' for column 'timestamp'

t/db_dependent/Koha.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #36 from Julian Maurice  ---
Created attachment 71435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71435=edit
Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests

When created without Koha::Biblio.

Fix for:
Field 'datecreated' doesn't have a default value

t/db_dependent/Items.t

TODO LATER - Use Koha::Biblio instead

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #35 from Julian Maurice  ---
Created attachment 71434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71434=edit
Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT

Fix for:
Field 'marcxml_old' doesn't have a default value

t/db_dependent/ImportBatch.t

Fixme - need to update existing DB?

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69951|0   |1
is obsolete||

--- Comment #7 from Claire Gravely  ---
Created attachment 71433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71433=edit
Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl

To test:
1 - Run the circulation wizard with itemtypes as columns, shelving
locations as rows - display on screen
2 - Note all itemtype values are blank
3 - Switch rows/columns - same issue
4 - Apply patch
5 - Re-run reports
6 - Itemtypes should display correctly

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #34 from Julian Maurice  ---
Created attachment 71432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71432=edit
Bug 20144: [sql_modes] Remove HAVING clause in GetUpcomingDueIssues

More attention needed here!

Fix for:
Non-grouping field 'days_until_due' is used in HAVING clause

t/db_dependent/Circulation.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #33 from Julian Maurice  ---
Created attachment 71431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71431=edit
Bug 20144: [sql_modes] Set issuingrules.no_auto_renewal_after to NULL in tests

Fix for:
Incorrect integer value: '' for column 'no_auto_renewal_after'

FIXME - must we update values for existing installs?
TODO - check if can be set to an empty string from the interface

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #32 from Julian Maurice  ---
Created attachment 71430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71430=edit
Bug 20144: [sql_modes] Add default value for
subscription_numberpatterns.description in tests

Fix for:
Field 'description' doesn't have a default value

t/db_dependent/AdditionalField.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #31 from Julian Maurice  ---
Created attachment 71429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71429=edit
Bug 20144: [sql_modes] Remove HAVING clause in GetLateOrders

More attention needed here!

Fix for:
Non-grouping field 'quantity' is used in HAVING clause

Having is useless, and certainly slower

t/db_dependent/Acquisition.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #13 from Katrin Fischer  ---
You are right, the country-code is in the module. I am worried that different
modules will be hard to maintain while containing a lot of duplicated code, at
least for the European countries.

I think better in Koha - but please check with Joubu for general approach.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #30 from Julian Maurice  ---
Created attachment 71428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71428=edit
Bug 20144: [sql_modes] Shorten aqbudgets.budget_code

Fix for:
Data too long for column 'budget_code'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #29 from Julian Maurice  ---
Created attachment 71427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71427=edit
Bug 20144: [sql_modes] Set default value for Acccountline in TestBuilder

Fix for:
Data too long for column 'proccode'

t/db_dependent/Accounts.t

FIXME LATER - It's a varchar(4), must be integer!

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163

Claire Gravely  changed:

   What|Removed |Added

  Attachment #71357|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 71426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71426=edit
Bug 20163: Position of NoLoginInstructions text is inconsistent

This patch modifies the markup for two login forms, making the markup
more consistent between them. The order of NoLoginInstructions, "Forgot
your password?" and "Don't have an account?" should now be the same.

This patch also updates some classes in each login form to allow for
more consistent custom styling.  A couple of capitalization corrections
are included.

To test, enable the PatronSelfRegistration and OpacResetPassword
preferences. Put some text in the NoLoginInstructions preference.

View the login form as associated links on the OPAC main page. Compare
to the login form which appears in a modal window when you click the
login link at the top of the page. The two areas should look consistent.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #28 from Julian Maurice  ---
Created attachment 71425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71425=edit
Bug 20144: [sql_modes] Fix default value for statistics.itemnumber

Must be an integer, not empty string

Fix for:
Incorrect integer value: '' for column 'itemnumber'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #27 from Julian Maurice  ---
Created attachment 71424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71424=edit
Bug 20144: [sql_modes] Add a value for borrower_attribute_types.description in
tests

Fix for:
Field 'description' doesn't have a default value

t/db_dependent/Koha/Patron/Attribute/Types.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #26 from Julian Maurice  ---
Created attachment 71423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71423=edit
Bug 20144: [sql_modes] Shorten items.barcode

It's a varchar(20)

Fix for:
Data too long for column 'barcode'

t/db_dependent/Koha/Items.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #25 from Julian Maurice  ---
Created attachment 71422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71422=edit
Bug 20144: [sql_modes] Correct quotes.timestamp values in tests

Fix for:
Incorrect datetime value: '-00-00 00:00:00' for column 'timestamp'

t/db_dependent/Koha/GetDailyQuote.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #24 from Julian Maurice  ---
Created attachment 71421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71421=edit
Bug 20144: [sql_modes] Add default values for export_format columns

Fix for:
Field 'field_separator' doesn't have a default value
Field 'encoding' doesn't have a default value

field_separator and subfield_separator are only used for MARC csv
profiles, no need to specify a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #23 from Julian Maurice  ---
Created attachment 71420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71420=edit
Bug 20144: [sql_modes] Shorten cities.city_zipcode

It's a varchar(20)

Fix for:
Data too long for column 'city_zipcode'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #22 from Julian Maurice  ---
Created attachment 71419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71419=edit
Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests

Fix for:
Field 'marcxml' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #21 from Julian Maurice  ---
Created attachment 71418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71418=edit
Bug 20144: [sql_modes] Set missinglist and recievedlist in subscriptionhistory

Fix for:
Field 'missinglist' doesn't have a default value

t/db_dependent/Koha/Acquisition/Booksellers.t

from mysql doc:
BLOB, TEXT, GEOMETRY, and JSON columns cannot be assigned a default
 value.

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #20 from Julian Maurice  ---
Created attachment 71417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71417=edit
Bug 20144: [sql_modes] Fix date format in tests

Fix for:
Incorrect date value: '01-01-2013' for column 'startdate'
Incorrect date value: '01-01-2016' for column 'budget_period_enddate'
Incorrect date value: '30-11-2013' for column 'enddate'
Incorrect date value: '31-12-2015' for column 'budget_period_enddate'
Incorrect date value: '12-31-2015' for column 'budget_period_enddate'
Incorrect date value: '01-01-2014' for column 'entrydate'

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #19 from Julian Maurice  ---
Created attachment 71416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71416=edit
Bug 20144: [sql_modes] Set default value for aqbasket.is_standing

Fix for:
Column 'is_standing' cannot be null

t/db_dependent/Koha/Acquisition/Booksellers.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #18 from Julian Maurice  ---
Created attachment 71415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71415=edit
Bug 20144: [sql_modes] Fix datatype for aqbasket.authorisedby

It's defined as a VARCHAR(10) in DB, but it is expecting a
borrowernumber instead

Fix for
Data too long for column 'authorisedby'

Must be a FK but first a borrowernumber
Need to update kohastructure for the comment?

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #17 from Julian Maurice  ---
Created attachment 71414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71414=edit
Bug 20144: [sql_modes] Set default value for Aqbookseller in TestBuilder

Fix for:
Out of range value for column 'tax_rate'

t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #16 from Julian Maurice  ---
Created attachment 71413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71413=edit
Bug 20144: [sql_modes] Fix generated value for account_offsets.amount

Fix error:
Out of range value for column 'amount'

DBD::mysql::st execute failed: Out of range value for column 'amount' at
row 1 [for Statement "INSERT INTO `account_offsets` ( `amount`,
`debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues:
0=7925469795795194609664.00, 1='10', 2='Manual Debit'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

7925469795795194609664.00
=> Should be lower anyway

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #15 from Julian Maurice  ---
Created attachment 71412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71412=edit
Bug 20144: [sql_modes] Fix default value for statistics.amount

Must be an integer, not empty string
Fix for:
Data truncated for column 'value'

Found with
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #14 from Julian Maurice  ---
Created attachment 71411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71411=edit
Bug 20144: [sql_modes] Set a default value for lowestPriority

Fix for:
Field 'lowestPriority' doesn't have a default value

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #13 from Julian Maurice  ---
Created attachment 71410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71410=edit
Bug 20144: [sql_modes] Fix borrowers table structure

surname, address and city can be NULL

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144

--- Comment #12 from Julian Maurice  ---
The git branch contains more than 60 commits (mostly independents from each
other). Some commits are OK while others require more work. In order to not
block the whole thing, I'm going to attach the patches that pass QA, and maybe
open new reports for problematic patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #12 from Alex Arnaud  ---
An other point i'm wondering about is the libraries having borrowers from
different areas. It is the case for many universities. But, for now, the script
runs for all the users in database without being aware of their country/area

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #11 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #10)
> I agree with Jonathan:
> 
> - The French country code +33 is hard coded into the script which makes it
> only useful for French telephone numbers, but not usable for example for
> German ones (+41). This could easily be more generic and then much more
> useful.
+33 (or 0033) is not hard coded into the script. Only in the pod. It is only in
the C4::SMSNumber::Fr package which is dedicated to french number. You can add
a C4::SMSNumber::De package with a german logic for transforming number and add
to the pod:
  - De: Checks german mobile number. options: '+41', ... \n"
like i did for french


> - There is an option --country-option, but it doesn't appear to be used?
Yes, forgot to remove this from the pod
> - It adds a new module to C4, which we should not do anymore.
Better in Koha/SMSNumber/* ?
> - It doesn't include tests.
Right.
> 
> I think if we want something like that, it might be better as a clean-up
> script in misc/maintenance. Possibly without a separate module?
Separate modules contain the logic specific to each area. It's not
easy/clear/possible to have a script that check and transform number for all
the areas as the format of number could be different (i.e not the number of
digit). So the area paramter determines which area module to use.
> 
> I think it's not quite ready, sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/