[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #70482|0   |1
is obsolete||
  Attachment #70483|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 72082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72082=edit
Bug 9302 - Add ability to merge patron records

It would be great if there were a merge patrons feature. If you
accidentally end up with one patron with two cards it would be nice to
merge their records together so that you don't lose their history or
holds or anything.

This patch adds a basic patron merge feature. It attempts to relink all
patron related tables from the patron(s) to be merged. It does not
attempt to relink librarian account related tables at this time. This
feature does not attempt to automatically resolve issues such as
duplicate holds. Such a feature could build upon this one though.

Test Plan:
1) Apply this patch
2) Find two or more patrons
3) Perform a patron search that will bring them up on the same page of
   results, or add them all to a list of patrons.
4) Use the 'merge' button to begin the merging process
5) Choose a patron to keep
6) Verify the deleted patrons data ( checkouts, holds, etc )
   are now linked to the kept patron

Signed-off-by: Owen Leonard 

Signed-off-by: Ed Veal 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #24 from Kyle M Hall  ---
Created attachment 72083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72083=edit
Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table

Signed-off-by: Owen Leonard 

Signed-off-by: Ed Veal 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72080|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 72081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72081=edit
Bug 20123: Allow multiple instances of Koha to have different timezones on the
same server

Most of Koha depends on the local timezone of the server, except for
Koha::Database which support an ENV override with the key TZ.

We should take this a step further. We should not only accept the TZ
environment variable for all of Koha, we should really be able to set the
timezone in the koha conf file as well so we don't have to pass that
environment variable to things like cronjobs and one-off scripts.

Test Plan:
1) Apply this patch
2) Set a timzone in your koha_conf file, that is *not* your local time zone
   Available timzones are listed here:
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
3) Restart apache/plack
4) Perform some actions, check the timestamps in the database and in the
   html output, note they are for the set timezone and not the local
   timezone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

--- Comment #8 from Kyle M Hall  ---
(In reply to Dilan Johnpullé from comment #6)
> I'm having some trouble applying this patch in my devbox. My terminal output
> is as follows:

Please give it a try now! The patch just needed to be rebased!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #71840|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 72080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72080=edit
Bug 20123: Allow multiple instances of Koha to have different timezones on the
same server

Most of Koha depends on the local timezone of the server, except for
Koha::Database which support an ENV override with the key TZ.

We should take this a step further. We should not only accept the TZ
environment variable for all of Koha, we should really be able to set the
timezone in the koha conf file as well so we don't have to pass that
environment variable to things like cronjobs and one-off scripts.

Test Plan:
1) Apply this patch
2) Set a timzone in your koha_conf file, that is *not* your local time zone
   Available timzones are listed here:
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
3) Restart apache/plack
4) Perform some actions, check the timestamps in the database and in the
   html output, note they are for the set timezone and not the local
   timezone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #8 from Magnus Enger  ---
Some further observations:

I have a bunch of MARC-records in a file that I import with:

bulkmarcimport.pl -insert -match=Control-number,001 -l /tmp/insert.log

(I use some more options as well, of course, but these are the interesting
ones), because I want to check if the records exist (based on the value in 001)
and only add them if they do not already exist in Koha. When I look at the log,
I see something like this:

126210;insert;ok
126210;insert;ok
103703;insert;warning : already in database
103703;insert;ok
126211;insert;ok
126211;insert;ok

126210 and 126211 are OK, they did not exist and have now been added. 

Since the script has correctly figured out that 103703 is already in the
database, I would expect it to be skipped. But when I look at the timestamps in
the database it turns out the entries in the biblio and biblioitems tables were
not affected, but biblio_metadata *was* actually updated. And the item was
added to the record. This means I now have two items on this record, where
there should just be one. 

This behaviour seems to be caused by having the logic for update/insert on
lines 453-477 of bulkmarcimport, followed by calls to AddItemBatchFromMarc on
line 479 (this adds the items, even if -insert was specified and the record was
found to exist in koha) and ModBiblioMarc on line 487 (this updates
biblio_metadata).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

--- Comment #3 from Victor Grousset/tuxayo  ---
It works for me. (Apache was restarted, double checked that)

Also tried the test plan from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187#c8

And checked the login pages.

Tested with Apache 2.4.18 on Ubuntu 16.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #14 from Julian Maurice  ---
Patches rebased on master

QA comments in comment 10 still need to be addressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Julian Maurice  changed:

   What|Removed |Added

  Attachment #53609|0   |1
is obsolete||

--- Comment #13 from Julian Maurice  ---
Created attachment 72079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72079=edit
Bug 15774: (QA followup) Make sure that tablename is correctly saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Julian Maurice  changed:

   What|Removed |Added

  Attachment #53608|0   |1
is obsolete||

--- Comment #12 from Julian Maurice  ---
Created attachment 72078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72078=edit
Bug 15774: Add additional fields to order baskets

This also moves the admin page for additional fields for all tables to a
single common screen, and factors out display/input parsing logic.

Test plan:
  1. Create an additional field for a subscription (under Serials -> Add
 subscription fields).
  2. Apply patch.
  3. Visit Additional fields under administration, and verify that
 the field created above still shows under the list for the
 subscription table.
  4. Create at least four fields for aqbasket for each combination of
 searchable/not-searchable and with/without an authorized value.
  5. Create an order basket, and verify that all fields are visible and
 correctly save.
  6. Edit the basket, verifying that changes to these additional fields
 are saved.
  7. Add an order to the basket (contents are irrelevant).
  8. Go to advanced search within acquisitions.
  9. Verify that only the searchable fields show in the form, and that
 their contents may be searched.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20187] New rewrite rules can break custom css

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20259

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20187

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71268|0   |1
is obsolete||

--- Comment #191 from Julian Maurice  ---
Created attachment 72077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72077=edit
Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace

and fix Koha::Acquisition::Order usage everywhere

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71264|0   |1
is obsolete||

--- Comment #187 from Julian Maurice  ---
Created attachment 72073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72073=edit
Bug 11708: Place "Basket groups" menu entry on top of the side navigation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71267|0   |1
is obsolete||

--- Comment #190 from Julian Maurice  ---
Created attachment 72076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72076=edit
Bug 11708: UT: Use DateTime instead of localtime+sprintf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71266|0   |1
is obsolete||

--- Comment #189 from Julian Maurice  ---
Created attachment 72075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72075=edit
Bug 11708: UT: Replace 'ok' by 'is' where appropriate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71265|0   |1
is obsolete||

--- Comment #188 from Julian Maurice  ---
Created attachment 72074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72074=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

In the process, this patch adds 4 new "Koha::Object" modules:
- Koha::Bookseller(s)
- Koha::Basket(s)
- Koha::Basketgroup(s)
- Koha::Order(s)

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268

Victor Grousset/tuxayo  changed:

   What|Removed |Added

Summary|CSS regression  |CSS regression: white gap
   ||on the top of the staff
   ||pages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71262|0   |1
is obsolete||

--- Comment #185 from Julian Maurice  ---
Created attachment 72071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72071=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

This happens when no booksellerid is given.
This patch also adds 4 columns:
- No. of ordered titles
- No. of received titles
- Ordered amount
- Charged amount (amount of received orders)

Add filters to basketgroup tables columns
Show closed date in closed basketgroups tables

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71263|0   |1
is obsolete||

--- Comment #186 from Julian Maurice  ---
Created attachment 72072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72072=edit
Bug 11708: Remove column aqbasketgroups.closed

It is redundant with aqbasketgroups.closeddate

Signed-off-by: Paola Rossi 

Patch updated: use atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71261|0   |1
is obsolete||

--- Comment #184 from Julian Maurice  ---
Created attachment 72070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72070=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71260|0   |1
is obsolete||

--- Comment #183 from Julian Maurice  ---
Created attachment 72069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72069=edit
Bug 11708: Add aqbasketgroups.closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 

Patch updated: Use atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20268] CSS regression

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19981
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20268] New: CSS regression

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268

Bug ID: 20268
   Summary: CSS regression
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victor.grous...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 72068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72068=edit
Screenshot of the new white gap on the top of the page.

There is a new white gap on the top of the page, see screenshot.

git bisect allowed to find that this was caused by commit
3eb50270b1a02fe98cde767ad0240b2943e23321

Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20268

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #1 from Julian Maurice  ---
Created attachment 72067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72067=edit
Bug 20267: Add basic .gitignore

Ignore files generated by ExtUtils::MakeMaker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] New: Add basic .gitignore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Bug ID: 20267
   Summary: Add basic .gitignore
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Ignore the files generated by ExtUtils::MakeMaker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Consistent log message for item insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Consistent log message for item insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

--- Comment #4 from Magnus Enger  ---
Created attachment 72066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72066=edit
Bug 11936 - Consistent log message for item insert

If you use bulkmarcimport.pl to import records with items it looks
like the successfull insert of the record is reported multiple time,
but the second and subsequent "ok" is really related to importing
the item(s).

This patch changes the log message on successfully inserting an item
to match the log message given when inserting an item fails.

To test, the easy way:
- Look at lines 530 and 536 of bulkmarcimport.pl, and note that the
  "op" in those two lines are different
- Apply the patch
- Look at lines 530 and 536 again, and note that the "op" is now
  identical, and that this makes sense, since they are both related
  to the same operation, specifically inserting an item

To test, the hard way
- Have some records with items
- Import the records with bulkmarcimport.pl, and make sure to specify
  the -l option, to create a log of the actions taken
- Look at the log and verify it looks something like this:
  id;operation;status
  1;insert;ok
  1;insert;ok
  2;insert;ok
  2;insert;ok
- Apply this patch and import some more records with items. The log
  should now be similar to this:
  id;operation;status
  1;insert;ok
  1;insertitem;ok
  2;insert;ok
  2;insertitem;ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Consistent log message for item insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

Magnus Enger  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15364] fines and invoices in letter templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15364

Ola Andersson  changed:

   What|Removed |Added

 CC||ola.anders...@ltu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #10 from Alex Arnaud  ---
Hello Nick,

Searching on entire record doesn't work for me. You may replace all occurences
of "value_any" by "value_all" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Consistent log message for item insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

Magnus Enger  changed:

   What|Removed |Added

Summary|Different log messages for  |Consistent log message for
   |biblio insert and item  |item insert
   |insert in bulkmarcimport.pl |
   |log |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20251] SIP checkout broken in master

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|critical|blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Different log messages for biblio insert and item insert in bulkmarcimport.pl log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

--- Comment #3 from Magnus Enger  ---
Or rather op=>"insertitem", to match line 530.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Different log messages for biblio insert and item insert in bulkmarcimport.pl log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

--- Comment #2 from Magnus Enger  ---
This is the code that needs to be changed: 

 527 eval { ( $itemnumbers_ref, $more_errors ) =
AddItemBatchFromMarc( $record, $biblionumber, $biblioitemnumber, '' ); };
 528 if ( $@ ) {
 529 warn "ERROR: Adding items to bib $biblionumber failed:
$@\n";
 530 printlog({id=>$id||$originalid||$biblionumber,
op=>"insertitem",status=>"ERROR"}) if ($logfile);
 531 # if we failed because of an exception, assume that
 532 # the MARC columns in biblioitems were not set.
 533 ModBiblioMarc( $record, $biblionumber, $framework );
 534 next RECORD;
 535 } else {
 536 printlog({id=>$id||$originalid||$biblionumber,
op=>"insert",status=>"ok"}) if ($logfile);
 537 }

It would be clearer if line 536 had something like op=>"insert item"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Different log messages for biblio insert and item insert in bulkmarcimport.pl log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

Magnus Enger  changed:

   What|Removed |Added

Summary|bulkmarcimport.pl reports   |Different log messages for
   |inserted records twice  |biblio insert and item
   ||insert in bulkmarcimport.pl
   ||log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

--- Comment #19 from Marcel de Rooy  ---
For documentation or release:

The patches of this report make that unknown publication/copyright years like
19.. or 19xx or 19XX or 19?? or 19--? (and similar forms) are interpreted as
1900 instead of 0 when saving copyrightdate (MARC21) or publicationyear
(UNIMARC).
These fields are so-called kohafields (fields extracted from the MARC record
and saved additionally in the database for optimization).
Since it is now possible to connect multiple MARC fields to one kohafield, you
can enter something like 1xxx or 201x into MARC21 fields like 260$c or 264$c.
When you save the record, the estimated publication year (1000 or 2010) will be
saved into the corresponding kohafield. This field is used for sorting lists
[virtual shelves] by copyrightdate among others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20266] New: Authentication using Shibboleth - bootstrap

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20266

Bug ID: 20266
   Summary: Authentication using Shibboleth - bootstrap
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: matthias.meusbur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Bug 12046 stated that CAS authentication is too complex to be displayed in a
modal window, therefore authentication is displayed in a separate page when CAS
authentication is enabled.

However, Shibboleth auth is quite the same as CAS auth in terms of complexity,
and yet the modal is still used when Shibboleth authentication is enabled.

This doesn't seem like a consistant behavior to me.

Shouldn't the modal also be disabled when Shibboleth authentication is enabled?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046

Matthias Meusburger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20266

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/