[Koha-bugs] [Bug 20267] Add basic .gitignore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #7 from Maksim Sen --- Ignore comment 6, I accidentally submitted a patch when I tried to sign off your patch. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20267] Add basic .gitignore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 Maksim Sen changed: What|Removed |Added Attachment #72389|0 |1 is obsolete|| Attachment #72389|1 |0 is patch|| --- Comment #6 from Maksim Sen --- Comment on attachment 72389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72389 Hi Maksim, >From 2b8905cb588a594d54843ec5ffeef578d92c8d3c Mon Sep 17 00:00:00 2001 >From: Julian Maurice >Date: Thu, 22 Feb 2018 10:51:27 +0100 >Subject: [PATCH] Bug 20267: Add basic .gitignore > >Ignore files generated by ExtUtils::MakeMaker > >NOTE: Limited scope does not affect files created > by translation utilities > >Signed-off-by: Mark Tompsett >Signed-off-by: Maksim Sen >--- > .gitignore | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitignore > >diff --git a/.gitignore b/.gitignore >new file mode 100644 >index 000..7befa23 >--- /dev/null >+++ b/.gitignore >@@ -0,0 +1,4 @@ >+/MYMETA.* >+/blib/ >+/Makefile >+/pm_to_blib >-- >2.7.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20267] Add basic .gitignore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #5 from Maksim Sen --- Created attachment 72389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72389&action=edit Hi Maksim, here's a possible test plan: 1. Run `perl Makefile.PL` followed by `make` to generate the files MYMETA.json, MYMETA.yml, Makefile, pm_to_blib and directory blib/ 2. See that those files appear in the output of `git status` 3. Apply patch 4. Run `git status` again and see that they are no longer displayed. Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Roch D'Amour changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||roch.dam...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Roch D'Amour changed: What|Removed |Added Attachment #71692|0 |1 is obsolete|| --- Comment #2 from Roch D'Amour --- Created attachment 72388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72388&action=edit Bug 20219: Remove t/smolder_smoke_signal The file is no longer used (is it?) and the project looks dead. Let remove that file. Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20265] Add syspref to hide news published date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Roch D'Amour changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20265] Add syspref to hide news published date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Roch D'Amour changed: What|Removed |Added Attachment #72194|0 |1 is obsolete|| --- Comment #4 from Roch D'Amour --- Created attachment 72387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72387&action=edit This patch adds a system preference that allows a user to toggle the published date for OPAC news items on or off. Test plan: 1. Login to the staff client, navigate to Tools → News and create some news articles that have their display location set to “All”. 2. Navigate to the OPAC and notice that the news items you added have a line at the bottom reading “(published on mm/dd/)”. 3. Apply the patch. 4. Enter the instance user session - $ sudo koha-shell kohadev 5. Change into your git directory - $ cd kohaclone 6. Update the database - $ perl installer/data/mysql/updatedatabase.pl 7. Exit the instance user session and restart Apache, Memcached and Plack - $ restart_all 8. Open the staff client and navigate to Koha administration→ Global system preferences, click the “OPAC” tab on the left and notice a new option “OPACNoNewsDate” under the “Features” heading. 9. Select “Don’t show”, save and notice that the published date of news items on the OPAC is now suppressed. 10. Select “Show” and notice that the published date of news items on the OPAC is visible once more. Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20265] Add syspref to hide news published date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Roch D'Amour changed: What|Removed |Added CC||roch.dam...@inlibro.com --- Comment #3 from Roch D'Amour --- You patch's author field says "Your full Name ". You might want to check your git config and make sure it is configured properly :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20052] Add Reports object class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Maksim Sen changed: What|Removed |Added Attachment #70845|0 |1 is obsolete|| --- Comment #3 from Maksim Sen --- Created attachment 72386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72386&action=edit Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Signed-off-by: Claire Gravely Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Roch D'Amour changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||roch.dam...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Roch D'Amour changed: What|Removed |Added Attachment #72340|0 |1 is obsolete|| --- Comment #2 from Roch D'Amour --- Created attachment 72385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72385&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20323] Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour changed: What|Removed |Added CC||roch.dam...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20323] Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20323] Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour changed: What|Removed |Added Attachment #72347|0 |1 is obsolete|| --- Comment #2 from Roch D'Amour --- Created attachment 72384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72384&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 Roch D'Amour changed: What|Removed |Added CC||roch.dam...@inlibro.com --- Comment #2 from Roch D'Amour --- Hi Jonathan Do you have a test plan for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Maksim Sen changed: What|Removed |Added CC||maksim@inlibro.com --- Comment #2 from Maksim Sen --- Hey Marcel, When I tried to get to the links you put out, I got to an Error 404 in Koha (after changing the server and bibnumbers of course), with and without the patch. I accessed the links directly, do I need to access your through another page? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marjorie Barry-Vila changed: What|Removed |Added Resolution|FIXED |--- CC||marjorie.barry-vila@collect ||o.ca Status|RESOLVED|REOPENED --- Comment #25 from Marjorie Barry-Vila --- Hi, In 17.05, i have same error message on koha/tools/manage-marc-import.pl Software error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F298826" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "(SQTD)191897"") from diag-set 'ZOOM' I understand that patch is just for search on authorities/authorities-home.pl ? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #61 from Marco Moreno --- Fair enough - trust your judgment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #60 from Tomás Cohen Arazi --- (In reply to Marco Moreno from comment #59) > Couldn't it be done in once in a common library that is used everywhere, > like /usr/share/koha/bin/kohalib.pl? > > Sorry, I really don't know much about Koha's architecture and I trust you've > studied this more than I have. I understand the kohalib.pl approach, but I think it is too hacky and I don't think we should use it at all. So a solution there I wouldn't agree. Also, not all CLI scripts written in perl use it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Nick Clemens changed: What|Removed |Added CC||tomasco...@gmail.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #1 from Barton Chittenden --- Here's data from a production system that I think would be adversely affected if cleanup_database.pl --fees 1 was run Query: SELECT a.*, credit.amount AS 'credit amount', credit.amountoutstanding 'credit outstanding', credit.description 'credit description', credit.accounttype AS 'credit type', debit.amount AS 'debit amount', debit.amountoutstanding 'debit outstanding', debit.description 'debit description', debit.accounttype AS 'debit type' FROM account_offsets a INNER JOIN accountlines credit on a.credit_id = credit.accountlines_id INNER JOIN accountlines debit on a.debit_id = debit.accountlines_id WHERE credit.amountoutstanding = 0 and debit.amountoutstanding > 0 ORDER BY a.id desc limit 1 *** 1. row *** id: 4214002 credit_id: 1708799 debit_id: 1708796 type: Payment amount: 0.00 created_on: 2018-03-02 11:51:05 credit amount: -5.00 credit outstanding: 0.00 credit description: credit type: Pay debit amount: 0.50 debit outstanding: 0.50 debit description: I survived the eruption of Mount St. Helens, 1980 / 02/28/2018 23:59 debit type: F In this case, credit outstanding, i.e. accountlines.amountoutstanding where accountlines_id = 1708799 is 0, so that row would be deleted by purge_zero_balance_fees, even though it's still linked to by account_offsets, and debit outstanding is not 0. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20325] New: C4::Accounts::purge_zero_balance_fees does not check account_offsets.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
Bug ID: 20325
Summary: C4::Accounts::purge_zero_balance_fees does not check
account_offsets.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
purge_zero_balance_fees is used in cleanup_database.pl to determine which fees
can be cleaned up.
It uses a simple SQL query to determine which rows in accountlines need to be
removed:
463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }
The function comes with the following warning:
451 B Because fines and payments are not linked in accountlines, it
is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.
This was a reasonable solution prior to the addition of account_offsets in
17.11. The problem now is that rows in accountlines which are linked as credits
in accountlines will *always* have amountoutstanding marked as 0. These are
linked to debits via account_offsets. purge_zero_balance_fees will delete
credits and leave rows in account_offsets which link to deleted credits.
Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may
have all of their credits removed without warning.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing records from a staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Sandre Cunha changed: What|Removed |Added CC||cu...@monterey.org --- Comment #2 from Sandre Cunha --- This is a serious issue for Acquisitions, as one can easily go over budget quickly with out being aware of it. It makes no sense that the warning is not triggered when you save a group of orders as well as an individual item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #36 from Kyle M Hall --- Created attachment 72381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72381&action=edit Bug 4078: Pass with_symbol to module The template plugin did not pass the with_symbol flag to the module and so was not taken into account Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #34 from Kyle M Hall --- Created attachment 72379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72379&action=edit Bug 4078: Update DB entry - add new column currency.p_sep_by_space Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Kyle M Hall changed: What|Removed |Added Attachment #71118|0 |1 is obsolete|| Attachment #71119|0 |1 is obsolete|| Attachment #71120|0 |1 is obsolete|| Attachment #71121|0 |1 is obsolete|| Attachment #71122|0 |1 is obsolete|| Attachment #71123|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall --- Created attachment 72378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72378&action=edit Bug 4078: DBIC Schema changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #37 from Kyle M Hall --- Created attachment 72382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72382&action=edit Bug 4078: Add the ability to display and configure the symbol for prices The symbol of currencies are not displayed (or not correctly) so far. This patch set adds the ability to configure the display of the symbol (with or without a whitespace between the symbol and the price). Test plan: 1. Execute the update DB entry, go to the currency admin page and tick the new "Space separation between symbol and value" checkbox 2. Add a fine to a patron and use their credentials to login at the OPAC 3. You should see the "$ 42 due fines and charges" info in the dashboard 4. Untick the new checkbox to remove the space and reload the OPAC main page. => The space should not be longer displayed ($42) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #38 from Kyle M Hall --- Created attachment 72383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72383&action=edit Bug 4078: Add a new test Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #35 from Kyle M Hall --- Created attachment 72380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72380&action=edit Bug 4078: Add the checkbox to the UI Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing records from a staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Viccy Kemp changed: What|Removed |Added CC||victoria.kemp@flower-mound. ||com --- Comment #1 from Viccy Kemp --- This would seem to be a problem that would cause issues on many different levels. Anyone working on it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #59 from Marco Moreno --- Couldn't it be done in once in a common library that is used everywhere, like /usr/share/koha/bin/kohalib.pl? Sorry, I really don't know much about Koha's architecture and I trust you've studied this more than I have. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall changed: What|Removed |Added Attachment #72376|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 72377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72377&action=edit Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall changed: What|Removed |Added Assignee|je...@bywatersolutions.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 --- Comment #2 from Kyle M Hall --- Created attachment 72376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72376&action=edit Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #58 from Tomás Cohen Arazi --- (In reply to Marco Moreno from comment #57) > Hmmm...I'm now reconsidering this and wonder if option #3 is really the best > solution by removing '.' from @INC. > > You made a good point about /tmp being a concern. This, plus the fact that > they have removed '.' from @INC in recent versions of Perl, has convinced me > that having '.' in @INC is generally a very bad idea and a major security > concern. > > Therefore, I want to propose revisiting comment #40 which removes '.' from > @INC in a common library early in the bootstrapping process. This > effectively undoes the "feature" added in Perl 5.18 and removed in Perl > 5.26. Additionally, this prevents exploits that attempt to insert '.' via > PERL5LIB. I considered that option. But we would need to do it on every script, and we would also be changing the current behaviour. Someone might be using their own lib (or version of some lib) on purpose and we'd be breaking them. So, for the general user base, we should stick with the cleaner solution IMHO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #57 from Marco Moreno --- Hmmm...I'm now reconsidering this and wonder if option #3 is really the best solution by removing '.' from @INC. You made a good point about /tmp being a concern. This, plus the fact that they have removed '.' from @INC in recent versions of Perl, has convinced me that having '.' in @INC is generally a very bad idea and a major security concern. Therefore, I want to propose revisiting comment #40 which removes '.' from @INC in a common library early in the bootstrapping process. This effectively undoes the "feature" added in Perl 5.18 and removed in Perl 5.26. Additionally, this prevents exploits that attempt to insert '.' via PERL5LIB. It is a single line of code, does nothing if '.' doesn't exist in @INC, and doesn't require modifying crons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Owen Leonard changed: What|Removed |Added Attachment #72371|0 |1 is obsolete|| --- Comment #69 from Owen Leonard --- Created attachment 72375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72375&action=edit Bug 19522: Label creator: Batches: make "Export Labels" translatable Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Kyle M Hall changed: What|Removed |Added Attachment #72365|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 72374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72374&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Kyle M Hall changed: What|Removed |Added Attachment #72368|0 |1 is obsolete|| Attachment #72369|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 72372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72372&action=edit Bug 17717: Add a --chdir option switch for koha-foreach Until Perl 5.26, the current directory is added to @INC when running a Perl script [1]. Having the current directory in @INC means it can be tried to be traversed when performing a lib lookup. Since version 5.18, Perl dies when it finds an unreadable directory (permissions) in @INC that needs to be traversed. This behaviour won't change because Perl devs consider it an enhancement to security. [2] Because of this, we need to make sure our scripts are ran **from** a directory in which they have read permissions. Ths patch adds a --chdir option switch to the **koha-foreach** wrapper script, that makes the inner shells/scripts to be ran within the Koha instance's user home directory. The change is trivial and should be QAed easily. I tested this on a prod server: - Create a /tmp/test.pl file containing: use Modern::Perl; use Cwd; my $dir = getcwd; warn $dir; 1; A) then create a cronjob entry to run it using koha-foreach: (in /etc/cron.d/test): 1/* * * * * root koha-foreach perl /tmp/test.pl - Once I noticed the cronjob ran, I used mutt to read the emails in the root user. => FAIL: ... Subject: Cron koha-foreach --enabled perl /tmp/test.pl "/root" "/root" "/root" "/root" "/root" ... B) I then used the patched koha-foreach with different results: => SUCCESS: ... Subject: Cron /root/koha-foreach --chdir --enabled perl /tmp/test.pl "/var/lib/koha/acaderc" "/var/lib/koha/agro" "/var/lib/koha/anc" "/var/lib/koha/arico" "/var/lib/koha/artes" ... So this patch's approach works. But... C) master's koha-foreach seems to work just the same... I think it is because of my previous attempt to fix this by using sudo in koha-shell. So I think environmental conditions affect the behaviour (which shell is configured for cron, sudo configuration, etc). In conclusion, I think we should go ahead with this patch as it will solve peoples issues, and it is a right solution (option #5 on the list) to this Perl behaviour change. It doesn't cover other commands, but followup patches could do. I avoided /tmp as it is writable by any user... so it is an easy path for both exploiting by replacing some lib, and also because the existence of an unreadable dir that the interpreter could try to traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same error, and I assume people know what they are putting on the instance's dir, at least it will be easier to track). A followup patch takes care of making the cronjobs use --chdir when calling koha-foreach [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html [2] https://rt.perl.org/Public/Bug/Display.html?id=123795 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #56 from Kyle M Hall --- Created attachment 72373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72373&action=edit Bug 17717: Make cronjobs using koha-foreach use --chdir In order to patch production sites we need to adjust the shipped cronjobs so they are called with the --chdir option switch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #72357|0 |1 is obsolete|| --- Comment #68 from Victor Grousset/tuxayo --- Created attachment 72371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72371&action=edit Bug 19522: Label creator: Batches: make "Export Labels" translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What|Removed |Added Attachment #72367|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 72370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72370&action=edit Bug 19191: Remove need for bug 19966 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi changed: What|Removed |Added Summary|Can't locate|Make koha-plack run Starman |Mojolicious/Plugin/Koha/RES |from the instance's |T/Plugin/Pagination.pm |directory |breaks opac and staff | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tomás Cohen Arazi changed: What|Removed |Added Summary|process_message_queue.pl: |Fix broken cronjobs due to |Can't locate|permissions of the current |Authen/CAS/Client/Response/ |directory |Failure.pm | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tomás Cohen Arazi changed: What|Removed |Added Attachment #63677|0 |1 is obsolete|| --- Comment #53 from Tomás Cohen Arazi --- Created attachment 72368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72368&action=edit Bug 17717: Add a --chdir option switch for koha-foreach Until Perl 5.26, the current directory is added to @INC when running a Perl script [1]. Having the current directory in @INC means it can be tried to be traversed when performing a lib lookup. Since version 5.18, Perl dies when it finds an unreadable directory (permissions) in @INC that needs to be traversed. This behaviour won't change because Perl devs consider it an enhancement to security. [2] Because of this, we need to make sure our scripts are ran **from** a directory in which they have read permissions. Ths patch adds a --chdir option switch to the **koha-foreach** wrapper script, that makes the inner shells/scripts to be ran within the Koha instance's user home directory. The change is trivial and should be QAed easily. I tested this on a prod server: - Create a /tmp/test.pl file containing: use Modern::Perl; use Cwd; my $dir = getcwd; warn $dir; 1; A) then create a cronjob entry to run it using koha-foreach: (in /etc/cron.d/test): 1/* * * * * root koha-foreach perl /tmp/test.pl - Once I noticed the cronjob ran, I used mutt to read the emails in the root user. => FAIL: ... Subject: Cron koha-foreach --enabled perl /tmp/test.pl "/root" "/root" "/root" "/root" "/root" ... B) I then used the patched koha-foreach with different results: => SUCCESS: ... Subject: Cron /root/koha-foreach --chdir --enabled perl /tmp/test.pl "/var/lib/koha/acaderc" "/var/lib/koha/agro" "/var/lib/koha/anc" "/var/lib/koha/arico" "/var/lib/koha/artes" ... So this patch's approach works. But... C) master's koha-foreach seems to work just the same... I think it is because of my previous attempt to fix this by using sudo in koha-shell. So I think environmental conditions affect the behaviour (which shell is configured for cron, sudo configuration, etc). In conclusion, I think we should go ahead with this patch as it will solve peoples issues, and it is a right solution (option #5 on the list) to this Perl behaviour change. It doesn't cover other commands, but followup patches could do. I avoided /tmp as it is writable by any user... so it is an easy path for both exploiting by replacing some lib, and also because the existence of an unreadable dir that the interpreter could try to traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same error, and I assume people know what they are putting on the instance's dir, at least it will be easier to track). A followup patch takes care of making the cronjobs use --chdir when calling koha-foreach [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html [2] https://rt.perl.org/Public/Bug/Display.html?id=123795 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20324] New: Fund Warnings do not occur when importing records from a staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Bug ID: 20324 Summary: Fund Warnings do not occur when importing records from a staged file Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When using the Warning feature on funds (whether that is a $ amount of percentage) in the Acquisition module - these warnings do not display a warning when importing records from a staged file. Koha does warn the user when using other avenues upon adding items to an order, just not with staged files. /addorderiso -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #54 from Tomás Cohen Arazi --- Created attachment 72369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72369&action=edit Bug 17717: Make cronjobs using koha-foreach use --chdir In order to patch production sites we need to adjust the shipped cronjobs so they are called with the --chdir option switch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18345] Add a more ES based query builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 --- Comment #5 from Nick Clemens --- No, it shouldn't -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18345] Add a more ES based query builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 Nick Clemens changed: What|Removed |Added Blocks|14567 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Depends on|18345 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 [Bug 18345] Add a more ES based query builder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Nick Clemens --- That works for me, Jonathan or Katrin, any input? If it sounds good I will try to work on that or you can feel free Julian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #13 from Kyle M Hall --- Created attachment 72367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72367&action=edit Bug 19191: Remove need for bug 19966 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What|Removed |Added Attachment #70471|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 72366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72366&action=edit Bug 19191: Add ability to email receipts for account payments and write-offs Some libraries are paperless and require all payment receipts to be emailed. Koha should give libraries the option to send email receipts if a patron has an email address. If a notice for the type of "credit" exists ( payment or writeoff ), then an email receipt will be sent. These notices only support Template Toolkit syntax. Test Plan: 1) Apply this patch and dependencies 2) Add the two new notices, you can find them in installer/data/mysql/en/mandatory/sample_notices.sql 3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF 4) Find or create a patron with an email address that owes some amount of money 5) Make a payment for one or more fees 6) Note a new email is queued for the patron 7) Make a writeoff for one or more fees 8) Note a new new email is queued for the patron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #52 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #48) > (In reply to Marco Moreno from comment #47) > > Understanding the problem is necessary to determine the best solution. > [...] > > 5. Change the current directory to one that is readable by modifying all > > code that performs a "sudo -u". This may be as simple as adding "cd /tmp" > > at the beginning of /usr/sbin/koha-foreach and /usr/sbin/koha-rebuild-zebra. > > Possibly the best solution for now. > > > > Option #5 seems like the best one for now. It is a clear, one-line solution > > that doesn't require modifying any crons. > > I would agree. Put cd /tmp very close to the sudo -u. Adding it in cron is > more confusing. > Clear argumentation imo! If there's a /tmp/Koha directory, without read permissions for the instance's user it will still fail. I think we should jump into the instance's home directory and I'm providing a patch to do so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20245] Wrong language code for Slovak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #2 from Petr Havel --- (In reply to Jonathan Druart from comment #1) > Hola Petr, Can you provide a patch please? > > https://wiki.koha-community.org/wiki/Submitting_A_Patch Sorry, I can't make patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #51 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #50) > Can anyone take care of this one? I'm taking care of it. I'm working on the same approach as bug 19546. Adding a --chdir option switch to koha-foreach. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #9 from Julian Maurice --- (In reply to Nick Clemens from comment #8) > I added it only for old reports, if a library has been using a report with > duplicated inputs this will be a change in behavior and may be > unexpected/unwanted. > > Am happy to reconsider or explore alternate options, this seemed the > simplest at the time I hadn't thought about old reports. It makes sense... but what do you think about renaming all parameters (appending a number for instance) of existing reports in an updatedatabase script ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18345] Add a more ES based query builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 --- Comment #4 from Julian Maurice --- So, it does not really block bug 14567 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 72365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72365&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18345] Add a more ES based query builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 --- Comment #3 from Nick Clemens --- Currently this is just a placeholder for some code that was lost at some point, we should pursue in the future, but i think other issues are ahead of this. Currently we use the built in ES query parser for most things, but in the future it would be nice to leverage some of the specific ES search endpoints directly for more refined searches. Some of that is done here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Where we need to use more specific searching to mimic what we do in zebra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #25 from Kyle M Hall --- Created attachment 72359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72359&action=edit Bug 19160: Move duplicated code to its own private subroutine Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #29 from Kyle M Hall --- Created attachment 72363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72363&action=edit Bug 19160: Remove tab characters causing qa script to fail Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #30 from Kyle M Hall --- Created attachment 72364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72364&action=edit Bug 19160: Add POD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #26 from Kyle M Hall --- Created attachment 72360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72360&action=edit Bug 19160: Move the code from controller to C4::Auth_with_cas Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #27 from Kyle M Hall --- Created attachment 72361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72361&action=edit Bug 19160: Isolate CAS code into its own module Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #28 from Kyle M Hall --- Created attachment 72362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72362&action=edit Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What|Removed |Added Attachment #71831|0 |1 is obsolete|| Attachment #71832|0 |1 is obsolete|| Attachment #71833|0 |1 is obsolete|| Attachment #71834|0 |1 is obsolete|| Attachment #71835|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall --- Created attachment 72358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72358&action=edit Bug 19160: CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #8 from Nick Clemens --- I added it only for old reports, if a library has been using a report with duplicated inputs this will be a change in behavior and may be unexpected/unwanted. Am happy to reconsider or explore alternate options, this seemed the simplest at the time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #67 from Victor Grousset/tuxayo --- Thanks paxed, I noticed this string but though that I wasn't translatable due to the Grey Box lib. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #66 from Victor Grousset/tuxayo --- Created attachment 72357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72357&action=edit Bug 19522: Label creator: Batches: make "Export Labels" translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #14 from Tomás Cohen Arazi --- I managed to reproduce. This is the same issue introduced by Perl 5.18 we face with cronjobs. I'll provide a patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Is the new option really necessary ? I can't imagine a use case where someone would like to not use this feature. And if users really want to repeat themselves they can just rename one of the parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18345] Add a more ES based query builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #2 from Julian Maurice --- What is the status of this bug ? Waiting for sign-off ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #16 from Marcel de Rooy --- [Without patch] Three items (CPL MPL RMA) 2 record level patron A and item level from patron B (CPL) Checkin CPL item at RMA Confirm Waiting OK Checkin this item again and Cancel Finally reproduced the error: Second patron A hold became Item level (Bug) Checkin again, confirm Checkin and cancel What happened? Priority last hold = 1. Transfer created. No message to staff. (Bug: transit should be a T hold?) [With patch] Three items 2 record level for patron A 1 item level for patron B on CPL item Goto RMA Checkin CPL item, confirm for patron A Waiting So far so good. Checkin again and cancel. Second record level hold at 1. This cancel created no transfer. No message. (Behavior change?) Checkin again, confirm. Waiting OK Checkin again, cancel. Last item level hold at 1. No transfer. No message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #15 from Marcel de Rooy --- Squashed both patches. Follow-up may need to be moved. Tested this quite a bit. Hard to reproduce at first. (Alternative test plan in next comment.) Failing QA because this patch has side-effects when you cancel a hold from the confirm hold popup. Before we called GetOtherReserves and now we dont. This changes behavior. Also I am wondering if the passed patron etc. at lines 160/170 makes any sense. If you confirm the transfer or cancel, you come back to the default returns.pl form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What|Removed |Added QA Contact|josef.mora...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #19 from Kyle M Hall --- Created attachment 72353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72353&action=edit Bug 19933: Remove patronflags - tricky ones Here we are, patronflags is used in a couple of places where (almost) all flags were really useful: C4::SIP::ILS::Patron->new and circulation.pl This patch only deal with the circulation code as I am not convident enough with SIP code. The change does not seems trivial because of the complexity of the existing code, but the logic is the same. We send a variable to the template depending on the situation of the patron. I guess only code eyes ball could catch issue in this patch quickly. Maybe we need to find a good place in a Koha module to move this code and provide code coverage (especially when C4::SIP::ILS::Patron will reuse it). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #20 from Kyle M Hall --- Created attachment 72354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72354&action=edit Bug 19933: (follow-up) Remove patronflags - easy ones Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #22 from Kyle M Hall --- Created attachment 72356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72356&action=edit Bug 19933: Fix typo in template plugin name Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #21 from Kyle M Hall --- Created attachment 72355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72355&action=edit Bug 19933: Move instantiation of in deletemem.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #17 from Kyle M Hall --- Created attachment 72351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72351&action=edit Bug 19933: Remove patronflags - In CanBookBeIssued The change is trivial here, we only want to pass gonenoaddress, lost and is_debared to the template. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #18 from Kyle M Hall --- Created attachment 72352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72352&action=edit Bug 19933: Remove patronflags - easy ones This patch replaces the easy occurrences of patronflags. These calls only need the CHARGES->amount value, that is the non issues charges. Luckily we now have a Koha::Account->non_issues_charges that deal with that. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Kyle M Hall changed: What|Removed |Added Attachment #72004|0 |1 is obsolete|| Attachment #72005|0 |1 is obsolete|| Attachment #72006|0 |1 is obsolete|| Attachment #72007|0 |1 is obsolete|| Attachment #72095|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 72350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72350&action=edit Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl There is oldamound/amountold variable that is sent to the template but never used later. Let remove it now to avoid useless replacement. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What|Removed |Added Attachment #72210|0 |1 is obsolete|| Attachment #72211|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 72348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72348&action=edit Bug 18958 - If patron has multiple record level holds on one record transferring first hold causes next hold to become item level Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places to record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. Test Plan: 1. Create and use a patron that can place multiple record level holds per record 2. Create a record with X items, each at a different library 3. Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4. Rebuild the holds queue 5. Check in LibraryA's copy as LibraryA and confirm the hold 6. Revisit request.pl for the record, notice the next hold in line is now item-specific 7. Attempt to place another hold for your patron, notice that it requires an item-specific hold 8. Apply this patch 9. Repeat steps 1-4 10. Revisit request.pl for the record, notice the next hold in line has *not* become item-specific Signed-off-by: Kyle M Hall Signed-off-by: Jason Robb Signed-off-by: Josef Moravec Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of the template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #14 from Marcel de Rooy --- Created attachment 72349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72349&action=edit Bug 18958: (Follow-up) Pass patron to template for confirm hold Removing the FIXME. Trivial fix. Not sure where to put it; can be moved on its own. Test plan: Confirm a hold and verify that patron details are shown in popup. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20323] Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Depends on||18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20323] Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 --- Comment #1 from Josef Moravec --- Created attachment 72347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72347&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20323] Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Josef Moravec changed: What|Removed |Added Blocks||20323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 [Bug 20323] Batch patron modification tool broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
