[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #136 from Josef Moravec --- (In reply to David Bourgault from comment #135) > Forgot to mention : t/db_dependent/TestBuilder.t does fail with error > message "Unknown type time for open_hour in DiscreteCalendar at > /inlibro/git/koha-master-dev-inlibro/t/lib/TestBuilder.pm line 341." > > I'm not sure what to do with this. Isn't 'time' a standard datatype for all > SQL implementations? > > Advice welcome. It is because test builder does not know the data type "time", look into t/lib/TestBuilder.pm line 358 (sub _gen_type) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20417] Remove OpacCloud system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- According to Hea 83 libraries are using this feauture. Maybe these questions would better be asked on the mailng list? libraries won't see the bug reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #3 from M. Tompsett --- Haven't written the tests yet, so feel free to take it, write them, and ask for sign off. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Assignee|gmcha...@gmail.com |mtomp...@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #2 from M. Tompsett --- Created attachment 72902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72902&action=edit Bug 12159: Move borrower_add_additional_fields to Koha::Patron The same function was effectively coded twice. It was removed from members/pay.pl and members/paycollect.pl and placed in Koha/Patron.pm instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357
--- Comment #16 from M. Tompsett ---
Comment on attachment 72296
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72296
Bug 16357: (follow-up) Log and timestamp fatal errors
Review of attachment 72296:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16357&attachment=72296)
-
::: debian/templates/plack.psgi
@@ +41,5 @@
> use Log::Log4perl qw(:easy);
> Log::Log4perl->easy_init({ level => $WARN, utf8 => 1 });
> my $logger = Log::Log4perl->get_logger(); # use the default logger style
> +$SIG{__WARN__} = sub { $logger->warn(shift) };
> +$SIG{__DIE__} = sub { $logger->fatal(shift) };
I prefer using my ($message) = @_; because I believe it is less floody prone,
though I could be wrong. And while I value vertical space too, I would have
left the __WARN__ code unchanged, and mirrored that layout for __DIE__.
::: misc/plack/koha.psgi
@@ +9,5 @@
> use Log::Log4perl qw(:easy);
> Log::Log4perl->easy_init({ level => $WARN, utf8 => 1 });
> my $logger = Log::Log4perl->get_logger(); # use the default logger style
> +$SIG{__WARN__} = sub { $logger->warn(shift) };
> +$SIG{__DIE__} = sub { $logger->fatal(shift) };
If bug 20393 is valid, this change is unnecessary.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #7 from M. Tompsett --- Why not refactor to a hash reference parameter format? It makes adding/removing parameters much easier. Also, when a function starts to break three parameters, it probably should use a hashref. And lastly, it's a really small refactor, and we do have some coding guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19660] Set borrower password on first login from self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 --- Comment #6 from M. Tompsett --- Created attachment 72901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72901&action=edit Bug 19660: Follow up to fix password field on the registration page This is a follow up patch to fix the password field on the registration complete page. Please upload this patch along with the previous version :) Test plan: 1. Apply this patch 2. The password field has the pregenerated password if the syspref is enabled 3. Before the patch the password was displayed on the screen in a span tag Signed-off-by: Laurence Rault Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19660] Set borrower password on first login from self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 M. Tompsett changed: What|Removed |Added Attachment #70596|0 |1 is obsolete|| Attachment #70727|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 72900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72900&action=edit Bug 19660: Set password after self registration Test plan: 1. Enable PatronSelfRegistration 2. Add a PatronSelfRegistrationDefaultCategory too 3. In OPAC register a user 4. Without patch after hitting submit, password is displayed onscreen 5. After applying patch, password is changed afterwards by sending a email 6. Note how primary email is required Notes - Email is now required for this to work since a unique key was needed for password-recovery.pl to work - A password is randomly generated for the user Signed-off-by: Laurence Rault Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19660] Set borrower password on first login from self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19660] Set borrower password on first login from self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #4 from M. Tompsett --- These system preferences need setting from a base kohadevbox: OpacResetPassword - Allowed -- otherwise you get almost done, and then it won't let you check it, because reset isn't allowed. PatronSelfRegistration - Allow -- otherwise, you can't even start. PatronSelfRegistrationDefaultCategory - Anything valid, otherwise you may have a crash somewhere. PatronSelfRegistrationPrefillForm -- MMmmm... something isn't right with this now. It works as expected, but something about this leaves a bad taste in my mouth. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20419] Current location not updated correctly on the return of a reserved item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20419] Current location not updated correctly on the return of a reserved item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 --- Comment #1 from Alex Buckley --- Created attachment 72899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72899&action=edit Bug 20419 - Removed updating of holdingbranch in ModItemTransfer() The call to ModItem to update the holdingbranch has been removed from the ModItemTransfer function in C4/Items.pm this is because the holdingbranch should only be changed when the item is checked in at the destination branch not whilst it is in transit. Test plan: 1. Ensure the system preference AutomaticItemReturn is set to 'Dont' 2. Place a reserve on an item to be picked up at branch b 3. Check out the item to a different patron 4. Check the item back in to branch a 5. Select 'Confirm hold and transfer' button in the modal box that appears 6. Notice that the current location of the item visible on the item tab of the detail.pl page of the record is set as branch b even though the item is in transit 7. Apply patch 8. Restart apache2, memcached and plack (if it is enabled) 9. Repeat steps 1, 2, 3, 4, 5 and notice that the current location is set to branch a 10. Check the item in at branch b and notice that the current location of the item is now branch b Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #47 from David Cook --- (In reply to David Cook from comment #45) > Another unrelated note... I wonder if there's anything we could do to help > people use TLS for email. Alas, Let's Encrypt doesn't provide certificates > for email, so that doesn't help. I think maybe it is all up to the sysadmin > on the final system to set that up... > > But that's a layer of security that I could see all libraries using quite > readily. Ohhh... looks like I misunderstood the Let's Encrypt certificate thing: https://community.letsencrypt.org/t/how-to-get-certificate-for-email-server/50702/2 So we could be using TLS for email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15439] Current Location incorrect when item in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20419 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20419] New: Current location not updated correctly on the return of a reserved item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Bug ID: 20419 Summary: Current location not updated correctly on the return of a reserved item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: alexbuck...@catalyst.net.nz Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com At present when a reserved item is returned to a library branch which is not the branch set as the pickup location for the reserve then after clicking the 'Confirm hold and transfer' button on the return modal box the items current location is set to the pickup location even though the item is actually in transit. The current location of the item should be set as the branch that the item was returned to whilst in transit and only change to the pickup location when it checked in at the pickup location branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #2 from Liz Rea --- I don't think it's too much. Plugins enable unverified code to be run, I'm for belt and bracers all the way here. I *want* people to have to talk to a sysadmin before enabling plugins. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18661] Make "Replace only included patron attributes" default on patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jon Knight changed: What|Removed |Added CC||j.p.kni...@lboro.ac.uk --- Comment #12 from Jon Knight --- Just a random thought to throw into this: would it be worth creating database views to replicate the old tables based on the new ones? That way if any installations have pre-existing reports that use the old tables in their queries, they will still continue to work. For example something like this: CREATE VIEW old_issues AS SELECT * FROM issues WHERE deleted_at IS NOT NULL; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Roch D'Amour changed: What|Removed |Added Attachment #72706|0 |1 is obsolete|| --- Comment #68 from Roch D'Amour --- Created attachment 72898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72898&action=edit Bug 12747 - Add extra column in Z3950 search This is a complete squash of previous patches, with additional code quality improvments following M. Tompsett's feedback. Squashing was done (as suggested) because many lines add be added and subsequently deleted, which made for confusing patches. New changes: * Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_ variable is no longer used (at all), and the split() routine is used. * t/db_dependent/Breeding.t now uses the mocked preference logic to avoid sysprefs being affected. Functionality and test plan have not changed. -- This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields Sponsored-by: CCSR (https://ccsr.qc.ca) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Roch D'Amour changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Roch D'Amour changed: What|Removed |Added Attachment #69297|0 |1 is obsolete|| --- Comment #67 from Roch D'Amour --- Created attachment 72897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72897&action=edit Bug 12747 - Switch date field on marc flavour Amended _add_rowdata to check only for the marcflavour-appropriate date field. This makes the test pass without noise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Roch D'Amour changed: What|Removed |Added Attachment #68215|0 |1 is obsolete|| --- Comment #66 from Roch D'Amour --- Created attachment 72896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72896&action=edit Bug 12747 - Missing use in tests Adds missing `use t::lib::Mocks ...` to Breeding.t Tests should now pass correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12020] Allow translating label-edit-batch hardcoded strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 M. Tompsett changed: What|Removed |Added Attachment #72730|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 72895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72895&action=edit Bug 12020: Allow translating label-edit-batch hardcoded strings Move the hardcoded error strings in the batch label edit into the template, so they can be translated. Test plan: 1) Apply patch 2) Go to Home -> Tools -> Label edit 3) Create a new batch with some items in it 4) Try to trigger any of the errors, check that the error messages look correct 5) Update a language xx-YY 5) Check that the error messages show up in xx-YY-staff-prog.po Signed-off-by: Pasi Kallinen NOTE: compared po's of master and this with patch. Strings showed up. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12020] Allow translating label-edit-batch hardcoded strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #46 from Martha Fuerst --- Huntsville-Madison County is interested in this as an added layer of security. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520
--- Comment #5 from M. Tompsett ---
Comment on attachment 72819
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72819
Bug 19520: Update database
Review of attachment 72819:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19520&attachment=72819)
-
:::
installer/data/mysql/atomicupdate/Bug19520_Add_more_information_to_rotating_collections.perl
@@ +5,5 @@
> +$dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2`
> FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE
> SET NULL ON UPDATE CASCADE");
> +
> +$dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime default
> NULL AFTER createdBy" );
> +
> +$dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn datetime
> default NULL AFTER createdOn" );
These 4 do's should be encapsulated by !column_exists checks.
@@ +10,5 @@
> +
> +# or perform some test and warn
> +# if( !column_exists( 'biblio', 'biblionumber' ) ) {
> +#warn "There is something wrong";
> +# }
And you don't need comments. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #4 from Victor Grousset/tuxayo --- caused by Bug 18471 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mtomp...@hotmail.com --- Comment #10 from M. Tompsett --- Only concern is if the authorization isn't attempted after it expires, the oauth_access_tokens record will lay in the table indefinitely. But works nicely otherwise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 M. Tompsett changed: What|Removed |Added Attachment #72886|0 |1 is obsolete|| --- Comment #7 from M. Tompsett --- Created attachment 72892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72892&action=edit Bug 20402: Implement OAuth2 authentication for REST API It implements only the "client credentials" flow with basic scopes support (only one is defined, "patrons.read"). API Clients are defined in $KOHA_CONF. Test plan: 0. Install Net::OAuth2::AuthorizationServer 0.16 1. In $KOHA_CONF, add an element under : $CLIENT_ID $CLIENT_SECRET patrons.read 2. Apply patch, run updatedatabase.pl and reload starman 3. Install Firefox extension RESTer [1] 4. In RESTer, go to "Authorization" tab and create a new OAuth2 configuration: - OAuth flow: Client credentials - Access Token Request Method: POST - Access Token Request Endpoint: http://$KOHA_URL/api/v1/oauth/token - Access Token Request Client Authentication: Credentials in request body - Client ID: $CLIENT_ID - Client Secret: $CLIENT_SECRET - Scopes: patrons.read 5. Click on the newly created configuration to generate a new token (which will be valid only for an hour) 6. In RESTer, set HTTP method to GET and url to http://$KOHA_URL/api/v1/patrons then click on SEND It should return 200 OK with the list of patrons 7. Remove or change the from $KOHA_CONF (reload starman & memcached) and see that you cannot generate a new token. Then reset the scope to its initial value 8. Edit api/v1/swagger/paths/patrons.json, locate 'x-koha-scopes' (2 occurences) and change the values to something else. Reload starman. Repeat step 6 and see that you receive a 403 Forbidden status Undo your changes in api/v1/swagger/paths/patrons.json and reload starman again. 9. Wait an hour (or run the following SQL query: UPDATE oauth_access_tokens SET expires = 0) and repeat step 6. You should have a 403 Forbidden status, and the token must have been removed from the database. [1] https://addons.mozilla.org/en-US/firefox/addon/rester/ Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 M. Tompsett changed: What|Removed |Added Attachment #72888|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 72894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72894&action=edit Bug 20402: Follow-up to correct uninitialized failures Added type => 'access' to the token request line in Koha/REST/V1/OAuth.pm based on my quick skim of /usr/share/perl5/Net/OAuth2/AuthorizationServer/Defaults.pm which was complaining, and seemed to allow valid values of 'auth', 'refresh', and 'access'. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 M. Tompsett changed: What|Removed |Added Attachment #72887|0 |1 is obsolete|| --- Comment #8 from M. Tompsett --- Created attachment 72893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72893&action=edit Bug 20402: Add Net::OAuth2::AuthorizationServer to perl deps Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20418] Remove UpdateTotalIssuesOnCirc and make it cron everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20418 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20418 [Bug 20418] Remove UpdateTotalIssuesOnCirc and make it cron everywhere -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20418] New: Remove UpdateTotalIssuesOnCirc and make it cron everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20418 Bug ID: 20418 Summary: Remove UpdateTotalIssuesOnCirc and make it cron everywhere Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I guess the reason this system preference exists it that if you do a lot of circulation, updating this live could have an impact on your server load. But we could make it cron for everyone, it would always work and wouldn't require choices to be made and setup to be done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- I'd vote to remove the koha-conf.xml entry instead! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20417] Remove OpacCloud system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 [Bug 20417] Remove OpacCloud system preference and feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20417] New: Remove OpacCloud system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 Bug ID: 20417 Summary: Remove OpacCloud system preference and feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org This is a poorly implemented old fashioned "word cloud". I think it could be entirely removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20416] New: Remove hide_marc and advancedMARCeditor system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20416 Bug ID: 20416 Summary: Remove hide_marc and advancedMARCeditor system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl These two system preferences allow small customizations of the cataloging interface, namely showing only labels, or only the numbers. I don't think it's any use, almost everyone has the same values according to hea, and i am pretty sure the few libraries who don't can deal with seeing a framework with tag numbers and labels. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20416] Remove hide_marc and advancedMARCeditor system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20416 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20416 [Bug 20416] Remove hide_marc and advancedMARCeditor system preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] New: Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 Bug ID: 20415 Summary: Remove UseKohaPlugins system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In order to use plugins you need: - to have uploaded some plugins - to have activated the relevant part of your koha conf file - to have the right permissions - to have activated this system preference I think that's a little too much and the system preference could be removed and be always on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 [Bug 20415] Remove UseKohaPlugins system preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20414] remove COinSinOPACResults system preference and make it always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20414] New: remove COinSinOPACResults system preference and make it always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414 Bug ID: 20414 Summary: remove COinSinOPACResults system preference and make it always on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org This system preference make the results page zotero friendly. It doesn't change anything in the look of the page and is very useful, i cannot see a good reason to leave the choice to the administrators, it should always be on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20414 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414 [Bug 20414] remove COinSinOPACResults system preference and make it always on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20413 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 [Bug 20413] Remove the "template" system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20413] Remove the "template" system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20412] New: Importing records from Copac server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20412 Bug ID: 20412 Summary: Importing records from Copac server Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: jefk...@dias.ie QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl "Copac exposes rare and unique research material by bringing together the catalogues of over 100 major UK and Irish libraries" They do so via: https://copac.jisc.ac.uk/developers/z39.50/ https://copac.jisc.ac.uk/developers/sru/ Z39.50 provides record syntax: XML or SUTRS SRU provides record format: MODS XML As far as I understand, Koha doesn't understand XML over Z39.50. It doesn't understand MODS XML over SRU either. However, when configuring the SRU, an XSLT file can be provided. So: is there an XSLT file for converting from MODS to MARC21? If not, that would be a feature request. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20413] New: Remove the "template" system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Bug ID: 20413 Summary: Remove the "template" system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This was meant to allow us to have different templates on the staff interface, but this will probably never be used. Could we get rid of the system preference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 [Bug 20411] Remove StaffDetailItemSelection system preference and make the feature always on -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20411] Remove StaffDetailItemSelection system preference and make the feature always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20411] New: Remove StaffDetailItemSelection system preference and make the feature always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Bug ID: 20411 Summary: Remove StaffDetailItemSelection system preference and make the feature always on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This is always used according to HEA, and a very useful feature, i am not sure it makes sense to let the administrators choose to have it or not. Permissions are here also to make sure librarians won't batch delete items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 [Bug 20410] Remove OpacGroupResults system preference and feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20410] New: Remove OpacGroupResults system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 Bug ID: 20410 Summary: Remove OpacGroupResults system preference and feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org This is used only once according to HEA, but i am pretty sure this doesn't work, and probably never will. I suggest removing it entirely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] Wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20409] Remove OpacBrowseResults system preference and make it always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20409 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20409 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20409 [Bug 20409] Remove OpacBrowseResults system preference and make it always on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20409] New: Remove OpacBrowseResults system preference and make it always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20409 Bug ID: 20409 Summary: Remove OpacBrowseResults system preference and make it always on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org According to HEA, this is always on. I don't think it should be a system preference. Libraries that *really* don't want this useful feature (which don't seem to exist at the moment) could still hide it with css. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 Alex Arnaud changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407
--- Comment #1 from Alex Arnaud ---
Created attachment 72891
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72891&action=edit
Bug 20407 - REST API: Ability to hide fields from unauthorized users
Test plan:
- apply this patch,
- edit api/v1/swagger/definitions/city.json,
- remove the keys "country" and "postal_code" from required,
- add a key "x-public": false for country and postal_code
"postal_code": {
"description": "city postal code",
"type": ["string", "null"],
"x-public": false
},
"country": {
"description": "city country",
"type": ["string", "null"],
"x-public": false
}
- logout from Koha and go to api/v1/cities,
- you should not see country and postal_code,
- login to Koha and refresh api/v1/cities,
- you should see country and postal_code
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #17 from Gaetan Boisson --- I have created a new ticket for removing the feature. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408 This ticket can remain open in order to fix the feature eventually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20396] Omnibus: Koha Cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Gaetan Boisson changed: What|Removed |Added Depends on||20408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408 [Bug 20408] Remove the availability facet and filter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20408] Remove the availability facet and filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408 Gaetan Boisson changed: What|Removed |Added Blocks||20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20408] New: Remove the availability facet and filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408 Bug ID: 20408 Summary: Remove the availability facet and filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.bois...@biblibre.com QA Contact: testo...@bugs.koha-community.org Both on staff interface and opac, the availability filter and facet aren't working. This has been an issue for some time. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 The feature should be removed until it is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18309] UNIMARC update from IFLA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Gaetan Boisson changed: What|Removed |Added Summary|Remove search result|Add a system preference to |highlighting|disable search result ||highlighting in the staff ||interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Remove search result highlighting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #1 from Gaetan Boisson --- Discussed with Owen at the hackfest, removing it could be disturbing for some users even though it is clearly not working. The way to go would be to add a system preference so we can disable it. Changing the title of the bug accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] New: Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 Bug ID: 20407 Summary: Hide some fields from unauthoriezd users Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arn...@biblibre.com The main goal here is to be able to make some fields/properties/columns "non public" to unauthorized people ( permission => catalogue ) by setting a "x-public" key to false in Swagger definitions files. Patch is coming... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20403] Refactor "Keywords to marc mapping"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20403 --- Comment #2 from Gaetan Boisson --- I renamed this to "refactor" instead of "remove" since it is in fact used. We do need to find a way to solve the performance issue, and have an interface that makes more sense than the current one. I am in favor of adding columns to the biblio table, but it wouldn't be possible to have more than one field in one column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com --- Comment #8 from Josef Moravec --- Failed QA means I need answer here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318
--- Comment #7 from Josef Moravec ---
Comment on attachment 72881
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72881
Bug 20318: Merge invoices can lead to an merged invoice without Invoice number
Review of attachment 72881:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20318&attachment=72881)
-
::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
@@ -351,4 @@
> $(row).click(function () {
> $('#merge_table tbody tr').removeClass('active');
> $(this).addClass('active');
> -
> $('#merge_invoicenumber').text(invoice.invoicenumber);
Why do you remove this? The functionality of using one of merged invoices
number just by clicking on it could be still useful.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20403] Refactor "Keywords to marc mapping"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20403 Gaetan Boisson changed: What|Removed |Added Summary|"Keywords to marc mapping" |Refactor "Keywords to marc |could be dropped|mapping" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 jmbroust changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jean-manuel.broust@univ-lyo ||n2.fr --- Comment #25 from jmbroust --- tested on sandbox, git applied with Fridolyn because cannot be applied via sandbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #135 from David Bourgault --- Forgot to mention : t/db_dependent/TestBuilder.t does fail with error message "Unknown type time for open_hour in DiscreteCalendar at /inlibro/git/koha-master-dev-inlibro/t/lib/TestBuilder.pm line 341." I'm not sure what to do with this. Isn't 'time' a standard datatype for all SQL implementations? Advice welcome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 --- Comment #6 from Julian Maurice --- Note: you can add as many API clients as you want by adding additional elements. I'm sure it would be better for API clients to be stored in database with a nice interface to manage them in Koha. But I think that can come later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #134 from David Bourgault --- Created attachment 72890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72890&action=edit Bug 17015 - Correction on QA feedback Changes: * Koha::DiscreteCalendar->new uses a hashref instead of a hash This meant changing every call to the Calendar and explains why this patch is so big. Most changes are simply adding braces to the new() call. + Added table encoding to atomic update + Added table definition to kohastructure.sql - Removed `repeatable_holidays`, `special_holidays` from kohastructure.sql Also added relevant DROP TABLEs to a new atomicupdate (part3) + Added 'override' param to Koha::DiscreteCalendar Without this param (off by default), edit_holiday will not modify past dates. This caused issues with some tests that required this functionality to work properly. Adding 'override => 1' to the function call will allow past dates to happen, but should only be called for testing. * Holds.t, Hold.t, CalcDateDue.t have been corrected. Prior to his patch, theses tests used hardcoded dates to test calendar functionalities, however, DiscreteCalendar is only usable one year into the past by default. They have been modified to be centered around '$today' * 'use strict; use warnings;' changed to 'use Modern::Perl;' in modified files. * Atomic update no longer takes params * Javascript moved to the bottom of discrete_calendar.tt * Calendar css moved out of tt file and into new discrete_calendar.css * All references to C4::Calendar and Koha::Calendar should now be removed * Some comments corrected All relevant tests passed for me on a fresh database. QA tool green. Test plan has not changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernan...@biblibre.com changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #4 from Olivier --- Ok for 4XX Ok for 210c_bis, ok for 225a_bis but KO for 210c and 225a (drop down menu is empty) all others fields works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Lucie Gay changed: What|Removed |Added CC||lucie.gay@ens-paris-saclay. ||fr --- Comment #57 from Lucie Gay --- patch works well, but messages are not clear : in staff user : "None of these items can normally be put on hold for this patron" opac : "Sorry, none of these items can be placed on hold." patrons doesn't know that it's because there is a limit per day -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #12 from Nick Clemens --- Created attachment 72889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72889&action=edit Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record To test: 1 - Set 'Holds per record' to 0 for some itemtype/patorn combination 2 - Attempt to plac a hold 3 - Will see 'Too many..' 4 - Apply patch 5 - Try again 6 - Should now see 'No holds..' 7 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 --- Comment #4 from Julian Maurice --- Created attachment 72887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72887&action=edit Bug 20402: Add Net::OAuth2::AuthorizationServer to perl deps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 Julian Maurice changed: What|Removed |Added Attachment #72874|0 |1 is obsolete|| --- Comment #5 from Julian Maurice --- Created attachment 72888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72888&action=edit Bug 20402: Follow-up to correct uninitialized failures Added type => 'access' to the token request line in Koha/REST/V1/OAuth.pm based on my quick skim of /usr/share/perl5/Net/OAuth2/AuthorizationServer/Defaults.pm which was complaining, and seemed to allow valid values of 'auth', 'refresh', and 'access'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 Julian Maurice changed: What|Removed |Added Attachment #72865|0 |1 is obsolete|| --- Comment #3 from Julian Maurice --- Created attachment 72886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72886&action=edit Bug 20402: Implement OAuth2 authentication for REST API It implements only the "client credentials" flow with basic scopes support (only one is defined, "patrons.read"). API Clients are defined in $KOHA_CONF. Test plan: 0. Install Net::OAuth2::AuthorizationServer 0.16 1. In $KOHA_CONF, add an element under : $CLIENT_ID $CLIENT_SECRET patrons.read 2. Apply patch, run updatedatabase.pl and reload starman 3. Install Firefox extension RESTer [1] 4. In RESTer, go to "Authorization" tab and create a new OAuth2 configuration: - OAuth flow: Client credentials - Access Token Request Method: POST - Access Token Request Endpoint: http://$KOHA_URL/api/v1/oauth/token - Access Token Request Client Authentication: Credentials in request body - Client ID: $CLIENT_ID - Client Secret: $CLIENT_SECRET - Scopes: patrons.read 5. Click on the newly created configuration to generate a new token (which will be valid only for an hour) 6. In RESTer, set HTTP method to GET and url to http://$KOHA_URL/api/v1/patrons then click on SEND It should return 200 OK with the list of patrons 7. Remove or change the from $KOHA_CONF (reload starman & memcached) and see that you cannot generate a new token. Then reset the scope to its initial value 8. Edit api/v1/swagger/paths/patrons.json, locate 'x-koha-scopes' (2 occurences) and change the values to something else. Reload starman. Repeat step 6 and see that you receive a 403 Forbidden status Undo your changes in api/v1/swagger/paths/patrons.json and reload starman again. 9. Wait an hour (or run the following SQL query: UPDATE oauth_access_tokens SET expires = 0) and repeat step 6. You should have a 403 Forbidden status, and the token must have been removed from the database. [1] https://addons.mozilla.org/en-US/firefox/addon/rester/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20406] Remove ISBD display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20406 --- Comment #2 from Gaetan Boisson --- Can't we use csv export there as well? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 --- Comment #6 from Christophe Croullebois --- Thx Séverine, in fact this message is not coded in koha but depend of your language, I presume it is French on your machine. Maybe someone can test with English to validate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20401] "Item circulation alerts" is overkill and might be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20401 --- Comment #2 from Gaetan Boisson --- Do you mean the checkin/checkout notifications or the whole items circulation alert tool? Using enhanced messaging preferences, it is already possible to define on a per patron category basis which category will receive these notifications. This tool only adds the possibility to define on a very granular basis which library will send a notification for which item type. I find it overkill and would replace issuing slips by the checkout notification, without so much granular choice. Are people really using this tool in that connfiguration, or only the checkout notices? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 --- Comment #3 from claire.hernan...@biblibre.com --- Created attachment 72885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72885&action=edit Follow-up: Bug 20390: UNIMARC biblio mappings WIP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernan...@biblibre.com changed: What|Removed |Added Attachment #72806|0 |1 is obsolete|| --- Comment #2 from claire.hernan...@biblibre.com --- Created attachment 72884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72884&action=edit Bug 20390: UNIMARC biblio mappings WIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #60 from sandbo...@biblibre.com --- Created attachment 72883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72883&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 sandbo...@biblibre.com changed: What|Removed |Added Attachment #72295|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19882] Add Novelist Select staff client profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #59 from sandbo...@biblibre.com --- Patch tested with a sandbox, by delaye -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
