[Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #21 from Fridolin SOMERS  ---
Because of test plan I think this can not be tested on a sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

François Pichenot  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
 CC||fpiche...@ville-roubaix.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

François Pichenot  changed:

   What|Removed |Added

   Assignee|fridolin.som...@biblibre.co |fpiche...@ville-roubaix.fr
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

Alex Arnaud  changed:

   What|Removed |Added

 QA Contact||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

--- Comment #19 from François Pichenot  ---
Created attachment 72825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72825&action=edit
Bug 18309: Unimarc update from IFLA - Unimarc Biblio (French)

- Koha specific fields prefixed by "Koha - "
- ABES specific fields prefixed by "ABES - "
- BnF specific fields prefixed by "BnF - "
- initial letters of fields and subfileds tags uppercased
- 183 added
- 203 added
- 219 added
- 231 added
- 283 added
- 338 added
- 009 deleted (deprecated field)
- 609 deleted (local field)
- 679 deleted (local field)
- 900 deleted
- 901 deleted
- 902 deleted
- 903 deleted
- 910 deleted
- 920 deleted
- 932 deleted
- 936 deleted
- 942 deleted
- 950 deleted
- 960 deleted
- 966 deleted
- 970 deleted
- 980 deleted
- 959 corrected
- 'unimarc_181c', 'ccrt', 'image cartographique tactile' corrected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

François Pichenot  changed:

   What|Removed |Added

  Attachment #61460|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jway...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

Claude  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||claude.bra...@cea.fr

--- Comment #4 from Claude  ---
I had system error while testing on a sandbox, with the following message :

Global symbol "$multihold" requires explicit package name (did you forget to
declare "my $multihold"?) at /home/koha/src/reserve/request.pl line 129.
Execution of /home/koha/src/reserve/request.pl aborted due to compilation
errors.

best regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Nicolas Legrand  ---
I don't dare to rebase it myself ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

--- Comment #2 from Nicolas Legrand  ---
Didn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20347] Add missing classes to search results elements

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #72497|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20347] Add missing classes to search results elements

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 72826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72826&action=edit
Bug 20347: Add missing classes to search results elements

The MARC21 XSLT doesn't add html classes to distinguish between
certain elements, and there's no way to rely on the element
positioning, making it impossible to style the elements with CSS.

Add the missing classes to distinguish the elements.

Test plan:
1) Apply patch
2) Search for any biblios
3) Check the search result page table HTML to see that the
   "Publisher", "Edition", "Source", "Other title", and "Online access"
   are wrapped in a span with class of results_summary and one
   of "publisher", "edition", "source", "other_title", and
   "online_access"
4) Check that the search results of the elements above looks correct
   when compared to the other elements

Signed-off-by: Pasi Kallinen 

Signed-off-by: Sebastian Hierl 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20347] Add missing classes to search results elements

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Sebastian Hierl 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68894|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 72827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72827&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

To test:
1 - Set an item type to allow no holds
2 - Attempt to place a hold for a patron
3 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
4 - Try placing a multihold with the record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68895|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 72828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72828&action=edit
Bug 16787: Add tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19719] Add a ‘Collection’ column in the patron loans data table.

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

--- Comment #3 from Séverine Queune  ---
Created attachment 72829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72829&action=edit
Bug 19719 - Add a ‘Collection’ column in the patron loans data table.

Signed-off-by: Severine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #13 from Nick Clemens  ---
Pushed to master, will be in 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19519] Ability to bind the rotating collection with branch during creating

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519

Lucie Gay  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Lucie Gay  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 19519:
Something went wrong !Applying: Bug 19519: Add ability to bind
rotating collectino with library during creation
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 19519: Add ability to bind rotating collectino with
library during creation
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 19519 - Ability to bind the rotating collection with branch during creating

72818 - Bug 19519: Add ability to bind rotating collectino with library during
creation

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-19519-Add-ability-to-bind-rotating-collectino--a2JeLJ.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #72471|0   |1
is obsolete||

--- Comment #7 from Nicolas Legrand  ---
Created attachment 72830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72830&action=edit
Bug 20334 - Option for escaping slashes in search queries

Add "QueryRegexEscapeOption" system preference to provide option to escape
Elasticsearch regexp delimiters (/) within queries, or alternativly to
unescape escaped slashes (\/) while escaping unescaped slashes, in
effect making "\/" the new regexp delimiter.

How to test:
1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
2) All tests should succeed

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19719] Add a ‘Collection’ column in the patron loans data table.

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||severine.que...@bulac.fr

--- Comment #4 from Séverine Queune  ---
Column correctly appears on both "Checkout" and "Details" tabs on patron
account.
It is correctly hidden if "collection_code" box are checked on Column
configuration > Circulation > id=issues-table and Column configuration >
Patrons > id=issues-table.
Thanks Kyle and Jesse !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr
 Status|Needs Signoff   |In Discussion

--- Comment #2 from Nicolas Legrand  ---
Could you please provide a test plan?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20395] Paycollect does not use Price formatter

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395

paxed  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #64704|0   |1
is obsolete||

--- Comment #24 from Alex Arnaud  ---
Created attachment 72831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72831&action=edit
Bug 8137 - Add Default checkout limit by patron category with priority.

This patch add the ability to make a 'Default checkout limit by patron
category'
rule has priority. When a rule has priority, it overrides all others
for the same categorycode. For "normal" rule, the behavior is the same
than before (like a default rule if no one is specified at branch level).
Rule with priority can only be created on the circulation and fine rules
page for *all libraries*. The goal is to allow librarian to limit the
total number of checkouts by patron category for all libraries.

test plan:

  - Create a rule with 4 checkouts allowed in default checkout limit
table
for a patron category and make it has priority,
  - create more permissive rules for all other branches (at least 5
checkouts allowed),
  - Checkout items of different branches for a patron with the same
category,
  - Patron should be limited to 4 checkouts

https://bugs.koha-community.org/show_bug.cgi?id=8137

Rebased: 2018-03-14, by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #64891|0   |1
is obsolete||

--- Comment #25 from Alex Arnaud  ---
Created attachment 72832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72832&action=edit
Bug 8137 - Add default issuing rule for all branches.

This patch does the same that for 'Default checkout limit by patron
category'.

test plan:

  - Create an issuing rule a patron category and itemtype. make it
has priority,
  - create more permissive issuing rules for all other branches,
  - check that the priority rule is taken into account for this
category
and itemtype.

Rebased: 2018-03-14, by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||nicolas.legr...@bulac.fr

--- Comment #11 from Nicolas Legrand  ---
It breaks my authority indexing (Unimarc) :

substr outside of string at /home/koha/perl5/lib/perl5/MARC/File/XML.pm line
563.
Use of uninitialized value $enc in string eq at
/home/koha/perl5/lib/perl5/MARC/File/XML.pm line 565.
Use of uninitialized value $enc in string eq at
/home/koha/perl5/lib/perl5/MARC/File/XML.pm line 565.
Use of uninitialized value $enc in string eq at
/home/koha/perl5/lib/perl5/MARC/File/XML.pm line 567.
Use of uninitialized value $enc in concatenation (.) or string at
/home/koha/perl5/lib/perl5/MARC/File/XML.pm line 570.
Unsupported UNIMARC character encoding [] for XML output for unimarc; 100$a ->
20180313 frey50   at /home/koha/perl5/lib/perl5/MARC/File/XML.pm line 570.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

--- Comment #7 from Nicolas Legrand  ---
How could I test it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20386] Improve warning and error messages for Search Engine Configuration

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20386

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #72768|0   |1
is obsolete||

--- Comment #2 from Nicolas Legrand  ---
Created attachment 72833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72833&action=edit
Bug 20386: Improve warning and error messages for Search Engine Configuration

This patch updates a warning message and error message in the Search
engine configuration for Elasticsearch.

Note: elasticsearch does not need to be active in order to test.

To test warning message:
 1. go to: cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl
 2. note the warning message
 3. Apply patch
 4. Note the change in warning message. Confirm it makes sense.

To test error message:
  Apply patch and check the changed message in the template file mappings.tt
and confirm it makes sense.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20386] Improve warning and error messages for Search Engine Configuration

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20386

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added'

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #72653|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added'

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #3 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added'

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369

--- Comment #4 from sandbo...@biblibre.com  ---
Created attachment 72834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72834&action=edit
Bug 20369: Analytics search is broken with QueryAutoTruncate set to 'only if *
is added'

Test Plan:
1) Enable EasyAnalytics
2) Disable QueryAutoTruncate
3) Create an analytic record, add some host items to it
4) Browser to the analytics tab for the record
5) Click the link in the 'used in' column of the table
6) No search results
7) Apply this patch
8) Reload the page, now you get the analytic record!

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added'

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #5 from Séverine Queune  ---
Thanks Kyle for this so useful enhancement !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@joensuu.fi

--- Comment #7 from paxed  ---
Comment on attachment 72523
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72523
Bug 20346 - Server side patron filtering implemented

Untranslatable strings:

+$('#searchmember_filter').attr("title","Please enter date
inputs in the format mm/dd/").tooltip('show');
+$('#searchmember_filter').attr("title","Please enter date
inputs in the format dd/mm/").tooltip('show');
+$('#searchmember_filter').attr("title","Please enter date
inputs in the format -mm-dd").tooltip('show');
+$('#searchmember_filter').attr("title","Please enter date
inputs in the format dd.mm.").tooltip('show');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346

--- Comment #8 from paxed  ---
Comment on attachment 72815
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72815
Bug 20346 - New wording above the patron table on the patron page

Untranslatable strings:

+ filtered = " starting with ";
+   } else {
+ filtered = " containing ";
+   }
+   filtered += "'" + $("#searchmember_filter").val() + "'";

These would also better written using _(" starting with '%s'").format(...)
instead of concatenation.

Same problems here:

+filtered += " begins with " + "'" +
$("#firstletter_filter").val() +"'";
+ } else {
+filtered = " begins with " + "'" +
$("#firstletter_filter").val() +"'";

And here:

+filtered += " with category " + "'" +
$("#categorycode_filter").find("option:selected").text() + "'";
+  } else {
+filtered = " with category " + "'" +
$("#categorycode_filter").find("option:selected").text() + "'";

And:

+filtered += " in library " +
$("#branchcode_filter").find("option:selected").text();
+ } else {
+filtered = " in library " +
$("#branchcode_filter").find("option:selected").text();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #22 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #23 from sandbo...@biblibre.com  ---
Created attachment 72835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72835&action=edit
Bug 18450 - Implemented check in renew.tt for block and renewal limits

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.
2. Place a hold on an item from a patron
3. Checkout the item out to a different patron
4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning
5. Click the 'Override and renew' button and notice that you
can bypass the hold
6. Apply patch
7. Renew the item again and notice that the message does not have a
'Override and renew' button it just has the 'Ignore and continue' button
8. Go back to More->Administration->Global system preferences and set
AllowRenewalLimitOverride to 'Allow'
9. Try renewing the same item again and notice that the 'Override and
renew' button is displayed
10. In systems preferences now set the
AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and
renew' button is displayed
11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew'
button is displayed
because you will not be violating these preferences.

Note: Checking if the renewal exceeds the renewal level, if auto renew
is set up, or if renewal is to soon is checked earlier in this
conditional
if statement earlier and so the check in this patch does not need to
check the renewal level, auto renewal, if renewal is too soon.

Signed-off-by: Lee Jamison 

Signed-off-by: Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #69489|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #64402|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #24 from sandbo...@biblibre.com  ---
Created attachment 72836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72836&action=edit
Bug 18450 - Followup - Implemented a conditional checking if the item that the
patron is trying to renew has more than 1 copy available which can be renewed.
This means the AllowRebnewalIfOtherItemsAvailable system preference is now
appropriately implemen

In order to make the conditional statement work correctly checking three
conditions each time (two system preferences and the value of the
can_renew variable I had to implement a elsif statement. I spent a large
amount of time trying to get a single IF statement to check the three
conditions in three different combinations but it ignored the value of
the can_renew variable each time and so I was forced to split it out
into an If and ELSIF

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.

2. Place a hold on an item

3. Checkout the item out to a different patron

4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning

5. Click the 'Override and renew' button and notice that you
can bypass the hold

6. Apply patch

7. Try to renew an item (with item level hold on it) which belongs to a biblio
with either only one
item or a biblio with multiple items all of which have holds on them.
Notice the only button in the yellow message box displayed is
'Continue without renewing'

8. Repeat step 7 but change the hold to a 'Next available' hold rather
than an item level hold. Again notice only the 'Continue without
renewing' button is displayed

9. Try to renew an item (with item level hold on it) which belongs to a
biblio with mutliple aviable items of it in the catalogue. Notice only
the 'Continue without renewing' button is displayed

10. Repeat step 9 but change the hold to a 'Next available' hold rather
than an item level hold. Notice only the 'Continue without renewing'
button is displayed

11. Set both AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable systempreferences to 'Allow' and
repeat step 7 notice only the 'Continue without renewing' button is
displayed in the yellow message box

12. Repeat step 8 and notice only the 'Continue without renewing' button
is displayed

13. Repeat step 9 and notice only the 'Continue without renewing' button
is displayed

14. Repeat step 10 and notice the item is immediately renewed and the
yellow message box is not displayed

15. Set the AllowRenewalIfOtheritemsAvailable to 'Dont' Allow' and
repeat step 7 and notice that both the 'Override and renew' and 'Continue
without renewal' buttons are
displayed

16. Repeat step 8 and notice both buttons are displayed

17. Repeat step 9 and notice both buttons are displayed

18. Repeat step 10 and notice both buttons are displayed

19. Set AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride syspref to 'Dont' Allow' and repeat step 7 and
notice only the 'Continue without renewal' button is displayed

20. Repeat step 8 and notice only 'Continue without renewal' button is
displayed

21. Repeat step 9 and notice only the 'Continue without renewal' button
is displayed

22. Repeat step 10 and notice both buttons are displayed

Sponsored-By: Catalyst IT

Signed-off-by: Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20382] Missing space between patron and cardnumber on check out screen

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20382

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 72837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72837&action=edit
Bug 20382: Missing space between patron and cardnumber on check out screen

There should be a space between patron name and cardnumber on the check
out screen.

This patch adds a space between patron and cardnumber.

To test:
 1 type a patron name into the check out search or go to the check out
 tab from a patron record
 2 Confirm there is no space between patron name and cardnumber on the
 check out page
 3 apply patch
 4 confirm there is now a space
 5 sign off :)

Signed-off-by: Sebastian Hierl 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20382] Missing space between patron and cardnumber on check out screen

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20382

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #72736|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20382] Missing space between patron and cardnumber on check out screen

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20382

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Sebastian Hierl 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

--- Comment #4 from Alex Arnaud  ---
Comment on attachment 72810
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72810
Bug 20385 - Don't try to get info for bad authtypecodes

Review of attachment 72810:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20385&attachment=72810)
-

::: Koha/SearchEngine/Elasticsearch/Search.pm
@@ +217,4 @@
>  # with the record. It's not documented why this is the case, so
>  # it's not reproduced here yet.
>  my $authtype   = $rs->single;
> +my $auth_tag_to_report = $authtype ? 
> $authtype->auth_tag_to_report : $authtypecode;

Works fine but i feel not confortable with the fact of putting an auth type
code inside a variable supposed to contain a marc field tag. Why not just ''?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added'

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #9 from Ere Maijala  ---
Thanks for comments.

1) I tried to use the prevalent style in the file, but I'll change the
indentation. 
2) I'll add a test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18661] Make "Replace only included patron attributes" default on patron import

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

jmbroust  changed:

   What|Removed |Added

 CC||jean-manuel.broust@univ-lyo
   ||n2.fr
 Status|Needs Signoff   |Failed QA

--- Comment #2 from jmbroust  ---
Problem on sandbox 8. Not tested.
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18661:
Something went wrong !Applying: Made Replace only included patron
attributes default on patron import
Using index info to reconstruct a base tree...
M koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
error: Failed to merge in the changes.
Patch failed at 0001 Made Replace only included patron attributes default on
patron import
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 18661 - Make Replace only included patron attributes default on patron
import

70572 - Made Replace only included patron attributes default on patron import

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
tmpMade-Replace-only-included-patron-attributes-defau-C0CswV.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20275] Add comment to let users know they can define multiple plugindirs

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

Nick Clemens  changed:

   What|Removed |Added

  Attachment #72093|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 72838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72838&action=edit
Bug 20275: Add comment to let user know they can define multiple plugindirs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20275] Add comment to let users know they can define multiple plugindirs

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19873] Make it possible to search on value 0

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19873] Make it possible to search on value 0

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #72307|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 72840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72840&action=edit
Bug 19873 - Add unit tests

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19873] Make it possible to search on value 0

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #70122|0   |1
is obsolete||

--- Comment #7 from Brendan Gallagher  ---
Created attachment 72839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72839&action=edit
Bug 19873 - Ability to search on 0 value

Test plan:
  - create a st-numeric index in zebra conf related to
a numeric field
i.e:
yourindex 1=yourindex 4=109
  - fill a field with 0 in a biblio,
  - reindex your biblios,
  - search yourindex=0,
  - should not work,
  - apply this patch,
  - test again,
  - should work

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Lucie Gay  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #26 from Lucie Gay  ---

the priority rule is applied except for the loan period, it's the one define in
the more permissive rule which is taken into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Lucie Gay  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lucie.gay@ens-paris-saclay.
   ||fr

--- Comment #52 from Lucie Gay  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 15261:
Something went wrong !Applying: Bug 15261: Verify if
checkouts/reserves requests periods overlap...
Using index info to reconstruct a base tree...
M C4/Circulation.pm
M C4/Reserves.pm
M Koha/DateUtils.pm
M circ/circulation.pl
M installer/data/mysql/sysprefs.sql
M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
M opac/opac-reserve.pl
M reserve/placerequest.pl
Falling back to patching base and 3-way merge...
Auto-merging reserve/placerequest.pl
Auto-merging opac/opac-reserve.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging circ/circulation.pl
Auto-merging Koha/DateUtils.pm
Auto-merging C4/Reserves.pm
Auto-merging C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15261: Verify if checkouts/reserves requests periods
overlap...
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 15261 - Verify if checkouts or reserves requests periods overlap with
existing reserves

68852 - Bug 15261: Verify if checkouts/reserves requests periods overlap...
68853 - Bug 15261 - Check reserves while renewing an issue

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-15261-Verify-if-checkoutsreserves-requests-per-9hD_17.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878

Olivier  changed:

   What|Removed |Added

 CC||olivier.ro...@enssib.fr

--- Comment #2 from Olivier  ---
There is a problem with 4XX fields
On the pop-up window the link choose do nothing on click.

The others fields are ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19488] Adding patron "Borrower Number" to 'patronbriefinfo' on patron details page in staff client

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Jesse Maseto  changed:

   What|Removed |Added

  Component|Architecture, internals,|Staff Client
   |and plumbing|
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19436] Add SRU support for authorities

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

François Pichenot  changed:

   What|Removed |Added

  Attachment #72252|0   |1
is obsolete||

--- Comment #3 from François Pichenot  ---
Created attachment 72841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72841&action=edit
Bug 19436: Add SRU support for authorities

Test plan:
 - Apply the patch
 - Add an SRU authority server in admininistration -> Z39.50/SRU servers
   You can try with the French national library, configured as such:
   Hostname: catalogue.bnf.fr
   Port: 80
   Database: api/SRU
   Syntax: Unimarc
   Record type: authority
   Additional SRU options: version=1.2,sru=get
   SRU Search fields mapping example:
Keyword (any): aut.anywhere
Name (any): aut.anywhere
Author (any): (aut.type any "pep org") and aut.accesspoint
Author (personal): aut.type=pep and aut.accesspoint
Author (corporate): aut.type=org and aut.accesspoint
Author (meeting/conference): aut.type=org and aut.accesspoint
Subject heading: (aut.type any "geo ram_nc ram_ge ram_pe ram_co") and
aut.accesspoint
Subject sub-division: aut.type=ram_pe and aut.accesspoint
Title (any): (aut.type any "tic tut tum ram_tp ram_tu") and
aut.accesspoint
Title (uniform):(aut.type any "tut tum ram_tu") and aut.accesspoint

 - Try a search from Authorities -> New from Z39.50/SRU
 - Check that the authority is correctly displayed in "Show Marc"
 - Check that the authority is correclty added to koha in "Import"
 - prove t/db_dependent/Breeding.t

Signed-off-by: François Pichenot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19436] Add SRU support for authorities

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

François Pichenot  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #59259|0   |1
is obsolete||

--- Comment #21 from Brendan Gallagher  ---
Created attachment 72842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72842&action=edit
Bug 17809: Add upgrade warning messages

TEST PLAN
-
0) backup db
1) drop db and recreate empty
2) run fr-FR web install
3) update systempreferences set Value='16.3' where variable='Version';
-- it is currently 16.4 as of this writing
4) run fr-FR web install
   -- bottom of red warnings should be the check messages.
5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl
   -- $VERSION message, which we don't care about
   -- maybe a message about return value of print ignored.

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #59261|0   |1
is obsolete||

--- Comment #22 from Brendan Gallagher  ---
Created attachment 72843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72843&action=edit
Bug 17809 correct authorisation values for fr-FR

This corrects:
CC -- duplicate, but name not full.
GQ -- duplicate, but only one name correct.
PK -- Poland was mislabelled.

This removes and edits duplicates and corrects PK to PL.

Signed-off-by: Luke Honiss 

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #59262|0   |1
is obsolete||

--- Comment #23 from Brendan Gallagher  ---
Created attachment 72844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72844&action=edit
Bug 17809 - ER country twice in fr-FR database files

In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is
defined twice, for "Erythrée" (correct one) and "Allemagne".

Test plan :
- Create a new database using fr-FR or import the sql file
- Look at authorised values COUNTRY
=> without patch you have ER / Allemange
=> with patch you have ER / ErythrÃe

NOTE: Allemange occurs twice as well, correctly with DE.
  This patch correctly removes the ER one.

Signed-off-by: Mark Tompsett 

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #72099|0   |1
is obsolete||

--- Comment #24 from Brendan Gallagher  ---
Created attachment 72845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72845&action=edit
Bug 17809: (follow-up) search in COUNTRY category

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68246|0   |1
is obsolete||
  Attachment #68247|0   |1
is obsolete||
  Attachment #68248|0   |1
is obsolete||
  Attachment #69250|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 72846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72846&action=edit
Bug 19482 - DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #9 from Nick Clemens  ---
Created attachment 72847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72847&action=edit
Bug 19482 - Add support for defining 'mandatory' mappings

To test:
1 - Apply patch
2 - Clear all ES mappings form the db: DELETE FROM search_fields; DELETE
FROM search_marc_maps; DELETE FROM search_marc_to_fields;
3 - Reset Es mapping:
/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
4 - issues should now be uneditable and not removable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #10 from Nick Clemens  ---
Created attachment 72848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72848&action=edit
Bug 19482 - Schema changes (DO NOT PUSH)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #11 from Nick Clemens  ---
I updated the instructions, this should work if the settings are entirely
cleared - that should be dealt with on a separate bug though. This should be
testable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #15 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #14)

Thx Katrin for QAing.

> 1) Question: I notice all other options are are -- and the new one is the
> only one - - is there a reason to use one or the other?

Good catch :) There is no real difference. I will add a minus for consistency.
According to Getopt::Long we should one minus for single character options like
-l and two minuses for long option names like --long. But if you define a
'category' option and you have nothing else starting with a 'c', -c and --c
will work both.

> DBD::mysql::st execute failed: Column 'categorycode' in where clause is
> ambiguous 

Oops. Caused by a QA follow-up on one of the preceding reports that replaced a
subquery by a join, followed by a rebase here. Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71655|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 72850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72850&action=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #18 from Marcel de Rooy  ---
Created attachment 72851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72851&action=edit
Bug 19454: (QA follow-up) Fix selection on categorycode

A follow-up on a preceding report introduced a join instead of a
subquery. This made the categorycode ambiguous.

Test plan:
See former patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71654|0   |1
is obsolete||

--- Comment #16 from Marcel de Rooy  ---
Created attachment 72849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72849&action=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

Amended: Replace -category by --category. (marcelr 20180304)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72849|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 72852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72852&action=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

Amended: Replace -category by --category. (marcelr 20180314)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72851|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 72854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72854&action=edit
Bug 19454: (QA follow-up) Fix selection on categorycode

A follow-up on a preceding report introduced a join instead of a
subquery. This made the categorycode ambiguous.

Test plan:
See former patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72850|0   |1
is obsolete||

--- Comment #20 from Marcel de Rooy  ---
Created attachment 72853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72853&action=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Séverine Queune  ---
Applying: Bug 20318: Merge invoices can lead to an merged invoice without
Invoice number
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 20318: Merge invoices can lead to an merged invoice
without Invoice number
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Merge-invoices-can-lead-to-an-merged-invoice-witho-SIyTfk.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

Séverine Queune  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

François Pichenot  changed:

   What|Removed |Added

  Attachment #61479|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

--- Comment #20 from François Pichenot  ---
Created attachment 72855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72855&action=edit
Unimarc biblio (French) default export

You can check the correctness of the French Unimarc biblio framework with this
export.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #3 from Victor Grousset/tuxayo  ---
Linked but not a duplicate. Needs an independent patch due to the specificities
of the two different pages.

The current plan is to make the order page take into account the CurrencyFormat
syspref. Server side that means using Koha::Number::Price->unformat()
But it's likely to be done client-side.
Because currently, on the client-side there are calculations to convert the
amount from one currency to another.

With that the behavior would be consistent between the order and reception.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20392] Multiple biblio holding does not work when patron is not set

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20392

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #72814|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20392] Multiple biblio holding does not work when patron is not set

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20392

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 72856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72856&action=edit
Bug 20392: Fix handling multi hold when not patron set

Test plan:
0) Do not apply the patch
1) Set the system preference DisplayMultiPlaceHold to enable
2) Search in staff client catalogue
3) On results page check more then one result and click on Place hold
button at the top of the page
4) Search for patron, but don't be to specific, you need to have more
then one result
5) Click on one of the found patron
6) Now you are going to confirm a hold, but only for one record!
7) Apply the patch
8) Repeat 2-5 and confirm that now it is working as expected ( place
hold for multiple records)

Signed-off-by: delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20392] Multiple biblio holding does not work when patron is not set

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20392

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20119] Ability to print claims for late orders

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Séverine Queune  ---
Applying: Bug 20119 - Ability to print claims for late orders
Using index info to reconstruct a base tree...
M   C4/Letters.pm
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
Auto-merging C4/Letters.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 20119 - Ability to print claims for late orders
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-20119---Ability-to-print-claims-for-late-order-II3tjp.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #5 from Marcel de Rooy  ---
Created attachment 72857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72857&action=edit
Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes

This routine looks at the issuingrules and makes a fast 'intelligent
guess' if article requests may be allowed for item types while
branch code and patron category may not be available.

We also add Koha::Biblio->may_article_request using the routine based
on default item type or parameter. Implemented as both class and instance
method. Added a few tests.

Test plan:
[1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
[2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #7 from Marcel de Rooy  ---
Created attachment 72859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72859&action=edit
Bug 17530: Use can_article_request to control sidebar link

Before this patch, the 'Request article' link is displayed whenever the
pref is enabled. In many cases this might be useless. Instead of a guess
as in opac-search, we now call can_article_request to know for sure.
Note: at least this is the case when a user has logged in.

Update sidebar template with template variable artreqpossible.
Add code in opac-detail, MARCdetail and ISBDdetail to fill it.

Test plan:
[1] Look for two biblios with items: one that should allow article requests
and one that should not (respecting branch, patron, item type).
[2] Verify on detail, ISBD and MARC that the link is displayed for
the first biblio and hidden for the second biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72859|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 72860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72860&action=edit
Bug 17530: Use can_article_request to control sidebar link

Before this patch, the 'Request article' link is displayed whenever the
pref is enabled. In many cases this might be useless. Instead of a guess
as in opac-search, we now call can_article_request to know for sure.
Note: at least this is the case when a user has logged in.

Update sidebar template with template variable artreqpossible.
Add code in opac-detail, MARCdetail and ISBDdetail to fill it.

Test plan:
[1] Look for two biblios with items: one that should allow article requests
and one that should not (respecting branch, patron, item type).
[2] Verify on detail, ISBD and MARC that the link is displayed for
the first biblio and hidden for the second biblio.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #6 from Marcel de Rooy  ---
Created attachment 72858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72858&action=edit
Bug 17530: Use may_article_request method in opac-search

If you enable pref ArticleRequests, until now all search results got the
'Request article' link. This patch tries to improve the situation by
using the new sub with the itemtype of the search result.

In most cases the number of links will drastically decrease. It may still
be possible sometimes that a link is shown while it effectively is not
possible, but we do not get the performance burden of determining that and
going through all items.

Test plan:
[1] Look for two borrowers P1 and P2 within categories C1 resp. C2.
[2] Look for two biblios B1 and B2 with default item types I1 resp. I2.
(See 942c in case of MARC21.)
[3] Make sure that no circ rules allow article requests. Enable the pref.
[4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes.
Log out. Search for B1 and B2, verify that only B1 has AR link.
Log in as P1. Verify that only B1 has AR link.
Log in as P2. Verify that no biblio has AR link.
[5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only.
Log out. Search for B1 and B2, verify that both have AR links.
Log in as P1. Verify that only B1 has AR link.
Log in as P2. Verify that only B2 has AR link.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

  Attachment #72801|0   |1
is obsolete||

--- Comment #10 from Ere Maijala  ---
Created attachment 72861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72861&action=edit
Bug 20248 - Elasticsearch - Improvements to mappings UI and indexing script

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 72862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72862&action=edit
Bug 19872: Move template JavaScript to the footer: UNIMARC editor plugins, part
4

This patch updates more and more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_124a.tt
- unimarc_field_124b.tt
- unimarc_field_124c.tt
- unimarc_field_124d.tt
- unimarc_field_124e.tt
- unimarc_field_124f.tt
- unimarc_field_124g.tt

Signed-off-by: delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #70121|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >