[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Liz Rea from comment #5) > They don't, that's the point. The reason for the many hoops here was that we > didn't want front end staff uploading un-verified code (none of the plugins > are independently audited, nor do they go through a community QA process) to > the public server filled with personally identifying information without the > IT departments of libraries being aware that it was happening. > > I can imagine a (however unlikely) scenario where someone makes a Really > Awesome Plugin(tm) that provided a function that lots of libraries want, > that does the feature but also sends the entire database to an unscrupulous > 3rd party. With the hoops, we can at least be sure that someone with access > to the server has spoken to the person in the library about their > intentions. Without them, either the sysadmin or the librarian could do this > independently and without speaking to each other. > > Experience tells me that librarians will do almost anything to get out of > talking to the IT department (yes it's a generalisation). This isn't a good > thing in this scenario, we have to think about the potential for theft of > data via the plugin system and do what we can to make sure that the people > tasked with protecting the data (the IT departments, usually) know exactly > what code is running on their publicly facing web servers. The multi factor > turn on for this feature is at the very least, due diligence on our part. We > could warn more, to be honest. > > I hope this helps explain my perspective a bit. > > Cheers, > Liz I agree with Liz. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #35 from M. Tompsett --- Created attachment 72986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72986&action=edit Bug 9701: Followup to make test pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 --- Comment #5 from Liz Rea --- They don't, that's the point. The reason for the many hoops here was that we didn't want front end staff uploading un-verified code (none of the plugins are independently audited, nor do they go through a community QA process) to the public server filled with personally identifying information without the IT departments of libraries being aware that it was happening. I can imagine a (however unlikely) scenario where someone makes a Really Awesome Plugin(tm) that provided a function that lots of libraries want, that does the feature but also sends the entire database to an unscrupulous 3rd party. With the hoops, we can at least be sure that someone with access to the server has spoken to the person in the library about their intentions. Without them, either the sysadmin or the librarian could do this independently and without speaking to each other. Experience tells me that librarians will do almost anything to get out of talking to the IT department (yes it's a generalisation). This isn't a good thing in this scenario, we have to think about the potential for theft of data via the plugin system and do what we can to make sure that the people tasked with protecting the data (the IT departments, usually) know exactly what code is running on their publicly facing web servers. The multi factor turn on for this feature is at the very least, due diligence on our part. We could warn more, to be honest. I hope this helps explain my perspective a bit. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #33 from Roch D'Amour --- Created attachment 72985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72985&action=edit Bug 17674 - Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Removed SQl and use snake_case. Same test plan as before. Might also want to test t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Roch D'Amour changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9081] Opac news not output on check in and check out notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081 --- Comment #4 from Lisette --- +1 for this enhancement. It would be great if anything that could go to a patron could have the news on it: CHECKIN CHECKOUT DUE DUEDGST FinesPaidToday ISSUEQSLIP PREDUE PREDUEDGST ACCTDETAILS HOLD ODUE This way e-mailed or printed notices could all have news. Lisette Scheer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #82 from Séverine Queune --- It would be great if someone could work on this patch again ! The problem is still valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #34 from M. Tompsett --- t/db_dependent/Biblio.t is failing... there is a difference between unsafe and empty call to GetMarcStructure for some reason. Haven't traced it back enough. This is a side issue that is failing this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #16 from sandbo...@biblibre.com --- Created attachment 72984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72984&action=edit Bug 20120: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandbo...@biblibre.com changed: What|Removed |Added Attachment #72598|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from sandbo...@biblibre.com --- Patch tested with a sandbox, by George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20429] Patron is told history is not deleted incorrectly on opac-privacy.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20429 lucasgass changed: What|Removed |Added Summary|opac-privacy.pl display |Patron is told history is |needs changed |not deleted incorrectly on ||opac-privacy.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20429] New: opac-privacy.pl display needs changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20429 Bug ID: 20429 Summary: opac-privacy.pl display needs changed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The opac-privacy.pl (privacy tab) displays either "Your reading history has been deleted" OR "NO reading history to delete". This is true even if the user has a reading history and hasn't deleted it. There should be a 3rd case where the display class is hidden. Here is the code from the opac-privacy.tt file: Your privacy management [% IF deleted %] Your reading history has been deleted. [% ELSE %] No reading history to delete [% END %] A 3rd clause that checks if there is a reading history or not and then hides the display if there is should be added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Victor Grousset/tuxayo changed: What|Removed |Added CC|victor.grous...@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #64675|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #50 from Victor Grousset/tuxayo --- Created attachment 72983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72983&action=edit Bug 12310 : Decimal separators issues: fix maninvoice, mancredit The aid is to prevent x100 or /100 of the amounts. And decimal part truncation WIP fix maybe aqbudgets and aqbudgetperiods The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Modify the tooltips helping the users entering monrtary information in the right format. Fields on all those pages are now automatically formatted - cgi-bin/koha/admin/aqbudgetperiods.tt - cgi-bin/koha/admin/aqbudgets.tt - cgi-bin/koha/members/mancredit.tt - cgi-bin/koha/members/maninvoice.tt Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbol is ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #72213|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407
M. Tompsett changed:
What|Removed |Added
Attachment #72891|0 |1
is obsolete||
--- Comment #2 from M. Tompsett ---
Created attachment 72982
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72982&action=edit
Bug 20407 - REST API: Ability to hide fields from unauthorized users
Test plan:
- apply this patch,
- edit api/v1/swagger/definitions/city.json,
- remove the keys "country" and "postal_code" from required,
- add a key "x-public": false for country and postal_code
"postal_code": {
"description": "city postal code",
"type": ["string", "null"],
"x-public": false
},
"country": {
"description": "city country",
"type": ["string", "null"],
"x-public": false
}
- logout from Koha and go to api/v1/cities,
- you should not see country and postal_code,
- login to Koha and refresh api/v1/cities,
- you should see country and postal_code
NOTE: Make sure to go to Koha administration and add cities before testing.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthoriezd users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20428] New: MARC import fails on Debian Stretch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 Bug ID: 20428 Summary: MARC import fails on Debian Stretch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It appears that Koha cannot access /tmp on Stretch. We should standardize on each Koha instance having it's own TMPDIR in /var/lib/koha//tmp to avoid this as well as avoiding possible file name collisions between instances. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #72 from Séverine Queune --- Tested with Unimarc DB, worked as described on both basket and cataloguing. Thanks for this enhancement ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune changed: What|Removed |Added Attachment #72896|0 |1 is obsolete|| --- Comment #69 from Séverine Queune --- Created attachment 72979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72979&action=edit Bug 12747 - Missing use in tests Adds missing `use t::lib::Mocks ...` to Breeding.t Tests should now pass correctly. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune changed: What|Removed |Added Attachment #72898|0 |1 is obsolete|| --- Comment #71 from Séverine Queune --- Created attachment 72981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72981&action=edit Bug 12747 - Add extra column in Z3950 search This is a complete squash of previous patches, with additional code quality improvments following M. Tompsett's feedback. Squashing was done (as suggested) because many lines add be added and subsequently deleted, which made for confusing patches. New changes: * Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_ variable is no longer used (at all), and the split() routine is used. * t/db_dependent/Breeding.t now uses the mocked preference logic to avoid sysprefs being affected. Functionality and test plan have not changed. -- This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields Sponsored-by: CCSR (https://ccsr.qc.ca) Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune changed: What|Removed |Added Attachment #72897|0 |1 is obsolete|| --- Comment #70 from Séverine Queune --- Created attachment 72980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72980&action=edit Bug 12747 - Switch date field on marc flavour Amended _add_rowdata to check only for the marcflavour-appropriate date field. This makes the test pass without noise. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164 --- Comment #23 from Koha Team Lyon 3 --- Hello, I have tried on a 16.11.16 and it works. I'm going to try it on a master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #30 from Nick Clemens --- Created attachment 72978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72978&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Brendan Gallagher changed: What|Removed |Added Attachment #69790|0 |1 is obsolete|| --- Comment #2 from Brendan Gallagher --- Created attachment 72977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72977&action=edit Bug 19809: Re-allow to call Koha::Objects::find in list context and remove 'scalar' keyword in calls where it's not needed. Also, fix Koha::Patron::guarantor which had the same problem as find Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Paycollect does not use Price formatter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #4 from M. Tompsett --- Created attachment 72976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72976&action=edit Bug 20395: Followup to change format to use price filter See comment #1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Owen Leonard changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19474 | Depends on||19474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What|Removed |Added Blocks||20427 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20427 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 [Bug 20427] Convert OPAC LESS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 --- Comment #13 from Séverine Queune --- Thanks Josef and Christophe, the onclick feature is a great idea ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 --- Comment #12 from Séverine Queune --- Created attachment 72975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72975&action=edit Bug 20318: Merge invoices can lead to an merged invoice without Invoice number Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Paycollect does not use Price formatter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- Confirmed Josef's comment with: git grep "format(['\"]%.2f['\"])" | grep [.]tt: git show 3910d5e8b I believe the best course of action for the currency line is to cut it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #49 from Victor Grousset/tuxayo --- TODO check that bug 18471 isn't back. == Plan == - Make the patch work again - Fix all the QA issues, make a clean thing - sign off (spam Lyon 3, cait, Marc Véron, BULAC, etc to make them do that) - etc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] New: Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Bug ID: 20427 Summary: Convert OPAC LESS to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Since we're working to add SCSS to the staff client (Bug 19474), we can convert the OPAC to use SCSS too and use the same build process for both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20427 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #2 from Katrin Fischer --- Created attachment 72973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72973&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: A list of the routling lists a patron appears on in the OPAC. To test: - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Turn the preference on - the tab should appear now - Add some subscriptions and add your patron to the routing list - Check tab again - it should now show a list of the serials with links to the detail page in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #3 from Katrin Fischer --- Created attachment 72974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72974&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #4 from Katrin Fischer --- Not ready for sign-off yet! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20378] OPAC ID and password do not auto-generate for new patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20378 --- Comment #1 from Agnes Rivers-Moore --- Further testing ... If I create a QuickAdd patron form without OPAC ID and password fields - We can save that form without ID or password When calling up the same record - Koha has inserted a username and password for that record (firstname.lastname and default password whatever that is). So it seems Koha still can generate the ID, but in the full patron add form it is not allowing the form to be saved without those fields, so the auto-generated ID on save never happens. This means if the bug 19908 fix to make those fields not mandatory is applied, the auto-generate behaviour may fix itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425 --- Comment #3 from M. Tompsett --- I confirmed the sensibility of the regular expression by running this in the kohaclone directory: git grep KOHA_VERSION | sed -E 's#(^.*:).*(=".*KOHA_VERSION ).*#\1: \2#g' | sort -u | less For some reason two paths are hard coded with opac-tmpl. Most things have interface, but there is themelang. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425 --- Comment #2 from M. Tompsett --- Created attachment 72972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72972&action=edit Bug 20425: Improve regular expression. See comment #1 for test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Brendan Gallagher changed: What|Removed |Added Attachment #70683|0 |1 is obsolete|| --- Comment #14 from Brendan Gallagher --- Created attachment 72971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72971&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Brendan Gallagher changed: What|Removed |Added Attachment #70682|0 |1 is obsolete|| --- Comment #13 from Brendan Gallagher --- Created attachment 72970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72970&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Nick Clemens --- The test plan here uses numbers valid for LC callnumbers. I think you will need to find a valid callnumber range if using a different classification source -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Christophe Croullebois changed: What|Removed |Added Attachment #72958|0 |1 is obsolete|| --- Comment #11 from Christophe Croullebois --- Created attachment 72969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72969&action=edit Merge invoices can lead to an merged invoice without Invoice number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425 --- Comment #1 from M. Tompsett --- Created attachment 72968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72968&action=edit Bug 20425: [DO NOT PUSH] False Positive AND Failure TEST PLAN - 1) Apply this first patch to your kohaclone 2) run qa test tools in kohaclone -- two issues will be raised 3) Apply the second patch to your qa-test-tools 4) run qa test tools again in your kohaclone -- only one issue will be raised 5) confirm that the one issue is the requiring KOHA_VERSION -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #48 from Victor Grousset/tuxayo --- After talking to Lyon 3, BULAC, Owen, cait and another library. The conclusions are: - the current behavior is okay - we need to keep the syspref to leave the option to handle thousands separator Finally we will be able to move on! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20426] New: Can't import all titles from a stage file with default values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Bug ID: 20426 Summary: Can't import all titles from a stage file with default values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org When you import staged file for an order, you could have a lot of title in a file and you need to use default "item information" and default "Default accounting details" to choose budget and item informations. I try to import with this default information and I have an error message : 'Some budgets are not defined in item records' We use this every day in my university and we really need this. Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Brendan Gallagher changed: What|Removed |Added Attachment #72939|0 |1 is obsolete|| --- Comment #10 from Brendan Gallagher --- Created attachment 72967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72967&action=edit Bug 17561 - ReserveSlip needs itemnumber for item level holds on same biblio This patch fixes a regression after bug 14695. This patch adds itemnumber and barcode as optional params in ReserveSlip used by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be able to generate correct slips when items in multi-item holds are checked in. Test plan: 1) activate a circulation rule with multi-item holds 2) Place two holds on same biblio for patron 3) for debugging, either use browser console to observe POST request and responses or use info from reserves, e.g. reserve_id in the HOLD_SLIP 4) checkin two items from same biblio on pickup branch 5) note that both holds are effectuated, but reserve_id is the same on both slips 6) also note that there is no itemnumber or barcode in the requests from returns.pl 7) Apply this patch 8) repeat 2-4 9) note that reserve_id is now different on the two slips and/or: Run tests: t/db_dependent/Reserves/ReserveSlip.t Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425 M. Tompsett changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|jonathan.dru...@bugs.koha-c |mtomp...@hotmail.com |ommunity.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20425] New: Reducing false positives on KOHA_VERSION
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425 Bug ID: 20425 Summary: Reducing false positives on KOHA_VERSION Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: mtomp...@hotmail.com Improve the regular expression for checking if KOHA_VERSION is needed. This was found as a result of bug 20420. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 --- Comment #9 from Marcel de Rooy --- Created attachment 72966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72966&action=edit Bug 19929: (QA follow-up) Fix POD Make qa tools happy. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357
--- Comment #5 from M. Tompsett ---
(In reply to Marcel de Rooy from comment #4)
> Mark, what about:
>
> } elsif ( scalar @{ $after->{subs} } == 0 ) {
> # This is perfectly okay.
>
> If there are no subs anymore, do not complain about pod coverage.
> Note that no subs means no 'public' subs; there may still be subs like _type
> with an underscore.
Because, if you cut out a function, I rather fall to the next check, then just
allow out right cuts. I can't recall the test case I hit that made me want to
do both. Probably something about increasing, then decreasing in the same patch
set.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy changed: What|Removed |Added Attachment #72959|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 72965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72965&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing records from a staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #7 from Marcel de Rooy --- QA: Working here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #4 from Marcel de Rooy ---
Mark, what about:
} elsif ( scalar @{ $after->{subs} } == 0 ) {
# This is perfectly okay.
If there are no subs anymore, do not complain about pod coverage.
Note that no subs means no 'public' subs; there may still be subs like _type
with an underscore.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20420] Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 Brendan Gallagher changed: What|Removed |Added Attachment #72927|0 |1 is obsolete|| --- Comment #3 from Brendan Gallagher --- Created attachment 72964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72964&action=edit Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the
[Koha-bugs] [Bug 20420] Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20424] Zebra - Updating default Unimarc biblio mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 François Pichenot changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20424] Zebra - Updating default Unimarc biblio mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 François Pichenot changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fpiche...@ville-roubaix.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20424] New: Zebra - Updating default Unimarc biblio mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Bug ID: 20424 Summary: Zebra - Updating default Unimarc biblio mapping Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: fpiche...@ville-roubaix.fr QA Contact: testo...@bugs.koha-community.org Zebra doesn't yet integrate last Unimarc bibliographic updates published by IFLA. This ticket aims to update Zebra Unimarc bibliographic mappings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Brendan Gallagher changed: What|Removed |Added Attachment #70684|0 |1 is obsolete|| --- Comment #6 from Brendan Gallagher --- Created attachment 72963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72963&action=edit Bug 17247: Check if patron is debarred in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812
Kyle M Hall changed:
What|Removed |Added
Attachment #72961|0 |1
is obsolete||
--- Comment #12 from Kyle M Hall ---
Created attachment 72962
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72962&action=edit
Bug 4812: Reserves for a specific copy of a book say book is available even
though it it still checked out
When you place a reserve on a specific copy of a book a note is immediately put
on the card of the person for whom the book is being reserved that says the
book is available even though it is still checked out to someone else.
The code is in placerequest.pl & opac-reserve.pl
holdingbranch
if ($checkitem ne ''){
$rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns');
my $item = $checkitem;
$item = GetItem($item);
if ( $item->{'holdingbranch'} eq $branch ){
$found = 'W' unless C4::Context->preference('ReservesNeedReturns');
}
}
This code does not bother to check to see if an item is actually on the shelf,
it sets it to 'W' reguardless.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812
Kyle M Hall changed:
What|Removed |Added
Attachment #72960|0 |1
is obsolete||
--- Comment #11 from Kyle M Hall ---
Created attachment 72961
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72961&action=edit
Bug 4812: Reserves for a specific copy of a book say book is available even
though it it still checked out
When you place a reserve on a specific copy of a book a note is immediately put
on the card of the person for whom the book is being reserved that says the
book is available even though it is still checked out to someone else.
The code is in placerequest.pl & opac-reserve.pl
holdingbranch
if ($checkitem ne ''){
$rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns');
my $item = $checkitem;
$item = GetItem($item);
if ( $item->{'holdingbranch'} eq $branch ){
$found = 'W' unless C4::Context->preference('ReservesNeedReturns');
}
}
This code does not bother to check to see if an item is actually on the shelf,
it sets it to 'W' reguardless.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 abernaud changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11 from abernaud --- Tested with the dependencies : doesn't work better... Anne-Claire -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812
Kyle M Hall changed:
What|Removed |Added
Attachment #2173|0 |1
is obsolete||
--- Comment #10 from Kyle M Hall ---
Created attachment 72960
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72960&action=edit
Bug 4812: Reserves for a specific copy of a book say book is available even
though it it still checked out
When you place a reserve on a specific copy of a book a note is immediately put
on the card of the person for whom the book is being reserved that says the
book is available even though it is still checked out to someone else.
The code is in placerequest.pl & opac-reserve.pl
holdingbranch
if ($checkitem ne ''){
$rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns');
my $item = $checkitem;
$item = GetItem($item);
if ( $item->{'holdingbranch'} eq $branch ){
$found = 'W' unless C4::Context->preference('ReservesNeedReturns');
}
}
This code does not bother to check to see if an item is actually on the shelf,
it sets it to 'W' reguardless.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett changed: What|Removed |Added Attachment #72949|0 |1 is obsolete|| --- Comment #6 from M. Tompsett --- Created attachment 72959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72959&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t NOTE: No POD was added, but I don't believe it is mandatory. PERL13 says it is only encouraged, not required. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 --- Comment #10 from Christophe Croullebois --- (In reply to Josef Moravec from comment #8) > Failed QA means I need answer here. Hi Josef, you'r right, so I have added this functionality. Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Christophe Croullebois changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Christophe Croullebois changed: What|Removed |Added Attachment #72873|0 |1 is obsolete|| Attachment #72881|0 |1 is obsolete|| --- Comment #9 from Christophe Croullebois --- Created attachment 72958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72958&action=edit Merge invoices can lead to an merged invoice without Invoice number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20423 CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20423] ReservesNeedReturns allows multiple patrons to have the same item set to 'waiting'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=4812 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Attachment #68853|0 |1 is obsolete|| --- Comment #54 from Alex Arnaud --- Created attachment 72957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72957&action=edit Bug 15261 - Check reserves while renewing an issue Test plan: - Create an issue (i.e from 15/09/2017 to 04/10/2017), - place a reserve on the same item from 05/10/2017 to 30/10/2017), - enable PreventCheckoutOnSameReservePeriod, - Check that you are not able to renew the issue. Rebased (2018-03-15) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20422] Fix warn on URI/Escape.pm line 184 from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422
Brendan Gallagher changed:
What|Removed |Added
Attachment #72953|0 |1
is obsolete||
--- Comment #4 from Brendan Gallagher ---
Created attachment 72955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72955&action=edit
Bug 20422: Fix warning on uri_escape_utf8 in Output.pm
When opac-details calls parametrized_url, it triggers an uninitialized
warning when you would have a record without e.g. author, like:
Use of uninitialized value in subroutine entry at
/usr/share/perl5/URI/Escape.pm line 184.
This is (imo) actually a bug in URI::Escape; it should check its args.
But we resolve the warning here by adding the "// q{}" in parametrized_url.
NOTE: Along the way we do something similar in the arrParamsBusc loop.
If the variable is undefined, jump to the next one. (Consistent with the
approach in the if-part preceding it.)
Test plan:
[1] Run t/Output.t again. Should pass now.
Signed-off-by: Marcel de Rooy
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Attachment #68852|0 |1 is obsolete|| --- Comment #53 from Alex Arnaud --- Created attachment 72956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72956&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rabased on master Rebased on master (2016-06-23) Rebased on master (2017-03-23) Rebased on master (2018-03-15) Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20422] Fix warn on URI/Escape.pm line 184 from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20422] Fix warn on URI/Escape.pm line 184 from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Brendan Gallagher changed: What|Removed |Added Attachment #72952|0 |1 is obsolete|| --- Comment #3 from Brendan Gallagher --- Created attachment 72954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72954&action=edit Bug 20422: Add unit test to Output.t for parametrized_url This test will reveal that we need to resolve a warning too. Test plan: [1] Run t/Output.t without the second patch. [2] The test will fail on the warning raised by an undefined value. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20423] New: ReservesNeedReturns allows multiple patrons to have the same item set to 'waiting'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423 Bug ID: 20423 Summary: ReservesNeedReturns allows multiple patrons to have the same item set to 'waiting' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If ReservesNeedReturns set to "Automatically", then two or more patrons can place a hold on the item and it will be set to 'waiting' for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12011] ReservesNeedReturns breaks 'Hold Filled' functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12011 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20423 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20119] Ability to print claims for late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Séverine Queune changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #14 from Séverine Queune --- The current patch (that works perfectly for pdf export) doesn't update the claims count nor the claimed date. Is it a behaviour we want to keep ? In that case, as the claims count is update only when emailing the vendor, there is no way in Koha to trace the "paper claims". But, in the other hand, there is no garanty that the claim pdf will be send to the vendor, or the date of sending can be different of the one in Koha so it's not necesarly a good idea to update these informations at the printing moment. I don't know which behaviour is better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20408] Remove the availability facet and filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20422] Fix warn on URI/Escape.pm line 184 from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 --- Comment #1 from Marcel de Rooy --- Created attachment 72952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72952&action=edit Bug 20422: Add unit test to Output.t for parametrized_url This test will reveal that we need to resolve a warning too. Test plan: [1] Run t/Output.t without the second patch. [2] The test will fail on the warning raised by an undefined value. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20422] Fix warn on URI/Escape.pm line 184 from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422
--- Comment #2 from Marcel de Rooy ---
Created attachment 72953
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72953&action=edit
Bug 20422: Fix warning on uri_escape_utf8 in Output.pm
When opac-details calls parametrized_url, it triggers an uninitialized
warning when you would have a record without e.g. author, like:
Use of uninitialized value in subroutine entry at
/usr/share/perl5/URI/Escape.pm line 184.
This is (imo) actually a bug in URI::Escape; it should check its args.
But we resolve the warning here by adding the "// q{}" in parametrized_url.
NOTE: Along the way we do something similar in the arrParamsBusc loop.
If the variable is undefined, jump to the next one. (Consistent with the
approach in the if-part preceding it.)
Test plan:
[1] Run t/Output.t again. Should pass now.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
