[Koha-bugs] [Bug 20695] Upload does not show all results when uploading multiple files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #74967|0   |1
is obsolete||

--- Comment #4 from Dilan Johnpullé  ---
Created attachment 75199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75199=edit
Bug 20695: Fix multiple upload result in tools/upload script

Instead of calling UploadedFiles->find only once with $id, we should
extract all comma separated id's from the parameter.

Test plan:
[1] Before this patch, upload two files at once in Tools/Upload. After doing
so, you should see only one result reported. But both files should
have been uploaded.
[2] With this patch, repeat step 1 and see two upload results.

Signed-off-by: Marcel de Rooy 

Patch applies and functions as described.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20695] Upload does not show all results when uploading multiple files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20694] Purchase suggestion cancel is not reflecting in suggestion cancel order tab after cancel the order at vendor level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20694

Amit Gupta  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Amit Gupta  changed:

   What|Removed |Added

  Attachment #75197|0   |1
is obsolete||

--- Comment #15 from Amit Gupta  ---
Created attachment 75198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75198=edit
Bug 18889: Simpler counter-patch

Works OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

  Attachment #73519|0   |1
is obsolete||

--- Comment #14 from Alex Buckley  ---
Created attachment 75197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75197=edit
Bug 18889: Simpler counter-patch

There is no need to add barcode into the accountlines
table, as a relationship via itemnumber can easily look it up.

Followed test plan, works as described. Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

Summary|Item number in biblio   |Add barcode to 'Pay Fines'
   |description in fine page|tab in patrons payment page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

  Attachment #73362|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #75131|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 75196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75196=edit
Bug 20668: Update two-column templates with Bootstrap grid: Acquisitions part 2

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718

Dilan Johnpullé  changed:

   What|Removed |Added

 CC||di...@calyx.net.au

--- Comment #2 from Dilan Johnpullé  ---
Applied patch, created some lists including 'staff' but noticed that 'staff'
lists seemingly vanish after creation.

/cgi-bin/koha/virtualshelves/shelves.pl only shows private and public lists;
all staff lists are invisible to the owner and anyone else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20735] Multiple LDAP servers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20735

Terence Lau  changed:

   What|Removed |Added

 CC||terence...@cic.hk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20735] New: Multiple LDAP servers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20735

Bug ID: 20735
   Summary: Multiple LDAP servers
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: terence...@cic.hk
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Koha does not support multiple LDAP servers.  Can it be one of the development
option?

For example, student accounts were stored in LDAP A, teaching staff accounts
were stored LDAP B.  Students and teaching staff have different access rights /
privileges.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

--- Comment #6 from M. Tompsett  ---
Comment on attachment 74858
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74858
Bug 20661: Shortcut scripts if a blocking error appeared

Review of attachment 74858:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20661=74858)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt
@@ +12,5 @@
>  
> +
> +Home
> + Circulation
> +[% UNLESS blocking_error %] Circulation statistics for [% title 
> |html %][% END %]

Why add this unless, when line 26 still displays the title?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75007|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 75195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75195=edit
Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

Triggered by the finding on bug 20697.
The three calls of GetHostItemsInfo should be controlled by the pref. This
patch makes the sub return an empty list when the pref is disabled.

The patch simplifies the sub by merging the two identical foreach loops
depending on the field number in MARC21/UNIMARC.

Will add a unit test on a follow-up patch.

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75008|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 75194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75194=edit
Bug 20702: Add unit tests for GetHostItemsInfo

Unfortunately, we did not have unit tests yet.
Adding some simple tests that test basic operation of the sub when the
pref is enabled/disabled and for MARC21/UNIMARC.

Test plan:
[1] Run t/db_dependent/Items/GetHostItemsInfo.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

--- Comment #4 from M. Tompsett  ---
Comment on attachment 75007
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75007
Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

Review of attachment 75007:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20702=75007)
-

::: C4/Items.pm
@@ +1226,5 @@
> +} elsif( C4::Context->preference('marcflavour') eq 'UNIMARC') {
> +@fields = $record->field('461');
> +}
> +
> +foreach my $hostfield ( @fields ) {

I like this optimization. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are ad

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20678

--- Comment #7 from Alex Buckley  ---
Hi Katrin

Thanks, sorry about that I got carried away :)

This patch is for a client running Koha 17.11 at present and so it has been
developed to work on Koha 17.11.

I also want to upstream it to master however 17.11 and master have diverged
sufficiently (in particular the moving of the JavaScript from the top of
/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt file to the
bottom that to prevent merge conflicts when applying this patch I have had to
create two patches; this one for 17.11 and bug 20678 for master. 

Cheers,
Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20699

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #75192|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

--- Comment #11 from Alex Buckley  ---
Created attachment 75193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75193=edit
Bug 20699 - Implemented a save marc as draft feature

This patch implements the ability to save marc records to the reservior
(in a similar way to how imported staged records are stored in the
 reservior).

The purpose of this feature is to be able to train junior library staff
and catalogers by letting them practise cataloging biblio records and saving
them as drafts
(stored in the reservoir). Because these draft records are stored in the
reservoir they are not returned as OPAC search results.

This patch implements a new 'editcatalogue' subpermission called
'commit_MARC_records_to_catalog'. A staff member must have this subpermission
enabled to commit a record to the catalog.

In the addbiblio.pl interface users with all editcatalogue
subpermissions (which should be staff experienced with cataloging) will see 4
'Save' options:

* Save and review record
* Save and edit items
* Save and continue editing
* Save without cataloging

Junior staff should have all editcatalog subpermissions except for
'commit_MARC_records_to_catalog' and they will see one save option 'Save
without cataloging' and this saves the record as a draft.

To view and administer all draft records you can click on the 'View
draft records' button in the toolbar on the addbooks.pl page.

Here draft records are listed newest to oldest and individual draft records can
be edited/deleted or all draft records
can be deleted in one go.

Test plan:

Test plan:
1. Go to addbooks.pl and notice there is no 'View draft reocrds' button
in the toolbar alongside 'New record'

2. Apply patch

3. Restart plack, memcached

4. Update your database, this can be achieved by runnning
installer/data/mysql/updatedatabase.pl or in Koha staff client going to
Adminstration->Global system preferences->Local use and amending the
Version syspref value

5. Create two user accounts one with superlibrarian permissions and the
other with all editcatalogue subpermissions except for
'commit_MARC_records_to_catalog' and also enable the catalogue
permission so this user can access the staff client.

6. Log in as user 1 (superlibrarian) go to Cataloging->New record and
select the 'Save' dropdown box and notice you have 4 options. Select
'Save and view record' and notice you have created a biblio in the
catalog.

7. Log out and log in as user 2 go to Cataloging->New record and
click the 'Save' button and notice that there is only one option 'Save
without cataloging'. Meaning you are restricted to only creating a draft
record.

8. Select 'Save without cataloging' and you are re-directed to the
Cataloging main page. Now select the 'View draft records' button and
view your draft record in the table of draft records.

9. Select the 'Edit' link and notice the addbiblio.pl page for the draft
record is loaded

10. Return to the View draft records interface and delete the draft
record and notice that after the page reloads the record is no longer
displayed in the table.

11. Create 2 more draft records and return to the View draft records
interface and select 'Delete all drafts from reservoir' and notice the
drafts table is emptied

12. Create 1 more draft record and then log out

13. Log in as user 1 (superlibrarian) and go to the View draft records
interface.

14. Select the 'Edit' link

15. Select any save option except for 'Save without cataloguing' and
notice the record is now committed to the catalog.

16. Return to the 'View draft records' interface and notice the record
you just committed to the catalog has been removed as a draft record in
the reservoir.

17. Run the unit test t/db_dependent/ImportBatch.t in koha-shell

18. Notice that unit test 12 passes: 'ok 12 - No biblio expected since
we deleted the biblio from the batch'

19. Log out and back in as the second user and search for a biblio
record which is in the catalog (i.e. not a draft record) and notice both
in the staff client search results and the biblio detail page the links
to edit the record and items associated with the biblio record are not
displayed. This is because the user you are logged in as has all
edit_catalogue permissions except
CAN_user_editcatalogue_commit_MARC_records_to_catalog which is
neccessary to add/edit/delete biblios or items in the catalog.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

--- Comment #10 from Alex Buckley  ---
Created attachment 75192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75192=edit
Bug 20699 - Implemented a save marc as draft feature

This patch implements the ability to save marc records to the reservior
(in a similar way to how imported staged records are stored in the
 reservior).

The purpose of this feature is to be able to train junior library staff
and catalogers by letting them practise cataloging biblio records and saving
them as drafts
(stored in the reservoir). Because these draft records are stored in the
reservoir they are not returned as OPAC search results.

This patch implements a new 'editcatalogue' subpermission called
'commit_MARC_records_to_catalog'. A staff member must have this subpermission
enabled to commit a record to the catalog.

In the addbiblio.pl interface users with all editcatalogue
subpermissions (which should be staff experienced with cataloging) will see 4
'Save' options:

* Save and review record
* Save and edit items
* Save and continue editing
* Save without cataloging

Junior staff should have all editcatalog subpermissions except for
'commit_MARC_records_to_catalog' and they will see one save option 'Save
without cataloging' and this saves the record as a draft.

To view and administer all draft records you can click on the 'View
draft records' button in the toolbar on the addbooks.pl page.

Here draft records are listed newest to oldest and individual draft records can
be edited/deleted or all draft records
can be deleted in one go.

Test plan:

Test plan:
1. Go to addbooks.pl and notice there is no 'View draft reocrds' button
in the toolbar alongside 'New record'

2. Apply patch

3. Restart plack, memcached

4. Update your database, this can be achieved by runnning
installer/data/mysql/updatedatabase.pl or in Koha staff client going to
Adminstration->Global system preferences->Local use and amending the
Version syspref value

5. Create two user accounts one with superlibrarian permissions and the
other with all editcatalogue subpermissions except for
'commit_MARC_records_to_catalog' and also enable the catalogue
permission so this user can access the staff client.

6. Log in as user 1 (superlibrarian) go to Cataloging->New record and
select the 'Save' dropdown box and notice you have 4 options. Select
'Save and view record' and notice you have created a biblio in the
catalog.

7. Log out and log in as user 2 go to Cataloging->New record and
click the 'Save' button and notice that there is only one option 'Save
without cataloging'. Meaning you are restricted to only creating a draft
record.

8. Select 'Save without cataloging' and you are re-directed to the
Cataloging main page. Now select the 'View draft records' button and
view your draft record in the table of draft records.

9. Select the 'Edit' link and notice the addbiblio.pl page for the draft
record is loaded

10. Return to the View draft records interface and delete the draft
record and notice that after the page reloads the record is no longer
displayed in the table.

11. Create 2 more draft records and return to the View draft records
interface and select 'Delete all drafts from reservoir' and notice the
drafts table is emptied

12. Create 1 more draft record and then log out

13. Log in as user 1 (superlibrarian) and go to the View draft records
interface.

14. Select the 'Edit' link

15. Select any save option except for 'Save without cataloguing' and
notice the record is now committed to the catalog.

16. Return to the 'View draft records' interface and notice the record
you just committed to the catalog has been removed as a draft record in
the reservoir.

17. Run the unit test t/db_dependent/ImportBatch.t in koha-shell

18. Notice that unit test 12 passes: 'ok 12 - No biblio expected since
we deleted the biblio from the batch'

19. Log out and back in as the second user and search for a biblio
record which is in the catalog (i.e. not a draft record) and notice both
in the staff client search results and the biblio detail page the links
to edit the record and items associated with the biblio record are not
displayed. This is because the user you are logged in as has all
edit_catalogue permissions except
CAN_user_editcatalogue_commit_MARC_records_to_catalog which is
neccessary to add/edit/delete biblios or items in the catalog.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #74962|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #74961|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #74960|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #74929|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #74928|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #74922|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are ad

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699

--- Comment #6 from Katrin Fischer  ---
Always be careful what you ask for... quite a bug title now. :) 
Allow adding draft records to the reservoir and managing them?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are ad

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699

--- Comment #5 from Alex Buckley  ---
Created attachment 75191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75191=edit
Bug 20699 - Implemented a save marc as draft feature

This patch implements the ability to save marc records to the reservior
(in a similar way to how imported staged records are stored in the
 reservior).

The purpose of this feature is to be able to train junior library staff
and catalogers by letting them practise cataloging biblio records and saving
them as drafts
(stored in the reservoir). Because these draft records are stored in the
reservoir they are not returned as OPAC search results.

This patch implements a new 'editcatalogue' subpermission called
'commit_MARC_records_to_catalog'. A staff member must have this subpermission
enabled to commit a record to the catalog.

In the addbiblio.pl interface users with all editcatalogue
subpermissions (which should be staff experienced with cataloging) will see 4
'Save' options:

* Save and review record
* Save and edit items
* Save and continue editing
* Save without cataloging

Junior staff should have all editcatalog subpermissions except for
'commit_MARC_records_to_catalog' and they will see one save option 'Save
without cataloging' and this saves the record as a draft.

To view and administer all draft records you can click on the 'View
draft records' button in the toolbar on the addbooks.pl page.

Here draft records are listed newest to oldest and individual draft records can
be edited/deleted or all draft records
can be deleted in one go.

Test plan:

Test plan:
1. Go to addbooks.pl and notice there is no 'View draft reocrds' button
in the toolbar alongside 'New record'

2. Apply patch

3. Restart plack, memcached

4. Update your database, this can be achieved by runnning
installer/data/mysql/updatedatabase.pl or in Koha staff client going to
Adminstration->Global system preferences->Local use and amending the
Version syspref value

5. Create two user accounts one with superlibrarian permissions and the
other with all editcatalogue subpermissions except for
'commit_MARC_records_to_catalog' and also enable the catalogue
permission so this user can access the staff client.

6. Log in as user 1 (superlibrarian) go to Cataloging->New record and
select the 'Save' dropdown box and notice you have 4 options. Select
'Save and view record' and notice you have created a biblio in the
catalog.

7. Log out and log in as user 2 go to Cataloging->New record and
click the 'Save' button and notice that there is only one option 'Save
without cataloging'. Meaning you are restricted to only creating a draft
record.

8. Select 'Save without cataloging' and you are re-directed to the
Cataloging main page. Now select the 'View draft records' button and
view your draft record in the table of draft records.

9. Select the 'Edit' link and notice the addbiblio.pl page for the draft
record is loaded

10. Return to the View draft records interface and delete the draft
record and notice that after the page reloads the record is no longer
displayed in the table.

11. Create 2 more draft records and return to the View draft records
interface and select 'Delete all drafts from reservoir' and notice the
drafts table is emptied

12. Create 1 more draft record and then log out

13. Log in as user 1 (superlibrarian) and go to the View draft records
interface.

14. Select the 'Edit' link

15. Select any save option except for 'Save without cataloguing' and
notice the record is now committed to the catalog.

16. Return to the 'View draft records' interface and notice the record
you just committed to the catalog has been removed as a draft record in
the reservoir.

17. Run the unit test t/db_dependent/ImportBatch.t in koha-shell

18. Notice that unit test 12 passes: 'ok 12 - No biblio expected since
we deleted the biblio from the batch'

19. Log out and back in as the second user and search for a biblio
record which is in the catalog (i.e. not a draft record) and notice both
in the staff client search results and the biblio detail page the links
to edit the record and items associated with the biblio record are not
displayed. This is because the user you are logged in as has all
edit_catalogue permissions except
CAN_user_editcatalogue_commit_MARC_records_to_catalog which is
neccessary to add/edit/delete biblios or items in the catalog.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are ad

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699

Alex Buckley  changed:

   What|Removed |Added

  Attachment #75151|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are ad

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699

Alex Buckley  changed:

   What|Removed |Added

Summary|save marc record|Implement functionality for
   ||junior cataloguing staff to
   ||practise cataloguing/saving
   ||their records to reservoir
   ||(import_records,
   ||import_biblios DB tables)
   ||as drafts which are
   ||administered from the
   ||Cataloging interface

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

--- Comment #4 from Jonathan Druart  
---
Hi Maureen, can you try this patch?

I have not tried it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

--- Comment #3 from Jonathan Druart  
---
Created attachment 75190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75190=edit
Bug 16342: Fix variable scope to make BakerTaylor works under plack

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20525] Add --timezone switch to koha-create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525

--- Comment #11 from Jonathan Druart  
---
Can we have a note on the wiki page about this flag?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #22 from Jonathan Druart  
---
I was expecting to see rejected any requests made with a valid token when the
pref is off.

Example:
Turn the pref on
Generate a token
Request something (or not)
Turn the pref on
Request something
=> 200
Should not we return 401 or whatever instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

Maureen Wynkoop  changed:

   What|Removed |Added

 CC||mwynkoop@camdencountylibrar
   ||y.org

--- Comment #2 from Maureen Wynkoop  ---
This looks like a really lonely, ignored bug.  I'm very sad that I can't have
book jackets on my lists because I added value to my catalog by using Baker and
Taylor for enhanced content!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20734

--- Comment #32 from Jonathan Druart  
---
Please take care of bug 20734 before the end of the week.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20734
[Bug 20734] Add warning to the about page if RESTOAuth2ClientCredentials and
not Net::OAuth2::AuthorizationServer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20734] Add warning to the about page if RESTOAuth2ClientCredentials and not Net::OAuth2::AuthorizationServer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20734

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20612


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612
[Bug 20612] Make OAuth2 use patron's client_id/secret pairs
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20734] New: Add warning to the about page if RESTOAuth2ClientCredentials and not Net::OAuth2::AuthorizationServer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20734

Bug ID: 20734
   Summary: Add warning to the about page if
RESTOAuth2ClientCredentials and not
Net::OAuth2::AuthorizationServer
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20734] Add warning to the about page if RESTOAuth2ClientCredentials and not Net::OAuth2::AuthorizationServer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20734

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20733] Delete api key or add a deleted flag?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20612


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612
[Bug 20612] Make OAuth2 use patron's client_id/secret pairs
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20733

--- Comment #31 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #23)
> (In reply to Jonathan Druart from comment #22)
> > Should we really remove a deleted key from the DB table?
> > I would flag it as inactive instead, it would permit to keep track of the
> > different requests and associate it to a user.
> > Disclaimer: This may be a very stupid idea.
> 
> I thought about it too. That would mean an extra column: deleted TINYINT
> (1), and it makes sense.

See bug 20733.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733
[Bug 20733] Delete api key or add a deleted flag?
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20733] New: Delete api key or add a deleted flag?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733

Bug ID: 20733
   Summary: Delete api key or add a deleted flag?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org

>From bug 20612 comment 23.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

--- Comment #30 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #20)
> Please write a wiki page about these changes.

See
https://wiki.koha-community.org/wiki/APIs_and_protocols_supported_by_Koha#OAuth2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] OAuth2 client credentials grant for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

--- Comment #71 from Jonathan Druart  
---
Created attachment 75189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75189=edit
Bug 20402: only output if verbose flag is set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20568] Add API key management interface for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75186|0   |1
is obsolete||

--- Comment #55 from Jonathan Druart  
---
Created attachment 75188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75188=edit
Bug 20568: Fix bad resolution conflict with bug 18403

borrowers module permission has now several subpermissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20568] Add API key management interface for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

--- Comment #54 from Jonathan Druart  
---
Created attachment 75187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75187=edit
Bug 20568: fix shebang

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20568] Add API key management interface for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

--- Comment #53 from Jonathan Druart  
---
Created attachment 75186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75186=edit
Bug 20568: (follow-up) API keys management in interface

Fix bad resolution conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75178|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 75185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75185=edit
Bug 20351: Shortcut serials scripts if a blocking error appeared

The idea of output_and_exit_if_error (added by bug 18403) is to make sure
parameters are valid before executing the script.
If not (old or broken URLs), we shortcut everything coming next to display a
generic error ("object does not exist", "you do not have permission to do
that", etc.)

This bug report fixes the scripts under serials/*.

Test plan:
Hit the script under the serials directory with an invalid subscriptionid
parameter
and confirm you get an error instead of the normal view with empty values.

The goal is not to be exhaustive during the first iteration, but at least to
fix
the most common views.

For instance:
/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=XXX
/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=XXX
/cgi-bin/koha/serials/routing.pl?subscriptionid=XXX=new
/cgi-bin/koha/serials/subscription-add.pl?op=modify=XXx
/cgi-bin/koha/serials/subscription-add.pl?op=dup=XXX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #26 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #19)
> No access to /tmp? This will probably affect much more than upload?
> What about CGI sessions? Several cron jobs ?
> We should also look for hardcoded /tmp's in the codebase..
> etc.
> 
> Or make sure that koha-instance has enough permissions at install/upgrade ?

You are right about this being a broader problem for Stretch users. Kyle filed
bug 20727 to have that conversation as this one only deals with file uploads.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20732] New: Display the note tab for records without items.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20732

Bug ID: 20732
   Summary: Display the note tab for records without items.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: patrick.robitai...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Hi, 

when we have a record who have no items, it would be great to displays the note
tab first instead of holdings. It would be useful for the records of electronic
resources who don't have items. Having the notes tab put forward would avoid
one more click for relevant information. It could be a system preference like
opacSerialDefaultTab but for the records without items.  

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 75184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75184=edit
Bug 20624: Net::OAuth2::AuthorizationServer is not a hard dependency

While we get packaging sorted, Net::OAuth2::AuthorizationServer is not a
hard dependency for Koha and the feature requiring it is disabled by
default.

This patch:
- Makes the dependency optional
- Makes the unit tests for the OAuth2 client credentials flow skip if
  the dependency is not met.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from M. Tompsett  ---
It was beautiful (edit and create), but the show is empty.
Inspecting the source, I see a display: none with the correct SQL outside the
CodeMirror divs. I think Failed QA is appropriate, because of that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20731] Move template JavaScript to the footer: Call number browser MARC plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20731] Move template JavaScript to the footer: Call number browser MARC plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731

--- Comment #1 from Owen Leonard  ---
Created attachment 75183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75183=edit
Bug 20731: Move template JavaScript to the footer: Call number browser MARC
plugin

This patch modifies the call number browser plugin so that JavaScript is
in the footer instead of the header.

This patch also makes some unrelated changes: The page title has been
corrected; DataTables code has been removed as it was unused.

To test, apply the patch and configure a MARC framework to use
cn_browser.pl as the plugin for tag 952 subfield o.

Open an item for editing. The "Full call number" field should have an
active "..." link next to it. Clicking this should trigger a popup
window with the Call number browser. Confirm that submitting a new
search from this window works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett  ---
(In reply to M. Tompsett from comment #5)
> Where is this?

DOH! find . | grep codemirror and comment #0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

--- Comment #5 from M. Tompsett  ---
Comment on attachment 75180
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75180
Bug 20260: Use CodeMirror for the SQL reports editor

Review of attachment 75180:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20260=75180)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ +31,4 @@
>  [%- END -%]
>  
>  [% INCLUDE 'doc-head-close.inc' %]
> +[% Asset.css("lib/codemirror/codemirror.css") %]

Where is this?

@@ +953,4 @@
>  [% INCLUDE 'datatables.inc' %]
>  [% INCLUDE 'columns_settings.inc' %]
>  [% END %]
> +[% Asset.js( "lib/codemirror/codemirror-compressed.js" ) %]

Where is this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731
[Bug 20731] Move template JavaScript to the footer: Call number browser MARC
plugin
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20731] New: Move template JavaScript to the footer: Call number browser MARC plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731

Bug ID: 20731
   Summary: Move template JavaScript to the footer: Call number
browser MARC plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for the call number browser plugin.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75168|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 75182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75182=edit
Bug 20729: Update style of datepickers

This patch updates the styling of form fields which are configured to
use the jQueryUI datepicker widget. Some CSS has been added, and the
default datepicker configuration has been changed.

To test, apply the patch and clear your cache if necessary. Test pages
which include a datepicker to confirm that they look correct and work
correctly. Some examples:

 - Circulation -> Check out -> Specify due date
 - Patrons -> Add patron -> Date of birth, registration date, expiry
   date fields
 - Serials -> Search subscriptions -> Search results page sidebar
 - Tools -> News -> Add news item

And confirm that this change hasn't adversely affected the calendar
tool:

 - Tools -> Calendar

NOTE: Obvious in Serials.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #25 from Tomás Cohen Arazi  ---
This is PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

Owen Leonard  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #4 from Owen Leonard  ---
I've tried to also address Bug 19399 in these changes. If testers agree, please
mark that bug as a duplicate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

--- Comment #3 from Owen Leonard  ---
Created attachment 75180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75180=edit
Bug 20260: Use CodeMirror for the SQL reports editor

This patch adds CodeMirror syntax highlighting to the SQL reports
editor. Newly added is a file containing the sql-specific syntax
highlighting code, in both compressed and uncompressed versions.

Unrelated change: Some JavaScript has been moved from inside the body of
the page to the footer.

To test, apply the patch and go to Reports -> Saved SQL reports

- Edit an existing report and confirm that the SQL is correctly
  highlighted and that there are no display problems when editing.
- Confirm that changes are saved successfully.
- Perform the same test when creating a new SQL report.
- View an existing report and confirm that the SQL is syntax-highlighted
  but is read-only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #5 from Jonathan Druart  
---
Attached to test but will certainly need to be adjusted depending on the
decisions from bug 20726.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

--- Comment #1 from Jonathan Druart  
---
Created attachment 75178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75178=edit
Bug 20351: Shortcut serials scripts if a blocking error appeared

The idea of output_and_exit_if_error (added by bug 18403) is to make sure
parameters are valid before executing the script.
If not (old or broken URLs), we shortcut everything coming next to display a
generic error ("object does not exist", "you do not have permission to do
that", etc.)

This bug report fixes the scripts under serials/*.

Test plan:
Hit the script under the serials directory with an invalid subscriptionid
parameter
and confirm you get an error instead of the normal view with empty values.

The goal is not to be exhaustive during the first iteration, but at least to
fix
the most common views.

For instance:
/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=XXX
/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=XXX
/cgi-bin/koha/serials/routing.pl?subscriptionid=XXX=new
/cgi-bin/koha/serials/subscription-add.pl?op=modify=XXx
/cgi-bin/koha/serials/subscription-add.pl?op=dup=XXX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20730

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #5 from Jonathan Druart  
---
The idea of output_and_exit_if_error (added by bug 18403) is to make sure
parameters are valid before executing the script.
If not (old or broken URLs), we shortcut everything coming next to display a
generic error ("object does not exist", "you do not have permission to do
that", etc.)

This bug report fixes the scripts under circ/*, other bug reports will follow
to take care of other modules.

Test plan:
Hit the script under the circ directory with an invalid biblionumber parameter
and confirm you get an error instead of the normal view with empty values.

The goal is not to be exhaustive during the first iteration, but at least to
fix the most common views.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20351
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351
[Bug 20351] Implement blocking errors for serials scripts
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

Jonathan Druart  changed:

   What|Removed |Added

Version|17.11   |master
Summary|Subscription detail page|Implement blocking errors
   |with non-existent   |for serials scripts
   |subscriptionid shows empty  |
   |subscription|
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20661
 Depends on||20661
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
   Severity|minor   |enhancement


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661
[Bug 20661] Implement blocking errors for circulation scripts
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

--- Comment #4 from Jonathan Druart  
---
Created attachment 75176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75176=edit
Bug 20366: Add subscription info to the acq tab on the biblio detail page

On the "Acquisition details" tab of the bibliographic detail page, the
subscription information are missing.
This patch replace the call to GetHistory with Koha::Acquisition::Orders
in order to simplify the code and make use of new Koha::
packages/methods.

TODO: Add column settings (show/hide columns) to this table (?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

--- Comment #3 from Jonathan Druart  
---
Created attachment 75175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75175=edit
Bug 20366: Add new method Koha::Acquisition::Basket->basket_group

Can be moved to a separate bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

--- Comment #2 from Jonathan Druart  
---
Created attachment 75174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75174=edit
Bug 20366: Add new method Koha::Acquisition::Order->subscription

Can be moved to a separate bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20365


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365
[Bug 20365] Allow several open orders on subscription
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20365] Allow several open orders on subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20366


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366
[Bug 20366] More information about orders linked to subscriptions on
"Acquisition details" tab
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16739] generate edifact showing on basket groups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk
   Assignee|koha-b...@lists.koha-commun |j.p.kni...@lboro.ac.uk
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16739] generate edifact showing on basket groups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

--- Comment #6 from Jon Knight  ---
Created attachment 75173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75173=edit
Bug 16739: generate edifact showing on basket groups

When a book seller (vendor) does not have EDI account information configured
the basketgroup display still shows a button to generate EDIFACT output which
results in 500 error when clicked.  This patch fixes two aspects of this:

a) it stops the button being displayed in the first place, replacing it with
a message that explains there is not EDIFACT configuration for the vendor.

b) if, somehow, an edifact print operation is passed to the basketgroup
script it detects the lack of an EAN and redirects back to the basket group
display page with a warning message.

To test:
1) Create a vendor with no EDI details.
2) Create a basket with some items in, then close it and add it to a basket
   group for this vendor.
3) Go to that vendor's basket groups, click on the "Closed" tab and then
   click on the 'generate edifact order' button. You should get a 500 error.
4) Apply this patch.
5) Repeat 3, except this time you should find that the 'generate edifact
   order' button has been replaced with a note that there is
   "No EDIFACT configuration for ".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16739] New: generate edifact showing on basket groups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

Bug ID: 16739
   Summary: generate edifact showing on basket groups
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: cgi-bin/koha/acqui/basketgroup.pl?booksellerid=2
d=1
OS: All
Status: Needs Signoff
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: katrin.fisc...@bsz-bw.de, ve...@veron.ch
CC: ve...@veron.ch
   Summary: generate edifact showing on basket groups
  See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi
?id=6740
  See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi
?id=16740
CC: katrin.fisc...@bsz-bw.de
Status: Needs Signoff

When looking at basketgroups the 'generate edifact order' button shows even if
edi isn't set up for that vendor and leads to a 500 error page

--- Comment #1 from Marc Véron  ---
Duplicate of 6740?

--- Comment #2 from Marc Véron  ---
Sorry, I mean 
Bug 16740 - EDIFACT on Basket Groups leads to 500 error (

--- Comment #3 from Katrin Fischer  ---
*** Bug 16740 has been marked as a duplicate of this bug. ***

--- Comment #4 from Katrin Fischer  ---
Still valid.

--- Comment #5 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 CC||mtomp...@hotmail.com

--- Comment #24 from M. Tompsett  ---
I'm going for lunch, but I'll have to test this on Stretch for a MARC import to
be sure. Changing back to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75162|0   |1
is obsolete||

--- Comment #20 from M. Tompsett  ---
Created attachment 75169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75169=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75164|0   |1
is obsolete||

--- Comment #22 from M. Tompsett  ---
Created attachment 75171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75171=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75163|0   |1
is obsolete||

--- Comment #21 from M. Tompsett  ---
Created attachment 75170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75170=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #23 from M. Tompsett  ---
Created attachment 75172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75172=edit
Bug 20428: Added missing parameter --upload-tmp-path

Line 463 lists valid parameters, but it was missing
upload-tmp-path: which resulted in the koha-create
saying it is an invalid parameter.

TEST PLAN
-
1) apply all patches but this.
2) sudo perl ~/misc4dev/cp_debian_files.pl
3) restart_all
4) sudo koha-create --create-db --upload-tmp-path unique-path
awesome-test-name
   -- Fails to run.
5) apply this patch
6) repeat 2-4
7) sudo vi /etc/koha/sites/awesome-test-name/koha-conf.xml
   -- the upload_tmp_path entry should have unique-path
  in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

--- Comment #3 from Owen Leonard  ---
Created attachment 75168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75168=edit
Bug 20729: Update style of datepickers

This patch updates the styling of form fields which are configured to
use the jQueryUI datepicker widget. Some CSS has been added, and the
default datepicker configuration has been changed.

To test, apply the patch and clear your cache if necessary. Test pages
which include a datepicker to confirm that they look correct and work
correctly. Some examples:

 - Circulation -> Check out -> Specify due date
 - Patrons -> Add patron -> Date of birth, registration date, expiry
   date fields
 - Serials -> Search subscriptions -> Search results page sidebar
 - Tools -> News -> Add news item

And confirm that this change hasn't adversely affected the calendar
tool:

 - Tools -> Calendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

--- Comment #2 from Owen Leonard  ---
Created attachment 75167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75167=edit
Screenshot showing the form after this style update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

--- Comment #1 from Owen Leonard  ---
Created attachment 75166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75166=edit
Screenshot showing the calendar icon pushed onto the next line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] New: Update style of datepickers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Bug ID: 20729
   Summary: Update style of datepickers
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I propose and update to the styling of form fields which are configured to use
the jQueryUI datepicker plugin. Instead of appending a calendar icon to the
input (which can result in unwanted line-wrapping), we can style the input with
the calendar icon as a background-image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|20276   |20726


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276
[Bug 20276] GetCourseItem is using the wrong call  to get itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726
[Bug 20726] Display acquisition details on the subscription detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20276] GetCourseItem is using the wrong call to get itemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20728


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728
[Bug 20728] Remove subroutines GetLastOrder*
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20276] GetCourseItem is using the wrong call to get itemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|20728   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728
[Bug 20728] Remove subroutines GetLastOrder*
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/