[Koha-bugs] [Bug 20787] System preference missing from manual - UseACQFrameworkForBiblioRecords

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20787

Lee Jamison  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Lee Jamison  ---
This system preference has been added to the 18.05 documentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

--- Comment #18 from Lee Jamison  ---
Can anyone confirm if this is still relevant?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Eugene Espinoza  changed:

   What|Removed |Added

 CC||eugen...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #12 from Charles Farmer  ---
Went through the test plan with all 5 users and their respective permissions.

Only the fourth account, manage_circ_rules sans
parmeters_remaining_permissions, couldn't access the 'currencies' page after
update. Every other account gain access to 'Acquisitions' page, as described in
the test plan.

With the newest follow-up patch, I only saw two hyperlinks, 'Acqui home' and
'Currencies', when using accounts with restrictive permission sets.

Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20645] Print patrons before anonymise

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20645

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20606] Add the age column to statistics table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20606

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20605] Make possible to set patron's privacy from staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20605

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Charles Farmer  changed:

   What|Removed |Added

  Attachment #75452|0   |1
is obsolete||

--- Comment #10 from Charles Farmer  ---
Created attachment 75573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75573=edit
Bug 7651: Add a new permission for managing currencies and exchange rates

At the moment staff users need parameters or parameters_remaining_permissions
in order to be able to change exchange rates for acquisition orders.

This patch adds a new separate permission currencies_manage and
updates staff users currently having those permissions to get the
new permission as well.

To test:
- Create some staff users with different permission sets
  1) superlibrarian
  2) parameters
  3) parameters_remaining_permissions
  4) manage_circ_rules, but not parmeters_remaining_permissions
  5) all acquisition permissions
- Apply patch and run database update
- Verify new permission has been added and staff users updated
  1) remains the same
  2) + 3) will have currencies_manage
  4) remains unchanged, doesn't have new permission
  5) remains the same, will have access now because of having
 the top level acquisition permission
- Verify the changed pages work correctly:
  - navigation on admin home page
NOTE: the acquisition parameters section will now honor all
different related permissions (edi_manage, budget_manage,...)
  - navigation on acquisition home page
  - try to access currencies page directly

https://bugs.koha-community.org/show_bug.cgi?id=3849

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Charles Farmer  changed:

   What|Removed |Added

  Attachment #75517|0   |1
is obsolete||

--- Comment #11 from Charles Farmer  ---
Created attachment 75574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75574=edit
Bug 7651: (follow-up) Correct visibility on admin sidebar

This patch corrects visibility of links to the different
acquisition pages from the admin sidebar.

It also makes a correction to the links on the acq start
page:
- Budgets = period_manage
- Funds = budget_manage

To test:
- Follow the test plan of the first patch

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20604] Provide a way to anonymise patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20604

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20027] Generate password at patron detail edit page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20026] Add new permission related to personal data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20024] Backup files should be encrypted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Charles Farmer  changed:

   What|Removed |Added

  Attachment #75548|0   |1
is obsolete||

--- Comment #23 from Charles Farmer  ---
Created attachment 75572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75572=edit
Bug 12759: Use a list (shelf) for batch record modification and deletion

To test:
1) Create a list, add a record to it by its barcode that you don't mind
deleting
2) Go to Tools -> Batch record modification
3) Select the record type 'Authorities'. Confirm the dropdown to select
a list disappears. Confirm selecting 'Biblios' makes the dropdown show
again.
4) Select the list from the dropdown, select a modification template,
Continue
5) Confirm all of the records in that list show on the page. Click
Modify selected records. Confirm this is successful.
6) Go to Batch record deletion
7) Select the record type 'Authorities'. Confirm the dropdown to select
a list disappears. Confirm selecting 'Biblios' makes the dropdown
show again.
8) Select the list from the dropdown and click Continue
9) Confirm all of the records in that list show on the page. Click
Delete selected records. Confirm this is successful.
10) Go back to your lists. The list should still exist but it will now be
empty.

Sponsored-by: Catalyst IT

NOTE: Rebased to work -- Mark Tompsett

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #67 from Charles Farmer  ---
Had to remove the firstmost patch named "[SIGNED OFF] Changes to CCL.properties
...". Nothing lost, however, since it looked like a patch that was rebased but
not obsoleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20652] Sort After Item Type Search Fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652

Pierre-Luc Lapointe  changed:

   What|Removed |Added

 CC||pierre-luc.lapointe@inLibro
   ||.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20652] Sort After Item Type Search Fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652

Pierre-Luc Lapointe  changed:

   What|Removed |Added

  Attachment #74822|0   |1
is obsolete||

--- Comment #3 from Pierre-Luc Lapointe  ---
Created attachment 75571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75571=edit
Bug 20652: Fix result sorting after search on limit only

1 chomp was missing, spaces were replaced with %20
This patch adds extra chomps, but it does not hurt

Test plan:
Advanced Search
Choose an Item type (do not enter any other search limits)
Search
Click on Sort (it doesn't appear to matter what you sort on)

Signed-off-by: Pierre-Luc Lapointe 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Charles Farmer  changed:

   What|Removed |Added

  Attachment #25672|0   |1
is obsolete||
  Attachment #73617|0   |1
is obsolete||

--- Comment #65 from Charles Farmer  ---
Created attachment 75569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75569=edit
Bug 8962: Changes to CCL.properties, bib1 for authorities, and templates

This patch adds a new index Anywhere in ccl.properties in bib1 for authorities,
and add "any word" option in intranet search for using this index.
Default OPAC and intranet search in still using CCL "Any" index.

Testing plan :
In a Marc21 GRS-1 Koha :
1/ make some biblio searches without selecting any index (Koha will use "any"
index) and note the results. Ex : search "fre", "eng", "book", "history",
"history book"
2/ apply the 3 patches
3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth,
Unimarc bib) from your sources to the directory used by Zebra configuration in
your Koha instance
4/ launch rebuild_zebra.pl -b -r -x -v
5/ check that a new choice "Any word (all indexes)" is visible in advanced
search.
6/ make the same searches as 1/ : you should see less results (detailed test
plan in patchs 2 and 3)
7/ in Staff interface adavanced search, select "Any word (all indexes)" and
make the same searches as 1/ : you should see the same results (maybe with a
slight differences, because more notes fields are indexed in Marc21)

In a UNIMARC GRS-1 Koha :
same test

Signed-off-by: Martin Renvoize 

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Charles Farmer  changed:

   What|Removed |Added

  Attachment #73618|0   |1
is obsolete||

--- Comment #66 from Charles Farmer  ---
Created attachment 75570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75570=edit
Bug 8962: Restore Any index behavior and add Anywhere index

The "Any" index/register should contains all the data contained in all the
other indexes/registers (e.g. Title, Author, Subject, etc).

The "Anywhere" index/register should contain the entire record including
fields/subfields that aren't indexed anywhere else.

In GRS1 indexing the Any index was indeed only on fields defined as indexed.
This has changed in DOM where all data in MARC is indexed with Any.
This generates a lot of results when no index is defined in search.

This patch changes the DOM xsl config generation to add Any to each indexed
data and add Anywhere to keep a way of searching on all data.

Test plan :
- Add a data on a field that is not indexed : for example "toto" in 998$z
- Add same data as the title of another record
- Index the records
- Search on toto without index (uses Any) => you get the 2 records
- Search on toto with title index => you get the record with "toto" as title
- Apply patch
- Update DOM xsl config files
- Reindex
- Search on toto without index (uses Any) => you get the record with "toto" as
title
- Search on toto with title index => you get the record with "toto" as title
- Search on toto with Anywhere index => you get the 2 records

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Charles Farmer  changed:

   What|Removed |Added

  Attachment #75350|0   |1
is obsolete||

--- Comment #8 from Charles Farmer  ---
Created attachment 75568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75568=edit
Bug 3886: Fix mismatch of required permissions for printing slips

- Print summary (summary-print.pl)
- Print quick slip (printslip.pl)
- Print slip (printslip.pl)
- Print overdues (print_overdues.pl)

Perl scripts all require circulate_remaining_permissions, while
in the template we were checking for edit_borrowers.

Now the print pull down will only be visible if the patron has
circulate or circulate_remaining_permissions.

To test:
- Verify that printing the listed slips works for staff users
  with either circulate or circulate_remaining_permissions
  and without edit_borrowers.

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763

Pierre-Luc Lapointe  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||pierre-luc.lapointe@inLibro
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||charles.far...@inlibro.com

--- Comment #7 from Charles Farmer  ---
Works as advertised, though I had to manually enter the print-summary URL in
order to test, since my borrower only had the 'catalogue' and either
'circulate' or 'circulate_remaining_permissions' and couldn't directly visit
moremember.pl.

Are there any other pages available to a patron with such narrow permissions
where the printslip button appears?

Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763

pierre-luc.lapoi...@inlibro.com changed:

   What|Removed |Added

  Attachment #75302|0   |1
is obsolete||

--- Comment #2 from pierre-luc.lapoi...@inlibro.com ---
Created attachment 75567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75567=edit
Bug 20763: AllowPurchaseSuggestionBranchChoice triggers error
opac-suggestions.pl is visited without logging in

Some code executed in the script opac-suggestions.pl if the system preference
AllowPurchaseSuggestionBranchChoice is enabled assumes there is a logged in
user. If there is not, patrons will see the error "Internal Server Error".

Test Plan:
1) Enable AllowPurchaseSuggestionBranchChoice
2) Enable AnonSuggestions
3) In the OPAC, perform a search that will have no results,
   click the "Make a purchase suggestion" link.
4) Note the error
5) Apply this patch
6) Reload the page
7) The page should load now!

Signed-off-by: Pierre-Luc Lapointe 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20824] New: Display of cancelled Orders show up in Acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20824

Bug ID: 20824
   Summary: Display of cancelled Orders show up in Acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently, any orders that have been cancelled will show up in Acquisitions
(basket.pl). 
It would be nice from a display side, to have this view (cancelled orders ) be
collapsed so if needed, they are still viewable, but generally they do not
appear on this screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311

--- Comment #3 from Mirko Tietgen  ---
I'll send a patch that stops koha-common in preinst and starts it at the end of
postinst. I'd like to do a 18.05.00-2 together with bug 18250.

Together that should take care of stopping, starting memcached, koha-common
(incl. plack) and apache.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20820] koha fails to connect to memcached until restart after debian package upgrade 17.11.06-1 -> 18.05.00-1 on Ubuntu Xenial 16.04

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20820

Mirko Tietgen  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Mirko Tietgen  ---


*** This bug has been marked as a duplicate of bug 18250 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

Mirko Tietgen  changed:

   What|Removed |Added

 CC||heli...@centrum.sk

--- Comment #16 from Mirko Tietgen  ---
*** Bug 20820 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

--- Comment #15 from Mirko Tietgen  ---
Testplan does not work apply to systemd. However the patch still works, systemd
generates a target file

/run/systemd/generator.late/multi-user.target.wants/koha-common.service

Without patches

># Automatically generated by systemd-sysv-generator
>
>[Unit]
>Documentation=man:systemd-sysv-generator(8)
>SourcePath=/etc/init.d/koha-common
>Description=LSB: Start required services for each Koha instance
>Before=multi-user.target
>Before=multi-user.target
>Before=multi-user.target
>Before=graphical.target
>After=remote-fs.target

[…]

With the patches applied I get

># Automatically generated by systemd-sysv-generator
>
>[Unit]
>Documentation=man:systemd-sysv-generator(8)
>SourcePath=/etc/init.d/koha-common
>Description=LSB: Start required services for each Koha instance
>Before=multi-user.target
>Before=multi-user.target
>Before=multi-user.target
>Before=graphical.target
>After=remote-fs.target
>After=memcached.service

[…]

which means the patches do what they are supposed to do.

I don't know if we have an official policy regarding SysVinit vs. systemd. As
far as I can see we rely on the backwards compatibility provided by systemd in
other places too.

I'll send a signoff and consider to bundle it together with bug 17311 for a
18.05.00-2 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #71 from David Gustafsson  ---
Forgot to change status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #63 from Koha Team Lyon 3  ---
Bonjour Alex,
J'étais parti, le coeur plein d'entrain, pour une nouvelle séance de test sur
la nouvelle mouture de ton patch (tu as dû te régaler..), mais après mise à
jour d'une master de test que j'ai sur vbox (qu'avait pas servi depuis la
dernière fois), je me retrouve avec un affichage déglingué et je constate que
koha cherche à charger les css et js en leur ajoutant un suffixe
18.050 (ça ressemble à la date de mise à jour du patch ?!) :
http://preprod:8080/intranet-tmpl/prog/css/staff-global_18.050.css 
Soit j'ai fait une grosse bourde, soit il y a quelque chose qui m'échappe
(voire même les deux d'ailleurs ). ça te parle ? 

Olivier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15296] MEMBER logging in action_logs does not give enough detail.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296

--- Comment #3 from Caroline Cyr La Rose  ---
I agree that the info column doesn't give useful information.

There is already a kind of diff in the cataloguing action_logs, which I find 
somewhat useful because it gives you the "biblio before" so you can compare and
see what changed. It would be even better if there was the before / after but
something similar would be a good first step for the patron file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 75566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75566=edit
Bug 20823: UNIMARC XSLT add subfield t for subjects

In UNIMARC, 604 contains subfield t, see
http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf.
Actual XSLT files use template tag_subject for 604, it does not use t subfield.

This patch adds subfield t to tag_subject and tag_onesubject templates in
intranet and OPAC XSLT files.

Test plan :
1) In UNIMARC catalog edit a biblio record to add 604$t
2) Use default XSLT files in sysprefs
2) Go to catalogue details page of this record using default XSLT files
3) Check $t is displayed at OPAC and intranet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20823] New: UNIMARC XSLT does not display 604$t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823

Bug ID: 20823
   Summary: UNIMARC XSLT does not display 604$t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In UNIMARC, 604 contains subfield t.
Actual XSLT files use template tag_subject for 604, it does not use t subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #2 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #1)
> Hi Kyle, can you explain what FY18 means?

I have no idea, maybe JesseM does ; )

I have updated the title to actually describe the requires.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

Summary|Development FY18 New System |Add ability to choose if
   |Preference  |lost fee is refunded based
   ||on length of time item has
   ||been lost

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #31 from Kyle M Hall  ---
> What happens? Somehow $session is already undef when you call track. If we
> need to call CGI::Session->new($sessionID) each time, we do not really
> benefit in terms of db access (well: 1 lookup in sessions instead of 1 in
> borrowers).

That would at least be changing from 1 write to 1 read, which is definitely an
improvement, right?

> Is there a different approach? What about using a cache key? (Do we want to
> pollute the cache with keys for every session..)

So you're suggesting storing something like

--
my $cache = Koha::Caches->get_instance();
my $cache_key = "seen-for-session-$borrowernumber";
my $cached = $cache->get_from_cache($cache_key, { unsafe => 1});
unless ( $cached ) {
  $patron->track_login;
  $cache->set_in_cache($cache_key, 1);
}
--

If so, I think that works! Let me know and I'll submit a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20822] New: Can't find HOLD_SLIP template when printing.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822

Bug ID: 20822
   Summary: Can't find HOLD_SLIP template when printing.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: stefan.berndts...@ub.gu.se
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Printing HOLD_SLIP from the Hold found modal can't find the template.

In "returns.tt" the print action is sent "patron.borrowernumber", but the
print-slip template parameters in "returns.pl" only include "borrowernumber"
and "biblionumber", not "patron".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20821] Elasticsearch - problems in using CQL in the search box directly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20821

Nick Clemens  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com,
   ||claire.hernandez@biblibre.c
   ||om,
   ||ere.maij...@helsinki.fi,
   ||glask...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20821] New: Elasticsearch - problems in using CQL in the search box directly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20821

Bug ID: 20821
   Summary: Elasticsearch  - problems in using CQL in the search
box directly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

This was noted while testing bug 18163

In search box enter:
ti:beckett samuel - works 
ti,phr: beckett samuel - same results
title:beckett samuel - same results
title,phr:becket samuel - no results

ti:"beckett samuel" - no results
title:"beckett samuel" - no results

ti:"samuel beckett" - goes to record exactly
title:"samuel beckett" - goes to record exactly

ti,phr:"samuel beckett" - goes to record exactly
title,phr:"samuel beckett" - no results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #9 from Andrew Isherwood  ---
Test plan:

- Apply patches
- Enable ILL
- Ensure you have the FreeForm ILL backend available, a clone of the master
branch here is required: https://github.com/PTFS-Europe/FreeForm
- Create an request ILL using the FreeForm backend, populate as much metadata
as possible, ensuring to also supply some custom fields
- Save the request
- On the "Manage ILL request" page for the newly created request, select the
"Edit request metadata"
- On the resulting edit page:
  => TEST: Ensure all entered metadata is displayed
  -  Add new values, remove values, change values, including custom fields
  -  Click "Update"
- On the resulting "Manage ILL request":
  => TEST: Ensure all metadata fields reflect their changed values
- Repeat the editing and updating process until you're happy it works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

--- Comment #5 from Nick Clemens  ---
Created attachment 75565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75565=edit
Bug 18163: Pass through limits in ES

Before these patches we only allow a small subset of indexes to be used
as limits - if we are going to let users add new fields eventually we
probably don't want to strip out terms we didn't plan for.

To test:
1 - Enable ES
2 - Using sample kohadevbox data try a search like this (or adjust as
necessary):
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw=kw=kw=subject%2Cphr%3Astreet_by=relevance=Search
3 - Note nothing is found
4 - Apply patches
5 - Repeat search
6 - It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

--- Comment #4 from Nick Clemens  ---
Created attachment 75564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75564=edit
Bug 18163: Unit tests

prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #55 from Jonathan Druart  
---
(In reply to Narcis Garcia from comment #54)
> Is "template_cache_dir" parameter affected by this issue?

No

> I have Koha 17.11 running on Debian 9 without this directive. Should I
> enable it when following performance recommendations?

Yes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

Andrew Isherwood  changed:

   What|Removed |Added

 Depends on||7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Andrew Isherwood  changed:

   What|Removed |Added

 Blocks||20772


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772
[Bug 20772] Bib metadata pertaining to an ILL request should be editable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #8 from Andrew Isherwood  ---
Created attachment 75563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75563=edit
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |martin.renvoize@ptfs-europe
   ||.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20812] Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20812

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #2 from Tomás Cohen Arazi  ---
Podrías darnos mas informacion de contexto? Ese mensaje lo que dice es que se
intentó crear un campo MARC con numero de campo vacío. (por ejemplo, en vez de
020, vacio).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

--- Comment #9 from Tomás Cohen Arazi  ---
(In reply to Julian Maurice from comment #7)
> (In reply to Julian Maurice from comment #3)
> > So, the message should probably be "This method does not exist" rather than
> > "not covered by tests".
> 
> Any opinion on that ? Should I open a new bug ?

I agree. File a new one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20820] New: koha fails to connect to memcached until restart after debian package upgrade 17.11.06-1 -> 18.05.00-1 on Ubuntu Xenial 16.04

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20820

Bug ID: 20820
   Summary: koha fails to connect to memcached until restart after
debian package upgrade 17.11.06-1 -> 18.05.00-1 on
Ubuntu Xenial 16.04
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: heli...@centrum.sk
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

On Ubuntu Xenial 16.04, after upgrading koha from 17.11.06-1 to 18.05.00-1 from
official koha debian package, the following error is shown in the dpkg log and
accessing koha opac and koha intranet shows an unstyled interface.


...
Upgrade to 17.12.00.044 done (Bug 20624 - Disable OAuth2 client credentials
grant by default)
Upgrade to 18.05.00.000 done (Koha 18.05)

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues
Updated the cs-CZ translations.
Setting up libhijk-perl (0.26-1) ...
Setting up libtype-tiny-xs-perl (0.012-1build1) ...
Use of uninitialized value $fn in exists at
/usr/share/perl5/NeedRestart/Utils.pm line
100.=
  ]
Use of uninitialized value $fn in stat at /usr/share/perl5/NeedRestart/Utils.pm
line 102.
Use of uninitialized value in list assignment at
/usr/share/perl5/NeedRestart/Interp/Perl.pm line 132.
Use of uninitialized value $fn in exists at
/usr/share/perl5/NeedRestart/Utils.pm line
100.==
 ]
Use of uninitialized value $fn in stat at /usr/share/perl5/NeedRestart/Utils.pm
line 102.
Use of uninitialized value in list assignment at
/usr/share/perl5/NeedRestart/Interp/Perl.pm line 132.
Scanning processes...   
Scanning candidates...  
Scanning linux images...
Restarting services using systemd...
No containers need to be restarted.



$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 16.04.4 LTS
Release:16.04
Codename:   xenial

$ grep MEMCACHED_SERVERS /etc/koha/koha-sites.conf
# MEMCACHED_SERVERS: comma separated list of memcached servers (ip:port)
MEMCACHED_SERVERS="127.0.0.1:11211"

$ sudo systemctl status memcached.service 
● memcached.service - memcached daemon
   Loaded: loaded (/lib/systemd/system/memcached.service; enabled; vendor
preset: enabled)
   Active: active (running) since Fri 2018-05-25 13:01:18 CEST; 32min ago
 Main PID: 1016 (memcached)
Tasks: 6
   Memory: 12.1M
  CPU: 110ms
   CGroup: /system.slice/memcached.service
   └─1016 /usr/bin/memcached -m 64 -p 11211 -u memcache -l 127.0.0.1

May 25 13:01:18 koha systemd[1]: Started memcached daemon.

$ sudo netstat -tulpn | grep 11211
tcp0  0 127.0.0.1:11211 0.0.0.0:*   LISTEN 
1016/memcached  


The problem is not alleviated even after restarting the koha-common service and
the memcached service. It is resolved by restarting the host.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512

Stefan Berndtsson  changed:

   What|Removed |Added

 CC||stefan.berndts...@ub.gu.se

--- Comment #14 from Stefan Berndtsson  ---
(In reply to Marcel de Rooy from comment #11)
> Currently in Koha, if you choose to force a hold from the staff side that
> would contravened the current issuing rules, that hold will never be filled,
> as it is always skipped over by CheckReserves.
> 
> This patch disallows overrideing except for tooManyReserves which are the
> only overridden holds that will be trapped.

>From what I can see in the code, this isn't actually true. CheckReserves does
not include neither LOST nor WITHDRAWN in its checks. In fact, we use the LOST
part here.

When longoverdue.pl marks a book as LOST, our staff adds a reserve to that
item, so that they will be notified if it is returned. With the code prior to
this patch,
this works perfectly fine since we have the AllowHoldPolicyOverride set and
returning a LOST item fills the hold.

We've also used a similiar thing with withdrawn, but that's not as critical, so
I won't argue against that one.

The assumption that this is always skipped is not valid, unless I've missed
something.

We can patch things temporarily, but some sort of option for better override
selectability would probably be useful here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||18081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||20819


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
[Bug 20819] GDPR: Add a consent field for processing personal data
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20819] New: GDPR: Add a consent field for processing personal data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Bug ID: 20819
   Summary: GDPR: Add a consent field for processing personal data
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

See 18081

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75476|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 75562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75562=edit
Bug 2426: Remove deprecated management permission

After review of the code it turns out that the management permission
that has been marked as deprecated a long time ago, does not have
any function.

The patch removes all remaining code related to it.

To test:
- Make sure you have a patron with the management permission
- Apply patch
- Run database update
- Check everything still works as expected

Bonus:
borrowers.flags is recalculated for patrons with management
permission.

To check:
- Create some 'permission twins' with and without management
  permission
- Note the value in borrowers.flags
- Apply patch, don't run database update
- Save permissions from GUI for one of the twins
- Note the newly calculated value
- Run database update
- Now both twins should have the same borrowers.flags value

Signed-off-by: Owen Leonard 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 CC||m.de.r...@rijksmuseum.nl

--- Comment #10 from Marcel de Rooy  ---
> Bonus:
> borrowers.flags is recalculated for patrons with management
> permission.

No bonus imo.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17739] Opac explodes when clicking on user tag when using elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17739

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
This is the same issue as in 18822 - we assume we got MARC::Record objects from
zebra, but in this case we have raw xml fetched from the DB directly.

Possibly in the future we should index the tags and search them using the
search engine instead of a direct db call

*** This bug has been marked as a duplicate of bug 18822 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

Nick Clemens  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #15 from Nick Clemens  ---
*** Bug 17739 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68803|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 75561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75561=edit
Bug 18822: Check if we have MARC::Record and convert if not when using ES

The new_record_from_zebra subroutine assumes that when using ES we
always get MARC::Record objects when using ES, but sometimes we get them as xml
via Z39 or
internally. This adds a test to new_from_zebra to confirm we have a
record object and to convert it if not

To test:
1 - Perform an advanced search from the advanced editor, make sure to
select 'Local catalog' and a remote source
2 - Error 'Internal search error [Object object]'
3 - Apply patch
4 - Repeat search, success!
5 - Select and deselect various servers, search should still work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75499|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 75560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75560=edit
Bug 20756: Compiled CSS

This patch contains the compiled CSS file

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75498|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 75559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75559=edit
Bug 20756: OPAC "Share list" button should be styled with an icon

This patch adds a new "share" icon to the sprite image used to style
controls in the OPAC. The "share list" links now have a "sharelist"
class which is used to style the links with the new icon.

Also changed: Fixed the page structure markup of opac-shareshelf.tt.

To test you must have the OpacAllowSharingPrivateLists system preference
enabled.

 - Log in to the OPAC and go to Lists -> Your lists.
 - Create one or more private lists if necessary.
 - In the table of your lists there should be a "Share" link with the
   new icon.
 - View one of these lists and confirm that the "Share" link at the top
   of the table of list items.
 - Click through to the share list page and confirm that the page looks
   correct.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75481|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 75558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75558=edit
Bug 20791: Correct capitalization on 'Notices & slips' page

- Standardizes spelling to 'Notices & slips'

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75268|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 75557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75557=edit
Bug 20752: Fix capitalization on the files tab for patron files

- Activate EnableBorrowerFiles
- Go to any patron account in staff
- Go to the files tab
- Check that strings on the page ar all properly capitalized
  - button
  - legend on section

Signed-off-by: Owen Leonard 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20778] Unable to delete a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #5 from Marcel de Rooy  ---
I think we are not adding consistency in this script by removing a confirm from
one of the js functions in a row of similar ones.
Should you remove the other confirmation perhaps ?

If you have confirm_deletion as name, I would expect a confirm there too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75508|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 7
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7=edit
Bug 20774: Trivial HTML error in itemslost.tt

This patch makes a minor correction to the markup of the lost items
report template.

To test, apply the patch and run the lost items report with parameters
which will return results. The report results should look correct, and
the page should validate with no relevant errors.

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

--- Comment #8 from Marcel de Rooy  ---
(In reply to Julian Maurice from comment #7)
> (In reply to Julian Maurice from comment #3)
> > So, the message should probably be "This method does not exist" rather than
> > "not covered by tests".
> 
> Any opinion on that ? Should I open a new bug ?

This method is not supported ? If you only replace a few words, please add a QA
follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

--- Comment #4 from Marcel de Rooy  ---
I would prefer a patron consent field as a datetime somewhere. This helps us to
comply to the need to prove that a patron gave consent. It should be added to
self registration too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781

--- Comment #4 from Marcel de Rooy  ---
Created attachment 75554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75554=edit
Bug 20781: (QA follow-up) Remove unneeded rules

These rules do not have any meaning.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75437|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 75553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75553=edit
Bug 20781: Set a minimum enrollemnt period 'in months' of 1

To test:
 1 - Browse to Admin->Patron Categories
 2 - Click '+ New category'
 3 - Enter data as required, however, enter 0 in 'Enrolment period' ->
'in months'
 4 - Save
 5 - View the list of categories, the new category has 'Enrolment period'
= 'until'
 6 - Create a patron in this category, note their dateexipry is
'-00-00'
 7 - Search for them
 8 - internal server error
 9 - Delete that patron
10 - Apply patch
11 - Edit the category, note you cannot save with 0 months
12 - Set 1 month and save
13 - Create a patron in this cateogry
14 - Note they have a valid dateexpiry
15 - Search for them
16 - All works
17 - Create a new category and verify you cannot add with 0 months

Signed-off-by: Owen Leonard 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20768] Noisy test results when SearchEngine set to Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20768

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 19893 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #51 from Nick Clemens  ---
*** Bug 20768 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

--- Comment #7 from Julian Maurice  ---
(In reply to Julian Maurice from comment #3)
> So, the message should probably be "This method does not exist" rather than
> "not covered by tests".

Any opinion on that ? Should I open a new bug ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/