[Koha-bugs] [Bug 20860] New: List last e-mail address/SMS number/carrier sent to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20860 Bug ID: 20860 Summary: List last e-mail address/SMS number/carrier sent to Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org It would be helpful if the notifications listed the last e-mail address or SMS number and carrier that each notice was sent to. That way we know if the information was changed before/after the last failure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20859] New: SMS and other notification preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Bug ID: 20859 Summary: SMS and other notification preferences during self registration Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org Some libraries would prefer the option for patrons to choose their notification preferences and setup their SMS information during registration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 --- Comment #8 from Christopher Brannon --- (In reply to George Williams (NEKLS) from comment #7) > Working in a large consortium, I definitely want something like this. > > If a patron looks at the OPAC and sees a title with 30 items spread around > at different locations and 20 are already checked out and there are 15 > unfilled requests on the remaining 10 items the existing message can be > confusing if you're not at a branch where a copy is actually available to be > grabbed off of the shelf. > > Maybe the issue could be resolved by allowing for the wording of the wording > of the "Pending hold" message to be customized to suit the needs of the > library. If the message that displays when there is a pending hold on an > item could be tied to an authorised value, then each library could customize > the description of the item's availability in the staff client and the OPAC > to suit the needs of their library. If, for example, I want an item that is > hold_fill_targets to display a message that the item has a hold on it then I > can change the authorised value to read "Pending hold" but if I want it to > display the same availability as any other item on the shelf, I could change > the authorised value to read "Available." > > George I agree with George. This feature is needed, yet, we need to do it in a way that won't jeopardize how some libraries already use it. If it can be setup in a way we can tailor it, that would be great. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 --- Comment #9 from Claudio --- Jonathan, finally it works for me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 Owen Leonard changed: What|Removed |Added Attachment #75742|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 75743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75743&action=edit Bug 20840: (bug 2696 follow-up) Fix biblio info fetch There is no accountlines.biblionumber field, if the account line is linked to an item, accountline-details.pl will explode with: Template process failed: undef error - The method biblionumber is not covered by tests! Test plan: Create a fine for a given item Pay the fine View the detail of the account line => Without this patch you get a software error => With this patch applied you will see the biblio's title Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate --- Comment #11 from Jonathan Druart --- We need it to be backported to help debug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 --- Comment #7 from Jonathan Druart --- Created attachment 75742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75742&action=edit Bug 20840: (bug 2696 follow-up) Fix biblio info fetch There is no accountlines.biblionumber field, if the account line is linked to an item, accountline-details.pl will explode with: Template process failed: undef error - The method biblionumber is not covered by tests! Test plan: Create a fine for a given item Pay the fine View the detail of the account line => Without this patch you get a software error => With this patch applied you will see the biblio's title -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Severity|major |critical Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #12 from Owen Leonard --- Created attachment 75741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75741&action=edit Bug 20468: (follow-up) Changes to checkbox/menu interactions This patch makes a couple of minor interface changes and updates the way checkbox change events are handled: - jQueryUI tabs initialization sets a variable for "active table" which can be re-used by functions which affect only the visible table. - The batch "Actions" menu is shown or hidden based on whether there are checked items. - The item selection tools are shown or hidden based on whether there are rows in the table. To test, apply the patch and test various article request actions: - Single "process," "complete," and "cancel" operations. - Select all/ clear all operations on both tabs. - Batch operations with checked requests. - Process all pending requests to confirm the selection controls for that table are hidden. - Complete all processing requests to confirm the selection controls for that table are hidden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to create a new basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion --- Comment #3 from Jonathan Druart --- We can imagine 1. You are on the vendor view (/acqui/supplier.pl?booksellerid=X), click on "New > Duplicate a basket", then you select the order lines you want to duplicate. or 2. You are on the basket view (/acqui/basket.pl?basketno=X), click "Add to basket > From existing order lines" Then you get a form/table like the one we have to search order lines (acqui/histsearch.pl), then you select the ones you want to duplicate. In both case we will have another view to change the values you want to modify. We could also: 3. You are viewing an existing basket, you click on a "duplicate" link next to one of the orders. Then you select another basket in a list. That sounds less flexible, but could be implemented later -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |juan.sie...@xercode.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #96 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #95) > Very brave to take this upon you ! Thanks Marcel :) > Tiny suggestion: > .decimal-unformating > Fix spelling please. At least t => tt Indeed >< thanks for catching this. QA++ :) TODO implement > but what is decimal unformat btw? I followed this example: https://metacpan.org/pod/Number::Format#unformat_number($formatted) > Better name? Something with normalize or so?? .number-normalizing .number-normalizer .number-normalize .decimal-normalizing .decimal-normalizer .decimal-normalize Which one would be good enough? TODO wait answer, blocking question > I have the feeling that DecimalSeparators and CurrencyFormat don't really > harmonize. And yes, I can understand how problematic making changes in this > area must be.. > > So thousands separators come at the expense of handling both dots and commas. > Still opt for something that is more understandable. I'm not sure to understand. Is the the current state the patch on this topic acceptable? > The number of changes to be expected here would be much larger. You actually > use the new js formatting in three acq templates. > What about things like: > [...] > And this is just to name a few; the list could probably be larger when > searching harder. > It might be impossible to make global changes but the risk of this is adding > just another approach in a few places and leaving Koha even more fragmented > on the subject? I split the patch because the test plan was way too long. http://irc.koha-community.org/koha/2018-03-30#i_2024887 http://irc.koha-community.org/koha/2018-03-30#i_2024900 When this bug and bug 18723[1] will be in master there won't be more fragmentation than today. And less actually. locally: acquisitions and payments/fines will be internally less fragmented. as there are currently different behaviors in *successive pages* [2] globally: the new approach replaces an existing one (I checked that it not used elsewhere) see moneyFormat function. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=diff So, are these changes a step in the right direct worth of begin integrated? TODO wait answer, blocking question [1] which will also apply these changes to aqbudgetperiods.tt aqbudgets.tt in addition of the pages concerned by the bug description. [2] a big reason of why I get the most requests to fix decimal sep issues in these views -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to create a new basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #2 from Jonathan Druart --- Do we want to create a new basket by duplicating order lines from only one basket, or from several baskets? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20857] "Orders search" filters overlap the toolbar on the basket view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20857 --- Comment #1 from Jonathan Druart --- Created attachment 75740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75740&action=edit Bug 20857: Take the filters block into account to position the toolbar This does not work for 2 reasons: - additional_height is always 0, but even when moved inside the onclick block the height is not the correct one. - This mimicks what is done on members/memberentrygen.tt, but the way the block is toggled is different: $('.filteraction').toggle(); vs class="toggle_element" data-element="#filters,.filteraction" Maybe we should adjust that first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20857] New: "Orders search" filters overlap the toolbar on the basket view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20857 Bug ID: 20857 Summary: "Orders search" filters overlap the toolbar on the basket view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org https://screenshots.firefox.com/i7RA3SES6uYwKP2I/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 --- Comment #7 from George Williams (NEKLS) --- Working in a large consortium, I definitely want something like this. If a patron looks at the OPAC and sees a title with 30 items spread around at different locations and 20 are already checked out and there are 15 unfilled requests on the remaining 10 items the existing message can be confusing if you're not at a branch where a copy is actually available to be grabbed off of the shelf. Maybe the issue could be resolved by allowing for the wording of the wording of the "Pending hold" message to be customized to suit the needs of the library. If the message that displays when there is a pending hold on an item could be tied to an authorised value, then each library could customize the description of the item's availability in the staff client and the OPAC to suit the needs of their library. If, for example, I want an item that is hold_fill_targets to display a message that the item has a hold on it then I can change the authorised value to read "Pending hold" but if I want it to display the same availability as any other item on the shelf, I could change the authorised value to read "Available." George -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 --- Comment #6 from Claudio --- I'm so sorry Jonathan, I have not expressed myself correctly. I checked the log files out but did not identify any meaningful message about this issue. I have checked all log files in /var/log/koha/INSTANCE. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 --- Comment #5 from Jonathan Druart --- You should have something in the log file, please double-check :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855 Jonathan Druart changed: What|Removed |Added Version|17.11 |master Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855 --- Comment #2 from Jonathan Druart --- Personal note: 98 $getransf{'itemtype'} = $itemtype->description; # FIXME Should not it be translated_description? may cause problem if the item type is not defined in the itemtypes table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Could you give us a step by step plan to recreate the problem? Can you have a look at the Koha log file, you will find a more meaningful error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20846] Suppressed Records Still Appear in Public Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||14377 Version|17.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 [Bug 14377] Indicate that a record is suppressed in staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What|Removed |Added Blocks||20846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846 [Bug 20846] Suppressed Records Still Appear in Public Lists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 --- Comment #9 from Jonathan Druart --- Created attachment 75739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75739&action=edit Bug 20838: Add 2 small tests to check ref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 --- Comment #4 from Claudio --- Created attachment 75738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75738&action=edit Further samples -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 --- Comment #3 from Claudio --- Katrin, Jonathan I cannot identify a more meaningful message in the log files. See a new attached PDF with further samples. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- You should also see a more meaningful error in the log file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 --- Comment #29 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #27) > Move is not remove? I suggested to remove it: "4. Maybe we do not need may_article_request, but only guess_article_requestable_itemtypes?" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #24 from Jonathan Druart --- (In reply to Séverine Queune from comment #23) > Works as expected now :) > > What do you think about the tooltip or something similar ? Yes maybe, but I am not convinced. I would prefer to wait for another idea/opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #20 from Jonathan Druart --- Created attachment 75737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75737&action=edit Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added Attachment #75630|0 |1 is obsolete|| Attachment #75631|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 75736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75736&action=edit Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > After the require the new { acquisition => 'suggestions_manage' } they* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --- Comment #17 from Jonathan Druart --- We should highlight the change in the release notes: Before: members/purchase-suggestions.pl required { borrowers => 'edit_borrowers' } suggestion/suggestion.pl required { catalogue => 1 } After the require the new { acquisition => 'suggestions_manage' } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #20 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #19) > (In reply to Katrin Fischer from comment #18) > > It looks like this change introduced a regression. Before the changes it was > > possible to define the delay for unverified registrations in hours and now > > it's days. It will also change what actually happens when you switch over? > > > > With GDPR being very strict about saving data the initial feature of being > > able to delete after x hours would be better. > > I think you are being even stricter now :) Triggered by a request from a library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Katrin Fischer changed: What|Removed |Added Blocks||20856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 [Bug 20856] Restore ability to delete unverified self registrations after x hours -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20856] Restore ability to delete unverified self registrations after x hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 Katrin Fischer changed: What|Removed |Added Depends on||13049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 [Bug 13049] Merge selfreg cron jobs into cleanup_database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #19 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #18) > It looks like this change introduced a regression. Before the changes it was > possible to define the delay for unverified registrations in hours and now > it's days. It will also change what actually happens when you switch over? > > With GDPR being very strict about saving data the initial feature of being > able to delete after x hours would be better. I think you are being even stricter now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #22 from Jonathan Druart --- I do not know this code but seems quite old school and error prone. It seemed safer to not include it into 18.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #12 from Jonathan Druart --- There is a date range filter example in serials/claims.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20856] Restore ability to delete unverified self registrations after x hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 --- Comment #1 from Katrin Fischer --- To be fair, there is a note: IMPORTANT: You should no longer call this script. Please use cleanup_database.pl with parameter --del-unv-selfreg. Totally missed it, was only looking at the options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20856] New: Restore ability to delete unverified self registrations after x hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 Bug ID: 20856 Summary: Restore ability to delete unverified self registrations after x hours Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com With bug 13049 the behaviour of the was changed, so the number of hours defined for will be recalculated into days now (minimum 1). It would be nice if it was possible again to give the delay in hours. But we should at least change the help of delete_unverified_opac_registrations.pl to point out that limitation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #18 from Katrin Fischer --- It looks like this change introduced a regression. Before the changes it was possible to define the delay for unverified registrations in hours and now it's days. It will also change what actually happens when you switch over? With GDPR being very strict about saving data the initial feature of being able to delete after x hours would be better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20855] New: transferstoreceive.pl returns internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855 Bug ID: 20855 Summary: transferstoreceive.pl returns internal server error Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: luli...@ibwya.net QA Contact: testo...@bugs.koha-community.org /cgi-bin/koha/circ/transferstoreceive.pl returns internal server error on some of branches, but works fine on other branches. All these branches have some configuration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] New: Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Bug ID: 20854 Summary: Redirect after logout with CAS 3.0 broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org There has been a change in the parameters for the logout request between CAS 2.0 und CAS 3.0: Redirect URL parameter CAS 2.0: url CAS 3.0: service The CAS module used by Koha officially only support CAS 2.0, so when you logout from a CAS 3.0 server now, the redirect to Koha will be broken. See here: https://github.com/apereo/cas/blob/master/docs/cas-server-documentation/protocol/CAS-Protocol-Specification.md Note: The url parameter defined in the former CAS 2.0 specification is not a valid parameter in CAS 3.0 anymore. CAS Servers MUST ignore given url parameters. A CAS client MAY provide the service parameter as described above, as this ensures the parameter is validated against the registered service URLs when operating in non-open mode. See 2.3.2 for details. We are using the following 'hack' to make the redirect work correctly: C4/Auth_with_cas.pm $uri =~ s/\?logout\.x=1//; # We don't want to keep triggering a logout, if we got here, the borrower is already logged out of Koha -print $query->redirect( $cas->logout_url(url => $uri)); +my $logout_url = $cas->logout_url(url => $uri); +$logout_url =~ s/url/service/; +print $query->redirect( $logout_url ); We won't have time to fix this properly, but wanted to document problem and workaround at least. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #11 from Andrew Isherwood --- Hi Jonathan Thanks for your feedback. 1. OK, addressed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75734 2. OK, addressed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75735 3. Thanks for the pointer towards title-string. I have used the *_formatted fields to allow me to display the date fields in the datatable according to the date format set in the sysprefs. Since the data is coming in to the datatable from an API call, I'm not sure how else I can do it. $KohaDates obviously won't work, I couldn't get title-string to either, though, having done some research, it appears it is used to control sorting, rather than display formatting. 4. Good point, I'll create a follow-up patch and submit it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20722] Searching only for an ITEMTYPECAT itemtype is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20722 --- Comment #5 from Katrin Fischer --- Could this be considered for backporting to 17.11? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #10 from Andrew Isherwood --- Created attachment 75735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75735&action=edit Bug 20600: (follow-up) Remove date formatting It is not required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #9 from Andrew Isherwood --- Created attachment 75734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75734&action=edit Bug 20600: (follow-up) Do not use $_ in loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #75729|0 |1 is obsolete|| --- Comment #46 from Kyle M Hall --- Created attachment 75733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75733&action=edit Bug 18821: (QA follow-up) Last tweaks for performance [1] passing unsafe has no use since it is a scalar, removed it to unconfuse [2] remove caching when pref is disabled [3] caching userid removes the need for calling Patron->find each time [4] subsequent changes in unit test [5] cosmetic renames to move from session to daily basis (changed dev angle) Signed-off-by: Marcel de Rooy First call going thru Koha::Patron takes about 0.0150 sec. Subsequent calls only use caching and take about 0.0006 sec. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #95 from Marcel de Rooy --- Preliminary QA: Very brave to take this upon you ! Tiny suggestion: .decimal-unformating Fix spelling please. At least t => tt but what is decimal unformat btw? Better name? Something with normalize or so?? I have the feeling that DecimalSeparators and CurrencyFormat don't really harmonize. And yes, I can understand how problematic making changes in this area must be.. So thousands separators come at the expense of handling both dots and commas. Still opt for something that is more understandable. The number of changes to be expected here would be much larger. You actually use the new js formatting in three acq templates. What about things like: C4/Biblio.pm:$subfield_value =~ s/\./,/ if C4::Context->preference("CurrencyFormat") eq "FR"; acqui/addorderiso2709.pl:$price =~ s/\./,/ if C4::Context->preference("CurrencyFormat") eq "FR"; acqui/addorderiso2709.pl:$price =~ s/\./,/ if C4::Context->preference("CurrencyFormat") eq "FR"; Koha/Number/Price.pm $format_params = { %$format_params, int_curr_symbol => '', mon_thousands_sep => '', mon_decimal_point => '.', }; koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc [% IF Koha.Preference("CurrencyFormat") == 'FR' %] var default_value = { thousands_sep: ' ', decimal_point: ',', decimal_digits: 2 }; And this is just to name a few; the list could probably be larger when searching harder. It might be impossible to make global changes but the risk of this is adding just another approach in a few places and leaving Koha even more fragmented on the subject? Changing state for need of feedback or adjustments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #79 from David Gustafsson --- Ok! This should now be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #8 from Marcel de Rooy --- Test coverage of all_libraries is rather limited.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added Attachment #75701|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 75732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75732&action=edit Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added Attachment #75700|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 75731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75731&action=edit Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #78 from David Gustafsson --- Created attachment 75730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75730&action=edit Bug 18316: Fix field weight validation/deletion bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #5 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 --- Comment #7 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #6) > Not sure to understand what you are expecting. If i remove the 2 others JS > confirmation (for closing and reopening), we have no more confirmation at > all. I did it for deleting because there is an other one after. So the JS > one is useless. > > Other possibility is to remove the one after JS for subscription deletion. > > I agree that this BZ is for fixing subscription deleting. Not for removing a > useless confirmation. So i can just do what it is expected for Yeah. Consider removing the one after the JS confirm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #45 from Marcel de Rooy --- Created attachment 75729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75729&action=edit Bug 18821: (QA follow-up) Last tweaks for performance [1] passing unsafe has no use since it is a scalar, removed it to unconfuse [2] remove caching when pref is disabled [3] caching userid removes the need for calling Patron->find each time [4] subsequent changes in unit test [5] cosmetic renames to move from session to daily basis (changed dev angle) Signed-off-by: Marcel de Rooy First call going thru Koha::Patron takes about 0.0150 sec. Subsequent calls only use caching and take about 0.0006 sec. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Attachment #75634|0 |1 is obsolete|| Attachment #75635|0 |1 is obsolete|| --- Comment #43 from Marcel de Rooy --- Created attachment 75727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75727&action=edit Bug 18821: TrackLastPatronActivity is a performance killer Test Plan: 1) Apply this patch 2) Start a new session ( a private browser window works well ) 3) Note the lastseen column in the borrowers table is updated 4) Browse a few pages, not the lastseen column is not updated again 5) Close the browser window and repeat steps 2-4 6) prove t/db_dependent/Auth.t Signed-off-by: Charles Farmer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #44 from Marcel de Rooy --- Created attachment 75728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75728&action=edit Bug 18821: Convert to using cache with date checking Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #42 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #35) > I actually think a hybrid of your first and second suggestions is the best > solution. We should use cache *and* test a date! Why do you think we will > use too much memory? Let's assume we have 1000 simultaneous users. That's > still a minuscule amount of memory compared to caching the marc frameworks, > for example. On second thought, the consumed cache may be very limited indeed. Nice! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #6 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #5) > I think we are not adding consistency in this script by removing a confirm > from one of the js functions in a row of similar ones. > Should you remove the other confirmation perhaps ? > > If you have confirm_deletion as name, I would expect a confirm there too. Hello Marcel, Not sure to understand what you are expecting. If i remove the 2 others JS confirmation (for closing and reopening), we have no more confirmation at all. I did it for deleting because there is an other one after. So the JS one is useless. Other possibility is to remove the one after JS for subscription deletion. I agree that this BZ is for fixing subscription deleting. Not for removing a useless confirmation. So i can just do what it is expected for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20853] New: Show holding library for item level article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20853 Bug ID: 20853 Summary: Show holding library for item level article requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice if more information about the item was shown for article requests on item level. At the moment the callnumber and the barcode is shown, but not all libraries assign unique callnumbers per item and not always barcodes for serial issues. It would be nice if we could at least show the holding library for the item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20852] New: Make "All libraries" default organisation for article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20852 Bug ID: 20852 Summary: Make "All libraries" default organisation for article requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com At the moment the pick-up location a user selects in the OPAC will decide which library the article request shows up for in the interface. The tabs are organized by pick-up location. - There is no label stating it's the pickup location in the staff interface. - The pick-up library is not necessarily the library, that will the article request. So for processing new article requests the workflow is not ideal, as the library always has to switch to 'all libraries' in order to see requests they possibly have to process. As Koha allows article requests to be set on record level, Koha doesn't know which libraries might be able to fill the article request. So it might be best to optionally allow setting to "all libraries" and also adapt the note on the dashboard accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #77 from Alex Arnaud --- The patch "Bug 18316: Change search field weight field to decimal" seems to break the ability to erase weights. I.e - set weihgt to 1.25 for title, - save, - erase (empty) the weight input for title, - save, - weight is still here with the same value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #72 from Alex Arnaud --- (In reply to Koha Team Lyon 3 from comment #65) > Just a little thing about ergonomy of "Week(s) not published" scrolldown > list : when you tick/untick a checkbox at first time, the form jumps > surprisingly. > Could we avoid this ? > Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #75406|0 |1 is obsolete|| --- Comment #69 from Alex Arnaud --- Created attachment 75724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75724&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #75407|0 |1 is obsolete|| --- Comment #70 from Alex Arnaud --- Created attachment 75725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75725&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #75408|0 |1 is obsolete|| --- Comment #71 from Alex Arnaud --- Created attachment 75726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75726&action=edit Bug 17656: move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #75405|0 |1 is obsolete|| --- Comment #68 from Alex Arnaud --- Created attachment 75723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75723&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #75404|0 |1 is obsolete|| --- Comment #67 from Alex Arnaud --- Created attachment 75722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75722&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #75403|0 |1 is obsolete|| --- Comment #66 from Alex Arnaud --- Created attachment 75721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75721&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #41 from Marcel de Rooy --- QA: Having another look here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > Created attachment 75720 [details] [review] > Bug 20468: (QA follow-up) Design issues > > Moving selection stuff to the top. > Why does the dropdown menu act so weird ? Owen, any idea why the menu does like it does? I remember spending too much time on it before already ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #10 from Marcel de Rooy --- Created attachment 75720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75720&action=edit Bug 20468: (QA follow-up) Design issues Moving selection stuff to the top. Why does the dropdown menu act so weird ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #9 from Marcel de Rooy --- (In reply to Owen Leonard from comment #6) > I agree with Joubu. In order to be consistent with every similar interface > in Koha the select all/clear all links should be at the top of the table, > inside the tab. > > Ideally the multi-action button should be disabled until there is a > selection. If not, there should at least be a warning triggered when you > choose one of those actions. Something like, "You must select one or more > titles." Design failures are the worst ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #8 from Marcel de Rooy --- (In reply to Owen Leonard from comment #7) > By the way, I get an error when I try to print a slip: "Undefined subroutine > &C4::Letters::GetPreparedLetter called at > /home/vagrant/kohaclone/circ/article-request-slip.pl line 49." Could not reproduce this one. But to be safe, added the module on bug 20851. Not related to this report btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #1 from Marcel de Rooy --- Created attachment 75719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75719&action=edit Bug 20851: Add module to circ/article-request-slip.pl See bug 20468, comment7. Although the script seems to compile well, we better add the module here. Trivial change. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Moving trivial fix to SO rightaway -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |trivial Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] New: Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Bug ID: 20851 Summary: Missing module in circ/article-request-slip.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org >From 20468, comment7 by Owen Leonard: By the way, I get an error when I try to print a slip: "Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/circ/article-request-slip.pl line 49." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 --- Comment #28 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #26) > > > 3. The cache is cleared in a very lazy way :) > > Lazy is good enough here imo. > > I do not think so, the cache is flushed every time the page is hit. The L1 cache is cleared. I do not see the need to remove it frequently from memcached. If we change smart rules, it is cleared (even more strict than needed; read: programmer's lazy). This cache is just for faster presentation, no threat for bad data or so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/