[Koha-bugs] [Bug 20889] Items marked as not for loan can be checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #11 from Fridolin SOMERS --- Depends on Bug 19943 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20889] Items marked as not for loan can be checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Fridolin SOMERS changed: What|Removed |Added Blocks||20866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 [Bug 20866] ArticleRequests.t fails on existing requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS --- Depends on Bug 18403 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Depends on||18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 paxed changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi --- Comment #1 from paxed --- Created attachment 76016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76016&action=edit Bug 20927: moredetail.pl crash on nonexistent biblionumber moredetail.pl crashes when trying to view a nonexistent biblionumber. The case should be handled like it is done in detail.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] New: moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Bug ID: 20927 Summary: moredetail.pl crash on nonexistent biblionumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org moredetail.pl crashes when trying to view a nonexistent biblionumber. The case should be handled like it is done in detail.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20925] New: Changing font color for pipes between list items in #moresearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925 Bug ID: 20925 Summary: Changing font color for pipes between list items in #moresearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: k...@bywatersolutions.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Work to be done: 1 - Add a new system preference "MoreSearches" 2 - Append the contents of this syspref to the auto generated links in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20926] New: Changing font color for pipes between list items in #moresearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20926 Bug ID: 20926 Summary: Changing font color for pipes between list items in #moresearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: je...@bywatersolutions.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Work to be done:,1 - Add a new system preference "MoreSearches",2 - Append the contents of this syspref to the auto generated links in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Attachment #72548|0 |1 is obsolete|| Attachment #72549|0 |1 is obsolete|| Attachment #72550|0 |1 is obsolete|| Attachment #72551|0 |1 is obsolete|| --- Comment #48 from Aleisha Amohia --- Created attachment 76015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76015&action=edit Bug 14272: Show single news item [alternative patch] This is a new patch for this bug that shows a single news item on the OPAC using Koha Objects (Koha::News). To test: 1) Go to Tools -> News on staff interface, make a news item to show on the OPAC 2) Go to OPAC 3) Notice news item shows and title cannot be clicked 4) Apply patch, refresh page 5) Notice title is now a link. Click title 6) Confirm breadcrumbs shows title of news item 7) Confirm RSS feed and OpacMainUserBlock are not visible 8) In the URL, change the news_id param to an ID that does not exist 9) Confirm that an appropriate error message shows Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Depends on||20924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 [Bug 20924] News content textarea not showing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Aleisha Amohia changed: What|Removed |Added Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Aleisha Amohia changed: What|Removed |Added Blocks||14272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 [Bug 14272] Allow OPAC to show a single news item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 --- Comment #1 from Aleisha Amohia --- Created attachment 76014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76014&action=edit Bug 20924: Make news content textarea show To test: 1) Go to Tools -> News 2) Edit existing news item or add new news item 3) Notice content box is missing, can't edit news or add any content 4) Apply patch, refresh page 5) Notice textarea now shows Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] New: News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Bug ID: 20924 Summary: News content textarea not showing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Created attachment 76013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76013&action=edit screenshot showing missing textarea when adding new or editing exiting koha news item, the content textarea box does not show. /cgi-bin/koha/tools/koha-news.pl?op=add_form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
--- Comment #59 from Aleisha Amohia ---
Created attachment 76012
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76012&action=edit
Bug 17698: [FOLLOW-UP] Fixing things in Comment 57
3. In the JS console: "ReferenceError: $ is not defined", I did not
investigate it.
Where do you see this in the console? I cannot recreate on opac-user.pl
or on circ/checkout-notes.pl.
5. The alert id=error is displayed then hide in JS, but it's then
displayed half a second. We should hide it by default (css)
Fixed in this patch
6. I would move the "mark seen" and "mark not seen" buttons at the
top of the table
Fixed in this patch
8. Cursor on "Select all" and "Clear all" links must be adjusted
Fixed in this patch
9. $(".btn-xs").click(function(event){
The selector should be $("button.seen, button.notseen"), you
do not want to apply this function to all other btn-xs on
the page (maybe there are only two for now, but who knows
later?)
Fixed in this patch
12. Important: When a note is updated, it's still marked as
seen. Is it the expected behavior?
I don't see this behaviour. When a note is updated it is
marked as not seen.
opav/svc/checkout_notes:79: $issue->set({ notedate =>
dt_from_string(), note => $clean_note, noteseen => 0
})->store;
13. What will happen when hundred of notes will be on this
table? Not blocker but we will need a "hide seen" buttons to
filters the already seen notes.
Added in this patch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #58 from Jonathan Druart --- Created attachment 76011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76011&action=edit Bug 17698: (QA follow-up) Fix minors design issues This patch includes some changes required on comment 57: 1. Bad resolution conflict, permission self_checkout is re-add 2. The IGNORE modifier is missing in the INSERT statement 4. When I hit /circ/checkout-notes.pl from the side bar, the page displays "Checkout notes", nothing else. We should add "There is no checkout notes". 7. I would display the table on the confirmation screen as well 10. html filters are missing 11. span element should surround translatable string, to help translators 14. patron-title.inc must be used to display patron's info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #57 from Jonathan Druart
---
1. Bad resolution conflict, permission self_checkout is re-add (I will fix)
2. The IGNORE modifier is missing in the INSERT statement (I will fix)
3. In the JS console: "ReferenceError: $ is not defined", I did not investigate
it.
4. When I hit /circ/checkout-notes.pl from the side bar, the page displays
"Checkout notes", nothing else. We should add "There is no checkout notes". (I
will fix)
5. The alert id=error is displayed then hide in JS, but it's then displayed
half a second. We should hide it by default (css)
6. I would move the "mark seen" and "mark not seen" buttons at the top of the
table
7. I would display the table on the confirmation screen as well (I will fix)
8. Cursor on "Select all" and "Clear all" links must be adjusted
9. $(".btn-xs").click(function(event){
The selector should be $("button.seen, button.notseen"), you do not want to
apply this function to all other btn-xs on the page (maybe there are only two
for now, but who knows later?)
10. html filters are missing (I will fix)
11. span element should surround translatable string, to help translators (I
will fix).
12. Important: When a note is updated, it's still marked as seen. Is it the
expected behavior?
13. What will happen when hundred of notes will be on this table? Not blocker
but we will need a "hide seen" buttons to filters the already seen notes.
14. patron-title.inc must be used to display patron's info (I will fix)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 --- Comment #3 from Blou --- I applied the patch and upgrade from 3.0 to 17.12.00.044 with success. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Blou changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Blou changed: What|Removed |Added Attachment #76006|0 |1 is obsolete|| --- Comment #2 from Blou --- Created attachment 76010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76010&action=edit Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl Koha::Number::Format->round use Number::Format->round with a precision=2 We should use it directly instead of Koha::* modules. It will avoid the DB entry to fail because schema changes. >From the koha-devel list: http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html 16.06.00.042 Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher) DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( `active` = ? )" with ParamValues: 0=1] at /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.p_sep_by_space' in 'field list' at /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209 Basically, the update code uses Koha::Number::Price, which in full modern object mode goes for its newly added *p_sep_by_space* _in the 18.05 code_. But the DB doesn't have it yet (it comes with 17.12.00.022). Signed-off-by: Blou -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #245 from Jonathan Druart --- 1. aqbasketgroups.closedate is set to NOW, maybe better to use basket.closedate (the latest)? 2. ->bookseller should be ->vendor (not blocker as we already have both in Koha::*...) 3. a. I would not "cache" ->baskets, we already deal with the context in Koha::Objects->search b. ->baskets_count - no need to have it, it should be replaced with baskets->count => Maybe you want to keep them for performance purpose, but is it really a performance improvement? 5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now. We may want to display a friendly message if called without a [valid] id 6. basketgroups.tt should have JS at the bottom 7. Some links still point to basketgroup.pl?booksellerid=X without the basketgroupid, they should be replaced right? i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be removed (?) 8. Are you sure you need the changes done to C4::Acquisition? 9. acqui/basketgroup.pl + use List::MoreUtils qw/uniq/; => Not needed 10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to init a table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #28 from Tomás Cohen Arazi --- C4::Search:584 is a closer example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Tomás Cohen Arazi --- Almost there. The result looks funny because it is showing codes instead of descriptions. Take a look at C4::Search:570 and you will understand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Attachment #75997|0 |1 is obsolete|| --- Comment #25 from Tomás Cohen Arazi --- Created attachment 76008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76008&action=edit Bug 18322: (followup) Add generated xsl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 76009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76009&action=edit Bug 18322: Update xslt for NORMARC and UNIMARC Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67823|0 |1 is obsolete|| --- Comment #24 from Tomás Cohen Arazi --- Created attachment 76007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76007&action=edit Bug 18322: Add a facet for ccode fields to Zebra This patch adds the index definitions for zebra faceting of ccode in koha for marc21, normarc and unimarc. We also add lines to the templates to expose the new facet and enable non-zebra faceting for ccode too. Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #2 from Jerome Charaoui --- Debian 9.4 (stretch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #1 from Jonathan Druart --- Which versions of Debian and/or Ubuntu did you test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I think we already have the branch in the source code, but in another spot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Jonathan Druart changed: What|Removed |Added Version|18.05 |master Assignee|koha-b...@lists.koha-commun |jchara...@cmaisonneuve.qc.c |ity.org |a CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords||dependency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20923] New: Merging backend status graph into main status graph incorrect use of grep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923
Bug ID: 20923
Summary: Merging backend status graph into main status graph
incorrect use of grep
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: ILL
Assignee: koha-bugs@lists.koha-community.org
Reporter: andrew.isherw...@ptfs-europe.com
When the Illrequest object is being constructed, it consults the status graphs
for enabled backends. These status graphs are then merged into the main graph
in order to provide the full workflow for a request.
As part of this process, the "next_actions" property is updated to reflect any
new statuses. During this, a check is performed to determine if the status
graph knows about the next status being declared by a backend status graph:
if ( grep $prev_action, @core_status_ids ) {
This is incorrect. According to http://perldoc.perl.org/functions/grep.html,
the first parameter should be a block or expression, here we are passing a
string. This malfunctions in so much as passing "REQ" with match twice in the
following array [ "REQ", "REQREV" ], this is not what we would expect.
The fix is to substitute the following line:
if ( grep /^$prev_action$/, @core_status_ids ) {
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20923] Merging backend status graph into main status graph incorrect use of grep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Jonathan Druart changed: What|Removed |Added Blocks||19789 Depends on|19789 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 [Bug 19789] Remove some indirect DBIx calls from updatedatabase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19789] Remove some indirect DBIx calls from updatedatabase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart changed: What|Removed |Added Depends on||20922 Blocks|20922 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Jonathan Druart changed: What|Removed |Added Depends on||19789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 [Bug 19789] Remove some indirect DBIx calls from updatedatabase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19789] Remove some indirect DBIx calls from updatedatabase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789
Jonathan Druart changed:
What|Removed |Added
Blocks||20922
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #1 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #0)
> L13526 and context: Koha::Number::Price->new( $order->{rrp} )->round;
> Only new calls seem to be fine. But might be tricky.
Done on bug 20922.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922
[Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 --- Comment #1 from Jonathan Druart --- Created attachment 76006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76006&action=edit Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl Koha::Number::Format->round use Number::Format->round with a precision=2 We should use it directly instead of Koha::* modules. It will avoid the DB entry to fail because schema changes. >From the koha-devel list: http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html 16.06.00.042 Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher) DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( `active` = ? )" with ParamValues: 0=1] at /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.p_sep_by_space' in 'field list' at /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209 Basically, the update code uses Koha::Number::Price, which in full modern object mode goes for its newly added *p_sep_by_space* _in the 18.05 code_. But the DB doesn't have it yet (it comes with 17.12.00.022). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What|Removed |Added Blocks||20922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13321] Fix tax and prices calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart changed: What|Removed |Added Blocks||20922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Jonathan Druart changed: What|Removed |Added Depends on||4078, 13321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 [Bug 13321] Fix tax and prices calculation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] New: Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Bug ID: 20922 Summary: Koha::Number::Price must not be used in updatedatabase.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org >From the koha-devel list: http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html 16.06.00.042 Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher) DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( `active` = ? )" with ParamValues: 0=1] at /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.p_sep_by_space' in 'field list' at /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209 Basically, the update code uses Koha::Number::Price, which in full modern object mode goes for its newly added *p_sep_by_space* _in the 18.05 code_. But the DB doesn't have it yet (it comes with 17.12.00.022). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921
--- Comment #1 from Nick Clemens ---
Created attachment 76005
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76005&action=edit
Bug 20921: Add borrowernumber and branchcode as html attributes
To test:
1 - Apply patch
2 - Visit the opac
3 - Sign in
4 - You should not see any difference
5 - Inspect the element 'Welcome, {username}'
6 - Note the attributes for borrowernumber and branchcode
7 - Add to OPACUserJS:
$(document).ready(function(){
console.log( $(".loggedinusername").attr('branchcode'));
console.log( $(".loggedinusername").attr('borrowernumber'));
});
8 - Check the console and note you can see the info expected
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Works as expected and passes all tests. I'm happy with it and Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 Martin Renvoize changed: What|Removed |Added Attachment #76003|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 76004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76004&action=edit Bug 20760: Fill authorised values in svc framework To test: 1 - Map a marc field to an authorised value in the default framework - say 300$c -> CCODE 2 - Open the advanced cataloguing editor 3 - Create a new field 300$c - note there is no dropdown 4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define 5 - Note the many instance of Koha::Schema::ResultSet::AuthorisedValueCategory->HASH... 6 - Apply patch 7 - Restart memcached and plack 8 - reload/recreate record in rancor 9 - Note that 300$c is now a dropdown as expected 10 - repeate 4 11 - note the authorised values look correct in response Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] New: Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Bug ID: 20921 Summary: Expose borrowernumber and branch when user is logged in to OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some libraries would like the ability to trigger javascript ofr users of a certain branch or specific borrowers. There is currently no way to retrieve this information on the opac. This patchset will add these two variables as attributes on the loggedinusername span -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #124 from Jonathan Druart --- (In reply to Jonathan Druart from comment #113) > Bug 12395: Save order line's creator > reverts bug 20303 This one is still missing I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 --- Comment #11 from Nick Clemens --- I agree with Joubu, we don't need the sort and his patch is better (as usual, *sigh*) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Please provide tests to cover this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 Nick Clemens changed: What|Removed |Added Attachment #75291|0 |1 is obsolete|| Attachment #75779|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 76003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76003&action=edit Bug 20760: Fill authorised values in svc framework To test: 1 - Map a marc field to an authorised value in the default framework - say 300$c -> CCODE 2 - Open the advanced cataloguing editor 3 - Create a new field 300$c - note there is no dropdown 4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define 5 - Note the many instance of Koha::Schema::ResultSet::AuthorisedValueCategory->HASH... 6 - Apply patch 7 - Restart memcached and plack 8 - reload/recreate record in rancor 9 - Note that 300$c is now a dropdown as expected 10 - repeate 4 11 - note the authorised values look correct in response Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 Nick Clemens changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20911] Search history page forms use 'GET' and this limits the number of entries that can be submitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911 Jonathan Druart changed: What|Removed |Added Attachment #75966|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 76002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76002&action=edit Bug 20911: Use 'POST' to submit search history forms To test: 1 - Enable EnableOpacSearchHistory and EnableSearchHistory 2 - Do some searches 3 - View your search history in staff/opac 4 - Confirm you can delete single or multiple rows 5 - Confirm other page functionality has not changed Signed-off-by: Ed Veal Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20911] Search history page forms use 'GET' and this limits the number of entries that can be submitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20911] Search history page forms use 'GET' and this limits the number of entries that can be submitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892 Jonathan Druart changed: What|Removed |Added Attachment #75943|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 76001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76001&action=edit Bug 20892: Correct basketgroup link in histsearch.pl When searching an order, histsearch.pl page, you see if exists the backetgroup as a link. This link is composed of "basketgroup.pl?booksellerid=xxx", it must also contain "basketgroupid=xxx" and "opa=add". See Bug 11429 for example. Test plan : 1) Create an order in a basket and add it to a basketgroup 2) Search for this order, you get to page histsearch.pl 3) Check clicking on basketgroup id leads to basketgroup details page Signed-off-by: Amit Gupta Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] New: Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Bug ID: 20920 Summary: Plack timeout because of missing CGI::Compile Perl dependency Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: jchara...@cmaisonneuve.qc.ca QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net Created attachment 76000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76000&action=edit Patch for debian/control The Debian/Ubuntu package is missing a dependency on libcgi-compile-perl. Without this package installed, when Plack is enabled/started, the webserver is unresponsive and the following errors appear in the logs: Error while loading /etc/koha/plack.psgi: Can't locate CGI/Compile.pm in @INC (you may need to install the CGI::Compile module) (@INC contains: /usr/share/koha/lib /us r/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5 /5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /usr/share/perl5/Plack /App/WrapCGI.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/WrapCGI.pm line 8. Compilation failed in require at /usr/share/perl5/Plack/App/CGIBin.pm line 6. BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/CGIBin.pm line 6. Compilation failed in require at /etc/koha/plack.psgi line 21. BEGIN failed--compilation aborted at /etc/koha/plack.psgi line 21. Attached is a patch to add this package to the debian/control file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Jerome Charaoui changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Good spot, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Martin Renvoize changed: What|Removed |Added Attachment #75994|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 75999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75999&action=edit Bug 20918: Fix left-side navigation on the checkout history page commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: -biblionumber => $biblionumber, # required for left-side navigation But did not deal with the side-effects. Test plan: When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken if this patch is not applied, the biblionumber is not set. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Works as expected :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Martin Renvoize changed: What|Removed |Added Attachment #75975|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 75998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75998&action=edit Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #40 from Jonathan Druart --- I have amended the last 2 patches: 1. rename atomic update file and 2. remove the line from commit message that was not related to the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #23 from Martin Renvoize --- Created attachment 75997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75997&action=edit Bug 18322: (followup) Add generated xsl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart changed: What|Removed |Added Attachment #74642|0 |1 is obsolete|| --- Comment #39 from Jonathan Druart --- Created attachment 75996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75996&action=edit Bug 18235: Add unit tests for get_facetable_fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart changed: What|Removed |Added Attachment #72999|0 |1 is obsolete|| --- Comment #38 from Jonathan Druart --- Created attachment 75995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75995&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Hugo Agud changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] New: A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Bug ID: 20919 Summary: A Zebra query is done for each item when opening a record detail page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ha...@orex.es QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We have figured out that koha launch a zebra query for each item of a record, if the record have few items no problem, but if the record has hundreds of items, the time to display goes easily over 30 seconds. we have checked on a fresh install on debian jessie 8 with koha 17.11.6 and 18.05 the file zebra-output.log becomes huge We have checked from intranet interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 --- Comment #1 from Jonathan Druart --- Created attachment 75994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75994&action=edit Bug 20918: Fix left-side navigation on the checkout history page commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: -biblionumber => $biblionumber, # required for left-side navigation But did not deal with the side-effects. Test plan: When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken if this patch is not applied, the biblionumber is not set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What|Removed |Added Blocks||20918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 [Bug 20918] left-side navigation broken on the checkout history page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] New: left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Bug ID: 20918 Summary: left-side navigation broken on the checkout history page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 18403 commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: -biblionumber => $biblionumber, # required for left-side navigation When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken, the biblionumber is not set. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #121 from Martin Renvoize --- I'm pretty happy with all this now. Well done to marcelr for the first QA run, he did a great job and made my life much easier to get it over the finishing line. Please note that the manual should get a corresponding minor patch to update the OAI reference to the deletedbiblio table that this removes: https://koha-community.org/manual/17.11/en/html/02_administration.html?highlight=oai Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20917] Improve email functionality relating to ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 Andrew Isherwood changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20917] New: Improve email functionality relating to ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 Bug ID: 20917 Summary: Improve email functionality relating to ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com The ILL module has the ability to send emails containing details of requests to "partner" libraries. This functionality, though currently in the core ILL code, is actually only required by the "FreeForm" backend. It is surfaced in the UI as a form containing an email template and a multi-select to select the partners who will receive the email. The email functionality offered by ILL, though functional, is lacking in some important respects, which this bug proposes addressing. Proposed enhancements, which are all inter-related, are: - Move emailing functionality from the core ILL module to the FreeForm backend where it is actually used - Email is sent independently of the Koha message queue, which is understood to be undesirable, this should be addressed - As such, there is no ability for users to specify a default message template, using the Notices and Slips module, this should be addressed - It is not possible for users to specify default "reply-to" addresses for all ILL related emails, currently the ReplyToDefault syspref is used, this should be addressed - No message notification is sent to nominated staff when a request is modified, this should be addressed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #75899|0 |1 is obsolete|| --- Comment #117 from Martin Renvoize --- Created attachment 75990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75990&action=edit Bug 20271: (QA follow-up) Additional about cleanup Still found references to biblios and items in script and template. Test plan: Check about page again. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #75910|0 |1 is obsolete|| --- Comment #118 from Martin Renvoize --- Created attachment 75991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75991&action=edit Bug 20271: (QA follow-up) Remove last occurrences of deleted_at Trivial replace of deleted_at by deleted_on. Test plan: Run t/db_dependent/Koha/ItemTypes.t Run t/db_dependent/Items_DelItemCheck.t git grep -E "deleted_at\W" Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #120 from Martin Renvoize --- Created attachment 75993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75993&action=edit Bug 20271: (QA follow-up) Make the atomicupdate idempotent Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #119 from Martin Renvoize --- Created attachment 75992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75992&action=edit Bug 20271: (QA follow-up) Reword OAI-PMH:DeletedRecord systempref The preference still refered to the deletedbiblio table made defunct by this patchset. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #75898|0 |1 is obsolete|| --- Comment #116 from Martin Renvoize --- Created attachment 75989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75989&action=edit Bug 20271: (QA follow-up) DBIx schema changes Please separate these changes from the other patches. Note that Biblioitem was not in the last set of changes too. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #75897|0 |1 is obsolete|| --- Comment #115 from Martin Renvoize --- Created attachment 75988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75988&action=edit Bug 20271: (QA follow-up): rename to deleted_on and various fixes - renamed deleted_at => deleted_on - removed failing sql in t/db_dependent/OAI/Server.t - removed deprecated autoincrement checks in about.pl - fixed errors in catalogue_stats.tt and catalogue_stats.pl Signed-off-by: Marcel de Rooy Removed the DBIx schema changes. Please keep them separated. We missed changes for Biblioitem btw. Adding them in follow-up. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #75265|0 |1 is obsolete|| --- Comment #114 from Martin Renvoize --- Created attachment 75987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75987&action=edit Bug 20271: (follow-up) DBIx schema changes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #74412|0 |1 is obsolete|| --- Comment #109 from Martin Renvoize --- Created attachment 75982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75982&action=edit Bug 20271: add atomic update Bug 20271: disable foreign keys on deletedbiblio_metadata Signed-off-by: Brendan A Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #74415|0 |1 is obsolete|| --- Comment #112 from Martin Renvoize --- Created attachment 75985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75985&action=edit Bug 20271: print instead of warn unmovable items Signed-off-by: Brendan A Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #74416|0 |1 is obsolete|| --- Comment #113 from Martin Renvoize --- Created attachment 75986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75986&action=edit Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues Signed-off-by: Brendan A Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #37 from Alex Arnaud --- (In reply to Jonathan Druart from comment #35) > Created attachment 74642 [details] [review] > Bug 18235: Add unit tests for get_facetable_fields > > rename atomic update file Looks like this patch does not what it was named for. Atomic update file's name is still Bug_xxx. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Attachment #74413|0 |1 is obsolete|| --- Comment #110 from Martin Renvoize --- Created attachment 75983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75983&action=edit Bug 20271: Use a single pass in the OAI-PMH provider Signed-off-by: Brendan A Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
