[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #8 from Nick Clemens  ---
(In reply to Charles Farmer from comment #4)
> > 975 from record:
> > =975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 
> > 
> > You will need to adjust subfield $h to the name of on of your funds that is
> > duplicated
> 
> This will definitely have to be rephrased, because like Zoe Bennett, I
> couldn't reproduce the issue.
> 
> I did as you said, created two budgets, with one fund that had the same
> code, and yet, when I used the staged file to add items to a new basket,
> there was only one budget name in the dropdown menu.

I added an example file and screenshots, I changed the fund name to show that
both are selected, the problem persists if the names are the same or different

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #7 from Nick Clemens  ---
Created attachment 76115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76115=edit
Example marc file for staging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #6 from Nick Clemens  ---
Created attachment 76114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76114=edit
View of double selected elements on adding to basket

View of the issue when adding from staged to basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #5 from Nick Clemens  ---
Created attachment 76113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76113=edit
Budget setup

Example budgets/funds to illustrate issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't show after placing a suggestion

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Nick Clemens  ---
Seems to be fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Nick Clemens  changed:

   What|Removed |Added

  Attachment #71559|0   |1
is obsolete||
  Attachment #71560|0   |1
is obsolete||

--- Comment #19 from Nick Clemens  ---
Created attachment 76112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76112=edit
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|Small patch |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72014|0   |1
is obsolete||

--- Comment #5 from Charles Farmer  ---
Created attachment 76111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76111=edit
Bug 20259: Shorter JS and CSS rewrite rule

Bug 20187 has changed the JS and CSS rewrite rules to :
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css
[L]

This patch changes this rules using [0-9]{N} and fusion in one rule.
And espaces the dot in extension js and css.

Test plan :
1) Go to intranet and opac
2) Check CSS and JS are doing well
3) Apply patch changes on our Apache configuration
4) Reload intranet and opac pages (Ctrl + F5)
5) Check CSS and JS are doing well

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #4 from Charles Farmer  ---
Only seeing 200's on my station. Looks good.

Tested with:
Server version: Apache/2.4.18 (Ubuntu)
Server built:   2018-04-18T14:53:04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20924] News content textarea not showing

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Maryse Simard  changed:

   What|Removed |Added

  Attachment #76014|0   |1
is obsolete||

--- Comment #3 from Maryse Simard  ---
Created attachment 76110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76110=edit
Bug 20924: Make news content textarea show

To test:
1) Go to Tools -> News
2) Edit existing news item or add new news item
3) Notice content box is missing, can't edit news or add any content
4) Apply patch, refresh page
5) Notice textarea now shows

Sponsored-by: Catalyst IT

Signed-off-by: Maryse Simard 
Followed the test plan and everything works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20924] News content textarea not showing

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #4 from Charles Farmer  ---
> 975 from record:
> =975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 
> 
> You will need to adjust subfield $h to the name of on of your funds that is
> duplicated

This will definitely have to be rephrased, because like Zoe Bennett, I couldn't
reproduce the issue.

I did as you said, created two budgets, with one fund that had the same code,
and yet, when I used the staged file to add items to a new basket, there was
only one budget name in the dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

Pierre-Luc Lapointe  changed:

   What|Removed |Added

 CC||pierre-luc.lapointe@inLibro
   ||.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #10 from Pierre-Luc Lapointe  ---
Created attachment 76109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76109=edit
Bug 5789 - Fines don't work when items have null homebranch

When the CircControl system preference is set to 'the library the item is from'
and items.homebranch is not set,
fines.pl will stop processing witha fatal error that looks something like this:

Use of uninitialized value $branchcode in exists at
/home/koha/kohaclone/misc/cronjobs/fines.pl line 110
No branchcode argument passed to Koha::Calendar->new at
/home/koha/kohaclone/misc/cronjobs/fines.pl line 169.

This patch will check the value of $branchcode before it is used. If
$branchcode is undefined, a warning will
be issued and, processing will be skipped for that item, and continue for the
next item.

To test:

1) Set CircControl to  'the library the item is from'
2) Check out items and back-date them to be overdue
3) Set homebranch of one of the items to NULL
4) Run misc/cronjobs/fines.pl, note that processing stops at that item.
5) Apply patch
6) Repeat step 4. not that processing completes.
7) Check logs, you should see a warning message for the item missing its
homebranch.
8) Sign off.

Signed-off-by: Pierre-Luc Lapointe 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Maryse Simard  changed:

   What|Removed |Added

  Attachment #75551|0   |1
is obsolete||

--- Comment #3 from Maryse Simard  ---
Created attachment 76108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76108=edit
Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions
conditional block

Moving the conditional block [% IF
(CAN_user_circulate_circulate_remaining_permissions ) %] block up the
checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes
this bug.

Test plan:
1. Go to the circ home page and confirm the following
keyboard shortcuts work:

Alt+q = goes to search catalog
Alt+w = goes to renew

2. Go to returns.pl and confirm the following  keyboard shortcuts work:

Alt+q = goes to renew
Alt+w = goes to search catalog

3. Apply patch

4. Restart apache2, memchached and plack

5. Confirm on the returns.pl the following keyboard shortcuts work:
Alt+q = goes to search catalog
Alt+w = goes to renew

Sponsored-By: Catalyst IT

Signed-off-by: Maryse Simard 
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15704] split up 264 index

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #4 from Charles Farmer  ---
Using the most basic record with the 'Default framework', I can't reproduce the
issue of not finding a record from its publisher.

Here's what I did:

* Since the 264's weren't visible by default in the editor, I went ahead and
made them show up by changing the properties of admin/biblio_framework.pl.
Otherwise, I had no way of adding content to those fields
* I created a new record, filled the info.
* * I also made sure to fill the other fields of 264 with garbage data, just in
case
* Rebuilt zebra
* Searched for the string I added in 264b: supercalifragilisticexpialidocious
* I'm redirected to the new record's page

Am I doing something wrong here? Why is it showing up on my master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #5 from Caroline Cyr La Rose  ---
When I apply the patch, it doesn't look the same as the screenshots. The
section headings are blue and the syspref names are almost the same as their
description. making it hard to read. I like it, but  would like the syspref
names to be at least in bold.

Also, would it be possible to keep the same indent as the first line on the 2nd
+ line of the description? For example, in my screenshot, in the description
for gist, the second line, starting at "rounded" doesn't have the same indent
as the line above. I think it makes it look messy. 

I would miss the arrows to collapse a section (when they're really long, it
saves scrolling energy). Would it still be possible to have them in this new
design? It's not the end of the world if it's not

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

--- Comment #5 from Maryse Simard  ---
Created attachment 76107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76107=edit
Bug 20867 - Ability to show membership renewal date on moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
5. Apply the patch.
6. Reload the page now you will able to see the Membership renewal date.

Signed-off-by: Maryse Simard 
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #4 from Caroline Cyr La Rose  ---
Created attachment 76106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76106=edit
Screenshot of the system preferences page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #71 from Caroline Cyr La Rose  ---
I had a bit of trouble applying the patch. I had to add member-flags.tt and
then continue applying the patch. I don't know if that's normal or not.

I went to Global system preferences and clicked on the tab for circulation.
When I clicked help, the manual was at the beginning of the sysprefs section. I
don't know if it's possible at all to point to the right sub-section? It's just
that are so many system preferences...

My KohaManualLanguage is on Arabic by default. I'm guessing it's the first
language in the list, but if I don't change it will this be the default? Should
we put English by default instead of Arabic?

I also don't see the edit button mentioned in comment 7. Was that implemented
or just an idea for a future development? It could be a second patch. People
don't currently have the ability to modify from the staff interface, so it
wouldn't necessarily be a step back. More advanced users can still use their
own help files.

I wasn't able to test switching languages because my master is only installed
in English.

It's a great development! It will be much easier to translate, no need to
translate the help file, just the manual. It will also be more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20928] Checkout status not showing patron

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20928] Checkout status not showing patron

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Maryse Simard  changed:

   What|Removed |Added

  Attachment #76058|0   |1
is obsolete||

--- Comment #3 from Maryse Simard  ---
Created attachment 76105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76105=edit
Bug 20928: Fix regression - display patron's info on moredetail if item is
checked out

This patch is a follow-up of
  commit 5f80977875ff124d411f2cd89de4a944fa9c27af
  Bug 18403: Use patron-title.inc when hidepatronname is used

Test plan:
- Check an item out
- Go on the moredetail.pl page of this biblio record
Home › Catalog › Item details for your biblio
- Confirm that you see:
"Checkout status: Checked out to"
followed by the patron's info

Signed-off-by: Maryse Simard 
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Maryse Simard  changed:

   What|Removed |Added

  Attachment #76043|0   |1
is obsolete||

--- Comment #2 from Maryse Simard  ---
Created attachment 76104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76104=edit
Bug 20934: Fix display of old checkouts in the checkout history page

Again a regression caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

Signed-off-by: Maryse Simard 
The patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #76098|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 76103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76103=edit
Bug 20954: Add ability to set syspref overrides in SIP as we can in apache

We should be able to set system preference overrides for SIP in a
similar manner that we do in Apache. It would be great if we could
specify those overrides on both a config level, and login level basis.

Test Plan:
 1) Apply this patch
 2) Start your SIP server
 3) Enable the syspref AllFinesNeedOverride
 4) Find or create a patron with a small fine ( less than noissuescharge )
 5) Attempt to check out an item to the patron, it should fail
 6) Add the global syspref override from the bottom of the example SIP config
file
 7) Restart your SIP server
 8) Attempt to check out an item to the patron again, this time it should work
 9) Now, add the login level syspref override section as it appears in
the eaxmple SIP config file. Make sure to add it to the login you are using
10) Attempt to check out another item to the patron, this time is should
again fail

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20826] Error during initial setup

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #8 from so...@edzone.net ---

/etc/apt/sources.list



# 

# deb cdrom:[Debian GNU/Linux 8.1.0 _Jessie_ - Official i386 NETINST Binary-1
20150606-12:58]/ jessie main

#deb cdrom:[Debian GNU/Linux 8.1.0 _Jessie_ - Official i386 NETINST Binary-1
20150606-12:58]/ jessie main

deb http://ftp.us.debian.org/debian/ jessie main
deb-src http://ftp.us.debian.org/debian/ jessie main

deb http://security.debian.org/ jessie/updates main
deb-src http://security.debian.org/ jessie/updates main

# jessie-updates, previously known as 'volatile'
deb http://ftp.us.debian.org/debian/ jessie-updates main
deb-src http://ftp.us.debian.org/debian/ jessie-updates main

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #35 from Mirko Tietgen  ---
Ok, it is, in this order,

18285
18286
18287
18288
18289
18226
18851

No rebase needed. All tests run fine afterwards (not checked db-dependent)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #34 from Mirko Tietgen  ---
Nevermind, it fails a lot more tests afterwards. There is more missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #33 from Mirko Tietgen  ---
Fridolin: I suppose you missed that it depends on bug 18226. I could easily
apply both to 17.05.x, there is just one test to 'git add'. This would probably
fix the failing t/XSLT.t in 17.05.x (with Test::DBiX::Class but without DB, as
on the nightly server). Would you reconsider pushing to 17.05.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron who has fines on deleted items causes software error.

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

--- Comment #2 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #1)
> I do not recreate, I noticed that accountlines.itemnumber is set to NULL
> when the item is deleted.
> Can you detail a bit more the steps to recreate?

The problem is triggered by accountlines records that have itemnumbers that
don't point to items -- I honestly don't know *how* that happened -- manual
database manipulation? Accountlines records that existed before the foreign key
constraints?

I think as a work-around, we're going to simply null accountlines.itemnumber
and set accountlines.note using

UPDATE
accountlines
SET
note=CONCAT(itemnumber," item deleted from system"),
itemnumber=NULL
WHERE
itemnumber NOT IN ( SELECT itemnumber FROM items );

I'm still open to a patch for this; but considering that the code that causes
his no longer exists in master, and that I can't reproduce this by normal means
in 17.11, I'm willing to use the workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20956] New: BorrowersLog is not logging permission changes

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Bug ID: 20956
   Summary: BorrowersLog is not logging permission changes
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I made changes to permissions, and I can see that it is not being logged.  This
is a security issue and should be fixed immediately.  We cannot have people
changing permissions undetected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20826] Error during initial setup

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #7 from Mirko Tietgen  ---
What does your /etc/apt/sources.list* look like?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20826] Error during initial setup

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #6 from so...@edzone.net ---
Distributor ID: Debian
Description:Debian GNU/Linux 8.10 (jessie)
Release:8.10
Codename:   jessie


output:

root@Pine:~# apt-cache policy libnet-oauth2-authorizationserver-perl
N: Unable to locate package libnet-oauth2-authorizationserver-perl
root@Pine:~#

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20826] Error during initial setup

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #5 from Mirko Tietgen  ---
1. What version of Debian are you running?

2. Could you please give the output of

apt-cache policy libnet-oauth2-authorizationserver-perl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20826] Error during initial setup

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

so...@edzone.net changed:

   What|Removed |Added

 CC||so...@edzone.net

--- Comment #4 from so...@edzone.net ---
as per Jonathan Druart 


Please comment with your info on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826


root@Pine:~# sudo apt-get install koha-common
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 koha-common : Depends: libnet-oauth2-authorizationserver-perl but it is not
going to be installed
E: Unable to correct problems, you have held broken packages.
root@Pine:~#


current server:

Server information
Koha version:   17.05.05.000
OS version ('uname -a'):Linux Pine 3.16.0-4-686-pae #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) i686
Perl interpreter:   /usr/bin/perl
Perl version:   5.020002
Perl @INC:  /usr/share/koha/lib 
/etc/perl 
/usr/local/lib/i386-linux-gnu/perl/5.20.2 
/usr/local/share/perl/5.20.2 
/usr/lib/i386-linux-gnu/perl5/5.20 
/usr/share/perl5 
/usr/lib/i386-linux-gnu/perl/5.20 
/usr/share/perl/5.20 
/usr/local/lib/site_perl 
. 
MySQL version:  mysql Ver 14.14 Distrib 5.5.60, for debian-linux-gnu (i686)
using readline 6.3
Apache version: Server version: Apache/2.4.10 (Debian)
Memcached:  Servers: undefined | Namespace: koha | Status: unknown | Config
read from: Nowhere Note that the right place to define the memcached config is
in your $KOHA_CONF file. Currently you do not have a valid memcached
configuration defined. | Effective caching method: Cache::Memory
Zebra version:  Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software,
covered by the GNU General Public License, and you are welcome to change it
and/or distribute copies of it under certain conditions. SHA1 ID:
c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

--- Comment #1 from Nick Clemens  ---
Created attachment 76101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76101=edit
Bug 20955: Add systempreference to allow triggering forbidden holds

To test:
1 - Set a holds policy to allow only holds from homebranch
2 - Place a hold on an item for a patron from another branch
3 - Checkin item
4 - Hold does not trigger
5 - Apply patches and updatedatabase
6 - Check in item
7 - Hold triggers

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

--- Comment #2 from Nick Clemens  ---
Created attachment 76102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76102=edit
Bug 20955: Unit tests

prove -v t/db_dependent/Holds/HoldFulfillmentPolicy.t
prove -v t/db_dependent/Reserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] New: Add ability to trigger holds that violate holds policies (overridden holds)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Bug ID: 20955
   Summary: Add ability to trigger holds that violate holds
policies (overridden holds)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some libraries would like holds placed by staff that override holds policies to
trigger during checkin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #6 from Nick Clemens  ---
Created attachment 76100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76100=edit
Bug 19288: [Alternate] Only show existence of item level hold unless waiting

To test:
1 - Please a biblio level hold for one patron, and an item level hold
for another on same record
2 - Note that you patron name for item lvel hold
3 - Apply patch
4 - You should now see 'There is a hold on this item' with no patron
detail
5 - Confirm hold, patron detail should be visible

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #79 from Koha Team Lyon 3  ---
What I understood about Joseph comment is what follows :
Say we configure a weekly review from 01/01/2018 to 31/12/2018,if you set 52
issues as subscription length, it will be okay.
A priori, it makes sense that you will set permanent irregularities on a single
cycle/subscription (but people are strange !).
If, for some reason, you put, say, 56 issues as subscription length, you will
obtain as much checkboxes in the checkboxes lists.
In the "weeks not published" scrolldown list, you will have four extra
checkboxes (corresponding to weeks 1,2,3,4 of year 2019).
If you check one of these weeks, the corresponding checkbox will not be checked
on the fixed list and you risk not to notice this.
It's the reason why, I guess, Joseph suggests to limit the displayed list to 52
weeks (Some year may have 53 weeks according to iso numbering. may be we can
limit by end date of current year. Problem, I'm thinking that some subscription
(and numbering)  begin in the middle of the year and finish the year after like
New York Review.

as for "jumping checkboxes", It occurs in the "weeks not published" scrolldown
list and only at first checkbox checking. the second checking you do, no
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #5 from Nick Clemens  ---
This patch will only show the hold if it is next in the priority list, however,
localholds priority and other settings may mean the hold triggered at checkin
is not the one listed. Would it be reasonable to only show "there is a hold on
this item" unless the hold is waiting?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #4 from Nick Clemens  ---
Created attachment 76099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76099=edit
Bug 19288: Only display holds if next in queue or waiting

To test:
 1 - Place a title level hold on a biblio for a patron
 2 - View the details, the item(s) has no info about holds
 3 - Place an item level hold for an item on the same biblio for another patron
 4 - View the details page, note the item indicates it is held for the
second patron
 5 - Apply patch
 6 - Refresh details, the hold is not indicated
 7 - Set the item specific hold to be priority #1
 8 - Refresh details, the hold should now be indicated
 9 - Confirm the hold
10 - Refresh details, the hold should show as waiting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

--- Comment #1 from Kyle M Hall  ---
Created attachment 76098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76098=edit
Bug 20954: Add ability to set syspref overrides in SIP as we can in apache

We should be able to set system preference overrides for SIP in a
similar manner that we do in Apache. It would be great if we could
specify those overrides on both a config level, and login level basis.

Test Plan:
 1) Apply this patch
 2) Start your SIP server
 3) Enable the syspref AllFinesNeedOverride
 4) Find or create a patron with a small fine ( less than noissuescharge )
 5) Attempt to check out an item to the patron, it should fail
 6) Add the global syspref override from the bottom of the example SIP config
file
 7) Restart your SIP server
 8) Attempt to check out an item to the patron again, this time it should work
 9) Now, add the login level syspref override section as it appears in
the eaxmple SIP config file. Make sure to add it to the login you are using
10) Attempt to check out another item to the patron, this time is should
again fail

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20954] New: Add ability to set syspref overrides in SIP as we can in apache

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Bug ID: 20954
   Summary: Add ability to set syspref overrides in SIP as we can
in apache
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

We should be able to set system preference overrides for SIP in a similar
manner that we do in Apache. It would be great if we could specify those
overrides on both a config level, and login level basis.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19956] Adjusting fine block on SIP connected self-check

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19956] Adjusting fine block on SIP connected self-check

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956

Kyle M Hall  changed:

   What|Removed |Added

Summary|Adjusting fine block on SIP |Adjusting fine block on SIP
   |connected self-check -  |connected self-check
   |Coffeyville |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19956] Adjusting fine block on SIP connected self-check - Coffeyville

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|je...@bywatersolutions.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #3 from Owen Leonard  ---
Created attachment 76097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76097=edit
Bug 20935: Redesign system preferences interface

This patch proposes a new interface for system preferences. The goal is
to make the interface more readable and to give the user additional
options for finding what they need.

- Restructures the preferences list as a , with the preference name
  as the  and the description as the .
- Add a JS filter library (mark.js) to do live filtering of the page and
  add search term highlighting.
- When the user has searched, show links to the sections in which
  results were returned.

To test, apply the patch and go to Administration -> System preferences.

 - Test the functionality of setting various kinds of preferences,
   including multi-selects, textareas, WYSIWYG editors, etc.
 - Test the filter form at the top of the page for narrowing in-page
   results.
   - Test both successful and unsuccessful filters.
 - Perform a system preference search.
   - Test the in-page links to the different sections.
   - Test that in-page filtering works in this case too.
 - View the licenses tab of the "About" page and check that the
   information about mark.js looks correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19990

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

--- Comment #1 from Fridolin SOMERS  ---
Can not be tested without Bug 20951

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20953

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #76096|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] New: Discharge can be requested several times on OPAC

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Bug ID: 20953
   Summary: Discharge can be requested several times on OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

On OPAC, a user can requested a discharge even if one is already pending.
This generates several pending discharges in staff interface that can not be
deleted.

This is because request operation leads to page 'opac-discharge.pl?op=request'
and user can refresh this page performing a new request.

Perl code must check that operation is allowed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20953


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953
[Bug 20953] Discharge can be requested several times on OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||20951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951
[Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #2 from Mirko Tietgen  ---
Erm. That did not work. ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

--- Comment #1 from Nightly Build Bot  ---
Created attachment 76096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76096=edit
Bug 20861: Correct EDI permissions on EDI messsages

The permission for EDI is edi_manage, but 2 pages asked
for manage_edi, allowing users not to access those.

To test:
- Add edi_manage to your permissions
- Try to access the EDIFACT messages from the
  acq start page
- Verify it doesn't work
- Apply patch and try again
- You should be able to access the page now
- Try to access the other page directly (if you don't
  have EDI data):
  /cgi-bin/koha/acqui/edimsg.pl
- Verify you can access the page and don't get a
  permission error

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 
(cherry picked from commit 7883b19de5f24551b36bf29133b04bc71ad4d56a)
Signed-off-by: Fridolin Somers 
(cherry picked from commit cbeed6cf3db342e025b4d837ab135136d39a140e)
Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #15 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20911] Search history page forms use 'GET' and this limits the number of entries that can be submitted

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #5 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20952

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20952

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17111,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17108,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17084
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20952

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #5 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20952] New: Automatic debian/control updates (oldoldstable/17.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Bug ID: 20952
   Summary: Automatic debian/control updates
(oldoldstable/17.05.x)
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

Automatic updates for debian/control in 17.05.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20832] Opac user page crash when there is an overdue fine and not any rental charge for a patron

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|Pushed to Stable
   Keywords|rel_18_05_candidate |

--- Comment #7 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #76094|0   |1
is obsolete||

--- Comment #42 from Mirko Tietgen  ---
Created attachment 76095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76095=edit
Bug 17111 - Automatic debian/control updates (oldstable/17.11.x)

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

Version|17.05   |17.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #41 from Nightly Build Bot  ---
Created attachment 76094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76094=edit
Bug 17111 - Automatic debian/control updates (oldstable/17.11.x)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] New: Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Bug ID: 20951
   Summary: Koha::Patron::Discharge is missing use
Koha::Patron::Debarments
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Koha::Patron::Discharge is missing use Koha::Patron::Debarments used in
discharge() method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.05.x)

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #70825|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951
[Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||15548


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548
[Bug 15548] New patron related code should have been put to Patron instead of
Borrower
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 76093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76093=edit
Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge

Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in
discharge() method.

Test plan :
1) Enable pref useDischarge
2) Go to OPAC user page
3) Go to 'ask for a discharge' tab
4) Click on 'Ask for a discharge'
5) Go to staff interface : /cgi-bin/koha/members/discharges.pl
6) Click on Allow
=> Without patch you get software error
=> With patch the discharge is validated

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20950] Plugins: Handler.pm doesn't fail gracefully when running plugin

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20950

Andrew Isherwood  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20950] New: Plugins: Handler.pm doesn't fail gracefully when running plugin

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20950

Bug ID: 20950
   Summary: Plugins: Handler.pm doesn't fail gracefully when
running plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andrew.isherw...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

When running a plugin that fails for some internal reason, the user doesn't
always receive a very helpful message. With the Kitchen Sink plugin (
https://github.com/bywatersolutions/koha-plugin-kitchen-sink ) I managed to
break it by trying to import C4::Members::GetMember - which doesn't exist any
more.

Running the plugin in this broken state resulted in:

run.pl: Plugin Koha::Plugin::Com::ByWaterSolutions::KitchenSink cannot be
loaded at /usr/share/koha/Koha/Plugins/Handler.pm line 72.:
/usr/share/koha/plugins/run.pl

It turns out that Koha::Plugins::Handler::run calls
Module::Load::Conditional::can_load, which was returning false, which caused
the message I saw to be output. However, Module::Load::Conditional sets a
global variable upon can_load returning false containing the reason. We should
display this (assuming we don't consider it to be a security risk).

So, in Handler.pm, we'd need to substitute in:

if ( can_load( modules => { $plugin_class => undef } ) ) {
my $plugin = $plugin_class->new( { cgi => $cgi, enable_plugins =>
$args->{'enable_plugins'} } );
if ( $plugin->can($plugin_method) ) {
return $plugin->$plugin_method( $params );
} else {
warn "Plugin does not have method $plugin_method";
}
} else {
warn "Plugin $plugin_class cannot be loaded: " .
$Module::Load::Conditional::ERROR;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

2018-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

--- Comment #5 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #4)
> I see $available means discharge is validated by a librarian in staff
> interface, different from $pending.

Oh I think I get it now :

FIXME means 'available' template param could directly be
Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}).
Because Koha::Patron::Discharge::is_discharged() looks if discharge is
validated.

Is it correct ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >