[Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #2 from Joy Nelson --- Test plan * Create a big with multiple 866, 867 and 868 tags * Note that the display in OPAC and Staff Details pages does not contain 867, 868 textual holdings and the 866 tags are run together on one line * Apply the patch * Now the 867 and 868 tags display * Additionally the 866,867 and 868 are displayed one per line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #1 from Joy Nelson --- Created attachment 76316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76316=edit Bug 20986 Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Joy Nelson changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an alternative no longer works
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #22 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20744] Replace staff client header Koha logo gif with transparent png
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20744 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #51 from Nick Clemens --- Created attachment 76315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76315=edit Bug 20073: (RM follow-up) Remove atomicupdate D'oh Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20986] New: MARC21 Supplement and Index Textual Holdings don't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Bug ID: 20986 Summary: MARC21 Supplement and Index Textual Holdings don't display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: j...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Koha currently only displays the 866 Textual Holdings tag. It does not display the 867 Supplements or 868 Indexes Textual Holdings data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from zebra-output.log when EasyAnalyticalRecords is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from zebra-output.log when EasyAnalyticalRecords is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697 Charles Farmer changed: What|Removed |Added Attachment #75002|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 76314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76314=edit Bug 20697: Bind calling GetAnalyticsCount to pref EasyAnalyticalRecords If you do not use the EasyAnalyticalRecords feature (introduced with bug 5528), you will have a lot of warnings in zebra-output.log like: zebrasrv(1096) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @attr 1=8911 259186 They come from C4::Items::GetAnalyticsCount called by catalogue/detail.pl. This sub starts a Zebra search on index 'hi' (Host-Item-Number). If you do not use this field at all (related to 773$9 in MARC21), Zebra returns an Unsupported Use attribute error (114). In making this change, I added one minor change: [1] Remove the commented GetAnalyticsCount in additem.pl and correcting indentation in that loop (removing tabs). So no change at all there. NOTE: I will propose to bind the GetHostItemsInfo call in detail.pl and two other scripts to this preference too on report 20702. Test plan: [1] If you use EasyAnalytics, verify that there is no change. [2] If you do not, check the zebra-output.log. You should no longer see searches for Host-Item-Number with 1=8911. (As well as ERROR 114 on this index.) Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from zebra-output.log when EasyAnalyticalRecords is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697 --- Comment #6 from Charles Farmer --- That's perfect. I was able to reproduce and confirm that your patch fixes the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||maryse.sim...@inlibro.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 --- Comment #1 from Maryse Simard --- Created attachment 76313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76313=edit Bug 19039: Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. Test plan: 1) In the staff client, view a list containing several items 2) Notice that you can't sort by 'date added' 3) Apply the patch 4) Repeat step 1 5) The list can now be sorted by 'date added' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Charles Farmer changed: What|Removed |Added Attachment #76215|0 |1 is obsolete|| --- Comment #6 from Charles Farmer --- Created attachment 76312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76312=edit Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on This patch reorganizes the way sidebar menus get highlighted based on the current page. A global function is added to handle most cases. Individual menu-handling scripts have been modified to handle only the edge cases which aren't covered by the global one. A new class is added to the global CSS file so that highlighted menu links can be custom-styled. To test, apply the patch and clear your cache if necessary. View various pages to confirm that current-page-highlighting in the sidebar menu is working correctly and that there are no JS errors in the browser console. For example: - Administration -> Currencies and exchange rates. - Acquisitions -> Invoices - Tools -> Patron lists - Tools -> Export And with CircSidebar turned on test various circulation pages, e.g. - Circulation -> Set library Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com --- Comment #5 from Charles Farmer --- Could reproduce, and went through most pages in the sidebar: the ones I visited were indeed highlighted as active, and the '$' error went away after applying patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222 Maryse Simard changed: What|Removed |Added Attachment #76237|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 76311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76311=edit Bug 14222: Sort holds in OPAC by priority This patch modifies the markup of the users's holds table in the OPAC so that if hold priority is displayed, the table will be sorted by that number. To test, apply the patch and set the OPACShowHoldQueueDetails system preference to "Show priority level" or "Show holds and their priority level." - Log in to the OPAC as a user who has multiple holds with various priorities. Include priorities which could be sorted incorrectly using a text sort, e.g. 1, 10. - View the holds tab on the "your summary" page. Confirm that the priority column is sorted by default with the lowest priority holds first. - Set the OPACShowHoldQueueDetails preference to "Show holds" and confirm that the holds table still displays correctly, sorted by "Placed on" ascending. Signed-off-by: Maryse Simard Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- I don't think the second patch is quite right - CanBookBeReserved calls CanItemBeReserved, but it might not be correct for a specific item Set a rule for 'No Holds Allowed' for an itemtype Find a bib with no items or create on Add an item with the disallowed item type Attempt hold on item via ILSDI - Not allowed Add a second item with a holdable itemtype Attempt hold on the original unholdable item via ILSDI - Allowed? I think the call in 'Hold Item' to CanBookBeReserved is the extraneous one unless I missed something I also note that neither of the routines mentioned check for 'On shelf holds allowed' policy - filed as bug 20985 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] New: CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Bug ID: 20985 Summary: CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Via ILSDI we use the routines mentioned above to determine holdability, however, neither of these routines check on shelf hold policies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Maryse Simard changed: What|Removed |Added Attachment #76200|0 |1 is obsolete|| --- Comment #8 from Maryse Simard --- Created attachment 76310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76310=edit Bug 20921: Add borrowernumber and branchcode as html attributes To test: 1 - Apply patch 2 - Visit the opac 3 - Sign in 4 - You should not see any difference 5 - Inspect the element 'Welcome, {username}' 6 - Note the attributes for borrowernumber and branchcode 7 - Add to OPACUserJS: $(document).ready(function(){ console.log( $(".loggedinusername").attr('data-branchcode')); console.log( $(".loggedinusername").attr('data-borrowernumber')); }); 8 - Check the console and note you can see the info expected Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984 --- Comment #1 from Joy Nelson --- Created attachment 76309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76309=edit Bug 20984: Add 300$f to display Adding Type of Unit (300$f) to the Opac details and staff side searches results and details display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984 Joy Nelson changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20984] New: MARC21 subfield 300f - Type of Unit does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984 Bug ID: 20984 Summary: MARC21 subfield 300f - Type of Unit does not display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: j...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In the search results list and details pages, the 300$f subfield does not display. This contains the "Type of Unit". Subfield g appears which contains the size of the unit. Knowing something is 21 x 35 cm big is great, but knowing it is a Box 21 x 35 cm is better! Especially for sites with special collections or archives where this information is helpful in retrieval from the stacks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #51 from Charles Farmer --- Went with the path of least resistance: search query now filters based on the news_lang retrieved earlier in the script. This should avoid retrieving news marked 'slip' or 'koha', and even those in other languages than the one currently displayed. Also removed a lingering variable, koha_news_count, that was not used anymore, and not even passed to the template. Test plan for this follow-up patch: 1) Make sure you have news from all different Location to display. At minimum, you should have the 'koha', 'slip' and 'en' locations readily available. 1.1) If you don't, create them at /cgi-bin/koha/tools/koha-news.pl 2) Apply patch "Bug 14272: Show single news item [alternative patch]" 3) Visit the OPAC 4) Click on the news' title 4.1) Not seeing any news? Go back to 1.1 5) Change the news_id parameter in the URL for another news that you've just created 5.1) You should be able to display any news, even those which you shouldn't have access to 6) Apply (follow-up) patch 7) Repeat 3) to 5), but this time, you should see an error message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Maryse Simard changed: What|Removed |Added Attachment #76112|0 |1 is obsolete|| --- Comment #20 from Maryse Simard --- Created attachment 76308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76308=edit Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #50 from Charles Farmer --- Created attachment 76307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76307=edit Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18088] Software error additem.pl Can't call method subfield error. Can't add items.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18088 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Is items.barcode mapped to a MARC field in your frameworks? You can check on the Koha 2 MARC configuration page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com --- Comment #2 from Pierre-Luc Lapointe --- I tested the patch and the credit is not displayed (like intended). However, the credit is still considered in the balance, so it still shows "Total due: -4.00". When trying to pay all fines, the message "You must pay a value less than or equal to -4.00" still shows up and and the payment cannot be done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Maryse Simard changed: What|Removed |Added Attachment #75640|0 |1 is obsolete|| --- Comment #12 from Maryse Simard --- Created attachment 76306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76306=edit Bug 17886: Don't show option to add to existing list if there are no lists This patch modifies the page for adding a title to a list so that the "Add to existing list" option doesn't appear if there are no lists defined. TEST PLAN - 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) Apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) Run koha qa test tools. Perform the same tests in the staff client. Signed-off-by: Maryse Simard Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com --- Comment #49 from Charles Farmer --- Should I refrain from signing this off if the lingering issue mentionned in comment#2 is still reproducible? I feel like it shouldn't be too hard to add a method like Koha::News::is_displayable that would filter the array from the search method, and return only what's acceptable for the given interface/lang. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Maryse Simard changed: What|Removed |Added Attachment #76016|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 76305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76305=edit Bug 20927: moredetail.pl crash on nonexistent biblionumber moredetail.pl crashes when trying to view a nonexistent biblionumber. The case should be handled like it is done in detail.pl. Signed-off-by: Pasi Kallinen Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added Attachment #76290|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added Attachment #76281|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #6 from Katrin Fischer --- Created attachment 76304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76304=edit Bug 20972: Add a testcase for bug 20972 Ensure all 10 characters of ISBN are preserved And that ISBNs and EANs are correctly identidied in the PIA segment Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #5 from Katrin Fischer --- Created attachment 76303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76303=edit Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used If ISBN has 10 numbers only the first 9 numbers are being added to the Edifact-message (PIA+5+3540556753:IB') This is caused by wrong positioning of capturing parentheses in a regular expression. Sponsored-by: Gothenburg University Library Signed-off-by: Colin Campbell Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #4 from Katrin Fischer --- Thx for the quick sign-off and tests, Colin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 --- Comment #7 from Joy Nelson --- To test: This patch updates the display of the title subfields in the XSLT display in the staff and OPAC. Display includes added subfields f and g To test: * Have a title or two with 245 subfields f and g already in the record. * Verify on OPAC and Staff side that subfields f and g do not appear in search results or Details Display * Apply the patch * Search the opac for title used above * Verify subfields f and g display properly * Click a title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not displayed in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Joy Nelson changed: What|Removed |Added Summary|245f and 245g are not |245f and 245g are not |mapped to subtitle in XSLT |displayed in XSLT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 --- Comment #6 from Joy Nelson --- Created attachment 76302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76302=edit Bug 17625: adding subfields f and g to XSLT display Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff side Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Joy Nelson changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Bug 7923 depends on bug 19820, which changed state. Bug 19820 Summary: Add unsafe param to GetMarcSubfieldStructure https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 What|Removed |Added Status|Pushed to Master|CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Jonathan Druart changed: What|Removed |Added Status|Pushed to Master|CLOSED Resolution|--- |FIXED --- Comment #16 from Jonathan Druart --- Let's stay on the safe side and do not backport this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18973] Auto focus the ISBN field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #50 from Nick Clemens --- Squashed 1st and 3rd patches on push -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #49 from Nick Clemens --- Awesome work all! Pushed to aster for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Joy Nelson changed: What|Removed |Added Summary|245f and 245g are not |245f and 245g are not |mapped to subtitle in |mapped to subtitle in XSLT |Keyword to MARC mapping | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in Keyword to MARC mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 --- Comment #5 from Joy Nelson --- (In reply to Katrin Fischer from comment #4) > Ah right, I think the keywords to marc mapping doesn't work on the xslt > detail view? I verified that. The Keyword to Marc mapping is for non xslt display. I'll change the title on this bug. The issue I'm having is indeed with XSLT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Nighswonger changed: What|Removed |Added CC||cnighswon...@foundations.ed ||u -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 76299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76299=edit Bug 20980: Add 'Manual Credit' and fix existing offsets This patch adds a new offset type 'Manual Credit'. And adds an atomic update for fixing existing offsets. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 76300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76300=edit Bug 20980: Make mancredit.pl use Koha::Account::add_credit This patch makes creating a manual credit from the UI record the account offset as 'Manual Credit', and properly set account_offsets.credit_id instead of account_offsets.debit_id. To test: - Create a manual credit (of 'Credit' type) for a known patron (acevedo?) - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => FAIL: The account offset for the manual credit has type=Manual Debit, credit_id=NULL and debit_id=accountlines_id - Run the atomic update: $ updatedatabase - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => SUCCESS: The account offset has been corrected and now has type=Manual Credit, credit_id=accountlines_id and debit_id=NULL - Create a new manual credit (of 'Forgiven' type) for a known patron - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => SUCCESS: The account offset has been stored correctly as a credit! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 76301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76301=edit Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff' This patch makes Koha::Account::add_credit record statistics logs (through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff' credit types. Both credit types are whitelisted in UpdateStats, so we keep the current behaviour. Another option would've been to add new account types to the white list, but with the account offsets it seems that using the statistics table for account changes won't be useful for too long, as offsets contain the same (and more) information. To test: - Apply the patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Katrin Fischer changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|cnighswon...@foundations.ed |jonathan.dru...@bugs.koha-c |u |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 --- Comment #11 from Joy Nelson --- Katrin, I did a retest to confirm. This patch will fix if opac suppress if ON or OFF. joy (In reply to Katrin Fischer from comment #10) > Why "* have OPACSuppression on"? > > Would like to test if bug 14716 also resolves the issue - might be the nicer > global fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #46 from Kyle M Hall --- Created attachment 76298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76298=edit Bug 18072: Only accept Koha::Library in parameters I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #44 from Kyle M Hall --- Created attachment 76296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76296=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #45 from Kyle M Hall --- Created attachment 76297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76297=edit Bug 18072: (QA followup) Remove warning from tests This patch removes a warning from Items.t due to bad parameters. It also makes the tests use Test::Exception. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #43 from Kyle M Hall --- Created attachment 76295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76295=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #42 from Kyle M Hall --- Created attachment 76294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76294=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #41 from Kyle M Hall --- Created attachment 76293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76293=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall changed: What|Removed |Added Attachment #76282|0 |1 is obsolete|| Attachment #76283|0 |1 is obsolete|| Attachment #76284|0 |1 is obsolete|| Attachment #76285|0 |1 is obsolete|| Attachment #76286|0 |1 is obsolete|| Attachment #76287|0 |1 is obsolete|| Attachment #76288|0 |1 is obsolete|| --- Comment #40 from Kyle M Hall --- Created attachment 76292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76292=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Jonathan Druart changed: What|Removed |Added Attachment #76108|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 76291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76291=edit Bug 18521: Fix key binding in the header Moving the conditional block [% IF (CAN_user_circulate_circulate_remaining_permissions ) %] block up the checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes this bug. Test plan: 1. Go to the circ home page and confirm the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew 2. Go to returns.pl and confirm the following keyboard shortcuts work: Alt+q = goes to renew Alt+w = goes to search catalog 3. Apply patch 4. Restart apache2, memchached and plack 5. Confirm on the returns.pl the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew Sponsored-By: Catalyst IT Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #3 from Colin Campbell --- Created attachment 76290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76290=edit Add a test case for this to Ediorder.t Add a test for this bug and ensure routine is correctly distinguishing 10 character ISBNs from 13 digit EANs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20257] Holds - Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20257 --- Comment #2 from Kyle M Hall --- (In reply to Katrin Fischer from comment #1) > I think this is a possible duplicate to some other existing bug reports > concerning the branch transfer limits: > > Bug 7614 - Branch transfer limit and holds > Bug 11020 - Transfer limits should be checked when placing a > hold/reservation in Staff client > Bug 10993 - Transfer limits should be checked when placing a > hold/reservation in OPAC > > Kyle, can you please check and mark duplicate if it fits? The other bugs > have patches, but not sure if something can be salvaged from there. > Discussion might still be interesting. Thanks for letting me know! It definitely appears worth picking back up on some of those! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #9 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #8) > If I understand correctly: The good thing is that people can keep the old > rule without issue so they won't have to change the RewriteRules for 18.05 > and 18.11 Yes, they are similar but one is easier to read. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #39 from Kyle M Hall --- (In reply to Jonathan Druart from comment #31) > (In reply to Jonathan Druart from comment #30) > > Created attachment 67209 [details] [review] [review] > > Bug 18072: Only accept Koha::Library in parameters > > > > I do not think we should allowed branchode and Koha::Library objects, it > > adds confusion in callers (we never know if we have a branchcode of a > > library object). > > Does this patch make sense? Yes, yes it does ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Marjorie Barry-Vila changed: What|Removed |Added CC|marjorie.barry-vila@collect | |o.ca| Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20509] Data consistency - authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=5789 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20509 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- If we consider that it is a data migration issue I think we should start writing a script to catch them. See also bug 20509. We cannot deal everywhere with such inconsistency, and if we do it in this script, we need to do it everywhere else. I would prefer to see a misc script searching for any kinds of data inconsistency in DB. We will then improve it incrementally. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added Attachment #76196|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 76289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76289=edit Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated This patch adds a system preference check around the call to the JavaScript include which sets the bibs_selected cookie. With BrowseResultsSelection disabled, the cookie should never be set. To test you should be using a browser with a tool for inspecting cookies. View the cookies for your Koha domain under each of these conditions, clearing cookies between each step: Without the patch applied: - With BrowseResultSelection enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have a bibs_selected cookie. With the patch applied: - With the BrowseResultSelection system preference enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have no bibs_selected cookie. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #37 from Kyle M Hall --- Created attachment 76287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76287=edit Bug 18072: (QA followup) Remove warning from tests This patch removes a warning from Items.t due to bad parameters. It also makes the tests use Test::Exception. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Hum yes, "commons.js" was certainly not the best name. Maybe the test must be moved to common.js, but not blocker for this quick fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #8 from Victor Grousset/tuxayo --- If I understand correctly: The good thing is that people can keep the old rule without issue so they won't have to change the RewriteRules for 18.05 and 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #38 from Kyle M Hall --- Created attachment 76288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76288=edit Bug 18072: Only accept Koha::Library in parameters I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #36 from Kyle M Hall --- Created attachment 76286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76286=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Colin Campbell changed: What|Removed |Added Attachment #76225|0 |1 is obsolete|| --- Comment #2 from Colin Campbell --- Created attachment 76281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76281=edit Signed off patch correcting ISBN extraction Signed off patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/