[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

--- Comment #7 from Josef Moravec  ---
Created attachment 76332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76332&action=edit
Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes
in OAI provider

Test plan:
0) apply the patchset
1) setup oai server with oaiconf file defining xsl_file for metadata
format marcxml or marc21
2) play with your oai and confirm that records are transformed as
expected
3) prove t/db_dependent/OAI/Server.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72553|0   |1
is obsolete||
  Attachment #72554|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 76331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76331&action=edit
Bug 19353: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

--- Comment #8 from Josef Moravec  ---
Just rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

 Blocks||20988


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988
[Bug 20988] Internationalization: wrap all translatable text inside t() calls
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] New: Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

Bug ID: 20988
   Summary: Internationalization: wrap all translatable text
inside t() calls
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr
Depends on: 15395

Bug 15395's Koha::I18n is working well, but it is basically useless until we
wrap all the translatable strings inside __*() calls (or t*() calls inside
templates).
This bug aims to do that.

I wrote a little tool to automatically find and replace translatable text by
the corresponding call. It can be found here :
https://github.com/jajm/koha-i18n.

This bug will hold a few patches that will make koha-i18n work better and I'll
try to attach all the changes it does.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
[Bug 15395] Internationalization: plural forms, context, and more
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #1 from Julian Maurice  ---
Created attachment 76333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76333&action=edit
Bug 20988: Modify templates so that they can be parsed as HTML

This is required for koha-i18n [1] to work correctly

[1] https://github.com/jajm/koha-i18n

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #2 from Julian Maurice  ---
Created attachment 76334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76334&action=edit
Bug 20988: Allow to create po for all languages at once

This is required for the script that comes with koha-i18n, which creates
the new PO files and fill them with existing translations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #3 from Julian Maurice  ---
Created attachment 76335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76335&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/includes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #5 from Julian Maurice  ---
Created attachment 76337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76337&action=edit
Bug 20988:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #8 from Julian Maurice  ---
Created attachment 76340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76340&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/admin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #7 from Julian Maurice  ---
Created attachment 76339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76339&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/acqui

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #4 from Julian Maurice  ---
Created attachment 76336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76336&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #6 from Julian Maurice  ---
Created attachment 76338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76338&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #12 from Julian Maurice  ---
Created attachment 76344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76344&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #10 from Julian Maurice  ---
Created attachment 76342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76342&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #11 from Julian Maurice  ---
Created attachment 76343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76343&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #9 from Julian Maurice  ---
Created attachment 76341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76341&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/authorities

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #16 from Julian Maurice  ---
Created attachment 76348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76348&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #14 from Julian Maurice  ---
Created attachment 76346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76346&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/clubs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #15 from Julian Maurice  ---
Created attachment 76347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76347&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #17 from Julian Maurice  ---
Created attachment 76349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76349&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/members

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #20 from Julian Maurice  ---
Created attachment 76352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76352&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #13 from Julian Maurice  ---
Created attachment 76345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76345&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/circ

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #18 from Julian Maurice  ---
Created attachment 76350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76350&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #22 from Julian Maurice  ---
Created attachment 76354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76354&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/installer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #21 from Julian Maurice  ---
Created attachment 76353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76353&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/plugins

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #19 from Julian Maurice  ---
Created attachment 76351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76351&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #24 from Julian Maurice  ---
Created attachment 76356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76356&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #25 from Julian Maurice  ---
Created attachment 76357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76357&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/serials

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #29 from Julian Maurice  ---
Created attachment 76361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76361&action=edit
Bug 20988: koha-tmpl/opac-tmpl/bootstrap/en/includes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #28 from Julian Maurice  ---
Created attachment 76360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76360&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #23 from Julian Maurice  ---
Created attachment 76355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76355&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #27 from Julian Maurice  ---
Created attachment 76359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76359&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #30 from Julian Maurice  ---
Created attachment 76362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76362&action=edit
Bug 20988: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #26 from Julian Maurice  ---
Created attachment 76358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76358&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #31 from Julian Maurice  ---
Created attachment 76363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76363&action=edit
Bug 20988: koha-tmpl/opac-tmpl/bootstrap/en/modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #32 from Julian Maurice  ---
Created attachment 76364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76364&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #33 from Julian Maurice  ---
Created attachment 76365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76365&action=edit
Bug 20988: Add a sample of a translated PO file

PO files are too big to be attached on Bugzilla, so here's a gzipped
version of misc/translator/po/fr-FR-messages.po as generated by
create-messages.sh (found in https://github.com/jajm/koha-i18n)

After applying the patch, run
  gunzip misc/translator/po/fr-FR-messages.po.gz

A few numbers about this PO file:
- Number of messages: 14178
- Number of translated messages: 13631
- Number of non-fuzzy translated messages: 9720

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #34 from Julian Maurice  ---
All theses patches (except the first two) were generated with the following
commands:

  koha-i18n --in-place koha-tmpl/**/en/**/*.tt koha-tmpl/**/en/**/*.inc  #
might 
be a zsh'ism, haven't tried with bash
  cd misc/translator &&
$GOPATH/src/github.com/jajm/koha-i18n/scripts/create-messages.sh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #35 from Julian Maurice  ---
Test plan:

1. Apply bug 15395
2. Apply the first two patches of this bug
3. Install koha-i18n (see the README)
4. Run koha-i18n on all .tt and .inc files
5. cd to misc/translator and run
$GOPATH/src/github.com/jajm/koha-i18n/scripts/create-messages.sh
6. Run ./translate install fr-FR  # or any available language
7. Reload starman
8. Go to Koha with your browser, switch language to fr-FR and check that the
strings translated in misc/translator/fr-FR-messages.po are translated in the
interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17705] Payments with cards through payment terminal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

--- Comment #11 from Josef Moravec  ---
Created attachment 76367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76367&action=edit
Bug 17705: payments using payment terminal

This patch expects already installed and configured payment terminal,
e.g Ingenico, provided by GPE (Global Payments Europe). This piece of
code already acquired an official certification in GPE Headquarter,
Prague, Czech Republic. Bank accounts connected to banks KB or CSOB
should work perfectly. Other banks will probably require additional
certifications and changes in the code.

Test plan
1) Appy this patch
2) Connect and/or start terminal device
3) Go to administration setting and look for "PosTerminal" items
4) Setup desired values (IP and port)
5) Make patron to pay a single fine (eg. lost book)
6) Tick the box "Pay by card" and confirm the payment
7) Popup window will raise displaying transaction status
8) Let the patron pay his amount using the terminal
9) When transaction finishes, close popup window
10) Optional: try to refund an amount by clicking "Refund to card"
button within fines overview (members/boraccount.pl). Steps 7-9 will
repeat accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17705] Payments with cards through payment terminal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

--- Comment #12 from Josef Moravec  ---
Created attachment 76368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76368&action=edit
Bug 17705: Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17705] Payments with cards through payment terminal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Josef Moravec  changed:

   What|Removed |Added

  Attachment #64526|0   |1
is obsolete||
  Attachment #64527|0   |1
is obsolete||
  Attachment #64528|0   |1
is obsolete||
  Attachment #64529|0   |1
is obsolete||
  Attachment #64613|0   |1
is obsolete||

--- Comment #10 from Josef Moravec  ---
Created attachment 76366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76366&action=edit
Bug 17705: Database structure update

This patch creates neccessary table and updates systempreferences.

Test plan:
1) Apply the patch
2) Check the presence of pos_terminal_transactions table
3) Observe new systempreferences' values
   - PosTerminalIP
   - PosTerminalPort
   - PosTerminalCurrencyCode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17705] Payments with cards through payment terminal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

--- Comment #13 from Josef Moravec  ---
Comment on attachment 76367
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76367
Bug 17705: payments using payment terminal

Review of attachment 76367:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17705&attachment=76367)
-

Radek, I just rebased your patches and have some comments on this patch:

::: Koha/PosTerminal/Client.pm
@@ +15,5 @@
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +

use Modern::Perl;

@@ +19,5 @@
> +
> +use IO::Socket::INET;
> +use IO::Socket::Timeout;
> +use Koha::PosTerminal::Message;
> +use Errno qw(ETIMEDOUT EWOULDBLOCK);

You are adding some new dependencies here, you should add them to
C4/Installer/PerlDependecies.pm, are they all available also for Debian in
needed versions?

::: Koha/PosTerminal/Message.pm
@@ +17,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

use Modern::Perl;

@@ +22,5 @@
> +
> +use Digest::CRC;
> +use Koha::PosTerminal::Message::Header;
> +use Koha::PosTerminal::Message::Field;
> +use Data::Dumper qw( Dumper );

Don't forget to remove debug printing;

@@ +178,5 @@
> +else {
> +$self->setValid(0);
> +}
> +}
> +#print Dumper($self);

Don't forget to remove debug printing;

@@ +221,5 @@
> +my $msg = $self->getHeader()->dumpObject();
> +
> +$msg .= "data:\n";
> +#print Dumper($self);
> +#die();

Don't forget to remove debug printing;

::: Koha/PosTerminal/Message/Field.pm
@@ +17,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

use Modern::Perl;

::: Koha/PosTerminal/Message/Header.pm
@@ +17,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

use Modern::Perl;

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +75,5 @@
>[% IF ( account.payment ) %]
>   class="btn btn-default btn-xs"> Reverse
>   class="btn btn-default btn-xs"> Void
> +[% IF (account.amountoutstanding+0 + account.amount+0 != 0 ) %]
> + class="btn btn-default btn-xs" onclick="refundPayment(this.href, [% 
> account.accountlines_id %], [% -1*account.amount %]);return false;"> class="fa fa-undo"> Refund to card

Do not use onclick parameter

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +46,4 @@
>  [% END %]
>  
>  [% IF ( pay_individual ) %]
> + onsubmit="return makePayment(this);" 
> action="/cgi-bin/koha/members/paycollect.pl">

Do not use onsubmit parameter

@@ +105,5 @@
> +
> +Pay by card: 
> +
> +
> +[% END %]

Consider using PAYMENT_TYPE authorised value

::: svc/pos_terminal
@@ +160,5 @@
> +
> +# send abort message
> +my $abort = new 
> Koha::PosTerminal::Message(Koha::PosTerminal::Message::DIR_SENT);
> +my $hdrAbort = $abort->getHeader();
> +die(Dumper($transaction ? $transaction->getHeader() : "BUBU"));

What does "BUBU" mean? :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17705] Payments with cards through payment terminal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Josef Moravec  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17705] Payments with cards through payment terminal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Josef Moravec  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #3 from Josef Moravec  ---
Raising severity as this generates ISE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Josef Moravec  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

--- Comment #5 from Josef Moravec  ---
Created attachment 76369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76369&action=edit
Bug 19902: (follow-up) Deal with patron column regarding on
intranetreadinghistory setting

Test plan:
Try it with intranetreadinghistory allowed and not allowed and it should
still work in both cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

--- Comment #6 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #4)
> Turn off intranetreadinghistory
> => boom!

Thanks for catching this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Josef Moravec  changed:

   What|Removed |Added

  Attachment #75625|0   |1
is obsolete||

--- Comment #8 from Josef Moravec  ---
Created attachment 76370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76370&action=edit
Bug 20806: Add item type description holds history page

Test plan:

0) Do not apply the patch
1) Set AllowHoldItemTypeSelection to Allow
2) Place some hold for a patron, some with specific item type and some
without item type
3) On holds history page you should see blank or item type code in item
type column
4) Apply the patch
5) Now you should see description in item type column
6) Set AllowHoldItemTypeSelection to Don't Allow
7) You shold not see the item type column, but column visibility
settings should continue working ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

--- Comment #9 from Josef Moravec  ---
Thanks all for comments/suggestions. I added the check of
AllowHoldItemTypeSelection system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19502] Result sets limited to 10000

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #9 from Julian Maurice  ---
(In reply to Alex Arnaud from comment #8)
> Debug thing ?

Yes. It can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19502] Result sets limited to 10000

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #10 from Julian Maurice  ---
Created attachment 76371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76371&action=edit
Bug 19502: Remove debug warn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19502] Result sets limited to 10000

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #11 from Julian Maurice  ---
Created attachment 76372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76372&action=edit
Bug 19502: Add POD for max_result_window

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18720] Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720

--- Comment #1 from Josef Moravec  ---
Created attachment 76373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76373&action=edit
Bug 18720: Use exception instead of die in GetBasketAsCsv

Test plan:
prove t/db_dependent/Acquisition/GetBasketAsCSV.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18720] Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720

Josef Moravec  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #1 from Andrew Isherwood  ---
Created attachment 76374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76374&action=edit
Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #2 from Andrew Isherwood  ---
Created attachment 76375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76375&action=edit
Bug 20968: Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

To test:

1) Download the plugin from
https://github.com/PTFS-Europe/cla-permissions-check-plugin
2) Follow the installation instructions from:
https://github.com/PTFS-Europe/cla-permissions-check-plugin
3) TEST: Observe that the "CLA Check Permissions" button takes the user
to the Check Permissions page and a modal displays containing the
results of the query
4) Remove the API key from the plugin "Configuration" page
5) TEST: Ensure that the "CLA Check Permissions" button takes the user
to the Check Permissions page and message displays informing the user
that "Did not receive required request parameters"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #76374|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

--- Comment #5 from Julian Maurice  ---
Created attachment 76377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76377&action=edit
Bug 16653: (QA follow-up) Avoid a warning and remove unused variables

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Julian Maurice  changed:

   What|Removed |Added

  Attachment #75937|0   |1
is obsolete||

--- Comment #4 from Julian Maurice  ---
Created attachment 76376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76376&action=edit
Bug 16653: Display number of checkouts when exporting 'Most-circulated items'
as CSV

reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

To replicate:

1/ Make sure that test instance has circulation in a given date range
2/ Go to Home › Reports › Most-circulated items
3/ Select a date range
4/ Select 'To screen into the browser' radio button, click submit.
5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of
checkouts' appear in screen output.
6/ Click the browser's back button
7/ Change output to 'To a file', click submit.

Without this patch:
the columns "100/", "Global" and "Total" are exported to the CSV file.
"100/" contains the rank, "Global" is still global, and the "Total" column is
empty.

With this patch patch applied, the last column is filled and the "Total" line
is removed

(This script is really dirty)

Signed-off-by: Pierre-Luc Lapointe 

(Yes it is)

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Julian Maurice  changed:

   What|Removed |Added

  Attachment #76165|0   |1
is obsolete||

--- Comment #3 from Julian Maurice  ---
Created attachment 76378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76378&action=edit
Bug 20893: batchRebuildItemsTables.pl has incorrect parameter

To test:
1 - run batchRebuildItemsTables.pl with a valid biblionumber
   perl /usr/share/koha/bin/batchRebuildItemsTables.pl --where
biblio.biblionumber=38483  -c
2 - Note it says 'undefined biblionumber
3 - Apply patch
4 - Do it again
5 - It works!

Signed-off-by: Katrin Fischer 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Signed Off  |Passed QA

--- Comment #4 from Julian Maurice  ---
This was broken by bug 19040.
The fix needs to be backported in 18.05.x and 17.11.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does not display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |j...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20989] New: Hold Notes to be added later

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20989

Bug ID: 20989
   Summary: Hold Notes to be added later
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fiona.borthw...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently it is only possible to add a Hold Note at the time of creating the
hold. It would be nice if notes could be added at a later stage.

A few of our customers have asked for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20868] Making billing date mandatory when closing invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20868

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #11 from claire.hernan...@biblibre.com 
 ---
20073 had been reverted, so I was waiting for its push, it now ok so 20390
applies now. Thanks Nick !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20990] New: Add Koha::Account::outstanding_credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Bug ID: 20990
   Summary: Add Koha::Account::outstanding_credits
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

This will be handy for the /patrons/{patron_id}/account endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20585] Label surname as name for organisation type patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20585] Label surname as name for organisation type patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

--- Comment #1 from Owen Leonard  ---
Created attachment 76379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76379&action=edit
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20585] Label surname as name for organisation type patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20983] Show 'organisation name' instead of 'surname' on patron form for organisations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20983

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 20585 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 76380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76380&action=edit
Bug 20990: Unit tests for Koha::Account->outstanding_credits

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20585] Label surname as name for organisation type patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

--- Comment #2 from Owen Leonard  ---
*** Bug 20983 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 76381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76381&action=edit
Bug 20990: Add Koha::Account->outstanding_credits

This patch adds a method that retrieves (for a patron's account) the
outstanding credits (i.e. those that haven't been applied to any debit.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20942] Add route to get patron's account balance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||20990, 20946


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
[Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990
[Bug 20990] Add Koha::Account::outstanding_credits
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12500] In opac-detail-view, "Browse results" shows indexes from the beginning upon hovering over the last index.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12500

--- Comment #2 from Owen Leonard  ---
I hope that Bug 20898 will make this bug obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing external sources

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Owen Leonard  ---
All dependent bugs are marked fixed, so I think this bug is ready to be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20930] Handle YAML type system preferences as parsed references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #1 from Lari Taskula  ---
Created attachment 76382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76382&action=edit
Bug 20930: Dump and load system preferences of YAML/JSON type

Currently, C4::Context->preference('YAMLpref') returns a string that needs to
be
parsed by any code using the preference.

My suggestion is to return a parsed version instead (a hash/array ref or a
string)
and using the syspref cache with the parsed value. Like this, we could:
- centralize parsing of YAML system preferences
- optimize use of system preference cache by caching the parsed version
instead.
  Parse once and store in cache; no need to re-parse on each call!

We can centralize this functionality into Koha::Config::SysPref->value() (used
by
C4::Context->preference). Use database column systempreferences.type with value
of
"YAML" to trigger this functionality in "value()"-method.

To test:
1. prove t/db_dependent/Context.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20930] Handle YAML type system preferences as parsed references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #2 from Lari Taskula  ---
Created attachment 76383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76383&action=edit
Bug 20930: First example - Change OpacHiddenItems to type YAML

To test:
1. prove t/db_dependent/Items.t
2. Check that desired items are still hidden in OPAC by using
   OpacHiddenItems as documented here:
   https://wiki.koha-community.org/wiki/OpacHiddenItems

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20930] Handle YAML type system preferences as parsed references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #3 from Lari Taskula  ---
Created attachment 76384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76384&action=edit
Bug 20930: Display human readable errors in preferences page

Displays human readable error when YAML/JSON preference has invalid syntax.

If multiple preferences are modified at the same time, notifies librarian of
the
preferences that were saved and the ones that had errors.

To test:
1. Apply patches
2. Write invalid YAML syntax to OpacHiddenItems system preference
3. Observe "Error; Preference OpacHiddenItems has invalid syntax" error
4. Write valid YAML syntax to OpacHiddenItems system preference
5. Observe "Saved preference OpacHiddenItems" message
6. Test steps 2-5 for both single preference modification and together
   with other system preferences.

---
invalid:
yaml syntax

---
valid:
  yaml: syntax

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20930] Handle YAML type system preferences as parsed references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

--- Comment #1 from Owen Leonard  ---
Created attachment 76385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76385&action=edit
Bug 20559: Occurrences of loading-small.gif still exist

This patch removes some leftover references to a file which no longer
exists. In the OPAC, loading-small.gif was included in CSS which was
never used. In the staff client, loading-small.gif should have been
corrected to spinner-small.gif.

To test, apply the patch and go to Tools -> Batch record modification.

 - Submit a batch of records to modify
 - In the table of titles which will be modified, click the 'Show MARC'
   button.
   - The modal preview window should show "Loading" and an animated
 spinner before the MARC record is loaded.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

--- Comment #2 from Owen Leonard  ---
Created attachment 76386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76386&action=edit
Bug 20559: Compiled CSS

This patch contains the compiled OPAC CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Lari Taskula  changed:

   What|Removed |Added

Summary|Handle YAML type system |Validate and cache parsed
   |preferences as parsed   |YAML/JSON type system
   |references  |preferences

--- Comment #4 from Lari Taskula  ---
Changed Bug title 

from "Handle YAML type system preferences as parsed references" 
to "Validate and cache parsed YAML/JSON type system preferences" 

as this now also adds syntax validation for librarians, so that it is no longer
possible to store invalid YAML system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #5 from Lari Taskula  ---
Also fyi, these patches do not automatically change the functionality for all
YAML/JSON type system preferences.

The type (systempreferences.type) needs to be YAML before this applies for the
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16970] In OPAC Search results, hides a record if some of its items are available and others unavailable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16970

Owen Leonard  changed:

   What|Removed |Added

   Hardware|PC  |All
 OS|Windows |All
Version|3.22|master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #1 from Owen Leonard  ---
Confirmed in master. A title with multiple items, one of which is checked out,
is hidden from search results when the 'Limit to available' filter is applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/