[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #10 from Barton Chittenden --- Request for back-port (issue first occurs in 17.11, I believe) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Mirko Tietgen changed: What|Removed |Added Attachment #75338|0 |1 is obsolete|| --- Comment #14 from Mirko Tietgen --- Created attachment 76599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76599=edit Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed Add CGI::Emulate::PSGI to PerlDependencies.pm Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #8 from Mirko Tietgen --- Martin: is in 18.05.01-2, please push to 18.05.02. Fridolin: is in 17.11.07-2, please push to 17.11.08. Depends on 20693 for 17.11.x, please push the other one first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Mirko Tietgen changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #13 from Mirko Tietgen --- Fridolin: Needs to go to 17.11. Is in 17.11.07-2 package, please push for 17.11.08! Minor rebase needed, I'll send a changed patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Charles Farmer changed: What|Removed |Added Attachment #76458|0 |1 is obsolete|| --- Comment #2 from Charles Farmer --- Created attachment 76598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76598=edit Bug 20999: Remove invalid 'style="block"' from OPAC templates This patch removes an invalid attribute from OPAC template markup. There should be no visible change to the OPAC. To test, apply the patch and confirm that the following pages still look correct when using various cover image sources: Coce, Amazon, Google: - Bibliographic detail page (opac-detail.pl) - The shelf browser - Catalog search results - Recent comments Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer --- Reganing my QA token with Charles' additional sign-off - switching this to PQA.off I -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||charles.far...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer changed: What|Removed |Added Attachment #76422|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 76595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76595=edit Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer changed: What|Removed |Added Attachment #76474|0 |1 is obsolete|| --- Comment #9 from Charles Farmer --- Created attachment 76597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76597=edit Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. Signed-off-by: Katrin Fischer Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer changed: What|Removed |Added Attachment #76595|0 |1 is obsolete|| --- Comment #8 from Charles Farmer --- Created attachment 76596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76596=edit Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #22 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20585] Label surname as name for organisation type patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20520] Re-indent moremember.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20991] Error will reset category when editing a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10348] Show number of items on tab headings in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from zebra-output.log when EasyAnalyticalRecords is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17869] Don't show pick-up library for list of holds in OPAC account when there is only one branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen changed: What|Removed |Added Status|Signed Off |Passed QA CC||n...@bywatersolutions.com --- Comment #7 from Mirko Tietgen --- Jerome, thanks a lot for spotting the problem and your patch! Minor QA change: first line of the commit message is supposed to be Bug x: Your bug report title I changed it and generated the new control file. Nick, please push, I will do a 18.05.01-2 and probably 17.11.07-2 package with this because it breaks fresh Koha with Plack on Stretch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #150 from David Bourgault --- Created attachment 76594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76594=edit Bug 17015: Improved UI readability * The calendar tool page no longer shows past holidays in the lists on the right side of the page. * Improved wording in the "Hints" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 --- Comment #13 from Jonathan Druart --- Created attachment 76593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76593=edit Bug 20806: Surround string by span tag to help translation Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 --- Comment #12 from Jonathan Druart --- Created attachment 76592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76592=edit Bug 20806: Do not rely on column position It is not the first time we have this splice call, it seems safer to rely on the column's name instead of the column's position Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What|Removed |Added Attachment #76585|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 76591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76591=edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen changed: What|Removed |Added Attachment #76217|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #6 from Mirko Tietgen --- Created attachment 76590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76590=edit Bug 20920: Followup: generated d/control Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #5 from Mirko Tietgen --- Created attachment 76589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76589=edit Bug 20920: Add missing dependency on CGI::Compile Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 --- Comment #1 from Charles Farmer --- Created attachment 76588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76588=edit Bug21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Charles Farmer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #19 from Jonathan Druart --- Pmed with Tomas, we agreed that outstanding_debits should return Koha::Account::Lines, then Koha::Account::Lines should have new methods to do the sum calculation. It will make the sum reusable and outstanding_debits return only what it needs to return (a set of lines) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 --- Comment #10 from Nick Clemens --- Created attachment 76587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76587=edit Bug 20945: (RM follow-up) Escape param_name too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] New: Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Bug ID: 21025 Summary: Koha::Patron::Discharge is missing use C4::Letters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: charles.far...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Tried to download a discharge slip from the OPAC, but received the following message: > An error occurs when generating the pdf file. Please contact the staff to > resolve this problem. >From the logs: > [Fri Jun 29 15:34:45.758105 2018] [cgi:error] [pid 10573] [client > 127.0.0.1:44946] AH01215: [Fri Jun 29 15:34:45 2018] opac-discharge.pl: > Undefined subroutine ::Letters::GetPreparedLetter called at > /meow/Koha/Patron/Discharge.pm line 113.: /meow/opac/opac-discharge.pl, > referer: http://master/cgi-bin/koha/opac-discharge.pl Will submit patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
--- Comment #18 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #17)
> Quick code review:
>
> 1. I do not like "return ( $total, $lines );"
> We are simplifying the call here, but maybe next ones will not need the
> total, or the line. It seems that we are recreating wrong patterns from C4.
Do you prefer a Koha::Account::OutstandingCredits objecT?
or
Koha::Account->oustanding_debits_total + outstanding_debit_lines ?
> 2.
> Koha::Account->new( { patron_id => $borrowernumber } )->outstanding_debits;
> should be
> $patron->account->outstanding_debits
I agree. This is an easy fix, though.
> 3. ->balance is used from several other places, do we need to update them as
> well?
Balance is another thing. Balance is a global value representing if the patron
owes or has credit. The point of having debits and credits separate is
replicating what other tools do (see any bank account balance, for example). So
in many places where ->balance is used, it is done in a correct way!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953
Charles Farmer changed:
What|Removed |Added
Attachment #76117|0 |1
is obsolete||
--- Comment #6 from Charles Farmer ---
Created attachment 76586
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76586=edit
Bug 20953: Prevent several discharge requests on OPAC
On OPAC, a user can requested a discharge even if one is already pending.
This generates several pending discharges in staff interface that can not be
deleted.
This is because request operation leads to page 'opac-discharge.pl?op=request'
and user can refresh this page performing a new request.
Perl code must check that operation is allowed.
Patch reoganised the code so that the following FIXME is obsolete :
'FIXME looks like $available is not needed'
Patch also replaces 'op' arg test to also check undef : input->param("op") //
''
Test plan :
1) Set system preference 'useDischarge' to 'Allow'
2) Choose a patron without checkouts nor fines nor restrictions
3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl
4) Click on 'ask for a discharge' tab
=> You see /cgi-bin/koha/opac-discharge.pl
with text 'What is a discharge? ...'
5) Click on 'Ask for a discharge' link
=> You see /cgi-bin/koha/opac-discharge.pl?op=request
with text 'Your discharge request has been sent ...'
6) In a new browser tab/page, go to intranet on
/cgi-bin/koha/members/discharges.pl
=> You see one discharge requets for the patron
7) Come back to OPAC and refresh page
=> You see /cgi-bin/koha/opac-discharge.pl
with text 'Your discharge will be available on this page within a few days.'
8) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl
=> There is still one requets for the patron
9) Come back to OPAC and enter URL /cgi-bin/koha/opac-discharge.pl?op=get
=> You see /cgi-bin/koha/opac-discharge.pl
with text 'Your discharge will be available on this page within a few
days.'
10) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl
=> There is still one requets for the patron
11) Click on 'allow' on patron discharge request
12) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
=> You see link 'Get your discharge'
13) enter URL /cgi-bin/koha/opac-discharge.pl?op=request
=> You see same page and no new discharge requets is created
14) Come back to intranet on patron details page
15) Remove the discharge restriction
16) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
=> You see text 'What is a discharge?...'
17) enter URL /cgi-bin/koha/opac-discharge.pl?op=get
=> You see same page and no new discharge requets is created
Signed-off-by: Charles Farmer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com --- Comment #5 from Charles Farmer --- Two things: * This bug's dependency is now 'pushed to stable'. The patch in this bug can now be applied alone. * Oddly, there seems to be an issue with generate_as_pdf at the end of the test plan. This is what I get on my system: Undefined subroutine ::Letters::GetPreparedLetter called at /.../Koha/Patron/Discharge.pm line 113 Since the issue I mentionned is unrelated to the problem you're trying to solve, I'll open another bug for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #17 from Jonathan Druart
---
Quick code review:
1. I do not like "return ( $total, $lines );"
We are simplifying the call here, but maybe next ones will not need the total,
or the line. It seems that we are recreating wrong patterns from C4.
2.
Koha::Account->new( { patron_id => $borrowernumber } )->outstanding_debits;
should be
$patron->account->outstanding_debits
3. ->balance is used from several other places, do we need to update them as
well?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Nick Clemens changed: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Maryse Simard changed: What|Removed |Added Attachment #76370|0 |1 is obsolete|| --- Comment #10 from Maryse Simard --- Created attachment 76585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76585=edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 --- Comment #16 from Nick Clemens --- Question here: before this patch I can 'Write off all' to clear the credit too, after I have no way to clear the credit, shuld that functionality wait on another bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Charles Farmer changed: What|Removed |Added Attachment #75703|0 |1 is obsolete|| --- Comment #15 from Charles Farmer --- Created attachment 76584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76584=edit Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button This patch makes a third stab at resolving this issue by reorganizing the authorities toolbar buttons to more closely match the bibliographic toolbar buttons: - "New from Z39.50" has been added to the "New authority" dropdown. - "Edit" is now a dropdown, like on the bibliographic detail page: - Edit record - Edit as new (duplicate) - Replace record via Z39.50/SRU - Delete record To test, apply the patch and go to the authorities module. Testing with existing Z39.50 authority sources configured: - On the authorities home page and the authorities search results page, the "New authority" menu should have a "New from Z39.50" link. - View the details for an authority record. The menus should appear as described above. Test each option. Remove all Z39.50 authority servers and test again. The "New from Z39.50" link should no longer appear. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #184 from Jonathan Druart --- virtualshelfcontents entries are not deleted when a bibliographic record is removed: - Add 3 biblios to a list - Remove one - /virtualshelves/shelves.pl?op=list=1 says "3 item(s)" - click on the list => There are only 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 --- Comment #3 from Jonathan Druart --- It's too hard to get rid of the cookie. It is used for add to cart and list selection. The safer is to keep and use it, even if the pref is turned off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Jonathan Druart changed: What|Removed |Added Attachment #76579|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 76583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76583=edit Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #76238|0 |1 is obsolete|| --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 76582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76582=edit Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20765] Search for items by acqdate does not work in label batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20765] Search for items by acqdate does not work in label batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765 Maryse Simard changed: What|Removed |Added Attachment #75306|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 76581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76581=edit Bug 20765: Fix search for items by acqdate in label batch In Tools > Label creator, when creating a batch you can add items using a search. This search has filters on acquisition date. Actually those filters does not work. The create a search using CCL syntaxe to query Zebra search engine. The cause is that operator "ge" or "le" must be before "st-date-normalized" in CCL query. Looks like it is because of "st-date-normalized" uses "r=o" in ccl.properties. Test plan : 1) Check in advance search you have indexed acquisition date 2) Go to Tools > Label creator 3) Click on New > Label batch 4) Click on Add item(s) 5) Enter a relevent date in "Added on or after date" and in "Added on or before date" 6) Click on "Search" => Without patch you get no results => With patch you get expected results Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Charles Farmer changed: What|Removed |Added Attachment #76307|0 |1 is obsolete|| --- Comment #52 from Charles Farmer --- Created attachment 76580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76580=edit Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 --- Comment #1 from Jonathan Druart --- Created attachment 76579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76579=edit Bug 21024: (bug 20864 follow-up) Only set bibs_selected cookie when BrowseResultSelection is activated This is an attempt to fix correctly the problem bug 20864 tried to solve. The cookie bibs_selected must only be defined if BrowseResultSelection is set. Bug 20864 removed the inclusion of commons.js, but some code from results.tt We should include it and take care of the pref in each function. Test plan: Retest 19290 and 20864 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Jonathan Druart changed: What|Removed |Added Depends on||20864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21024] New: JS error on search result breaks JS functionalities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Bug ID: 21024 Summary: JS error on search result breaks JS functionalities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Staff Client Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Caused by bug 20864, some JS functions defined in commons.js are called by search.pl The JS error is: ReferenceError: resetSearchContext is not defined It breaks add to basket, list, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added Blocks||21024 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Bad one, there is a JS error on the search result, which breaks all JS > functionalities (add to basket, list, etc.) See bug 20864. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 [Bug 21024] JS error on search result breaks JS functionalities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 --- Comment #8 from Jonathan Druart --- Bad one, there is a JS error on the search result, which breaks all JS functionalities (add to basket, list, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20901] Koha/Patrons/Import.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20901 Jonathan Druart changed: What|Removed |Added Severity|normal |minor CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores -D
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Jonathan Druart changed: What|Removed |Added Summary|debian/build-git-snapshot |debian/build-git-snapshot |script ignores |script ignores -D |--distribution | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores --distribution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- There is a colision with debug: 41 'distribution|D=s' => \$distribution, 46 'debug|d' => \$debug, It works with the long option name (--distribution) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are silently truncated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 --- Comment #2 from Jonathan Druart --- Created attachment 76578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76578=edit Bug 21009: Fix max length of inputs on editing/adding items There is a "max length" value you can define at framework level to limit the size of the input. But it is not taken into account on the add/edit item form. It is a regression that has been introduced by commit 47d2de9c024bfb93d56184f298f334b20685cd86 Bug 12176: Remove HTML from additem.pl max_length vs maxlength Test plan: - Define a maximum length for an item subfield - Add or edit an item => Without this patch the maxlength attribute of the inputs are not defined (maxlength="") => With this fix you will see the maxlength attributes correctly set with the value you defined in the framework Note: We could/should set this value to the size of the DB column when mapped For instance 952$u is mapped with items.uri, which is a varchar(255). This length restriction should done at framework level -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are silently truncated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are silently truncated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|17.11 |master Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart --- I do not know if I am going to address you concern here but I found a bug. There is a "max length" value you can defined at framework level, to limit the size of the input. But it is not taken into account on the add/edit item form. It is a regression that has been introduced by commit 47d2de9c024bfb93d56184f298f334b20685cd86 Bug 12176: Remove HTML from additem.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #25 from Cab Vinton --- (In reply to Jonathan Druart from comment #24) > There are sandboxes to test patches without any technical skills. Wrong > answer ;) Ah, not familiar w/ those. Think this would be a great training session for the Koha libraries in New England. Will contact our friends at ByWater & see if they have or know of anyone in our neck of the woods. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20409] Remove OpacBrowseResults system preference and make it always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20409 --- Comment #4 from Owen Leonard --- See also Bug 20898. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20414] Remove COinSinOPACResults system preference and make it always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11025] Display UNIMARC fields having $5 subfield with related items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11025 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 --- Comment #1 from Owen Leonard --- Created attachment 76577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76577=edit Bug 10562: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl This patch takes the suggestions in Bug 10562 and implements those changes in MARC21slim2OPACResults.xsl. This patch also makes the following changes: - De-duplicate famfamfam icons: Remove the /silk subdirectory and move non-duplicates to famfamfam/; Correct paths to these images in templates and CSS - Improve the granularity of some material type icon choices: Show "Film," "Picture," or "Object" instead of "Visual material." - Remove unnecessary title attributes from material type images - Implement the kind of changes made in Bug 18235, "Add classes to material type icons on result lists and detail pages" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #64 from Martin Renvoize --- I take that last comment back.. once I found the right accounting book to read it made a lot more sense.. though I'm not sure how well it translates to credits.. 'encumbered' tends to mean 'committed to paying', but a credit it sorta the opposite. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Tomás Cohen Arazi changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Tomás Cohen Arazi changed: What|Removed |Added Status|RESOLVED|REOPENED CC||tomasco...@gmail.com Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Nick Clemens changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Nick Clemens --- Frido, I think I missed this one, needed for 17.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #63 from Martin Renvoize --- Encumber is a really odd term.. I'm wondering where it came from.. even as a native english speaker I can't entirely work out what it means in this context. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #39 from Kyle M Hall --- (In reply to Jonathan Druart from comment #38) > Kyle, > > Go to "Default checkout, hold and return policy", you do not see "Total > holds allowed", fill the other fields, save: default_circ_rules.holdallowed > is filled. > We could add it to the interface and make it configurable, do not you think? holdallowed doesn't define how many holds may be placed, it defines what items a patron may place holds on. It's already revealed in the rules editor! > > Also if we add "max_holds", maybe we should rename "holdallowed" then. Again, not the same thing. > > After that is done, the code in CanItemBeReserved could be replaced with a > call to GetBranchBorrowerCircRule. > > Without these changes we add more confusion to the code in my opinion. > > I will not have the time to provide such change before the release. > > Setting to in discussion to get other QAer opinions on these patches. > > Feel free to provide a patch if you think my requests make sense to you. I think your comment is based on a fundamental misunderstanding of what holdallowed does. If I'm wrong let me know! We could definitely add max_holds to the default_circ_rules table, but that should be done on another bug as it is out of scope for this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #24 from Jonathan Druart --- There are sandboxes to test patches without any technical skills. Wrong answer ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 76576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76576=edit Bug 21023: Remove warning in t/db_dependent/Circulation/Chargelostitem.t To test: - Run: $ kshell k$ prove t/db_dependent/Circulation/Chargelostitem.t => FAIL: Warning is displayed - Apply this patch - Run: k$ prove t/db_dependent/Circulation/Chargelostitem.t => SUCCESS: Tests pass! No warning! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21023] New: Remove warning in t/db_dependent/Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Bug ID: 21023 Summary: Remove warning in t/db_dependent/Circulation/Chargelostitem.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org To reproduce: - Run: $ kshell k$ prove t/db_dependent/Circulation/Chargelostitem.t => FAIL: Warning is displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #23 from Cab Vinton --- (In reply to Jonathan Druart from comment #22) > (In reply to Cab Vinton from comment #18) > Did you test the rebase patches? If this is really directed at me, No. Just a humble librarian who has no idea how to test patches, etc. Willing to consider a career change, however ;-) Cab -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
