[Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #4 from Katrin Fischer --- Testing without items bulkmarcimport seems to mostly work (apart from the update option, see bug 20811). I also tested with a record exported from Koha with 3 items: /home/vagrant/kohaclone/misc$ ./stage_file.pl --match 3 --file ../data/bib-69.utf8 --item-action replace --add-items ... staging MARC records -- please wait ... finished staging MARC records ... looking for matches with records already in database Invalid normalization routine required (Biblionumber) at /home/vagrant/kohaclone/C4/Matcher.pm line 874. ... finished looking for matches MARC record staging report Input file: ../data/bib-69.utf8 Record type:biblio Number of input records:1 Number of valid records:1 Number of invalid records: 0 Number of records matched: 1 Number of items parsed: 3 Batch number assigned: 2 kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc$ ./commit_file.pl --batch-number 2 ... importing MARC records -- please wait ... finished importing MARC records MARC record import report Batch number:2 Number of new records added: 0 Number of records replaced: 1 Number of records ignored: 0 Number of items added: 0 Number of items replaced:3 Number of items ignored: 0 Then I deleted the record and tried another import: ./stage_file.pl --match 3 --file ../data/bib-69.utf8 --item-action always_add --add-items ./commit_file.pl --batch-number 4 Record and items were added. Tested on master. I think we need more information to track this problem down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #5 from Katrin Fischer --- Should add: tests were done on a freshly reset_all MARC21 database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Katrin Fischer changed: What|Removed |Added CC||alex.arn...@biblibre.com, ||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com, ||stephane.delaune@biblibre.c ||om --- Comment #4 from Katrin Fischer --- Need some reinforcements here, I think we are looking at a bigger issue. With and without the patch I don't get it to work with the -update option: $ ./bulkmarcimport.pl -b -file ../../data/Katrin-biblios.mrc -v -update Characteristic MARC flavour: MARC21 .DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`biblio_metadata`, CONSTRAINT `record_metadata_fk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `biblio_metadata` ( `format`, `marcflavour`, `metadata`) VALUES ( ?, ?, ? )" with ParamValues: 0='marcxml', 1='MARC21', 2=" http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd; xmlns="http://www.loc.gov/MARC21/slim;> 00647cas a2200229 4500 012079189 DE-576 20180708032646.0 tu 860818cxxm0ita c (OCoLC)72970470 (DE-599)BSZ012079189 DE-576 ger DE-576 line 1. Use of uninitialized value in sprintf at /home/vagrant/kohaclone/Koha/Exceptions/Exception.pm line 19, line 1. Invalid parameter passed, biblionumber= does not exist I've also tried using it with match: $ ./bulkmarcimport.pl -b -file ../../data/Katrin-biblios.mrc -v -match Control-number,001 -update The result is always the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Katrin Fischer changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20979] Error message when deleting bib attached to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Katrin Fischer changed: What|Removed |Added Attachment #76248|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 76777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76777=edit Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20979] Error message when deleting bib attached to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20979] Error message when deleting bib attached to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I think ultimately we should do something more clever here, like checking if the orders have all been received or cancelled before complaining. But this is a bug fix and as such perfect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer changed: What|Removed |Added Attachment #74830|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 76776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76776=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I think I like the new display better. As it's supposed to be a summary displaying only open credits and fines makes sense to me, but the heading should then be changed to match the new display. Signing, but waiting for follow-up and maybe another opinion here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer changed: What|Removed |Added Attachment #74829|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 76775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76775=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20949] Koha depends on Clone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20949] Koha depends on Clone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Katrin Fischer changed: What|Removed |Added Attachment #76643|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 76773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76773=edit Bug 20949: Koha depends on Clone Clone was not declared a dependency before. It used to be a dependency of Hash::Merge but isn't in the recent version. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20949] Koha depends on Clone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Katrin Fischer changed: What|Removed |Added Attachment #76644|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 76774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76774=edit Bug 20949: Followup: debian/control Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Katrin Fischer changed: What|Removed |Added Attachment #75487|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 76772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76772=edit Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Katrin Fischer --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Katrin Fischer changed: What|Removed |Added Attachment #76140|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76771=edit Bug 20698 - Remove obsolete template: transfer-slip.tt This patch removes an unused template file, circ/transfer-slip.tt. Its use was removed by Bug 7001: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ded4fa008668df8c485fbbc76efa3cc9cc00d7#patch12 To test, apply the patch and confirm that the file has been removed. Confirm that no references to the template exist in the codebase. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #28 from Katrin Fischer --- Sorry, don't see the noise. Can you pleas recheck and amend test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Katrin Fischer changed: What|Removed |Added Attachment #75549|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 76770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76770=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Signed Off --- Comment #13 from Katrin Fischer --- I redid the second patch from scratch as it did no longer apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What|Removed |Added Attachment #75664|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 76768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76768=edit Bug 16575: Irregular behaviour using window.print() followed by window.location.href This patch updates the OPAC and staff client carts to use CSS to control print output, removing a print parameter which was passed to the script. Currently, when you click "Print" on the OPAC basket, it navigates to a new page and initiates window.print() followed by a window.location.href change again. Unfortunately, due to differences in IE, Chrome, and FF, it will either show the print options, navigate away without showing them, or refuse to navigate away after printing. By changing to using print CSS, we don't navigate away from the basket in the first place, so we prevent this irregular behavior. TEST PLAN 1) Apply the patch 2) Create an OPAC basket by clicking "Add to cart" on multiple items 3) Using Chrome, IE, and Firefox (of any version), click the "Print" button 4) You should see the relevant print menu without the OPAC basket re-loading in any way. 5) After printing is complete, you should still be on the OPAC basket pop-up 6) Perform the same tests in the staff client Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What|Removed |Added Attachment #75665|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 76769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76769=edit Bug 16575: (follow-up) Compiled CSS This patch contains the compiled CSS for the OPAC print stylesheet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added Attachment #76545|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 76766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76766=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added Attachment #76547|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 76767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76767=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- No test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Katrin Fischer changed: What|Removed |Added Attachment #75561|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 76765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76765=edit Bug 18822: Check if we have MARC::Record and convert if not when using ES The new_record_from_zebra subroutine assumes that when using ES we always get MARC::Record objects when using ES, but sometimes we get them as xml via Z39 or internally. This adds a test to new_from_zebra to confirm we have a record object and to convert it if not To test: 1 - Perform an advanced search from the advanced editor, make sure to select 'Local catalog' and a remote source 2 - Error 'Internal search error [Object object]' 3 - Apply patch 4 - Repeat search, success! 5 - Select and deselect various servers, search should still work Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Katrin Fischer changed: What|Removed |Added Attachment #68804|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 76764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76764=edit Bug 18822 - Better error response Apply this patch first to see a change in the error feedback - instead of [Object object] you should get a text readable error Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 --- Comment #16 from Katrin Fischer --- This will only explode when there is a record found locally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I think it would be good to also add a database update cleaning up existing frameworks. What do you think, Frido? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Katrin Fischer changed: What|Removed |Added Attachment #76738|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76763=edit Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle. This table was removed when upgrading from Koha 2.2 to 3.0. Test plan : 1) Create a new install with web installer 2) Check that creating a record is OK Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What|Removed |Added Attachment #76229|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76762=edit Bug 20974: Remove files left behind after removing Solr Some files were left behind when Bug 12538 removed support for Solr. This patch removes them. To test, apply the patch and fail to observe the existence of these files: koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc Perform a search in the OPAC to confirm that nothing broke. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 --- Comment #3 from Katrin Fischer --- Created attachment 76761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76761=edit Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 --- Comment #2 from Katrin Fischer --- Can't reproduce the problem, but we have seen similar recently and this will not hurt. Please don't forget to assign bugs to yourself when providing or planning to provide a patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |charles.far...@inlibro.com |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Katrin Fischer --- Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21051] New: CGI::param called in list context when editing a patron card layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Bug ID: 21051 Summary: CGI::param called in list context when editing a patron card layout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org To test: - Edit a patron card layout - Save or cancel editing CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Katrin Fischer changed: What|Removed |Added Severity|minor |major CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Updating severity too - not being able to print is not good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #8 from Katrin Fischer --- Created attachment 76760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76760=edit Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Marcel, I've tried testing this, but can't reproduce the errors. What exactly do you mean by: Open a basket that contains no prices. ? I've tried closing and reopening a basket with one order line where I left all entries empty, but that didn't do it. Closing an empty basket is not possible, so I am a little lost here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Katrin Fischer changed: What|Removed |Added Attachment #76576|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76759=edit Bug 21023: Remove warning in t/db_dependent/Circulation/Chargelostitem.t To test: - Run: $ kshell k$ prove t/db_dependent/Circulation/Chargelostitem.t => FAIL: Warning is displayed - Apply this patch - Run: k$ prove t/db_dependent/Circulation/Chargelostitem.t => SUCCESS: Tests pass! No warning! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What|Removed |Added Attachment #72414|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 76758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76758=edit Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. Compare to opac-results.tt Signed-off-by: Pasi Kallinen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I think PazPar2 and grouped results are going to be deprecated, see bug 20410. But changes make sense from carefully reading and checking them. I am going to sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20332 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20410 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Katrin Fischer changed: What|Removed |Added Attachment #70920|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76757=edit Bug 20090: Missing script statement for Novelist Select on some record displays in OPAC This patch adds a check for UPCs and well as ISBNs to the Novelist Select conditionals in opac-detail.tt To test (note that you must subscribe to Novelist Select): 1. If your library does not use the raton ratings feature, activate it for the purposes of this test. 2. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will display as 5 radio buttons and a "rate it" button. 3. Apply the patch. 4. Display the same record again. The radio buttons will be replaced with stars. This indicates that the scripts on the page completed. Rather that using the patron ratings as in indicator, you can also use a web page inspector/debugger such as firebug or the built-in inspectors in most newer browsers to check for script errors. Signed-off-by: Katrin Fischer I couldn't check with Novelist Select, but read and checked changed made carefully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I am not sure we should allow returning of a borrowernumber for an empty cardnumber. This could lead to all kinds of problems. I feel we should return an error for an empty cardnumber. What if 2 patrons pick the same password or are imported with the same default password? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #3 from Katrin Fischer --- We assume cardnumbers need to be unique, NULL should not be treated as a valid value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Just noticed, there is a typo in the author line: Kyle M Hall watet instead of water -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273
--- Comment #13 from Katrin Fischer ---
I'd love to test this, but I am stuck on my Elasticsearch authority search not
working at all.
This is what I've tried:
I've reset my mappings using:
http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1
Then I've done a complete reindex.
When I search for an authority, I get an Internal server error resolving to:
[Request] ** [http://localhost:9200]-[400] [query_shard_exception] No mapping
found for [Heading__sort.phrase] in order to sort on, with:
{"index":"koha_kohadev_authorities","index_uuid":"FwdgBXbyRq-5E0F3sa4LTA"},
called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars:
{'request' => {'method' => 'GET','path' =>
'/koha_kohadev_authorities/data/_search','ignore' => [],'mime_type' =>
'application/json','qs' => {},'body' => {'sort' => [{'Heading__sort.phrase' =>
'asc'}],'query' => {'bool' => {'should' => [{'match' => {'Heading-Main' =>
'k'}}]}},'size' => 20,'from' => 0},'serialize' => 'std'},'status_code' =>
400,'body' => {'status' => 400,'error' => {'type' =>
'search_phase_execution_exception','grouped' => bless( do{\(my $o = 1)},
'JSON::PP::Boolean' ),'failed_shards' => [{'shard' => 0,'reason' => {'index' =>
'koha_kohadev_authorities','type' => 'query_shard_exception','reason' => 'No
mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' =>
'FwdgBXbyRq-5E0F3sa4LTA'},'node' => 'vSTPqetISteesIkQSA_Ehg','index' =>
'koha_kohadev_authorities'}],'phase' => 'query','reason' => 'all shards
failed','root_cause' => [{'type' => 'query_shard_exception','index' =>
'koha_kohadev_authorities','reason' => 'No mapping found for
[Heading__sort.phrase] in order to sort on','index_uuid' =>
'FwdgBXbyRq-5E0F3sa4LTA'}]}}}
Unable to perform your search. Please try again.
Anyone able to help or point me in the right direction?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi David, 1) Can you please add an entry for the new system preference in sysprefs.sql? 2) I wonder, is this something where picking a sensible default behaviour could make sense? Honestly I am more than a little confused by the different options, but I can confirm that searching for something containing / won't work right now, which is a problem. For example, it will break when someone copies a MARC record for search. Example: Dutch : an essential grammar / William Z. Shetter and Inge Van der Cruysse-Van Antwerpen 3) The system preference doesn't mention that it applies to Elasticsearch only - I think we need to add this information. 4) My sample search: Dutch / William doesn't work with any of the settings. What am I missing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Summary|Option for escaping slashes |Elasticsearch - Option for |in search queries |escaping slashes in search ||queries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #22 from Katrin Fischer --- 4) Editing a note no longer works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- Hi Aleisha, thx for the follow-up! Some notes: 1) I'd like to see "click to view note" changed to just "view note". As the text is formatted as a link, there should be no need to add the additional instruction. 2) When there are multiple lines with notes and you click on one of them, they will just overlay each other, with the first note being behind the second and so on, There seems to be no way to make them disappear again. I think my expectation was that the note would disappear clicking on the next note or just clicking outside the note field again. A longer note can also overlay the buttons, so I think putting some more thought into this would be worthwhile. 3) Tiny: Can you make your patch subject: Bug : (follow-up)? I would have fixed it as part of QA, but then stumbled on 2). (see: https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups) Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #36 from Katrin Fischer ---
Trying to tackle this:
1) QA scripts
Only the second looks valid, as this class is new and added by the patch set:
FAIL Koha/CmsPage.pm
FAIL pod coverage
POD coverage was greater before, try perl
FAIL Koha/CmsPages.pm
FAIL pod coverage
POD is missing for 'object_class'
FAIL Koha/Schema/Result/CmsPage.pm
FAIL pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
Can you please fix?
2) Code review
a) Schema patches would be much better in a separate patch. Ok for now as the
patch still applies. For a rebase separating those change might be good.
b) In opac-cmspages there is:
+flagsrequired => { borrow => 1 },
The borrow permission has been removed since. (blocker)
c) Comment was removed unnecessarily, just needs to be moved into its right
spot below again:
-# If GoogleIndicTransliteration system preference is On Set parameter to load
Google's javascript in OPAC search screens
d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 ); (blocker)
3) Unit tests
... all passing!
4) Feature tests
OPAC
a) I feel we don't need the "Pages" heading. It only takes up space and states
the obvious. (non-blocker... but navigation needs work, see below)
b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use
it to place text on the start page instead of using the news feature, which
means it repeats on all pages. I'd really like to see this changed.
c) Personally I'd change "Location" to "Interface" to avoid confusion with the
item value in translations. But I see it's the same on news. So out of scope
here.
d) Parent pages can be deleted without warning. Childs will be moved to top
level. This is acceptable behaviour as they are not left orphaned. But it might
be something to improve on in the future.
e) In the test plan and in the code I see there should be a confirmation
message on deleting a single or multiple entries, but this doesn't work.
(blocker)
f) Navigation looks strange when working with multiple levels. Repeating the
level before seems unnecessary and only takes up space?
Level 1
Level 1 › Level 2
Level 2 › Level 3
Also, clicking on the different links, sometimes a part of the navigation
disappears. I think this is a little too wonky to pass. Can you take another
look please? (blocker)
Intranet
Where do the pages appear in the intranet?
Generally I think this will be a great and really helpful addition and looking
forward to return to this!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19502] Result sets limited to 10000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer --- I don't have enough data to test this properly, but seems straight forward. Alex, maybe you could have another look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #17 from Katrin Fischer --- What should be the next step here? I am bit lost in the discussion, has consensus be reached or should we move this out of the queue for more discussion? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 --- Comment #6 from Katrin Fischer --- Created attachment 76756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76756=edit Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #16 from Katrin Fischer --- There is no question that this is more modern and prettier looking than before. The new filter functionality is a great addition, as are the "(modified)" labels on prefs changed. I am still a little torn on usability. I have the impression that it takes me a little longer to find things with the new styling. In the old interface the prefs were (ugly) Courier and in one column, so scanning over the page was pretty fast. This might be just a thing of 'being used to the old way'. I'd love another opinion as this is a bigger change and it would be good to get another set of eyes on it. Could be another sign-off or QA opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #15 from Katrin Fischer --- Created attachment 76755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76755=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Katrin Fischer changed: What|Removed |Added Attachment #76664|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 76754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76754=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a , with the preference name as the and the description as the . - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #13 from Katrin Fischer --- Just some small remarks, no blockers: Instead of "Click to edit" and "Click to collapse" I think it should just be "Edit" and "Collapse" as there is no need to extra label a link for clicking. Also... I think the German translation would be horribly long :) Attaching a patch with the suggested change, feel free to disagree! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
