[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #76802|0   |1
is obsolete||

--- Comment #27 from Aleisha Amohia  ---
Created attachment 76803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76803=edit
Bug 12759: [FOLLOW-UP] Using tabs for diff ways of adding records

This patch includes the changes for both batch record modification and
deletion.
Checks that all public lists are included and only private lists created
by the logged in user.
Hides the virtualshelves option if authorities are selected.
Doesn't show shelf option at all if none exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #26 from Aleisha Amohia  ---
Created attachment 76802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76802=edit
Bug 12759: [FOLLOW-UP] Using tabs for diff ways of adding records

This patch includes the changes for both batch record modification and
deletion.
Checks that all public lists are included and only private lists created
by the logged in user.
Hides the virtualshelves option if authorities are selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x)

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #43 from Nightly Build Bot  ---
Created attachment 76801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76801=edit
Bug 17111 - Automatic debian/control updates (oldstable/17.11.x)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

--- Comment #9 from Katrin Fischer  ---
Kyle, you or me for sign-off now? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

--- Comment #17 from Katrin Fischer  ---
Hi Nicolas, thx! 'None' works. 

Is there a bug already about the broken sorting for authorities with
Elasticsearch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #27 from Katrin Fischer  ---
yay!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21055] Add columns to statistics table that can be mapped to patron information by the library

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21055

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add columns to statitics|Add columns to statistics
   |that can be mapped to   |table that can be mapped to
   |patron information by the   |patron information by the
   |library |library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #76800|[tag] [reply] [−]  Private  |Patch
description|Description Kyle M Hall |
   |2018-07-09 18:04:53 UTC We  |
   |are getting reports that|
   |sometimes changing the  |
   |logged in library via   |
   |selectbranchprinter.pl  |
   |sometimes appears to fail   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056

--- Comment #1 from Kyle M Hall  ---
Created attachment 76800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76800=edit
[tag] [reply] [−]  Private Description Kyle M Hall 2018-07-09 18:04:53 UTC We
are getting reports that sometimes changing the logged in library via
selectbranchprinter.pl sometimes appears to fail

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21056] New: Changing the logged in library can fail sporadically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056

Bug ID: 21056
   Summary: Changing the logged in library can fail sporadically
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

We are getting reports that sometimes changing the logged in library via
selectbranchprinter.pl sometimes appears to fail. Flushing the session after
updating the branch appears to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20683] Update German web installer for 18.05

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #3 from Mirko Tietgen  ---
(In reply to Katrin Fischer from comment #2)
> Someone, please?

Will do.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
Bug 21002 depends on bug 20978, which changed state.

Bug 20978 Summary: Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944
Bug 20944 depends on bug 20978, which changed state.

Bug 20978 Summary: Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980
Bug 20980 depends on bug 20978, which changed state.

Bug 20978 Summary: Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED

--- Comment #29 from Martin Renvoize  ---
Awesome to see the code cleanup going on here!

Not backporting to 18.05.x series at the moment as it's an
enhancement/refactoring piece.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997
Bug 20997 depends on bug 20978, which changed state.

Bug 20978 Summary: Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Bug 14825 depends on bug 20978, which changed state.

Bug 20978 Summary: Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21055] New: Add columns to statitics that can be mapped to patron information by the library

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21055

Bug ID: 21055
   Summary: Add columns to statitics that can be mapped to patron
information by the library
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

With the need for better patron privacy it would be nice if the borrowernumber
could be removed from statistics without losing the ability to get meaningful
statistics. We already discussed adding age, patron category and other
information, but it might also be interesting to have 2 or more columsn that
can be mapped to patron data and patron attributes by the library as we can't
tell where classes, departments or other statistically relevant data might be
stored.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #3 from Kyle M Hall  ---
(In reply to Liz Rea from comment #2)
> Is this work in progress or are other solutions to this acceptable.

If you have thoughts or plans I'd love to hear them! As far as I'm aware, we
haven't put pen to paper yet :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #25 from David Gustafsson  ---
bug 18316

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #24 from David Gustafsson  ---
Yes, exactly. :) Waiting for bug_18316 to be merged, and will then refactor and
rebase this patch upon the master with 18316 included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

--- Comment #8 from Kyle M Hall  ---
(In reply to Alex Arnaud from comment #7)
> (In reply to Kyle M Hall from comment #6)
> > Won't this be a breaking change for anyone currently using ILS-DI that
> > doesn't have cardnumber and userid set to the same thing? Would it be better
> > to try cardnumber and fall back to userid, and simply not allow either to be
> > an empty field? That would make it behave like the rest of Koha's login
> > functionality, while minimizing breakages.
> 
> Not sure to understand how it could be broken. For me this patch make sense
> even though i didn't find a bug. We pass a userid to the function, so we
> retrieve the patron with the userid. It is unique, and it has been
> authenticated by checkpw just before.

Never mind me, I am a dummy.

I should have read the patch more closely. I blame mornings ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

--- Comment #16 from Nicolas Legrand  ---
Ther(In reply to Katrin Fischer from comment #15)
> I was doing a 'standard' search in authorities search, without changing any
> settings. What do you mean by none?

there is a sort menu after the input field which can be set to 'Heading A-Z',
'Heading Z-A' or 'None'. I remember Nick once told me it wasn't working well.
Plus there is some 'sort' trouble in your log so I thought about this, but
maybe it is not relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #23 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #21)
> Trying to unravel these Elasticsearch patches gives me a headache. ;)
> 
> What would be your "next steps" - should we drop this patch in favour of
> 20589?
Yes! I'm ok for giving up on this one and working on bug 20589.
> 
> So in order to 'unlock' bug 20589 we'd have to qa bug 18316, correct?

I think since David took part on bug 18316 (boosting feature), he should
provide a new patch on 20589 without boosting (the 2 patch conflicts). 

On 20589, we need: removing deprecated _all + staff/opac options for a field

David, are you ok?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #22 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #21)
> What would be your "next steps" - should we drop this patch in favour of
> 20589? 

If Alex agrees then yes, we should take David's approach

> So in order to 'unlock' bug 20589 we'd have to qa bug 18316, correct?
Yes, please :-) It looks like it had passed QA and was failed by Joubu on RM
review, perhaps he could take a second look now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #76792|0   |1
is obsolete||

--- Comment #26 from Alex Arnaud  ---
Created attachment 76799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76799=edit
Bug 19502: Add POD for max_result_window

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #76791|0   |1
is obsolete||

--- Comment #25 from Alex Arnaud  ---
Created attachment 76798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76798=edit
Bug 19502: Remove debug warn

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

--- Comment #6 from Nick Clemens  ---
Created attachment 76797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76797=edit
Bug 18387: Allow sco-user to access errors templates

To test:
 1 - Enable AuthoSelfCheck prefs
 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources
 3 - Visit the SCO
 4 - Sign in as a patron then click 'finish'
 5 - Say 'yes' to receipt
 6 - Note you are directed to log in
 7 - Apply patch
 8 - Restart all the things
 9 - Repeat 4 & 5
10 - Sucess, receipt prints

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #76788|0   |1
is obsolete||

--- Comment #22 from Alex Arnaud  ---
Created attachment 76794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76794=edit
Bug 19502: Limit pagination to first 1 results when using ES

This patch is to avoid hitting an error page. We should eventually make the
max number returned configurable for ES.

To test:
1 - Have Koha running ES with 10,000+ records
2 - Search for '*'
3 - Click 'Last' to view last page of results
4 - 'Cannot perform search' error
5 - Apply patch
6 - Search again
7 - View 'Last' page
8 - No error, you go to the last of 1
9 - Note the warning above the pagination buttons

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #76789|0   |1
is obsolete||

--- Comment #23 from Alex Arnaud  ---
Created attachment 76795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76795=edit
Bug 19502: (follow-up) Pass parameters to avoid making templates depend on
search engine

https://bugs.koha-community.org/show_bug.cgi?id=19502

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #76790|0   |1
is obsolete||

--- Comment #24 from Alex Arnaud  ---
Created attachment 76796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76796=edit
Bug 19502: Retrieve index.max_result_window from ES

This avoid hardcoding '1' in two different places and allow users to
adjust this setting.

Also, this patch fixes a bug when the search return less than 1
results

Test plan:
1. Do a search that returns 1+ records.
2. Note the warning above the pagination buttons
3. Go to the last page, no error
4. Change the ES setting:
   curl -XPUT http://elasticsearch/koha_master_biblios/_settings -d \
 '{"index": {"max_result_window": 2}}'
5. Do another search that returns more than 1 but less than 2
6. Note that the warning does not show up
7. Go to the last page, still no error

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732

Nick Clemens  changed:

   What|Removed |Added

 Blocks||21054


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054
[Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 Depends on||16732
   Patch complexity|--- |Trivial patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732
[Bug 16732] Add audio alerts (custom sound notifications) to web based self
checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054

--- Comment #1 from Nick Clemens  ---
Created attachment 76793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76793=edit
Bug 21054: Remove extraneous  tag from sco-main.tt

To test:
1 - Enable sco and setup AutoSelfCheck
2 - Try to use self checkout and print receipt
3 - You shoudl be redirected to the login page
4 - Apply patch and restart all the things
5 - Try to use self checkout and print a receipt
6 - Success!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21054] New: Extra closing body tag in sco-main.tt prevents slip printing

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054

Bug ID: 21054
   Summary: Extra closing body tag in sco-main.tt prevents slip
printing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 16732 added an extra closing body tag to sco-main.tt 

Bug 18387 notes that page errors kick the SCO user out.

The extra body tag creates an html error and prevents receipt printing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

--- Comment #7 from Alex Arnaud  ---
(In reply to Kyle M Hall from comment #6)
> Won't this be a breaking change for anyone currently using ILS-DI that
> doesn't have cardnumber and userid set to the same thing? Would it be better
> to try cardnumber and fall back to userid, and simply not allow either to be
> an empty field? That would make it behave like the rest of Koha's login
> functionality, while minimizing breakages.

Not sure to understand how it could be broken. For me this patch make sense
even though i didn't find a bug. We pass a userid to the function, so we
retrieve the patron with the userid. It is unique, and it has been
authenticated by checkpw just before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19688] OpacHiddenItems itype problems

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19688

DEVINIM  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #14 from Jon Knight  ---
Do we need to keep a copy of the template in use during the consent in the
database along with the borrower ID and date?  The UK ICO page on consenting
seems to say we do:

https://ico.org.uk/for-organisations/guide-to-the-general-data-protection-regulation-gdpr/consent/how-should-we-obtain-record-and-manage-consent/

(second example).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

--- Comment #9 from Fridolin SOMERS  ---
(In reply to Nick Clemens from comment #8)
> Can we attempt to deal with the discharges that may have been created and
> cannot be removed by staff? Can you provide an update statement Frido?

Seems hard, I'd say just add a warning text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #10)
> (In reply to Fridolin SOMERS from comment #9)
> > Patch "Compiled CSS" does not apply on 17.11.x.
> 
> You should only apply the first one then regenerate the .css
> 
> > Sorry I have never used this compilation.
> 
> There is a wiki page, search for "lessc"
> 
> > Must I run it or do we not back-port such patches ?
> 
> You are the Rmaint ;)
> IMO it's "just" a loading icon, not really important.

Ok thanks a lot.

I prefer to skip this time since its minor.
Not pushed to 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #18 from Nick Clemens  ---
Created attachment 76789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76789=edit
Bug 19502: (follow-up) Pass parameters to avoid making templates depend on
search engine

https://bugs.koha-community.org/show_bug.cgi?id=19502

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #20 from Nick Clemens  ---
Created attachment 76791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76791=edit
Bug 19502: Remove debug warn

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #21 from Nick Clemens  ---
Created attachment 76792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76792=edit
Bug 19502: Add POD for max_result_window

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #19 from Nick Clemens  ---
Created attachment 76790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76790=edit
Bug 19502: Retrieve index.max_result_window from ES

This avoid hardcoding '1' in two different places and allow users to
adjust this setting.

Also, this patch fixes a bug when the search return less than 1
results

Test plan:
1. Do a search that returns 1+ records.
2. Note the warning above the pagination buttons
3. Go to the last page, no error
4. Change the ES setting:
   curl -XPUT http://elasticsearch/koha_master_biblios/_settings -d \
 '{"index": {"max_result_window": 2}}'
5. Do another search that returns more than 1 but less than 2
6. Note that the warning does not show up
7. Go to the last page, still no error

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Nick Clemens  changed:

   What|Removed |Added

  Attachment #73024|0   |1
is obsolete||
  Attachment #74587|0   |1
is obsolete||
  Attachment #75816|0   |1
is obsolete||
  Attachment #76371|0   |1
is obsolete||
  Attachment #76372|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 76788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76788=edit
Bug 19502: Limit pagination to first 1 results when using ES

This patch is to avoid hitting an error page. We should eventually make the
max number returned configurable for ES.

To test:
1 - Have Koha running ES with 10,000+ records
2 - Search for '*'
3 - Click 'Last' to view last page of results
4 - 'Cannot perform search' error
5 - Apply patch
6 - Search again
7 - View 'Last' page
8 - No error, you go to the last of 1
9 - Note the warning above the pagination buttons

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

--- Comment #15 from Katrin Fischer  ---
I was doing a 'standard' search in authorities search, without changing any
settings. What do you mean by none?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75015|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 76787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76787=edit
Bug 19383: Add ability to print hold receipts automatically

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #76787|application/mbox|text/plain
  mime type||
  Attachment #76787|0   |1
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383

--- Comment #4 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #3)
> Just noticed, there is a typo in the author line:
> Kyle M Hall 
> watet instead of water

Thanks for the catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Won't this be a breaking change for anyone currently using ILS-DI that doesn't
have cardnumber and userid set to the same thing? Would it be better to try
cardnumber and fall back to userid, and simply not allow either to be an empty
field? That would make it behave like the rest of Koha's login functionality,
while minimizing breakages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

--- Comment #14 from Nicolas Legrand  ---
Have you tried sort 'None' ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

--- Comment #6 from Ian Bays  ---
The commit error was on the same system at the same version with the commit
line described earlier. If it helps the stage command used was:

/usr/share/koha/bin/stage_file.pl --file Results/ncol_bib.mrc --match 1
--add-items --item-action always_add --no-replace

where match 1 is match on ISBN and aggressive ISBN matching is turned on.

PERL5LIB is:

echo $PERL5LIB
/usr/share/koha/lib

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21053] New: editing 008 field with a hash overwrites data

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053

Bug ID: 21053
   Summary: editing 008 field with a hash overwrites data
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bernard.sca...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 76786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76786=edit
008 screenshots

Entering a hash (#) at any position in 008 field of a bib record causes all
subsequent data in field to be overwritten with default values when record is
saved.

To reproduce:
1. Find and edit a bib record which has an 008 which differs from the default
values for the MARC framework
2. Choose 008 helper
3. Add # in any position before the end of the field noting the current values
of the data
4. Save record
5. Edit record and select 008 helper
6. Review characters after # and note changes

See attached example screenshots

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

--- Comment #5 from Ian Bays  ---
For the bulkmarcimport error:

install is a "standard install" at version 17.11.04.000

Command line used:

~/kohaclone/misc/migration_tools/bulkmarcimport.pl -file Results/$x.mrc -v >
Logs/$x.txt

Repeating error is:

ERROR: Adding items to bib 4026 failed: Undefined subroutine
::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line
379,  line 4026.

Koha About information:

Koha version:   17.11.04.000
OS version ('uname -a'):Linux ncol.dh.bytemark.co.uk 4.9.0-6-amd64 #1
SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64
Perl interpreter:   /usr/bin/perl
Perl version:   5.024001
Perl @INC:  /usr/share/koha/lib
/etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1
/usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24
/usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24
/usr/share/perl/5.24
/usr/local/lib/site_perl
/usr/lib/x86_64-linux-gnu/perl-base
MySQL version:  mysql Ver 15.1 Distrib 10.1.26-MariaDB, for debian-linux-gnu
(x86_64) using readline 5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #20 from Fridolin SOMERS  ---
Depends on Bug 20234 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #19 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #21 from Katrin Fischer  ---
Trying to unravel these Elasticsearch patches gives me a headache. ;)

What would be your "next steps" - should we drop this patch in favour of 20589? 

So in order to 'unlock' bug 20589 we'd have to qa bug 18316, correct?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #16 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #12)
> I don't have enough data to test this properly, but seems straight forward.
> Alex,  maybe you could have another look?

If you want, here is a tiny script to generate thousands of new biblio:
https://nopaste.xyz/?6a713982d73e1ab2#44I4RKe2ynghhda8Gp48a9f3bQSXjWbPUoeawx1Npqc=
(You may want to change the title field for MARC21)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #15 from Julian Maurice  ---
I wished Nick would review my patch to be sure that it doesn't go against his
first patches. But I think this should not prevent the QA to be done. He can
review the patches while pushing them ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #20 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #19)
> > If i understand correctly, storing the entire record in all_fields_* would
> > help us to hide some fields like nonpublicnote (Nick, another advantage?) by
> > creating all_fields and all_fields_opac. But this could be done with a
> > staff/opac parameter on ES configuration form like David did in bug 20589. 
> > 
> > I wrote this patch in order to make Koha compliant with ES 6. But if we
> > remove this "feature", it is the same result. And the job is also done in
> > bug 20589.
> 
> Which job does 20589? Resolving the ES6 issue?

Removing deprecated _all

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #13 from Marcel de Rooy  ---
Trivial rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75820|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 76785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76785=edit
Bug 20819: Add consent to self-registration process

We add a section for the GDPR consent in opac-memberentry (only for the
self-registration). Not when editing personal details.

Test plan:
[1] Enable selfregistration (with confirm) and GDPR policy.
[2] Register a new account in OPAC. Verify that the GDPR checkbox is
required.
[3] After you submit, you should see a date in borrower_modifications
field gdpr_proc_consent.
[4] When you confirm, verify that the consent is visible on your consents.
[5] Enable selfregistration without confirmation mail. Register again.
[6] Check your consents tab again.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75818|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 76783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76783=edit
Bug 20819: Add your consents tab to opac-user

This patch adds a consents tab to the OPAC user account menu. We now
add a GDPR section here, but it is open for future extensions. Think of
a newsletter checkbox for instance.

Script opac-patron-consent handles the tab. And now only includes some
GDPR code but is also written for more general use too.

Test plan:
[1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual.
[2] Set pref to Permissive. Try to save a consent or a refusal. Note that
you are not logged out when saving a refusal.
[3] Set pref to Enforced. Save a refusal. You should be logged out.
Log in again and verify that the consents tab shows a No.
Note: a follow-up patch will add further enforcements.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75766|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 76781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76781=edit
Bug 20819: DBIx schema changes

No test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75767|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 76782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76782=edit
Bug 20819: Add Koha object classes for patron consents

Introduces Koha::Patron::Consent[s] for new table.
Adds basic CRUD test.

Test plan:
Run t/db_dependent/Koha/Patron/Consents.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75819|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 76784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76784=edit
Bug 20819: Add check in get_template_and_user to enforce GDPR

If you choose to enforce GDPR policy, a user needs to give consent for
data processing before he does something else in the OPAC while being
logged in.

Test plan:
[1] Set GDPR_Policy to Disabled or Permissive. Usual behavior.
[2] Set to Enforced. Save a refusal on your consents. Notice that
you are logged out when saving. When you login again, all OPAC
requests are redirected to your consents tab.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #19 from Katrin Fischer  ---

> If i understand correctly, storing the entire record in all_fields_* would
> help us to hide some fields like nonpublicnote (Nick, another advantage?) by
> creating all_fields and all_fields_opac. But this could be done with a
> staff/opac parameter on ES configuration form like David did in bug 20589. 
> 
> I wrote this patch in order to make Koha compliant with ES 6. But if we
> remove this "feature", it is the same result. And the job is also done in
> bug 20589.

Which job does 20589? Resolving the ES6 issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #18 from Fridolin SOMERS  ---
(In reply to Mason James from comment #17)
> (In reply to Tomás Cohen Arazi from comment #13)
> > Added the 17.11 RMaint because the original patches got backported.
> 
> Frido, just confirming this bug exists in 17.11.07
> 
> the patch fixes the bug :)

Ohhh thanks for this, I will backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Katrin Fischer  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #14 from Katrin Fischer  ---
(In reply to Alex Arnaud from comment #13)
> (In reply to Katrin Fischer from comment #12)
> > I don't have enough data to test this properly, but seems straight forward.
> > Alex,  maybe you could have another look?
> 
> I already had many looks. I'd like Nick to valid/sign Julian's patches and i
> could pass QA.

Sounds like a plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #76763|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 76780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76780=edit
Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files

SQL files in installer/data/mysql/ create frameworks with a koha to MARC
mapping on obsolete table bibliosubtitle.
This table was removed when upgrading from Koha 2.2 to 3.0.

Test plan :
1) Create a new install with web installer
2) Check that creating a record is OK

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

--- Comment #5 from Katrin Fischer  ---
Ah, I think I've misread the test plan then! userid makes sense and can't be
empty. Sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #76690|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 76779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76779=edit
Bug 8604: Patron cards made for patrons which don't have patron images use
preceding card's image

This patch corrects referential problems which caused the script to
"re-use" images as well as other sorts of bad image behaviour.

To test:

1. Ensure that you can reproduce the original bug or some variation thereof
using the steps described in either of these two comments:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c0

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c6

NOTE: This is not an easy bug to reproduce.

2. Once you can reproduce the bug, apply this patch and follow the same steps
used to reproduce the bug.

3. Observe that the symptoms are corrected.

Signed-off-by: Chris Nighswonger 
Signed-off-by: Christian Stelzenmüller 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

--- Comment #18 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #17)
> What should be the next step here? I am bit lost in the discussion, has
> consensus be reached or should we move this out of the queue for more
> discussion?

If i understand correctly, storing the entire record in all_fields_* would help
us to hide some fields like nonpublicnote (Nick, another advantage?) by
creating all_fields and all_fields_opac. But this could be done with a
staff/opac parameter on ES configuration form like David did in bug 20589. 

I wrote this patch in order to make Koha compliant with ES 6. But if we remove
this "feature", it is the same result. And the job is also done in bug 20589.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21052] New: New patron card printer profile won't save if paper bin is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052

Bug ID: 21052
   Summary: New patron card printer profile won't save if paper
bin is empty
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When adding a new printer profile in the patron card creator tool, you can save
without entering a paper bin, but it will not create a new entry in the
database. There is no error, the field is not marked as required.

To test:
- Add a new printer profile
- Fill in description, leave other fields unchanged
- Save
- Verify that the new printer profile doesn't appear in the list and hasn't
been created

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |cnighswon...@foundations.ed
   ||u
  Component|Templates   |Label/patron card printing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19502] Result sets limited to 10000

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #13 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #12)
> I don't have enough data to test this properly, but seems straight forward.
> Alex,  maybe you could have another look?

I already had many looks. I'd like Nick to valid/sign Julian's patches and i
could pass QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

--- Comment #4 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #2)
> I am not sure we should allow returning of a borrowernumber for an empty
> cardnumber. This could lead to all kinds of problems. I feel we should
> return an error for an empty cardnumber.
It's quite common to have borrowers without cradnumber. Mostly when using third
party import tools. So this leads to have dangerous behavior on portals that
use Koha as back-end. Some patron get the loans, reserves and all information
about an other one.

> 
> What if 2 patrons pick the same password or are imported with the same
> default password?

Duplicate password doesn't matter here because we retrieve patrons with their
userid (which is unique).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #76652|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 76778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76778=edit
Bug 21033: Remove few warns in acqui/basket.pl

Resolve (line numbers based on 16.11.x):
Use of uninitialized value in hash element at acqui/basket.pl line 337.
Use of uninitialized value in hash element at acqui/basket.pl line 338.
Use of uninitialized value in hash element at acqui/basket.pl line 340.
Use of uninitialized value in hash element at acqui/basket.pl line 342.
Use of uninitialized value in hash element at acqui/basket.pl line 344.

Argument "" isn't numeric in multiplication (*) at
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486.
Argument "" isn't numeric in multiplication (*) at
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591.

Test plan:
If you have older acq data, you may have records in aqorders with field
tax_rate_on_ordering is NULL. These orders will trigger the above warns.
If you do not have, you could simulate by setting this field to NULL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033

--- Comment #3 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #2)
> Hi Marcel,
> 
> I've tried testing this, but can't reproduce the errors. What exactly do you
> mean by:
> 
> Open a basket that contains no prices.
> 
> ?
> 
> I've tried closing and reopening a basket with one order line where I left
> all entries empty, but that didn't do it. Closing an empty basket is not
> possible, so I am a little lost here.

Thanks for testing! Hmm. I couldn't reproduce on master too. A closer look
reveals that older production data has NULL values in fields like
tax_rate_on_ordering whereas you cannot create these NULL values anymore on a
new record.
I can imagine that other people might have some older acq data too and see the
same warnings? In this case a dbrev replacing NULL by 0 would do the job too,
but changing these two lines does not hurt?
Will adjust the commit message to reflect these findings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #17 from Mason James  ---
(In reply to Tomás Cohen Arazi from comment #13)
> Added the 17.11 RMaint because the original patches got backported.

Frido, just confirming this bug exists in 17.11.07

the patch fixes the bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Mason James  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/