[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #23 from Fridolin SOMERS --- Code in pay.pl has changed a lot with Bug 10021 that is not in 17.11.x. I'm really not sure how to rebase. Can you provide rebased patches ? Maybe squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Fridolin SOMERS changed: What|Removed |Added Blocks||21020 Depends on|21020 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 [Bug 21020] Return branch not set for transfer when using SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Depends on||17680 Blocks|17680 | --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Fridolin SOMERS changed: What|Removed |Added Status|VERIFIED|RESOLVED Resolution|REMIND |FIXED --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08. The db update can be run even if already applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #10 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #8) > Maybe we should consider backporting this or at least fixing kohastructure > in the other branches. We ran into the problem updating an instance to 17.11 > today. Same for us, we have patched our 17.11 with this for our upgrades. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #6 from Katrin Fischer --- For the screenshot the pref was set to location|itype|ccode. If location is removed, the number of checkouts shows as 2 (which is correct). Note: in the screenshot, the shelving location is also not shown? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #5 from Katrin Fischer --- Created attachment 76875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76875&action=edit current checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #4 from Katrin Fischer --- Created attachment 76874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76874&action=edit statistics tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #3 from Katrin Fischer --- I retested it on master... not quite the same result as last time, but still something strange going on here. Hope the test plan works for you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #2 from Katrin Fischer --- - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 --- Comment #2 from Katrin Fischer --- We've also managed to create a template that takes up 100% CPU and brings down Koha when trying to print a PDF. But so far have not been able to figure out how to reproduce it on another system. There are some serious issues with the forms not checking for good input. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Screenshots? Which values are different? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Same for other labels/* forms In the logs: Database returned the following error on attempted INSERT: Duplicate entry 'DEFAULT PRINTER-0-Tray 1-Labels' for key 'printername' at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 164. or profile_id is currently undefined. at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 184. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 --- Comment #1 from Jonathan Druart --- Created attachment 76873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76873&action=edit Bug 21053: Encode URI characters in plugin 008 A # (or &) at any position in 008 field of a bib record causes all subsequent data in field to be overwritten with default values when record is saved. These characters need to be correctly encoded before being passed as parameters of the url To reproduce: 1. Find and edit a bib record which has an 008 which differs from the default values for the MARC framework 2. Choose 008 helper 3. Add # in any position before the end of the field noting the current values of the data 4. Save record 5. Edit record and select 008 helper 6. Review characters after # -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- What is the value of SessionStorage? >From CGI::Session: """ Always explicitly calling flush() on the session before the program exits is recommended. For extra safety, call it immediately after every important session update. """ Maybe we should add this line below (there is another ->param call later). It sounds like we should put some flush call to C4::Auth as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21051] CGI::param called in list context when editing a patron card layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||16154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 [Bug 16154] Replace CGI->param with CGI->multi_param in list context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Jonathan Druart changed: What|Removed |Added Blocks||21051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 [Bug 21051] CGI::param called in list context when editing a patron card layout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What|Removed |Added Version|17.11 |master Severity|trivial |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- I only have recreated the first issue (and find another one when editing a suggestion). The tab displayed ok for me. Which exact version of Koha are you using? On master I see the tabs which have status with suggestions. Emtpy tabs are not displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #4 from Jonathan Druart --- Created attachment 76872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76872&action=edit Bug 21048: Fix display of suggestion's status (SUGGEST_STATUS) When a suggestion's status is set to a customized value (AV SUGGEST_STATUS), the description is not always displayed correctly. Test plan: - Create different values for the AV SUGGEST_STATUS - Create several suggestions - Change the status using the SUGGEST_STATUS values - Edit the suggestion and change again the status - View the suggestions for a given patron (members/purchase-suggestions.pl?borrowernumber=XX), the statuses must displayed correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15439] Current Location incorrect when item in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20210] Claimed Return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20210 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Seems ok here - https://screenshots.firefox.com/3CmAOf29z2fHLjzR/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- All seems to work as expected and seems to make sense. I look the liberty of re-basing it against master whilst signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #75946|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70213|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 76867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76867&action=edit Bug 18639 - Add replacementprice field to aqorders Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70215|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 76869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76869&action=edit Bug 18639 - Add replacementprice field to acquisitions workflow To test: 0 - Apply patches and updatedatabase 1 - Add an order to a basket 2 - You should note new 'Retail price field' 3 - You should have a separate 'Replacement price' field 4 - Enter values and ensure they are saved as expected 5 - In the basket you should see the replacement price 6 - Modify order and ensure value is loaded and saved correctly 7 - Add and cancle an order and esure replacement price shows/saves 8 - Close basket 9 - Receive an order 10 - You should be able to edit replacement price 11 - 'retail price' field is not editable 12 - Check associated item, replacement price in item should be updated 13 - Cancel receipt, check item. receive again with new replacement price, check item 14 - Price should be correctly updated 15 - Finish receipt, value should show in table 16 - Test with receive from file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70216|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 76870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76870&action=edit Bug 18639 - Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #13 from Martin Renvoize --- Created attachment 76871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76871&action=edit Bug 18639 Use replacementprice when creating order from quote Updates column name from rrp -> replacementprice when creating order from EDI QUOTE message Also ensure other rrp_tax* fields populated Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70214|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 76868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76868&action=edit Bug 18639 - Schema updates (DO NOT PUSH) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376
Jonathan Druart changed:
What|Removed |Added
Attachment #76559|0 |1
is obsolete||
--- Comment #44 from Jonathan Druart
---
Created attachment 76866
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76866&action=edit
Bug 7376 Transfer limits should be checked at check-in
Test case:
* UseBranchTransferLimits must be set
* define your branch transfer limit. Refuse transfers from libraryA to libraryB
* checkout a book owned by libraryB, from libraryB, with a librarian located at
libraryB
* move the librarian to libraryA ("Set Library" link top/right)
* check-in the book => it's possible whatever your setup
After the patch, the behaviour respect the branch transfer limit parameter: you
can check-in if you accept transfers, you can't if you refuse them.
(Note: IndependantBranches must be OFF, otherwise it's not possible to do the
checkin whatever the branch transfer limits)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||martin.renvoize@ptfs-europe ||.com --- Comment #57 from Martin Renvoize --- Sorry guys, can't get this set to apply right now: Applying: Bug 18736: (follow-up) Undo changes to GetLateOrders error: sha1 information is lacking or useless (C4/Acquisition.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Martin Renvoize --- Sorry Nick, although I don't like the way this is done I would Pass QA on it as there's already precedent and we can refactor it once there's been discussion on bug 11983. Failing QA for because there's a fair number of issues reported by the QA script instead: OK Koha/Patrons.pm FAIL misc/cronjobs/update_patrons_category.pl FAIL critic "$min_dob" is declared but not used at line 157, column 1. Unused variables clutter code and make it harder to read. "$au" is declared but not used at line 155, column 1. Unused variables clutter code and make it harder to read. "$max_dob" is declared but not used at line 158, column 1. Unused variables clutter code and make it harder to read. "$ao" is declared but not used at line 156, column 1. Unused variables clutter code and make it harder to read. FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 189) FAIL valid Global symbol "$ageunder" requires explicit package name (did you forget to declare "my $ageunder"?) Global symbol "$ageover" requires explicit package name (did you forget to declare "my $ageover"?) misc/cronjobs/update_patrons_category.pl had compilation errors. OK t/db_dependent/Patrons.t Processing additional checks * Commit title does not start with 'Bug X: ' - a25919ad28 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #43 from Martin Renvoize --- (In reply to Martin Renvoize from comment #42) > Compile time warnings when running the QA script on this I'm afraid.. Looks > like $borrower is returned in the patch but it's not part of the method > signature anymore. Needs more digging.. borrower is indeed defined later in the method but it's not defined before it's called here.. failing qa until that's fixed :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #42 from Martin Renvoize --- Compile time warnings when running the QA script on this I'm afraid.. Looks like $borrower is returned in the patch but it's not part of the method signature anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 --- Comment #20 from emj...@pa.net --- (In reply to Mike from comment #12) > It is not depend on number of codes, but time that Koha consume to process > them. Think that this is problem with websere timeout time. If it is set on > 600 s (default), problem can be relevant for about 500 - 1000 barcodes. So, > we need solve it by universal way = make Inventory tool improvements that > make processing of barcodes on background, similar like import staging. > Webserver will not wait for it and timeouts will gone. "Small" change can > make Inventory tool really usefu(In reply to Mike from comment #12) > It is not depend on number of codes, but time that Koha consume to process > them. Think that this is problem with websere timeout time. If it is set on > 600 s (default), problem can be relevant for about 500 - 1000 barcodes. So, > we need solve it by universal way = make Inventory tool improvements that > make processing of barcodes on background, similar like import staging. > Webserver will not wait for it and timeouts will gone. "Small" change can > make Inventory tool really usefull. So is this still a problem in Koha 17.11.06? I don't want to take the time to scan thousands of items just to have it not work (again.) I believe I was using 17.05 the last time it did not work. What do we need to do to get the results from the inventory process? Not having this ability really limits the usefulness of Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Jonathan Druart changed: What|Removed |Added Blocks||21039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 [Bug 21039] auth_show_hidden_data.pl should also check if the subfield is ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21039] auth_show_hidden_data.pl should also check if the subfield is ignored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||18811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 Jonathan Druart changed: What|Removed |Added Depends on||18811 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Jonathan Druart changed: What|Removed |Added Blocks||21037 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion --- Comment #9 from Jonathan Druart --- I prefer the second approach even if more verbose. It's easier to read and to test. It will certainly be easier to maintain and less error prone. Few remarks: - The having could be replaced with a join, and so more efficient. - filter_by_last_issued sounds wrong. I agree we should have a pattern (here "filter_by_") to explicitly tell what we are doing, but it should also be meaningful. Maybe it is for native English speakers ;) - filter_by_has_issues($options) is not enough explicit IMO. Moreover $options is a boolean, and "issue" must be "checkout". I would suggest: $patrons->filter_by_has_pending_checkouts and another one (?) But maybe I am making things more complicated here. (note: it seems that this subroutine will not be used by cleanborrowers.pl, we do not have this use case) - Should not filter_by_has_issues be filter_by_have_issues? - filter_by_when_expired - the interface allows to filter by "expired before", now we provide a "and/or expire after", but it is not used. It means more code, more tests and so... more potential bugs. It is not a big deal for this one, but we could have filter_by_expired_before that will be easier to read/write/test. Not blocker but worth mentioning/discussing it I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21062] New: Clean up borrower_password_recovery when patron is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21062 Bug ID: 21062 Summary: Clean up borrower_password_recovery when patron is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When a patron is deleted, any entries in borrower_password_recovery should be deleted as well by cascade. CREATE TABLE `borrower_password_recovery` ( `borrowernumber` int(11) NOT NULL, `uuid` varchar(128) COLLATE utf8_unicode_ci NOT NULL, `valid_until` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, PRIMARY KEY (`borrowernumber`), KEY `borrowernumber` (`borrowernumber`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21061] New: Clean up expired password recovery requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21061 Bug ID: 21061 Summary: Clean up expired password recovery requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org >From reading the code it looks like entries to borrower_password_recovery are only cleaned up when an expired verification link is clicked or a password is reset successfully. It would be nice to have an option in cleanup_database to regularly clean up the table by deleting requests expired more than x days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21060] New: Article requests: Null borrowernumber when borrower is deleted and keep request data for statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21060 Bug ID: 21060 Summary: Article requests: Null borrowernumber when borrower is deleted and keep request data for statistics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When a patron is deleted the article requests will also be deleted. This can leave holes in statistics. It would be nicer to cancel them and null the borrowernumber instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > Solution is identical in detail. > I saw output_and_exit_if_error somewhere recently and was not really > impressed. Identical but much more changes are needed. See this counter-patch (to apply on top of bug 20661) and you will get why it's better ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 --- Comment #7 from Jonathan Druart --- Created attachment 76865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76865&action=edit [COUNTER-PATCH] Bug 20927: Shortcut moredetail.pl on nonexistent biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21059] New: callback function in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21059 Bug ID: 21059 Summary: callback function in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: k...@bywatersolutions.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Work to be done: Add the ability to define a callback function when adding an item to an order Define a callback function in intranetuserjs/OPACuserjs to remove items from the cart upon placing an order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #8 from Kyle M Hall --- (In reply to Katrin Fischer from comment #7) > Kyle, would you be ok to make this dependent on some patches in PQA when > rebasing? > > bug 11911 - new permission for managing suggestions > bug 7651 - new permission for managing currencies > > Both are adding new permissions. I am keen on resolving as many permission > bugs as possible this release and would be happy to help with this one to > have a better foundation. I'm a bit late replying, but yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Martin Renvoize changed: What|Removed |Added Status|RESOLVED|VERIFIED Resolution|FIXED |REMIND -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Martin Renvoize changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Keywords||rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #9 from Katrin Fischer --- Also it came up on the mailing list a few times now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Maybe we should consider backporting this or at least fixing kohastructure in the other branches. We ran into the problem updating an instance to 17.11 today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #10 from Fridolin SOMERS --- Depends on Bug 17893 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20979] Error message when deleting bib attached to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Bug 20979 depends on bug 20977, which changed state. Bug 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #9 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #6) > Depends on Bug 17893 not in 17.11.x A my mistake, Bug 17893 is in 17.11.x. Patch pushed to 17.11.x for v17.11.08. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens changed: What|Removed |Added Attachment #66897|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 76864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76864&action=edit Bug 19263: Rancor - Add auto-001 widget To test: 1 - Define a new authorised valued category "CONTROL_NUM_SEQUENCE" 2 - Add a value/sequence The authorised_value is the starting value - shoudl end in a number that can be incremented e.g. "control_sequence_001" The description field is the name for the seqeuence Opac description is unused 3 - Edit a record in rancor 4 - Note the new widget and option to increment or assign manually -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #7 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Important note: We certainly need to add an index on this column to boost
> > this query.
>
> Do you mean items.uri and deleteditems.uri?
only items.uri, but with the last patch it's not needed.
(In reply to Marcel de Rooy from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Important note: We certainly need to add an index on this column to boost
> > this query.
>
> Koha::Items->search( { uri => $uri } )->count
>
> You need to add biblionumber to limit the results. No need to scan the whole
> table.
Oops, yes you are right. It's itemnumber actually.
Maybe we should add more tests here, items.uri check should only be if
itemnumber is passed. But I would prefer to not complexity it now as it's
improvement and not bug fixing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #6 from Jonathan Druart --- Created attachment 76863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76863&action=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Jonathan Druart changed: What|Removed |Added Attachment #76090|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 76862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76862&action=edit Bug 20919: Remove unecessary search calls on the biblio detail page There is a countanalytics flag that is set for items used in analytical biblio records. This flag is only used in the template when 'analyze' has been passed to the script. In order to avoid unecessary search calls (1 per item), $analyse must be tested. Test plan: 0. Do not apply the patch 1. tail -f /var/log/koha/kohadev/zebra-output.log 2. Hit a bibliographic record detail page with several items 3. Notice that the log has 1 line per item: 11:30:36-14/06 zebrasrv(32) [warn] ir_session (exception) 4. Apply the patch 5. Hit the page again 6. There is nothing in the zebra log file If you are familiar with analytic records, confirm that you are not allowed to remove an item that is used in analytical biblio records. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #9 from Jonathan Druart --- Created attachment 76861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76861&action=edit Bug 20811: Fix update flag in bulkmarcimport I have no idea why we have these two variables $id and $originalid, it seems that they should not cohabit. It feels like Users and original authors of this script should provide an update and refresh it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED Assignee|pasi.kalli...@joensuu.fi|jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Ok I will provide a patch then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 --- Comment #8 from Fridolin SOMERS --- (In reply to Barton Chittenden from comment #7) > (In reply to Fridolin SOMERS from comment #6) > > Depends on Bug 17893 not in 17.11.x > > This *is* broken in 17.11.x, do we need a separate patch for that? Ok sorry, I will try to rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20979] Error message when deleting bib attached to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Bug 20979 depends on bug 20977, which changed state. Bug 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #8 from Jonathan Druart --- heh yes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21007] Add new patron column for date of last successful login attempt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21007 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #7 from Katrin Fischer --- The ModBiblio call is inside the check for a set update flag... if ($update)... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- > Invalid parameter passed, biblionumber= does not exist This sounds like another bug, I would prefer to discuss it on a separate bug report. Try without the --update flag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19044] Add BDS integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19044 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
