[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77094|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 77097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77097=edit
Bug 21085: Fix add/edit of patrons when HouseboundModule is set

This script takes all the parameters then set it to create/edit the
patron. We must list housebound_chooser and housebound_deliverer as not
part of patron's attributes

Test plan:
- Enable HouseboundModule
- Create a patron
=> When you save, if the patch is not applied, you will get:
No property housebound_deliverer for Koha::Patron

- Edit a patron
=> When you save, if the patch is not applied, you will get:
Patron creation failed! - DBIx::Class::Row::store_column(): No such column
'housebound_chooser' on Koha::Schema::Result::Borrower at
/home/vagrant/kohaclone/Koha/Object.pm line 75

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21088] Load the correct biblio or item-level link from tracklinks.pl

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21088

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21088] Load the correct biblio or item-level link from tracklinks.pl

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21088

Alex Buckley  changed:

   What|Removed |Added

Version|master  |17.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21088] New: Load the correct biblio or item-level link from tracklinks.pl

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21088

Bug ID: 21088
   Summary: Load the correct biblio or item-level link from
tracklinks.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

When the TrackLastPatronActivity and TrackClicks sysprefs are enabled all
biblio and item level links (these are links stored in the 856u or 952u MARC
subfields) on the OPAC are displayed on the template in the format:
/cgi-bin/koha/tracklinks.pl?uri==

i.e. all biblio and item level holds do not link directly to an external site,
but redirect to tracklinks.pl

In tracklinks.pl the links associated with the biblionumber are retrieved by
the call to C4::Biblio->GetMARCUrls.

However only the first url returned in the array form this function is assigned
as the url to load and so if there are multiple links in the 856u or 952u
fields then only the first link is ever loaded. 

As we are handing the url as a cgi parameter to the tracklinks.pl we should
compare each url in the returned url array if it is equal to the url cgi
parameter and choose which url to refirect to accordingly. 

This would mean biblios with multiple online resources would load the correct
external link depending which link was selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

--- Comment #5 from Jonathan Druart  
---
Test plan:
Create patron, edit, change password (staff and opac), use the password
recovery as well as the self registration features.

Everything must behave as usual.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from Jonathan Druart  
---
Late here, I do not know if it's enough. Could someone take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

--- Comment #3 from Jonathan Druart  
---
Created attachment 77096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77096=edit
Bug 21087: Hash passwords in ->update_password

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

--- Comment #2 from Jonathan Druart  
---
Created attachment 77095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77095=edit
Bug 21087: Test to describe the issue

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

--- Comment #1 from Jonathan Druart  
---
Highlighted by Jenkins with t/db_dependent/selenium/authentication.t

#   Failed test 'Patron with flags catalogue should be able to login'
#   at t/db_dependent/selenium/authentication.t line 63.
Wide character in print at /usr/local/share/perl/5.20.2/Test2/Formatter/TAP.pm
line 105.
#   'Koha › Invalid username or password Log in to Koha'
# doesn't match '(?^u:Koha staff client)'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21087] New: Patron's password is hashed twice when the object is saved

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087

Bug ID: 21087
   Summary: Patron's password is hashed twice when the object is
saved
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 20287

When a patron is edited (reading the code at least using patron batch
modification), the password is lost.

Prior to bug 20287 ModMember took the $hash of modification, and '' was a
trick to not update the password (when coming from memberentry).

The same trick has been reused for the move of ModMember to
Koha::Patron->store, but then the following code will modify the password of
the patron:

  my $password = 'password';
  $patron->password($password)->store;  
  $patron->surname('xxx')->store;   

=> User is not longer able to login with 'password'


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
[Bug 20287] Move AddMember and ModMember to Koha::Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21087


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087
[Bug 21087] Patron's password is hashed twice when the object is saved
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21048] suggest_status not behaving properly

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048

--- Comment #17 from Lisette Scheer  ---
(In reply to Katrin Fischer from comment #14)
> Hi Lisette, 
> can you share how you set up your SUGGEST_STATUS values?

The ones on the Valnet system were already set up when I got here. 
On the sandboxes I tested on here are my steps:
Go to Administration
Go to Authorized Values
Select 'SUGGEST_STATUS'
Click the "New Value for SUGGEST_STATUS" button. 
Type in an unique AV (doesn't match any other AV in SUGGEST_STATUS or other
AVs)
Type in a description and OPAC description
Click save. 

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

--- Comment #3 from Jonathan Druart  
---
Created attachment 77094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77094=edit
Bug 21085: Fix add/edit of patrons when HouseboundModule is set

This script takes all the parameters then set it to create/edit the
patron. We must list housebound_chooser and housebound_deliverer as not
part of patron's attributes

Test plan:
- Enable HouseboundModule
- Create a patron
=> When you save, if the patch is not applied, you will get:
No property housebound_deliverer for Koha::Patron

- Edit a patron
=> When you save, if the patch is not applied, you will get:
Patron creation failed! - DBIx::Class::Row::store_column(): No such column
'housebound_chooser' on Koha::Schema::Result::Borrower at
/home/vagrant/kohaclone/Koha/Object.pm line 75

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Depends on||20287
 Status|NEW |ASSIGNED

--- Comment #2 from Jonathan Druart  
---
Caused by bug 20287.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
[Bug 20287] Move AddMember and ModMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21085


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085
[Bug 21085] Can't edit patrons with housebound module active
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
On creating the error is:
Patron creation failed! - DBIx::Class::Row::store_column(): No such column
'housebound_chooser' on Koha::Schema::Result::Borrower at
/home/vagrant/kohaclone/Koha/Object.pm line 75

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21086] Wrong mock of DateTime->now in tests

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086

--- Comment #1 from Jonathan Druart  
---
Created attachment 77093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77093=edit
Bug 21086: Fix wrong mock of DateTime->now

prove t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/DecreaseLoanHighHolds.t .. 1/17 Can't locate object method
 "truncate" via package "80" (perhaps you forgot to load "80"?) at
/home/vagrant/kohaclone/C4/Circulation.pm line 3497.

What is happening:
We mock DateTime->now in the script to avoid the date comparaisons to fail on
slow servers (see bug 19705).

  my $now_value   = DateTime->now();
  my $mocked_datetime = Test::MockModule->new('DateTime');
  $mocked_datetime->mock( 'now', sub { return $now_value; } );

Since bug 20287, we have the following calls:
Koha::Patron->store => Koha::Patron::Category->get_expiry_date

which does:
221 return $date->add( months => $self->enrolmentperiod, end_of_month
=> 'limit' );

as enrolmentperiod is generated by t::lib::TestBuilder, it can be quite big,
and so
the date change from one call to the others.

The failure is actually coming from the date becoming > , which is not
handled correctly,
on purpose, by Koha::DateUtils (infinite)

On the way this patch fixes the other occurrence, in Sitemapper.t (just in
case)

Test plan:
Make sure the tests pass now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21086] Wrong mock of DateTime->now in tests

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21086


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086
[Bug 21086] Wrong mock of DateTime->now in tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21086


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086
[Bug 21086] Wrong mock of DateTime->now in tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21086] New: Wrong mock of DateTime->now in tests

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086

Bug ID: 21086
   Summary: Wrong mock of DateTime->now in tests
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 20287, 19705

prove t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/DecreaseLoanHighHolds.t .. 1/17 Can't locate object method
"truncate" via package "80" (perhaps you forgot to load "80"?) at
/home/vagrant/kohaclone/C4/Circulation.pm line 3497.

What is happening:
We mock DateTime->now in the script to avoid the date comparaisons to fail on
slow servers (see bug 19705).

  my $now_value   = DateTime->now();
  my $mocked_datetime = Test::MockModule->new('DateTime');
  $mocked_datetime->mock( 'now', sub { return $now_value; } );


Since bug 20287, we have the following calls:
Koha::Patron->store => Koha::Patron::Category->get_expiry_date

which does:
221 return $date->add( months => $self->enrolmentperiod, end_of_month
=> 'limit' );

as enrolmentperiod is generated by t::lib::TestBuilder, it can be quite big,
and so the date change from one call to the others.

The failure is actually coming from the date becoming > , which is not
handled correctly, on purpose, by Koha::DateUtils (infinite)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705
[Bug 19705] DecreaseLoanHighHolds.t is still failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
[Bug 20287] Move AddMember and ModMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20779] Style refresh for patron detail page

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #76968|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 77092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77092=edit
Bug 20779: Style refresh for patron detail page

This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.

To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.

- Check that the page looks correct and that sections like "Alternate
  address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.

Signed-off-by: Cab Vinton 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20779] Style refresh for patron detail page

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21085] New: Can't edit patrons with housebound module active

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085

Bug ID: 21085
   Summary: Can't edit patrons with housebound module active
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When the housebound module is activated, trying to save a patron record after
editing it will result in an internal server errror:

No property housebound_deliverer for Koha::Patron

To test:
- Activate housebound, system preference: HouseboundModule
- Edit a patron using the edit button in the toolbar
- Save the patron
- Verify you get an Internal server error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11911] Add separate permission for managing suggestions

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Katrin Fischer  changed:

   What|Removed |Added

Summary|Purchase suggestions can be |Add separate permission for
   |accessed by all staff   |managing suggestions
   |members / no specific   |
   |permission  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21084] Searching for authorities with 'contains' gives no results if search terms include punctuation

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20806] Item type in holds history table should be written as description, not code

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Katrin Fischer  changed:

   What|Removed |Added

Summary|Item type in holds history  |Item type in holds history
   |table should be write as|table should be written as
   |description, not code   |description, not code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21084] New: Searching for authorities with 'contains' gives no results if search terms include punctuation

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Bug ID: 21084
   Summary: Searching for authorities with 'contains' gives no
results if search terms include punctuation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
Depends on: 20273

Try the authority linker plugin dependent bugs applied.

To test:
- Go to catalouging
- Start a new record with the default framework
- Click on the authority linker on 100$a
- Don't change any setting in the form and type "smi" into the first input
field "main heading"
- The auto-complete feature will suggest several Smiths (assuming you are using
the standard sample data, otherwise look for another example with multiple
results)
- Pick one of the Smiths (note: all headings shown include some kind of
punctuation, like a comma between firstname and surname).
- Search for the selected heading.
- Verify there are no search results.
- Remove any punctuation
- Verify the correct record is now found


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273
[Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use
search_auth_compat
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||21084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084
[Bug 21084] Searching for authorities with 'contains' gives no results if
search terms include punctuation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75000|0   |1
is obsolete||
  Attachment #75001|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 77090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77090=edit
Bug 20273: Use compat routines for autocomplete in auth_finder.pl

Test plan:
  - Context: Koha working with elasticsearch,
  - Apply BZ 19582 (that make auth_finder.pl works again),
  - apply this patch,
  - go to cgi-bin/koha/authorities/auth_finder.pl,
  - type at least 3 chararcters in a search field and
check that the autocomplete returns results

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

--- Comment #24 from Katrin Fischer  ---
Created attachment 77091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77091=edit
Bug 20273: (follow-up) Autocomplete use start instead of contains

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20942] Add route to get patron's account balance

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #17 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #39 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21038] Reserves should be holds

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19524] Share patron lists between staff

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #13 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20079] Display stack trace for development installations

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #14 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #9 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #47 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #35 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #20 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #4 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #64 from Katrin Fischer  ---
You can query and output the content of the field without an authorised value.
Did you take a look at the sql library on the wiki? Maybe a topic for a
different  channel, like IRC or mailing list tho :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #63 from emj...@pa.net ---
(In reply to Katrin Fischer from comment #62)
> I understand, just trying to prevent you from doing something that might
> break stuff (because people have gone there before). I can't tell you why
> for Koha 999c was chosen in the beginning, but it's one of the things that
> will need quite a bit of thinking if we wanted to change it now.
> 
> I think here are patches around to make a plugin to set 001 individually. I
> am using a variation of the stocknumberAV plugin in one of our libraries to
> create numbers, but you have to trigger it and it doesn't move the number to
> 035 as they only do original cataloguing. A catalouging plugin might be a
> route to explore.

Katrin -- Thank you so much for responding. I'm a cataloger among
non-catalogers and I am just trying to make things as easy as possible for my
co-workers while following standard guidelines for minimum level cataloging. 

Unless I have a plug-in for the 001 and permit it to be filled in with a click
of the mouse, I will not be able to convince anyone to spend the time on it.
Some of our libraries are completely one-"man" operations.

Koha deviates in several significant ways from the ILS that I am accustom to,
including not having a good way to run reports requesting specific MARC fields.
Am I correct that I can run a report and find out how many records have a
specific MARC field, but the only way to find out the content of the field in a
report is to have the MARC field mapped to an authorized value?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

--- Comment #23 from Katrin Fischer  ---
Thx for testing and sharing your results! Glad that the situation seems to have
improved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #14 from M. Tompsett  ---
Useful documentation link for creating the zip file to test with:
http://manual.koha-community.org/3.2/en/uploadpatronimages.html
https://koha-community.org/manual/18.05/en/html/tools.html?highlight=batch%20patron%20upload#upload-patron-images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #25 from Katrin Fischer  ---
Created attachment 77089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77089=edit
Bug 19604: Unit tests

1 - Apply previous patches
2 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
3 - Should be green
4 - high fives!

Signed-off-by: Nicolas Legrand 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #76977|0   |1
is obsolete||
  Attachment #76978|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 77088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77088=edit
Bug 19604: Elasticsearch Fixes for build_authorities_query for auth searching

To test:
1 - Do some authority searches in Zebra
2 - Switch to ES and repeat, results will vary and some may fail
3 - Apply patch and dependencies
4 - Reindex ES
5 - Repeat searches, they should suceed and results should be similar to
Zebra
6 - Slight differences are okay, but results should (mostly) meet
expectations

A few notes:
We add a 'normalizer' to ensure we get a single token from the heading
indexes, this makes 'starts with' work as expcted
We switch to 'AND' for fields searched from cataloging editor - this
matches Zebra results
We force the '__sort' fields for sorting - if sorting looks wrong try
reducing the heading field to a single subfield - this will need to be
addressed on a future bug (multiple subfields create an array, ES sorts
those randomly)

Signed-off-by: Nicolas Legrand 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #23 from Katrin Fischer  ---
Nick and I found the key:

DELETE from search_marc_to_field; DELETE from search_marc_map; delete from
search_field;
localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1
perl misc/search_tools/rebuildelasticsearch.pl -v -d

I can search authorities now, sorting them as I see fit :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

--- Comment #22 from emj...@pa.net ---
(In reply to Katrin Fischer from comment #21)
>  
> I think noone was able to retest this yet. If you have a test system
> available to you, you could create a report in order to get a long list of
> barcodes and test with that. That could help to verify if the bug still
> exists.

I am using Koha 17.11.06. I ran a test batch through the inventory module. It
had 3747 items in it and it did not time out!

It may be because the results are coming back differently. Instead of getting
results that list each barcode and the fact that the item's status was updated,
only the "problem" items were listed (things that were checked out, missing,
etc.) And it actually used the date that I told it to (which it did one time I
ran an inventory and another time it did not.)

So this may not be a problem any longer. I do not have another library location
that I can run a fake inventory on at this time to see if a larger file would
run successfully. Please do note that we do not have the fastest internet here,
so those with better connections may be able to run larger files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #35 from Kyle M Hall  ---
Created attachment 77087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77087=edit
Bug 18887: Fix issues caused by rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #34 from Kyle M Hall  ---
Created attachment 77086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77086=edit
Bug 18887: (follow-up) Fix null/empty behavior

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #33 from Kyle M Hall  ---
Created attachment 77085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77085=edit
Bug 18887: (follow-up) Fix behavior for default branch/category

Also, fix a couple small QA issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #32 from Kyle M Hall  ---
Created attachment 77084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77084=edit
Bug 18887 - Port max_holds rules to new CirculationRules system

This is the first step in the circulation rules revamp as detailed
in the RFF
https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC

This patch moves the recent max_holds rule to the new circulation_rules table.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Go to the circ rules editor, note the new max holds rules
   by patron category in the "Checkout limit by patron category".
   ( Should we rename this section? )
4) Create find a patron that is allowed to place a hold, count the
   number of holds that patron has. Lets make that number 'X'.
5) Set the new max holds rule to X for "All libraries"
6) Note the patron can no longer place another hold
7) Set the new max holds rule to X + 1 for the patron's home library
8) Note the patron can again place another hold
9) Set the new max holds rule to X for the patron's home library
10) Note the patron can no longer place another hold

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #30 from Kyle M Hall  ---
Created attachment 77082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77082=edit
Bug 18887 - Update existing schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #31 from Kyle M Hall  ---
Created attachment 77083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77083=edit
Bug 18887 - Add Koha::CirculationRule(s)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #29 from Kyle M Hall  ---
Created attachment 77081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77081=edit
Bug 18887 - Add new schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72218|0   |1
is obsolete||
  Attachment #72219|0   |1
is obsolete||
  Attachment #72220|0   |1
is obsolete||
  Attachment #72221|0   |1
is obsolete||
  Attachment #7|0   |1
is obsolete||
  Attachment #72223|0   |1
is obsolete||
  Attachment #72224|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 77080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77080=edit
Bug 18887 - Update database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #22 from Katrin Fischer  ---
Giving this another go... keep fingers crossed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #62 from Katrin Fischer  ---
I understand, just trying to prevent you from doing something that might break
stuff (because people have gone there before). I can't tell you why for Koha
999c was chosen in the beginning, but it's one of the things that will need
quite a bit of thinking if we wanted to change it now.

I think here are patches around to make a plugin to set 001 individually. I am
using a variation of the stocknumberAV plugin in one of our libraries to create
numbers, but you have to trigger it and it doesn't move the number to 035 as
they only do original cataloguing. A catalouging plugin might be a route to
explore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #61 from emj...@pa.net ---
(In reply to Katrin Fischer from comment #60)

> The biblionumber is not a sequentially created number of the application,
> but it's the primary key assigned by the database. That's why it will only
> be set after saving a record for the first time - before it doesn't exist.
> 

I understand the purpose of the biblionumber. It is what MARC says the field
001 is for. I am trying to understand why Koha chose to use the 999$c for this
information instead of the 001, and the implications this decision has on our
library.

Although it is not good cataloging practice, Koha recommends importing a
"close" record if you can not find a matching record in your Z39.50 search.
Then simply alter the record as needed. This has happened at the library where
I work. However, the 001 field was not changed. Often these records were
imported from our state union catalog. Because Koha does not create a unique
001, these records would be for different items but have the same 001, and our
holdings would likely be attached to the wrong record. Thus we could receive
requests for items that we do not, in fact, own.

Thus this matter is not merely academic for us.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

--- Comment #10 from Jonathan Druart  
---
Created attachment 77079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77079=edit
Bug 15836: Add missing svc script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #10 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10198] Add the ability to import and export authorized values

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #109 from Kyle M Hall  ---
Created attachment 77078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77078=edit
Bug 14570: Update schema files [Do Not Push]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #77067|0   |1
is obsolete||
  Attachment #77068|0   |1
is obsolete||
  Attachment #77069|0   |1
is obsolete||
  Attachment #77070|0   |1
is obsolete||
  Attachment #77071|0   |1
is obsolete||
  Attachment #77072|0   |1
is obsolete||
  Attachment #77073|0   |1
is obsolete||
  Attachment #77074|0   |1
is obsolete||
  Attachment #77075|0   |1
is obsolete||
  Attachment #77076|0   |1
is obsolete||

--- Comment #108 from Kyle M Hall  ---
Created attachment 77077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77077=edit
Bug 14570: Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

Signed-off-by: Kim Peine 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

--- Comment #11 from Fridolin SOMERS  ---
(In reply to Martin Renvoize from comment #10)
> I'm not going to backport this to 18.05.x, save surprising users having to
> intervene during package upgrades, especially as the rule change is a
> cosmetic one for server administrators only.

Indeed, server administrators love makeup ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Fridolin SOMERS  ---
(In reply to Katrin Fischer from comment #16)
> (In reply to Fridolin SOMERS from comment #15)
> > Can you confirm this depends on Bug 14826 ?
> 
> Yes, it's a problem since account_offsets was reintroduced.

OK thanks a lot.

Not pushed to 17.05.x then

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||8326


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326
[Bug 8326] Allow patron attributes to be made repeatable after initial creation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20443
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
If bug 20443 is integrated rapidly I will have a look at fixing this bug.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443
[Bug 20443] Move C4::Members::Attributes to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||14826


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Store account offsets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21083

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Store account offsets

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20325


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
[Bug 20325] C4::Accounts::purge_zero_balance_fees does not check
account_offsets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21083] New: Batch patron modification does not allow to modify repeatable patron attributes

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083

Bug ID: 21083
   Summary: Batch patron modification does not allow to modify
repeatable patron attributes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 20443

This has been a limitation of the script since it has been integrated in to
Koha (see bug 12636).
I would like to see bug 20443 pushed and then could work on fixing this one.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443
[Bug 20443] Move C4::Members::Attributes to Koha namespace
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21083


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083
[Bug 21083] Batch patron modification does not allow to modify repeatable
patron attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #107 from Kyle M Hall  ---
Squashed patch for ease of reading the entire change set:
https://github.com/bywatersolutions/bywater-koha-devel/commit/be99e2aa23c3896e9c0aaedf464a5141d676556d

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #106 from Kyle M Hall  ---
Created attachment 77076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77076=edit
Bug 14570: Update schema files [Do Not Push]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #105 from Kyle M Hall  ---
Created attachment 77075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77075=edit
Bug 14570 [QA Followup]: Remove ability to add multiple non-koha patrons as
guarantors, bring back contact fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #104 from Kyle M Hall  ---
Created attachment 77074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77074=edit
Bug 14570 [QA Followup]: change instance of param to multi_param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #103 from Kyle M Hall  ---
Created attachment 77073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77073=edit
Bug 14570 [QA Followup]: Add Koha::Patron::add_gurarantor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #102 from Kyle M Hall  ---
Created attachment 77072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77072=edit
Bug 14570 [QA Followup]: Rename relationships table to borrower_relationships

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #101 from Kyle M Hall  ---
Created attachment 77071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77071=edit
Bug 14570 [QA Followup]: Make delete label clickable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #100 from Kyle M Hall  ---
Created attachment 77070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77070=edit
Bug 14570 [QA Followup]: Fix issue with only one new guarantor being saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #99 from Kyle M Hall  ---
Created attachment 77069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77069=edit
Bug 14570 [QA Followup]: Show add guarantor pane for correct patron types, fix
"Add child" button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #98 from Kyle M Hall  ---
Created attachment 77068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77068=edit
Bug 14570 [QA Followup]: Fix QA issues with POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #77040|0   |1
is obsolete||
  Attachment #77041|0   |1
is obsolete||
  Attachment #77042|0   |1
is obsolete||
  Attachment #77043|0   |1
is obsolete||
  Attachment #77044|0   |1
is obsolete||
  Attachment #77045|0   |1
is obsolete||
  Attachment #77046|0   |1
is obsolete||
  Attachment #77047|0   |1
is obsolete||
  Attachment #77048|0   |1
is obsolete||
  Attachment #77049|0   |1
is obsolete||

--- Comment #97 from Kyle M Hall  ---
Created attachment 77067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77067=edit
Bug 14570: Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

Signed-off-by: Kim Peine 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21079] Unify metadata schema across backends

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20240] Remove space before : when searching for a vendor in serials (Vendor name :)

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20240

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20083] Information disclosure when (mis)using the MARC Preview feature

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20083

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >