[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #4 from Lauski Mori --- (In reply to Jonathan Druart from comment #3) > (In reply to Jonathan Druart from comment #2) > > You should paste here the values of surname and firstname you have set for > > this user. > > And the userid (it is the one displayed on the intranet side actually) Hello, Jonathan Druart! I set the same value for surname and firstname: they were 月 and 月, which were Traditional Chinese Characters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21073] Improve plugin performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #23)
> Just minor (not blocker), reading the code:
>
> 1. In Koha::Account::Line->apply
> +my $offset_type = $params->{offset_type} // 'credit_applied';
>
> Should not we raise an exception if the offset_type is not known?
This method applies a credit to debits. The idea was to make it simple to use,
with documented defaults. There are two use cases in which I'm sure offset_type
will not be 'credit_applied':
- Payments: if we rewrite ->pay using this, then the offset type would be
'payment' to keep the current behaviour.
- Write-offs: if we are writing off a debit, then 'writeoff' should be used.
IThe work collecting the existing hardcoded options is already done so should
be easy. If you consider it a blocker, I'll do it as a follow-up. Otherwise, I
will happily do it on a separate bug.
> I would also list the possible values in the POD (or at list tell it comes
> from
> account_offset_types)
I agree.
> 2. I think we should follow the pattern "Credit Applied", instead of
> switching to snake_case "credit_applied" only for this new one.
Well, I wanted to deal with switching to snake_case all of them on a separate
bug, and I expected Katrin to fail this one for this case issue. I can fix it
as you like if you're QAing it.
> 3. is_debit, is_credit - what about amount == 0?
I only added is_credit he, blame Josef. Seriously, an account line with amount
= 0 only happens when a credit is void. And void credits are not credits as we
handle them. If we need methods for finding void credits specifically we could
add them, but that'd be another bug, when there's a use case for that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Pablo AB changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21109 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Pablo AB changed: What|Removed |Added Depends on||21109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21109 [Bug 21109] oai.pl returns invalid resumptionToken cursor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21109] New: oai.pl returns invalid resumptionToken cursor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21109 Bug ID: 21109 Summary: oai.pl returns invalid resumptionToken cursor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P4 Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org Blocks: 21102 Tested with https://github.com/zimeon/oaipmh-validator and curl -s "baseURL?verb=ListRecords&metadataPrefix=oai_dc" | xmllint --format - | grep resumptionToken ### Checking for correct use of resumptionToken (if used) REQUEST: baseURL?verb=ListRecords&metadataPrefix=oai_dc GET FAIL:A cursor value was supplied with the resumptionToken but it did not have the correct value zero for the first response. The value was '50'. This value is OAI-PMH:MaxCount syspref. _cursor_ indicate the number of previous replies have already delivered: "cursor -- a count of the number of elements of the complete list thus far returned (i.e. cursor starts at 0)." See https://www.openarchives.org/OAI/openarchivesprotocol.html#FlowControl See https://www.openarchives.org/OAI/2.0/guidelines-harvester.htm#resumptionToken Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Pablo AB changed: What|Removed |Added Depends on||21108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21108 [Bug 21108] oai.pl error response did not contain error code 'noRecordsMatch' when it should -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Pablo AB changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21108] New: oai.pl error response did not contain error code 'noRecordsMatch' when it should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21108 Bug ID: 21108 Summary: oai.pl error response did not contain error code 'noRecordsMatch' when it should Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org Blocks: 21102 Tested with https://github.com/zimeon/oaipmh-validator ### Checking for version 2.0 specific exceptions REQUEST: baseURL?verb=ListRecords&metadataPrefix=oai_dc&until=-001 GET FAIL:Error code noRecordsMatch not found in response but should be given to the request: verb=ListRecords&metadataPrefix=oai_dc&until=-001 The request specified a date one year before the earliestDatestamp given in the Identify response. There should therefore not be any records with datestamps on or before this date and a noRecordsMatch error code should be returned. See https://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions and 4.3 ListIdentifiers Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Pablo AB changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21107 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21107] New: oai.pl error response did not contain error code 'badResumptionToken' when it should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21107 Bug ID: 21107 Summary: oai.pl error response did not contain error code 'badResumptionToken' when it should Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org Blocks: 21102 Tested with https://github.com/zimeon/oaipmh-validator REQUEST: baseURL?verb=ListRecords&resumptionToken=junk GET FAIL:Exception/error response did not contain error code 'badResumptionToken' See https://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions and 4.3 ListIdentifiers Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Pablo AB changed: What|Removed |Added Depends on||21107 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21107 [Bug 21107] oai.pl error response did not contain error code 'badResumptionToken' when it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #37 from Jonathan Druart --- Also * The table circulation_rules does not have the current charset collate (see bug 18336) * Copyright lines come from Koha/IssuingRules.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #36 from Jonathan Druart --- Note for QA (does not block signoff): * update DB entry is not idempotent * Last of tests and POD for the new module * merge markers in first patch * This change is odd and need more attention -$max_holds = undef if $max_holds !~ /^\d+/; +$max_holds = '' if $max_holds !~ /^\d+/; Especially because it is different than others. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #20 from Jonathan Druart --- I have removed unnecessary code from the first version and provide a second patch to rename the permission as well as adjust the code. Ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart changed: What|Removed |Added Attachment #72240|0 |1 is obsolete|| Attachment #72241|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 77202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77202&action=edit Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Amended by JD: In a second version of this patch manage_circ_rules_restricted has been replaced by manage_circ_rules_from_any_libraries and 'no_inherit' related code has been removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #19 from Jonathan Druart --- Created attachment 77203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77203&action=edit Bug 15520: Rename permission to manage_circ_rules_from_any_libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #8 from Jonathan Druart --- I have pushed a branch to my gitlab repo to help testing: https://gitlab.com/joubu/Koha/tree/bug_20366 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 --- Comment #15 from Pablo AB --- (In reply to Tomás Cohen Arazi from comment #14) > That said, file independent bugs, marking them as 'Blocks' the umbrella bug. I created some bugs (28 so far) (a) Bug 21104 - oai.pl returns wrong baseURL (b) Bug 21105 - oai.pl returns invalid earliestDatestamp (d) Bug 21106 - oai.pl XML output doesn't validate against OAI-PMH XML schema All blocks 21102 and see also 17785. About (c), I talk with Vangelis Banos and he already fix the Content-Type issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Pablo AB changed: What|Removed |Added Depends on||21106 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21106 [Bug 21106] oai.pl XML output doesn't validate against OAI-PMH XML schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Pablo AB changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21106 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21106] New: oai.pl XML output doesn't validate against OAI-PMH XML schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21106 Bug ID: 21106 Summary: oai.pl XML output doesn't validate against OAI-PMH XML schema Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org Blocks: 21102 When using some verbs Koha return a well formed but in invalid XML. CLI test: wget -q "https://www.openarchives.org/OAI/2.0/OAI-PMH.xsd"; wget -q "https://demo.bibkat.no/cgi-bin/koha/oai.pl?verb=ListSets"; -O test.xml xmllint --noout --schema OAI-PMH.xsd test.xml Web test: An online way to test this is with http://validator.oaipmh.com/ 1. verb=ListSets: When no set is defined Koha incorrectly output . A set (child element of ListSets) should always be there, minOccurs default value is 1. Otherwhise should be: No sets defined, AFAIK even if tehere is no error. 2. verb=Identify: setDescription is not a string, is descriptionType ##other, "defined by a community" (?) See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785#c13 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Pablo AB changed: What|Removed |Added Depends on||21105 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 [Bug 21105] oai.pl returns invalid earliestDatestamp -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Pablo AB changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21105 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21105] New: oai.pl returns invalid earliestDatestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Bug ID: 21105 Summary: oai.pl returns invalid earliestDatestamp Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org Blocks: 21102 From: https://www.openarchives.org/OAI/openarchivesprotocol.html#DatestampsResponses Dates should be -MM-DDThh:mm:ssZ curl -s "baseURL?verb=Identify" | xmllint --format - | grep Date responseDate -> 2018-07-23T18:34:15Z : OK earliestDatestamp -> 2010-09-30 16:04:37 : FAIL Originally deteced with official validator: https://www.openarchives.org/Register/ValidateSite Related: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785#c13 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Pablo AB changed: What|Removed |Added Depends on||21104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21104 [Bug 21104] oai.pl returns wrong baseURL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21104] New: oai.pl returns wrong baseURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21104 Bug ID: 21104 Summary: oai.pl returns wrong baseURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org Blocks: 21102 Related/continuation of: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785#c11 When using Plack Koha anwer a "cooler" (bug 18410) but invalid baseURL, /opac/oai.pl instead of given URI. As Tomas said on bug #17785: > Our fix for the XSLT masked the underlying bug (our code doesn't know > about the proxypass we do, and then Plack answers what he knows, > /opac/oai.pl). Originally deteced with official validator: https://www.openarchives.org/Register/ValidateSite Tested with: curl -s "baseURL?verb=Identify" | xpath -q -e "/OAI-PMH/Identify/baseURL" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Pablo AB changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21104 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997
--- Comment #23 from Jonathan Druart
---
Just minor (not blocker), reading the code:
1. In Koha::Account::Line->apply
+my $offset_type = $params->{offset_type} // 'credit_applied';
Should not we raise an exception if the offset_type is not known?
I would also list the possible values in the POD (or at list tell it comes from
account_offset_types)
2. I think we should follow the pattern "Credit Applied", instead of switching
to snake_case "credit_applied" only for this new one.
3. is_debit, is_credit - what about amount == 0?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #77095|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 77200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77200&action=edit Bug 21087: Test to describe the issue Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #66 from Jonathan Druart --- (In reply to Jonathan Druart from comment #65) > (In reply to Jonathan Druart from comment #64) > > (In reply to Jonathan Druart from comment #63) > > > (In reply to Jonathan Druart from comment #59) > > > > I am stuck here and I need help: > > > > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > > > > wEy2wFB13hxbqq5Yle0= > > > > > > > > I changed .scss file and `yarn build` or `yarn css` does not update .css > > > > files. > > > > > > Retested right now and I do see the expected changes made to > > > koha-tmpl/intranet-tmpl/prog/css/staff-global.css > > > > I would like to retest on top of bug 20427 as well (maybe it came from > > there?), but it does no longer apply. > > Confirmed! The issue still exists for me with bug 20427 applied Fixed since patch on bug 20427 comment 13. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #77096|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 77201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77201&action=edit Bug 21087: Hash passwords in ->update_password Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76654|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 77198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77198&action=edit Bug 20997: ->apply should be applied to Koha::Account::Lines This patch makes ->apply get passed an object set class instead of single account lines. The change is fully covered by tests. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76655|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 77199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77199&action=edit Bug 20997: (follow-up) Minor POD fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76465|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 77196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77196&action=edit Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method Test plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t => Test should pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76549|0 |1 is obsolete|| --- Comment #20 from Tomás Cohen Arazi --- Created attachment 77197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77197&action=edit Bug 20997: Add new offset type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76464|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 77195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77195&action=edit Bug 20997: Add Koha::Account::Line::apply method This patch implements the ->apply() method for account lines. It will only work on credit lines, and raise an exception otherwise. It implements ->is_credit() as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Check all use cases are covered by the tests - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76463|0 |1 is obsolete|| --- Comment #17 from Tomás Cohen Arazi --- Created attachment 77194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77194&action=edit Bug 20997: Add unit tests for Koha::Account::Line::apply This patch adds unit tests for the mentioned method. To test: - Apply this patch - Run: $ khell k$ prove t/db_dependent/Koha/Account/Lines.t => FAIL: The method is not already implemented! Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Owen Leonard changed: What|Removed |Added Attachment #77192|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 77193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77193&action=edit Bug 20427: Convert OPAC LESS to SCSS This patch converts the OPAC LESS files to SCSS. In the process of converting opac.less (and other .less files) to .scss, I have improved the completeness of the nesting, reordered properties, and in general done cleanup based on rules in .scss-lint.yml. All of these changes should have no impact on the style of the OPAC. This patch modifies the commands used to compile CSS so that OPAC and staff assets can be processed separately: 'yarn build' <-- Builds the staff client assets by default 'yarn build --view opac' <-- Builds OPAC assets To test, apply the patch and compile the CSS by running the command above (or apply the follow-up patch with compiled CSS). Do a thorough review of the OPAC, taking care to cover as many pages as possible and checking responsive behavior at the same time. There should be no visual differences in the OPAC before and after applying the patch. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #16 from Jonathan Druart --- CONFLICT (content): Merge conflict in t/db_dependent/Koha/Account/Lines.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2894] Routing list holds are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 --- Comment #8 from Patrick Robitaille --- Hi, are someone is working on this bug? It could be nice to use the systeme preference RoutingListAddReserves so when the users that you add to the circulation list will have automatically a created bookings in the order of adding to the list. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2894] Routing list holds are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20826] Error during initial setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826 --- Comment #9 from Jonathan Druart --- (In reply to sowen from comment #8) > /etc/apt/sources.list Mirko was asking for /etc/apt/sources.list.d/*koha*.list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #65 from Jonathan Druart --- (In reply to Jonathan Druart from comment #64) > (In reply to Jonathan Druart from comment #63) > > (In reply to Jonathan Druart from comment #59) > > > I am stuck here and I need help: > > > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > > > wEy2wFB13hxbqq5Yle0= > > > > > > I changed .scss file and `yarn build` or `yarn css` does not update .css > > > files. > > > > Retested right now and I do see the expected changes made to > > koha-tmpl/intranet-tmpl/prog/css/staff-global.css > > I would like to retest on top of bug 20427 as well (maybe it came from > there?), but it does no longer apply. Confirmed! The issue still exists for me with bug 20427 applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #11 from Jonathan Druart --- The items are displayed at the end of the process (and so can lead to a timeout). Is it expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Owen Leonard changed: What|Removed |Added Attachment #73478|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 77192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77192&action=edit Bug 20427: Convert OPAC LESS to SCSS This patch converts the OPAC LESS files to SCSS. In the process of converting opac.less (and other .less files) to .scss, I have improved the completeness of the nesting, reordered properties, and in general done cleanup based on rules in .scss-lint.yml. All of these changes should have no impact on the style of the OPAC. This patch modifies the commands used to compile CSS so that OPAC and staff assets can be processed separately: 'yarn build' <-- Builds the staff client assets by default 'yarn build --view opac' <-- Builds OPAC assets To test, apply the patch and compile the CSS by running the command above (or apply the follow-up patch with compiled CSS). Do a thorough review of the OPAC, taking care to cover as many pages as possible and checking responsive behavior at the same time. There should be no visual differences in the OPAC before and after applying the patch. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Owen Leonard changed: What|Removed |Added Attachment #73474|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #64 from Jonathan Druart --- (In reply to Jonathan Druart from comment #63) > (In reply to Jonathan Druart from comment #59) > > I am stuck here and I need help: > > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > > wEy2wFB13hxbqq5Yle0= > > > > I changed .scss file and `yarn build` or `yarn css` does not update .css > > files. > > Retested right now and I do see the expected changes made to > koha-tmpl/intranet-tmpl/prog/css/staff-global.css I would like to retest on top of bug 20427 as well (maybe it came from there?), but it does no longer apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #63 from Jonathan Druart --- (In reply to Jonathan Druart from comment #59) > I am stuck here and I need help: > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > wEy2wFB13hxbqq5Yle0= > > I changed .scss file and `yarn build` or `yarn css` does not update .css > files. Retested right now and I do see the expected changes made to koha-tmpl/intranet-tmpl/prog/css/staff-global.css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 --- Comment #10 from Jonathan Druart --- RM: do not forget to regenerate the compiled CSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Jonathan Druart changed: What|Removed |Added Attachment #76603|0 |1 is obsolete|| Attachment #76604|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 77191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77191&action=edit Bug 15287: Use font-awesome on the OPAC This patch replaces Bootstrap's glyphicons with Font Awesome icons. To test, apply the patch and clear your browser cache and regenerate the OPAC CSS from the LESS file if necessary. Check these icons and confirm they look correct: - Cart and Lists icons in the OPAC header - User icon in the header when the browser window is narrow - Languages menu when multiple languages are installed and the OpacLangSelectorMode system preference is "top" or "both top and footer." - Set the SuspendHoldsOpac system preference to "allow" and log in to the OPAC as a user who has one or more holds. - Check the appearance of the "suspend" and "resume" buttons both in the table of holds and at the bottom. - With one or more clubs defined, log in to the OPAC and check the "Clubs" tab on the user summary page. The "Enroll" and "Cancel enrollment" buttons should look correct. - On the "your messaging" tab in the OPAC, the "Digests only" information icon should look correct. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Jonathan Druart changed: What|Removed |Added Attachment #76557|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 77190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77190&action=edit Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- The colour of the icons changed (now they are always white), is it expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What|Removed |Added Attachment #76657|0 |1 is obsolete|| --- Comment #62 from Owen Leonard --- Created attachment 77189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77189&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |BLOCKED --- Comment #12 from Jonathan Druart --- Blocked by bug 19474. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21101] Allow to disable XSLT cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21101 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #5 from Paul Poulain --- Most of our customers have access to XSLT editing (through a webdave space), but they don't have any SSH access. => restarting plack & updating XSLT don't require the same kind of permission. With this dev, a librarian can : * turn the pref ON * play with XSLT and test * once it's OK, turn pref OFF and get caching & performance back. The library is happy and our support team is happy too, one less thing to do :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21103] Fix parameter reuse in Elasticsearch/QueryBuilder.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21103] Fix parameter reuse in Elasticsearch/QueryBuilder.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 --- Comment #1 from Nick Clemens --- Created attachment 77188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77188&action=edit Bug 21103: Declare new parameter for loop iterator To test: prove -v t/00-testcritic.t it fails apply patch it passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21103] New: Fix parameter reuse in Elasticsearch/QueryBuilder.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103
Bug ID: 21103
Summary: Fix parameter reuse in Elasticsearch/QueryBuilder.pm
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
t/00-testcritic.t is failing on master
On line 318 we have:
foreach $val (@values) {
$val is a parameter passed in elsewhere, we should declare our own variable
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20683] Update German web installer for 18.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683 Jonathan Druart changed: What|Removed |Added Attachment #76805|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 77187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77187&action=edit Bug 20683: Update German web installer for 18.05 Adds translations for 2 new notices CANCEL_HOLD_ON_LOST and CHECKOUT_NOTE. Some small changes to older notices to match them with the English templates. To test: - Install German - Run the web installer on an empty database - Make sure all files install correctly and there are no SQL errors - Check notices were loaded correctly Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20683] Update German web installer for 18.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added Keywords||NeedsMoreQA --- Comment #14 from Jonathan Druart --- Koha::Item->is_waiting_or_transit sounds wrong to me, this logic belongs to Koha::Hold Waiting for another QA opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added Attachment #76630|0 |1 is obsolete|| Attachment #76631|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 77184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77184&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #13 from Jonathan Druart --- Created attachment 77186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77186&action=edit Bug 20469: Use DBIC rs and return ->count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #12 from Jonathan Druart --- Created attachment 77185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77185&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #5 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > (In reply to Nick Clemens from comment #0) > > This is an issue because of the datepicker on the holds page in intranet - > > it doesn't allow you to select today's date, so it sets the date to > > tomorrow > > Why do not we fix the UI instead? Because the script is wrong, and fixing it means the UI works right :-) The description in staff side when suspending holds: Specify date on which to resume (MM/DD/) : If we resume on that date, then we unsuspend before that date (today) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- Why do you return an empty string instead of "0"? IMO we should return ->count, and use the DBIC rs. I will provide a patch and you will tell me what you think about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #35 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #36 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Add separate permission for managing suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #21 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #71 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Barton Chittenden changed: What|Removed |Added CC||bar...@bywatersolutions.com Severity|enhancement |normal --- Comment #32 from Barton Chittenden --- I'm pushing the severity of to Normal -- this is causing significant issues at libraries where patrons have lots of fines, and I would like to see a back-port to 17.11 if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #62 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Jonathan Druart changed: What|Removed |Added Attachment #77176|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77183&action=edit Bug 21041: "Merge patrons" button remains disabled with "Select all" option This patch modifies the JavaScript functions for the select all/clear all links so that each action triggers the "change" event, required to enable or disabled the "merge selected patrons" button. To test, apply the patch and perform a patron search which will return multiple results. - Test the "select all" and "clear all" links, and confirm that the "Merge selected patrons" button is enabled and disabled. - Test that checking and unchecking multiple checkboxes still works correctly to enable and disable the button. Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Jonathan Druart changed: What|Removed |Added Depends on||9302 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 [Bug 9302] Add ability to merge patron records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9302] Add ability to merge patron records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Jonathan Druart changed: What|Removed |Added Blocks||21041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 [Bug 21041] "Merge patrons" button remains disabled with "Select all" option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- (In reply to Nick Clemens from comment #0) > This is an issue because of the datepicker on the holds page in intranet - > it doesn't allow you to select today's date, so it sets the date to > tomorrow Why do not we fix the UI instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > You should paste here the values of surname and firstname you have set for > this user. And the userid (it is the one displayed on the intranet side actually) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- You should paste here the values of surname and firstname you have set for this user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 --- Comment #6 from Jonathan Druart --- Created attachment 77182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77182&action=edit Bug 20757: Add pod for ->capture -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 --- Comment #3 from Owen Leonard --- Reopened to include Bug 21094 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191
--- Comment #61 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #59)
> (In reply to Kyle M Hall from comment #58)
> > (In reply to Jonathan Druart from comment #56)
> > > 1. There is 'Account Writeoff' vs 'Account writeoff'
> > >
> > > 2. In Koha::Account->pay, why require C4::Letters; instead of use?
> > >
> > > 3. Koha/Account.pm:273
> > > lang=> Koha::Patrons->find( $self->{patron_id} )->lang,
> > > No need to refetch the patron object, you did it already at the beginning
> > > of
> > > the method.
> > >
> > > 4. Koha/Account.pm:280
> > > offsets => scalar Koha::Account::Offsets->search( { id => { -in => [
> > > map {
> > > $_->id } @account_offsets ] } } ),
> > >
> > > I do not understand this line, we are refetching what we already have?
> >
> > Follow addresses everything but 2. I used require instead of use because use
> > is hoisted and it would import it even if the feature is not being used.
> > Basically it's a small efficiency improvement.
>
> It's usually a bad idea to require instead of use, to catch errors at
> compilation time.
> It's too late for 18.05 so I will let next RM decides.
>
> Moreover the title of the last patch is not formatted correctly.
We already load C4::Letters in plack.psgi anyway. I agree with Jonathan it is
better to use the lib, to catch problems in compilation time.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21102 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17785 CC||ere.maij...@helsinki.fi, ||pablo.bian...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21102] New: OAI-PMH specification conformance [UMBRELLA]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Bug ID: 21102 Summary: OAI-PMH specification conformance [UMBRELLA] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Currently, Koha fails various validation tests on the OAI-PMH implementation. [1] This umbrella bug will ease finding OAI-PMH implementation issues. [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785#c13 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Pablo AB from comment #13) > So this bug should be reopened? bibkat.no doesn't fail beacause it doesn't > use Plack? pablito, I think we need to focus on each issue in a separate place. I would create an 'umbrella' bug (meaning it is not a real bug but a goal), and then file individual bugs for each alleged bug. Those tests you made should all be made against master. Not sure where, how. But we don't develop (usually) against stable branches. We develop against master, and the maintainers backport. That said, file independent bugs, marking them as 'Blocks' the umbrella bug. There's a situation with the HTTP::OAI library maintenance status that needs to be solved ASAP, but it might not be related to this bugs you highlight, as how the data comes from the DB for exposing it on the OAI-PMH front-end is a Koha business. About the OAI-PMH spec requiring UTC, I think it is a plain wrong decision. Conversion can be done asynchronously on receiving the data (in the harvester), but in turn, it forces the provider to convert whatever data it has into UTC, causing an innecessary overhead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
