[Koha-bugs] [Bug 21124] Non-Public note does not appear if added to item in MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21124 dani...@brimbank.vic.gov.au changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #5 from dani...@brimbank.vic.gov.au --- Hi Katrin, Just looked in one of the MARC frameworks and noticed there was no Koha link in Advanced Constraints for Non-public note in the Live system. In our Test system, there is a link for the framework. I will check the other frameworks, but this looks like the problem. So what you're saying is if I update the link it will wipe the current notes that are in there? I guess I better migrate the existing notes then :) Thanks all for your help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Victor Grousset/tuxayo changed: What|Removed |Added CC||matthias.meusburger@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Jonathan Druart changed: What|Removed |Added Attachment #77252|0 |1 is obsolete|| Attachment #77253|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 77357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77357=edit Bug 19743: Update header and footer on each item for checkin / checkout / renewal notices When generating the checkout notice for a patron we only update the section in between the '---' tags For template toolkit purposes it means we cannot affect the content based on more than a single item. For instance, we want to add the total cost of all items checked out. Test Plan: 1) Add "Thank you for visiting <>." to the bottom of the checkout notice. Below the second ''. 2) Check out an item to a patron to generate that notice 3) Note the branch name in the notice 4) Update the branch name in the branches editor, change it to something else 5) Check out a 2nd item to that patron 6) Notice the items list updated, but the branch name did not 7) Apply this patch 8) Check out a 3rd item to that patron 9) Notice the branch name updated this time Signed-off-by: Te Rauhina Jackson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 --- Comment #9 from Jonathan Druart --- Created attachment 77358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77358=edit Bug 19743: Unit Tests Signed-off-by: Te Rauhina Jackson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 Katrin Fischer changed: What|Removed |Added Blocks||20813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 [Bug 20813] Revamp user permissions system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Add separate permission for managing suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What|Removed |Added Blocks|20813 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 [Bug 20813] Revamp user permissions system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Katrin Fischer changed: What|Removed |Added Depends on|7651, 11911 |20226 CC||oleon...@myacpl.org --- Comment #10 from Katrin Fischer --- Hi Kyle, I think with Koha's code having moved since this was originally written, this needs more of a rebase than I can handle :( Do you think you will have time to work on this? I'd really like to help move this along and will make time for it. Some things I noticed so far: - CATCODE_MULTI will be removed by bug 20226 - We have the patron object available in the templates now, so won't need the template variables (bug 18789) - We already got a has_permission in Patron.pm, so this gets doubled up by the patch - There is also a is_child that could simplify some of the code - Do we still need the description column in the permission table? We could think about removing it as the descriptions are in the templates. - Database update appears to be missing - Why the change to member in members-toolbar.inc? - Got confused by having both Koha::Patron::Permission(s) and Koha::Permission(s) - Owen is trying to get rid of the tree view on bug 11375 - maybe something to talk about before moving forward here or there. - I feel like we should keep part of the copyright on top of member-flags.pl I am thinking about moving on with my patch for making granular administration permissions that I had started as it might not be too hard to adapt this patch set (bug 14391). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 [Bug 7651] Add separate permission for managing currencies and exchange rates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 [Bug 11911] Add separate permission for managing suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What|Removed |Added Blocks|20813 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 [Bug 20813] Revamp user permissions system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #32 from Jonathan Druart --- Created attachment 77355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77355=edit Bug 20997: (QA follow-up) POD fixes and offset type consistency This patch addresses minor issues highlighted by QA. - The POD is enhanced based on the proposal in bug 11983. - The introduced offset type value is made consistent with the rest of them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #31 from Jonathan Druart --- Created attachment 77354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77354=edit Bug 20997: (follow-up) Minor POD fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #33 from Jonathan Druart --- Created attachment 77356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77356=edit Bug 20997: Replace missing credit_applied with 'Credit Applied' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #30 from Jonathan Druart --- Created attachment 77353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77353=edit Bug 20997: ->apply should be applied to Koha::Account::Lines This patch makes ->apply get passed an object set class instead of single account lines. The change is fully covered by tests. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #29 from Jonathan Druart --- Created attachment 77352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77352=edit Bug 20997: Add new offset type Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #28 from Jonathan Druart --- Created attachment 77351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77351=edit Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method Test plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t => Test should pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #27 from Jonathan Druart --- Created attachment 77350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77350=edit Bug 20997: Add Koha::Account::Line::apply method This patch implements the ->apply() method for account lines. It will only work on credit lines, and raise an exception otherwise. It implements ->is_credit() as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Check all use cases are covered by the tests - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Jonathan Druart changed: What|Removed |Added Attachment #77194|0 |1 is obsolete|| Attachment #77195|0 |1 is obsolete|| Attachment #77196|0 |1 is obsolete|| Attachment #77197|0 |1 is obsolete|| Attachment #77198|0 |1 is obsolete|| Attachment #77199|0 |1 is obsolete|| Attachment #77310|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 77349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77349=edit Bug 20997: Add unit tests for Koha::Account::Line::apply This patch adds unit tests for the mentioned method. To test: - Apply this patch - Run: $ khell k$ prove t/db_dependent/Koha/Account/Lines.t => FAIL: The method is not already implemented! Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21112] Re-indent staff client cart template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21112 Owen Leonard changed: What|Removed |Added Attachment #77239|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #118 from Jonathan Druart --- I cannot test it, when I save a new patron with a guarantor I get No property new_guarantor_surname for Koha::Patron at /usr/share/perl5/Exception/Class/Base.pm line 73 When I click "Add Child", I land on a "Add patron (Adult)" page. I would suggest to request another signoff after the re-submission. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #117 from Jonathan Druart --- - Are you sure we need the change to Koha::Object? - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt [% To.json(data) %] must have the html filter - changes to opac-user.tt are wrong (not needed) - There are too many (unneeded) changes made to members/update-child.pl, it will conflict with bug 20226 (not blocker) - misc/cronjobs/j2a.pl transaction must be done using txn_begin/txn_commit/txn_rollback - C4::Installer::load_sql returned the following errors while attempting to load /home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_14570.sql: I do not know what the error is. - Charset/collate: relationship VARCHAR(100) COLLATE utf8_unicode_ci NOT NULL, => this is wrong - same in the atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21135] New: Upon log in, user is redirected to account page instead of the page where they logged in from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135 Bug ID: 21135 Summary: Upon log in, user is redirected to account page instead of the page where they logged in from Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When a user clicks on a link "log in to ..." they are redirected to their account page instead of staying on the page they were on to do whatever they needed to log in to do. To reproduce : 1- In Administration > System preferences, enable TagsEnabled 2- Make sure TagsInputOnDetail is set to Allow 3- Go to OPAC, and do a search 4- Click on title to go to the details page 5- Click on the "Log in to add tags" link 6- Enter your login credentials in the popup window Result : user is redirected to "My account" Desired result : user is now logged in but stays on the record detail page Second case : 1- In OPAC, click on Lists > View All 2- Click on "Log in to create new lists" 3- Enter your login credentials Result : user is redirected to "My account" Desired result : user is now logged in but stays on the lists page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #116 from Jonathan Druart --- Created attachment 77348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77348=edit Bug 14570: Remove double declaration of $patron in opac-user.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What|Removed |Added Attachment #77290|0 |1 is obsolete|| Attachment #77291|0 |1 is obsolete|| --- Comment #114 from Jonathan Druart --- Created attachment 77346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77346=edit Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #115 from Jonathan Druart --- Created attachment 77347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77347=edit Bug 14570: Update schema files [Do Not Push] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #113 from Jonathan Druart --- (In reply to Kyle M Hall from comment #96) > > d. IMPORTANT - Should not we finally keep these fields and force the > > guarantors to be existing patrons? We could have only 1 "contact" and > > several guarantors. It seems that it will simplify a lot the code (for > > instance Koha::Patron->guarantors would return Koha::Patrons, and > > Koha::Patron::Relationship[s] would stay simple Koha::Object[s]) > > I'm going to have to ruminate on this and find out what the sponsors > requirements are. I like how it would simplify the code, but it would also > provide limitations that have already been overcome in the current patch set. What did you finally decide? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #9 from Jonathan Druart --- Created attachment 77345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77345=edit Bug 21133: Fix use statements order Basically the idea is: 1. Undefined subroutine ::Items::ModZebra called at /home/vagrant/kohaclone/C4/Items.pm line 302. => Then use C4::Items before C4::Biblio 2. Undefined subroutine ::Circulation::GetItem called at /home/vagrant/kohaclone/C4/Circulation.pm line 1290 => Then use C4::Circulation before C4::Items And sometimes these 2 rules do not work... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17539, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21133 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21133 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #8 from Jonathan Druart --- I am fixing this, in tests. Basically the idea is: 1. Undefined subroutine ::Items::ModZebra called at /home/vagrant/kohaclone/C4/Items.pm line 302. => Then use C4::Items before C4::Biblio 2. Undefined subroutine ::Circulation::GetItem called at /home/vagrant/kohaclone/C4/Circulation.pm line 1290 => Then use C4::Circulation before C4::Items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5598] More Granular Cloning Circulation & Fine Rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #7 from Jonathan Druart --- We broke some tests with this patch, it adds circular dependencies. koha_1 | Undefined subroutine ::Items::ModZebra called at /kohadevbox/koha/C4/Items.pm line 302. koha_1 | Undefined subroutine ::Circulation::GetItem called at /kohadevbox/koha/C4/Circulation.pm line 1290. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21128] Replace JavaScript-driven authority hierarchy display with static version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21128 --- Comment #6 from Owen Leonard --- (In reply to Mirko Tietgen from comment #4) > I don't think we actually tried to keep up with plugin upgrades, given that > we bundle 1.0.-RC3 from 2011. :P If it turns out that a tree display is the best solution, then we'll certainly upgrade. I just want to make sure we're not missing an opportunity to simplify if it's appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi --- Pushed to master, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||jonathan.dru...@bugs.koha-c ||ommunity.org CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi changed: What|Removed |Added Attachment #77341|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 77344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77344=edit Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm It's a follow-up of commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to->add_enrolment_fee_if_needed One of the known issue: > update categories set enrolmentfee=2; The use misc/devel/create_superlibrarian.pl to create a new superlibrarian patron Signed-off-by: Victor Grousset Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 18.11, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi changed: What|Removed |Added Summary|Missing use C4::Accountz|Missing use C4::Accounts |statement in Koha/Patron.pm |statement in Koha/Patron.pm Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accountz statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi changed: What|Removed |Added Summary|Missing use C4::Account |Missing use C4::Accountz |statement in Koha/Patron.pm |statement in Koha/Patron.pm CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Skipping QA for trivial patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Tomás Cohen Arazi changed: What|Removed |Added Attachment #77342|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 77343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77343=edit Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve koha_1 | # Looks like you planned 20 tests but ran 9. koha_1 | koha_1 | # Failed test 'approve tests' koha_1 | # at t/db_dependent/Koha/Patron/Modifications.t line 259. koha_1 | [Something went wrong]# Looks like your test exited with 255 just after 5. koha_1 | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t . "Something went wrong" should never been thrown, Koha::Patron::Modification->approve raises $@, but it's not defined, it should raise $_ instead Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134
--- Comment #2 from Jonathan Druart
---
To test you can play with the following snippet:
use Koha::Exceptions::Patron::Modification;
use Try::Tiny;
try {
die "this is a specific error";
} catch {
Koha::Exceptions::Patron::Modification->throw($@);
};
then replace $@ with $_
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
CC||victor.grous...@biblibre.co
||m
--- Comment #4 from Victor Grousset/tuxayo ---
Fix confirmed. Without the patch I got
{UNKNOWN}: Undefined subroutine ::Accounts::manualinvoice called at
/home/koha/src/Koha/Patron.pm line 864. at /home/koha/src/Koha/Patron.pm line
347
With the patch, it now works.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 --- Comment #1 from Jonathan Druart --- Created attachment 77342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77342=edit Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve koha_1 | # Looks like you planned 20 tests but ran 9. koha_1 | koha_1 | # Failed test 'approve tests' koha_1 | # at t/db_dependent/Koha/Patron/Modifications.t line 259. koha_1 | [Something went wrong]# Looks like your test exited with 255 just after 5. koha_1 | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t . "Something went wrong" should never been thrown, Koha::Patron::Modification->approve raises $@, but it's not defined, it should raise $_ instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #77340|0 |1 is obsolete|| --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 77341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77341=edit Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm It's a follow-up of commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to->add_enrolment_fee_if_needed One of the known issue: > update categories set enrolmentfee=2; The use misc/devel/create_superlibrarian.pl to create a new superlibrarian patron Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Jonathan Druart changed: What|Removed |Added Depends on||17767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 [Bug 17767] Let Koha::Patron::Modification handle extended attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Jonathan Druart changed: What|Removed |Added Blocks||21134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] New: Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Bug ID: 21134 Summary: Wrong error handling in Koha/Patron/Modification.pm hides a bug Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org koha_1 | # Looks like you planned 20 tests but ran 9. koha_1 | koha_1 | # Failed test 'approve tests' koha_1 | # at t/db_dependent/Koha/Patron/Modifications.t line 259. koha_1 | [Something went wrong]# Looks like your test exited with 255 just after 5. koha_1 | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t . "Something went wrong" should never been thrown, Koha::Patron::Modification->approve raises $@, but it's not defined, it should raise $_ instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Jonathan Druart changed: What|Removed |Added Blocks||21133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Jonathan Druart changed: What|Removed |Added Depends on||21087, 16912 --- Comment #2 from Jonathan Druart --- Should be backported if patches from bug 16912 are there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 [Bug 16912] Koha::Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 [Bug 21087] Patron's password is hashed twice when the object is saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16912] Koha::Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart changed: What|Removed |Added Blocks||21133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #1 from Jonathan Druart --- Created attachment 77340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77340=edit Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm It's a follow-up of commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to->add_enrolment_fee_if_needed One of the known issue: > update categories set enrolmentfee=2; The use misc/devel/create_superlibrarian.pl to create a new superlibrarian patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] New: Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Bug ID: 21133 Summary: Missing use C4::Account statement in Koha/Patron.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Jonathan Druart changed: What|Removed |Added Severity|enhancement |major Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Jonathan Druart changed: What|Removed |Added Attachment #77338|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 77339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77339=edit Bug 21122: Fix check-url-quick when utf8 characters in URL's To test: Make a record with a URL that has a UTF8 character, such as: http://some.nonexistent.tld/MāoriWomenAotearoa.pdf Run the check-url-quick.pl job, notice it dies at that URL Apply this patch Test again, it should work. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Jonathan Druart changed: What|Removed |Added Attachment #77289|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 77338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77338=edit Bug 21122: check-url-quick dies on utf8 characters in URL's To test: Make a record with a URL that has a UTF8 character, such as: http://some.nonexistent.tld/MāoriWomenAotearoa.pdf Run the check-url-quick.pl job, notice it dies at that URL Apply this patch Test again, it should work. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 --- Comment #3 from Jonathan Druart --- I got worst result without the patch: 15 http://some.nonexistent.tld/MāoriWomenAotearoa.pdf 595 No such device or address EV: error in callback (ignoring): Wide character in subroutine entry at /usr/lib/x86_64-linux-gnu/perl5/5.20/AnyEvent/Handle.pm line 1007. Wide character in print at misc/cronjobs/check-url-quick.pl line 67. 15 http://ko.wikipedia.org/wiki/위키백과:대문 596 Connection timed out EV: error in callback (ignoring): Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl5/5.20/AnyEvent/Handle.pm line 2285. EV: error in callback (ignoring): Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl5/5.20/AnyEvent/Handle.pm line 2285. EV: error in callback (ignoring): Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl5/5.20/AnyEvent/Handle.pm line 2285. EV: error in callback (ignoring): Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl5/5.20/AnyEvent/Handle.pm line 2285. [...infinite loop...] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |l...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history consistent with other patron account pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #6 from Jonathan Druart --- With this patch we are fixing half of the inconsistency, so yes we could fix that on a separate bug report, if you prefer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > It sounds like we should put some flush call to C4::Auth as well. No bug reported, so no fix for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Jonathan Druart changed: What|Removed |Added Attachment #76800|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 77336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77336=edit Bug 21056: Changing the logged in library can fail sporadically We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail. Flushing the session after updating the branch appears to fix this. Test Plan: 1) Change your logged in library repeatedly. Hopefully ( sort of ) it will fail to change. You may want to try various browsers. 2) Apply this patch 3) Note the change no longer fails Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 --- Comment #6 from Jonathan Druart --- Created attachment 77337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77337=edit Bug 21056: Add another flush later Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Katrin Fischer changed: What|Removed |Added Attachment #75545|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #9 from Katrin Fischer --- Working on a rebase, small conflict caused by http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=C4/Auth.pm;h=10929d887f2c6cf20f4ff2cced45ad577f29ebc8;hp=60c8c87911faeaf4459c5f1dc6154f726cbab710;hb=421746dd6337814f96adc6d79a773a2a23f50556;hpb=3d68ab447eda3eb5a25444b1ceaeea96b446c64b Will see how far I get. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Jonathan Druart changed: What|Removed |Added Attachment #77332|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 77335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77335=edit Bug 21032: Fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Jonathan Druart changed: What|Removed |Added Attachment #77320|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77334=edit Bug 21077: Fix database documentation for statistics.type There's a typo for 'locause', this should be 'localuse'. Also, 'Credit*' is never used. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history consistent with other patron account pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #5 from Katrin Fischer --- Do you mean all other pages or just this one? If the patron title is not on all pages, maybe this could be a separate bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20813 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11375 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history consistent with other patron account pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Other files have the patron.title displayed. Well, not all... Should not we fix everything at once on this bug report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Katrin Fischer changed: What|Removed |Added Depends on||11911, 7651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 [Bug 7651] Add separate permission for managing currencies and exchange rates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 [Bug 11911] Add separate permission for managing suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Add separate permission for managing suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What|Removed |Added Blocks||20813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 [Bug 20813] Revamp user permissions system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What|Removed |Added Blocks||20813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 [Bug 20813] Revamp user permissions system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history consistent with other patron account pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Other files have the patron.title displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Attachment #75967|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 77333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77333=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #10 from Katrin Fischer --- Hi Owen, I've rebased the patch to add the new permissions, hope I got everything right. Some things I notice: 1) Currently, when you click on a sub-permission, the top-level permission checkbox gets unchecked. With the new patches this no longer happens, which I think could lead to errors. Could we restore this behaviour? 2) Ok... searched up and down, otherwise this appears to work great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Jonathan Druart changed: What|Removed |Added Attachment #76884|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 77332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77332=edit Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #28 from Tomás Cohen Arazi --- Follow-up pushed to master. Gracias, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #113 from Tomás Cohen Arazi --- Follow-up pushed to master. Gracias, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21129] New ALTER IGNORE TABLE entries need correction in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 --- Comment #4 from Jonathan Druart --- Created attachment 77331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77331=edit Bug 21129: Fix typo created vs created_by -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21128] Replace JavaScript-driven authority hierarchy display with static version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21128 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Mirko, I think you might mean a different thing? This is for the authority detail page, not for the older opac-browser feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21101] Allow to disable XSLT cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21101 --- Comment #7 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #6) > We need a couple 'flush' buttons in about.pl, what do you think? > > - flush memcached > - flush template-toolkit cache > - flush XSLT cache Hmm. This might be better than toggling preferences. Where: About or Administration? The need to flush the XSLT cache separately might be very limited (although supported with $xslt->refresh). If we gracefully(!) restart Plack, we achieve the same and more? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #72 from Jonathan Druart --- There is no signoff! Please test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Jonathan Druart changed: What|Removed |Added Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||6979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 [Bug 6979] LDAP authentication fails during password comparison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Jonathan Druart changed: What|Removed |Added Blocks||18947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 [Bug 18947] Unexpected Active Directory LDAP authentication failure mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
