[Koha-bugs] [Bug 21149] Administrator creation in onboarding always fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 --- Comment #6 from Martin Renvoize --- I have the selenium tests bug and it's dependency of the separate db's for testing on my list for early next week. Lets get some tests in place to prevent a re-occurrence :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Martin Renvoize --- I like this and it all looks reasonably sane.. I'd like to test it against a few full test suit runs before signing it off though.. one for Monday! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #12 from Martin Renvoize --- This generally looks pretty solid to me.. certainly a good first step.. i'm sure we could test the negative cases a bit more (for example using bad db credentials and checking the right errors are present), but generally speaking this looks good to me. Of course, these tests can only be run on a brand new DB and as such make most sense when used alongside the dependency bug 19821 which given the right config will create a brand new clean database for each test run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #11 from Martin Renvoize --- Comment on attachment 75090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75090 Bug 19185: Add selenium tests for installation and onboarding process Review of attachment 75090: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19185&attachment=75090) - ::: t/db_dependent/selenium/00-installation.t @@ +52,5 @@ > +my $db_pass = C4::Context->config('pass'); > + > +$driver->get($base_url."mainpage.pl"); > + > +my $lang = "en"; # The idea here is to loop on all languages Question: Why would we want to loop for all languages? Are you still intending on implementing this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- This looks way better than the grey buttons. I did have a couple of problems though 1) I had trouble applying the patch, I had to add manually basket.tt and then resume applying. 2) Once the patch is applied, if I click on "Add user", nothing happens, but if I remove the patch, and click on "Add user", the pop-up appears. 3) Same thing if I click on "Set library" or "Change basket group" And my other comment is purely personal, I love the way it looks, but it adds one click. To change a basket group, for example, you have to click on "Change basket group", then choose the basket group in the drop down, and save (4 clicks). Whereas now, you just choose the basket group in the drop down and save (3 clicks). It's not the end of the world, and I can absolutely live with one click more, but I just wanted to throw it out there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21149] Administrator creation in onboarding always fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Works as expected and no failures on the qa scripts. Looks good to me, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21149] Administrator creation in onboarding always fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 Martin Renvoize changed: What|Removed |Added Attachment #77450|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 77485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77485&action=edit Bug 21149: Fix superlibrarian creation in onboarding See bug 21087 for more details. Test plan: Drop your DB Start the installation process Use the onboarding process to install missing data The superlibrarian created during this process should be created sucessfully and allowed to login Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21149] Administrator creation in onboarding always fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] series link is taking you to just 800a instead of whole 800
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #5 from Caroline Cyr La Rose --- Ok, so I have two records in my catalog by the same author, but the series is different (there is one word that is the same in both series titles). - Anne Robillard - Les chevaliers d'Antarès - Anne Robillard - Les chevaliers d'Émeraude The first record has a 800 but if I click on it, I get the second record which isn't the same series. Since it's a search and not a link to an authority, it might just be how zebra works. He thinks it's mostly the same and that's good enough for him. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #13 from Maryse Simard --- Patch doesn't apply. It seems to be due to the fact that the ReservesNeedReturns logic was moved from placerequest.pl & opac-reserve.pl to Reserves.pm by bug 20724. Applying: Bug 4812: Reserves for a specific copy of a book say book is available even though it it still checked out .git/rebase-apply/patch:32: trailing whitespace. $rank = '0'; warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M opac/opac-reserve.pl M reserve/placerequest.pl .git/rebase-apply/patch:32: trailing whitespace. $rank = '0'; warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging reserve/placerequest.pl CONFLICT (content): Merge conflict in reserve/placerequest.pl Auto-merging opac/opac-reserve.pl CONFLICT (content): Merge conflict in opac/opac-reserve.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 4812: Reserves for a specific copy of a book say book is available even though it it still checked out -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 77484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77484&action=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Maryse Simard --- (In reply to Owen Leonard from comment #6) > After creating a list which is sorted by default by date added, when I view > it in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected. Hmm... when I test it myself, I do not encounter this problem ("Date added" is properly preselected). Also, looking at the patch, it seems as though the situation should be handled correctly... Could I have you look at it one more time and confirm the problem does occur for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart changed: What|Removed |Added Attachment #77466|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 77483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77483&action=edit Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Signed-off-by: Cab Vinton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21132] Highlight active filters on saved report page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Maryse Simard changed: What|Removed |Added Attachment #77326|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 77482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77482&action=edit Bug 21132: Highlight active filters on saved report page This patch adds a more obvious way of see which search terms have been submitted to filter the table of saved reports. The patch also moves embedded CSS into a separate file. To test you should have multiple saved reports. - Apply the patch and go to Reports -> Use saved. - Filter the table of reports by submitting one or more terms in the sidebar "Filter" form. - Confirm that the terms you submit are shown at the top of the table of results. - Confirm that clicking the "Clear" link clears the search filter. Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21132] Highlight active filters on saved report page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] New: Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Bug ID: 21158 Summary: Add cronjob references to the system preference descriptions if a cronjob is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Add a reference in the system preference description saying this syspref requires a cronjob in order to work properly. Something like "Note: This system preference requires the misc/cronjobs/blah-blah.pl. Ask you system administrator to schedule it." The following system preferences require cronjobs. The starred sysprefs already have a reference to their cronjob, but it would be nice to standardize the message. - StaticHoldsQueueWeight: misc/cronjobs/holds/build_holds_queue.pl - ExpireReservesMaxPickUpDelay: misc/cronjobs/holds/cancel_expired_holds.pl - AutoResumeSuspendedHolds: misc/cronjobs/holds/auto_unsuspend_holds.pl - * finesMode: misc/cronjobs/fines.pl - DefaultLongOverdueLostValue: misc/cronjobs/longoverdue.pl - DefaultLongOverdueChargeValue: misc/cronjobs/longoverdue.pl - PatronSelfRegistrationExpireTemporaryAccountsDelay: misc/cronjobs/delete_expired_opac_registrations.pl - PatronSelfRegistrationVerifyByEmail: misc/cronjobs/delete_unverified_opac_registrations.pl - EnhancedMessagingPreferences: misc/cronjobs/process_message_queue.pl & misc/cronjobs/advance_notices.pl - NewItemsDefaultLocation: misc/cronjobs/cart_to_shelf.pl - InProcessingToShelvingCart: misc/cronjobs/cart_to_shelf.pl - ReturnToShelvingCart: misc/cronjobs/cart_to_shelf.pl - * AuthorityMergeLimit: misc/migration_tools/merge_authority.pl - * OpacBrowser: misc/cronjobs/build_browser_and_cloud.pl - * OpacCloud: misc/cronjobs/build_browser_and_cloud.pl - * UsageStats: share_usage_with_koha_community.pl - * PurgeSuggestionsOlderThan: misc/cronjobs/purge_suggestions.pl - MembershipExpiryDaysNotice: misc/cronjobs/membership_expiry.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21150] Data inconsistencies - item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 --- Comment #4 from Jonathan Druart --- Created attachment 77481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77481&action=edit Bug 21150: Search for item types inconsistencies search_for_data_inconsistencies.pl will now display errors if: 1.item-level_itypes is set to "specific item" and items.itype is not set or not set to an item type defined in the system (itemtypes.itemtype) 2.item-level_itypes is set to "biblio record" and biblioitems.itemtype is not set or not set to an item type defined in the system (itemtypes.itemtype) Test plan: Use the script and the different possible combinations to display the errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21150] Data inconsistencies - item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21150] Data inconsistencies - item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Depends on||21011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011 [Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011 Jonathan Druart changed: What|Removed |Added Blocks||21150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 [Bug 21150] Data inconsistencies - item types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20407] Hide some fields from unauthorized users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 Tomás Cohen Arazi changed: What|Removed |Added URL||https://wiki.koha-community ||.org/wiki/Partial_resources ||_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #77464|0 |1 is obsolete|| --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 77480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77480&action=edit Bug 21154: Remove unused subs from C4::Serials Test plan: Run these commands, grep should not return any occurences, prove should return green: git grep GetSerialStatusFromSerialId git grep GetDistributedTo git grep SetDistributedTo git grep SetDistributedto git grep in_array git grep is_barcode_in_use kshell prove t/db_dependent/Serials.t Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 --- Comment #1 from Owen Leonard --- Created attachment 77479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77479&action=edit Bug 21157: Improve style of OPAC login modal This patch revises the style of the OPAC's login form modal view. The goal is simply to make it look nicer. To test, apply the patch and regenerate the OPAC's CSS (https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files). In the OPAC, click the "Log in to your account" link at the top of the page. It should trigger the login modal. While the modal is displayed, resize the browser width to confirm that the form handles different widths well. Sign off if you think this is an improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] New: Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Bug ID: 21157 Summary: Improve style of OPAC login modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Created attachment 77478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77478&action=edit Screenshot showing the updated login form The OPAC login modal looks boring. I propose an update to it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 --- Comment #33 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #32) > This was QAed in March, guys. We are in August now! Is this part of the > "scare the last developers away" project or so ? I am not aware of such project, where is the code? RM is on holiday and Tomas is processing bug fixes only. About the non-inclusion into 18.05 I have answered already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #95 from Julian Maurice --- JS part is in bug 21156 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #1 from Julian Maurice --- Created attachment 77477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77477&action=edit Bug 21156: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian jessie, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr-FR-messages-js.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What|Removed |Added Blocks||21156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] New: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Bug ID: 21156 Summary: Internationalization: plural forms, context, and more for JS files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Depends on: 15395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #94 from Julian Maurice --- To ease testing I squashed all the patches, merged the test plans, and removed the JS part (I will re-add it in another bug). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What|Removed |Added Attachment #73901|0 |1 is obsolete|| Attachment #73902|0 |1 is obsolete|| Attachment #73903|0 |1 is obsolete|| Attachment #73904|0 |1 is obsolete|| Attachment #73905|0 |1 is obsolete|| Attachment #73906|0 |1 is obsolete|| Attachment #73907|0 |1 is obsolete|| Attachment #73908|0 |1 is obsolete|| Attachment #73909|0 |1 is obsolete|| Attachment #73910|0 |1 is obsolete|| Attachment #73911|0 |1 is obsolete|| Attachment #73912|0 |1 is obsolete|| Attachment #73913|0 |1 is obsolete|| Attachment #76328|0 |1 is obsolete|| Attachment #76329|0 |1 is obsolete|| Attachment #76330|0 |1 is obsolete|| --- Comment #92 from Julian Maurice --- Created attachment 77475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77475&action=edit Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") This patch also brings Koha::I18N power to Template::Toolkit templates by adding a TT plugin. This plugin can be used like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages and PPI Test plan for translation in Perl code: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) You may need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct 8. prove t/Koha/I18N.t Test plan for translation in templates: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http:
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #93 from Julian Maurice --- Created attachment 77476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77476&action=edit Bug 15395: Example usage of I18N Template::Toolkit plugin Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] series link is taking you to just 800a instead of whole 800
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 --- Comment #4 from Owen Leonard --- Created attachment 77474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77474&action=edit Bug 13692: series link is taking you to just 800a instead of whole 800 This patch modifies the OPAC and staff client's XSL template for the detail page so that series links based on a traced 490 tag use both author and series title from the 800 tag. To test you should have multiple titles in the same series with matching 490 and 800 tags in each record. Apply the patch and restart Plack if necessary. View the detail page for one of the series' titles. The "Series:" link should link to a search which uses both series title and author. Clicking the link should return the correct results. Test both the OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] series link is taking you to just 800a instead of whole 800
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] series link is taking you to just 800a instead of whole 800
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #24 from Owen Leonard --- (In reply to Jonathan Druart from comment #22) > Zoom in a bit: > https://screenshots.firefox.com/KYNIlu5FRCjpqM39/pro.kohadev.org I agree that this isn't ideal, but I don't think it's an issue which should block these patches. There are still a lot of responsive improvements which should be made to this interface. The goal of this bug is to lay the groundwork for those improvements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #23 from Owen Leonard --- Created attachment 77473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77473&action=edit Bug 20044: (follow-up) Add min-width to .input_marceditor This patch adds a min-width property to the first .input_marceditor rule in order to prevent styled by Select2 from collapsing at narrower browser widths. To reproduce the bug, apply all patches on Bug 20044 except this one. Open the MARC editor and narrow the browser width to below 768 pixels. Reload the page and view a tab which contains a styled by Select2 (942c is often an example). The will have narrowed to be almost invisible. Apply the patch and reproduce the steps above. The s should be fully visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Jonathan Druart changed: What|Removed |Added Attachment #77418|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 77472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77472&action=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: If you have older acq data, you may have records in aqorders with field tax_rate_on_ordering is NULL. These orders will trigger the above warns. If you do not have, you could simulate by setting this field to NULL. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #18 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21094] Syndetics: always use https instead of http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable Severity|enhancement |minor CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03. I've altered this from 'enhancement' to 'bug - minor'... it's a simple patch and improves security and user experience with zero detrimental effects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21155] New: SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21155 Bug ID: 21155 Summary: SwitchOnSiteCheckouts.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org https://jenkins.koha-community.org/job/Koha_18.05_D9/lastCompletedBuild/consoleFull koha_1 | # Failed test 'The date_due should have been set depending on the circ rules when the on-site checkout has been switched' koha_1 | # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 122. koha_1 | # got: '2018-08-03T23:59:00' koha_1 | # expected: '2018-08-08T23:59:00' koha_1 | # Looks like you failed 1 test of 10. koha_1 | [13:48:23] t/db_dependent/Circulation/SwitchOnSiteCheckouts.t koha_1 | Dubious, test returned 1 (wstat 256, 0x100) koha_1 | Failed 1/10 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21136] Error "No property select_city for Koha::Patron" when saving patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Depends on (and is caused by) but 20287 which is not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21129] New ALTER IGNORE TABLE entries need correction in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #8 from Martin Renvoize --- Affected DB updates only exist in master branch, no need to apply to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Julian Maurice changed: What|Removed |Added Attachment #74228|0 |1 is obsolete|| --- Comment #52 from Julian Maurice --- Created attachment 77471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77471&action=edit Bug 14716: URI-encode URLs in UNIMARC xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #51 from Julian Maurice --- (In reply to Katrin Fischer from comment #49) > Signing off for MARC21 - maybe someone else could take a look for UNIMARC? > Also tested that this fixes bug 16804. I prefer this solution. I confirm that the UNIMARC patch works too. I will attach the signed off patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Martin Renvoize --- This one is somewhat of a nightmare to backport. I'm going to hold off and see if there are any side effects in master before attempting a port. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #9 from Jonathan Druart --- root@a33753dce67d:/kohadevbox# for l in `head -n 100 DEBIAN/md5sums|tr -s ' ' | cut -d' ' -f2`; do ls "/$l" > /dev/null 2>&1; if [[ $? != 0 ]]; then echo $l; fi; done usr/share/doc/koha-common/LEEME.Debian usr/share/doc/koha-common/README.Debian usr/share/doc/koha-common/changelog.gz usr/share/doc/koha-common/history.txt usr/share/doc/koha-common/release_notes_3.txt.gz usr/share/doc/koha-common/release_notes_3alpha.txt.gz usr/share/doc/koha-common/release_notes_3beta.txt.gz usr/share/doc/koha-common/release_notes_3stableRC1.txt.gz usr/share/doc/koha-common/release_notes_30001.txt.gz usr/share/doc/koha-common/release_notes_30002.txt.gz usr/share/doc/koha-common/release_notes_30003.txt.gz usr/share/doc/koha-common/release_notes_30004.txt.gz usr/share/doc/koha-common/release_notes_30005.txt.gz usr/share/doc/koha-common/release_notes_3_10_0.txt.gz usr/share/doc/koha-common/release_notes_3_12_0.txt.gz usr/share/doc/koha-common/release_notes_3_14_0.txt.gz usr/share/doc/koha-common/release_notes_3_16_0.txt.gz usr/share/doc/koha-common/release_notes_3_18_0.txt.gz usr/share/doc/koha-common/release_notes_3_20_0.txt.gz usr/share/doc/koha-common/release_notes_3_22_0.txt.gz usr/share/doc/koha-common/release_notes_3_2_0.txt.gz usr/share/doc/koha-common/release_notes_3_4_0.txt.gz usr/share/doc/koha-common/release_notes_3_6_0.txt.gz usr/share/doc/koha-common/release_notes_3_8_0.txt.gz So yes, it's only the docdir, that's very weird. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Bug 21133 depends on bug 21087, which changed state. Bug 21087 Summary: Patron's password is hashed twice when the object is saved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #20 from Martin Renvoize --- Caused by bug 20287 which is not in 18.05.x series. Marking RESOLVED FIXED. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Add separate permission for managing suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #22 from Martin Renvoize --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Bug 19772 depends on bug 17698, which changed state. Bug 17698 Summary: Make patron notes show up on staff dashboard https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED --- Comment #72 from Martin Renvoize --- Enhancement, will not be backported to 18.05.x series. Great work though Aleisha, looks like a nice new feature to debut in 18.11.0! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03. Although it's an enhancement, it's a developer only one and aids in identifying causes for test failures so I decided it was worthwhile backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #7) > Tested the docker image, apt-get remote koha --purge, then: > > > root@a33753dce67d:/kohadevbox# apt-get install koha-common > Reading package lists... Done > Building dependency tree > Reading state information... Done > Suggested packages: > mysql-server | virtual-mysql-server letsencrypt > The following NEW packages will be installed: > koha-common > 0 upgraded, 1 newly installed, 0 to remove and 37 not upgraded. > Need to get 31.5 MB of archives. > After this operation, 470 MB of additional disk space will be used. > Get:1 http://apt.abunchofthings.net/koha-nightly unstable/main amd64 > koha-common all 18.06.01~git+20180803002557.c6b50f0b-1 [31.5 MB] > Fetched 31.5 MB in 13s (2,385 kB/s) > > debconf: delaying package configuration, since apt-utils is not installed > Selecting previously unselected package koha-common. > (Reading database ... 41209 files and directories currently installed.) > Preparing to unpack > .../koha-common_18.06.01~git+20180803002557.c6b50f0b-1_all.deb ... > Unpacking koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... > Setting up koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... > invoke-rc.d: could not determine current runlevel > invoke-rc.d: policy-rc.d denied execution of start. > Upgrading database schema for kohadev > root@a33753dce67d:/kohadevbox# > root@a33753dce67d:/kohadevbox# updatedb > root@a33753dce67d:/kohadevbox# locate history.txt > /kohadevbox/koha/docs/history.txt Yes somehow installing in the docker image we are using doesn't put the file where we expect it. This is not reproducible in a regular VM (vagrant init ubuntu/bionic64; vagrant up). I vote for actually setting to the git repo's history file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #7 from Jonathan Druart --- Tested the docker image, apt-get remote koha --purge, then: root@a33753dce67d:/kohadevbox# apt-get install koha-common Reading package lists... Done Building dependency tree Reading state information... Done Suggested packages: mysql-server | virtual-mysql-server letsencrypt The following NEW packages will be installed: koha-common 0 upgraded, 1 newly installed, 0 to remove and 37 not upgraded. Need to get 31.5 MB of archives. After this operation, 470 MB of additional disk space will be used. Get:1 http://apt.abunchofthings.net/koha-nightly unstable/main amd64 koha-common all 18.06.01~git+20180803002557.c6b50f0b-1 [31.5 MB] Fetched 31.5 MB in 13s (2,385 kB/s) debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package koha-common. (Reading database ... 41209 files and directories currently installed.) Preparing to unpack .../koha-common_18.06.01~git+20180803002557.c6b50f0b-1_all.deb ... Unpacking koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... Setting up koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... invoke-rc.d: could not determine current runlevel invoke-rc.d: policy-rc.d denied execution of start. Upgrading database schema for kohadev root@a33753dce67d:/kohadevbox# root@a33753dce67d:/kohadevbox# updatedb root@a33753dce67d:/kohadevbox# locate history.txt /kohadevbox/koha/docs/history.txt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 --- Comment #32 from Marcel de Rooy --- This was QAed in March, guys. We are in August now! Is this part of the "scare the last developers away" project or so ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21151] SRU search fields mapping pop-up comes up empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19436 CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Part of this fix is already in bug 19436. Waiting for a push too long already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21151 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 sandbo...@biblibre.com changed: What|Removed |Added Attachment #76332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #10 from sandbo...@biblibre.com --- Created attachment 77469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77469&action=edit Bug 19353: Add test Signed-off-by: Martin 357astný -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 sandbo...@biblibre.com changed: What|Removed |Added Attachment #76331|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #11 from sandbo...@biblibre.com --- Created attachment 77470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77470&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t Signed-off-by: Martin 357astný Signed-off-by: Martin 357astný -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #9 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Martin 357astný -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21151] SRU search fields mapping pop-up comes up empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 Owen Leonard changed: What|Removed |Added Attachment #77460|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77468&action=edit Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch. https://bugs.koha-community.org/show_bug.cgi?id=21141 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21151] SRU search fields mapping pop-up comes up empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21152] koha in ubuntu login shows as insecure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21152 Jonathan Druart changed: What|Removed |Added Group|Koha security | Component|Koha|Architecture, internals, ||and plumbing Product|Koha security |Koha Resolution|--- |INVALID Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun ||ity.org Status|NEW |RESOLVED QA Contact||testo...@bugs.koha-communit ||y.org --- Comment #1 from Jonathan Druart --- This message is displayed by your browser when you are filling a login form on a non-https URL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 --- Comment #7 from sandbo...@biblibre.com --- Created attachment 77467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77467&action=edit Bug 19909: Show attributes in patron search results Add a new column (hidden by default) in the results table which displays all attributes associated to the corresponding patron. New subroutine Koha::Patron::Attribute::display_value that returns the authorised value description and defaults to the raw value if the attribute's type is not associated to an authorised value category Test plan: 1. Create some patron attribute types, with and without an associated authorised value category 2. Choose an existing patron and set a value for each attribute 3. Go to patron search and do a search that will return your patron (and some others to avoid the redirection) 4. Show column 'Extended attributes' by clicking on 'Column visibility' button 5. Note that all attributes are displayed correctly 6. prove t/db_dependent/Koha/Patron/Attributes.t Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 sandbo...@biblibre.com changed: What|Removed |Added Attachment #77161|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #6 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 sandbo...@biblibre.com changed: What|Removed |Added Attachment #77139|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #5 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 --- Comment #6 from sandbo...@biblibre.com --- Created attachment 77466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77466&action=edit Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #77462|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 77465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77465&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 --- Comment #1 from Josef Moravec --- Created attachment 77464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77464&action=edit Bug 21154: Remove unused subs from C4::Serials Test plan: Run these commands, grep should not return any occurences, prove should return green: git grep GetSerialStatusFromSerialId git grep GetDistributedTo git grep SetDistributedTo git grep SetDistributedto git grep in_array git grep is_barcode_in_use kshell prove t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 Josef Moravec changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/