[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #162 from Charles Farmer --- I don't know how those 'sha1 information is lacking or useless' happen, but it made the stack of patches impossible to apply anywhere on the master tree, period. Since this is not really a rebase, I went ahead and remade that patch whole from one the that was up there. It should now apply cleanly without any manual intervention with the exact same code. Unfortunately, because that patch stood in the middle of the others, I had to reupload and obsolete the last half just to place the new one back in its right position. Sorry for the wall of text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77250|0 |1 is obsolete|| --- Comment #161 from Charles Farmer --- Created attachment 77613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77613&action=edit Bug 17015: Fixes to cronjob Fixes a typo in the add_days cronjob. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77249|0 |1 is obsolete|| --- Comment #160 from Charles Farmer --- Created attachment 77612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77612&action=edit Bug 17015: Fixes to migration script Fixes a few errors in the migration script. When first generation the discrete_calendar table, holidays should now be correctly imported for all branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #75479|0 |1 is obsolete|| --- Comment #158 from Charles Farmer --- Created attachment 77610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77610&action=edit Bug 17015: Improve stability for very old loans This patch fixes a crash when calculating fines for hourly loans created before the earliest date in the 'discrete_calendar' table. The SQL call has been altered to find the closest day (using DATEDIFF). QA Green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Luke Honiss changed: What|Removed |Added CC|luke.hon...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #76594|0 |1 is obsolete|| --- Comment #159 from Charles Farmer --- Created attachment 77611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77611&action=edit Bug 17015: Improved UI readability * The calendar tool page no longer shows past holidays in the lists on the right side of the page. * Improved wording in the "Hints" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74865|0 |1 is obsolete|| --- Comment #156 from Charles Farmer --- Created attachment 77608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77608&action=edit Bug 17015: Add gen_time to TestBuilder + Adds a gen_time() function to TestBuilder. TestBuilder now passes green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #75444|0 |1 is obsolete|| --- Comment #157 from Charles Farmer --- Created attachment 77609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77609&action=edit Bug 17015: Updated patch after bug 19204 This is a small modification to bring the patch up-to-date with current master after the changes made in 19204. Tests in db_dependent/Circulation.thave been changed slightly since DiscreteCalendar strictly prevents changing holidays in the past. This patch requires 20660. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74864|0 |1 is obsolete|| --- Comment #155 from Charles Farmer --- Created attachment 77607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77607&action=edit Bug 17015: Code quality fixes on QA feedback Changes: * Koha::DiscreteCalendar->new uses a hashref instead of a hash This meant changing every call to the Calendar and explains why this patch is so big. Most changes are simply adding braces to the new() call. + Added table encoding to atomic update + Added table definition to kohastructure.sql - Removed `repeatable_holidays`, `special_holidays` from kohastructure.sql Also added relevant DROP TABLEs to a new atomicupdate (part3) + Added 'override' param to Koha::DiscreteCalendar Without this param (off by default), edit_holiday will not modify past dates. This caused issues with some tests that required this functionality to work properly. Adding 'override => 1' to the function call will allow past dates to happen, but should only be called for testing. * Holds.t, Hold.t, CalcDateDue.t have been corrected. Prior to his patch, theses tests used hardcoded dates to test calendar functionalities, however, DiscreteCalendar is only usable one year into the past by default. They have been modified to be centered around '$today' * 'use strict; use warnings;' changed to 'use Modern::Perl;' in modified files. * Atomic update no longer takes params * Javascript moved to the bottom of discrete_calendar.tt * Calendar css moved out of tt file and into new discrete_calendar.css * All references to C4::Calendar and Koha::Calendar should now be removed * Some comments corrected All relevant tests passed for me on a fresh database. QA tool green. Test plan has not changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Charles Farmer changed: What|Removed |Added Attachment #75099|0 |1 is obsolete|| --- Comment #63 from Charles Farmer --- Created attachment 77606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77606&action=edit Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 --- Comment #2 from Katrin Fischer --- The problem is that $lang is send to the template from preferences.pl and overwrites the normal $lang variable. I *think* the variable is not used/never properly set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | --- Comment #6 from Alex Buckley --- Yup thanks Katrin looking now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #5 from Katrin Fischer --- Hi Alex, did you see my comment#3 here? Also, please don't forget to assign yourself to the bug :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #8 from Alex Buckley --- Created attachment 77605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77605&action=edit Bug 21173 - Customize age unit and starting point for automatic item modification by age tool and cronjob. This allows librarians to define either the item creation date or items last altered timestamp as the starting point for the age of the item so the autmatic_item_modification_by_age.pl can alter item fields for example for items which have been in the catalogue for a while. A use case for this functionality is: * When an items shelving location changes from 'In processing' to 'Shelving trolley' after 1 hour the status 'Shelving trolley' is removed for the item. The unit 'Hours' can now be set (extending the functionality of this cronjob from just calculating item age in days) and the age starting point of 'Last altered' can be defined so existing items in the catalogue like this example item will be altered by the cronjob. Test plan: 1. Go to Tools->Automatic item modifications by age and create a new rule by selecting the 'Edit rules' button 2. Notice you can only set the age in the unit of days not hours. Also alsthough not visible in the interface the rule will calculate the age of the item based on when it was created (i.e. added to Koha). 3. Apply patch and run ./updatedatabase.pl in the koha-shell 4. Now revisit Tools->Automatic item modifications by age. Notice the table of existing rules now contains a new column 'Age starting point' this is the date from which the item age is calculated. This enhancement offers you two options as the age starting point: Created (displayed in this table as 'itemcreated') or Last altered (displayed in this table as 'itemaltered'). 5. Click 'Edit rules' to create a new rule. Notice in the form for creating the new rule you can set the unit to either 'Hours' or 'Days'. When you select 'Days' then the Age starting point selection will appear where you can specify if you want the rule to work on the number of days since the item was last altered or number of days since the item was created. NOTE: If you select 'Hours' as the unit type when creating a new rule then the Age starting point selection area is hidden. This is because the item creation value is saved in the database as a date not a datetime. Therefore we cannot calculate the number of hours since the item was created in the Koha catalog. Therefore if the unit is set to 'Hours' then by default the item will use the item last altered value (stored as a date time) as the age starting point. For existing rules if they have the unit set to 'Hours' then the Age starting point area is hidden by default when the page loads. 6. In the new rule set the following values: Age: 1, Unit: Hours, condition items.location = 'CART', items.location = '' 7. Now save the rule and confirm the correct values are dispayed in the rules table which is loaded 8. Click 'Edit rules' button again. 9. Modify the rule you just created changing Age to 2 and create another new rule with the following values: Age='1', Unit='Days', 'Age starting point'='Created', Condition 'items.homebranch'='', substituions 'items.homebranch'='' 10. Now click 'Save' and confirm the data displayed for both rules is correct. 11. In the database manually set the location field of two items to 'CART' and set their timestamp value to 2 hours before the current time 12. Exit out of the database terminal and manually run the automatic_item_modification_by_age.pl cronjob from the koha-shell with this command: ./automatic_item_modification_by_age.pl --confirm 13. Now return to the database and notice the two items you set have a location of 'CART' now have a blank location field because the manually run cronjob altered them as they meet the conditions of the rule. 14. Repeat step 11 and enter this text into your /etc/cron.d/koha-common file: */2 * * * * root koha-foreach --enabled /usr/share/koha/bin/cronjobs/automatic_item_modification_by_age.pl --confirm This will make the cronjob run every 2 minutes. 15. Now restart koha-common with this command: sudo /etc/init.d/koha-common restart 16. Now wait for more than 2 minutes and check the database again and notice that the two items have blank location fields as the automatically running cronjob altered the items. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What|Removed |Added Attachment #77604|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #7 from Alex Buckley --- Hi Katrin Thanks for bringing the other inbuilt cart feature to my attention as I wasn't previously aware of it before writing this enhancement. I have just rebased the commits down to a single commit. I just have to obsolete the commit I just added as I noticed a template typo then it should be pretty close to being ready for being set to 'Needs signoff'. This commit and several others I have/am writing at the moment are for Toi Ohomai who you may have seen in the July community newsletter that they have recently gone live with Koha :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #6 from Katrin Fischer --- Hi Alex, not trying to block this one - as you said, it's a general feature that will allow for other things as well and I was not sure if you were away of the in-built cart feature that allows to return from cart to a former location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #4 from Alex Buckley --- Created attachment 77604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77604&action=edit Bug 21173 - Customize age unit and starting point for automatic item modification by age tool and cronjob. This allows librarians to define either the item creation date or items last altered timestamp as the starting point for the age of the item so the autmatic_item_modification_by_age.pl can alter item fields for example for items which have been in the catalogue for a while. A use case for this functionality is: * When an items shelving location changes from 'In processing' to 'Shelving trolley' after 1 hour the status 'Shelving trolley' is removed for the item. The unit 'Hours' can now be set (extending the functionality of this cronjob from just calculating item age in days) and the age starting point of 'Last altered' can be defined so existing items in the catalogue like this example item will be altered by the cronjob. Test plan: 1. Go to Tools->Automatic item modifications by age and create a new rule by selecting the 'Edit rules' button 2. Notice you can only set the age in the unit of days not hours. Also alsthough not visible in the interface the rule will calculate the age of the item based on when it was created (i.e. added to Koha). 3. Apply patch and run ./updatedatabase.pl in the koha-shell 4. Now revisit Tools->Automatic item modifications by age. Notice the table of existing rules now contains a new column 'Age starting point' this is the date from which the item age is calculated. This enhancement offers you two options as the age starting point: Created (displayed in this table as 'itemcreated') or Last altered (displayed in this table as 'itemaltered'). 5. Click 'Edit rules' to create a new rule. Notice in the form for creating the new rule you can set the unit to either 'Hours' or 'Days'. When you select 'Days' then the Age starting point selection will appear where you can specify if you want the rule to work on the number of days since the item was last altered or number of days since the item was created. NOTE: If you select 'Hours' as the unit type when creating a new rule then the Age starting point selection area is hidden. This is because the item creation value is saved in the database as a date not a datetime. Therefore we cannot calculate the number of hours since the item was created in the Koha catalog. Therefore if the unit is set to 'Hours' then by default the item will use the item last altered value (stored as a date time) as the age starting point. For existing rules if they have the unit set to 'Hours' then the Age starting point area is hidden by default when the page loads. 6. In the new rule set the following values: Age: 1, Unit: Hours, condition items.location = 'CART', items.location = '' 7. Now save the rule and confirm the correct values are dispayed in the rules table which is loaded 8. Click 'Edit rules' button again. 9. Modify the rule you just created changing Age to 2 and create another new rule with the following values: Age='1', Unit='Days', 'Age starting point'='Created', Condition 'items.homebranch'='', substituions 'items.homebranch'='' 10. Now click 'Save' and confirm the data displayed for both rules is correct. 11. In the database manually set the location field of two items to 'CART' and set their timestamp value to 2 hours before the current time 12. Exit out of the database terminal and manually run the automatic_item_modification_by_age.pl cronjob from the koha-shell with this command: ./automatic_item_modification_by_age.pl --confirm 13. Now return to the database and notice the two items you set have a location of 'CART' now have a blank location field because the manually run cronjob altered them as they meet the conditions of the rule. 14. Repeat step 11 and enter this text into your /etc/cron.d/koha-common file: */2 * * * * root koha-foreach --enabled /usr/share/koha/bin/cronjobs/automatic_item_modification_by_age.pl --confirm This will make the cronjob run every 2 minutes. 15. Now restart koha-common with this command: sudo /etc/init.d/koha-common restart 16. Now wait for more than 2 minutes and check the database again and notice that the two items have blank location fields as the automatically running cronjob altered the items. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #5 from Alex Buckley --- Hi Katrin Your right that with the use case outlined by Toi Ohomai they could indeed simply use the misc/cronjobs/cart_to_shelf.pl however that would require them to either ask a member of IT staff or their Koha support vendor to add/modify the number of hours since item last modified. Whereas this enhancement allows librarians to have control over this and provides scope for library staff to not just change item.location based on the number of hours since the item was modified but also many other conditions and substitutions are available to them. i.e. this gives librarians more control and lets them set many values other than items.location based on the number of hours or days since the item was last altered. What are your thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What|Removed |Added Attachment #77547|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What|Removed |Added Attachment #77548|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116
Benjamin Rokseth changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #5 from Benjamin Rokseth ---
Tested according to plan:
patched, added kitchen sink plugin, verified swagger schema and new 'contrib'
endpoint :
PUT /api/v1/contrib/kitchensink/patrons/{patron_id}/bother
gave expected result: {"bothered":true}
A very interesting and non-obtrusive approach to a common problem (feature
creep)!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 --- Comment #2 from Katrin Fischer --- Created attachment 77603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77603&action=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20994] Fix capitalization on OPAC result list "Save to Lists"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994 --- Comment #1 from Katrin Fischer --- Created attachment 77602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77602&action=edit Bug 20994: Fix capitaization "Save to Lists" On the OPAC result list, below each result, there is a link: "Save to Lists". Patch changes this to "Save to lists" following our capitalization rules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20994] Fix capitalization on OPAC result list "Save to Lists"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116 Benjamin Rokseth changed: What|Removed |Added Attachment #77274|0 |1 is obsolete|| --- Comment #4 from Benjamin Rokseth --- Created attachment 77601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77601&action=edit Bug 21116: Add API routes through plugins This patch adds plugins the capability of injecting new routes on the API. The plugins should provide the following methods to be considered valid API-generating plugins: - 'api_routes': returning the 'path' component of the OpenAPI specification corresponding to the routes served by the plugin - 'api_namespace': it should return a namespace to be used for grouping the endpoints provided by the plugin otherwise, they will be just skipped. All plugin-generated routes will be added the 'contrib' namespace, and will end up placed inside /contrib/, where is what the 'api_namespace' returns. A sample endpoint will be added to the Kitchen Sink plugin, and tests are being written. To test, wait a bit more for those samples :-D Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21026] Statistics tab in patron account should show descriptions instead of codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 Katrin Fischer changed: What|Removed |Added Assignee|katrin.fisc...@bsz-bw.de|koha-b...@lists.koha-commun ||ity.org Status|ASSIGNED|NEW --- Comment #1 from Katrin Fischer --- Sorry, no idea right now on how to fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21026] Statistics tab in patron account should show descriptions instead of codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 Katrin Fischer changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move serial enumeration to the right of callnumber on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move serial enumeration to the right of callnumber on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 --- Comment #3 from Katrin Fischer --- Created attachment 77600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77600&action=edit Bug 20896: Move serial enumeration after callnumber on intranet detail page The column with serial enumeration/chronology information is moved from the back to the right of itemcallnumber on the intranet detail page. To test: - Apply patch - Look at different detail pages in staff: - 1 or more items have serial enumeration information - no item has serial enumeration informatoin - Verify - itemcallnumber is now followed by serial information, if an item with the field filled in exists for the record - all other functionality, like sorting, works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move serial enumeration to the right of callnumber on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move serial enumeration to the right of callnumber on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Katrin Fischer changed: What|Removed |Added Summary|Move Serial enumeration to |Move serial enumeration to |the right of callnumber |the right of callnumber on ||staff detail page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #77597|0 |1 is obsolete|| --- Comment #21 from Charles Farmer --- Created attachment 77599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77599&action=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #74252|0 |1 is obsolete|| --- Comment #20 from Charles Farmer --- Created attachment 77598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77598&action=edit Bug18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #19 from Charles Farmer --- Created attachment 77597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77597&action=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #18 from Charles Farmer --- Thank you very much for you reply Owen. When you asked to change the keyword 'Intranet' to 'Staff client', were you talking about strings in the interface, or did you mean to go all the way and the change the syspref's name? I'll patch this right away. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move Serial enumeration to the right of callnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Katrin Fischer changed: What|Removed |Added Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167 --- Comment #2 from Katrin Fischer --- Created attachment 77596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77596&action=edit Bug 21167: Fix price formatting on printed fee invoice and receipt The prices were not formatted correctly on the printed receipts for fines and payments in the patron account. This patch introduces the use of the Price TT plugin to those templates. Also: - Fixes a few capitalization errors - Removes spaces in front of : - Updates accounttype-to-description list to the one used in other templats as a lot of values were missing (Credit etc.) To test: - Create several fines, use some .00 and some with other values - Pay some fines - Create a manual credit - Use print button for all of those (credit, fee, payment) - Verify that: - prices ending in .00 are displayed without the decimal part - instead of Credit only C is shown in the description - Apply patch - Print invoices and receipts again - Verify that: - prices are now formatted according to CurrencyFormat system preference, decimal part always included - verify that correct description for Credit is shown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #416 from Nick Clemens --- (In reply to Nick Clemens from comment #415) > Created attachment 77595 [details] [review] > Bug 7143: Update timeline (2 new devs) Pushed to master for 18.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21163] Basket group detail page layout is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21151] SRU search fields mapping pop-up comes up empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21149] Administrator creation in onboarding always fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21145] The "Column visibility" button should not be displayed at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167 Katrin Fischer changed: What|Removed |Added Summary|Printing fines on fee |Correct price formatting on |receipt -- amounts ending |printed fee receipt and |in 0 are truncated |invoice Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #415 from Nick Clemens --- Created attachment 77595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77595&action=edit Bug 7143: Update timeline (2 new devs) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #77549|0 |1 is obsolete|| --- Comment #4 from Alex Buckley --- Created attachment 77594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77594&action=edit Bug 21159 - Implementing 2 sysprefs to enable blanking location This patch introduces two new system preferences: BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By default both are off. If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's shelving location 952$c field will be set to '' in C4::Items->BlankShelvingLocation() If BlankingShelvingLocationOnReturn is enabled then when an item is returned it's shelving location field will be set to '' in C4::Items->BlankShelvingLocation(). t/db_dependent/Circulation/issue.t contains tests for BlankShelvingLocationOnIssue t/db_dependen/Circulation/Returns.t contains tests for BlankShelvingLocationOnReturn Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added two new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn both of which are off by default) 5. Notice the shelving location has not changed, showing with the BlankShelvingLocationOnReturn syspref not enabled the shelving location is not changed upon return 6. Check the item out again and notice the shelving location is not changed, showing that when the BlankShelvingLocationOnIssue is not enabled the shelving location is not changed upon issue. 7. Enable both aforementioned sysprefs in the Administration->Global system preferences->Circulation interface 8. Return the item and notice the Shelving location has changed from 'Cart' to no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it blanks the shelving location value on the return of the item 9. Edit the item changing the shelving location back to 'Shelving Trolley'(CART) 10. Check out the item and notice the shelving location is changed to no value, showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the shelving location on the issue of an item. 11. Run t/db_dependent/Circulation/Returns.t 12. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21167] Printing fines on fee receipt -- amounts ending in 0 are truncated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167 Katrin Fischer changed: What|Removed |Added Summary|Printing fines on patron|Printing fines on fee |account tab -- amounts |receipt -- amounts ending |ending in 0 are truncated. |in 0 are truncated CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 --- Comment #3 from Benjamin Rokseth --- Tomas PM'ed me on this and I briefly explained that we use the code, though heavily modified, in production. We add a Koha::Sync object and some logic, mostly to handle flaky implementation by the vendors of the sync endpoint, but I still believe it would better reside outside Koha community code, preferably as a module to koha core. Tomas argued for a plugin and I guess that would be a similar choice but faster to implement. I dont think the community should be burdened with this kind of perifery functionality, especially since it migh be legacy at some point, and noone might notice. If we're the only ones using it, I'd say better remove it from community code and let us struggle with the implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19436 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12747 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #28 from Nick Clemens --- I talked with enough people to agree this must be optional - will provide a followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19870] Loaned items show as available unless logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870 Mason James changed: What|Removed |Added Attachment #70095|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19870] Loaned items show as available unless logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870 Mason James changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19870] Loaned items show as available unless logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870 Mason James changed: What|Removed |Added Attachment #70095|0 |1 is obsolete|| --- Comment #8 from Mason James --- Created attachment 77593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77593&action=edit Bug 19870: Loaned items show as available unless logged in small typo fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Charles Farmer changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Charles Farmer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #18 from Charles Farmer --- Created attachment 77592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77592&action=edit Bug 7468 - (follow-up) Make sure only integers are accepted as from/to values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #17 from Charles Farmer --- (In reply to Jovana Dunisijevic from comment #15) > Hi everyone, > > This is what we are trying to do, which is similar to your idea, David. > Our idea is to preprint barcodes, given the starting barcode value and the > number/amount of barcodes that will be printed. With additional verification > as to check if one of the new barcodes haven't already been used. > > I am already working on this. Would like to hear some thoughts about it. Do you have any links to that patch? A BZ number? You're more than welcome to submit additional changes to this bug, but as it is right now, we're following the original usecase of the client who sponsored this development, and I don't see myself swerving too far off what we already have here. (In reply to Hugo Agud from comment #16) > The patch applies fine > > 1. It prints propertly the range of barcode > 2. It warns you if you use a to smaller than from > 3. BUT doesn't warn you if you use non-numeric... it allow you to write A, > B, C or A1000 to A2... it only pop up a blank pdf Well, it *kinda* warns you by highlighting the whole input box in red if you don't follow the defined type, but I get what you mean. Another patch coming up for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] Series link is only using 800a instead of 800t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 --- Comment #7 from Katrin Fischer --- I wonder if I made a thinking error here when we talked about it. We look for the series title in ser - which should work ok. But looking for the author in au probably shouldn't work. 800$a is not in the au index: 1047 1048 Name-and-title:w 1049 Title-series:w 1050 Title-series:p 1051 1053 1054 Author-title:w 1055 Name-and-title:w 1056 Title:w 1057 Title-series:w 1058 Title-series:p 1059 ... but it does kind of work... which is odd. Maybe as both are in Title-series it should be something like: localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=se,phr&q=+Martin%2C+Robert+C.&op=and&idx=se,phr&q=Robert+C.+Martin+series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19325] Enable padding of printed barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Charles Farmer --- (In reply to M. Tompsett from comment #7) > Why have an enabled AND length? If the length is 0, then what is the point > of enabled? I agree with you, we definitely could get rid of the property if the BarcodePaddingLength's description makes it clear that a value of 0 disables that part of the code. (In reply to Julian Maurice from comment #9) > Why new system preferences ? Shouldn't it be configurable at the layout > level ? It depends. If you have multiple employees doing this repeatedly, and you wanna make sure everything prints out the same way every time, it makes sense to offer a syspref instead of forcing users to enter values over and over, especially if the defaults aren't what they need. Usability-wise, I think there's merit to the sysprefs, but I can see why someone who prints barcodes once every blue moon wouldn't want to clutter its database with additional preferences. --- I did an in-between for now: removed the BarcodePaddingEnable pref, and changed the BarcodePaddingLength's description to imply that a value of 0 disables padding. If you say three times that the sysprefs have to go, I'll make it configurable at the template level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19325] Enable padding of printed barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325 --- Comment #11 from Charles Farmer --- Created attachment 77591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77591&action=edit Bug 19325: (QA follow-up) Remove a syspref, change the backend accordingly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21186] New: Incorrect Bootstrap modal event name in multiple templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186
Bug ID: 21186
Summary: Incorrect Bootstrap modal event name in multiple
templates
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
When we upgraded Bootstrap in the staff client we missed updating some
references to Bootstrap's "hidden" event. It should now be "hidden.bs.modal."
$("#marcPreview").on("hidden.bs.modal", function(){
// Action triggered when modal is closed
});
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 --- Comment #2 from Jonathan Druart --- Created attachment 77590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77590&action=edit Bug 21184: Remove GetBarcodeFromItemnumber Test plan: git grep GetBarcodeFromItemnumber should not return anything -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 --- Comment #1 from Jonathan Druart --- Created attachment 77589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77589&action=edit Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with my $barcode = Koha::Items->find($itemnumber)->barcode; But if we are not sure that the item exists, we should test the return of ->find before ->barcode Test plan: - Edit an item - Check an item in - Test SIP - I do not really know how to trigger that code, apparently misc/sip_cli_emulator.pl does not deal with holds. Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 --- Comment #1 from Owen Leonard --- Created attachment 77588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77588&action=edit Bug 21185: Incorrect title tag on tags review page This patch corrects the title tag on the tags review page. To test, apply the patch and go to Tools -> Tags. The page title (probably shown in the browser tab) should start with "Koha ->" instead of "Home ->". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] New: Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 Bug ID: 21185 Summary: Incorrect title tag on tags review page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The tags review page title starts with "Home ->" instead of "Koha ->" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Blocks||21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Depends on||21183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What|Removed |Added Depends on||21184 --- Comment #7 from Jonathan Druart --- Bug 21184 - C4::Items - Remove GetBarcodeFromItemnumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] New: C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Bug ID: 21184 Summary: C4::Items - Remove GetBarcodeFromItemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org my $barcode = GetBarcodeFromItemnumber($itemnumber); will become: my $barcode = Koha::Items->find($itemnumber)->barcode; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
--- Comment #1 from Jonathan Druart
---
Created attachment 77586
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77586&action=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #2 from Jonathan Druart --- Created attachment 77587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77587&action=edit Bug 21183: Remove GetItemnumberFromBarcode Test plan: git grep GetItemnumberFromBarcode should not return anything -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #221 from Owen Leonard --- I did what I hope was a fairly thorough test of the staff client and found these issues: - IntranetCirculationHomeHTML displays HTML tags as text - Patron title include showing HTML: Mr- Patron details -> Holds tab: Alerts data from the branches table - Search results page layout is broken. Looks like page-numbers.inc has a section missing. - Crazy encoding of action buttons on Lists page - Incorrectly escaped HTML in Notices & slips list - Label batch list title encoding wrong - Spine label print shows HTML - Administration -> Libraries: Alerts data from the branches table - Administration -> Item types: Alerts data from the items table - Item searching broken: "Unsupported format html at /home/vagrant/kohaclone/catalogue/itemsearch.pl line 42." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] Series link is only using 800a instead of 800t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 --- Comment #6 from Katrin Fischer --- Hi Caroline, can you share how the links look like behind the series entry? I wonder if it might have something to do with us not properly escaping things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13692] Series link is only using 800a instead of 800t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|series link is taking you |Series link is only using |to just 800a instead of |800a instead of 800t |whole 800 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20610] Add BULAC to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20610 --- Comment #9 from Katrin Fischer --- Hi Claire, sorry to be late here! Catching up never seems to end... A little info on the Sponsored-by line to go into the commit message is here: https://wiki.koha-community.org/wiki/Commit_messages#Sponsor_line I've added the topic of adding the sponsored-by libraries to the about page (semi)automatically to the agenda of the next general IRC meeting: https://wiki.koha-community.org/wiki/General_IRC_meeting_5_September_2018#Agenda Hope this will help move things forward :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21182] acqui/check_duplicate_barcode_ajax.pl is not longer in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Jonathan Druart changed: What|Removed |Added Blocks||21183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Depends on||21182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 [Bug 21182] acqui/check_duplicate_barcode_ajax.pl is not longer in use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] New: C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Bug ID: 21183
Summary: C4::Items - Remove GetItemnumberFromBarcode
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.dru...@bugs.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What|Removed |Added Depends on||21183 --- Comment #6 from Jonathan Druart --- Bug 21183 - C4::Items - Remove GetItemnumberFromBarcode Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Charles Farmer changed: What|Removed |Added Attachment #71976|0 |1 is obsolete|| --- Comment #36 from Charles Farmer --- Created attachment 77585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77585&action=edit Bug 11373: Follow-up after code review -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Charles Farmer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Charles Farmer changed: What|Removed |Added Attachment #71975|0 |1 is obsolete|| --- Comment #35 from Charles Farmer --- Created attachment 77584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77584&action=edit Bug 11373: Add a "cash register" feature to the fine payment form. Works as intended. Signed-off-by: Simon Pouchol -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
