[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||joonas.kylm...@helsinki.fi

--- Comment #32 from Joonas Kylmälä  ---
I was trying to test these patches but they don't apply on top of latest
master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #92 from Katrin Fischer  ---
Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How to
fix? CPAN?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #91 from Katrin Fischer  ---
There is something not quite right with the default URL and mappings. We have
since removed the chapter numbers from the file names in Sphinx, but the
patches seem to link to an outdated version of the manual:

https://koha-community.org/manual/18.05/en/html/09_acquisitions.html#acquisition-searches

vs correct:

https://koha-community.org/manual/18.05/en/html/acquisitions.html#acquisition-searches

Have to stop working on this for now, hope to be back later today. If you beat
me to fixing this. I'd not be unhappy about it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21223] Some floating values are wrong

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21223

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
Needs bug 21222 for testing right now (patron creation broken)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21223] Some floating values are wrong

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21223

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77813|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 77873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77873&action=edit
Bug 21223: Fix some floating values

See description of the bug for screenshots

I do not really know why we have these issues, but maybe we should
regenerate the .scss in order to catch the other problems?

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21223] Some floating values are wrong

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21223

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
Assignee is missing - Marcel or Martin? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70638|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 77872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77872&action=edit
Bug 20014: Preselect item budget based on id not code

To test:
1 - Have the same fund code in two budgets
2 - Have budget code defined in MarcItemFieldsToOrder
3 - Stage a file with some order items as defined above
4 - Inspect the fuinds drop down in the item, notice two lines are
marked selected
5 - Apply patch
6 - Repeat
7 - Only one field should be selected, with a preference for active
budget

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #10 from Katrin Fischer  ---
Wish our code was less confusing - budget should be fund.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #9 from Katrin Fischer  ---
If I am not mistaken it will use the last added fund from an active budget when
you have multiple active budgets with the same fund codes. This might still
cause a surprise for people with a strange budget/fund creation history, but I
don't see a better way to pick 'one' fund.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21159

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21173

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #13 from Alex Buckley  ---
Created attachment 77871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77871&action=edit
Bug 21159 - Corrected typo

Same test plan as first patch.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #12 from Alex Buckley  ---
I think this one is ready to test. 

It is building on (depends on) the functionality provided by 14576. Many thanks
to Katrin for informing me about 14576 so I was able to remove the duplicated
functionality that my original patch had. 

This new patch does not deal with automatically updating the item location when
the item is returned as this is covered by 14576. 

Instead, this new commit blanks out the items.location field when the item is
checked out if the UpdateItemLocationOnCheckout syspref is enabled. This makes
an easier workflow for automatically removing the items.location value if the
item is issued. 

Please let me know if further changes are required :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #11 from Alex Buckley  ---
Created attachment 77870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77870&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley  changed:

   What|Removed |Added

  Attachment #77869|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #10 from Alex Buckley  ---
Created attachment 77869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77869&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley  changed:

   What|Removed |Added

  Attachment #77859|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21219] NULL values in updated_on field break the Patrons REST API

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21219

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
Version|18.05   |master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Katrin Fischer  changed:

   What|Removed |Added

Summary|When adding to basket from  |When adding to basket from
   |a staged file item budgets  |a staged file item budgets
   |are selected my matching on |are selected by matching on
   |code, not id|code, not id
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #83 from Katrin Fischer  ---
I've fixed the commit messages Bug : instead of Bug  -. I've also added
a tiny follow-up to fix the styling of the button and the wrong number of
tests.

Generally this works well, so I am signing off.

Things to improve:
- When deleting multiple issues and one is expected, the expected one is not
deleted, which is, I think, the correct behaviour. Without the expected issue
the subscription would no longer work correctly. But we could improve the
visual by warning the user maybe.
- When deleting issues that have no items yet, you are still offered the option
to delete items with them (Status late for example). Nothing bad happens, so
not blocker for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #81 from Katrin Fischer  ---
Created attachment 77867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77867&action=edit
Bug 17674: (follow-up) Fix some HTML and JS inconsistencies

This patch makes some HTML and JS changes to make the template more
consistent with coding guidelines and other similar interfaces.

- The confirmation dialog is now below the heading. Buttons are styled
  to match others like them. The layout of messages hopefully makes it a
  little more clear.
- The "delete selected" event handler has been moved from an "onclick"
  attribute into the 

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #82 from Katrin Fischer  ---
Created attachment 77868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77868&action=edit
Bug 17674: (follow-up) Fix wrong number of tests, make button match visually

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #80 from Katrin Fischer  ---
Created attachment 77866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77866&action=edit
Bug 17674: Renamed GetSerialItemsInformations to get_serial_items_count and use
new OOP logic

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77745|0   |1
is obsolete||
  Attachment #77746|0   |1
is obsolete||
  Attachment #77747|0   |1
is obsolete||
  Attachment #77748|0   |1
is obsolete||
  Attachment #77749|0   |1
is obsolete||
  Attachment #77750|0   |1
is obsolete||
  Attachment #77751|0   |1
is obsolete||

--- Comment #75 from Katrin Fischer  ---
Created attachment 77861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77861&action=edit
Bug 17674: Allow UI to delete serials in batch

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Testing
- Have at least three serials, with items
- check the box to select two of them
- Press the Remove selected issues button
- Decide to delete their items as well or not
- Validate.

Sponsored by : CCSR

Signed-off-by: Sonia BOUIS 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #77 from Katrin Fischer  ---
Created attachment 77863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77863&action=edit
Bug 17674: Add unit tests

https://bugs.koha-community.org/show_bug.cgi?id=17674

Signed-off-by: Sonia BOUIS 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #79 from Katrin Fischer  ---
Created attachment 77865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77865&action=edit
Bug 17674: Adapting Serials.t to the namespace change

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #76 from Katrin Fischer  ---
Created attachment 77862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77862&action=edit
Bug 17674: Fix problem tabs

Signed-off-by: Sonia BOUIS 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #78 from Katrin Fischer  ---
Created attachment 77864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77864&action=edit
Bug 17674: Move subroutine GetSerialItemsInformations to Koha/Serials.pm

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500

--- Comment #7 from Katrin Fischer  ---
Thought a bit more about it - adding the spans will help translation more, as
it will make them match with the strings from the pull down list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500

--- Comment #6 from Katrin Fischer  ---
Created attachment 77860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77860&action=edit
Bug 19500: (QA follow-up) Add spans to ease translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #9 from Alex Buckley  ---
Created attachment 77859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77859&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley  changed:

   What|Removed |Added

  Attachment #5|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21068] Remove NorwegianPatronDB related code

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #12)
> If I read it right Magnus didn't say that they weren't using it? Just he was
> not opposed to change it into a plugin. I'd like to clarify that before we
> move on here.

My understanding is that Oslo was the one using it, and they are currently
using a highly customized version of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21068] Remove NorwegianPatronDB related code

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |In Discussion

--- Comment #12 from Katrin Fischer  ---
If I read it right Magnus didn't say that they weren't using it? Just he was
not opposed to change it into a plugin. I'd like to clarify that before we move
on here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #31 from Jonathan Druart  
---
Quick notes:
1. We hit the same problem as local cover on bug 19511
2. FIXME in .js, but copied from the OPAC one (not blocker)
3. Will fail tests bug 13618 is going to add (should be pushed very soon).
Filters are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #30 from Jonathan Druart  
---
Charles, you can discuss any "failures" from the QA checks. It is hard to test
all the situations without false positives.

Here, as Katrin said, we prefer to not add and remove a file in the same
patchset. RM or QA will squash the patches if it is really needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21231] New: BlockReturnofLostItems does not prevent lost items being found

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21231

Bug ID: 21231
   Summary: BlockReturnofLostItems does not prevent lost items
being found
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When the syspref BlockReturnOfLostItems is set to Block, the item is blocked
from being returned, but is still considered found -- it's set to lost=0 and a
refund is applied to the patron (if circ rules allow). The item can then be
checked in a second time and returned as it is no longer lost.

To test:
- set an item to lost
- set BlockReturnOfLostItems to Block
- check the lost item in
- Koha says item cannot be returned but also item was lost, is now found
- check the item in again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77716|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 77857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77857&action=edit
Bug 19991: use Modern::Perl in OPAC perl scripts

Test Case:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

errors/400.pl
errors/401.pl
errors/402.pl
errors/403.pl
errors/404.pl
errors/500.pl
opac-account-pay-paypal-return.pl
opac-alert-subscribe.pl
opac-authorities-home.pl
opac-authoritiesdetail.pl
opac-browser.pl
opac-ics.pl
opac-image.pl
opac-imageviewer.pl
opac-messaging.pl
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.pl
opac-overdrive-search.pl
opac-passwd.pl
opac-patron-image.pl
opac-privacy.pl
opac-ratings-ajax.pl
opac-ratings.pl
opac-readingrecord.pl
opac-renew.pl
opac-sendshelf.pl
opac-serial-issues.pl
opac-showreviews.pl
opac-suggestions.pl
opac-tags_subject.pl
opac-topissues.pl
opac-user.pl
sco/help.pl
sco/printslip.pl
sco/sco-patron-image.pl
svc/overdrive_proxy
svc/suggestion
unapi

Signed-off-by: Maryse Simard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991

--- Comment #7 from Jonathan Druart  
---
Created attachment 77858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77858&action=edit
Bug 19991: Remove warning from opac-user

Use of uninitialized value in split at
/home/vagrant/kohaclone/opac/opac-user.pl line 78.

Use of uninitialized value $search_query in string ne at
/home/vagrant/kohaclone/opac/opac-user.pl line 367.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #61 from Kyle M Hall  ---
Created attachment 77855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77855&action=edit
Bug 7534: Fix number of tests for Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #62 from Kyle M Hall  ---
Created attachment 77856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77856&action=edit
Bug 7534: Disambiguate branchcode parameter, make it match between subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #60 from Kyle M Hall  ---
Created attachment 77854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77854&action=edit
Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl

To test:
-1. Have access to your browser's developer tools in order to modify 
dropdown values
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No". Remember the
   branchcode of this library!
3. Go place a hold in OPAC
4. See the provided "Pick up location" list
5. Observe the library that you configured is not present in the list
6. You should see another library selected by default. Right click that and
   in Firefox/Chrome click "Inspect element"
7. You should see a list of blabla elements
8. Double click between value ( in above example) and replace the value
   with the branchcode you remember from step 2.
9. Place the hold
10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold
was not successful.
11. Go back to place a hold and this time do not modify any values.
12. Observe that a hold is now placed.

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #58 from Kyle M Hall  ---
Created attachment 77852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77852&action=edit
Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new
library

To test:
1. Apply the patches before this one
2. Go to /cgi-bin/koha/admin/branches.pl
3. Press New library button
4. Scroll down the page and observe Pickup location defaults to No
5. Apply this patch
6. Go to /cgi-bin/koha/admin/branches.pl
7. Press New library button
8. Scroll down the page and observe Pickup location now defaults to Yes

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #59 from Kyle M Hall  ---
Created attachment 77853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77853&action=edit
Bug 7534: Validate pickup location in CanBook/ItemBeReserved

This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold.

To test:
1. prove t/db_dependent/Holds.t

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #56 from Kyle M Hall  ---
Created attachment 77850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77850&action=edit
Bug 7534: Display pickup locations instead of all libraries in request.pl

This patch sets request.tt to use the list of pickup libraries instead
of every library in the system.

To test:
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No"
3. Go place a hold in intranet
4. See the provided "Pickup at" list
5. Observe the library that you configured is not present in the list
6. Place the hold
7. See list of existing holds on that biblio
8. See "Pickup library" column and observe your configured library is
   not included in the list

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #57 from Kyle M Hall  ---
Created attachment 77851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77851&action=edit
Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl

This patch sets opac-reserve.tt to use the list of pickup libraries instead
of every library in the system.

To test:
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No"
3. Go to OPAC and place a hold
4. See the provided Pickup location list
5. Observe the library that you configured is not present in the list

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #55 from Kyle M Hall  ---
Created attachment 77849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77849&action=edit
Bug 7534: Add configuration to admin/branches.pl

This patch adds a configuration option for pickup locations.

To test:
1. Apply patch
2. Go to cgi-bin/koha/admin/branches.pl
3. Observe there is a new column "Pickup location"
4. Click "Edit" for any library
5. Scroll to bottom of the page and select "No"
6. Click "Submit"
7. Observe your library in Libraries-table, notice the value of "Pickup
location"
   has changed to "No"

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #54 from Kyle M Hall  ---
Created attachment 77848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77848&action=edit
Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all

This lets us query libraries with additional search parameters and is useful
for this particular Bug by allowing us to select pickup locations.

Unit tests included.

To test:
1. prove t/db_dependent/Template/Plugin/Branches.t

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #61273|0   |1
is obsolete||
  Attachment #61274|0   |1
is obsolete||
  Attachment #61275|0   |1
is obsolete||
  Attachment #61276|0   |1
is obsolete||
  Attachment #61277|0   |1
is obsolete||
  Attachment #61278|0   |1
is obsolete||
  Attachment #61279|0   |1
is obsolete||
  Attachment #61280|0   |1
is obsolete||

--- Comment #53 from Kyle M Hall  ---
Created attachment 77847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77847&action=edit
Bug 7534: Add new column "pickup_location" to branches

This patch adds a new column "pickup_location" for each library. This value
defines whether a library can be used as a pickup location or not.

For extended configurability, this flag could perhaps be considered as a part
of issuing rules, but as of now, this patch only offers a simple flag into
each library. This method also allows easy way for REST API to determine valid
pickup locations by querying the /libraries endpoint.

To test:
1. perl installer/data/mysql/updatedatabase.pl
2. Observe
DEV atomic update: bug_7534.perl
Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup
locations)

https://bugs.koha-community.org/show_bug.cgi?id=7354

Signed-off-by: Koha Team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #31 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #20)
> (In reply to Jonathan Druart from comment #17)
> > When there is a match:
> > https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org
> > 
> > When there is no match:
> > https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org
> > 
> > The "Acquisitions preferences" h2 is display under the toolbar (I have
> > selected the text to show it on the screenshot.
> 
> I have no idea how to fix that. I have also noticed that fixFloat duplicate
> the toolbar node (one is hidden), and so we should not have an id on them.
> 
> Passing QA as it is a minor ergonomic issue.

Hum, I have posted twice the same link!
When there is no match:
https://screenshots.firefox.com/E2ey9Akb68rPHngV/pro.kohadev.org

This is still valid, but minor and can be pushed as it IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #30 from Jonathan Druart  
---
I have found a small regression added by the toolbar changes (bug 21139), RM
please push the follow-up I have attached on it along with these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #28 from Jonathan Druart  
---
Created attachment 77845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77845&action=edit
Bug 20935: Remove "Click to" from some links

Changes "Click to edit" and "Click to collapse" to just
"Edit" and "Collapse" as the "Click to" appears not
necessary for elements formatted as links.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #29 from Jonathan Druart  
---
Created attachment 77846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77846&action=edit
Bug 20935: Remove 'no match' box when it does

Test plan:
Hit /cgi-bin/koha/admin/preferences.pl
Search for "AcqCreateX"
=> You get "No matching terms were found on this page"
Remove the last X
=> Without this patch the "no matching" box is still displayed

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77707|0   |1
is obsolete||
  Attachment #77708|0   |1
is obsolete||
  Attachment #77709|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart  
---
Created attachment 77844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77844&action=edit
Bug 20935: Redesign system preferences interface

This patch proposes a new interface for system preferences. The goal is
to make the interface more readable and to give the user additional
options for finding what they need.

- Restructures the preferences list as a , with the preference name
  as the  and the description as the .
- Add a JS filter library (mark.js) to do live filtering of the page and
  add search term highlighting.
- When the user has searched, show links to the sections in which
  results were returned.

To test, apply the patch and go to Administration -> System preferences.

 - Test the functionality of setting various kinds of preferences,
   including multi-selects, textareas, WYSIWYG editors, etc.
 - Test the filter form at the top of the page for narrowing in-page
   results.
   - Test both successful and unsuccessful filters.
 - Perform a system preference search.
   - Test the in-page links to the different sections.
   - Test that in-page filtering works in this case too.
 - View the licenses tab of the "About" page and check that the
   information about mark.js looks correct.

Followed test plan and pleased to say everything worked as expected.
Looking forward to this enhancement.

Signed-off-by: Dilan Johnpullé 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21139] The floating toolbars have some issues

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139

--- Comment #17 from Jonathan Druart  
---
Created attachment 77843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77843&action=edit
Bug 21139: (follow-up) Floating toolbars - Remove unecessary height

Found where QAing bug 20935, we actually want the hidden toolbar to be
the exact same height as the visible one.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20994] Fix capitalization on OPAC result list "Save to Lists"

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20994] Fix capitalization on OPAC result list "Save to Lists"

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77619|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 77842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77842&action=edit
Bug 20994: Fix capitaization "Save to Lists"

On the OPAC result list, below each result, there is a link:
"Save to Lists".

Patch changes this to "Save to lists" following our
capitalization rules.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77457|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 77841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77841&action=edit
Bug 21144: Add ROADTYPE to default authorised values categories

The ROADTYPE category was missing from the default list of
authorised value categories available.

To test:
- Verify ROADTYPE is not listed as authorised value category
- Apply patch and run database update
- Verify ROADTYPE is now listed
- Add an entry, for example: AV = Avenue
- Add or edit a patron, verify a pull down with your entry
  shows on the form.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||17216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144
[Bug 21144] ROADTYPE missing from authorised value categories list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500

--- Comment #5 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #4)
> Should not we surround the strings with spans?

We could, but it's not necessary. The text will show up in the po file, because
it's inside a parsed html element: 
It will show up as one string, which can be good sometimes as it means you have
more context.

If we add  tags, they will all show up separately and might get merged
with existing translations. So both versions have advantages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19511] Local cover images not centered in table column in staff client search results

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19511] Local cover images not centered in table column in staff client search results

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77812|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 77840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77840&action=edit
Bug 19511: Local cover images not centered in table column in staff client
search results

This patch modifies the JavaScript which embeds local cover images in
staff client catalog search results. It now adds the "thumbail" class to
the image, matching Amazon cover images.

To test you should have one or more titles with local cover images
attached. Apply the patch and clear your browser cache if necessary.

Enable both the AmazonCoverImages and LocalCoverImages system
preferences and perform a search which will return titles with local
cover images. Confirm that local covers are styled like Amazon covers.

Tested and confirmed local cover images are appearing quite nicely now.
Signed-off-by: Dilan Johnpullé 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Should not we surround the strings with spans?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17978] Circ rules will not limit holds

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13802] Renewals ignore hard due dates

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13802

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21068] Remove NorwegianPatronDB related code

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

Jonathan Druart  changed:

   What|Removed |Added

Summary|NorwegianPatronDBEnable -   |Remove NorwegianPatronDB
   |Check for prior ModMember   |related code
   |calls that passed 'sync'|
   Assignee|mag...@libriotech.no|jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

--- Comment #10 from Jonathan Druart  
---
Created attachment 77838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77838&action=edit
Bug 21068: Remove NorwegianPatronDB related code

Bug 11401 introduced code to support Norwegian national library card.
This code is too specific to be part of Koha as it, it should be a
plugin instead.
Moreover nobody uses it, but a modified version (see comment 3).

Test plan:
Add/edit/delete patron and make sure there are no regressions introduced
by these patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

--- Comment #11 from Jonathan Druart  
---
Created attachment 77839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77839&action=edit
Bug 21068: DB changes

The update DB entry will not remove the prefs if NorwegianPatronDBEnable
is set.
This patch could be reverted locally by people using it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21230] Reserves.t is failing randomly

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21230

--- Comment #1 from Jonathan Druart  
---
Created attachment 77837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77837&action=edit
Bug 21230: Prevent Reserves.t to fail randomly

The following test can fail if the hold has been generated with found => 'W':
 #   Failed test 'No tests run for subtest "_koha_notify_reserve() tests"'
 #   at t/db_dependent/Reserves.t line 675.
Can't call method "to_address" on an undefined value at
t/db_dependent/Reserves.t line 661.
 # Looks like your test exited with 255 just after 56.

We should call AddReserve instead.

Test plan:
0. Do not apply this patch
1. Do the following change:
my $hold = $builder->build({
source => 'Reserve',
value => {
   borrowernumber=>$hold_borrower,
   found => 'W', # This line is added, do not forget the comma
above
}
});
2. Prove it makes the test fail
3. stash the changes and apply this patch
4. Make sure the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21230] Reserves.t is failing randomly

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21230

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||12681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681
[Bug 12681] Shibboleth attributes may contain lists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||18507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507
[Bug 18507] Shibboleth auto-provisioning - Sync
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312

Pierre-Luc Lapointe  changed:

   What|Removed |Added

  Attachment #77769|0   |1
is obsolete||
  Attachment #77796|0   |1
is obsolete||

--- Comment #13 from Pierre-Luc Lapointe  ---
Created attachment 77835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77835&action=edit
Bug 20312: Add a link to last consulted patron

This new feature adds a link to the last patron consulted
in the staff site. It uses cookies to save this information.
When a staff site user accesses a patron record, the ID, name
and card number of the patron will be saved in the cookie.

To test:
1- Apply the patch
2- Go to a patron details' page
3- Verify that the link "Last patron" appears on the top-right
   corner of the screen
4- Go to another page
5- The link should still be here
6- Click on the link
7- Verify that you are at the patron's checkout page
8- Click on the "X" button next to the "Last patron" link
9- The link should be gone
10- Go to another page
11- The link shouldn't appear (until the next patron detail's
page)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77832|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 77836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77836&action=edit
Bug 21226: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77831|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 77834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77834&action=edit
Bug 21226: Remove xISBN services

OCLC has decided to retire all xISBN services:
https://www.oclc.org/developer/news/2018/xid-decommission.en.html

The code for related features has to be removed from Koha.

Test plan:
You need to be familiar with the different sysprefs (I am not):
- FRBRizeEditions
- SyndeticsEnabled
- SyndeticsEditions
- ThingISBN

Make sure there are no regressions introduced by this patchset.

QA Note: C4/XISBN.pm should be renammed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312

Pierre-Luc Lapointe  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77830|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 77833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77833&action=edit
Bug 21226: DB Changes

Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

--- Comment #5 from Jonathan Druart  
---
Created attachment 77831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77831&action=edit
Bug 21226: Remove xISBN services

OCLC has decided to retire all xISBN services:
https://www.oclc.org/developer/news/2018/xid-decommission.en.html

The code for related features has to be removed from Koha.

Test plan:
You need to be familiar with the different sysprefs (I am not):
- FRBRizeEditions
- SyndeticsEnabled
- SyndeticsEditions
- ThingISBN

Make sure there are no regressions introduced by this patchset.

QA Note: C4/XISBN.pm should be renammed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

--- Comment #6 from Jonathan Druart  
---
Created attachment 77832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77832&action=edit
Bug 21226: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77827|0   |1
is obsolete||
  Attachment #77828|0   |1
is obsolete||
  Attachment #77829|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 77830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77830&action=edit
Bug 21226: DB Changes

Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

--- Comment #3 from Jonathan Druart  
---
Created attachment 77829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77829&action=edit
Bug 21226: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

--- Comment #2 from Jonathan Druart  
---
Created attachment 77828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77828&action=edit
Bug 21226: Remove xISBN services

OCLC has decided to retire all xISBN services:
https://www.oclc.org/developer/news/2018/xid-decommission.en.html

The code for related features has to be removed from Koha.

Test plan:
You need to be familiar with the different sysprefs (I am not):
- FRBRizeEditions
- SyndeticsEnabled
- SyndeticsEditions
- ThingISBN

Make sure there are no regressions introduced by this patchset.

QA Note: C4/XISBN.pm should be renammed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

--- Comment #1 from Jonathan Druart  
---
Created attachment 77827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77827&action=edit
Bug 21226: DB Changes

Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #24 from Andrew Isherwood  ---
Rebased against current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #75334|0   |1
is obsolete||

--- Comment #22 from Andrew Isherwood  ---
Created attachment 77825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77825&action=edit
Bug 20581: DO NOT PUSH: Updated Schema Files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #75810|0   |1
is obsolete||

--- Comment #23 from Andrew Isherwood  ---
Created attachment 77826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77826&action=edit
Bug 20581: (follow-up) Display status name

Rather than display the status code for custom statuses, we should be
displaying the name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >