[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #23 from Josef Moravec --- Created attachment 77970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77970&action=edit Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #20 from Josef Moravec --- Created attachment 77967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77967&action=edit Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #22 from Josef Moravec --- Created attachment 77969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77969&action=edit Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Josef Moravec changed: What|Removed |Added Attachment #77513|0 |1 is obsolete|| Attachment #77514|0 |1 is obsolete|| Attachment #77515|0 |1 is obsolete|| Attachment #77516|0 |1 is obsolete|| Attachment #77517|0 |1 is obsolete|| --- Comment #19 from Josef Moravec --- Created attachment 77966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77966&action=edit Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #21 from Josef Moravec --- Created attachment 77968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77968&action=edit Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 --- Comment #4 from Josef Moravec --- Created attachment 77965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77965&action=edit Bug 21201: Remove GetItemnumbersForBiblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201
Josef Moravec changed:
What|Removed |Added
Attachment #77685|0 |1
is obsolete||
Attachment #77686|0 |1
is obsolete||
--- Comment #3 from Josef Moravec ---
Created attachment 77964
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77964&action=edit
Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls
Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with
my @itemnumbers = Koha::Items->search({ biblionumber =>
$biblionumber})->get_column("itemnumber")
Test plan:
- Use the GetAvailability service of ILS-DI
- Try to place a hold on an item that is available and another one
- Use the batch record deletion tool to remove record with and without items.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 --- Comment #9 from Josef Moravec --- Created attachment 77962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77962&action=edit Bug 21184: Remove GetBarcodeFromItemnumber Test plan: git grep GetBarcodeFromItemnumber should not return anything Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 --- Comment #10 from Josef Moravec --- Created attachment 77963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77963&action=edit Bug 21184: (follow-up) Fix adding barcode to waiting hold item in SIP Test plan: 1) Set up your SIP: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2) Run: misc/sip_cli_emulator.pl -a localhost -p 6001 -su -sp -l --patron -s "Y " -m patron_information the -s parameter says what kind of additional information you want to see 3) Check the response: if the requested patron has waiting hold, there is field "AS" with the barcode of waiting item The right response looks like this: 64 00120180817 0524340001AOCPL|AA1|AEKoha Admin|BLY|CC5|AS304410|PCS|PIY|AFGreetings from Koha. | More reading ;) http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #7 from Josef Moravec --- You could test this using something like this: misc/sip_cli_emulator.pl -a localhost -p 6001 -su -sp -l --patron -s "Y " -m patron_information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Josef Moravec changed: What|Removed |Added Attachment #77955|0 |1 is obsolete|| Attachment #77956|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 77961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77961&action=edit Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with my $barcode = Koha::Items->find($itemnumber)->barcode; But if we are not sure that the item exists, we should test the return of ->find before ->barcode Test plan: - Edit an item - Check an item in - Test SIP - I do not really know how to trigger that code, apparently misc/sip_cli_emulator.pl does not deal with holds. Any ideas? Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #1 from Alex Buckley --- Created attachment 77960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77960&action=edit Bug 21241 - Conditional to choose appropriate message_transport_type for suggestion notices Introducing a conditional into C4/Suggestions.pm to check if no patron email exists but a smsalertnumber does exist then the suggestion notice message_transport_type is set to 'sms', otherwise the suggestion message_transport_type='email'. This ensures patrons with no email address still receieve their suggestion notices because at present the message_transport_type is hardcoded to 'email'. Test plan: 1. Chose a patron who has no email address set, but does have a smsalertnumber set (this value is set in the Patron messaging preferences section after the SMSSendDriver syspref is set) 2. Log into the OPAC with that user and submit a suggestion 3. In the staff client go to Acquisitions->Suggestions and tick the suggestion and set its status to 'Accepted' 4. In the database query the message_queue and notice the message_transport_type of the message is set to 'email' even though the patron has no email address set. 5. Apply this patch, restart memcached and plack 6. Repeat steps 2,3 with the same patron and query the message_queue table again and notice this time the message_transport_type = 'sms' 7. Repeat steps 2,3 with a patron with no smsalertnumber or email address. Query the database and observe the message_transport_type=email. If no smsalertnumber is set then the message_transport_type is set to 'email' by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] New: Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Bug ID: 21241 Summary: Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Presently the message_transport_type of suggestion module notices is hardcoded to email in C4/Suggestions.pm. If a patron does not have an email address set, but does have a smsalertnumber set then they will not receieve their suggestion notices. This patch introduces a conditional to C4/Suggestions.pm to check if no patron email exists AND a patron smsalertnumber does exist then the message_transport_type of the suggestion notice is set to 'sms'. Otherwise the message_transport_type is set to 'email'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Circ rules will not limit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #20 from Katrin Fischer --- Some notes from reading through the bug and code review: 1) Leftover warn in finishreceive.pl +$replacementprice = Koha::Number::Price->new( $replacementprice )->unformat(); +warn "Replacement $replacementprice"; 2) Database update I also wonder if we should prefill replacementprice from rrp. We could argue that not all libraries will want it to be set to rrp by default, especially as it would change the behaviour for pending orders. 3) Notes for for the release notes would be great. Nick? 4) Question: Why not allow editing of retail price later on? In case of a typo you'd have to reopen the basket and that will mess with the order dates and such... wouldn't it be easier to leave it editable? I can remove the warn in a follow-up, still have to finish testing of the behaviour and calculations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #91 from Katrin Fischer --- Thx, Joonas. Waiting for a follow-up here so I can continue testing - hopefully soon! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Katrin Fischer changed: What|Removed |Added Attachment #77958|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 77959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77959&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <> replacement: koha_1 | # 08/16/2018 14:25 [...] koha_1 | # 08/16/2018 14:24 Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Katrin Fischer changed: What|Removed |Added Attachment #77935|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 77958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77958&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <> replacement: koha_1 | # 08/16/2018 14:25 [...] koha_1 | # 08/16/2018 14:24 Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21229] Correct nesting and specificity for some button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Katrin Fischer changed: What|Removed |Added Attachment #77874|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 77957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77957&action=edit Bug 21229: Correct nesting and specificity for some button styles This patch corrects some Bootstrap button-related CSS which was causing some buttons to have the wrong color: - Circulation -> Check out: "Add a new message" link is black - Catalog -> Details page: "Print" button is blue To test, apply the patch and rebuild CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary and view the above pages to confirm the problem is fixed. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21229] Correct nesting and specificity for some button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21229] Correct nesting and specificity for some button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 --- Comment #6 from Jonathan Druart --- (In reply to Josef Moravec from comment #3) > Comment on attachment 77589 [details] [review] > I think there is too many variables called $item ;) Haha yes, good catch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 --- Comment #5 from Jonathan Druart --- Created attachment 77956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77956&action=edit Bug 21184: Remove GetBarcodeFromItemnumber Test plan: git grep GetBarcodeFromItemnumber should not return anything -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Attachment #77589|0 |1 is obsolete|| Attachment #77590|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 77955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77955&action=edit Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with my $barcode = Koha::Items->find($itemnumber)->barcode; But if we are not sure that the item exists, we should test the return of ->find before ->barcode Test plan: - Edit an item - Check an item in - Test SIP - I do not really know how to trigger that code, apparently misc/sip_cli_emulator.pl does not deal with holds. Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20739] Update two-column templates with Bootstrap grid: Administration part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20739 Jonathan Druart changed: What|Removed |Added Attachment #77879|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77954&action=edit Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20739] Update two-column templates with Bootstrap grid: Administration part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20739 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Rebased on top of bug 13618. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20739] Update two-column templates with Bootstrap grid: Administration part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20739 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21240] Tables with lot of columns should have autoWidth turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21240 --- Comment #1 from Jonathan Druart --- (note that the patch from bug 20739 is applied as well) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21240] New: Tables with lot of columns should have autoWidth turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21240 Bug ID: 21240 Summary: Tables with lot of columns should have autoWidth turned off Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org For instance, on patron's categories: On master: https://snag.gy/m8xJdG.jpg With 'bAutoWidth': false, # in categories.js: https://snag.gy/lzVm5P.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20738] Update two-column templates with Bootstrap grid: Administration part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20738 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Rebased on top of bug 13618. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20738] Update two-column templates with Bootstrap grid: Administration part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20738 Jonathan Druart changed: What|Removed |Added Attachment #77878|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77953&action=edit Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20738] Update two-column templates with Bootstrap grid: Administration part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20738 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Rebased on top of bug 13618. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77798|0 |1 is obsolete|| --- Comment #102 from Katrin Fischer --- Created attachment 77948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77948&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77797|0 |1 is obsolete|| --- Comment #101 from Katrin Fischer --- Created attachment 77947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77947&action=edit Bug 19817: Open the manual in a new window, not a popup Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77799|0 |1 is obsolete|| --- Comment #103 from Katrin Fischer --- Created attachment 77949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77949&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #105 from Katrin Fischer --- Created attachment 77951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77951&action=edit Bug 19817: (QA follow-up) Add German manual and fix system preference help files - German language manuals were added since this patch was started - The structure of the manual was changed slightly, system preferences were moved into their own chapter To test: - Test help files display correctly for system preferences display correctly Note: Local use uses a different page than the other tabs - Test German shows up as option in KohaManualLanguage and links correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 Jonathan Druart changed: What|Removed |Added Attachment #77877|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77952&action=edit Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77932|0 |1 is obsolete|| --- Comment #104 from Katrin Fischer --- Created attachment 77950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77950&action=edit Bug 19817: Remove numbering from chapter file names See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8 Remove numbering from chapter file names from koha-manual Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77793|0 |1 is obsolete|| --- Comment #98 from Katrin Fischer --- Created attachment 77944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77944&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77795|0 |1 is obsolete|| --- Comment #100 from Katrin Fischer --- Created attachment 77946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77946&action=edit Bug 19817: Add pref KohaManualLanguage Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77792|0 |1 is obsolete|| --- Comment #97 from Katrin Fischer --- Created attachment 77943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77943&action=edit Bug 19817: Remove local help files + edit help feature Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77794|0 |1 is obsolete|| --- Comment #99 from Katrin Fischer --- Created attachment 77945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77945&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Attachment #77791|0 |1 is obsolete|| --- Comment #96 from Katrin Fischer --- Created attachment 77942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77942&action=edit Bug 19817: Redirect to the online manual Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #4 from Jonathan Druart --- Mandatory fields Before : https://snag.gy/VhyPXM.jpg After : https://snag.gy/WZdGCM.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > .hint Also https://snag.gy/KlPSYp.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20740] Update two-column templates with Bootstrap grid: Administration part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- I have rebased the patch on top of bug 13618 as it should be the next one to be pushed. Also found bug 21239 while testing (not caused by this patch). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20740] Update two-column templates with Bootstrap grid: Administration part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Jonathan Druart changed: What|Removed |Added Attachment #77927|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 77941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77941&action=edit Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20740] Update two-column templates with Bootstrap grid: Administration part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #2 from Jonathan Druart --- Buttons for Datatables Before: https://snag.gy/gMR5US.jpg After : https://snag.gy/hMmZbu.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart changed: What|Removed |Added Blocks||21239 --- Comment #70 from Jonathan Druart --- I have opened bug 21239 to list the different regressions introduced by this change. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 [Bug 21239] CSS regressions caused by SCSS move -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Depends on||19474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #1 from Jonathan Druart --- .hint https://snag.gy/yJYbav.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] New: CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Bug ID: 21239 Summary: CSS regressions caused by SCSS move Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Summary|We do no longer need|Make |bibitems in AddReserve |C4::Reserves::AddReserves ||take a hashref in ||parameters Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Attachment #42198|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 77940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77940&action=edit Bug 14711: Change prototype for AddReserve - pass a hashref The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21237] Clean up staff client SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 --- Comment #1 from Owen Leonard --- Created attachment 77939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77939&action=edit Bug 21237: Clean up staff client SCSS This patch removes a redundant linter configuration, .sass-lint.yml, which was added by mistake. Some linter rules have been modified to better conform to the defacto standard set by our existing CSS. staff-global.scss has been corrected to comply with linter rules (https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md): - Comment, style: silent - TrailingSemicolon, true - Shorthand - ColorKeyword, enabled: true - PropertySortOrder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21237] Clean up staff client SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184
--- Comment #3 from Josef Moravec ---
Comment on attachment 77589
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77589
Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls
Review of attachment 77589:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21184&attachment=77589)
-
::: C4/SIP/ILS/Patron.pm
@@ +316,5 @@
> my $self = shift;
> my $item_arr = $self->x_items('hold_items', @_);
> foreach my $item (@{$item_arr}) {
> +my $item = Koha::Items->find($item->{itemnumber});
> +$item->{barcode} = $item ? $item->barcode : undef;
I think there is too many variables called $item ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
--- Comment #10 from Josef Moravec ---
Created attachment 77937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77937&action=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Josef Moravec changed: What|Removed |Added Attachment #77587|0 |1 is obsolete|| Attachment #77930|0 |1 is obsolete|| Attachment #77933|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 77936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77936&action=edit Bug 21183: Remove GetItemnumberFromBarcode Test plan: git grep GetItemnumberFromBarcode should not return anything Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #11 from Josef Moravec --- Created attachment 77938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77938&action=edit Bug 21183: Fix ->get_column call context I am not sure to understand what's going on here. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21237] Clean up staff client SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #95 from Katrin Fischer --- (In reply to Jonathan Druart from comment #94) > (In reply to Katrin Fischer from comment #92) > > Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How > > to fix? CPAN? > > I guess so, yes. But for sure you get it against master as well, it's not > related with those patches. I know it's not related - but this patch set changes the test and the failure keeps me from testing that part. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Sensible fix, works as expected. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Martin Renvoize changed: What|Removed |Added Attachment #77934|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 77935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77935&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <> replacement: koha_1 | # 08/16/2018 14:25 [...] koha_1 | # 08/16/2018 14:24 Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 --- Comment #1 from Jonathan Druart --- Created attachment 77934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77934&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <> replacement: koha_1 | # 08/16/2018 14:25 [...] koha_1 | # 08/16/2018 14:24 Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] New: TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Bug ID: 21238 Summary: TemplateToolkit.t is failing on slow server Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What|Removed |Added Blocks||21237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 [Bug 21237] Clean up staff client SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21237] New: Clean up staff client SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 Bug ID: 21237 Summary: Clean up staff client SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 19474 I would like to revise our scss-lint configuration file and make some cleanup changes to staff-global.scss. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21236] New: Restore ability to selectively set item to lost without generating fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21236 Bug ID: 21236 Summary: Restore ability to selectively set item to lost without generating fee Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Prior to bug 19974 a user could set an item to lost via additem.pl and the item would not be marked as returned and the patron would not be charged the replacement cost. The previous bug sought to standardize behavior between additem.pl and moredetail.pl, making both pages mark lost items and returned and charge the patron. Based on feedback about existing library workflows that relied upon the discrepancy between to two behaviors, the MarkLostItemsasReturned syspref was added to give libraries a choice of when and if an item would be marked as returned when set to lost. However, no such syspref was added to give the option to maintain the inconsistent legacy behavior in charging replacement costs when items are lost. This breaks existing workflows for libraries using lost status to handle Claims Returned items where the intent is to mark an item as lost but not charge the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Jonathan Druart --- Hum, weird... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #7 from Jonathan Druart --- Created attachment 77933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77933&action=edit Bug 21183: Fix ->get_column call context I am not sure to understand what's going on here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Pablo AB changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #4 from Pablo AB --- Related: To export patron images on a package ready for upload I create [this script](https://wiki.koha-community.org/wiki/Debian_packages_script_library#Bulk_export_patrons_images). Also in bug 12996. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #94 from Jonathan Druart --- (In reply to Katrin Fischer from comment #92) > Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How > to fix? CPAN? I guess so, yes. But for sure you get it against master as well, it's not related with those patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #93 from Jonathan Druart --- Created attachment 77932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77932&action=edit Bug 19817: Remove numbering from chapter file names See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8 Remove numbering from chapter file names from koha-manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #6 from Josef Moravec ---
Sorry, but still not working:
Can't use string ("2") as an ARRAY ref while "strict refs" in use at
/home/vagrant/kohaclone/tools/batchMod.pl line 269
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #24 from Martin Renvoize --- Just had to sort out some randomness with our sandboxes.. that final patch actually includes the signoff line this time.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #77818|0 |1 is obsolete|| --- Comment #23 from PTFS Europe Sandboxes --- Created attachment 77931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77931&action=edit Bug 20750: Allow logging of arbitrary actions This patch allows logging of arbitrary actions on request objects. A chronological summary of these actions can then be displayed when viewing a request. This patch also adds logging of request status changes. Additional work has been done on the BLDSS backend to log requests to the BLDSS request status check API. To test: - Apply patch - Ensure the Illlog logging preference is turned on - Create an ILL request and perform actions on it that change it's status. - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. Signed-off-by: Niamh Walker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21222] Patron's creation is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #8 from Martin Renvoize --- Not required in 18.05.x as we don't have bug 20226. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21226] Remove use of retired OCLC xISBN service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #18 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Jonathan Druart changed:
What|Removed |Added
Attachment #77687|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart
---
Created attachment 77930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77930&action=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21230] Reserves.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21230 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
