[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Claire Gravely changed: What|Removed |Added Attachment #78083|0 |1 is obsolete|| --- Comment #4 from Claire Gravely --- Created attachment 78084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78084=edit Bug 21209: (bug 20828 follow-up) Step 4 of moremember is used for Housebound and additional attributes Test plan: 1) Make sure the HouseboundModule is enabled in system preferences 2) Go to a patron file 3) Next to Housebound roles, click on "Add" 4) Check "Yes" next to one of the two roles (or both) 5) Click "Save" 6) The "Add" button is now "Edit", click on it The page is the one to edit housebound roles. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Jonathan Druart changed: What|Removed |Added Attachment #77763|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 78083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78083=edit Bug 21209: (bug 20828 follow-up) Step 4 of moremember is used for Housebound and additional attributes Test plan: 1) Make sure the HouseboundModule is enabled in system preferences 2) Go to a patron file 3) Next to Housebound roles, click on "Add" 4) Check "Yes" next to one of the two roles (or both) 5) Click "Save" 6) The "Add" button is now "Edit", click on it The page is the one to edit housebound roles. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #10 from Jonathan Druart --- Created attachment 78082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78082=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #9 from Jonathan Druart --- Created attachment 78081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78081=edit Bug 21206: Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Attachment #77699|0 |1 is obsolete|| Attachment #77700|0 |1 is obsolete|| Attachment #77701|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 78080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78080=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Jonathan Druart changed: What|Removed |Added Attachment #77888|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 78079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78079=edit Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for the last 3 patrons who checked out the items. I have no idea if it is a desired effects but, as this code has been there for a very long time (2005), I suspect it's not. The "doc" (/ilsdi.pl?service=Describe=GetRecords) does not say anything about the checkouts info. Test plan: hit /ilsdi.pl?service=GetRecords=1 and confirm the info about items are displayed correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #28 from Jonathan Druart --- Created attachment 78078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78078=edit Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #26 from Jonathan Druart --- Created attachment 78076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78076=edit Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #27 from Jonathan Druart --- Created attachment 78077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78077=edit Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What|Removed |Added Attachment #77966|0 |1 is obsolete|| Attachment #77967|0 |1 is obsolete|| Attachment #77968|0 |1 is obsolete|| Attachment #77969|0 |1 is obsolete|| Attachment #77970|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 78074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78074=edit Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #25 from Jonathan Druart --- Created attachment 78075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78075=edit Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #28 from Jonathan Druart --- Created attachment 78072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78072=edit Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #29 from Jonathan Druart --- Created attachment 78073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78073=edit Bug 20366: (follow-up) Fix link to subscription Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #27 from Jonathan Druart --- Created attachment 78071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78071=edit Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart changed: What|Removed |Added Attachment #77508|0 |1 is obsolete|| Attachment #77509|0 |1 is obsolete|| Attachment #77510|0 |1 is obsolete|| Attachment #77511|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 78070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78070=edit Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #50 from Jonathan Druart --- Created attachment 78067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78067=edit Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20365] Allow several open orders on subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 Jonathan Druart changed: What|Removed |Added Attachment #77507|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 78069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78069=edit Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #49 from Jonathan Druart --- Created attachment 78066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78066=edit Bug 20726: Add show/hide already received orders links Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #51 from Jonathan Druart --- Created attachment 78068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78068=edit Bug 20726: Add title to the price column headers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #47 from Jonathan Druart --- Created attachment 78064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78064=edit Bug 20726: Add acquisition history on the subscription detail page Since bug 20365 is going to add the ability to create several pending orders on the same subscription we should display the history of the acquisitions on the subscription detail page. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #48 from Jonathan Druart --- Created attachment 78065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78065=edit Bug 20726: Add DataTables Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 --- Comment #46 from Jonathan Druart --- Created attachment 78063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78063=edit Bug 20726: Add new method Acquisition::Order->invoice Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 Jonathan Druart changed: What|Removed |Added Attachment #77500|0 |1 is obsolete|| Attachment #77501|0 |1 is obsolete|| Attachment #77502|0 |1 is obsolete|| Attachment #77503|0 |1 is obsolete|| Attachment #77504|0 |1 is obsolete|| Attachment #77505|0 |1 is obsolete|| Attachment #77506|0 |1 is obsolete|| --- Comment #45 from Jonathan Druart --- Created attachment 78062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78062=edit Bug 20726: Add new method Koha::Acquisition::Order->fund Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8123] cronjob to pre-populate/Update patrons from ldap data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8123 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Attachment #77985|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 78061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78061=edit Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383
--- Comment #6 from Katrin Fischer ---
Comment on attachment 76787
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76787
Bug 19383: Add ability to print hold receipts automatically
Review of attachment 76787:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19383=76787)
-
Hi Kyle, can you take a quick look? Will continue testing.
::: circ/returns.pl
@@ +423,5 @@
> +ModReserveAffect( $reserve->{itemnumber},
> $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id} );
> +my ( $messages, $nextreservinfo ) =
> GetOtherReserves($reserve->{itemnumber});
> +
> +my $patron = Koha::Patrons->find( $nextreservinfo );
> +my $name = $patron ? $patron->surname . ", " . $patron->title . "
> " . $patron->firstname : '';
It looks like this line is not needed anymore?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984 Katrin Fischer changed: What|Removed |Added Attachment #78037|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 78060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78060=edit Bug 20984: Add 300$f to display Adding Type of Unit (300$f) to the Opac details and staff side searches results and details display Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Katrin Fischer changed: What|Removed |Added Attachment #78045|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 78059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78059=edit Bug 21207: Remove unused RM C4::Overdues::GetItems sub Test plan: git grep GetItems | grep -v GetItemsInCollection | grep -v GetItemsForInventory | grep -v GetItemsInfo | grep -v GetItemsLocationInfo | grep -v GetItemsAvailable | grep -v GetItemsByBiblioitemnumber should not return any occurrences of code in perl scripts Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20602] Use search fields weight/relevancy on OPAC simple search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Waiting for parent bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #16 from Katrin Fischer --- In a sentence it should work I think "save as draft" makes it clear that draft is a not a verb here. The problem is when draft appears without any context - then it's hard to tell what is really meant. Save without cataloguing somehow doesn't sound right to me, because even creating a draft means you are cataloguing. Maybe what's meant is: Save without adding to catalog (which is too long, I admit it). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Katrin Fischer changed: What|Removed |Added Attachment #77936|0 |1 is obsolete|| Attachment #77937|0 |1 is obsolete|| Attachment #77938|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 78056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78056=edit Bug 21183: Remove GetItemnumberFromBarcode Test plan: git grep GetItemnumberFromBarcode should not return anything Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #14 from Katrin Fischer --- Created attachment 78058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78058=edit Bug 21183: Fix ->get_column call context I am not sure to understand what's going on here. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
--- Comment #13 from Katrin Fischer ---
Created attachment 78057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78057=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
Signed-off-by: Josef Moravec
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 --- Comment #15 from Liz Rea --- Hi Elaine, The reason that we went with "save without cataloguing" is that the word Draft is both a noun and a verb. Save without cataloguing is easier to translate. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21237] Clean up staff client SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21237] Clean up staff client SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 Katrin Fischer changed: What|Removed |Added Attachment #77984|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 78055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78055=edit Bug 21237: Clean up staff client SCSS This patch removes a redundant linter configuration, .sass-lint.yml, which was added by mistake. Some linter rules have been modified to better conform to the defacto standard set by our existing CSS. staff-global.scss has been corrected to comply with linter rules (https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md): - Comment, style: silent - TrailingSemicolon, true - Shorthand - ColorKeyword, enabled: true - PropertySortOrder Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21216] Add filter/search options to notices table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21216 --- Comment #3 from Katrin Fischer --- The copy column doesn't work well on print and export - all pull down entries are exported into one column. Can we improve on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Katrin Fischer changed: What|Removed |Added Attachment #77875|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 78054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78054=edit Bug 21157: Improve style of OPAC login modal This patch revises the style of the OPAC's login form modal view. The goal is simply to make it look nicer. To test, apply the patch and regenerate the OPAC's CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the OPAC, click the "Log in to your account" link at the top of the page. It should trigger the login modal. While the modal is displayed, resize the browser width to confirm that the form handles different widths well. Sign off if you think this is an improvement. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7996] Patron modification log requires parameters permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #12 from Katrin Fischer --- Created attachment 78053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78053=edit Bug 7996: (QA follow-up) Remove unnecessary permission check view logs template Permission is checked in the perl file, no need to check again in the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7996] Patron modification log requires parameters permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Katrin Fischer changed: What|Removed |Added Attachment #77993|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 78052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78052=edit Bug 7996: Correct wrong permissions for modification log To test: 1 - Create a staff patron with catalogue,borrowers,and view_system_logs permissions 2 - Log in using that patron 3 - Go to tools 4 - Click 'Log viewer' 5 - You get a blank page 6 - View borrower circ screen, note you do not see 'Modification log' 7 - Edit a borrower, note you do not see 'Modification log' 8 - Apply patch 9 - 'Log Viewer' should now load correctly 10 - You should see 'Modification log' tab during circ 11 - You should see 'Modification log' tab when editing patron Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7996] Patron modification log requires parameters permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer --- Applied bug 21234 and bug 21237, but this one conflicts on top: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21239: CSS regressions caused by SCSS move fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21246] Extend the 'Last patron' navigation feature to 'Last X patrons'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21244] Make the display of the 'Last patron' button system preference driven.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21244 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21236] Restore ability to selectively set item to lost without generating fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21236 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21227] Add option to make items unavailable during closure period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21227 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21255] New: memberetnry.pl is missing categories in the Category pull-down list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21255
Bug ID: 21255
Summary: memberetnry.pl is missing categories in the Category
pull-down list
Change sponsored?: ---
Product: Koha
Version: 18.05
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: cnighswon...@foundations.edu
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
In some instances, when editing a patron, the Category pulldown under the
"Library management" section is missing categories.
I'm at a loss as to how to accurately describe the problem, but here goes:
1. The given patron's category shows up correctly on every other screen.
2. Navigating to the Patron Detail screen and selecting the edit option for
Library use section results in the Modify Patron screen.
3. The heading on the Modify Patron screen displays the correct category.
4. However, the Category pulldown does not.
5. Furthermore, the pulldown does not even contain the correct category for the
given patron.
Doing a bit of looking around turned up a few things which may or may not be
related. For the given patron:
1. The problem seems to be with the child category.
2. The Koha::Patron::Categories object may contain missing or incorrect
category information. Here is a snip of the object returned for the 'C'
category type by this line
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=members/memberentry.pl;h=cb4d0506ac54258b29fd82602c57a6056cf822ba;hb=HEAD#l634
'attrs' => {
'bind' => [],
'join' =>
'categories_branches',
'order_by' => [
'categorycode'
],
'where' => {
'category_type' => 'C',
'categories_branches.branchcode' => [
'JL',
undef
]
},
'alias' => 'me'
},
3. The underlying data appears to be sound.
4. This was not a problem prior to upgrading a month ago. Unfortunately, I'm
not sure what version this system was at prior to the upgrade.
Maybe this will get the discussion started and someone with more knowledge of
this area of the code can give some direction to it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #13 from Claudio --- No volunteers for this ticket? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 Elaine Bradtke changed: What|Removed |Added CC||e...@efdss.org --- Comment #14 from Elaine Bradtke --- It would be better to make the button say "Save as Draft" rather than save without cataloguing. We have been using the OpacSuppression syspref and a report that shows suppressed records, when training new staff, but this sounds more elegant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 --- Comment #3 from Marjorie Barry-Vila --- Anyone works on this? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #24 from Josef Moravec --- Created attachment 78051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78051=edit Bug 20487: (QA follow-up) Requested db revision As requested in comment12, we can update these cases in a dbrev too. Signed-off-by: Marcel de Rooy Checked out item, deleted issue record, ran dbrev. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Josef Moravec changed: What|Removed |Added Attachment #76615|0 |1 is obsolete|| Attachment #76616|0 |1 is obsolete|| --- Comment #23 from Josef Moravec --- Created attachment 78050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78050=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Josef Moravec changed: What|Removed |Added Attachment #77636|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 78049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78049=edit Bug 20504: Fix lang attribute in html tag on systempreferences page On the system preferences page the lang attribute of the html tag is always empty. To test: - Go to systempreferences - Check the html source and look at the html tag, it should read: - Apply patch - Check the html source again: Verify the language code shown matches the currently selected language in the staff interface - Verify the language system preferences work correctly Signed-off-by: Jonathan Druart The problem was actually that $lang = $template->param( 'lang' ); should certainly be $lang = $input->param( 'lang' ); and, as it, it overrides the value of 'lang' passed from C4::Auth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Josef Moravec changed: What|Removed |Added Attachment #77714|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 78048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78048=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21234] Remove our .clearfix class in favor of Bootstrap's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21234] Remove our .clearfix class in favor of Bootstrap's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21234] Remove our .clearfix class in favor of Bootstrap's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Josef Moravec changed: What|Removed |Added Attachment #77976|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 78047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78047=edit Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not displayed in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Josef Moravec changed: What|Removed |Added Attachment #78004|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 78046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78046=edit Bug 17625: adding subfields f and g to XSLT display Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff side Signed-off-by: Joy Nelson Signed-off-by: Cab Vinton Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not displayed in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17625] 245f and 245g are not displayed in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Ulrich Kleiber from comment #18) > Tomás, I think the mod_rewrite module is responsible for the setting of > 'SSLOptions +StdEnvVars'. It is required for the RewriteCond Directive. > > https://httpd.apache.org/docs/current/mod/mod_rewrite.html > ...These variables are available even without setting the StdEnvVars option > of the SSLOptions directive... > > Using 'RequestHeader set X_FORWARDED_PROTO "https" env=HTTPS' with Koha > shoudln't be a problem. Awesome, Uli. I propose we file a new bug for setting what you propose, and we keep this one for Marcel's enhancement which is still a nice improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 --- Comment #18 from Ulrich Kleiber --- Tomás, I think the mod_rewrite module is responsible for the setting of 'SSLOptions +StdEnvVars'. It is required for the RewriteCond Directive. https://httpd.apache.org/docs/current/mod/mod_rewrite.html ...These variables are available even without setting the StdEnvVars option of the SSLOptions directive... Using 'RequestHeader set X_FORWARDED_PROTO "https" env=HTTPS' with Koha shoudln't be a problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Marjorie Barry-Vila changed: What|Removed |Added CC|marjorie.barry-vila@collect | |o.ca| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Josef Moravec changed: What|Removed |Added Attachment #77702|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 78045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78045=edit Bug 21207: Remove unused RM C4::Overdues::GetItems sub Test plan: git grep GetItems | grep -v GetItemsInCollection | grep -v GetItemsForInventory | grep -v GetItemsInfo | grep -v GetItemsLocationInfo | grep -v GetItemsAvailable | grep -v GetItemsByBiblioitemnumber should not return any occurrences of code in perl scripts Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] Batch item/record modification/deletion tools does not open uploaded files in utf-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 --- Comment #9 from Victor Grousset/tuxayo --- Thanks for the fix! (In reply to Jonathan Druart from comment #4) > It is just a display problem, right? Actually jes and no, because with the BOM test case, it's still there (invisible instead of being mojibake[1]) And when using itemnumbers it's not just a display problem, it will make the first itemnumber invalid. For some reason, with barcodes it works; there must be some code that cleans the beginning and the end of the line. [1] https://en.wikipedia.org/wiki/Mojibake -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||josef.mora...@gmail.com --- Comment #7 from Josef Moravec --- Also QA tool fails: FAIL acqui/orderreceive.pl FAIL valid Global symbol "@items" requires explicit package name acqui/orderreceive.pl had compilation errors. FAIL catalogue/getitem-ajax.pl FAIL valid catalogue/getitem-ajax.pl had compilation errors. Global symbol "$item_unblessed" requires explicit package name FAIL misc/recreateIssueStatistics.pl FAIL forbidden patterns forbidden pattern: tab char (line 124) FAIL t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t FAIL valid syntax error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
--- Comment #6 from Josef Moravec ---
Comment on attachment 77699
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77699
Bug 21206: Replace C4::Items::GetItem
Review of attachment 77699:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21206=77699)
-
::: C4/ILSDI/Services.pm
@@ +615,5 @@
> # Add renewal if possible
> my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber );
> if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }
>
> +my $issue = $item ? $item->checkout : return; # FIXME should be handled
This does not return
::: labels/label-edit-batch.pl
@@ +87,4 @@
> my @numbers_list = split /\n/, $number_list; # Entries are
> effectively passed in as a separated list
> foreach my $number (@numbers_list) {
> $number =~ s/\r$//; # strip any naughty return chars
> +if( $number_type eq "itemnumber" && Koha::ITems->find($number) )
> {
ITems -> Items
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21254] ILS-DI service RenewLoan crash on not checked out item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21254 Josef Moravec changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Josef Moravec --- Looks like it is caused by 21206 which I am testing now. Closing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21254] New: ILS-DI service RenewLoan crash on not checked out item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21254 Bug ID: 21254 Summary: ILS-DI service RenewLoan crash on not checked out item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org When you try to renew a checkout on item which is not checked out, the ILS-DI service crashes with Can't call method "renewals" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 621 Url: /cgi-bin/koha/ilsdi.pl?service=RenewLoan_id=53_id=1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21253] New: Clarify calendar used by book drop mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21253 Bug ID: 21253 Summary: Clarify calendar used by book drop mode Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When using book drop mode in returns.pl, the checkin date is set to the last date the library was open. However, this gets confusing when multiple branches within the same system have different calendars. Book drop mode selects a date based on the calendar of the library whose circ rules governed the checkout (the library indicated by the CircControl and HomeOrHolding sysprefs). It does not consult the calendar of the library at which the checkin is taking place. This is not a particularly transparent behavior and is not explained in the manual. I'd like to see an explanation added to https://koha-community.org/manual/17.11/html/05_circulation.html#check-in-returning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21229] Correct nesting and specificity for some button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21238] TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21223] Some floating values are wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21223 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] Batch item/record modification/deletion tools does not open uploaded files in utf-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20994] Fix capitalization on OPAC result list "Save to Lists"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
