[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #84 from Alex Buckley --- Created attachment 78243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78243=edit Bug 15565: CSS changes Note: Reworked as we have switched to CSS since this commit was first written. This commit now contains 2 files: * koha-tmpl/opac-tmpl/bootstrap/css/opac.css * koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #83 from Alex Buckley --- Created attachment 78242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78242=edit Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Test plan: 1. Create an circulation rule to use for testing the patches on this bug report. Ensure it has a value greater than 1 for 'Holds allowed', 'Holds per record (count)', and 'Item level holds' is enabled. 2. Also ensure the 'RequestOnOpac' syspref is set to 'Allow'. 3. Go to the reservation page (request.pl) of a biblio in the staff client with more than one item. 4. Notice beside each item a radio button is displayed preventing you from being able to select multiple items to place a hold on. 5. Go to the reservation page (opac-reserve.pl) of the same biblio in the OPAC also notice a radio button is displayed beside every item. 6. Apply patches 7. Repeat step 3 and 5 and notice in both the staff client and OPAC checkboxes rather than radio buttons are displayed beside each item so you can select multiple items for reservation at a time. 8. From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record. - check also maxReserves system preference. 9. From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record. This is enforced by all unticked item checkboxes being disabled after the number of ticked checkboxes equals the 'Holds per record (count)' (circulation rules) value. - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added Text to go in the|This patch attempts to |This patch attempts to release notes|remove some confusion as|remove some confusion as |the 'Replacement price/rrp" |the 'Replacement price/rrp' |field was being used as |field was being used as |retail price during |retail price during |ordering process, but for |ordering process, but for |item replacement price when |item replacement price when |receiving. |receiving. | | |This patch |This patch |splits these fields so that |splits these fields so that |each may be set |each may be set |independently. RRP will be |independently. RRP will be |used to determine costs |used to determine costs |while ordering, and |while ordering, and |replacement price will |replacement price will |populate the items |populate the items |replacement price upon |replacement price upon |receiving. |receiving. --- Comment #32 from Katrin Fischer --- When you go back and modify the order, the replacement cost ist not properly formatted. 113.00 shows as 113.00. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #50 from Katrin Fischer --- Patch doesn't apply, please rebase! Problem is probably this one: Bug 19474 - Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21283] New: test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21283 Bug ID: 21283 Summary: test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added Attachment #72649|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added Attachment #72647|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added Attachment #72645|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added Attachment #72648|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added Attachment #72644|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added Attachment #72646|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #82 from Alex Buckley --- I have done the following changes to the patches on this bug report to try and get it moving along again: (#1 and #2 address Katrin's notes in comment 80) 1. Amended the first patch to include a proper test plan 2. Fixed the commit messages of all commits to be in the format: (Bug: ) 3. Rebased all commits against master 4. Reworked the css in the second patch because since that commit was written we have switched to scss. 5. Added an additional patch which fixes a few bugs when placing an item level hold from the OPAC. I will now attach these commits to the bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12186] Deduplicate TT code for account payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 paxed changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12186] Deduplicate TT code for account payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 --- Comment #3 from paxed --- Created attachment 78241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78241=edit Bug 12186: Deduplicate TT code for account payments Instead of using the same accounttype switch statement multiple times, just use the accounttype include file. Test plan: 1) Apply patch 2) Go to Patron's Fines 3) in the Pay fines -tab, check that the description shows correctly 4) in the Account -tab, click on the "Print" after the entries and check that the description shows correctly, both for invoices and fees. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12186] Deduplicate TT code for account payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 paxed changed: What|Removed |Added Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi Summary|Duplicate TT code for |Deduplicate TT code for |account payments|account payments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #45 from Aleisha Amohia --- Created attachment 78240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78240=edit Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Dilan Johnpullé changed: What|Removed |Added Attachment #78141|0 |1 is obsolete|| --- Comment #2 from Dilan Johnpullé --- Created attachment 78239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78239=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16702] Notice Triggers Issue: Delivery Mechanism Options Not Saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16702 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #4 from Liz Rea --- I ended up fixing this by dropping the overduerules and overduerules_transport_types tables (there were hardly any entries anyway) and recreating them from the schema of the version I was running (in this case, 17.05). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #23 from Cab Vinton --- Issues in Biblibre Sandbox 1: Some problems occurred applying patches from bug 15520: Something went wrong !Applying: Bug 15520: Add permission to restrict circ rules editing to own library Using index info to reconstruct a base tree... M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 15520: Add permission to restrict circ rules editing to own library The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 15520 - Add more granular permission for only editing own library's circ rules 77219 - Bug 15520: Add permission to restrict circ rules editing to own library 77220 - Bug 15520: Rename permission to manage_circ_rules_from_any_libraries Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-15520-Add-permission-to-restrict-circ-rules-ed-GgcAa1.patch . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #35 from Cab Vinton --- Tested in Biblibre Sandbox 1 -- Digital signs does not appear under Tools/Additional Tools. cgi-bin/koha/opac-signs.pl not found on server. OPACDigitalSigns system preference is added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||di...@calyx.net.au --- Comment #21 from Dilan Johnpullé --- I've just run into issues trying to apply this patch too :/ vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20554 Bug 20554 - New OPAC CSS 77689 - Bug 20554: New OPAC CSS 77690 - Bug 20554: (follow-up) Add local font files and add method for loading them Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20554: New OPAC CSS Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Applying: Bug 20554: (follow-up) Add local font files and add method for loading them Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/lib/fontfaceobserver.min.js Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 20554: (follow-up) Add local font files and add method for loading them The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20554-follow-up-Add-local-font-files-and-add-m-Hfq677.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #28 from Cab Vinton --- Patch failed to apply to Biblibre Sandbox 1 -- Some problems occurred applying patches from bug 16111: Something went wrong !Applying: Bug 16111: Fix content type for RSS feed Applying: Bug 16111: Fix atom support Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 16111: Fix atom support The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 16111 - RSS feed for OPAC search results has wrong content type 77057 - Bug 16111: Fix content type for RSS feed 77058 - Bug 16111: Fix atom support 77059 - Bug 16111: Remove 'rss2' which should be 'rss' or 'atom' 77060 - Bug 16111: (follow-up) Fixes for simplicity and validation Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-16111-Fix-atom-support-69Epde.patch . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326
--- Comment #44 from Aleisha Amohia ---
Created attachment 78238
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78238=edit
Bug 15326: (follow-up) Code review fixes
Addresses the following issues:
b) In opac-cmspages there is:
+flagsrequired => { borrow => 1 },
The borrow permission has been removed since. (blocker)
c) Comment was removed unnecessarily, just needs to be moved into
its right spot below again:
-# If GoogleIndicTransliteration system preference is On Set
parameter to load Google's javascript in OPAC search screens
d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 ); (blocker)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #49 from Cab Vinton --- Patch failed in PTFS Sandbox 0: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8630: Something went wrong !Applying: Bug 8630 - Adlibris covers (syspref files) Applying: Bug 8630 - Adlibris covers (intranet templates) Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Applying: Bug 8630 - Adlibris covers (intranet CSS) error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Patch failed at 0001 Bug 8630 - Adlibris covers (intranet CSS) The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8630 - Add covers from AdLibris to the OPAC and Intranet 76848 - Bug 8630 - Adlibris covers (syspref files) 76849 - Bug 8630 - Adlibris covers (intranet templates) 76850 - Bug 8630 - Adlibris covers (intranet CSS) 76851 - Bug 8630 - Adlibris covers (OPAC templates) 76852 - Bug 8630 - Adlibris covers (OPAC less changes) 76853 - Bug 8630: [FOLLOW-UP] Make Adlibris cover show on OPAC overdues tab 76859 - Bug 8630: Regenerated minified OPAC CSS Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8630---Adlibris-covers-intranet-CSS-11sz87.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17507] Can upload the same .koc file twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 --- Comment #9 from Liz Rea --- The UTF8 URLS of the world thank you all kindly <3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17507] Can upload the same .koc file twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507 --- Comment #4 from Liz Rea --- The feature we brainstormed over (not at all a complete idea) was a feature rather like staged marc imports, but for KOC files. i.e. you upload a file, it is staged, you can see what's in it and what will happen when it is applied. You can apply the file to the catalogue, and also have the option to reverse the actions it has taken, with full accounting in the case of fines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #76391|0 |1 is obsolete|| --- Comment #41 from Aleisha Amohia --- Created attachment 78236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78236=edit Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #43 from Aleisha Amohia --- Rebased, working on things in Comment 36 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #76392|0 |1 is obsolete|| --- Comment #42 from Aleisha Amohia --- Created attachment 78237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78237=edit Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #76388|0 |1 is obsolete|| --- Comment #38 from Aleisha Amohia --- Created attachment 78233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78233=edit Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #76389|0 |1 is obsolete|| --- Comment #39 from Aleisha Amohia --- Created attachment 78234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78234=edit Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #76390|0 |1 is obsolete|| --- Comment #40 from Aleisha Amohia --- Created attachment 78235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78235=edit Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #76387|0 |1 is obsolete|| --- Comment #37 from Aleisha Amohia --- Created attachment 78232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78232=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #76 from Aleisha Amohia --- Created attachment 78231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78231=edit Bug 14272: (follow-up) Fixing layout issues and expiration date hint Misunderstood the first time. I've added the hint to the news form on staff side. I've fixed the layout on OPAC. The RSS feed shows on the main page, but is hidden if there is no news and if viewing one news item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21282] New: Ordered lists should use ecost tax incl for calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 Bug ID: 21282 Summary: Ordered lists should use ecost tax incl for calculations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #51 from Aleisha Amohia --- Created attachment 78230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78230=edit Bug 14715: [FOLLOW-UP] Fix results not showing This fixes the display issue for me. Can someone please test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #92 from Katrin Fischer --- We had agreed that this bug should be next, still waiting, please fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |In Discussion --- Comment #13 from Katrin Fischer --- No consensus here yet - moving to 'in Discussion'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543 --- Comment #12 from Tomás Cohen Arazi --- Is pigz available on D8, D9 and supported Ubuntus? (I guess 16.04 and 18.04). While I see the advantage of having backups done faster, they are also an async task, and using all available cores in full (as a peak) might not be good for production sites. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] Remove NorwegianPatronDB related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #75 from Katrin Fischer --- Hm, yes, I didn't sign off on that, I think? Please always do follow-ups for changes like that once a patch has reached signed-off status. I also think this is a misunderstanding entirely. We were not asking for the expiration date to show on the news item, but for a hint on the news form in staff that the news will still be accessible by direct URL even if expired. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21281] Label Template - Creation not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21281 --- Comment #3 from Henrique --- Hi Chris, yes, i know that. backticks is the solution ... but i dont want to mess with koha code koha uses some record object / classes / model ... ...not so easy to change i think koha should code backticks on all sql statments to solve this sittuation and prevent any others in the future tia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17507] Can upload the same .koc file twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507 --- Comment #3 from Christopher Brannon --- Perhaps a unique key should be included in the file, and Koha should keep track of these keys to show that it has been processed already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #74 from Owen Leonard --- (In reply to Owen Leonard from comment #53) > > A problem I found: If there is no news to display, OpacMainUserBlock and > Quote of the Day don't show at all. This problem is back. Why do we note the expiration date of the news item? That doesn't seem relevant to me. If we must keep it the date should be formatted according to dateformat preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #271 from Alex Arnaud --- (In reply to Jonathan Druart from comment #254) > - Message on the admin page - click here, then you enable, then? We should > link to a documentation page. > > - log_path is not in the default yaml file or specify in any docs. > I did not manage to configure the server config file to make it work > locally. Can you share a working example please? I don't know what your are talking about for these 2 points > > - What is supposed to happen when I click on "Send" in the ManaToken syspref > block? There is a wrong error handling, as my server is not setup properly, > I click and nothing happens. You are supposed to receive an email containing a link to activate your Mana account. Like this one: " Hello Alex Arnaud, Someone asked on 2018-08-28 for an authentication on the Mana KB webservice. To activate your account definitively, please click on the following link and follow the instruction https://mana-test.koha-community.org/registration?id=DnX " It works for me because i set the official Mana server url in Koha. May be you are using a locale one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #78228|0 |1 is obsolete|| --- Comment #270 from Alex Arnaud --- Created attachment 78229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78229=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest=> search_entities buildRequest => build_request manaUrl => get_sharing_url -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21281] Label Template - Creation not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21281 --- Comment #2 from Chris Nighswonger --- The solution is to quote the keyword in question with backticks per the MariaDB knowledge base: "Reserved words cannot be used as Identifiers, unless they are quoted."[1] [1]https://mariadb.com/kb/en/library/reserved-words/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #269 from Alex Arnaud --- (In reply to Jonathan Druart from comment #253) > 1. Unit tests: > [kohadev-koha@kohadevbox:/home/vagrant/kohaclone (BZ17047_s) ✹ ✭]% prove -r > t/db_dependent/Koha/SharedContent.t t/db_dependent/Koha/Subscription* > t/db_dependent/Serial* > t/db_dependent/Koha/SharedContent.t Name > "Koha::SharedContent::MANA_IP" used only once: possible typo at > t/db_dependent/Koha/SharedContent.t line 44. > > t/db_dependent/Koha/Subscription.t . "my" variable $builder > masks earlier declaration in same scope at > t/db_dependent/Koha/Subscription.t line 38. > t/db_dependent/Koha/Subscription.t . 1/9 Can't call method > "biblionumber" on an undefined value at > /home/vagrant/kohaclone/Koha/Subscription.pm line 143. > # Looks like your test exited with 255 just after 8. > t/db_dependent/Koha/Subscription.t . Dubious, test returned > 255 (wstat 65280, 0xff00) > Failed 1/9 subtests > > t/db_dependent/Serials/ReNewSubscription.t . Undefined subroutine > ::SharedContent::manaGetRequestWithId called at > /home/vagrant/kohaclone/C4/Serials.pm line 303. > > > 2. QA script: > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >FAIL forbidden patterns > forbidden pattern: Do *not* include full path to js files, > use the Asset TT plugin (bug 20538) (line 196) > forbidden pattern: intranet-tmpl should certainly replaced > with [% interface %] (line 196) > > > FAIL t/db_dependent/Koha/SharedContent.t >FAIL valid > Name "Koha::SharedContent::MANA_IP" used only once: possible > typo > > FAIL t/db_dependent/Koha/Subscription.t >FAIL valid > "my" variable $builder masks earlier declaration in same > scope > > > About MANA_IP, you should move it to a Koha::SharedContent method. It would > be the only way to retrieve mana_config from the config. > It will help to handle non-existent/invalid entry. Moreover I think we > should avoid having config at package level (because of usage of Memcached > and Plack). It will be easy to mock with mock_config. > > 3. There is a CamelCase/snake_case mix in method's names Fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #267 from Alex Arnaud --- Created attachment 78227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78227=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #268 from Alex Arnaud --- Created attachment 78228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78228=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest=> search_entities buildRequest => build_request manaUrl => get_sharing_url -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76684|0 |1 is obsolete|| --- Comment #266 from Alex Arnaud --- Created attachment 78226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78226=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76683|0 |1 is obsolete|| --- Comment #265 from Alex Arnaud --- Created attachment 78225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78225=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76682|0 |1 is obsolete|| --- Comment #264 from Alex Arnaud --- Created attachment 78224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78224=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76681|0 |1 is obsolete|| --- Comment #263 from Alex Arnaud --- Created attachment 78223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78223=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76680|0 |1 is obsolete|| --- Comment #262 from Alex Arnaud --- Created attachment 78222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78222=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76679|0 |1 is obsolete|| --- Comment #261 from Alex Arnaud --- Created attachment 78221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78221=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76678|0 |1 is obsolete|| --- Comment #260 from Alex Arnaud --- Created attachment 78220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78220=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76677|0 |1 is obsolete|| --- Comment #259 from Alex Arnaud --- Created attachment 78219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78219=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76676|0 |1 is obsolete|| --- Comment #258 from Alex Arnaud --- Created attachment 78218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78218=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after for example) https://mana-kb.koha-community.org 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76674|0 |1 is obsolete|| --- Comment #256 from Alex Arnaud --- Created attachment 78216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78216=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76675|0 |1 is obsolete|| --- Comment #257 from Alex Arnaud --- Created attachment 78217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78217=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB = Test plan = (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What|Removed |Added Attachment #76673|0 |1 is obsolete|| --- Comment #255 from Alex Arnaud --- Created attachment 78215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78215=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21281] Label Template - Creation not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21281
--- Comment #1 from Henrique ---
... more info ...
the SQL command is
INSERT INTO creator_templates (creator, rows, template_code, profile_id,
page_height, label_width, left_text_margin, units, cols, label_height, col_gap,
row_gap, template_desc, page_width, top_margin, top_text_margin, left_margin)
VALUES ('Labels','0','DEFAULT
TEMPLATE','0','0','0','0','POINT','0','0','0','0','Default
description','0','0','0','0')
it does NOT work on
10.3.8-MariaDB-1:10.3.8+maria~stretch-log - mariadb.org binary distribution
It WORKs on
10.0.30-MariaDB-0+deb8u2
ROWS is a reserved word
tia,
Henrique
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9514] 'and' in subject searches causes a problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9514 --- Comment #3 from Owen Leonard --- Jon, the "importance" setting has no effect on how bug fixes are prioritized. If a bug isn't moving there are a few things you can do: - Provide more information. My comment from 2016 asks for more information and got no response. - Bring it up on the mailing list. If others are bothered by the problem it might trigger some action. - Pay to get it fixed. This is the only way you can guarantee action. Volunteers set their own agenda, and paid support companies go where their customers have the most need. https://koha-community.org/support/paid-support/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS --- Depends on Bug 18255 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Bug 21202 depends on bug 21203, which changed state. Bug 21203 Summary: ILS-DI - GetRecords crashes on non-existent records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #10 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS --- Depends on Bug 18403 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #37 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167 --- Comment #6 from Cab Vinton --- Let me know if I should be changing status (Patch doesn't apply? Failed QA?) Tested in PTFS Sandbox 0. Biblibre sandboxes are failing silently :-( Something went wrong !Applying: Bug 21167: Fix price formatting on printed fee invoice and receipt error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt Patch failed at 0001 Bug 21167: Fix price formatting on printed fee invoice and receipt The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 21167 - Correct price formatting on printed fee receipt and invoice 77596 - Bug 21167: Fix price formatting on printed fee invoice and receipt Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-21167-Fix-price-formatting-on-printed-fee-invo-0XLKVz.patch . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #38 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #17 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #16 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected by matching on code, not id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #15 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21281] New: Label Template - Creation not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21281 Bug ID: 21281 Summary: Label Template - Creation not working Change sponsored?: --- Product: Koha Version: 18.05 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: hkel...@gmail.com QA Contact: testo...@bugs.koha-community.org Hi, Koha version: 18.05.02.000 mysql Ver 15.1 Distrib 10.3.8-MariaDB create a "Label Template" and save. (any configuration ) There is no error message. But it shows a message indicating that "there is no template" It looks like Koha is using some reserved words ( rows ) during the creation of a new label template... As i looked the sql commands that koha is using to create the template i figure out that its using "rows" - a new reserved word ... Could you verify it, please tia Henrique -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug 20944 depends on bug 20942, which changed state. Bug 20942 Summary: Add route to get patron's account balance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug 15165 depends on bug 20942, which changed state. Bug 20942 Summary: Add route to get patron's account balance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m --- Comment #20 from Fridolin SOMERS --- I prefer not to push to 17.11.x to focus on major bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21280] Unify MARC tab HTML generation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13406 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21280] Unify MARC tab HTML generation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11885 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21280 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21280 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21280] Unify MARC tab HTML generation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 paxed changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pasi.kalli...@joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 78214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78214=edit Bug 21280: Unify MARC tab HTML generation Bug 11885 improved the MARC detail tab view, so it it easier to style with CSS, but the authority MARC tabs are still in a sorry state. We can unify the code into a single include file, and reuse that from both. Test plan: 1) Apply the patch 2) Look at the biblio MARC detail view, check the tabs look the same as before 3) Look at an authority MARC detail view, check the tabs look the same as the biblio view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21280] New: Unify MARC tab HTML generation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 Bug ID: 21280 Summary: Unify MARC tab HTML generation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Bug 11885 improved the MARC detail tab view, so it it easier to style with CSS, but the authority MARC tabs are still in a sorry state. We can unify the code into a single include file, and reuse that from both. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Katrin Fischer changed: What|Removed |Added Attachment #77467|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 78213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78213=edit Bug 19909: Show attributes in patron search results Add a new column (hidden by default) in the results table which displays all attributes associated to the corresponding patron. New subroutine Koha::Patron::Attribute::display_value that returns the authorised value description and defaults to the raw value if the attribute's type is not associated to an authorised value category Test plan: 1. Create some patron attribute types, with and without an associated authorised value category 2. Choose an existing patron and set a value for each attribute 3. Go to patron search and do a search that will return your patron (and some others to avoid the redirection) 4. Show column 'Extended attributes' by clicking on 'Column visibility' button 5. Note that all attributes are displayed correctly 6. prove t/db_dependent/Koha/Patron/Attributes.t Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- This is working well for me and is a really nice addition. Wondering 2 things: - We got a system preference for turning on/off patron attributes. Should the column not be visible when the pref is turned off? (ExtendedPatronAttributes) - The display_value method somehow looks not quite right to me. I think this may be what Jonathan was trying to point out in his comment, that there could be another way of doing it. Could you take a look and comment? I rebased the patch for testing, I will attach the rebased patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- I think this is a nice addition, but some small things: - Please add the new authorised value category to the default list and add a database update. - The Plugin will show always now, there is no way to turn it off. I think we shouldn't force it like that. As we can't delete authorised value categories at the moment, maybe the easiest would be to look for existing entries and decide on that if the feature should be active or not. It also wouldn't leave you with an empty/non-working widget so easily. - The buttons are a little huge going over the lines... (not blocker, but having a look would be cool) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
