[Koha-bugs] [Bug 15139] Show non-public item note in overdues report

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139

--- Comment #12 from Katrin Fischer  ---
And thank you, Spencer!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15139] Show non-public item note in overdues report

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139

--- Comment #11 from Katrin Fischer  ---
Hm, Kyle? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #6 from Katrin Fischer  ---
Hm, I don't think we need more configuration options - we need the report to
use the ones we have correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

--- Comment #2 from Alex Buckley  ---
Created attachment 79189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79189=edit
Bug 21241 - Conditional to choose appropriate message_transport_type for
suggestion notices

Introducing a conditional into C4/Suggestions.pm to check if no patron
email exists but a smsalertnumber does exist then the suggestion notice
message_transport_type is set to 'sms', otherwise the suggestion
message_transport_type='email'.

This ensures patrons with no email address still receieve their
suggestion notices because at present the message_transport_type is
hardcoded to 'email'.

Test plan:
1. Chose a patron who has no email address set, but does have a
smsalertnumber set (this value is set in the Patron messaging
preferences section after the SMSSendDriver syspref is set)

2. Log into the OPAC with that user and submit a suggestion

3. In the staff client go to Acquisitions->Suggestions and tick the
suggestion and set its status to 'Accepted'

4. In the database query the message_queue and notice the
message_transport_type of the message is set to 'email' even though the
patron has no email address set.

5. Apply this patch, restart memcached and plack

6. Repeat steps 2,3 with the same patron and query the message_queue
table again and notice this time the message_transport_type = 'sms'

7. Repeat steps 2,3 with a patron with no smsalertnumber or email
address. Query the database and observe the
message_transport_type=email.

If no smsalertnumber is set then the message_transport_type is set to
'email' by default

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

Alex Buckley  changed:

   What|Removed |Added

  Attachment #77960|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19036] Number payment receipts / payment slips

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10060] Self Checkout module does not honour circ control

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060

--- Comment #7 from Liz Rea  ---
No, because the problem is that the user of the selfcheck isn't always owned by
the branch that uses the selfcheck user, and the code is using the homebranch
of the user. 

It's been a while since we've looked at this, maybe it's fixed now I don't
know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

  Attachment #79171|0   |1
is obsolete||

--- Comment #42 from Michal Denar  ---
Created attachment 79188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79188=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

--- Comment #34 from Katrin Fischer  ---
can you explain?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21362] Advanced MARC Editor - Rancor - Tab navigation not working in fixed fields

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21362

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Maybe he meant the default plugins? They have a lot of pull downs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #113 from Nick Clemens  ---
Created attachment 79187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79187=edit
Bug 18736: (follow-up) Remove duplicate code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to Staff interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #78877|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 79185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79185=edit
Bug 21352: Allow plugins to add CSS and Javascript to Staff interface

We should have plugin hooks for the staff interface just like we have for the
OPAC as detailed on bug 20181.

Test Plan:
1) Apply this patch
2) Download and install the Kitchen Sink plugin ( v2.1.19 or later )
  
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.19/koha-plugin-kitchen-sink-v2.1.19.kpz
3) Install the plugin
4) Restart all the things if you can ( restart_all if you are using kohadevbox
)
   This will ensure the plugin takes effect right away, it should be
   necessary but it won't hurt anything!
5) Load the staff intranet, notice you get an alert message and the background
   for your staff intranet is now orange ( assuming you've not customized the
   staff intranet in any way )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to Staff interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to Staff interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352

--- Comment #6 from Kyle M Hall  ---
Created attachment 79186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79186=edit
Bug 21352: Use the raw filter for plugin hooks, both opac and staff side

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8543] enter an 001 at acquisitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8543

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|WONTFIX |FIXED

--- Comment #4 from Katrin Fischer  ---
This should work now with the possibility to define the fields shown in acq via
the ACQ framework.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8541] Type code for fund instead of just pull down

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8541

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Maybe another option would be to display both the code and description and use
a select2 style pull down?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Nick Clemens  changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #11 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 20664 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #21 from Nick Clemens  ---
*** Bug 21006 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED

--- Comment #10 from Nick Clemens  ---
Ere demonstrated the issue for me - at least my tests were useful - closing
this in favor of his

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

--- Comment #8 from M. Tompsett  ---
(In reply to Blou from comment #6)
> Examine opac-tmrpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl around line
> 110 (just below the "Wrapper div" comment.  You'll find
> 
> record
> 
> Translate, then look at the (fr-CA) version, you'll find

Translate how? You did not give the steps.

> 
> notice
> 
> This will in turn create in the webpage some   
> Bad.

Imagine I only how how to click and type. Tell me more detailed instructions
starting from:

1) vagrant up jessie
2) cd kohaclone
3) git checkout -b bug_21130 origin/master
3a) Oops... forgot to do the opac steps first to find the page that is broken.
3b) something about looking for something on a page where it is going to be
wrong.
4) git bz apply 21130
5) restart_all
6) sudo service apache2 restart
7) sudo systemctl daemon-reload
8) kshell
9) cd misc/translator
10) ./translate --help
-- I'm stuck.
11) open the opac
12) change language
-- oops... forgot to set some system preferences, but I'm playing ignorant, so
I'm stuck, because there is no way to change anything.
13) inspect the page source
-- looking for something gives me the line that should be corrected now.

I need more details. I can fill in some of them, but this doesn't give me
enough information to test still. Imagine the person is trying to set up Koha
for the first time. Write instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10060] Self Checkout module does not honour circ control

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Could using a separate self-check user for each branch solve the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard  changed:

   What|Removed |Added

  Attachment #78343|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard  changed:

   What|Removed |Added

  Attachment #78343|0   |1
is obsolete||
  Attachment #78437|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 79184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79184=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
 at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to Staff interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352

--- Comment #4 from Kyle M Hall  ---
(In reply to David Cook from comment #3)
> I think this plugin and test plan might be for the OPAC rather than the
> staff client?
> 
> Even on the OPAC, it's escaping the angle brackets so it just prints the CSS
> out as text. 
> 
> The HTML source looks like this:
> 
> style
>   body {
> background-color: orange;
>   }
> /style

Sounds like a regression. You are right about the test plan. It should say
intranet, not opac.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21388] New: Add ability to hide Non-public Notes from Circulation Page

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388

Bug ID: 21388
   Summary: Add ability to hide Non-public Notes from Circulation
Page
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In a previous bug 19806, non-public notes were requested for the library to
have the ability to hide this field (non public note/ itemnotes) in checkin
tables.  This field "itemnotes" was added to the Configure Columns to allow a
library to choose or not choose to have this field visible.  This feature would
also be nice in the issues (circulation) screen.  When a staff member is
checking out an item to the patron, they might not necessarily need to see the
non-public note during checking out in addition to checking in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #112 from Martin Renvoize  ---
QA Comment: _get_rounding_sql is present in both C4::Budgets and
C4::Acquisitions, should this not be factored out somewhere to prevent it
falling out of sync across the two locations?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard  changed:

   What|Removed |Added

  Attachment #78470|0   |1
is obsolete||

--- Comment #54 from Owen Leonard  ---
Created attachment 79183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79183=edit
Bug 20600: (follow-up) Fix bad rebase

Rebasing didn't do the right thing, so this patch fixes it

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #79117|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19749] Report to show all holds placed independent on items being available to pull

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19749

SiobhanC  changed:

   What|Removed |Added

 CC||siobhancot...@gmail.com

--- Comment #5 from SiobhanC  ---
Hi, 

This is something that we requested with our implementation of Koha, because we
also keep paper-based reservation information (for now). The report that PTFS
and I wrote is: 

SELECT biblio.title AS 'Title', CONCAT('Click here' ) AS 'Title link', CONCAT (borrowers.firstname,' ',
borrowers.surname) AS 'Name', reserves.reservedate AS 'Date of reservation',
reserves.branchcode AS 'Pick up location'
FROM reserves
JOIN biblio USING (biblionumber)
JOIN borrowers USING (borrowernumber)
WHERE reserves.reservedate BETWEEN <> AND
<> AND reserves.found IS NULL

It's still not quite perfect, as it shows available items too. 

Siobhan

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #79173|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67225|0   |1
is obsolete||
  Attachment #67226|0   |1
is obsolete||
  Attachment #67227|0   |1
is obsolete||
  Attachment #67228|0   |1
is obsolete||
  Attachment #67229|0   |1
is obsolete||
  Attachment #67230|0   |1
is obsolete||
  Attachment #69429|0   |1
is obsolete||
  Attachment #69493|0   |1
is obsolete||

--- Comment #47 from Alex Arnaud  ---
Created attachment 79182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79182=edit
Bug 17282: Ability to create charts for SQL reports

Add a form under report's result that allow to configure and draw a
chart (pie, bar, line and combination).

Pie: Usefull only for a two-column report's result

bar: Horizontal: Can be horizontal or vertical (check/uncheck
horizontal checkbox),
 Group: allows to group columns (stacked bar chart),
 Line: show some columns as line in a bar chart (combination)

line: line chart :)

This patch adds 2 new js libraries: d3js and c3js:
  - c3.min.css
  - c3.min.js
  - d3.min.js

Test plan:
- Apply this patch,
- execute a report,
- click on show chart settings button (in the tool bar),
- draw chart (click on draw button),
- check the chart

Features:
- Include all rows (ignore pagination),
- Download the chart (svg),
- Choose x column and y columns,
- Exclude last line (Rollup)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21387] New: Receive items from - form should include tax hints the same as the ordering form

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387

Bug ID: 21387
   Summary: Receive items from - form should include tax hints the
same as the ordering form
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

On the 'New order' page in the 'Accounting details' section of the form there
are clarifications on which amount (with/without tax) one is expected to enter.
 These clarifications should be replicated to the 'Accounting details' form on
the 'Receive items from: ' page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20460] Staff can only change password through the change password button if patron hits failedloginattempts

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460

Agnes Rivers-Moore  changed:

   What|Removed |Added

  Component|OPAC|Patrons
 CC||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to Stable|RESOLVED

--- Comment #23 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21285] Select2 broken on high dpi screens

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21334] Add bibliographic content type definitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21334] Add bibliographic content type definitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21334] Add bibliographic content type definitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

Martin Renvoize  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21334] Add bibliographic content type definitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17371] Add routes for biblios

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371
Bug 17371 depends on bug 21334, which changed state.

Bug 21334 Summary: Add bibliographic content type definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21334] Add bibliographic content type definitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21334] Add bibliographic content type definitions

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

--- Comment #10 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.04.

After pushing bug 21116 I decided this one warranted backporting for the same
reasons outlined on that bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782

--- Comment #4 from Martin Renvoize  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #75457|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 79181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79181=edit
Bug 20782: Fix link from edifactmessages to invoices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21340] Add spans with classes around callnumbers in OPAC for additional styling

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #78866|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 79180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79180=edit
Bug 21340: Add spans with classes around callnumbers in OPAC for additional
styling

It would be nice if the callnumber portion of the callnumber + label was in a
span, and it also makes sense to wrap the entire callnumber string in a span as
well.

Signed-off-by: Petter 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||Print summary for patron
  release notes||will now show only
   ||outstanding fines/payments.
   ||To print all fines/payments
   ||you can use the 'print'
   ||option for the table in the
   ||accounts page for the
   ||patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #35 from Owen Leonard  ---
Created attachment 79179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79179=edit
Bug 20935: Remove 'no match' box when it does

Test plan:
Hit /cgi-bin/koha/admin/preferences.pl
Search for "AcqCreateX"
=> You get "No matching terms were found on this page"
Remove the last X
=> Without this patch the "no matching" box is still displayed

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard  changed:

   What|Removed |Added

  Attachment #77844|0   |1
is obsolete||
  Attachment #77845|0   |1
is obsolete||
  Attachment #77846|0   |1
is obsolete||

--- Comment #33 from Owen Leonard  ---
Created attachment 79177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79177=edit
Bug 20935: Redesign system preferences interface

This patch proposes a new interface for system preferences. The goal is
to make the interface more readable and to give the user additional
options for finding what they need.

- Restructures the preferences list as a , with the preference name
  as the  and the description as the .
- Add a JS filter library (mark.js) to do live filtering of the page and
  add search term highlighting.
- When the user has searched, show links to the sections in which
  results were returned.

To test, apply the patch and go to Administration -> System preferences.

 - Test the functionality of setting various kinds of preferences,
   including multi-selects, textareas, WYSIWYG editors, etc.
 - Test the filter form at the top of the page for narrowing in-page
   results.
   - Test both successful and unsuccessful filters.
 - Perform a system preference search.
   - Test the in-page links to the different sections.
   - Test that in-page filtering works in this case too.
 - View the licenses tab of the "About" page and check that the
   information about mark.js looks correct.

Followed test plan and pleased to say everything worked as expected.
Looking forward to this enhancement.

Signed-off-by: Dilan Johnpullé 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #34 from Owen Leonard  ---
Created attachment 79178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79178=edit
Bug 20935: Remove "Click to" from some links

Changes "Click to edit" and "Click to collapse" to just
"Edit" and "Collapse" as the "Click to" appears not
necessary for elements formatted as links.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Nick Clemens  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #60 from Nick Clemens  ---
I pushed this, the UI display for when a user has denied consent could be
improved - it still seems to be waiting for approval, but doesn't make it clear
that 'No' has been set - as others seemed fine with it I let it go but
something to consider

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #59 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656

--- Comment #23 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #4)
> I think I like the new display better. As it's supposed to be a summary
> displaying only open credits and fines makes sense to me, but the heading
> should then be changed to match the new display.
> 
> Signing, but waiting for follow-up and maybe another opinion here.

I am happy to fix this on a follow-up bug, can you suggest a new title?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21374] Self registration e-mail verification does not work

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #22 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656

--- Comment #21 from Nick Clemens  ---
Created attachment 79176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79176=edit
Bug 20656: (RM follow-up) Add missing filter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #58 from Nick Clemens  ---
Created attachment 79175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79175=edit
Bug 20819: (RM follow-up) Add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21386] New: Receive shipment from vendor X: Items expected is never more than 0

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21386

Bug ID: 21386
   Summary: Receive shipment from vendor X: Items expected is
never more than 0
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

I'm not sure what the point of this field is on this page in the summary of
invoices table, but I can never get it to show anything other than 0.

Do we know what it was intended to show and if it's still relevant?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21385] New: Vendor search: Item count is incorrectly updated on partial receive.

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385

Bug ID: 21385
   Summary: Vendor search: Item count is incorrectly updated on
partial receive.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

To reproduce:

1) Create a basket with 2 biblios, one with 2 items and one with 1 item
2) Search for vendors and note the basket above should contain 'Item count 3',
'Biblio count 2', 'Items expected 3'
3) Receive shipment, and only receive 1 of the items on the biblio with 2 items
above.
4) Search for vendors and note that the 'Item count' for the basket above is
now '2'.

The item count for a closed basket should remain the same and should differ
from the 'items expected' count some items have been recieved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16739] generate edifact showing on basket groups

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

Spencer  changed:

   What|Removed |Added

 CC||ssmi...@mckinneytexas.org

--- Comment #10 from Spencer  ---
Created attachment 79174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79174=edit
screencaptrure

It appears this patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #79117|0   |1
is obsolete||

--- Comment #14 from ByWater Sandboxes  ---
Created attachment 79173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79173=edit
Bug 13406: (RM follow-up) Add missing filter

Signed-off-by: Nick Clemens 

Signed-off-by: qwer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21191] GDPR: Script to block inactive users (with no successful logins on a defined period)

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||21336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336
[Bug 21336] GDPR: Process unsubscribe requests automatically
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||21191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191
[Bug 21191] GDPR: Script to block inactive users (with no successful logins on
a defined period)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21191] GDPR: Script to block inactive users (with no successful logins on a defined period)

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191

--- Comment #7 from Marcel de Rooy  ---
Bug 21336 adds a Patrons method lock (wrapper for Koha Patron lock).
So you only need to add a simple search.
Something like:

Koha::Patrons->search({ login_attempts => { '>=', pref_value }, lastseen => {
'<', some_date }) -> lock;

Lock adds the option expire => 1 setting the expire date. Effectively
disallowing holds, issues, etc.
And the option remove => 1 for removing holds and article requests.

So most work done already..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #5 from Magnus Enger  ---
I have a customer expeiencing problems with this too. 

Could an easy solution be to have a checkbox on the itemtypes that says "Do not
include in 'Holds to pull' report"? And then exlude items with that setting
when the "Holds to pull" is generated?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

Owen Leonard  changed:

   What|Removed |Added

  Attachment #77498|0   |1
is obsolete||
  Attachment #77521|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 79172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79172=edit
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #41 from Blou  ---
Fixed the rest, but for the padding in the button, we'll need to find another
solution since an  under a class="dialog message" will show like that. 
Not sure why the staff.css specifies that padding, but clearly having a confirm
button in a message dialog is not the standard Koha way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Blou  changed:

   What|Removed |Added

  Attachment #79122|0   |1
is obsolete||

--- Comment #40 from Blou  ---
Created attachment 79171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79171=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #3 from Marcel de Rooy  ---
Created attachment 79167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79167=edit
Bug 21336: DBIx schema changes

Changes for additional column flgAnonymized.
No test plan.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #6 from Marcel de Rooy  ---
Created attachment 79170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79170=edit
Bug 21336: Adjust cleanup_database.pl

Add the new Patron routines to this cron job. Actions are performed only if
preferences are set.

Note: No specific command line flags for these actions are added here
(and probably not needed too). So no crontab changes too.

Test plan:
Add a new patron.
Enable GDPR_Policy and refuse consent on OPAC for this patron.
Set only the first delay to zero (0) for immediate action.
Run cleanup_database.pl --logs (or any other flag) for the first time.
Check lock and expiration.
Set the second delay to zero (0) for immediate action.
Run cleanup_database.pl --logs for the second time. Check anonymization.
Set the third delay to zero (0) for immediate action.
Run cleanup_database.pl --logs for the third time. Check removal.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #1 from Marcel de Rooy  ---
Created attachment 79165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79165=edit
Bug 21336: Small adjustment in Koha::Token

Allow a pattern too in Koha::Token->generate. Only supported length.
Does not affect CSRF calls. So tiny change without further impact.

Test plan:
Run  t/Token.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #5 from Marcel de Rooy  ---
Created attachment 79169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79169=edit
Bug 21336: Search, lock and anonymize methods

Add Koha::Patron->lock and anonymize.
Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates
and search_anonymized. And wrappers for lock and anonymize.
Add unit tests.

Test plan:
Run t/db_dependent/Koha/Patrons.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #4 from Marcel de Rooy  ---
Created attachment 79168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79168=edit
Bug 21336: Dbrev for new prefs

This patch adds three new prefs:
- UnsubscribeReflectionDelay
- PatronAnonymizeDelay
- PatronRemovalDelay

Test plan:
Run upgrade.
Check patrons pref page. Look under Privacy.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Process unsubscribe requests automatically

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #2 from Marcel de Rooy  ---
Created attachment 79166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79166=edit
Bug 21336: Database revision for borrowers.flgAnonymized

This new flag should speak for itself ;)

Test plan:
Run installer or updatedatabase.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881

--- Comment #19 from Alex Arnaud  ---
I can't reproduce that.

Hiding a column set is_hidden to 1 and vice versa.
I may miss a specific use case. Can you tell me exactly what you did?

As you've probably noticed, we don't store the column name in database but the
corresponding mapped subfield. Are you checking the right one?

Also, changes are done using an asynchronous call to the API. This may take
some time depending on your local instance/hardware.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13272] Many inputs lack a type attribute

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272

--- Comment #12 from Owen Leonard  ---
Created attachment 79164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79164=edit
Bug 13272: Followup on tab issues

Cleaned up whitespace issues tab vs. space in template.
After applying all patches:
git diff -w origin/master
For the koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
only the changed type="text" lines will show, but without the
-w, there will be more whitespace changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13272] Many inputs lack a type attribute

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272

Owen Leonard  changed:

   What|Removed |Added

  Attachment #79018|0   |1
is obsolete||
  Attachment #79120|0   |1
is obsolete||
  Attachment #79123|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 79162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79162=edit
Bug 13272: Adds type="text" to inputs missing it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13272] Many inputs lack a type attribute

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272

--- Comment #11 from Owen Leonard  ---
Created attachment 79163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79163=edit
Bug 13272: Followup on comment #5

Correct the two issues I pointed out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13272] Many inputs lack a type attribute

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #165 from Josef Moravec  ---
Created attachment 79161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79161=edit
Bug 18606: Fix TT filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

--- Comment #7 from Blou  ---
And yes, David's steps were... hum... lacking?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

--- Comment #6 from Blou  ---
Examine opac-tmrpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl around line 110
(just below the "Wrapper div" comment.  You'll find

record

Translate, then look at the (fr-CA) version, you'll find

notice

This will in turn create in the webpage some http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21380] Circulation history UI improvements - make barcode clickable

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21380

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21380] Circulation history UI improvements - make barcode clickable

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21380

--- Comment #4 from Josef Moravec  ---
Created attachment 79160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79160=edit
Bug 21380: (QA follow-up) Use uri filter in link parameters

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21380] Circulation history UI improvements - make barcode clickable

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21380

Josef Moravec  changed:

   What|Removed |Added

  Attachment #79124|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 79159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79159=edit
Bug 21380: Circulation history UI improvements - make barcode clickable

This patch modifies the patron circulation history template so that the
barcode of each item links to the item details page.

To test, apply the patch and view the circulation history for a patron
with multiple current or past checkouts.

In the table of titles, the barcode for each item should correctly link
to the item details page for that item.

Signed-off-by: Michal Denar 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #164 from Josef Moravec  ---
(In reply to Alex Arnaud from comment #144)
> Also, we lost the "reason" in error messages when adding/removing items.
>   - Failed to add item with barcode : Item is already in this
> collection   => Failed to add item with barcode 
>   - Failed to add item with barcode unknown_barcode: No item with matching
> barcode found=> Failed to add item with barcode unknown_barcode
>   - Failed to remove item with barcode unknown_barcode: No item with
> matching barcode found => Failed to remove item with barcode unknown_barcode

I rebased the patches on master and now I am working on the error messages,
follow-up will come soon - hopefully

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #163 from Josef Moravec  ---
(In reply to Alex Arnaud from comment #143)
> Comment on attachment 72574 [details] [review]
> Bug 18606: Database changes - Add foreign keys to collections_tracking
> 
> Review of attachment 72574 [details] [review]:
> -
> 
> ::: installer/data/mysql/kohastructure.sql
> @@ +969,5 @@
> > +  PRIMARY KEY (collections_tracking_id)
> > +) ENGINE=InnoDB  DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
> > +
> > +ALTER TABLE `collections_tracking`
> > +  ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) 
> > REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE;
> 
> Why did add constraints separatly from the table creation? It seems to me
> that it is less readable for people wanting to quickly get the structure of
> the table.

No strong reason from me, fixed in follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #159 from Josef Moravec  ---
Created attachment 79155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79155=edit
Bug 18606: Unify handling of success/error messages

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2018-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #161 from Josef Moravec  ---
Created attachment 79157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79157=edit
Bug 18606: (follow-up) Remove lines from collections_tracking referencing non
existant objects

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >