[Koha-bugs] [Bug 19524] Share patron lists between staff

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #16 from Katrin Fischer  ---
Hm, there is a new field 'shared', but it's not mentioned in the test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19524] Share patron lists between staff

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer  ---
This reads like quite a behavior chance - moving things from being private to
be shared. Would be good to have some text for the release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #115 from Katrin Fischer  ---
Maybe we could promote this to 'new feature' to hightlight in release notes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15326] Add CMS feature

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15326] Add CMS feature

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #46 from Aleisha Amohia  ---
Created attachment 79269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79269=edit
Bug 15326: (follow-up) Pages navigation fixes

This is the best I've managed to do with the navigation. Would be happy
for someone else to give it a go because I'm aware that some parent
links repeat.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005

Dilan Johnpullé  changed:

   What|Removed |Added

 CC||di...@calyx.net.au
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Dilan Johnpullé  ---
Error results when applying patch:

vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 21005
Bug 21005 - Missing row/column defaults cause unexpected results in report
wizards

77644 - Bug 21005: Missing row/column defaults cause unexpected results in
report wizards

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21005: Missing row/column defaults cause unexpected results in
report wizards
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 21005: Missing row/column defaults cause unexpected
results in report wizards
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-21005-Missing-rowcolumn-defaults-cause-unexpec-XprggD.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21397] Routing list tab not marked as active

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21397

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||di...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21397] Routing list tab not marked as active

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21397

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #79262|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 79268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79268=edit
Bug 21397: Mark "Routing list" tab as active when selected

/members/routing-lists.pl?borrowernumber=5 show the different tab of the
menu but "Routing lists" is not displayed as the selected one (active).

"routinglistview" must be set and passed to the template

Test plan:
Enable the RoutingSerials pref
and hit /members/routing-lists.pl?borrowernumber=42

The "Routing lists" tab must be selected/active

Followed test plan and tab now shows as active.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19309] Add ReservesMaxPickUpDelay to the Circulation Matrix

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|NEW |In Discussion
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8367

--- Comment #1 from Alex Buckley  ---
Possible duplicate of bug 8367?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19309

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #3 from Alex Buckley  ---
Created attachment 79267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79267=edit
Bug 20844 - Revert hold when setting an item to lost

If an item is marked as 'Lost' then this patch introduces the following
new functionality:

1. Check if there is a bib-level or item-level hold on the item with the
status of 'W' (waiting). This is an allocated hold which is not yet
checked out to the requesting patron.

1.a. If the hold was originally a bib-level reserve
(reserves.originalholdtype='B') then
do the following:

* Revert the waiting status of the reserve
* Set the reserves.itemnumber=NULL so the hold is reset to a bib-level
hold

1.b. If the hold was originally (and still is) a item-level hold
(reserves.originalholdtype='I') then
display a alert dialog box on the additem.pl interface asking the
librarian to select one of two options:

* Cancel the hold - This deletes the hold altogether
* Retain the hold - This does not change the hold. Therefore the
requester will still have a hold on a lost item

NOTE: Previously an allocated bib-level hold was identical to a item-level hold
in the database.
As the first available item on the bib record had been allocated to the
requester and so an itemnumber had been set in the record in the reserves
table.

However this patch introduces a atomicupdate which adds the new column
'originalholdtype' to the reserves table. This allows us to track if the
reserve was originally a bib level hold and treat it differently when
the allocated item is being marked as 'Lost'

Test plan:
1. Place a bib-level hold on a biblio
2. Check out an item from the biblio to a different patron
3. Query the reserves db table for biblio you placed the bib-level
hold and notice it has no 'itemnumber' or 'status' value
4. Return the item and confirm the hold in the modal box that is loaded
5. Query the reserves db table and notice the itemnumber field is now
filled with the returned item's itemnumber and the status is 'W'
6. Set the item to 'Lost' either by clicking on Edit->Edit items from
the detail.pl page
OR
clicking on the Items tab on the left side of the detail.pl page
7. Notice the waiting item-level hold still exists after the item is
marked as 'lost'

8. Repeat steps 1-7 but this time place an item-level hold on an item in
step 1 and then check that same item out in step 2. Notice in the
repeated step 7 that the hold remains after marking the item as 'Lost'
9. Apply patch and run ./updatedatabase.pl from the koha-shell in the
installer/data/mysql/ directory

9. Repeat steps 1-6 placing an bib-level hold and then query the
database and notice the bib-level hold which was changed to an allocated
waiting item-level hold when the item was returned and the hold
confirmed is now reverted to a bib-level hold again. This is controlled
by the LostBibLevelHoldsRevert syspref.

If this syspref is not enabled then the allocated item-level (originally
bib-level hold) will remain after the item is marked as lost.

10. Repeat 1-6 but this time place an item-level hold on the item.
Notice when you mark the item as 'Lost' a yellow warning box is
displayed asking if you want to 'Retain hold' or 'Cancel hold'. Select
'Retain hold' and notice the item-level hold remains now the item is marked as
lost.

11. Repeat step 10 but choose 'Cancel hold' option and notice the hold
is deleted now.

12. Now enable the new 'LostItemCancelOutstandingTransfers' syspref.
This will now cancel any outstanding transfers on the item when it is
marked as lost.

13. Find a item which is in transfer, i.e. find an item with the text in
the 'Status' field of the table in detail.pl that indicates it is in
transfer

14. Now mark that item as 'Lost' and now notice the transfer is
cancelled

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Michal Denar  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20486] Add --marc_conditions option to export_records.pl

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486

Michal Denar  changed:

   What|Removed |Added

  Attachment #75110|0   |1
is obsolete||

--- Comment #11 from Michal Denar  ---
Created attachment 79266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79266=edit
Bug 20486: Add --marc_conditions option to export_records.pl

Add --marc_conditions option to export_records.pl script, for
excluding records based on conditions applied to MARC-record
data.

How to test:
1) Run tests in t/Exporter/Record.t
2) All tests should pass

Sponsored-by: Gothenburg University Library

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20486] Add --marc_conditions option to export_records.pl

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21400] New: Cronjobs: processes exited with return code 1

2018-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21400

Bug ID: 21400
   Summary: Cronjobs: processes exited with return code 1
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

I have recently updated Koha to 18.05. From this moment on, two emails are sent
from Debian's cronjob system with these msg:

run-parts: /etc/cron.weekly/koha-common exited with return code 1
run-parts: /etc/cron.hourly/koha-common exited with return code 1



Weekly: cleanup_databases.pl
Hourly: process_message_queue.pl


cleanup_databases.pl runs daily too, together with other scripts, but no email
is sent.

Well, has anybody experience or suggestion about this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/