[Koha-bugs] [Bug 21397] Routing list tab not marked as active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21397 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21038] Reserves should be holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification tool throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED --- Comment #13 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m --- Comment #13 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20994] Fix capitalization on OPAC result list "Save to Lists"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #80178|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #80178|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #80182|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #217 from Andreas Roussos --- Created attachment 80182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80182=edit Bug 6473: Update LICENSE version and date This commit updates the version and date of the LICENSE. --- a/LICENSE +++ a/LICENSE @@ -51,3 +51,3 @@ modified versions of the software inside them, although the manufacturer -can do so. This is fundamentally incompatible with the aim of +can do so. This is fundamentally compatible with the aim of protecting users' freedom to change the software. The systematic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #80181|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #216 from Andreas Roussos --- Created attachment 80181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80181=edit Bug 6473: Test bug for Git-bz LICENSE file updated to reflect recent changes. README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/README +++ a/README @@ -1,3 +1,3 @@ -Koha is a free software integrated library system. - +Koha is a paid-for software integrated library system. + Koha is distributed under the GNU GPL version 3 or later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added CC||arouss1...@gmail.com Attachment #80180|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #80179|0 |1 is obsolete|| --- Comment #215 from Andreas Roussos --- Created attachment 80180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80180=edit Bug 6473: Test bug for Git-bz LICENSE file updated to reflect recent changes. --- a/README +++ a/README @@ -1,3 +1,3 @@ -Koha is a free software integrated library system. - +Koha is a paid-for software integrated library system. + Koha is distributed under the GNU GPL version 3 or later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #214 from Andreas Roussos --- Created attachment 80179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80179=edit Bug 6473: Test bug for Git-bz LICENSE file updated to reflect recent changes. And now for some more evil lines: --- a/README +++ b/README @@ -1,3 +1,3 @@ -Koha is a free software integrated library system. - +Koha is a paid-for software integrated library system. + Koha is distributed under the GNU GPL version 3 or later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #80178|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21073] Improve plugin performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #8 from David Cook --- (In reply to Kyle M Hall from comment #7) > (In reply to David Cook from comment #6) > > Do you have some examples of plugins we can use before and after this patch? > > Any and all plugins should be valid. The Kitchen Sink would be a good test. Cool, so something like the following? 0) Install Kitchen Sink plugin 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing Kitchen Sink plugin 5) Remove Kitchen Sink plugin 6) Verify you can install new Kitchen Sink plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Andreas Roussos changed: What|Removed |Added Attachment #79959|0 |1 is obsolete|| --- Comment #213 from Andreas Roussos --- Created attachment 80178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80178=edit Updated LICENSE file to the latest version. Evil lines follow: --- a/README +++ b/README @@ -1,4 +1,4 @@ -Koha is a free software integrated library system. +Koha is a paid-for software integrated library system. Koha is distributed under the GNU GPL version 3 or later. Please read the file LICENSE for more details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21400] Cronjobs: processes exited with return code 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21400 --- Comment #1 from Claudio --- I'm worried about this issue because I do not know if it could be a program error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Michal Denar changed: What|Removed |Added Attachment #80176|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 80177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80177=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos changed: What|Removed |Added Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 --- Comment #1 from Andreas Roussos --- Created attachment 80176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80176=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos changed: What|Removed |Added Assignee|oleon...@myacpl.org |arouss1...@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] New: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Bug ID: 21513 Summary: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: arouss1...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 80175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80175=edit missing 'Cancel' button and duplicate 'Save' button The bibliographic editor (cataloguing/addbiblio.pl) includes a 'Cancel' button in its toolbar at the top. Actually, most pages in Koha which allow you to add/edit something (e.g. MARC Framework, Authority types, Authorised values, etc.) have a 'Cancel' button or link. The authority editor (authorities/authorities.pl), however, does not have a 'Cancel' button. Oddly, it has two 'Save' buttons, as per the attached screenshot. I propose to: a) add a 'Cancel' button to the toolbar at the top of the page b) remove the 'Save' button from the bottom of the page since the floating toolbar already has one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21512] CalculateFinesOnReturn doesn't work without the syspref finesMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Olli-Antti Kivilahti changed: What|Removed |Added Change sponsored?|--- |Sponsored --- Comment #2 from Olli-Antti Kivilahti --- Bug found and fix sponsored by Minna Kivinen @ https://www.hamk.fi/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21512] CalculateFinesOnReturn doesn't work without the syspref finesMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 80174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80174=edit 0001-Bug-21512-CalculateFinesOnReturn-doesn-t-work-withou.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21512] CalculateFinesOnReturn doesn't work without the syspref finesMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Olli-Antti Kivilahti changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21512] New: CalculateFinesOnReturn doesn't work without the syspref finesMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Bug ID: 21512 Summary: CalculateFinesOnReturn doesn't work without the syspref finesMode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivila...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Fines are not created for checking in an Item, if the syspref 'CalculateFinesOnReturn' is enabled without the syspref finesMode being in the 'production' -mode (Calculate and charge). CalculateFinesOnReturn must work without the fines.pl -feature. The problem is with the subroutine C4::Circulation::_CalculateAndUpdateFine() Initially it looks like it must be invoked from the fines.pl as well. But that subroutine is only used within the C4::Circulation module for AddRenew and AddReturn. Hence the _CalculateAndUpdateFine() has nothing to do with fines.pl|finesMode. This patch replaces the finesMode-check with CalculateFinesOnReturn-check. I am not sure why there needs to be a specific syspref for the fines.pl, or why CalculateFinesOnReturn is needed, as the fine amounts can be tweaked using the circulation rules matrix and the fines.pl-cronjob can either be ran, or not, with an endless possibility of parameters that shouldn't be in the sysprefs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21455] Authority search options get shuffled around when you click on 'Search'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 --- Comment #8 from Andreas Roussos --- (In reply to Katrin Fischer from comment #5) > This doesn't work for me yet, when I search, the tab still jumps back to the > first. (applied patch, restart all, reloaded the page mulitple times) My bad really, now that I re-read the bug description and test plan for the patch I realise I should have been more explicit. Nevertheless it's interesting to see how your testing led to the discovery of yet another authorities-related bug! ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
