[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21479 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21174 CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2 from Alex Buckley --- Actually I want to make a few more changes to this solution for master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #41 from Aleisha Amohia --- Created attachment 80252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80252=edit Bug 8628: (follow-up) Some template fixes This patch: - makes the stream name a required field - fixes the link to the OPAC sign view - fixes the toolbar in staff side Still have not fixed the overlapping of titles. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Assignee|mar...@bugs.koha-community. |alei...@catalyst.net.nz |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #1 from Alex Buckley --- Created attachment 80251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80251=edit Bug 21486: Re-added get_pending_issues function to C4/SIP/ILS/Patron.pm This allows the list of a borrower's checked out items to be returned by SIP. Test plan: 1. Make sure SIP is working with the commands: sudo koha-enable-sip sudo koha-start-sip 2. Check SIP is working with the command: telnet localhost 6001 3. Choose a patron with items checked out to them and set their username and password in the SIPconfig.xml file 4. From inside the Koha-shell from the Koha home directory run the command: misc/sip_cli_emulator.pl -a localhost -p 6001 -su -sp -l --patron -s " Y " -m patron_information This command is PATRON_INFORMATION, it should return information about the patron. The Y in the 3rd position of the quotes means return the list of the borrowers charged items (items issued to the borrower). 5. Notice the "AU" field is empty: e.g. READ: 64 00120181008 161428000100010002AOCPL|AA8765432|AEMika SMith|BLY|CC5|AU|PCB|PIY|AFGreetings from Koha. | i.e. There should be a barcode after the AU field as the borrower has a item issued to them 6. Apply patch 7. Restart memcached and plack with the commands: sudo service memcached restart sudo koha-plack --restart 8. Stop SIP: sudo koha-stop-sip 9. Then enable and start SIP again: sudo koha-enable-sip sudo koha-start-sip 10. Repeat step 4 and notice the AU field does have a item barcode value: e.g. READ: 64 00120181008 161859000100010002AOCPL|AA8765432|AEMika SMith|BLY|CC5|AUTEST7474747474|PCB|PIY|AFGreetings from Koha. | In this case the item barcode value for the AU field is: TEST7474747474 Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77145|0 |1 is obsolete|| --- Comment #40 from Aleisha Amohia --- Created attachment 80250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80250=edit Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77143|0 |1 is obsolete|| --- Comment #38 from Aleisha Amohia --- Created attachment 80248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80248=edit Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77144|0 |1 is obsolete|| --- Comment #39 from Aleisha Amohia --- Created attachment 80249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80249=edit Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21389] Javascript error on article requests page bis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Chris Cormack changed: What|Removed |Added Attachment #79226|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 80247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80247=edit Bug 21389: Correct Javascript error on article requests page Bug 21076 fixed a Javascript error on article requests page when patron is found. There is also an error when patron is not found, with message : Patron not found No patron with this name, please, try another This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input. Test plan: 1 - Do not apply patch 2 - Enable article requests 3 - Search on staff client and click 'Request article' 4 - Search for a patron that does not exist 5 - You get a yellow message "Patron not found" 6 - View error in console 7 - Apply patch 8 - Reload 9 - Not error is gone 10 - Search for a patron that does exist 11 - Check there is no error in console 12 - Check that autocompletion works Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21389] Javascript error on article requests page bis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #80119|0 |1 is obsolete|| --- Comment #71 from Aleisha Amohia --- Created attachment 80246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80246=edit [SIGNED-OFF] Bug 8630: (follow-up) Template corrections This patch makes two corrections to templates: One to correct the case of a variable, an error which I introduced when adding html filters. The other removes a redundant image tag from the recent comments template. To test, apply the patch and log in to the OPAC as a user with checkouts. Cover images on the "your summar" page should appear correctly. View the "recent comments" page and confirm that images still appear correctly. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #80111|0 |1 is obsolete|| --- Comment #70 from Aleisha Amohia --- Created attachment 80245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80245=edit [SIGNED-OFF] Bug 8630: (follow-up) Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Chris Cormack changed: What|Removed |Added Attachment #79414|0 |1 is obsolete|| --- Comment #15 from Chris Cormack --- Created attachment 80244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80244=edit Bug 20548: (follow-up) Fix unit tests Removed the "Backend create: copyright clearance" unit test since we no longer have a "copyrightclearance" stage, hence we don't have a block in the template handling it, hence the test failure! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Chris Cormack changed: What|Removed |Added Attachment #79051|0 |1 is obsolete|| --- Comment #14 from Chris Cormack --- Created attachment 80243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80243=edit Bug 20548: Remove copyright clearance for staff This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood Signed-off-by: Barry Cannon Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Signed Off |Patch doesn't apply --- Comment #30 from Chris Cormack --- Could you do a rebase please, there we a few too many conflicts for me to fix without breaking things accidentally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16420] Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16420] Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Chris Cormack changed: What|Removed |Added Attachment #80145|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 80242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80242=edit Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold." Signed-off-by: Michal Denar Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21487] Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Chris Cormack changed: What|Removed |Added Attachment #80156|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 80241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80241=edit Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same Signed-off-by: David Nind Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21487] Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #154 from David Gustafsson --- Ok! No problem, will have a look at and fix these issues, it could take a week or so before I have the time though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263
Cori Lynn Arnold` changed:
What|Removed |Added
Attachment #80237|0 |1
is obsolete||
--- Comment #11 from Cori Lynn Arnold` ---
Created attachment 80240
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80240=edit
Bug 19263: Rancor - Add auto control number (001) widget
To test you need access to the database.
1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to
table authorised_value_categories
2) Edit a record using advanced editor and note that widget does NOT show
for 001 field
3) Enter a new value for authorised_values table with:
CONTROL_NUM_SEQUENCE in category column
authorised_value column has string ending with a number
lib column has a short string indicating type of control seq ("FAW")
4) Edit a record using advanced editor and note that the widget does show
for 001 field
Change inclues database update for new installations.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21433] Switch two-column templates to Bootstrap grid: Tools part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21433 lucasgass changed: What|Removed |Added Attachment #79516|0 |1 is obsolete|| --- Comment #2 from lucasgass --- Created attachment 80239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80239=edit Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1 This patch modifies several tools templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 21433] Switch two-column templates to Bootstrap grid: Tools part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21433 lucasgass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21518] New: Material type "three-dimensional artifact" displays as "visual material"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 Bug ID: 21518 Summary: Material type "three-dimensional artifact" displays as "visual material" Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: isabel.pin...@ds.edu.sv QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl A catalog record with material type r (three-dimensional artifact) displays as g (visual material) - the icon as well as the description, in the admin interface as well as in the OPAC. Looking at the source code, I see that the icon VM.png is used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Chris Cormack changed: What|Removed |Added Attachment #79718|0 |1 is obsolete|| --- Comment #11 from Chris Cormack --- Created attachment 80238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80238=edit Bug 21426: Handle USE_MEMCACHED=no in koha-create Signed-off-by: Andreas Roussos Works as intended. I've set USE_MEMCACHED to "no" and created a new Koha instance. Home > About now reports this information: Memcached: Servers: undefined | Namespace: undefined | Status: unknown | Config read from: Nowhere [...] | Effective caching method: Cache::Memory Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from Cori Lynn Arnold` --- See Comment 9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263
--- Comment #9 from Cori Lynn Arnold` ---
Created attachment 80237
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80237=edit
Bug 19263: Rancor - Add auto control number (001) widget
To test you need access to the database.
1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to
table authorised_value_categories
2) Edit a record using advanced editor and note that widget does NOT show
for 001 field
3) Enter a new value for authorised_values table with:
CONTROL_NUM_SEQUENCE in category column
authorised_value column has string ending with a number
lib column has a short string indicating type of control seq ("FAW")
4) Edit a record using advanced editor and note that the widget does show
for 001 field
Change inclues database update for new installations.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Chris Cormack changed: What|Removed |Added Attachment #80215|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 80236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80236=edit Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21440] koha-create expects the file passed by $DEFAULTSQL to be in gzip format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21440 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21440] koha-create expects the file passed by $DEFAULTSQL to be in gzip format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21440 Chris Cormack changed: What|Removed |Added Attachment #80216|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 80235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80235=edit Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format koha-create contains a call to `zcat` which fails if the file passed as an argument is not in gzip format. This patch fixes the issue by adding the -f flag to the zcat call in koha-create, as per the top-voted answers in the following SE URLs: https://unix.stackexchange.com/a/77309 https://unix.stackexchange.com/a/131944 Test plan: 1) in /etc/koha/koha-sites.conf, set the DEFAULTSQL variable to point to an _uncompressed_ SQL database dump 2) run `koha-create --create-db instance` and notice how it fails with: gzip: /path/to/dump.sql: not in gzip format 3) apply the patch 4) notice the extra line of information "The SQL file can be optionally compressed with gzip" in koha-sites.conf 5) run the `koha-create` command again, this time it should work 6) repeat with DEFAULTSQL pointing to a gzip'd dump, it should work too Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21493] Remove incomplete icon style from serial issues tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21493] Remove incomplete icon style from serial issues tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Chris Cormack changed: What|Removed |Added Attachment #80218|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 80234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80234=edit Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |oleon...@myacpl.org |ommunity.org| QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 --- Comment #16 from Jonathan Druart --- I did not test but maybe we should use To.json instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 80233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80233=edit Bug 21503: Tests for the existing behaviour This patch introduces tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart --- Quick feedback on the second patch: 1. Commit message must start with "Bug 19263: ", not a big deal ;) 2. Changes in the atomic update files will affect existing installations only. Changes to installer/data/mysql/mandatory/auth_val_cat.sql must be provided for new installations. 3. At first glance the second remark from comment 4 has not been taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21405] Pagination in authorities search broken for Zebra and broken for 10000+ results in ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21405] Pagination in authorities search broken for Zebra and broken for 10000+ results in ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Martin Renvoize --- Should there not be a test accompanying this for Koha/SearchEngine/Elasticsearch/Search.pm search_auth_compat to ensure we don't get future regressions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20772] Make request metadata editable and add price_paid field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #48 from Andrew Isherwood --- Created attachment 80232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80232=edit Bug 20772: (follow-up) Add unit test Add unit test for price_paid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #7 from Cori Lynn Arnold` --- Bug 19263 Rancor - Add auto control number (001) widget In advanced editor mode for cataloging, the 001 widget will automatically assign the next control number if a format is defined in authorised_values table. To test you need access to the database. 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Enter a new value for authorised_values with the authorised_value column ending in a number 3) Edit a record using the advanced editor, specifically the 001 field 4) Note the new widget and option to increment or assign manually. The buttons fit within the widget now, and there's a database update to create the CONTROL_NUM_SEQUENCE. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #6 from Cori Lynn Arnold` --- Created attachment 80231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80231=edit Bug 19263 Advanced Editor - Rancor - Add auto control number (001) widget In advanced editor mode for cataloging, the 001 widget will automatically assign the next control number if a format is defined in authorised_values table. To test you need access to the database. 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Enter a new value for authorised_values with the authorised_value column ending in a number 3) Edit a record using the advanced editor, specifically the 001 field 4) Note the new widget and option to increment or assign manually. The buttons fit within the widget now, and there's a database update to create the CONTROL_NUM_SEQUENCE. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 --- Comment #29 from Andrew Isherwood --- I had to squash: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80101 and https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80104 as the problem in the first was causing it to fail to apply before it got to the second which fixed the problem. So now they're a single patch which should apply correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Andrew Isherwood changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com Attachment #80104|0 |1 is obsolete|| --- Comment #28 from Andrew Isherwood --- Comment on attachment 80104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80104 Bug 18591: (QA follow-up) Fix merge error in kohastructure.sql This patch was squashed into https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80227 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591
Andrew Isherwood changed:
What|Removed |Added
Attachment #80102|0 |1
is obsolete||
--- Comment #25 from Andrew Isherwood ---
Created attachment 80228
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80228=edit
Bug 18591: Allow any number of comments on ILLs
This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.
To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
is displayed in the "Comments" column
- Check that the tests pass:
prove t/db_dependent/Illcomments.t
Signed-off-by: andrew.isherw...@ptfs-europe.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Andrew Isherwood changed: What|Removed |Added Attachment #80103|0 |1 is obsolete|| --- Comment #26 from Andrew Isherwood --- Created attachment 80229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80229=edit Bug 18591: (follow-up) Add missing html filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Andrew Isherwood changed: What|Removed |Added Attachment #80105|0 |1 is obsolete|| --- Comment #27 from Andrew Isherwood --- Created attachment 80230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80230=edit Bug 18591: (follow-up) Add more POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Andrew Isherwood changed: What|Removed |Added Attachment #80101|0 |1 is obsolete|| --- Comment #24 from Andrew Isherwood --- Created attachment 80227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80227=edit Bug 18591: Database updates Signed-off-by: andrew.isherw...@ptfs-europe.com Bug 18591: (QA follow-up) Fix merge error in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` changed: What|Removed |Added Assignee|n...@bywatersolutions.com |carn...@dgiinc.com Status|Failed QA |ASSIGNED --- Comment #5 from Cori Lynn Arnold` --- Making changes based on feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #66 from Martin Renvoize --- Comment on attachment 79951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79951 Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. Review of attachment 79951: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=79951) - Can one still overpay when using this system? What if the librarian finds they don't have the appropriate change in the drawer, can they continue with the transaction inputting the full amount and as such creating a credit? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +108,5 @@ > + > + > + > +Change to give: > + This shouldn't be an 'input' in my opinion, rather it should be more clearly distinguished as information.. perhaps a span with a class highlighting in 'red' if the patron is owed change? @@ +220,5 @@ > + > + > + > +Change to give: > + As above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Works as expected, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Martin Renvoize changed: What|Removed |Added Attachment #80054|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 80226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80226=edit Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 --- Comment #9 from Martin Renvoize --- I think that would do the trick, yeah. Not sure if there's anything else I'm missing though ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21517] New: OAI returns records outside of specified time range.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21517 Bug ID: 21517 Summary: OAI returns records outside of specified time range. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: rudolfby...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 80225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80225=edit The XML output of the OAI-PMH request. Example: http://brutus.local:8092/cgi-bin/koha/oai.pl?verb=ListRecords=oai_dc=2012-11-03=2012-11-04 Output contains results from 2014. Attached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Rudolf Byker changed: What|Removed |Added CC||rudolfby...@gmail.com --- Comment #1 from Rudolf Byker --- This makes a HUGE difference for anyone not in a UTC timezone. I think this should be higher priority... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #14 from Martin Renvoize --- also, as much as I personally don't like it.. you'd be best to conform the the guidelines for your new field name: https://wiki.koha-community.org/wiki/Koha_Objects#Database_Table_Conventions - Every foreign key should have the same name as the primary key it links to when possible ( exceptions would be multiple FKs to the same table, and where a descriptor is better e.g. widgets.borrowernumber = widgets.managing_borrowernumber ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #13 from Martin Renvoize --- A few points. 1) This information is actually already stored in the statistics table (though I'll happily admit that's a pain and not especially useful for querying against) 2) It feels confusing to have this at the account_offsets level (which often has both debit_id and credit_id), it feels like it would be better placed in accountlines to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 --- Comment #25 from Martin Renvoize --- Marking as blocked pending bug 19893 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 Martin Renvoize changed: What|Removed |Added Status|Signed Off |BLOCKED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20772] Make request metadata editable and add price_paid field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Andrew Isherwood changed: What|Removed |Added Summary|Bib metadata pertaining to |Make request metadata |an ILL request should be|editable and add price_paid |editable|field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Andrew Isherwood changed: What|Removed |Added Text to go in the||Added the new price_paid release notes||field to ILL requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Added followup to be consistent across the board. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Martin Renvoize changed: What|Removed |Added Attachment #79661|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 80223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80223=edit Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 --- Comment #6 from Martin Renvoize --- Created attachment 80224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80224=edit Bug 21456: (QA follow-up) Catch missed case in authorities merge Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20941] Displaying requests does not display request material type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #37 from Andrew Isherwood --- Responses to comment #35: >This seems to be a spelling mismatch. The type for new requests saves with the >first letter being lower case (article) while the the pull downs look for >(Article) This was a bug in the FreeForm backend and has now been fixed. Details: https://github.com/PTFS-Europe/koha-ill-freeform/commit/ddff82bc9adc4bd7205192543b6e18c4ad844bb0 >I am also not clear on the switch from medium to type, there are still lines >like these in the code: media => [ "Book", "Article", "Journal" ], >(ill-requests.pl) This has been fixed, see comment #36 >It's also a little odd that the rquest type shows in 2 places, in the "Request >details" and the "Details from supplier" sections. The details listed here are all metadata relating to the request and will be dependent on the backend from which the request was made, some backends (BLDSS for example) won't even include "type". Whether this display is even necessary is debatable, since bug 20561 added a modal that displays all this information, it just formats it a bit less nicely. I think there's room for improvement in this area, but would suggest it as a future enhancement rather than addressing it here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21506] DataTables four button pagination uses the wrong icon for First and Last buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Works as expected, code is reasonable and I've not spotted anywhere it's not applying (shared library code). Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21506] DataTables four button pagination uses the wrong icon for First and Last buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Martin Renvoize changed: What|Removed |Added Attachment #80161|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 80222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80222=edit Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons Pages with DataTables' four button pagination use the wrong icon for 'First' and 'Last'. Also, the icons for all four buttons are truncated at the bottom. This patch fixes that. Test plan: 1) Go to a page that uses four button pagination (e.g. Home > Administration > MARC frameworks) and notice how the pagination icons for First/Previous and Next/Last are the same. Also notice all four icons are clipped at the bottom. 2) Apply the patch. 3) Refresh the page; the First and Last buttons' icons now include a vertical bar, and there is no clipping visible. 4) For completeness, check other affected pages as well. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 Martin Renvoize changed: What|Removed |Added Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- I'm a little disturbed by the lack of tests for Koha::EDI, but can't warrant failing qa here for that as it's the entire module that's lacking, not just this bugfix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 Martin Renvoize changed: What|Removed |Added Attachment #79525|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 Martin Renvoize changed: What|Removed |Added Attachment #79607|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 --- Comment #14 from Martin Renvoize --- Created attachment 80221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80221=edit Bug 21417: (QA follow-up) Display default EAN as such in admin display A branch value of null is interpreted as the default Add text 'All libraries' to this case in the display rather than blank so that its function is clear to the user Signed-off-by: Pierre-Marc Thibault Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 --- Comment #13 from Martin Renvoize --- Created attachment 80220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80220=edit Bug 21417: EDI ordering fails when basket and EAN libraries do not match When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message. We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean. Test Plan: 1) Apply this patch set 2) Run updatedatabase 3) Verify you can create a Library EAN without setting a branchcode for it 4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set Signed-off-by: Colin Campbell Signed-off-by: Pierre-Marc Thibault Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21417] EDI ordering fails when basket and EAN libraries do not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21417 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #79525|signed off patch adding |Bug 21417: EDI ordering description|default option |fails when basket and EAN ||libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- I like Owens alternative.. as he says, it just feels more robust. QA Comment though.. could we possibly add a selenium test for this perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Martin Renvoize changed: What|Removed |Added Attachment #79950|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 80219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80219=edit Bug 21479: (alternate) Removing from cart removes 2 items This patch changes the way biblionumbers are passed to the cart script for adding and removing single items. The title's biblionumber is now stored in a data-attribute on the links for adding and removing. This should be a more robust, unified way to handle these single-item operations. To test, apply the patch and enable the opacbookbag system preference. Test adding and removing items from the cart from various pages using various methods: - By clicking an "Add to your cart" / "Remove" link in search results - By clicking an "Add to your cart" / "Remove" link on a detail page - By checking boxes in search results and adding via the dropdown Each operation should work correctly. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21493] Remove incomplete icon style from serial issues tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Always like a bit of cleaning up.. thanks Owen, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #8 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > Hmmm, would this not also disable the 'Opac Maintenance page' for the > duration of the upgrade, which would be undesirable for lengthy DB updates > for example? Maybe if we removed the 'servide koha-common stop' from the preinst file this would keep the spirit, while avoiding the problem you noticed, Martin? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21493] Remove incomplete icon style from serial issues tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Martin Renvoize changed: What|Removed |Added Attachment #79963|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 80218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80218=edit Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Hmmm, would this not also disable the 'Opac Maintenance page' for the duration of the upgrade, which would be undesirable for lengthy DB updates for example? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 Alex Arnaud changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #4 from Alex Arnaud --- (In reply to Martin Renvoize from comment #3) > This one seemed to be a good bug to cut my teeth on as it were with my new > found elastic search setup for testing. > > Looks good, does as expected. Signing off. Thanks Martin, But we'll have to throw this patch away since bug 19893 will completely change the code, and, fix this bug i hope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` changed: What|Removed |Added CC||carn...@dgiinc.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- This one seemed to be a good bug to cut my teeth on as it were with my new found elastic search setup for testing. Looks good, does as expected. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 Martin Renvoize changed: What|Removed |Added Attachment #78560|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 80217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80217=edit Bug 21331: Elasticsearch - fix indexing of concatenated subfields Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21440] koha-create expects the file passed by $DEFAULTSQL to be in gzip format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21440 Martin Renvoize changed: What|Removed |Added Attachment #79541|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 80216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80216=edit Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format koha-create contains a call to `zcat` which fails if the file passed as an argument is not in gzip format. This patch fixes the issue by adding the -f flag to the zcat call in koha-create, as per the top-voted answers in the following SE URLs: https://unix.stackexchange.com/a/77309 https://unix.stackexchange.com/a/131944 Test plan: 1) in /etc/koha/koha-sites.conf, set the DEFAULTSQL variable to point to an _uncompressed_ SQL database dump 2) run `koha-create --create-db instance` and notice how it fails with: gzip: /path/to/dump.sql: not in gzip format 3) apply the patch 4) notice the extra line of information "The SQL file can be optionally compressed with gzip" in koha-sites.conf 5) run the `koha-create` command again, this time it should work 6) repeat with DEFAULTSQL pointing to a gzip'd dump, it should work too Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21440] koha-create expects the file passed by $DEFAULTSQL to be in gzip format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21440 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Nice little fix that works well, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Works as expected for me, signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Martin Renvoize changed: What|Removed |Added Attachment #79783|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 80215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80215=edit Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
