[Koha-bugs] [Bug 21559] Rules for automatic framework codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559 paxed changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21559] Rules for automatic framework codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559 paxed changed: What|Removed |Added Attachment #80587|0 |1 is obsolete|| --- Comment #6 from paxed --- Created attachment 80798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80798=edit Bug 21559: Rules for automatic framework codes Allow setting rules in a system preference, what framework code should be automatically set for biblio, based on the MARC record fields. Does not affect anything if the MarcToFrameworkcodeAutoconvert system preference rules aren't used. The "Default" framework is always overridden, if the rules match, but some other framework chosen by you is always used. Test plan: -- 0) Apply patch, apply the atomicupdate, etc. 1) Go to cataloguing, and import a record without choosing a framework. note how the framework is set to "Default". 2) Bulkmarcimport some records. Check the framework codes for the imported records - they're all "default". 3) Set the following rules in MarcToFrameworkcodeAutoconvert syspref: - 000/06: a: BKS c: SR m: CF This rule sets framework code to 'BKS' if 000/06 is 'a', etc. 4) Repeat 1 and 2, the frameworkcodes should be something else than default, if the record 000/06 was one of 'a', 'c', or 'm'. 5) Go to cataloguing, and import a record, but choose some specific framework - note how the framework you chose is kept, even if the record would match the syspref rules. 6) Repeat 5, but create a new record from scratch. Framework you chose should override the syspref rules. 7) Bulkmarcimport some record, but give the framework-parameter. The framework you chose should override the syspref rules. 8) prove t/Biblio/AutoFrameworkcode.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21593] DBD::mysql::st execute failed: 'koha_kohadev.me.id' when paying fees on paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Alex Buckley changed: What|Removed |Added Component|Fines and fees |Architecture, internals, ||and plumbing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21593] DBD::mysql::st execute failed: 'koha_kohadev.me.id' when paying fees on paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20521 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21593 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21593] New: DBD::mysql::st execute failed: 'koha_kohadev.me.id' when paying fees on paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Bug ID: 21593 Summary: DBD::mysql::st execute failed: 'koha_kohadev.me.id' when paying fees on paycollect.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org When going to pay a users fine the following error is displayed: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.id' isn't in GROUP BY at /home/vagrant/kohaclone/Koha/Objects.pm line 129 at /home/vagrant/kohaclone/C4/Templates.pm line 122 Viewing the logs you see this is caused by this DB error: DBD::mysql::st execute failed: 'koha_kohadev.me.id' isn't in GROUP BY [for Statement "SELECT `me`.`id`, `me`.`category`, `me`.`authorised_value`, `me`.`lib`, `me`.`lib_opac`, `me`.`imageurl` FROM `authorised_values` `me` LEFT JOIN `authorised_values_branches` `authorised_values_branches` ON `authorised_values_branches`.`av_id` = `me`.`id` WHERE ( ( ( `authorised_values_branches`.`branchcode` IS NULL OR `authorised_values_branches`.`branchcode` = ? ) AND `category` = ? ) ) GROUP BY `lib` ORDER BY `category`, `lib`, `lib_opac`" with ParamValues: 0="CPL", 1='PAYMENT_TYPE'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Doing a git bisect I found this error started when the patch 20521 was pushed to master: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #76665|0 |1 is obsolete|| --- Comment #69 from Aleisha Amohia --- Created attachment 80794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80794=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #76667|0 |1 is obsolete|| --- Comment #71 from Aleisha Amohia --- Created attachment 80796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80796=edit Bug 13952: [FOLLOW-UP] Fixing import for default auth type Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #76668|0 |1 is obsolete|| --- Comment #72 from Aleisha Amohia --- Created attachment 80797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80797=edit Bug 13952: [FOLLOW-UP] Fixing export on default biblio framework Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #7|0 |1 is obsolete|| --- Comment #70 from Aleisha Amohia --- Created attachment 80795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80795=edit Bug 13952: [FOLLOW-UP] Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #26 from Aleisha Amohia --- This has now been rebased but note, it fails with ElasticSearch enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18346] Improved web installer containing basic and advanced setup modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #240 from Alex Buckley --- Created attachment 80793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80793=edit Bug 19532: Fixed Internal Server error thrown upon returning recalled item Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #75641|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 80792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80792=edit Bug 16939: (follow-up) Correction for orderreceive.tt This patch makes a change to orderreceive.tt which corresponds to the changes made in the previous patch. To test, apply the patch and set the AcqCreateItem system preference to "receiving an order." - Go to Acquisitions -> Vendor -> Receive shipment. - Submit the "Receive a new shipment" form. - Click "Receive" for an order line. - Fill out the item form and click "Add item." - The table of existing items should display correctly, with a single "Actions" column containing an "Edit" and "Delete" button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #61661|0 |1 is obsolete|| --- Comment #24 from Aleisha Amohia --- Created attachment 80791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80791=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td Edit: Fixing js error Edit: circ/reserveratios.tt updated so that the plus icon doesn't show if there is no link Edit: fixing logic in circ/reserveratios.tt Edit: merge conflicts Edit: updating buttons to bootstrap 3, which i believe fixes the problem in comment 16 To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Followed test plan, works as expected. Signed-off-by: Marc VĂ©ron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #41 from Aleisha Amohia --- Created attachment 80790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80790=edit Bug 12365: (follow-up) Putting backticks in atomicupdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #40 from Aleisha Amohia --- Just wanted to jump in with my input: it makes sense to me that if I'm looking for notes associated to circ rules, I'm going to look at the circ rules table. Working on getting this ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #238 from Alex Buckley --- Created attachment 80788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80788=edit Bug 19532: Amended the detail.pl call to retrieve recalls so now it retrieves recalls with the status of 'R' or 'W' This means the 'Item recalled by' text is displayed in the holdings table in detail.pl for items with a recall with the status of recalled or waiting. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #237 from Alex Buckley --- Created attachment 80787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80787=edit Bug 19532: Stopping recalls awaiting pickup to be issued to patrons other than the patron who recalled. Also fixed the display of item status in the holdings table on detail.pl on staff client so it doesn't say an item has been recalled when the recall has the status of 'F' (fulfilled) or 'C' (cancelled) Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #236 from Alex Buckley --- Created attachment 80786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80786=edit Bug 19532: Fixed display of recall buttons on opac-course-details.pl Recall button now displayed on items in opac-course-details.pl which are issued to another user. No internal server error being thrown on courses with issued course reserves. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #235 from Alex Buckley --- Created attachment 80785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80785=edit Bug 19532: Added conditional to check the recall has a status = 'W' before setting it to closed This solves a bug I found that if the same borrower number and itemnumber combination occur more than once in the recalls database table then when the item is checked out to the patron who recalled the item then the recall is not updated to have a status of closed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #234 from Alex Buckley --- Created attachment 80784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80784=edit Bug 19532: Implemented check if recall status equals 'R' before recall popup is shown This stops the 'confirm recall' popup message being displayed upon item return when the item has a recall with any status other than 'R' (recalled). Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #233 from Alex Buckley --- Created attachment 80783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80783=edit Bug 19532: Fixing Internal Server Error thrown on C4/Circulation.pm Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #30 from David Cook --- I'm guessing the redefined warnings come from some circular dependency... but that's a red herring since we'd never run C4::Auth on its own anyway. If I create a script and load "C4::Auth", the script compiles fine. In fact, if I remove the semi-colon from the end of "my $dir = C4::Context::temporary_directory", the Koha web app still loads just fine. But I get the following when I try to compile the module: perl -c "C4/Auth.pm" Subroutine psgi_env redefined at C4/Auth.pm line 50. Subroutine safe_exit redefined at C4/Auth.pm line 52. Subroutine get_template_and_user redefined at C4/Auth.pm line 142. Subroutine _version_check redefined at C4/Auth.pm line 715. Subroutine _session_log redefined at C4/Auth.pm line 761. Subroutine _timeout_syspref redefined at C4/Auth.pm line 768. Subroutine checkauth redefined at C4/Auth.pm line 778. Subroutine check_api_auth redefined at C4/Auth.pm line 1387. Subroutine check_cookie_auth redefined at C4/Auth.pm line 1629. syntax error at C4/Auth.pm line 1751, near "C4::Context::temporary_directory my " Global symbol "$instance" requires explicit package name at C4/Auth.pm line 1751. Global symbol "$dir" requires explicit package name at C4/Auth.pm line 1752. Global symbol "$instance" requires explicit package name at C4/Auth.pm line 1752. BEGIN not safe after errors--compilation aborted at C4/Auth.pm line 1928. Interesting... I always thought that modules were compiled when they were loaded using "use". Not even the BEGIN{} block in the module is run when loaded using "use", which seems contradictory to experience... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #29 from David Cook --- That's not it either as I have a newer CGI version than 4.08... HTTP_USER_AGENT=stuff perl -c C4/Auth.pm [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine psgi_env redefined at C4/Auth.pm line 50. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine safe_exit redefined at C4/Auth.pm line 52. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine get_template_and_user redefined at C4/Auth.pm line 142. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine _version_check redefined at C4/Auth.pm line 715. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine _session_log redefined at C4/Auth.pm line 761. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine _timeout_syspref redefined at C4/Auth.pm line 768. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine checkauth redefined at C4/Auth.pm line 778. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine check_api_auth redefined at C4/Auth.pm line 1387. [Thu Oct 18 11:16:58 2018] Auth.pm: Subroutine check_cookie_auth redefined at C4/Auth.pm line 1629. Status: 500 Content-type: text/html Software error: Bareword C4::Context::temporary_directory not allowed while strict subs in use at C4/Auth.pm line 1750. BEGIN not safe after errors--compilation aborted at C4/Auth.pm line 1928. For help, please send mail to this site's webmaster, giving this error message and the time and date of the error. [Thu Oct 18 11:16:58 2018] Auth.pm: Bareword "C4::Context::temporary_directory" not allowed while "strict subs" in use at C4/Auth.pm line 1750. [Thu Oct 18 11:16:58 2018] Auth.pm: BEGIN not safe after errors--compilation aborted at C4/Auth.pm line 1928. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #28 from David Cook --- I see C4::Context turns off the warnings for redefined functions when there's a HTTP_USER_AGENT environmental variable, so that explains why the warnings don't show up in the web server logs... I wonder if Modern::Perl is up to something here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > I'm guessing no one else has experienced this? For some reason, when I use the web app, I don't get any errors. I wonder if we're suppressing them unintentionally in whatever is loading C4::Auth? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #26 from David Cook --- When I run "perl -c C4/Auth.pm", I get the following: perl -c C4/Auth.pm Subroutine psgi_env redefined at C4/Auth.pm line 50. Subroutine safe_exit redefined at C4/Auth.pm line 52. Subroutine get_template_and_user redefined at C4/Auth.pm line 142. Subroutine _version_check redefined at C4/Auth.pm line 715. Subroutine _session_log redefined at C4/Auth.pm line 761. Subroutine _timeout_syspref redefined at C4/Auth.pm line 768. Subroutine checkauth redefined at C4/Auth.pm line 778. Subroutine check_api_auth redefined at C4/Auth.pm line 1387. Subroutine check_cookie_auth redefined at C4/Auth.pm line 1629. Bareword "C4::Context::temporary_directory" not allowed while "strict subs" in use at C4/Auth.pm line 1750. BEGIN not safe after errors--compilation aborted at C4/Auth.pm line 1928. If I change "C4::Context::temporary_directory" to "C4::Context::temporary_directory()", that error goes away and compilation is fine. I'm guessing no one else has experienced this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #25 from David Cook --- When I run "perl -c C4/Auth.pm", I get the following: dcook@kohaprod:/kohawebs/dev/dcook/git> perl -c C4/Auth.pm Subroutine psgi_env redefined at C4/Auth.pm line 50. Subroutine safe_exit redefined at C4/Auth.pm line 52. Subroutine get_template_and_user redefined at C4/Auth.pm line 142. Subroutine _version_check redefined at C4/Auth.pm line 715. Subroutine _session_log redefined at C4/Auth.pm line 761. Subroutine _timeout_syspref redefined at C4/Auth.pm line 768. Subroutine checkauth redefined at C4/Auth.pm line 778. Subroutine check_api_auth redefined at C4/Auth.pm line 1387. Subroutine check_cookie_auth redefined at C4/Auth.pm line 1629. Bareword "C4::Context::temporary_directory" not allowed while "strict subs" in use at C4/Auth.pm line 1750. BEGIN not safe after errors--compilation aborted at C4/Auth.pm line 1928. If I change "C4::Context::temporary_directory" to "C4::Context::temporary_directory()", that error goes away and compilation is fine. I'm guessing no one else has experienced this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586 --- Comment #4 from David Cook --- Comment on attachment 80689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80689 Bug 21586: Add generic OpenIDConnect client implementation Review of attachment 80689: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21586=80689) - ::: C4/Auth.pm @@ +1789,4 @@ > } > else { > # catch all defaults to tmp should work on all systems > +my $dir = C4::Context::temporary_directory(); Ooops. This was a local fix that I did so that C4::Auth would compile for my client side git hook...I should take that out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #232 from Alex Buckley --- Just a note that I will be attaching a few more additional patches to this bug report in the next hour or so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #231 from Alex Buckley --- All attached. I just tested and all commits apply cleanly on master as of 18 oct 2018. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #230 from Alex Buckley --- Created attachment 80782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80782=edit Bug 19532 - New RECALL_REQUESTER_DET notice and print option on confirm recall popup This patch adds a new notice RECALL_REQUESTER_DET which like HOLD_SLIP outlines borrower and item information so the item can be put aside for the requester. This patch also adds a 'Print and confirm' button to the 'Confirm recall' popup that appears when returning a recalled item. This functionality works the same as the 'Print and confirm' functionality for the Hold slip: A print modal popup will appear for the user to choose print settings, and choose to print or cancel. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item in the staff client 5. Notice there are only two buttons on the 'Confirm recall' popup which appears: 'Confirm' and 'Cancel' 6. Apply patch, run updatedatabase.pl (as there is a SQL atomicupdate file to be run), and restart memcached and plack 7. Using a new item repeat steps 2,3 8. In a new tab, in the staff client go to Circulation->Recalls queue, and notice the recall has a status of 'Requested' 8. Back in your first tab return the item and notice that a new button 'Print and confirm' is on the 'Confirm recall' popup. Select this button and notice two new popup windows appear: Browsers print window, and a window showing what the notice to be print looks like. 9. If you have a printer available print the notice. Otherwise you can look at what the notice would look like in the notice window, observing the notice outlines the following information: * Current date and time * Recall pickup branch * Borrowers first name and surname * Borrowers cardnumber, phonenumber, address, address2, city, zipcode, email * Recalled item title, author, barcode, callnumber. * Recall waiting date, and recall notes Some of these values will not be displayed on the notice if they are not set. For example the patron may not have set an address, or email. 10. After either printing the notice, or selecting 'Cancel' in the print window. Go back to your second tab and refresh the page and notice the status of the recall has changed to 'Ready for pickup' this shows the 'Print and confirm' button does actually confirm the recall. 11. Making sure the changes implemented in the previous commit (Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns) still work. Try returning the item again and notice the 'Confirm recall' popup with the 'Print and confirm' button is displayed again and you can choose to print the notice again if you want. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #229 from Alex Buckley --- Created attachment 80781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80781=edit Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester Previously the confirm recall popup was only displayed the first time the recalled item was out through returns. However it is useful for the Confirm recall popup to appear if the item is put through the returns multiple times due to library staff being interrupted. This ensures library staff are informed that the item has been recalled. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and notice the 'Confirm recall' popup appears. Click confirm 5. Now check the item in again and notice the popup is not displayed this time. 6. Apply this patch 7. Restart memcached and plack 8. Using a new item repeat steps 2,3,4,5 and notice in step 5 the 'Confirm recall' popup is displayed this time. Click 'Confirm' 9. Check the item out to patron 2 10. Return the item and notice no popup is displayed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #228 from Alex Buckley --- Created attachment 80780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80780=edit Bug 19532 - Stopping an recalled item currently awaiting pickup from being able to be checked out to patrons other than the recall requester. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and confirm the recall 5. In the staff client go to Circulation->Recalls queue, notice the recall has a status of 'Ready for pickup' 6. Try issuing the item to patron 3 and notice without this patch applied you can issue a recall awaiting pickup to a patron who did not place the recall. 7. Apply patch 8. Restart memcached and plack 9. Using a new item repeat steps 1,2,3,4,5,6 and notice you get a yellow message displayed stating: 'This item is awaiting pickup by another patron who recalled it.' The issuing has not taken place to a patron who is not the patron who placed the recall as the item is awaiting pickup by the recall requester. 10. Issue the item to patron 2 and notice the issuing takes place successfully Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #227 from Alex Buckley --- Created attachment 80779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80779=edit Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is empty Sponsored-BY: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #226 from Alex Buckley --- Created attachment 80778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80778=edit Bug 19532 - Recalls for Course Reserves. This ptach fixes the 'Template process error Koha::Item->avail_for_recall' which is thrown when loading a Course pgae in opac-course-details.pl with course reserves which are currently issued. It also allows recalls to be placed from Course reserves Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #224 from Alex Buckley --- Created attachment 80776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80776=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #223 from Alex Buckley --- Created attachment 80775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80775=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #225 from Alex Buckley --- Created attachment 80777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80777=edit Bug 19532 - Fixes to stop transfer recall modal from being displayed incorrectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #222 from Alex Buckley --- Created attachment 80774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80774=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: Warning: Your library does not allow recalls for x item types. Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #221 from Alex Buckley --- Created attachment 80773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80773=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #220 from Alex Buckley --- Created attachment 80772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80772=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #219 from Alex Buckley --- Created attachment 80771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80771=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #218 from Alex Buckley --- Created attachment 80770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80770=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #217 from Alex Buckley --- Created attachment 80769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80769=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #216 from Alex Buckley --- Created attachment 80768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80768=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 --- Comment #7 from David Cook --- Awesome! I should've looked more thoroughly when I reported #21160. This should have some nice knock on effects, especially for CGI users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #215 from Alex Buckley --- Created attachment 80767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80767=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #214 from Alex Buckley --- Created attachment 80766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80766=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #213 from Alex Buckley --- Created attachment 80765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80765=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #212 from Alex Buckley --- Created attachment 80764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80764=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #211 from Alex Buckley --- Created attachment 80763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80763=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78777|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78778|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78782|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78780|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78785|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78787|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78790|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78789|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78792|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78794|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78797|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78800|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78801|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78803|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78802|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78804|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78805|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78807|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78806|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #78808|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #210 from Alex Buckley --- Hi all I have gone through and fixed the conflicts when applying these patches, and will attach the fixed patches. Apologies for the email deluge. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17120] Specify number of rows per page in report and initial run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17120 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19010] When downloading reports, long running reoprts will time out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19010 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16703] Home > Reports > Circulation statistics showing no circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16703 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18891] Download Reports Directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #22 from Christopher Brannon --- Created attachment 80762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80762=edit Bug 21503: Simplify If Else logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Alex Buckley --- Hi Owen Thanks for testing. I have corrected the commit message in the first patch, and have just attached a second path which corrects the issue you saw trying to cancel a hold on the cataloguing/additem.pl interface. This second patch also corrects the qa warning on C4/Circulation.pm Can you please test again? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #7 from Alex Buckley --- Created attachment 80761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80761=edit Bug 20844: Fixed error when cancelling hold from cataloguing/additem.pl Also fixed qa test tool failure on C4/Circulation.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #6 from Alex Buckley --- Created attachment 80760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80760=edit Bug 20844: Revert hold when setting an item to lost If an item is marked as 'Lost' then this patch introduces the following new functionality: 1. Check if there is a bib-level or item-level hold on the item with the status of 'W' (waiting). This is an allocated hold which is not yet checked out to the requesting patron. 1.a. If the hold was originally a bib-level reserve (reserves.originalholdtype='B') then do the following: * Revert the waiting status of the reserve * Set the reserves.itemnumber=NULL so the hold is reset to a bib-level hold 1.b. If the hold was originally (and still is) a item-level hold (reserves.originalholdtype='I') then display a alert dialog box on the additem.pl interface asking the librarian to select one of two options: * Cancel the hold - This deletes the hold altogether * Retain the hold - This does not change the hold. Therefore the requester will still have a hold on a lost item NOTE: Previously an allocated bib-level hold was identical to a item-level hold in the database. As the first available item on the bib record had been allocated to the requester and so an itemnumber had been set in the record in the reserves table. However this patch introduces a atomicupdate which adds the new column 'originalholdtype' to the reserves table. This allows us to track if the reserve was originally a bib level hold and treat it differently when the allocated item is being marked as 'Lost' Test plan: 1. Place a bib-level hold on a biblio 2. Check out an item from the biblio to a different patron 3. Query the reserves db table for biblio you placed the bib-level hold and notice it has no 'itemnumber' or 'status' value 4. Return the item and confirm the hold in the modal box that is loaded 5. Query the reserves db table and notice the itemnumber field is now filled with the returned item's itemnumber and the status is 'W' 6. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 7. Notice the waiting item-level hold still exists after the item is marked as 'lost' 8. Repeat steps 1-7 but this time place an item-level hold on an item in step 1 and then check that same item out in step 2. Notice in the repeated step 7 that the hold remains after marking the item as 'Lost' 9. Apply patch and run ./updatedatabase.pl from the koha-shell in the installer/data/mysql/ directory 9. Repeat steps 1-6 placing an bib-level hold and then query the database and notice the bib-level hold which was changed to an allocated waiting item-level hold when the item was returned and the hold confirmed is now reverted to a bib-level hold again. This is controlled by the LostBibLevelHoldsRevert syspref. If this syspref is not enabled then the allocated item-level (originally bib-level hold) will remain after the item is marked as lost. 10. Repeat 1-6 but this time place an item-level hold on the item. Notice when you mark the item as 'Lost' a yellow warning box is displayed asking if you want to 'Retain hold' or 'Cancel hold'. Select 'Retain hold' and notice the item-level hold remains now the item is marked as lost. 11. Repeat step 10 but choose 'Cancel hold' option and notice the hold is deleted now. 12. Now enable the new 'LostItemCancelOutstandingTransfers' syspref. This will now cancel any outstanding transfers on the item when it is marked as lost. 13. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 14. Now mark that item as 'Lost' and now notice the transfer is cancelled Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Attachment #79267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #21 from Christopher Brannon --- Created attachment 80759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80759=edit Bug 21503: Changed logic for checking values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #20 from Christopher Brannon --- Created attachment 80758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80758=edit Bug 21503: Tests clarification for debugging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #8 from Jonathan Druart --- It looks like we can be more precise and use the full path: errors/errorpage.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 --- Comment #2 from Jonathan Druart --- What about NULL vs ''? I think we should alert if '', do not you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 Jonathan Druart changed: What|Removed |Added Depends on||21150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 [Bug 21150] Data inconsistencies - item types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21150] Data inconsistencies - item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 Jonathan Druart changed: What|Removed |Added Blocks||21591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 [Bug 21591] Data inconsistencies - Item types and biblio level -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21592] When adding to basket from a file and using MarcFieldsToOrder items are not added to basket if missing funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21592 Nick Clemens changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21592] New: When adding to basket from a file and using MarcFieldsToOrder items are not added to basket if missing funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21592 Bug ID: 21592 Summary: When adding to basket from a file and using MarcFieldsToOrder items are not added to basket if missing funds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Test plan: 1 - Edit the MarcItemFieldsToOrder and MarcFieldsToOrder syspref. For example: MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$c nonpublic_note: 975$d public_note: 975$e loc: 975$f ccode: 975$g price: 975$h replacementprice: 975$i itemcallnumber: 975$j notforloan: 975$m uri: 975$n copyno: 975$o MarcFieldsToOrder price: 975$h 2 - Stage your order file from vendor. (Test file : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57715 ) 3 - Add to basket from staged file 4 - Values are filled but not budget (ensure you don't have the one in file defined) 5 - Check the box and save 6 - You are returned to empty basket 7 - View the record - items have been created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 --- Comment #1 from Nick Clemens --- Created attachment 80757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80757=edit Bug 21591: Check for record level item type issues too To test: 1 - sudo koha-mysql kohadev 2 - UPDATE biblioitems SET itemtype = NULL where biblionumber = 1 3 - UPDATE items SET itype = NULL where biblionumber = 1 4 - perl misc/maintenance/search_for_data_inconsistencies.pl 5 - Notice warnings 6 - Apply patch 7 - Undefined itemtype on bibliolevel is now warned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/