[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Alex Buckley --- The updatedatabase.pl fails when there are records in the lost item refund rules table. See below updatedatabase.pl output: DEV atomic update: bug_18930.perl DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`circulation_rules`, CONSTRAINT `circ_rules_ibfk_1` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT NULL, branchcode, NULL, 'refund', refund FROM refund_lost_item_fee_rules "] at (eval 1209) line 4. Upgrade to XXX done (Bug 18930 - Move lost item refund rules to circulation_rules table) kohadev-koha@kohadevbox:/home/vagrant/kohaclone/installer/data/mysql$ exit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #10 from Alex Buckley --- Created attachment 81107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81107=edit Bug 13098: Make _FixAccountForLostAndReturned refund the right thing This patch changes the logic inside the method, to make it match the behaviour described on the tests. It uses the existing offsets on the account_offsets table to gather information about the right things to refund. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests don't pass! - Apply this patch - Run k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Followed test plan, patch works as described. All three patches pass QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #9 from Alex Buckley --- Created attachment 81106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81106=edit Bug 13098: Tests for all _FixAccountForLostAndReturned use cases This patch introduces tests for all the use cases for _FixAccountForLostAndReturned. This includes the following scenarios before _FixAccountForLostAndReturned is called: - Full write off (the original issue) - Full payment - No payment or write off - Partial payment and partial write off Written off debts (L lines) are just skipped, any kind of payment is added and then refund as a single credit (CR). Amount outstanding is set to 0. Offsets need to be generated for paper trail of this decisions. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because _FixAccountForLostAndReturned is not doing the right thing :-D Followed test plan, patch works as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #8 from Alex Buckley --- Created attachment 81105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81105=edit Bug 13098: Add Koha::Account::Offsets->total This patch introduces this trivial method for returning the sum0 result of the amount columns of a Koha::Account::Offsets set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t - Sign off :-D Followed test plan, patch worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley changed: What|Removed |Added Attachment #80862|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley changed: What|Removed |Added Attachment #80863|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #80864|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21647] Clean up SRU fields mapping templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from M. Tompsett --- For authorities, these unexplained errors happen in validation. Error: End tag div seen, but there were open elements. From line 122, column 5; to line 122, column 10 form>↩↩↩ Error: Unclosed element main. From line 62, column 5; to line 62, column 10 id">↩↩↩ Error: Stray end tag div. From line 129, column 9; to line 129, column 14 ↩↩↩↩ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 --- Comment #3 from Phil Ringnalda --- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl is also affected, since bug 13692 also changed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #84 from David Cook --- (In reply to Jonathan Druart from comment #75) > I have rebased the branch (tricky!), but I get > > Undefined subroutine ::Items::TransformKohaToMarc called at > /home/vagrant/kohaclone/C4/Items.pm line 1491. > > when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42 > > TransformKohaToMarc is exported by C4::Biblio. > And it is what we are trying to avoid... > > Any ideas? I don't really understand the question here. Based on https://github.com/joubu/Koha/commit/9bbab48f740f1ebcb4c08549622d750b34fe14c0, I'm guessing that you're explicitly importing "TransformKohaToMarc" from C4::Biblio at the top of C4::Items, but you're still getting "Undefined subroutine ::Items::TransformKohaToMarc called at > /home/vagrant/kohaclone/C4/Items.pm line 1491."? I'd need to be able to poke around on the system to know exactly what's going on and I'd have to do some experiments (like dumping %INC and looking at functions by namespace to see what is declared at what time), but... ...wouldn't a solution be just to write C4::Biblio::TransformKohaToMarc? Personally, I think we overuse Exporter.pm. I think moving from EXPORT to EXPORT_OK is a great improvement, but I'm not sure why we export so many functions either. Perhaps because it makes things easier to write, but it makes things harder to read and understand, and it creates issues like these... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 M. Tompsett changed: What|Removed |Added Attachment #81102|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 81104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81104=edit Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process This is a follow-up patch for bug 14048 comment 97 Test plan: git grep refund_lost_item_fee_rules.sql should not return any results Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Phil Ringnalda changed: What|Removed |Added CC||phil.c...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #83 from David Cook --- (In reply to Jonathan Druart from comment #75) > See my previous comment, I do not plan to maintain this branch up-to-date. > As I did not get the expected feedback it is not longer on my priority list. I know this is no longer on your priority list, but I'm happy to provide some feedback now that I know this bug exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 M. Tompsett changed: What|Removed |Added Attachment #81043|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 81103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81103=edit Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #33 from David Cook --- (In reply to Jonathan Druart from comment #26) > I do not think your Koha::Daemon will work for the background jobs. > > To me, the best way to fix this would be to provide a Koha daemon, instead. > But it would watch a DB table, which would allow us to build a view on top > of it to manage the different jobs (and history). > > We could also have different daemons for different needs (a param of the > daemon matching a column in the DB table). > > The question behind that is security, we will have to list the different > operations the daemon is allowed to process (and so we will loose > flexibility). > > I have spent a *lot* of time trying to fix this issue by forking, etc. And > my conclusion is: it's not feasible (see discussions and tries on related > bug reports) > > See also bug 1993. I just realized that I misread your comment, Jonathan... Take a look at line 106 of "Harvester.pm" at https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10662=79039. Using POE::Component::JobQueue, I check a DB table called "oai_harvester_import_queue" for "new" import jobs. You could do the same thing. In my case, the job in "oai_harvester_import_queue" actually has a field containing a JSON array of record identifiers, and the import task fetches those records from the file system and then works on them as a batch. Going 1 by 1 for each record would be way too slow (both in terms of retrieving tasks and importing records). But yeah the web interface could upload the records, store their location, put that in a job, and then store that data in the database. The import daemon would poll the database (which isn't super efficient but efficient enough for Koha's purposes I imagine), and then work on batches as it could. -- (One thing to keep in mind here is import matching rules that use Zebra... if you have high performance importing, Zebra won't be able to keep up, and it means that you could wind up with duplicate records if someone tries to import the same record too quickly... ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #32 from David Cook --- We could look at something like http://gearman.org/, http://www.celeryproject.org/, or one of the other many projects... but they don't offer as much nuanced control as we might like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #31 from David Cook --- Actually, when working on #10662, I thought about creating a standalone "import daemon", as importing records into Koha is the hardest part of OAI-PMH harvesting. (I already have an extremely fast download worker, but the bottleneck is importing into Koha *sadface*.) For #15032, "Stage MARC records for import" could simply be a script that allows a use to upload MARC records from their browser client to the Koha server, and to pass on some configuration options to accompany those records. We could store all of that on the file system, in the database, or wherever makes the most sense. If we wanted to have fun, we could leave them in-memory and let an import daemon suck them out of memory instead of a disk which would require way more I/O ops. Once the records are uploaded to the Koha server and stored with the job details, the PSGI/CGI script alerts the "import daemon" that it would like to start the job. Now the "import daemon" should probably have a master listener process which does very little work, which makes it highly responsive to queries from the Koha web client. That master listener process can talk to worker processes that do the actual work. In terms of imports, it probably would be good if the master process can query the workers for progress updates (and probably also allow cancellations of imports - which might be useful for very large imports). (Oh another thing... this import daemon wouldn't just be usable from a web interface. It could also be used by command line tools. Thus we have 1 point for getting records into Koha, and that daemon can act as gatekeeper.) We default the "import daemon" workers to maybe 1 worker, but allow it to be configurable, so that large Koha instances can commit more resources to it. (If we were smart, we'd probably have the import daemon use TCP for communications and allow workers to be distributed. Although to do that we'd need to package Koha libraries for working with records and distribute those too. Plus we'd need database configuration information distributed. I mean we could have an API to handle all the actual imports, but that would be slow...) Just some ideas ^_^. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Assignee|k...@bywatersolutions.com |jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #28 from Jonathan Druart --- I have started a rebase but it's getting very hard here. I will wait a bit for other patches to get attention. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #30 from David Cook --- (In reply to Jonathan Druart from comment #26) > I do not think your Koha::Daemon will work for the background jobs. > > To me, the best way to fix this would be to provide a Koha daemon, instead. > But it would watch a DB table, which would allow us to build a view on top > of it to manage the different jobs (and history). > > We could also have different daemons for different needs (a param of the > daemon matching a column in the DB table). > > The question behind that is security, we will have to list the different > operations the daemon is allowed to process (and so we will loose > flexibility). > > I have spent a *lot* of time trying to fix this issue by forking, etc. And > my conclusion is: it's not feasible (see discussions and tries on related > bug reports) > > See also bug 1993. My Koha::Daemon is just a module for making a daemon process; it's similar to Proc::Daemon on CPAN. But yeah I could see my Koha::OAI::Harvester::Listener and Koha::OAI::Harvester not working for all background jobs. They work well in my case but I'd be happy to actually replace (elements of) them with a more general Koha solution, if it worked for my use case too. Yeah I think that different daemons for different needs makes sense too. Like in the case of #10662, I originally wrote a generic job server, but then realized it might not suit everyone, so I re-wrote it just for that specific task of harvesting OAI-PMH records. Yeah, I don't think forking makes sense in a Plack/persistent environment. Actually, I don't think it makes sense in the CGI environment either, but it "worked". Setting up separate daemons is easy. I don't know why we don't just do that. The issue then I suppose is security, as you've said, and deciding on communication protocols. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #29 from David Cook --- (In reply to Jonathan Druart from comment #27) > My idea would be "something that works", I have already tons of things that > do not work. I am not sure letting other developer retrying again what did > not work is a good idea :) > Let's discuss and agree on an idea, then I can implement it. That works for me too! So long as we have some sort of timeline/deadline I think, so that we don't let the discussion go on forever? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 --- Comment #1 from Jonathan Druart --- Created attachment 81102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81102=edit Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process This is a follow-up patch for bug 14048 comment 97 Test plan: git grep refund_lost_item_fee_rules.sql should not return any results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 Jonathan Druart changed: What|Removed |Added Depends on||14048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Blocks||21654
--- Comment #98 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #97)
> There is one occurrence left:
> C4/Installer.pm:push @fnames, C4::Context->config('intranetdir') .
> "/installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql";
>
> Please fix!
See bug 21654, thanks!
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654
[Bug 21654] Installer is loading a non-existing file
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] New: Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 Bug ID: 21654 Summary: Installer is loading a non-existing file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql But this file has been removed by 14048 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart changed: What|Removed |Added Attachment #71007|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 81101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81101=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #28 from Christopher Brannon --- Created attachment 81100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81100=edit Bug 21346: Restore values needed for buttons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #6 from Jonathan Druart --- Created attachment 81097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81097=edit Bug 18928: Add DB structure changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #7 from Jonathan Druart --- Created attachment 81098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81098=edit Bug 18928: Update schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #8 from Jonathan Druart --- Created attachment 81099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81099=edit Bug 18928: Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Attachment #71005|0 |1 is obsolete|| Attachment #71006|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 81096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81096=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #50 from Jonathan Druart --- Created attachment 81095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81095=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925
--- Comment #47 from Jonathan Druart
---
Created attachment 81092
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81092=edit
Bug 18925: (follow-up) Change name of rule to fix ambiguity
There was previously an ambiguity between the branch/category/itemtype
specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty.
The latter has been renamed to patron_max{,onsite}issueqty.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What|Removed |Added Attachment #79642|0 |1 is obsolete|| Attachment #79643|0 |1 is obsolete|| Attachment #79644|0 |1 is obsolete|| Attachment #79645|0 |1 is obsolete|| Attachment #79646|0 |1 is obsolete|| --- Comment #46 from Jonathan Druart --- Created attachment 81091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81091=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #49 from Jonathan Druart --- Created attachment 81094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81094=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #48 from Jonathan Druart --- Created attachment 81093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81093=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21653] New: add koha-cronlogaction script, which will call C4/Log::cronlogaction with the remaining command line arguments set as "info" in the logs.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21653 Bug ID: 21653 Summary: add koha-cronlogaction script, which will call C4/Log::cronlogaction with the remaining command line arguments set as "info" in the logs. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Sometimes it is useful for administrators to make changes that affect libraries, but which would not otherwise be logged -- this could be called from a shell script, and would give clues to any changes made within the script. usage: koha-cronlogaction INSTANCE-NAME "text to be added to logs" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21652] New: reserves.waitingdate is set to current date by printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Bug ID: 21652 Summary: reserves.waitingdate is set to current date by printing new hold slip Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To test: - Find or create a hold with a waitingdate other than today - Check the item in to generate a new hold alert - Select "Confirm and Print" - Verify that the waiting date has changed to the current date The waiting date does not change if you select "Confirm" rather than "Confirm and Print." This causes confusion as it puts the waiting date out of sync with the expiration date. In fact, if ExpireReservesMaxPickUpDelay is off and expired holds must be cancelled manually, a new hold slip can be printed after the cancellation date, causing the hold to show a waiting date after its expiration date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21562] Sorting on checkout date is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21562] Sorting on checkout date is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #80988|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21562] Sorting on checkout date is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562 --- Comment #4 from Alex Buckley --- Created attachment 81090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81090=edit Bug 21562: Fix sort by checkout date in the circulation table The sort is done in SQL but resort by DataTables when displaying the results. iDataSort should be used to mimick date_due sort behavior. Test plan: - Check some items out - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, then due date. The sort should be correct for all values of the DateFormat syspref Followed test plan, patch works as described and passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 --- Comment #22 from Katrin Fischer --- (In reply to Alex Buckley from comment #20) > Rebased against master on 16th of sept 2018. > > We (Catalyst) believe the best way to get this feature upstreamed is for > those who would like the wording to be changed to 'Save as draft' to make a > dependent bug report with a patch implementing that wording change. > > i.e. we should try and get this useful new feature as it is into master and > then those who have differing views on the wording can make a dependent > patch which implements the wording they would like. I'd like to add something here. Changing the wording later might create a lot of work for a lot of people: - developers - testers - documentation writers - translators Why not change the little detail now? If I see it correctly, it would be only one line to change: +Save without cataloging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21651] Force insert of notices related tables during the install process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #2 from Jonathan Druart --- Created attachment 81089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81089=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21651] Force insert of notices related tables during the install process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21651] Force insert of notices related tables during the install process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #1 from Jonathan Druart --- Created attachment 81088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81088=edit Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #90 from Jonathan Druart --- Created attachment 81087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81087=edit Bug 15486: Fix failing test in GetHardDueDate.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7614] Branch transfer limit and holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Alex Buckley --- Sorry the patches do not apply, can you please rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 7614: Add a new method Koha::Libraries->pickup_locations Using index info to reconstruct a base tree... M t/db_dependent/Koha/Libraries.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Libraries.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Libraries.t Failed to merge in the changes. Patch failed at 0001 Bug 7614: Add a new method Koha::Libraries->pickup_locations The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-7614-Add-a-new-method-KohaLibraries-pickuploca-2UIRVc.patch You have new mail in /var/mail/vagrant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Jonathan Druart changed: What|Removed |Added Attachment #81084|0 |1 is obsolete|| --- Comment #59 from Jonathan Druart --- Created attachment 81086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81086=edit Bug 15766: Update tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21651] New: Force insert of notices related tables during the install process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Bug ID: 21651 Summary: Force insert of notices related tables during the install process Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) I would suggest to move the 3 .sql files to installer/data/mysql/mandatory, remove all the others (as well as the .txt files) and insert them without asking during the install process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #5 from Nick Clemens --- Created attachment 81085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81085=edit Bug 21639: Adjust the other languages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #58 from Nick Clemens --- Created attachment 81084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81084=edit Bug 15766: Update tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21650] C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 M. Tompsett changed: What|Removed |Added Attachment #81082|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 81083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81083=edit Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results NOTE: POD Coverage test failure is expected on removal Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21650] C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 M. Tompsett changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21650] C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- POD Coverage failure. Otherwise Ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21650] C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21650] C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 --- Comment #1 from Jonathan Druart --- Created attachment 81082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81082=edit Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21650] New: C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Bug ID: 21650 Summary: C4::Items::GetLastAcquisitions has never been used and should be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21645] Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 M. Tompsett changed: What|Removed |Added Attachment #81078|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 81081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81081=edit Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21645] Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21645] Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 --- Comment #4 from M. Tompsett --- Header looks better in the case of having library groups, but looks out of place when there are none. Perhaps a pretty shaded box telling us how lonely it is with no library groups would be better, but this isn't a blocker for me. The HTML clean up is awesome (96 -> 5 errors, of which the remainder are include files and have nothing to do with this page specifically). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] Remove NorwegianPatronDB related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21607] Koha::Account::Line->apply should store credit offsets as negative amounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21607 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > I know sorting is prettier, but a smaller patch with just phone would be > easier to eyeball. :P Agreed, especially because you are going to provide the same changes for all the other languages now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #14 from Jonathan Druart --- (In reply to Caroline Cyr La Rose from comment #13) > So I should try with another vendor to see the different links? > > Also, if we're not supposed to change the vendor tax settings, they > shouldn't be editable. Yes I think they should not be editable unless there is no order yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21596] Handle default values when storing Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 --- Comment #20 from Jonathan Druart --- Please review and push this last patch to make Jenkins happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21596] Handle default values when storing Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 --- Comment #19 from Jonathan Druart --- Created attachment 81080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81080=edit Bug 21596: Handle updated_on This has been picked from the solution proposed on bug 21610. It may not be pushed soon and so we need a fix for the failing tests (t/Auth_with_shibboleth.t) Test plan: prove -r t/Auth_with_shibboleth.t t/db_dependent/Koha/Patrons* must return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21511] Don't show acquisition details on subscription detail when there is no acq data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #50 from Nick Clemens --- (In reply to Jonathan Druart from comment #49) > Created attachment 81068 [details] [review] > Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet > > SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by > Asset.css() > > Signed-off-by: Jonathan Druart > Fix a bad resolution conflict Followup pushed to master for 18.11, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21492] Show subscriptions count in the sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21492 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21216] Add filter/search options to notices table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21216 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #14 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #13 from Caroline Cyr La Rose --- So I should try with another vendor to see the different links? Also, if we're not supposed to change the vendor tax settings, they shouldn't be editable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #42 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #57 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #89 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21611] Priority in request.pl shows 1 instead of Waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 --- Comment #3 from Christopher Brannon --- (In reply to Jonathan Druart from comment #2) > Caused by bug 19469. Confirmed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] New: Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Bug ID: 21649 Summary: Add child button in the staff client is no longer automatically populating the parent address Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: marga...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In 18.05 when a staff member clicks the Add Child button on a Parent's/Guardian's account the main address is not populated on the new patron page. Other details carry over but the main address is empty. I tested on a 17.11 instance and the feature works correctly there. To Replicate: 1) Install/be running 18.05.04 2) Create or find an adult patron account you want to test with; make sure they have an address - street, city, etc. 3) On the Details tab of the patron's record click on the "+Add child" button. 4) See that the main address text boxes are empty on the /cgi-bin/koha/members/memberentry.pl?op=add=... page. The Guarantor information and Contact information seems to come over, but Address does not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21646] Clean up Overdrive template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21646] Clean up Overdrive template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 --- Comment #1 from Owen Leonard --- Created attachment 81079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81079=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21645] Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Owen Leonard changed: What|Removed |Added Attachment #81069|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 81078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81078=edit Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21645] Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #4 from SysAdmin --- Since Koha has added a timeout function to the Self check and Self return systems, which seem to work on the Opac side (not the intranet side) shouldn't this be an easy enhancement/bug to fix now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #12 from Jon Knight --- I'm not sure I understand how columns.def is going to useful in this case. That file appears to be some sort of vaguely XML file mapping tables & columns to human readable names in a given language. However we don't want language dependent human readable attributes in the output - we're after consistent machine readable output for GDPR. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21596] Handle default values when storing Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 Jonathan Druart changed: What|Removed |Added CC||n...@zefanjas.de --- Comment #18 from Jonathan Druart --- *** Bug 16858 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16858] import_borrowers.pl does not load because of mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16858 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- This should have been fixed by bug 21596. *** This bug has been marked as a duplicate of bug 21596 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 16858, which changed state. Bug 16858 Summary: import_borrowers.pl does not load because of mysql 5.7 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16858 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21645] Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- edit-group classes are twice in some tags delete-group classes are twice in some tags ? -- probably should be a closed span. -- the type stuff is in an include file. recheck the div match ups, particularly across include files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 SysAdmin changed: What|Removed |Added CC||syst...@decatur.lib.al.us --- Comment #3 from SysAdmin --- We would also like to see a "refresh" timer for the Opac. We have already had issues with patrons leaving themselves logged in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 M. Tompsett changed: What|Removed |Added Attachment #81044|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 81077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81077=edit Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #104 from Jonathan Druart --- (In reply to Julian Maurice from comment #92) > Extraction of strings from templates is a bit complicated and use > Template::Parser and PPI. Template is compiled into Perl code and then > analyzed by PPI. It is slow, but should be correct even with complex > constructions. Indeed, it is super slow compared. I would consider it acceptable compared to the enhancement it brings. (master) % time perl translate update fr-FR perl translate update fr-FR 10.02s user 5.16s system 84% cpu 17.868 total (master) % time perl translate install fr-FR perl translate install fr-FR 12.88s user 3.05s system 79% cpu 19.988 total (bug_21156) % time perl translate install fr-FR . done. perl translate update fr-FR 102.00s user 11.62s system 97% cpu 1:56.00 total (bug_21156) % time perl translate install fr-FR perl translate install fr-FR 12.49s user 2.56s system 79% cpu 18.940 total BTW do you know what is the ". done." outputted by install? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #2 from M. Tompsett --- Comment on attachment 81044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81044 Bug 21639: Add phone transports to new and existing installs Review of attachment 81044: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21639=81044) - ::: installer/data/mysql/en/mandatory/sample_notices_message_transports.sql @@ -4,5 @@ > (1, 'email', 0, 'circulation', 'DUE'), > (1, 'email', 1, 'circulation', 'DUEDGST'), > -(2, 'email', 0, 'circulation', 'PREDUE'), > -(2, 'email', 1, 'circulation', 'PREDUEDGST'), > -(4, 'email', 0, 'reserves','HOLD'), I know sorting is prettier, but a smaller patch with just phone would be easier to eyeball. :P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21647] Clean up SRU fields mapping templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 --- Comment #1 from Owen Leonard --- Created attachment 81076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81076=edit Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
