[Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #18 from Héctor Eduardo Castro Avalos  
---
Hi everyone

This is a problematic subject, keep-up to date the frameworks. We fix this
updating SQL manually. Right now I encourage all my co-worker to start
cataloging in Rancor, rather than frameworks. You'll see that this is a better
option with the unique inconvenience that you cannot obtain stadistics with
frameworks anymore.

Of course Rancor got some problems (bugs) yet, but if you learn how to avoid
them, you'll see a good option for cataloging process. And after all it's much
faster cataloging there than the old frameworks.

We used frameworks with students and inexperienced librarians.

Cataloger thought.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21666] Advanced editor search- error is given for 'Unsupported Use attribute' when searching on title + author

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21666

David Cook  changed:

   What|Removed |Added

  Attachment #81249|0   |1
is obsolete||

--- Comment #3 from David Cook  ---
Created attachment 81250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81250=edit
Bug 21666: Replace unsupported use attribute with more widely supported
attribute

search.js uses the 1=1004
author personal attribute which isn't supported by libraries like
Seattle Public Library.

This patch aligns search.js
with C4/Breeding.pm which uses the more widely supported 1=1003
author attribute.

To test:
1. Set up Seattle Public Library as a Z39.50 target
2. Try to search author using the Advanced Editor advanced search
3. Observe failure
4. Apply the patch
5. Try to search again
6. Observe successful retrieval of records

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21666] Advanced editor search- error is given for 'Unsupported Use attribute' when searching on title + author

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21666

David Cook  changed:

   What|Removed |Added

Summary|Advanced editor search- |Advanced editor search-
   |error is given for  |error is given for
   |“Unsupported Use attribute” |'Unsupported Use attribute'
   |when searching on title +   |when searching on title +
   |author  |author

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21666] Advanced editor search- error is given for “Unsupported Use attribute” when searching on title + author

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21666

--- Comment #2 from David Cook  ---
Created attachment 81249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81249=edit
Bug 21666: Replace unsupported use attribute with more widely supported
attribute

search.js uses the 1=1004
author personal attribute which isn't supported by libraries like
Seattle Public Library.

This patch aligns search.js
with C4/Breeding.pm which uses the more widely supported 1=1003
author attribute.

To test:
1. Set up Seattle Public Library as a Z39.50 target
2. Try to search author using the Advanced Editor advanced search
3. Observe failure
4. Apply the patch
5. Try to search again
6. Observe successful retrieval of records

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21666] Advanced editor search- error is given for “Unsupported Use attribute” when searching on title + author

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21666

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
Let's see...

The Advanced Editor in cataloguing defines its search attributes in
"./koha-tmpl/intranet-tmpl/lib/koha/cateditor/search.js".

Title = 1=4
Author = 1=1004

The "New from Z39.50/SRU" defines its attributes in "C4/Breeding.pm".

Title = @attr 1=4
Author = @attr 1=1003

We can see the full list of attributes at
https://www.loc.gov/z3950/agency/defns/bib1.html#use

We can see LOC's supported attributes at http://www.loc.gov/z3950/lcserver.html
(which includes 1003 and 1004).

I don't see any information about SPL's supported attributes or Z39.50 set up.

However, it seems to me that 1004 is an odd choice. I think 1003 tends to be
more widely supported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #74 from Aleisha Amohia  ---
Created attachment 81248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81248=edit
Bug 13952: (follow-up) Fixing leftover merge conflict stuff

There was some leftover stuff from a merge conflict messing with the JS,
so I have fixed this up. The window now closes after export, as
expected.

Have noticed however that export breaks with authtypecodes that have a
slash (/) in them. Will set to Assigned to fix this.

Also need to add a fail message for when authtypecodes do not match on
import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #288 from Alex Buckley  ---
All done, and I have attached 6 additional patches fixing a few bugs and
introducing new features such as the ability to set the Recall due date
interval and Recall pickup period in the unit of hours (previously these fields
were only in days).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #287 from Alex Buckley  ---
Created attachment 81247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81247=edit
Bug 19532: Added ability to set Recall due date interval, and Recall pickup
period to hours

Previously you could only set a number of days a recalled item
has to be returned (Recall due date interval (days)) and a number of
days available for a recalled item to be picked up.

For academic libraries which often loan high-demand items out by a
certain number of hours being able to set the number of hours a borrower
has to return a recalled item and for the recaller to pickup the waiting
recall is important.

This patch implement a check in C4::Overdue->CalcFine() if item is
recalled.

If the item has been recalled and is past the due date then use the
recall_overdue_fine to calculate the appropriate fine to charge the
patron, otherwise use the fines value in the issuingrules table

Also implemented atomicupdate to change recalls waitingdate and
expirationdate to datetime datatypes with associated template changes in
the recalls reports to display the date and time of these recall values.

Test plan:
1. Apply all other patches on bug 19532 (except this patch)

2. Set a fine charge interval period (if you do not have this field set
in the circ rule then the fine will not be applied).

3. Set the 'Unit' of the circ rule to 'hours', 'Recall due date
interval' = 1, recall overdue fune amount= 1, recall pickup period=1

4. Check out an item to borrower A and recall it in the OPAC by borrower
B

5. In the database manually change the issues.date_due to 1 hour
before the current time

6. From the Koha shell run './misc/cronjobs/fines.pl'

7. Notice the fine of 1 has been applied to the borrower for being 1
hour late in returning the recall

8. Return the item and confirm the recall. Manually change the waiting
date to more than 1 hour before the current time and repeat step 6
running overdue_notices.pl

9. Notice the recall is overdue now

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #286 from Alex Buckley  ---
Created attachment 81246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81246=edit
Bug 19532: Added missing conditional check so now item availability for
recalled items on OPAC search results page is corrected

On the OPAC now if an item is a waiting recall then it is shown as 'On
reserve' rather than available.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #285 from Alex Buckley  ---
Created attachment 81245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81245=edit
Bug 19532: Fixed missing variable declaration error

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #284 from Alex Buckley  ---
Created attachment 81244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81244=edit
Bug 19532: Amended C4/Circulation->CanBookBeIssued()

This function now checks for waiting recalls before checking for
reserves on an item.

If a recall record does exist and it was placed by the same borrower who
is trying to check out the item then no check for reserves takes place
because the waiting recall takes precedence.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #283 from Alex Buckley  ---
Created attachment 81243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81243=edit
Bug 19532: Stop item status='Available' for waiting recalls

This patch alters the display of the item status in the staff client and
OPAC so items which are waiting recalls are not shown in these
interfaces with the status of 'available'.

Waiting recalls are not available they are only available to the patron
who recalled them.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #281 from Alex Buckley  ---
Created attachment 81241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81241=edit
Bug 19532: Fixed Internal Server error thrown upon returning recalled item

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #282 from Alex Buckley  ---
Created attachment 81242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81242=edit
Bug 19532: Fix t/db_dependent/Koha/Recalls.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #279 from Alex Buckley  ---
Created attachment 81239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81239=edit
Bug 19532: Amended the detail.pl call to retrieve recalls so now it retrieves
recalls with the status of 'R' or 'W'

This means the 'Item recalled by' text is displayed in the holdings
table in detail.pl for items with a recall with the status of recalled
or waiting.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #280 from Alex Buckley  ---
Created attachment 81240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81240=edit
Bug 19532: Stopping recalled items (recall status='R') from being renewed

Test plan:
1. Check out an item to a borrower and note the due date
2. Recall the item and note the updated due date
3. Try renewing the item and notice you can't. A message appears telling
you the item has been recalled and cannot be renewed.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #278 from Alex Buckley  ---
Created attachment 81238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81238=edit
Bug 19532: Stopping recalls awaiting pickup to be issued to patrons other than
the patron who recalled.

Also fixed the display of item status in the holdings table on detail.pl
on staff client so it doesn't say an item has been recalled when the
recall has the status of 'F' (fulfilled) or 'C' (cancelled)

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #277 from Alex Buckley  ---
Created attachment 81237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81237=edit
Bug 19532: Fixed display of recall buttons on opac-course-details.pl

Recall button now displayed on items in opac-course-details.pl which are
issued to another user.

No internal server error being thrown on courses with issued course reserves.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #276 from Alex Buckley  ---
Created attachment 81236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81236=edit
Bug 19532: Added conditional to check the recall has a status = 'W' before
setting it to closed

This solves a bug I found that if the same borrower number and itemnumber
combination occur more than once in the recalls database table then when the
item is checked out to the patron who recalled the item then the recall is not
updated to have a status of closed.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #275 from Alex Buckley  ---
Created attachment 81235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81235=edit
Bug 19532: Implemented check if recall status equals 'R' before recall popup is
shown

This stops the 'confirm recall' popup message being displayed upon item
return when the item has a recall with any status other than 'R' (recalled).

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #273 from Alex Buckley  ---
Created attachment 81233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81233=edit
Bug 19532 - New RECALL_REQUESTER_DET notice and print option on confirm recall
popup

This patch adds a new notice RECALL_REQUESTER_DET which like HOLD_SLIP
outlines borrower and item information so the item can be put aside for
the requester.

This patch also adds a 'Print and confirm' button to the 'Confirm
recall' popup that appears when returning a recalled item. This
functionality works the same as the 'Print and confirm' functionality
for the Hold slip: A print modal popup will appear for the user to
choose print settings, and choose to print or cancel.

Test plan:
1. Ensure 'UseRecalls' sypref is enabled and you have inputted
values for recalls fields in the circulation rules
(Administration->Circulation and fines rules)

2. Check item out to patron 1

3. Log into the OPAC as patron 2 and place a recall on the checked out
item

4. Return the item in the staff client

5. Notice there are only two buttons on the 'Confirm recall' popup which
appears: 'Confirm' and 'Cancel'

6. Apply patch, run updatedatabase.pl (as there is a SQL atomicupdate
file to be run), and restart memcached and plack

7. Using a new item repeat steps 2,3

8. In a new tab, in the staff client go to Circulation->Recalls queue,
and notice the recall has a status of 'Requested'

8. Back in your first tab return the item and notice that a new button
'Print and confirm' is on the 'Confirm recall' popup. Select this button
and notice two new popup windows appear: Browsers print window, and a
window showing what the notice to be print looks like.

9. If you have a printer available print the notice.

Otherwise you can look at what the notice would look like in the notice window,
observing the notice outlines the following information:

* Current date and time
* Recall pickup branch
* Borrowers first name and surname
* Borrowers cardnumber, phonenumber, address, address2, city, zipcode, email
* Recalled item title, author, barcode, callnumber.
* Recall waiting date, and recall notes

Some of these values will not be displayed on the notice if they are not
set. For example the patron may not have set an address, or email.

10. After either printing the notice, or selecting 'Cancel' in the print
window. Go back to your second tab and refresh the page and notice the
status of the recall has changed to 'Ready for pickup' this shows the
'Print and confirm' button does actually confirm the recall.

11. Making sure the changes implemented in the previous commit (Bug
19532 - Make the Recall confirmation popup appear everytime a recalled item is
put through returns) still work. Try returning the item again and notice the
'Confirm recall' popup with the 'Print and confirm' button is displayed again
and you can choose to print the notice again if you want.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #274 from Alex Buckley  ---
Created attachment 81234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81234=edit
Bug 19532: Fixing Internal Server Error thrown on C4/Circulation.pm

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #272 from Alex Buckley  ---
Created attachment 81232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81232=edit
Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item
is put through returns until it is checked out to recall requester

Previously the confirm recall popup was only displayed the first time
the recalled item was out through returns. However it is useful for the
Confirm recall popup to appear if the item is put through the returns
multiple times due to library staff being interrupted.

This ensures library staff are informed that the item has been recalled.

Test plan:
1. Ensure 'UseRecalls' sypref is enabled and you have inputted
values for recalls fields in the circulation rules (Administration->Circulation
and fines rules)

2. Check item out to patron 1

3. Log into the OPAC as patron 2 and place a recall on the checked out
item

4. Return the item and notice the 'Confirm recall' popup appears. Click
confirm

5. Now check the item in again and notice the popup is not displayed
this time.

6. Apply this patch

7. Restart memcached and plack

8. Using a new item repeat steps 2,3,4,5 and notice in step 5 the
'Confirm recall' popup is displayed this time. Click 'Confirm'

9. Check the item out to patron 2

10. Return the item and notice no popup is displayed.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #271 from Alex Buckley  ---
Created attachment 81231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81231=edit
Bug 19532 - Stopping an recalled item currently awaiting pickup from being able
to be checked out to patrons other than the recall requester.

Test plan:
1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for
recalls fields in the circulation rules (Administration->Circulation and
fines rules)

2. Check item out to patron 1

3. Log into the OPAC as patron 2 and place a recall on the checked out
item

4. Return the item and confirm the recall

5. In the staff client go to Circulation->Recalls queue, notice the
recall has a status of 'Ready for pickup'

6. Try issuing the item to patron 3 and notice without this patch
applied you can issue a recall awaiting pickup to a patron who did not
place the recall.

7. Apply patch

8. Restart memcached and plack

9. Using a new item repeat steps 1,2,3,4,5,6 and notice you get a yellow
message displayed stating: 'This item is awaiting pickup by another
patron who recalled it.'

The issuing has not taken place to a patron who is not the patron who
placed the recall as the item is awaiting pickup by the recall
requester.

10. Issue the item to patron 2 and notice the issuing takes place
successfully

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #270 from Alex Buckley  ---
Created attachment 81230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81230=edit
Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is
empty

Sponsored-BY: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #269 from Alex Buckley  ---
Created attachment 81229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81229=edit
Bug 19532 - Recalls for Course Reserves.

This ptach fixes the 'Template process error
Koha::Item->avail_for_recall' which is thrown when loading a Course pgae
in opac-course-details.pl with course reserves which are currently
issued.

It also allows recalls to be placed from Course reserves

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #268 from Alex Buckley  ---
Created attachment 81228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81228=edit
Bug 19532 - Fixes to stop transfer recall modal from being displayed
incorrectly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #267 from Alex Buckley  ---
Created attachment 81227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81227=edit
Bug 19532 - Improve and refine recalls functionality

Only allow 1 recall per item
When checking in only check for holds if no reserves found
Add a T/transferring status for recalls, only confirm them once arrived
Improve message when checking in recall
Fix clashing ids on recall-history
Check if patron can hold item before allowing recall
Prevent multiple recalls when pressing back button
Select/fill only active recall when issuing

To test:
1 - Repeat major test plan - verify all points
2 - Attempt to place multiple recallsusing back button, should fail
3 - Set all item level holds to not allowed, should not be able to place
recall
4 - Check-in recall at branch other than destination, should be in
transit
5 - Confirm at correct branch, should send message and get expiration
date etc.
6 - Return to another branch, should eb in transit again
7 - Play with circ rules and verify only allowed patrons can place
recall

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #266 from Alex Buckley  ---
Created attachment 81226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81226=edit
Bug 19532 (follow-up) Update characterset for recalls table

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #265 from Alex Buckley  ---
Created attachment 81225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81225=edit
Bug 19532: Extra fixes from Comment 68

This patch fixes the following:

The db uppdate tries to insert after 'notes' in issuing rules, but this
doesn't exist

When placing recall I always get a warning:
Warning: Your library does not allow recalls for
x item types.

Cancelling recall from 'Recall history tab' doesn't work

If patron has no recalls there is 'Patron has no current recalls'
message at bottom of tabs on checkout and details tabs for patron

When confirming a recall if the item is from another branch I get a
transfer generated as well as confirming hold for recall
Feature now checks if the recall branch is the same as the item
holding branch when checking in item to determine if transfer is
required

On recalls awaiting pickup:
need to update recall.borrower to recall.patron - causing
internal server error

When placing a recall - if I hit 'back' after confirming and
confirm again I get a second recall on the same item

Recalls queue should have waiting date information
Recalls queue should have a way to hide cancelled, I would
expect closed recalls to be hidden by default
Recalls queue now hides old (cancelled/expired/finished) recalls by
default and has a checkbox to toggle this

When viewing a patrons account in the staff side we should see
that a checkout has an active recall

Checking out the recall doesn't seem to close the recall
Added an 'F' status for finished/closed recalls

Signed-off-by: Nick Clemens 

Conflicts:
Koha/Schema/Result/Borrower.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #264 from Alex Buckley  ---
Created attachment 81224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81224=edit
Bug 19532: Notices for recalls

The notices:

-RETURN_RECALLED_ITEM
-PICKUP_RECALLED_ITEM

have been created and added to sample_notices.sql
Changed tools/letter.pl to use recalls table

Added notices to translated installers

https://bugs.koha-community.org/show_bug.cgi?id=19523

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #263 from Alex Buckley  ---
Created attachment 81223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81223=edit
Bug 19532: Extra fixes

This patch addresses some of Liz's comments in Comment 37

- shows new due date on opac-recall.pl when the recall is requested
- shows new due date on opac-recalls.pl recalls history
- shows new due date on circ/recalls_queue.pl
- syspref is default off
- recalls tab on catalogue/detail.pl
- show that there is a recall on an item on catalogue/detail.pl

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #261 from Alex Buckley  ---
Created attachment 81221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81221=edit
Bug 19532: Nice message if no recalls for opac recalls history

https://bugs.koha-community.org/show_bug.cgi?id=19523

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #262 from Alex Buckley  ---
Created attachment 81222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81222=edit
Bug 19532: POD fix, renaming methods

Tomas's comments:
- renaming 'Class methods' to 'internal methods'
- renaming 'borrower' and 'branch' methods to 'patron' and 'library'

other comments are out of date with current patches and do not need to
be actioned

when testing, confirm all data still shows as expected and nothing is
broken

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #260 from Alex Buckley  ---
Created attachment 81220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81220=edit
Bug 19532: Tests for Koha/Recalls

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #259 from Alex Buckley  ---
Created attachment 81219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81219=edit
Bug 19532: Cronjob to check for overdue recalls

This patch adds a check to the overdue_notices cronjob, so if any of the
overdue issues are also recalls, the status will be set to O (overdue)

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #258 from Alex Buckley  ---
Created attachment 81218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81218=edit
Bug 19532: Flagging recall as 'old' when expired or cancelled

Set 'old' flag to 1 if cancelling or expiring a recall

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #256 from Alex Buckley  ---
Created attachment 81216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81216=edit
Bug 19532: Send notice to user to return a recalled item

When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is
sent to the user who has the item checked out, with the updated due
date.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #257 from Alex Buckley  ---
Created attachment 81217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81217=edit
Bug 19532: Send notice to user to pickup recalled returned item

Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall
when the item is checked in.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #255 from Alex Buckley  ---
Created attachment 81215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81215=edit
Bug 19532: Recall pop up when checking in an item

When checking in an item on the staff side, the staff member will see a
pop up if there is a recall attached to that item. From here, they can
confirm the recall, setting the status to 'Waiting' and updating the
waitingdate. The item will still be checked in.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #254 from Alex Buckley  ---
Created attachment 81214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81214=edit
Bug 19532: UseRecalls syspref

This patch adds a syspref to control the usability of the recalls
feature

Test the following:

Staff side
/includes/circ-menu.inc
/includes/circ-nav.inc
/includes/members-menu.inc
/admin/preferences/circulation.pref
/circ/circulation-home.tt
/circ/circulation.tt
/circ/recalls_overdue.tt
/circ/recalls_queue.tt
/circ/recalls_waiting.tt
/members/moremember.tt
/members/recallshistory.tt

OPAC
/includes/usermenu.inc
/opac-recall.tt
/opac-recalls.tt
/opac-user.tt
/members/recallshistory.pl
/opac/opac-detail.pl

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #253 from Alex Buckley  ---
Created attachment 81213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81213=edit
Bug 19532: Only recall items checked out by other users

... shouldn't be able to recall items that are currently checked out by
yourself.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #252 from Alex Buckley  ---
Created attachment 81212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81212=edit
Bug 19532: Recalls awaiting pickup report

this patch adds reports for all recalls awaiting pickup, and recalls
that have been waiting more than X days. a syspref,
RecallsMaxPickUpDelay, is added to give a general max shelf time for
recalls

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #251 from Alex Buckley  ---
Created attachment 81211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81211=edit
Bug 19532: Overdue recalls report

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #250 from Alex Buckley  ---
Created attachment 81210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81210=edit
Bug 19532: Recalls queue

This patch adds a recalls queue page to the circulation reports

You can see all recalls made in the system, who requested them, their
status and other relevant info. you can cancel individual or multiple
recalls.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #249 from Alex Buckley  ---
Created attachment 81209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81209=edit
Bug 19532: recalls history

this patch
- adds recalls history (similar to holds history) to OPAC and intranet
- edits the tables in opac-user.pl (OPAC), moremember.pl and
circulation.pl (staff) so that it only shows active recalls (recalls
that have been requested or are waiting)
- some extra datatables fixes

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #248 from Alex Buckley  ---
Created attachment 81208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81208=edit
Bug 19532: Fixing broken OPAC recalls table

Forgot to add 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #247 from Alex Buckley  ---
Created attachment 81207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81207=edit
Bug 19532: Show recalls on intranet side

This patch
- adds Recall tab to the Check out section of member account, and to the
Details section of member account
- Functionality to cancel recalls on staff side
- Fixing cancel on OPAC side (before I was deleting the whole recall
instead of cancelling)
- Fixing validation when checking whether a recall can be placed on an
item that has been recalled by this borrower before. If the old recall
is expired or cancelled then they can make a recall again.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #246 from Alex Buckley  ---
Created attachment 81206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81206=edit
Bug 19532: Cancel recall and see recalls in OPAC

This patch adds ability for user to cancel a recall
They can also see their recalls in the user summary

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #245 from Alex Buckley  ---
Created attachment 81205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81205=edit
Bug 19532: Recall an item in OPAC

 This patch:
  - adds the 'Recall' button to the item on it's detail page
  - adds ability to place a recall
  - the recall is stored in the recalls table
  - the due date for the checkout is updated to whatever has been set in
  the issuing rule under recall_due_date_interval
  - error messages for if the user isn't logged in, the user tries to
  place a recall on an item they have already recalled, or if storing
  the recall in the db fails for any reason

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #244 from Alex Buckley  ---
Created attachment 81204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81204=edit
Bug 19532: Circulation rules

Adding 3 new rules and columns to issuingrules
- recall_due_date_interval
- recall_overdue_fine
- recall_shelf_time

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78763|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78766|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78765|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78768|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78770|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78772|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78775|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78776|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78773|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78774|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80764|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80763|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80765|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80766|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80767|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80768|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80769|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80770|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80772|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80773|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80776|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80774|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80771|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80775|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80777|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80779|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80778|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80782|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80781|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80784|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80780|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80785|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80783|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80787|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80786|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80789|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80788|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80878|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80793|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #243 from Alex Buckley  ---
Hi all

I have gone through and rebased again and will be attaching the rebased patches
now. 

I will also be adding further enhancement patches.

Apologies for the email deluge. 

Cheers,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #65 from Aleisha Amohia  ---
(In reply to Séverine Queune from comment #63)
> Tested with Zebra : works fine !
> 
> Tested with Elasticsearch :  works fine except for "60 results per page" (UI
> + OPAC) : each time there is more than 1 results, using "Last" button
> failed : "Error: Unable to perform your search. Please try again."
> 
> As it's not supposed to work with ES, I don't know if I should change the
> status to "Failed" or sign the patch...

Hi there! Can you please test again - i have hidden the dropdown if
Elasticsearch is enabled to avoid this error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #79988|0   |1
is obsolete||

--- Comment #64 from Aleisha Amohia  ---
Created attachment 81203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81203=edit
Bug 14715: (follow-up) Edits for ElasticSearch

Note added to preferences that the dropdown should not be used with
ElasticSearch activated.
Dropdowns do not show on search results on staff side or OPAC side if
Elasticsearch enabled.

Ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21641] Software error when checking out an item with a charge associated with it

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641

--- Comment #14 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #10)
> The accountno field and the associated functions should be removed. I don't
> think we should move that anywhere. :-D

Hmmm... we already have accountlines_id. You're probably right, cut and
refactor anything that used it. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21669] TT assignment statements must not be html filtered

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|TT assignement statements   |TT assignment statements
   |must not be html filtered   |must not be html filtered

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

--- Comment #33 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #32)
> (In reply to Aleisha Amohia from comment #30)
> > (In reply to Katrin Fischer from comment #27)
> > > Does it fail with Elasitc with and without this patch?
> > 
> > This is a good point. I've retested and can confirm that we cannot add to a
> > basket with elasticsearch enabled, with or without the patch.
> 
> Hi Aleisha, could you maybe file a bug with your findings? This seems major.

Done - see Bug 21675.

Would like to see this one get through anyhow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21675] New: Unable to add to a basket with ElasticSearch enabled

2018-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21675

Bug ID: 21675
   Summary: Unable to add to a basket with ElasticSearch enabled
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Found when testing Bug 16939.

To reproduce:
Set SearchEngine syspref to Elasticsearch
Go to Acquisitions and find a basket 
Add an order to the basket from an existing record
Confirm error

Message in error logs:
neworderbiblio.pl: [NoNodes] ** No nodes are available:
[http://localhost:9200], called from sub
Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/usr/share/perl5/Catmandu/Store/ElasticSearch.pm line 27. at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 437., referer:
http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl
neworderbiblio.pl: Unable to perform your search. Please try again., referer:
http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >