[Koha-bugs] [Bug 20602] Use search fields weight/relevancy on OPAC simple search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602 --- Comment #10 from Katrin Fischer --- I think it can't be avoided, we are not trying to rebuild Zebra as is, but something that will hopefully work better :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #10 from David Cook --- (In reply to David Cook from comment #9) > Actually going to use this cpanfile now with plenv to do some > troubleshooting... Or rather I guess I'll install carton with plenv and go from there... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #9 from David Cook --- Actually going to use this cpanfile now with plenv to do some troubleshooting... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #8 from M. Tompsett --- Not that lots of people run it anymore, but ./koha_perl_deps.pl should probably be tweaked too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 --- Comment #7 from Alex Buckley --- Created attachment 81611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81611=edit Bug 21628: (follow-up) Indentation and filter corrections This patch modifies the new waiting_holds.inc to fix the indentation. A template variable filter has been added to quiet QA tool warnings. Buttons are now styled as Bootstrap buttons. To test, apply the patch and view the holds report. Confirm that everything looks correct. Validate the HTML and confirm that there are no errors in the HTML of the body of the page. Followed test plan, everything looked correct and no HTML errors on waitingreserves.tt found by HTML validator Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 Alex Buckley changed: What|Removed |Added Attachment #81485|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 --- Comment #6 from Alex Buckley --- Created attachment 81610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81610=edit Bug 21628: Simplify holds awating pickup report To test: 1 - Place a number of holds 2 - Check in the items and confirm the holds 3 - Visit /cgi-bin/koha/circ/waitingreserves.pl 4 - View the report 5 - Apply patch 6 - Confirm that the report looks the same 7 - Confirm cancelling holds works as before Signed-off-by: Owen Leonard Followed test plan, patch worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 Alex Buckley changed: What|Removed |Added Attachment #81486|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #18 from David Cook --- This is an interesting one... I have the exact same Koha code running on Debian Jessie and OpenSUSE. The code on OpenSUSE works fine, but the code on Debian is creating the error reported in this bug. Debian is Perl 5.20.2 using Koha apt repository and Debian apt repo for dependencies. Exporter is 5.71. OpenSUSE is Perl 5.18.2 using CPAN for dependencies. Exporter is 5.68. -- Doesn't look like there's anything important in the Exporter changelog: https://metacpan.org/changes/distribution/Exporter. -- Hmm, the C4::Items::Item2Marc function looks exactly the same in 17.05.xx as it does in older versions of Koha that worked fine on Debian. When I try the older Koha library code on Debian with a little script I've written, it works fine (notwithstanding expected database schema errors). It's an issue with the newer Koha library code... The exports look basically the same in C4::Biblio between versions. -- So it looks like something we must have done... yet it also looks like it depends on the system Perl too. Going to try a different Perl on OpenSUSE and see if that makes a difference... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Permanent location should show instead of cart location - course-details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #5 from Alex Buckley --- Hi there Could you please rebase your patches as they are not applying cleanly on master. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21446: Correct perm location and enhance Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt Failed to merge in the changes. Patch failed at 0001 Bug 21446: Correct perm location and enhance The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21446-Correct-perm-location-and-enhance-6FL5FL.patch Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #14 from Alex Buckley --- Patch works as described and I also ran t/db_dependent/Accounts.t unit test which also passes. I have corrected the commit message to be in the format 'Bug: ' so it matches commit message guidelines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #13 from Alex Buckley --- Created attachment 81609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81609=edit Bug 18805: Add ability to use up account credits Right now, in Koha, credits always have a static amount outstanding. So if a patron owes $10 in fines, and has a $10 credit, they technically owe nothing, but yet they still owe $10. This seems rather confusing. Instead, we should add the ability for credits to be used to pay down closed out fines and other fees. Test Plan: 1) Apply this patch and dependencies 2) Create a manual credit of some amount 3) Create a manual invoice 4) Note the manual invoice was automatically paid down using the balance from the manual credit! Followed test plan, patch worked as described. I also ran t/db_dependent/Accounts.t test which passed Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #80415|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21273] After upgrade from 17.11.08 to 18.05.02 intra not working, Software error: Template process failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21273 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I've noticed this as well recently. I was wondering if it was intentional or not... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20602] Use search fields weight/relevancy on OPAC simple search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #9 from David Cook --- I was going to say that this makes Zebra and ElasticSearch behaviours deviate, but after a glance... I think they already deviate a lot? Field weighting for Zebra is done really badly, so I wouldn't want it added to the Zebra simple search anyway... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #72 from David Cook --- Cheers for working on this Ere! I was going to suggest using XML::LibXSLT::register_function() to solve this problem, which I've done locally for years, but your comment reminded me of EXSLT! That seems like an easier way to do it. A while ago, I actually ended up using EXSLT in DSpace since Apache Xalan supports it and I needed some extension features. It's a very interesting read: http://exslt.org/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21707] Wrong CSRF token - adding a new patron with auto generated card number turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21707 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I think I've had people having this same problem as well, but I've only heard sporadic reports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13812 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #11 from David Cook --- Ah Jonathan is all over this at #21526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #4 from Alex Buckley --- Created attachment 81608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81608=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #80953|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #10 from David Cook --- Just realized that Katrin's comment is from February 2017. I see there is a html filter on the OPAC template: [% facet.facet_label_value | html %] I have no idea why we're html escaping the URL... But it does seem to work... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #7) > I think we see this happen with single quotes in an author name in facets. > The name is: Kum'a N'dumbe. A keyword search for the name works, but when > you search au:Kum'a N'dumbe - no results. Same when you click on the facet > with this name: > > > /cgi-bin/koha/catalogue/search. > pl?idx=kw=kamerun_by=relevance_dsc=au:Kum'a N'dumbe, Alexandre This is the URL that appears for my facets in master: /cgi-bin/koha/opac-search.pl?idx=kwq=testsort_by=relevance_dsclimit=au:Kum%27a%20N%27dumbe,%20Alexandre The URL works although it does look like the ampersands are being erroneously escaped as well... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #8 from David Cook --- (In reply to Katrin Fischer from comment #7) > I think we see this happen with single quotes in an author name in facets. > The name is: Kum'a N'dumbe. A keyword search for the name works, but when > you search au:Kum'a N'dumbe - no results. Same when you click on the facet > with this name: > > > /cgi-bin/koha/catalogue/search. > pl?idx=kw=kamerun_by=relevance_dsc=au:Kum'a N'dumbe, Alexandre Thanks for that info. I'll try to reproduce this one, and see about writing a quick patch... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18768] Add the ability to authenticate patrons against other ILSs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18768 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18175] Makefile sets koha-httpd api path incorrectly for standard installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #35 from David Cook --- (In reply to Tomás Cohen Arazi from comment #34) > This is worth discussing in koha-devel, and IRC meeting or Marseille, but I > think we should have a job queue in the lines of what David proposes. And I > would add maybe the use of ZeroMQ to possibly notify other services. I agree about opening up the discussion in another forum like koha-devel, IRC, or Marseille. I'm intrigued by the use of ZeroMQ. How do you see that working, Tomás? When I first started thinking about background processing, I thought using a message queue would be a good idea. Since then, I've used an embedded ActiveMQ with the Fedora repository a bit, but that publishes notifications about record changes. Celery uses a message queue for sending out tasks and then it can use a backend like Redis for storing task results. I think if we use a database for a job queue, that would replace the message queue? Or are you meaning using a message queue for notifying other services like an indexer that there are imported records to index? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21717] TestBuilder.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21717
--- Comment #2 from Alex Buckley ---
Created attachment 81607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81607=edit
Bug 21717: Fix generation of real's values
With strict SQL modes we now have TestBuilder tests that fail randomly with:
Out of range value for column 'tax_rate_on_receiving'
Out of range value for column 'discount'
We are trying to insert a value that is too high for the type defined at DB
level.
It happens for discount when a value > 100 is generated. The datatype is
float(6,4).
>From the MySQL Doc:
"""
MySQL permits a nonstandard syntax: FLOAT(M,D) or REAL(M,D) or DOUBLE
PRECISION(M,D).
Here, (M,D) means than values can be stored with up to M digits in total, of
which D digits may be after the decimal point.
"""
So float(6,4) does not allow 100.
To recreate easily the issue:
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
$builder->build( { source => 'Aqorder', value => { discount => 100 } }
)->{discount};
To make sure this patch fixes the issue you can use this script:
use Modern::Perl;
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
my ( $real, $i ) = ( 0, 0 );
while ( $real < 100 ) {
$real = $builder->_gen_real( { info => { size => [ 6, 4 ] } } );
warn $i++;
}
warn "$i - $real";
Test plan:
0/ Does not apply this patch
1/ Run the snippet above
2/ Confirm that it fails quite quickly (constantly before 500 for me)
3/ Apply this patch
4/ Run again the script
5/ Confirm that it is stuck in an infinite loop
6/ CTRL-C :D
QA Note:
Other _gen_* subroutine may need a fix, but we will wait for them to fail
TODO:
1. Add JS check to the interface to prevent the use to enter a value > 100
2. Allow '100' as a valid value for discount (?)
Followed test plan, patch worked as described
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21717] TestBuilder.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21717 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #81582|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21717] TestBuilder.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21717 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 --- Comment #21 from M. Tompsett --- Comment on attachment 81530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81530 Bug 21526: Use the 'url' filter when needed Review of attachment 81530: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21526=81530) - Generally, if there was no comment, I don't think there was a problem, OR... I commented about a problem elsewhere, and didn't feel like repeating it over and over. Here's some feedback. There ARE some Failed QA issues. ::: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc @@ +10,4 @@ > > [% IF marcflavour == 'UNIMARC' %] > [% IF authid %] > +[% link = BLOCK %][% > heading | html %][% END %] Perhaps this line and line 31 should use the same method to build the URL? I tend to prefer 31's split. @@ +28,4 @@ > > [% IF ( linkType=='seealso' ) %] > [% IF ( authid ) %] > +[% heading | > html %] Nice catch on the URL vs URI. But I think URI should be used for the base part, and URL for anything we are adding to it, unless there is a bizarre & at the end or something. ::: koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc @@ +33,4 @@ >[% IF facet.active %] > [% SET local_url = url _ "nolimit=" _ facet.type_link_value _ > ":" _ facet.facet_link_value %] > [% facet.facet_label_value | html %] > +[x] Yes. Because local_url is the WHOLE url, the url filter is right. @@ +45,4 @@ >[% END %] >[% IF ( facets_loo.expandable ) %] > > + Show more If url is more than the base url, then url is correct, but the others are single values, so I would think it is uri. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +413,4 @@ > > [% batch_lis.staged_date | $KohaDates with_hours => 1 | html > %] > [% batch_lis.num_records | html %] > +Add > orders Nice correction of the uri to url. Also, see the use of uri here for the token-y parts? That's what I would expect. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt @@ +2,4 @@ > [% USE Asset %] > [% BLOCK csv_export %] > > + > Export as CSV Okay, so should the token-y parts be uri or html? Hmmm... html, to prevent security attacks? Perhaps all the tiny parts should be html. So far, it hasn't been consisten. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt @@ +264,4 @@ > Phone: [% phone | html %] > Fax: [% fax | html %] > [% IF ( url ) %] > +Website: [% url | html %] Right, the url filter for a full URL, and the html filter to display it without running any sort of weird scripting security side effects. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt @@ +96,4 @@ > > > > +Cancel missing changing an html to uri. ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt @@ +13,4 @@ > [% END %] > [% INCLUDE 'doc-head-close.inc' %] > > + BAD FILTER! IntranetFavicon missing a filter name. If interface is a url, then html is the wrong filter. theme probably should be uri. ::: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ +405,4 @@ >name="total" size="10" value="[% total | html %]"/> > > name="returnsuggested" value="[% IF ( returnsuggestedby ) %][% > returnsuggestedby | html %][% ELSE %]noone[% END %]"/> > +[% IF ( suggestionid ) %] class="cancel" href="[% IF ( returnsuggestedby ) > %]/cgi-bin/koha/members/moremember.pl?borrowernumber=[% returnsuggestedby | > uri %]#suggestions[% ELSE %]suggestion.pl[% END %]">Cancel[% ELSE > %] href="suggestion.pl">Cancel[% END %] Nice correction of html to uri in the url build part, but the hidden value's value... perhaps uri? After all, it's like the portion of a long GET request, not a string to display. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt @@ +201,4 @@ > [% IF MARCurl.part > %][% MARCurl.part | html %][% END %] > > [% IF > OPACURLOpenInNewWindow %] > + target="_blank" rel="noreferrer">[% MARCurl.linktext | html %] Should note that I agree that title should use html filter, because it's just a tooltip, not actually a link value. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +337,4 @@ > > [% IF ( OPACURLOpenInNewWindow ) %] > [% IF trackclicks == 'track' || > trackclicks == 'anonymous' %] > +
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #7 from Alex Buckley --- Can you please rebase your patches, the second patch is currently not applying cleanly on master, as the below output shows: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19735: Script to generate cpanfile (DO NOT PUSH) Applying: Bug 19735: Move Perl deps definitions into a cpanfile Using index info to reconstruct a base tree... M C4/Installer.pm M C4/Installer/PerlDependencies.pm M C4/Installer/PerlModules.pm M Makefile.PL M about.pl M debian/list-deps M installer/install.pl Falling back to patching base and 3-way merge... Removing t/Installer_PerlDependencies.t Auto-merging installer/install.pl Auto-merging debian/list-deps Auto-merging about.pl Auto-merging Makefile.PL Auto-merging C4/Installer/PerlModules.pm CONFLICT (content): Merge conflict in C4/Installer/PerlModules.pm CONFLICT (modify/delete): C4/Installer/PerlDependencies.pm deleted in Bug 19735: Move Perl deps definitions into a cpanfile and modified in HEAD. Version HEAD of C4/Installer/PerlDependencies.pm left in tree. Auto-merging C4/Installer.pm Failed to merge in the changes. Patch failed at 0001 Bug 19735: Move Perl deps definitions into a cpanfile The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19735-Move-Perl-deps-definitions-into-a-cpanfi-S1GHo1.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Attachment #80956|0 |1 is obsolete|| --- Comment #50 from Aleisha Amohia --- Created attachment 81603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81603=edit Bug 12365: Notes for rules This patch adds a note column to the circ and fine rules to act as a description line for the rule. To test: 1) Apply patch, update database (may have to also update schema) 2) Go to Admin -> Circ and fine rules 3) Scroll to the right, notice new Note column 4) Confirm it works to create a brand new rule with a Note 5) Confirm it works to modify an existing rule with a Note Sponsored-by: Catalyst IT Lee Jamison rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. Signed-off-by: Mark Tompsett Signed-off-by: macon lauren KohaCon17 Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #7 from Alex Buckley --- Can you please rebase your patch it is currently not applying cleanly on master, as the below output shows: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14420 : bulkmarcimport.pl - Some problems Using index info to reconstruct a base tree... M misc/migration_tools/bulkmarcimport.pl Falling back to patching base and 3-way merge... Auto-merging misc/migration_tools/bulkmarcimport.pl CONFLICT (content): Merge conflict in misc/migration_tools/bulkmarcimport.pl Failed to merge in the changes. Patch failed at 0001 Bug 14420 : bulkmarcimport.pl - Some problems The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14420--bulkmarcimportpl---Some-problems-T8e2dA.patch You have new mail in /var/mail/vagrant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #54 from Aleisha Amohia --- Rebased. Setting back to signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Attachment #80998|0 |1 is obsolete|| --- Comment #53 from Aleisha Amohia --- Created attachment 81606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81606=edit Bug 12365: (follow-up) Fixing broken circ rules table Adding filters to note to satisfy qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Attachment #80958|0 |1 is obsolete|| --- Comment #52 from Aleisha Amohia --- Created attachment 81605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81605=edit Bug 12365: (follow-up) Putting backticks in atomicupdate Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Attachment #80957|0 |1 is obsolete|| --- Comment #51 from Aleisha Amohia --- Created attachment 81604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81604=edit Bug 12365: (follow-up) Adding maxlength attribute and popover Test that you can't add a note of more than 100 characters. Test notes with rules, notes are hidden by 'View note' and the popover correctly displays note. View the note by hovering over the link I've moved the Note column so the popover displays nicely and doesn't cover the buttons. I've also changed the placement so that it doesn't cover information in the row. Update: Test that you can edit the note when clicking 'Edit' and that behaviour is the same for editing all other fields Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21719] Fix typos in codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21719 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21719] Fix typos in codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21719 --- Comment #1 from Josef Moravec --- Created attachment 81602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81602=edit Bug 21719: Fix typos This patch was generated using codespell Test plan: Read through changes and confirm they make sense Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21719] New: Fix typos in codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21719 Bug ID: 21719 Summary: Fix typos in codebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21719] Fix typos in codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21719 Josef Moravec changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #33 from Jonathan Druart --- *** Bug 17876 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17876] Show more invoice information in subscription details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17876 Jonathan Druart changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 21467 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18175] Makefile sets koha-httpd api path incorrectly for standard installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Jonathan Druart changed: What|Removed |Added Assignee|alex.sassmannshausen@gmail. |martin.renvoize@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19691] Enforce OPAC SEARCH LIMIT server-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19691 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #2 from Alex Buckley --- Hi there Can you please rebase this as it is not applying cleanly on master as the below output shows: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19691 - Move code to opac-search.pl Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Failed to merge in the changes. Patch failed at 0001 Bug 19691 - Move code to opac-search.pl The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19691---Move-code-to-opac-searchpl-BrIj3i.patch Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- See bug 21526 comment 19. There are plenty to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Alex Buckley --- This still looks to be applicable for master as the item objects are still not being handed to C4::Reserves::IsAvailableForItemLevelRequest(). I tried applying it to master, and the patch doesn't apply cleanly (as the below output shows), can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest fatal: sha1 information is lacking or useless (C4/Reserves.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19302-Send-kohaobjects-to-C4ReservesIsAvailabl-wrc9H7.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Josef Moravec --- When I try to add title level hold on biblio without items, I get this error: Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 670 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18175] Makefile sets koha-httpd api path incorrectly for standard installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #2 from Alex Buckley --- Hi there Sorry this patch is not applying cleanly on master (as the below output shows), can you please either rebase the patch or define the Koha version this patch should be used on? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18175: Use Makefile variable for api path. Using index info to reconstruct a base tree... M etc/koha-httpd.conf Falling back to patching base and 3-way merge... Auto-merging etc/koha-httpd.conf CONFLICT (content): Merge conflict in etc/koha-httpd.conf Failed to merge in the changes. Patch failed at 0001 Bug 18175: Use Makefile variable for api path. The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18175-Use-Makefile-variable-for-api-path-cy4MsZ.patch Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Attachment #79049|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21581] Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #7 from Josef Moravec --- Created attachment 81600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81600=edit Bug 21581: Pass through authorities indexes To test: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml none,fatal,warn,request,info 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' 12 - Apply patch 13 - Reapply matching 14 - Note we search the expected index and no match is found NOTE: By applying bug 21579, I was able to view the difference, and see that it didn't match identically, because I had moved the value from 010 to 155. No log checking needed. clean/delete batch. Apply patch, no match. clean/delete batch. Edit authority back, matches. Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Attachment #79048|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Attachment #79047|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Attachment #81372|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Attachment #81374|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added Attachment #81373|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Attachment #81371|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21581] Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21581] Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21581] Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #8 from Josef Moravec --- Created attachment 81601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81601=edit Bug 21581: (QA follow-up) Update comment according to code in SearchAuthorities Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21581] Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec changed: What|Removed |Added Attachment #81064|0 |1 is obsolete|| Attachment #81065|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 81599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81599=edit Bug 21581: Unit tests and updated data To test: 1 - Apply this patch only 2 - prove -v t/db_dependent/Search.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/Search.t 6 - It passes! Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18768] Add the ability to authenticate patrons against other ILSs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18768 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #3 from Alex Buckley --- Hi Kyle Can you please rebase, as you can see the patches are not applying cleanly on master: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18768 - Convert logic in sip_cli_emulator to a reusable library Applying: Bug 18768 - Add support for authenticating against external SIP servers ala LDAP and CAS /home/vagrant/kohaclone/.git/rebase-apply/patch:360: trailing whitespace. Make sure that ALL required fields are populated by your LDAP database (and mapped in KOHA_CONF). /home/vagrant/kohaclone/.git/rebase-apply/patch:401: trailing whitespace. Once a user has been accepted by the LDAP server, there are several possibilities for how Koha will behave, depending on /home/vagrant/kohaclone/.git/rebase-apply/patch:417: trailing whitespace. their SIP password OR their local one. If this is a problem, then you should enable update and supply a mapping for warning: 3 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Auth.pm :360: trailing whitespace. Make sure that ALL required fields are populated by your LDAP database (and mapped in KOHA_CONF). :401: trailing whitespace. Once a user has been accepted by the LDAP server, there are several possibilities for how Koha will behave, depending on :417: trailing whitespace. their SIP password OR their local one. If this is a problem, then you should enable update and supply a mapping for warning: 3 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm Failed to merge in the changes. Patch failed at 0001 Bug 18768 - Add support for authenticating against external SIP servers ala LDAP and CAS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18768---Add-support-for-authenticating-against-rU5kes.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 --- Comment #10 from Eric Phetteplace --- Just a follow up: our staff continued to discuss this and agreed that "Accounting" doesn't seem right for a patron-facing term, it seems likely to cause confusion. "Fines" was preferred. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #32 from Jonathan Druart --- (In reply to Katrin Fischer from comment #31) > Jonathan, can you explain a bit more? > > 1) I am a little confused as to what items means in the test plan. Items > from the order = Invoices I plan to enter? Or Issues? The number of issues you are expecting for this subscription. > 2) What about the FIXMEs? > - standing orders - why can't it cohabit? If these changes only applied to > 'order by subscription' it would be ok, right? You can create an order from a subscription, using a basket that has the standing orders flag. > - cancelling order It was a question for the tester, and Séverine confirmed me it seems to work ok in case of cancelled orders. > I'll come back to this, but continuing somewhere else first. > > Can you please check my follow-up? It looks great, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #9 from Jonathan Druart --- Created attachment 81598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81598=edit Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21713] ExpireReservesonHolidays not obeying calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- IIRC this is only used by the cronjob, it won't cancel when the library is closed. Have you checked ExcludeHolidaysFromMaxPickUpDelay? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #8 from Jonathan Druart --- Ha, it does not happen 100% of the time, it depends on the order of the fieldset and the ol elements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #20 from Katrin Fischer --- Couldn't resist, being a librarian and all. Moving back to "Signed off" as last 2 follow-ups have been trivial and this was already signed-off before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #19 from Katrin Fischer --- Created attachment 81597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81597=edit Bug 20334: Move new system preferene into right spot in alphabet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #0) > To recreate: > 1. Create 1+ authorised values PA_CLASS > 2. Create patron's attributes using it > 3. Edit a patron 4. Turn HouseboundModule off (!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #320 from Alex Buckley --- Created attachment 81595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81595=edit Bug 19532: Fixes and enhancements to recalls This implements the following fixes and enhancements: * Stopping a waiting recall from being able to be checked out to patrons other than the patron who placed the recall * Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester * Introduce a new notice RECALL_REQUESTER_DET which outlines borrower and item information so the item can be put aside * Stop recalled items from being renewed * Stop display of 'Available' for waiting recalls * Check if recalls exist on an item before checking for reserves * Added ability to set Recall due date interval, and Recall pickup period in hours * Fix the 'Template process error Koha::Item->avail_for_recall' thrown on course page where a course reserve is currently issued Test plan: 1. Repeat major test plan - verify all points 2. Place another recall and check it in 3. Try checking the recall out to a different patron and confirm you are not able to check out a waiting recall to a different patron 4. Check the same item in again and observe that the recall modal is displayed again and is displayed every time the item is checked in until the item is checked out to the patron who placed the recall 5. Check the item in again and select the 'Print slip and confirm' and confirm the RECALL_REQUESTER_DET notice can be printed 6. Place a recall on an item and try to renew the item and confirm you are unable to renew recalled items 7. Return the same item and confirm in the OPAC and staff client that the item is not shown as available 8. Place a recall to one borrower then reserve the same item to a different borrower. Check the item in and confirm the recall modal is displayed not the reserve modal as recalls take precedence 9. In circ and fine rules set a rules 'Fine charge interval period'=1 10. Set the 'Unit' of the circ rule to 'hours', 'Recall due date interval' = 1, 'Recall overdue fine amount'=1, 'Recall pickup period'=1 11. Check out an item to borrower A and recall it in the OPAC by borrower B 12. In the database manually change the issues.date_due to 1 hour before the current time 13. From the Koha shell run './misc/cronjobs/fines.pl' 14. Notice the fine of 1 has been applied to the borrower for being 1 hour late in returning the recall 15. Return the item and confirm the recall. Manually change the waiting date to more than 1 hour before the current time and run ./misc/cronjobs/overdue_notices.pl 16. Notice the recall is overdue now - Steps 9-16 test point #7 above 17. Enable 'UseCourseReserves' syspref 18. Check out a course reserve item to a borrower 19. In the OPAC navigate to the course page containing the issued course reserve and confirm the page loads successfully 20. Recall a course reserve and confirm recalls works for course reserves Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Katrin Fischer changed: What|Removed |Added Attachment #80943|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 81596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81596=edit Bug 21622: Remove incorrect GROUP BY clauses in acqui script acqui/ordered.pl:GROUP BY aqorders.ordernumber acqui/spent.pl:GROUP BY aqorders.ordernumbe 'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY Test plan: - Create orders for different basket and using different funds - Receive some of them - Hit the ordered and spent pages (from the acqui home page) => The tables must contain the same data with and without this patch Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21714] Unable to view vendor with strict_sql_modes enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21714 Jonathan Druart changed: What|Removed |Added Depends on||21385 Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 [Bug 21385] Vendor search: Item count is incorrectly updated on partial receive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Attachment #81588|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly updated on partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart changed: What|Removed |Added Blocks||21714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21714 [Bug 21714] Unable to view vendor with strict_sql_modes enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #0) > To recreate: > 1. Create 1+ authorised values PA_CLASS > 2. Create patron's attributes using it > 3. Edit a patron 4. Turn HouseboundModule on -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21714] Unable to view vendor with strict_sql_modes enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21714 --- Comment #3 from Jonathan Druart --- Jenkins is currently failing because of this, the SQL error is: "Non-grouping field 'expected_items' is used in HAVING clause" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21702] mancredit.pl incorrectly passes user_id instead of the patron id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21702 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21702] mancredit.pl incorrectly passes user_id instead of the patron id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21702 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21702] mancredit.pl incorrectly passes user_id instead of the patron id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21702 Josef Moravec changed: What|Removed |Added Attachment #81464|0 |1 is obsolete|| Attachment #81465|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 81593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81593=edit Bug 21702: Make mancredit.pl use the patron id for the staff user I think unsafe SQL modes and the fact that manager_id has no FK allowed this to go unnoticed. But now we catch it! To test: - On a patron, try adding a new manual credit of any type => FAIL: It fails telling the userid of the logged user is not a valid integer! - Apply this patch - Try adding a manual credit of any type => SUCCESS: Manual credit added! - Sign off! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Isherwood Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21702] mancredit.pl incorrectly passes user_id instead of the patron id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21702 --- Comment #6 from Josef Moravec --- Created attachment 81594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81594=edit Bug 21702: (follow-up) Simplify checks and use standard fallback behaviour This patch acknowledges the fact that some checks here are done in a way that is not standard these days. This checks are originally done multiple times in different ways. output_and_exit_if_error should be used. This implies a minor behaviour change: if the passed (in the URL) borrowernumber doesn't exist, it sends the user to a 'Patron doesn't exist page' instead of the circulation page for the borrowernumber. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Isherwood Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Jonathan Druart changed: What|Removed |Added Status|REOPENED|NEW --- Comment #5 from Jonathan Druart --- I confirm it still exists indeed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #319 from Alex Buckley --- Rebased and re-attached to this bug report. Can you please re-test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21433] Switch two-column templates to Bootstrap grid: Tools part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21433 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21433] Switch two-column templates to Bootstrap grid: Tools part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21433 Josef Moravec changed: What|Removed |Added Attachment #80239|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 81592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81592=edit Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1 This patch modifies several tools templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 21433] Switch two-column templates to Bootstrap grid: Tools part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21433 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21718] Lists of pending/received orders for a fund explodes with strict modes active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21718 Jonathan Druart changed: What|Removed |Added Blocks||17258 Depends on|17258 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Blocks|21714, 21718| Depends on||21714, 21718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21714 [Bug 21714] Unable to view vendor with strict_sql_modes enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21718 [Bug 21718] Lists of pending/received orders for a fund explodes with strict modes active -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21714] Unable to view vendor with strict_sql_modes enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21714 Jonathan Druart changed: What|Removed |Added Blocks||17258 Depends on|17258 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #11 from Liz Rea --- Hi, I think this patchset caused bug 21080 - classes of attributes go outside of the attributes area when HouseBound is disabled. Attributes that have no class are fine. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
