[Koha-bugs] [Bug 21831] New: Marc modification templates move all action moves only one field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21831 Bug ID: 21831 Summary: Marc modification templates move all action moves only one field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org If you have a marc modification template action to "move all fields XXX to YYY", and the field XXX has been repeated in a record, only the first XXX field is moved. Same applies to "copy" and "copy and replace" actions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21819] Marc modification templates action always checks Regexp checkbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21819 paxed changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Component|Templates |Tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21744] Getting Error 500 while trying to Upload patron images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21744 Harjinder Singh Nagi changed: What|Removed |Added Summary|Getting Error 500 e trying |Getting Error 500 while |to Upload patron images |trying to Upload patron ||images --- Comment #6 from Harjinder Singh Nagi --- I would appreciate if you can provide an update on the issue reported -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 Nick Clemens changed: What|Removed |Added Keywords||rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Nick Clemens changed: What|Removed |Added Keywords||rel_18_11_candidate --- Comment #246 from Nick Clemens --- After discussion with several people I am considering this one and bug 20244 still as ES is not widely used and needs these improvements to be more usable. I tested what I can see, but can I get a detailed test plan to ensure we are covered here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21799] Change wording for quantity input field on order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21799 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #20 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21282] Ordered/spent lists should use prices including tax for calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #69 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17597] Outdated translation credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17597 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21830] error stopping log in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21830 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi, this kind of error indicates that your Koha installation can't connect to the database. There can be different reasons for this to happen, but it's very likely not a bug but a setup issue of your installation. These kinds of questions are better asked on the mailing list: https://koha-community.org/support/koha-mailing-lists/ Many more people will read there and be able to help than on bugzilla which is used for tracking bugs and enhancement requests primarily. Please make sure to include information about your installation to make it easier to help: Which version do you use? Did it work before? New installation? How was it installed? Which OS? etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21830] New: error stopping log in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21830 Bug ID: 21830 Summary: error stopping log in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: lai...@manaia.school.nz QA Contact: testo...@bugs.koha-community.org Hi there, I am thinking that we may have a bug. The following error is coming up when we try to log in to our system. Could you please let us know how to correct this? DBIx::Class::Storage::DBI::dbh(): DBI Connection failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1253. at /usr/share/koha/lib/Koha/Database.pm line 90 Compilation failed in require at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 32. BEGIN failed--compilation aborted at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 32. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21282] Ordered/spent lists should use prices including tax for calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 --- Comment #10 from Martin Renvoize --- Totally agree, thanks for adding the release note to clarify the change/correction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21740] Fixed-length fields show _ instead of @ when editing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21740 Andreas Roussos changed: What|Removed |Added Summary|Fixed-lenght fields show _ |Fixed-length fields show _ |instead @ when editing |instead of @ when editing |subfields |subfields CC||arouss1...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #52 from Martin Renvoize --- With all the followups this is looking solid to me now.. I'd happily add a second QA stamp to the whole set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 --- Comment #10 from David Gustafsson --- (In reply to Martin Renvoize from comment #9) > (In reply to David Gustafsson from comment #7) > > Another thing that I also think has been brought up is that there perhaps > > should be added some defaults for fields that should be concatenated, like > > author and full title. This could perhaps be handled in a follow up patch > > though. > > See the last patch on bug 19365, does this cover the defaults scenario? It seems to use the new syntax, but for me it seems a little bit odd to categorically concatenate all the subfield for most fields. That defeats the purpose of the special syntax (to just concatenate the subfields where it makes sense to do so, when the result will be something like full title, or full author name like in the previous examples). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #28 from Nick Clemens --- If no adjustments are made and 'Update holds' is clicked then any waiting holds are reverted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #27 from Nick Clemens --- Created attachment 82322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82322&action=edit Bug 21608: Add ID and fix filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #26 from Nick Clemens --- (In reply to Marcel de Rooy from comment #25) > Oops forgot this suggestion: > Rename: Revert found status => Revert waiting status This affects 'In-transit' holds too, I will add an id to the button > And two functional questions: > Should someone be informed about this revert? > Or should we make the button preference controlled ? I think yes, on both of these, however, we are restoring behvaiour (buggy, but existing) so it should be a new report > Have fun ! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 --- Comment #9 from Martin Renvoize --- (In reply to David Gustafsson from comment #7) > Another thing that I also think has been brought up is that there perhaps > should be added some defaults for fields that should be concatenated, like > author and full title. This could perhaps be handled in a follow up patch > though. See the last patch on bug 19365, does this cover the defaults scenario? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #92 from Nick Clemens --- (In reply to Katrin Fischer from comment #91) > Created attachment 82321 [details] [review] > Bug 15836: Remove deprecated subroutines > > It will take too much time to fix the failures here, given the > simplicity of the subroutines I would be in favor of deleting them and > continue the move on a separate bug report to use Koha::Object-objects > > Signed-off-by: Katrin Fischer > I've checked that everything removed is no longer in use. Last two patches pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Katrin Fischer changed: What|Removed |Added Attachment #82319|0 |1 is obsolete|| --- Comment #91 from Katrin Fischer --- Created attachment 82321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82321&action=edit Bug 15836: Remove deprecated subroutines It will take too much time to fix the failures here, given the simplicity of the subroutines I would be in favor of deleting them and continue the move on a separate bug report to use Koha::Object-objects Signed-off-by: Katrin Fischer I've checked that everything removed is no longer in use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 82320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82320&action=edit Bug 21777: (QA follow-up) Fix colspan in the footer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 --- Comment #1 from Arturo --- In looking at the HTML source of the generated e-mail notice, it's actually just spitting out "<>" rather than "<>". That's just how my browser and e-mail client displayed the output, assuming it was an (invalid) HTML element. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738
--- Comment #7 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #6)
> I am wondering if we should not move
> $canReserve->{status} //= ''
> from reserve/request.pl to CanBookBeReserved
>
> That will make the calls to CanBookBeReserved safe.
>
> Kyle, what are your thoughts about that?
Yes, that sounds like a good idea to me!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] New: Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829
Bug ID: 21829
Summary: Date displays as a datetime in notices
Change sponsored?: ---
Product: Koha
Version: 17.11
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Notices
Assignee: koha-bugs@lists.koha-community.org
Reporter: libr...@sll.texas.gov
QA Contact: testo...@bugs.koha-community.org
The borrowers.dateexpiry field is a date, not a datetime, yet when it is used
in a notice like MEMBERSHIP_EXPIRY, it displays as a datetime by default with
the "12:00 AM" time ("MM/DD/ 12:00 AM").
Bug 13622 added the option to strip times from datetimes by using a "dateonly"
placeholder like so: <>, but if you use this
option on borrowers.dateexpiry, it fails -- probably because the field is not a
datetime?
<> outputs "MM/DD/ 12:00 AM".
<> outputs "<>" (a left-angle bracket followed
by right-angle bracket).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Attachment #82318|0 |1 is obsolete|| --- Comment #90 from Jonathan Druart --- Created attachment 82319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82319&action=edit Bug 15836: Remove deprecated subroutines It will take too much time to fix the failures here, given the simplicity of the subroutines I would be in favor of deleting them and continue the move on a separate bug report to use Koha::Object-objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #89 from Jonathan Druart --- Created attachment 82318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82318&action=edit Bug 15836: Remove deprecated subroutines It will take too much time to fix the failures here, given the simplicity of the subroutines I would be in favor of deleting them and continue the move on a separate bug report to use Koha::Object-objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #88 from Jonathan Druart --- Created attachment 82317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82317&action=edit Bug 15836: Fix failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #2 from Kyle M Hall --- Created attachment 82316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82316&action=edit Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #245 from David Gustafsson --- (In reply to Martin Renvoize from comment #243) > Fantastic effort everyone.. thank you all for the perseverance and continual > refinement of these patches and responses to feedback! > > I have added the Sponsored-by lines to each of the followup patches and > added two very very minor QA followups. > > Passing QA, again, well done and thank you to everyone involved! Great! I replied regarding the missing documentation for concatenation in bug 21331 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331#c7). Have not yet had time to look into it as perhaps need to create a new section for mappings.yaml in the Online manual. But agree this should be addressed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 --- Comment #8 from David Gustafsson --- Oops, I thought I responded in bug 19893, and were referring to the discussion in that issue. Will link to this comment in that issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21331] [Elasticsearch] Concatenated subfields are not indexed correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21331 David Gustafsson changed: What|Removed |Added CC||glask...@gmail.com --- Comment #7 from David Gustafsson --- (In reply to Martin Renvoize from comment #6) > The functionality here indeed appears to have been folded into bug 19893 so > I'm marking as RESOLVED DUPLICATE. > > However, it does rely on updated available configuration options which > should be documented somewhere. > > Fields may now be properly concatenated by specifying them within brackets > `()`... Marking as 'Manual' to bring a maintainers attention. Thanks! This has been brought up before in this issue and agree this needs to be fixed. I failed to find any existing section for the mappings.yaml format in the Koha Online manual where this could be put, but I just took a quick glance. Another thing that I also think has been brought up is that there perhaps should be added some defaults for fields that should be concatenated, like author and full title. This could perhaps be handled in a follow up patch though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] New: Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Bug ID: 21828 Summary: Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The routine iterates through all fields in a biblio and compares them to a list of acceptable tags that may link to an authority. It may be more efficient to do the opposite iteration, working through acceptable authority tags and looking for the existence of that field in the biblio. (Note.. I've not tested this hypothesis.. it depends heavily on how efficient it is to fetch a single MARC tag using Marc::Record) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #79 from Jonathan Druart --- Patches rebased: https://gitlab.com/joubu/Koha/commits/bug_15774 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Martin Renvoize --- I'd really like to see some minimal test coverage adding for the change to C4::LinkBibHeadingsToAuthorities here before I feel I can pass qa. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #42 from Martin Renvoize --- We've fallen at the last hurdle here I'm afraid.. we need some updated/additional unit tests to cover the changes.. at a minimum Koha:: namespace changes, but I'd really love to see some minimal coverage of C4::Biblio added for the affected method too... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21516] Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood changed: What|Removed |Added Attachment #82309|0 |1 is obsolete|| --- Comment #4 from Andrew Isherwood --- Created attachment 82315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82315&action=edit Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of . To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21827] New: koha-mysql does not recognize non-standard port
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21827 Bug ID: 21827 Summary: koha-mysql does not recognize non-standard port Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net The koha-mysql script provided with the Debian package currently does not check the element in koha-conf.xml. Consequently, if one uses a non-standard port number for MySQL, koha-mysql cannot connect to the database even though Koha itself can. Teaching koha-mysql how to pass --port to the mysql command would fix it. I note that if/when the patches for bug 11974 make it in, it would be useful to also teach koha-mysql how to pass --socket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21516] Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21516] Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood changed: What|Removed |Added Attachment #80209|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added Depends on||21826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 [Bug 21826] Automatic authority record generation improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Martin Renvoize changed: What|Removed |Added Blocks||19365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ere.maij...@helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #82307|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added Attachment #82303|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 82312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82312&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added Attachment #82305|0 |1 is obsolete|| --- Comment #41 from Martin Renvoize --- Created attachment 82314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82314&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize changed: What|Removed |Added Attachment #82304|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 82313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82313&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Signoff carried across from bug 19365 where it has been extracted from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 --- Comment #2 from Martin Renvoize --- Created attachment 82311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82311&action=edit Bug 21826: (QA follow-up) Add UNIMARC support Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 --- Comment #1 from Martin Renvoize --- Created attachment 82310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82310&action=edit Bug 21826: Use subfield map in LinkBibHeadingsToAuthorities Use only allowable subfields when creating authorities from bibliographic records. Signed-off-by: Brendan Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21516] Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 --- Comment #3 from Owen Leonard --- Created attachment 82309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82309&action=edit Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of . To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21516] Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #87 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21782] Release team 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] New: Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Bug ID: 21826 Summary: Automatic authority record generation improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Whilst QAing bug 19365 I saw that some general improvements had been made to the generation of authorities from bibliographic records routines. I felt these should get their own mention in the release notes and so have split them out into this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Jonathan Druart --- You have local changes: error: Your local changes to the following files would be overwritten by merge: C4/Letters.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21823] Cannot update or create translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_11_candidate CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21825] New: UNIMARC Authority subfields missing 'u'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21825 Bug ID: 21825 Summary: UNIMARC Authority subfields missing 'u' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Whilst QAing bug 19365 I spotted that the subfields string contains all of the alphabet except for 'u' and I wondered whether this was deliberate or a mistake? When asking the question on IRC it sounded as though subfield 'u' may well be used but we wanted to defer to some more expert cataloguers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738
Jonathan Druart changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--- Comment #6 from Jonathan Druart
---
I am wondering if we should not move
$canReserve->{status} //= ''
from reserve/request.pl to CanBookBeReserved
That will make the calls to CanBookBeReserved safe.
Kyle, what are your thoughts about that?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #1 from Kyle M Hall --- Created attachment 82308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82308&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21823] Cannot update or create translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 Tomás Cohen Arazi changed: What|Removed |Added CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #38 from Martin Renvoize --- Created attachment 82307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82307&action=edit Bug 19365: (QA follow-up) Add UNIMARC support Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21823] Cannot update or create translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 --- Comment #1 from Julian Maurice --- Created attachment 82306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82306&action=edit Bug 21823: Force creation of POT file even if there is no messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21823] Cannot update or create translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] New: Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bug ID: 21824 Summary: Add ability to format dates in various formats in templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Since enabling template toolkit for notices we have found we are trying to do date comparisons and more advanced manipulations. We have been using 'manip' but this is complicated. We should build in some utils to allow for more advanced formatting and comparison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571 Hugo Agud changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Hugo Agud --- 80656 - Bug 21571: Make ACCTDETAILS translatable Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21571: Make ACCTDETAILS translatable Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: Your local changes to the following files would be overwritten by merge: C4/Letters.pm Please, commit your changes or stash them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 21571: Make ACCTDETAILS translatable The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21571-Make-ACCTDETAILS-translatable-hKZVxD.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21823] New: Cannot update or create translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 Bug ID: 21823 Summary: Cannot update or create translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Bug 15395 broke the translations handling process. Steps to reproduce: - Run: $ kshell k$ cd misc/translator k$ perl translate update fr-FR => FAIL: You get an error: system call failed: /bin/sed --in-place /home/vagrant/kohaclone/misc/translator/Koha.pot --expression='s/charset=CHARSET/charset=UTF-8/' at /home/vagrant/kohaclone/misc/translator/LangInstaller.pm line 655. - Create a new set of language translation files: k$ perl translate create xx-YY => FAIL: You get an error: /bin/sed: can't read /home/vagrant/kohaclone/misc/translator/Koha.pot: No such file or directory system call failed: /bin/sed --in-place /home/vagrant/kohaclone/misc/translator/Koha.pot --expression='s/charset=CHARSET/charset=UTF-8/' at /home/vagrant/kohaclone/misc/translator/LangInstaller.pm line 655. Note: the translation files get updated/generated, but the error breaks any automatic pipeline. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 [Bug 21823] Cannot update or create translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21823] Cannot update or create translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21823 Tomás Cohen Arazi changed: What|Removed |Added Depends on||15395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Jonathan Druart changed: What|Removed |Added Blocks||21738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 [Bug 21738] [ILS-DI] error while holding a title without item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Jonathan Druart changed: What|Removed |Added Depends on||15524 --- Comment #5 from Jonathan Druart --- This is a regression since 18.05, we need it into 18.11 Caused by commit 5f485e476b2c5521d59bda6d48b56ed36cff3f86 Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Attachment #82283|0 |1 is obsolete|| --- Comment #36 from Ere Maijala --- Created attachment 82304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82304&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Attachment #82284|0 |1 is obsolete|| --- Comment #37 from Ere Maijala --- Created attachment 82305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82305&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Attachment #82282|0 |1 is obsolete|| --- Comment #35 from Ere Maijala --- Created attachment 82303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82303&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21809] Deleting a request does not delete its log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21809 --- Comment #2 from Andrew Isherwood --- illrequests.illrequest_id is an auto_increment column, which is inline with the vast majority of primary key columns in Koha. Googling around suggests that MySQL/MariaDB shouldn't reuse deleted values in auto_increment columns, which was always my understanding also. However, I'm seeing log entries associated with requests where the log entries are dated before the request was created. My assumption was that IDs were being re-used, though, I have failed to replicate that behaviour. So perhaps the problem is not caused by that after all. I believe though that the bug is still valid. If a request is deleted, its log entries should be also. Due to the inability to create a foreign key on action_logs.object (due it potentially referring to many different keys), and therefore the inability to create a cascade, I believe we should do this cleanup manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #84 from Jonathan Druart --- Created attachment 82300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82300&action=edit Bug 15836: Fix deletion of class sources -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #86 from Jonathan Druart --- Created attachment 82302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82302&action=edit Bug 15836: (follow-up) Fix display input in any situations Koha::ClassSplitRule->regexs returns an array -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #81 from Jonathan Druart --- Created attachment 82297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82297&action=edit Bug 15836: Fix DB structure That was a leftover from the first approach, this table must not be modified! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #74 from Jonathan Druart --- Created attachment 82290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82290&action=edit Bug 15836: UI changes The script admin/classsources.pl has been adjusted to follow usual patterns used in other Koha scripts. $op can be add_source, add_source_validate, etc. Deletion steps have been removed (there is a JS confirmation box) to simplify both script and template. Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836
--- Comment #75 from Jonathan Druart
---
Created attachment 82291
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82291&action=edit
Bug 15836: Add the ability to defined custom methods to split call number in
labels
Currently the call number splitting seems to be mostly implemented for
DDC and LC classifications.
Those are both not very common in some countries.
A lot of libraries use their own custom classification schemes so the call
number
plitting is something that should be individually configurable.
This enhancement adds the ability to define custom splitting rules based
on regular expressions.
How does it work so far?
From C4/Labels/Label.pm there are 3 differents splitting methods defined,
depending on items.cn_source.
if cn_source is "lcc' or 'nlm' we split using Library::CallNumber::LC
if cn_source is 'ddc' we split using a in-house method
Finally there is a fallback method to split on space
And nothing else is done for other cn_source
The idea of this patch is to mimick what was done for the "filing rules" and
add
the ability to define "splitting rules" that will be used by the
"Classification sources".
A classification source will then have:
* a filing rule used to sort items by callnumbers
* a splitting rule used to print labels
To acchieve this goal this enhancement will do the following
modifications at DB level:
* New table class_split_rules
* New column class_sources.class_split_rule
Test plan:
* Execute the update database entry to create the new table and
column.
I. UI Changes
a) Create/modify/delete a filing rule
b) Create/modify/delete a splitting rule
c) Create/modify/delete a classification source
=> A filing rule or splitting rule cannot be removed if used by a
classification source
II. Splitting rule using regular expressions
a) Create a splitting rule using the "Splitting routine" "RegEx"
b) Define several regular expressions, they will be applied one after
the other in the same order you define them.
Something like:
s/\s/\n/g # Break on spaces
s/(\s?=)/\n=/g# Break on = (unless it's done already)
s/^(J|K)\n/$1 / # Remove the first break if callnumber starts with J or K
c) You can test the regular expressions using filling the textarea with
a list of callnumbers. Then click "Test" and confirm the callnumbers are
split how you expected.
d) Finally create a new classification source that will use this new
splitting rule.
III. Print the label!
a) Create a layout. It should have the "Split call numbers" checkbox
ticked, and display itemcallnumber
b) Use this layout to export labels, use items with different
classification source ('lcc', 'ddc', but also the new one you have
create)
=> The callnumbers should have been split according to the regex you
defined earlier!
Notes:
* The update database entry fill the class_sources.class_split_rule
with the value of class_sources.class_sort_rule
If default rules exist it will not work, we should add a note in the
release notes (would be enough?)
* C4::ClassSplitRoutine::* should be moved to Koha::ClassSplitRule,
but it sounded better to keep the same pattern as ClassSortRoutines
* Should not we use a LONGTEXT for class_split_rules.split_regex instead
of VARCHAR(255)?
* class_sources.sql should be filled for other languages before pushed
to master!
IMPORTANT NOTES: The regular expressions are stored as it, and eval is
used to evaluate it (perlcritic raises a warning about it (Expression
form of "eval"). It can lead to serious security issues (execution of
arbitrary code on the server), especially if the modifier 'e' is used.
We could then remedy the situation with one of these following points:
- Assume that this DB data is safe (We can add a new permission?)
- Assume that the data is not safe and deal with possible attack
Cons: how be sure we are exhaustive? Making sure it matches ^s///[^e/]*$
would be enough?
- Use Template Toolkit syntax instead (Really safer?)
[% callnumber.replace('\s', '\n').replace ... %]
- Cut the regex parts: find, replace, modifiers
like we already do for Marc modification template. Cons: we are going to
have escape problems, the "find" and "replace" parts should not be
handle the same way (think "\n", "\\n", "\1", "\s", etc.)
I did not manage to implement this one easily.
Sponsored-by: Goethe-Institut
Signed-off-by: Christian Stelzenmüller
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #77 from Jonathan Druart --- Created attachment 82293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82293&action=edit Bug 15836: Add tests Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Attachment #81627|0 |1 is obsolete|| Attachment #81629|0 |1 is obsolete|| Attachment #81630|0 |1 is obsolete|| Attachment #81631|0 |1 is obsolete|| Attachment #81632|0 |1 is obsolete|| Attachment #81633|0 |1 is obsolete|| Attachment #81634|0 |1 is obsolete|| Attachment #81635|0 |1 is obsolete|| Attachment #82118|0 |1 is obsolete|| Attachment #82119|0 |1 is obsolete|| Attachment #82120|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart --- Created attachment 82289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82289&action=edit Bug 15836: DB changes Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #78 from Jonathan Druart --- Created attachment 82294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82294&action=edit Bug 15836: Add missing svc script Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #80 from Jonathan Druart --- Created attachment 82296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82296&action=edit Bug 15836: Fix display input in any situations Fix when switching an existing rule to RegEx Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #76 from Jonathan Druart --- Created attachment 82292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82292&action=edit Bug 15836: Mark C4::ClassSource subs DEPRECATED These subs are no longer used from scripts and should be removed. It should be done on a separate bug report given that additional work is needed Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #83 from Jonathan Druart --- Created attachment 82299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82299&action=edit Bug 15836: (follow-up) Fix filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #82 from Jonathan Druart --- Created attachment 82298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82298&action=edit Bug 15836: DBIC Schema change Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #79 from Jonathan Druart --- Created attachment 82295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82295&action=edit Bug 15836: Handle non-existent regexs For other types of split rules Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
